Issue 2

16th April 2006 by Danny Allen

This Week...

Furious activity in Digikam, KmPlot and amaroK. Compile and linking fixes for applications in /trunk with CMake. Multi-platform porting fixes. KSmileTris is removed from /trunk/KDE/kdegames/.
The upcoming KDE 4 era heralds many changes, and one of those is the introduction of a new build system: CMake. People following KDE 4 development may at this point be asking what happened to SCons, the build system previously championed as the solution to the current autotools-based build system kludge. Well, with the understanding that CMake is not just a renamed SCons, KDE 4 must have chosen a different solution somewhere along the way...
Alexander Neundorf explains the reasoning behind the change:
scons was chosen at akademy, and people started to work on it.

But after months of work we ended up basically with a fork of scons.

So apparently scons wasn't the best tool for the job.

...

CMake needed some enhancements mainly for the windows stuff (we are probably the first project which uses mingw heavily). The cmake developers have been very supportive for KDE, they are on the buildsystem mailinglist and fixed the issues we found within days. They want cmake to become the buildsystem for KDE 4.
Thomas Nagy clarifies:
Not a fork but an experimental branch.
Followed by a round-up from Thiago Macieira:
We had basically no relationship with the scons maintainers. None of our changes were applied upstream.

One of the reasons, at least, was to maintain compatibility with an old Python version. By dropping that compatibility, we made some progress, but created a fork.
Of course, the introduction of any significant change is going to take a while to get used to, as Aaron Seigo noted:
the introduction of cmake, however, has redefined "waste of time" for me.

...

between how much slower cmake is and the constant breakages that i have no idea how to fix (like the NOGUI in kdesu/kdesud/CMakeLists.txt not working, even though i have the latest cmake modules installed from kdelibs that seem to include something about it) i really, really, really hope that it improves dramatically over the next month. we don't need a build system holding us back. i understand the need for something better than autotools, but in my book the baseline for "better" is "actually builds reliably". meh.
However, CMake does have at least some supporters within the KDE camp. Boudewijn Rempt likes it for, amongst other things, its ability to compile KOffice trunk, whilst Adriaan de Groot comments:
Aaron's right in some ways. With auto*, there is this huge collected cloud of knowledge about how things work and you can shout out on lots of IRC channels when something's wrong. Anyway, it's all shell script and anyone can write shell script, right? Therein lies both the power and the failing of auto* -- it's hard to write correct shellscript (svn log doxygen.sh for my stumblings), but whacking something into shape isn't that hard.

With CMake, I get the feeling that there's only a very few gurus who know what is going on (Alex, David, and of course William Hoffmann on -core-devel). Whining often leads to fixes of a mysterious nature. But waiting for osmosis to somehow bring enough knowledge to developers is a slow process. The wiki page has some information, but it's mostly about using CMake under ideal conditions, as opposed to fixing it when it's broke.

...

I believe Aaron's point on CMake is that a build system shouldn't get in the way, and if CMake breaks right now and keeps him from working on whatever it is he does, those are valuable wasted hours. autofoo had progressed to a point that it didn't regularly get in the way of developers on KDE's UNIX-like platforms. CMake does get in the way, since it's still being broken. For the -- presumably many -- people who do not want to be build-system guru's, the system just has to work. That goes double for external tools that use the build system, like Coverity's static checking.

Now I'm done being annoyed for CMake getting in the way, though, I can get on with loving it for the things that it does right.
...and finally, Aaron Seigo comes over to the CMake side:
so... moving away from autohell was probably a good idea. cmake was probably our best choice. and it's currently a painful process. i don't like losing days of productivity to it, and i really don't like the thought of others going through the same. but...

...i'm fairly confident that it'll work out in the end; i have great faith in the people who work on this project. we're not "in the end" yet, more in the middle. and along the way i think it is healthy to discuss what is working and what isn't working along the way.
The acceptance and adoption of CMake can be seen with the many commits this week regarding the porting of existing KDE apps to KDE 4. See below for specific examples of this activity.
Tom Albers announces version 0.6.0 of RSIBreak, a utility to help prevent Repetitive Strain Injury:
About RSIBreak

Repetitive Strain Injury is an illness which can occur as a result of working with a mouse and keyboard. This utility can be used to remind you to take a break now and then. It will show you a random picture from a collection you can configure yourself for a configurable duration at a configurable interval.

You can use these breaks to do some stretch exercises for example, or as a reminder to walk away from the computer for a while.

RSIBreak will sit in your system tray and when it is time for a break it will show you the picture full screen. All timings can be set by clicking with the right mouse button on the icon in the system tray.

Version 0.6.0 Changelog:
  • Extensive amount of statistics.
  • Colors to indicate how far away you are from a break in the tooltip
  • libxss for the idle detection is a no longer optional, it is required.
  • RSIBreak remembers the timer states when you quit. It can restore the timers if you restart RSIBreak afterwards in a short timeframe. This is handy for rebooting (for those zealots who believe rebooting solves problems).
  • Bug fixes:
    • For Gnome there were two Quit entries in the context menu.
    • Welcome message on first launch was incorrect.
    • Compiles with KDE 3.3 and probably with gcc 2.9x.
    • Memory leak while querying idle time.
    • Some buddies in the setup were not set.
    • Some i18n calls in the setup were not correct.
    • Clear focus from buttons to prevent accidental closure of a break.
To find out more information about RSIBreak, and to download packages for your distribution, go to http://www.rsibreak.org
Congratulations to Thomas Zander, who managed to close a massive 91 bugs in KOffice this week. As he says:
So, if you want to get your name in the new commit-digest, take a look at the junior jobs page and help us out!
I couldn't agree more!

Statistics

Commits 2636 by 212 developers, 5981 lines modified, 886 new files
Open Bugs 12107
Open Wishes 10590
Bugs Opened 349 in the last 7 days
Bugs Closed 313 in the last 7 days

Commit Summary

Module Commits
/trunk/KDE
716
 
/trunk/www
421
 
/trunk/l10n
308
 
/trunk/extragear
264
 
/trunk/koffice
185
 
/branches/stable
150
 
/branches/KDE
128
 
/branches/work
121
 
/trunk/playground
104
 
/branches/koffice
84
 
Lines Developer Commits
284
 
Laurent Montel
143
 
269
 
David Faure
111
 
177
 
Dirk Mueller
83
 
157
 
Gilles Caulier
70
 
217
 
Luboš Luňák
58
 
107
 
Frans Englich
41
 
85
 
Volker Krause
40
 
79
 
Albert Astals Cid
37
 
76
 
Mark Kretschmann
37
 
83
 
Stefan Nikolaus
36
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
99.99%
 
Danish (da)
99.12%
 
Swedish (sv)
99.04%
 
French (fr)
95.1%
 
Spanish (es)
94.78%
 
Italian (it)
94.51%
 
Estonian (et)
93.94%
 
Dutch (nl)
93.55%
 
Greek (el)
93.38%
 
British English (en_GB)
92%
 

Bug Killers and Buzz

Person Bugs Closed
Thomas Zander
91
 
Tommi Tervo
31
 
Thiago Macieira
17
 
Olivier Goffart
14
 
Luboš Luňák
12
 
Mark Kretschmann
12
 
Seb Ruiz
11
 
Julian Seward
10
 
Charis Kouzinopoulos
8
 
Jens Dagerbo
8
 
Program Buzz
amaroK
2215
 
K3B
1079
 
Kopete
1069
 
Kate
759
 
KMail
691
 
SuperKaramba
666
 
Kontact
589
 
Kicker
566
 
KDevelop
540
 
Quanta
355
 
Person Buzz
zogje
397
 
Aaron J. Seigo
371
 
George Staikos
352
 
pipitas
291
 
Stephan Kulow
290
 
Zack Rusin
281
 
David Faure
276
 
riddell
236
 
telex
210
 
boud
190
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    []

Educational

[] [] []   []

Graphics

[] []    

KDE Base

[] [] [] []  

KDE-PIM

[] [] []   []

Office

[] [] []   []

Konqueror

[] [] []   

Multimedia

[] [] []   

Networking Tools

[] [] []   []

User Interface

     

Utilities

[] []    []

Games

[] []    

Other

     

There are 131 selections this week

Bug Fixes

Development Tools

Matt Rogers committed changes in /trunk/KDE/kdevelop:

don't crash when deleting the designer window. Instead, crash in
kdelibs instead. :)

Dirk Mueller committed changes in /trunk/qt-copy/patches-src:

reviewed another 50 coverity reports

Educational

Andreas Nicolai committed changes in /branches/KDE/3.5/kdeedu/ktouch:

KTouch - fixed wrong keyboard layouts

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 528092
David Saxton committed changes in /trunk/KDE/kdeedu/kmplot/kmplot:

Fixed validator on parametric input edit (was ignoring the parametric
equations' prefixes).

Diffs: 1, 2, 3, 4, 5 Revision 528862
David Saxton committed changes in /trunk/KDE/kdeedu/kmplot:

Fixed remaining issues on EBN.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 528960

Graphics

Gilles Caulier committed changes in /trunk/extragear/graphics/digikam/utilities/cameragui:

digikam from trunk: Camera Rename Customizer bug fix: If 'Add Sequence Number' and 'Add Date Time' are unselected, the customize filename have non-sence because all target files to download will have all the _same_ filename. Also, camera GUI will ask to user is target must be overwritted!

This commit fix the problem to use a Combo Box options list instead separate Check Box. Like this at least one option will be used if user want a customized renaming.

Stephan Kulow committed changes in /branches/KDE/3.5/kdegraphics/kamera/kioslave/kamera.cpp:

ForwardingSlave simply invents mimetypes if there are none
(for whatever reason). So give them a mimetype so konqueror
is not confused between application/octet-stream and S_IFDIR

Gilles Caulier committed changes in /trunk/extragear/graphics/digikam/utilities/imageeditor/canvas/dimginterface.cpp:

digikam from trunk : patch from Paco about screen ICC color profile rules.

The implemented have been fixed about a crash generated by in DImg::convertToPixmap() witch return a null Pixmap.

The code isn't optimized : ICC color profile files are loaded from disk at each pixmap computation. better way is to load these files at Image Editor startup, store like bytes array into memory, and use it when we want.

Gilles Caulier committed changes in /trunk/extragear/graphics/digikam:

digikam from trunk : reverse RAW file generator source code about thumbnail rotation. I suspect a problem in this code witch broke CR2 file thumbs and don't rotate properly thumbs (certainly some camera tags orientation flags without respect TIFF/EP spec).

Alternative solutions for the future :

1 / using future libopenraw library from freedesktop.org (http://www.freedesktop.org/wiki/Software_2flibopenraw)
2 / using Exiv2 thumbs extractor when TIFF/EP will be finalized (my prefered way (:=)))

Diffs: 1, 2, 3, 4 Revision 530066

KDE Base

Daniel Teske committed changes in /branches/KDE/3.5/kdebase/konqueror/keditbookmarks/actionsimpl.cpp:

Fix commandline export.

BUG: 125165

Rohan McGovern committed changes in /branches/KDE/3.5/kdebase/kwin/kompmgr/kompmgr.c:

Fix bug where 'fade out' setting was always used for fading between opacities, even if we were actually fading in. Also committed to KDE 4.

Luboš Luňák committed changes in /trunk/KDE/kdelibs/kdesu:

Handle even su that doesn't write "<whatever>:" - looks like in China
they have a different colon than we do.

Stephan Kulow committed changes in /branches/KDE/3.5/kdelibs/kio/kiocppcpp:

guessing mimetypes just for the sake of it is wrong
(especially for directories that become octet-streams)
and slow.

Allan Sandfeld Jensen committed changes in /branches/KDE/3.5/kdelibs/khtml/xml/dom_stringimpl.cpp:

The XML parser lets \t through. For now just rewrite them to spaces, because
otherwise Qt print them as boxes.

Brad Hards committed changes in /trunk/kdesupport/qca/unittest/cms/cms.cpp:

OK, it turns out that when you reset(), you have
to put the keys/certs back in. With that, it stops
asserting. Then it just fails to compare the messages.
If you encrypt the same data, with the same certs,
twice, you don't get the same result each time.

So I added the decrypt part, including re-use, and
checked that if you encrypt the same data twice, then
each decrypt produces the same result, and that result
is exactly what you started with. The test now passes.

David Faure committed changes in /trunk/KDE/kdebase/kdesu/kdesud:

Fix compilation on Mac OS X

David Faure committed changes in /:

Fix build on Mac OS X but not using ksocks.h in the kcontrol module
(the problem was kde_socklen_t but Thiago suggested this solution, to avoid using ksocks.h altogether)

Diffs: 1, 2, 3 Revision 529081
David Faure committed changes in /trunk/KDE/kdelibs:

Moved out the 4 values from config.h that depend on the installation prefix,
so that changing the prefix doesn't mean recompiling -all- of kdelibs, only
a few files. One more step towards modular config-foo.h files.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 529149
Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/kicker/libkicker/kickertip.cpp:

forward port fix for fullscreen windows and kickertips showing anyways
with autohide panels

Thorsten Roeder committed changes in /trunk/KDE/kdebase/workspace/kwin/rules.cpp:

unbreak compilation with gcc-3.3. As stated on k-c-d gcc-3.3 should be supported for now.

Sebastian Kügler committed changes in /trunk/playground/base/guidance:

BUG: Changing an user's password can change another password for a different
user (Malone bug #39444)

Diffs: 1, 2, 3 Revision 529443
Luboš Luňák committed changes in /trunk/KDE/kdebase/workspace:

Forwardport of r451134 . Doing it so long after had been committed
to 3.5 branch was certainly a lot of fun.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision 529470
Dirk Mueller committed changes in /branches/KDE/3.5/kdelibs:

backport various coverity fixlets

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 529483
Dirk Mueller committed changes in /trunk/KDE/kdelibs/kdeui/kmessagebox.cpp:

when checking the "don't show again" box and then pressing Yes,
remember "Yes", not "No". Everything else doesn't seem to make
sense to me.

Allan Sandfeld Jensen committed changes in /branches/KDE/3.5/kdelibs/khtml/xml/xml_tokenizer.cpp:

Missing file in no-namespace commit.
Default to no namespace in XML rather than to XHTML

Luboš Luňák committed changes in /branches/KDE/3.5/kdebase/kwin:

Ok, I've had enough with Alt+Tab and mouse focus policies:
- use click to focus or focus follows mouse and I'll be fine
- with the remaining unreasonable focus policies only the CDE-style
tabbox works that raises and lowers windows and ignores
keep above/below windows
- if you don't like that, provide a patch for kwin/tabbox.cpp
- tabbox should be completely redesigned for KDE4
BUG: 123890
CCBUG: 105263
CCBUG: 84424

Diffs: 1, 2, 3 Revision 528225
Aaron J. Seigo committed changes in /branches/KDE/3.5/kdebase/kicker/taskbar/taskcontainer.cpp:

use the same icon as on the button (the last task in the group's icon)
for eagle eye bart.

Ralf Habacker committed changes in /trunk/KDE/kdebase/libkonq/konq_operations.cc:

don't use KAutoMount, it isn't available on win32

Allan Sandfeld Jensen committed changes in /branches/KDE/3.5/kdelibs/khtml/css/html4.css:

Lower-case tags so it actually works with XHTML.
Regressed because namespaces actually work now.

Stephan Kulow committed changes in /branches/work/coolos_media/mediamanager/halbackend.cpp:

the floppy case is worse than expected. But now it really works:
we have to stress KMountPoint a bit as hal is completly useless
for floppies and we can't easily integrate the fstab backend.

Luboš Luňák committed changes in /branches/work/kdelibs4_snapshot/kdecore:

Handle X timestamp wrapping correctly even on 64bit platforms.

Diffs: 1, 2, 3, 4 Revision 528575
Luboš Luňák committed changes in /trunk/KDE/kdebase/workspace/kwin:

Ok, I've had enough with Alt+Tab and mouse focus policies:
- use click to focus or focus follows mouse and I'll be fine
- with the remaining unreasonable focus policies only the CDE-style
tabbox works that raises and lowers windows and ignores
keep above/below windows
- if you don't like that, provide a patch for kwin/tabbox.cpp
- tabbox should be completely redesigned for KDE4
(#123890,#105263,#84424)

Diffs: 1, 2, 3, 4 Revision 528579
Luboš Luňák committed changes in /branches/KDE/3.5/kdebase/kwin/geometry.cpp:

One more of "When a window resizes, first try to keep it inside its xinerama screen."

Luboš Luňák committed changes in /branches/KDE/3.5/kdebase/kwin:

Separate focus chains are nice, but KDE-style Alt+Tab not limited
to the current desktop still needs the global one for MRU.
BUG: 124721

Diffs: 1, 2, 3, 4 Revision 528608
Jonathan Riddell committed changes in /branches/KDE/3.5/kdelibs/pics/hicolor/index.theme:

Revert previous two commits. For the second time.
hicolour is not a theme, it is a namespace for third party icons.

KDE-PIM

David Jarvie committed changes in /trunk/KDE/kdepim/doc/kalarm/index.docbook:

Allow system tray icon to appear in non-KDE window managers (Bug 123651)

Marco Gulino committed changes in /trunk/playground/pim/kmobiletools/kmobiletools/engines/at_engine:

Fixing PDU decoding, checking if it is an incoming or an outgoing SMS.
This should fix a lot of problems, with outgoing sms, so please upgrade, test, and report.

Diffs: 1, 2, 3 Revision 528794
Tom Albers committed changes in /trunk/KDE/kdepim/doc:

This fixes the issues reported by the docbook sanitizer found at EBN for kdepim. I fixed all issues which were raised at the kde-pim mailinglist. One of the changes involved a new entity, so it will only 'compile' with the latest entities installed. (cp $svn/kdelibs/kdoctools/customization/entities/general.entities $prefix/share/appses/general.entities)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 529193

Office

Boudewijn Rempt committed changes in /branches/koffice/1.6/koffice/lib/kotext/KoFontTab.cpp:

Don't hide the font preview -- we want it!

David Faure committed changes in /branches/koffice/1.5/koffice/lib/kotext/KoTextParag.cpp:

Don't draw dashed line over solid line :)

Bart Coppens committed changes in /branches/koffice/1.6/koffice/kword:

Fix typing of accented characters with compositing-like keys for specific accents (like with azerty keyboards) and probably more things like that, in KWord tables.
This is triggered by the immodule patch Debian Unstable has applied to its Qt 3.3.6.
Thomas, David: please check if this is OK, and perhaps backport and forwardport if it is.

Thomas Braun committed changes in /trunk/extragear/office/kile/kile/kile.cpp:

change "&&" to "and" in i18n strings to get the translators less confused and correct spelled tooltips

Bart Coppens committed changes in /branches/koffice/1.5/koffice/kword/KWCanvas.cpp:

Enable the input methods _before_ setting the focus. Should fix the odd bug that some people had where they could not enter accented characters before manually focussing another widget.BUG: 124532

Bart Coppens committed changes in /branches/koffice/1.5/koffice/kword/KWView.cpp:

This was a tricky one: when I tried inputting some japanese text with skim, it wouldn't work in KWord. Turns out that when KWord gets a IMComposite event, it (indirectly) calls this function. That would then unconditionally update that KAction, that then would update a QCombobox to set the current text, and that then would reset the inputcontext on the poor old canvas, thus resulting in a loss of your poor hiragana each time skim would compose one.
I fix this by checking if the fontsize and font family actually changed. Since I assume it won't change in the middle of an IMStart-IMEnd sequence, this fixes the input with me.

From what I understand, this would basically mean that Japanese input would be impossible without this patch. However, I think I recall actually being able to do that in KWord, so I'm inclined to think that it's partially caused by qt-immodule. Anyway, the CCBUG seems related, but I'm going to check this with someone who actually has a real Japanese keyboard (Kiruwa) and maybe close it if he can confirm this a bit better.
CCBUG: 41380

Jarosław Staniek committed changes in /branches/koffice/1.5/koffice/kexi/plugins/importexport/csvcpp:

CSV Import
- fixed problem with importing data with more than 100 columns (for default settings)
1.0/2.0: ported

- only the first 10KiB of data is loaded for the preview by default; can be adjusted
by setting ImportExport/MaximumBytesForPreviewInImportDialog option in kexirc
1.0/2.0: ported

Thorsten Zachmann committed changes in /branches/koffice/1.5/koffice/kpresenter/KPrPage.cpp:

o Fix Bug 125418: Resizing textarea resizes wrong textarea
The problem was that another obejcts was selected when trying to
resize the object. This has be fixed by checking if there is allready
an other object selected at this place.

Thanks for reporting the bug.

BUG: 125418

Thorsten Zachmann committed changes in /branches/koffice/1.5/koffice/kpresenter:

o Fix Bug 125424: When setting slide background to "Use slide master
background", preview is not shown correctly.

Now we show the background of the master in the preview when
"Use slide master background" is selected.

Thanks for reporting this bug.

BUG: 125424

Boudewijn Rempt committed changes in /branches/koffice/1.6/koffice/krita:

BUG: 125433
Fix crash when trying to use tools on layers that cannot be painted on: now we
select the nearest layer that can be painted on (as was my original intention).

Diffs: 1, 2, 3, 4 Revision 529588
Adrian Page committed changes in /trunk/koffice/krita/ui:

Fix the XMLGUI related hang, bringing back a lot of the ui. krita is now usable for painting and things.

Konqueror

Frans Englich committed changes in /trunk/kdenonbeta/kdom/xpath:

* Crystal ball programming: assume Michael Rys' comment #1 in http://www.w3.org/Bugs/Public/show_bug.cgi?id=3097 gets accepted, and align. Basically, s/FORG0006/XPTY0004.
* Improve Doxygen in AggregateFNs.h

Diffs: 1, 2, 3, 4, 5, 6 Revision 528374
Frans Englich committed changes in /trunk/tests/kxpathtests/testsl:

Assume http://www.w3.org/Bugs/Public/show_bug.cgi?id=3097 gets resolved as FIXED, and align accordingly.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 528375
Eva Brucherseifer committed changes in /trunk/kdenox/konq-embed/src/pics/bookmark_goto.png:

- use goto icon in bookmark dialog, bookmark icon can be misinterpreted

Multimedia

Mark Kretschmann committed changes in /trunk/extragear/multimedia/amarok/src:

Disable "Unset Cover Image" for embedded images, since we can't remove them anyway. Patch by Shane King <kde@dontletsstart.com>.

BUG: 125372

Diffs: 1, 2, 3, 4 Revision 528712
Martin Aumüller committed changes in /trunk/extragear/multimedia/amarok/src/mediadevice/vfat:

fix display of free space for devices larger than 4gb

Bart Cerneels committed changes in /trunk/extragear/multimedia/amarok/srccppcpp:

Fix a regression when downloading lugradio episodes.

If anyone notices podcasts with strange url's in the enclosures, please report them to me.

Stephan Kulow committed changes in /branches/KDE/3.5/kdemultimedia/kioslave/audiocd/audiocd.cpp:

nice guess. The chances were just 50:50 to get it right ;)
The difference is 0 for IDE, but noticably for SATA

Gábor Lehel committed changes in /trunk/extragear/multimedia/amarok/src:

start porting the context browser to more properly display ratings
this is very much a work in progress (for one, the default theme should be made to not use stars for the scores, as two rows of them is a bit confusing), but I've been putting it off for far too long.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 529859

Networking Tools

Jan Ritzerfeld committed changes in /branches/kopete/0.12/kopete:

Use the following method to determine the status message to
be displayed (the term "contact" should be read as
"contact of the metacontact" and "online" as "not offline"):
* Display the new status message if
- the new status message is not empty and
- the contact who set it is online or there are no contacts online at all.
* Otherwise display the first non-empty status message among all contacts
online---or offline if there are no contacts online at all.
* If no status message is displayed yet display no status message at all.

BUG: 116614

Olivier Goffart committed changes in /branches/kopete/0.12/kopete/libkopete/private/kopeteemoticons.cpp:

Fix Bug 118689: Incoming emoticons appear unpredictably

BUG: 118689

This was caused because on rich text messages, there is <span> or <p> arround the text, and the > or < was not considered as a space. now it is.

Utilities

Ryan Nickell committed changes in /branches/KDE/3.5/kdeutils/superkaramba/doc/python_api:

Update the script that creates api documentation via robodoc.
Should be more full proof now and leave the existing source files
completely untouched.
Enjoy!

Games

Albert Astals Cid committed changes in /trunk/KDE/kdegames/kolf/CMakeLists.txt:

it seems cmake is not able to deal with lib called kolf and a binary called kolf, so i renamed the lib to kolflib and i can play kolf4 now :-)

Features

Development Tools

Richard Dale committed changes in /trunk/KDE/kdebindings/qtruby:

* Added xml/saxbookmarks, xml/dombookmarks and widgets/tooltips examples
* Improved garbage collection marking, Children QTreeWidgets and
QListWidgets are now marked. QObject tree instances are only marked
starting at an instance which has no parent to improved efficiency,
otherwise the same sub trees would be marked several times as a
traversal is started for each node in the heirarchy.
* The 'type' method in QEvent subclasses now works correctly.
* Added inspect and pretty_print methods to the Qt::WidgetTreeItem class

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 528725
Oliver Kellogg committed changes in /branches/KDE/3.5/kdesdk/umbrello/umbrello:

Implement subsystems for component diagrams.
A subsystem is internally represented by a package with the stereotype <<subsystem>>.
This probably still has some rough egdes. Please test and leave your comments at
BUG:124326

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 528933
Allen Winter committed changes in /trunk/playground/devtools/krazy:

The krazy source code checker.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 14 more) Revision 529141
Michael Pyne committed changes in /trunk/KDE/kdesdk/scripts/kdesvn-build:

Add code to use the kdelibs4_snapshot for kdelibs if the 'branch kde4-snapshot' option is
selected, instead of requiring weird hacks in the config file to use the snapshot.

e.g.

module kdelibs
branch kde4-snapshot # Use the branches/work/kdelibs4_snapshot stuff.
end module

Make the snapshot the default for kdelibs, which should help with the Coverity stuff.

Don't try to download a snapshot if override-url is in effect for a module.

Update the sample file to match, including a comment at the use-stable-kde option to warn
the user to also update the kdelibs options.

Touch up the pretend mode output a bit.

Oliver Kellogg committed changes in /branches/KDE/3.5/kdesdk/umbrello:

Apply patches from http://www.geeksoc.org/~jr/umbrello/uml-devel/9396.html
implementing AutoCompletion for ComboBox dialog widgets. Many thanks Achim.
BUG:104477

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 528495

Educational

Jason Harris committed changes in /trunk/KDE/kdeedu/kstars/kstars/tools:

The Observing list tool is now functional. The table view is now a
QTableWidget, and the "Tiny" (name only) view is a QListWidget.What works? Adding objects to the list in the map (popup menu, or "O"
key), selecting them in the tool and using the action buttons. You can
also switch to "Tiny" mode, which shows just the name field and hides
the Log notes editor.TODO: Shrink the window when entering Tiny mode. Sort rows when
clicking a column. ObsListWizard is still a crash.

Diffs: 1, 2, 3 Revision 528464
David Saxton committed changes in /trunk/KDE/kdeedu/kmplot:

Added legendre polynomials up to n=6 (P_[0->6]).

Diffs: 1, 2, 3 Revision 528685
David Saxton committed changes in /trunk/KDE/kdeedu/kmplot/kmplot:

Added code for drawing plots in a variety of styles (dashes, dots, etc) (there
is no way of configuring which style to use for plots yet, though).

Diffs: 1, 2, 3, 4 Revision 528877
David Saxton committed changes in /trunk/KDE/kdeedu/kmplot/kmplot:

Allow changing of plot line style (e.g. solid, dash, dot, etc). "Appearance"
group box needs improving though - atm it is slightly cluttered.

Diffs: 1, 2, 3, 4 Revision 529047

Graphics

Gilles Caulier committed changes in /trunk/extragear/graphics/digikam/libs:

digikam from trunk : GPS locator tool :

- Code polishing.
- Remember last web GPS locator service used.

Nota: the implementation is ready to use new GPS maps service from the web. If you have some url witch accept world latitude and longitude GPS coordinates, let's me hear...
111560

Diffs: 1, 2, 3, 4 Revision 528096
Gilles Caulier committed changes in /trunk/extragear/graphics/digikam:

digikam from trunk : improving image properties restoration in database using image metadata:

- Fix DMetadata method to get image Exif/Iptc tags properlly. (With the old implementation, Comments from Exif and Iptc, Rating from Iptc and are never checked duing a wrong validity test - stupid bug)
- Now at startup, these informations are backported to database :

==> Comments from JFIF section, or Exif UserComments tag, or Iptc Caption tag.
==> Date & time stamp from Exif dateTime tag or Iptc date & time tags.
==> Rating from Iptc Urgency tag !!! If you add new files in your Album library, witch are rated using Mapivi for example, digiKam items rating will be appear in main interface.

Nota : these updates in database are only performed to new files :

==> when all albums are parsed during statup (or manually from Tool menu).
==> when new items are downloaded using camera interface.
==> when a folder is imported from main interface.

TODO :

- Performed a database update at startup when files are already in database and when metadata have been changed outside digiKam (using ExifTools for example)
- Do something with digiKam Tags, since they are stored in IPTC Keywords tags. This is most complicated to do because there is no hierarchy between IPTC Keywords like with digiKam tags. We store only Tags name in IPTC keywords. I propose :

==> to check if a digiKam tags name already exist in database and taging automaticly item using it.
==> do nothing if Tags name do not exist (no new digiKam Tags will be created in database).
==> If dupplicate Tags name exist in digiKam database (for ex. Travel/City and Travel/France/City), use only the first Tag name found in database.

digiKam Tags <==> IPTC Keywords rules is a complex problem. Please give me your viewpoints into B.K.O. Thanks in advance
91811

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 528157
Marcel Wiesweg committed changes in /trunk/extragear/graphics/digikam:

digikam from trunk:

The ImageEditor can now access the database independently
from main view, i.e. also if main moved to a different directory.

- adjust ImageInfo to be more like a database item wrapper class
- add a method to ImageWindow to start it with a list of
ImageInfo objects, use this in AlbumIconView
- adapt ImageWindow to (optional) ImageInfo list
- adjust behavior of saveAsIsComplete
- add itemChanged methods to ImagePropertiesSidebarDB:
- one takes only a URL (no database)
- one takes an ImageInfo object (used by ImageWindow, full DB support)
- one takes AlbumIconItem and -View (used by main view,
full DB support, optional future interaction with the view)
- ImageDescEditTab now works on an ImageInfo object
- add a copyItem method to ImageInfo as a wrapper for said function from AlbumDB
- modify AlbumDB::copyItem to return image id of inserted image
- add DISTINCT keyword to second SELECT statement of AlbumDB::copyItem.
With all of above changes, I constantly produced bug #113915.
I do not know why the SELECT statement produces (in my case) three times
the same result so that INSERT complains, and I do not know which of
my changes should ever trigger this problem, but the DISTINCT fixes this.
If anyone speaks SQL, you might want to check my comment in AlbumDB::copyItem.

Currently, the rating is not copied when database information is copied (in copyItem).
Should this be done?

CCBUG: 113915

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 529254

KDE Base

Stephan Kulow committed changes in /trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake:

Make it user friendly:
- Qt qmake not found!
+ The installed Qt version 4.1.0-rc1 is too old, at least version 4.1.1 is required

Marcus Camen committed changes in /trunk/KDE/kdebase/SConstruct:

remove SConstruct as kdelibs doesn't have bksys support anymore (commit 523268)

David Faure committed changes in /trunk/KDE/kdebase/kdesu/kdesu:

FEATURE: --noignorebutton, based on patch by "Nicolas Lécureuil" <neoclust.kde gmail.com>

Diffs: 1, 2, 3 Revision 529045
Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma:

starting work on dataengines, datasource, datavisualizations, the plasma
app and applets ... doesn't compile atm as it's a work in progress off
the design concepts. but dinner becons and i don't want to lose progress
in case my laptop degrades further.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 529282
Matt Broadstone committed changes in /trunk/KDE/kdelibs/kjsembed/autobind:

Added classinfo to the bindings, this is going to be _very_ helpful later
on.. also got rid of the stuff in the top level of autobind because its
not really useful anymore, we're going to have to rethink object/widget
bindings.. but variants first!

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 27 more) Revision 529301
Marijn Kruisselbrink committed changes in /trunk/KDE/kdelibs/kdeui:

Implemented KGlobalAccelImpl for OSX, and slightly reorganized kkeyserver, moving platform-independent functions to kkeyserver.h/.cpp instead of kkeyserver_x11.x/.cpp

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 529499
Richard J. Moore committed changes in /trunk/KDE/kdelibs/kjs/create_parser:

A replacement for the make parser target until someone figures out how to do that in CMake

Hamish Rodda committed changes in /trunk/KDE/kdebase:

Merging in from bleeding edge kdebase branch
- i18n ported
- KAccel removed
- Some fixes for OS X

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 349 more) Revision 528190
David Faure committed changes in /branches/work/kde4/setup-env:

QT_PLUGIN_PATH is useful so that the KDE widgets are available in designer.

KDE-PIM

Marco Gulino committed changes in /trunk/playground/pim/kmobiletools/kmobiletools:

Adding a 22x22 icon for phone calls.
Implementing popup menu actions (but calls) for phonenumbers.
Cleaning API.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 529500
Chusslove Illich committed changes in /trunk/KDE:

Conversion to new i18n API (see KDE4PORTING.html->I18N->i18n calls).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1394 more) Revision 528186

Office

Ariya Hidayat committed changes in /branches/koffice/1.5/koffice/filters/kspread/excel/sidewinder:

implemented cell reference to another sheet, like "Sheet2!A1"
this is done by partial support for EXTERNSHEET and SUPBOOK records
should work both on Excel 95 and Excel 97/later

Dag Andersen committed changes in /branches/koffice/1.6/koffice/kplato:

Add standard working hours to the standardworktimedialog.
These will be used as default when resources has no calendar defined.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 528564
Dag Andersen committed changes in /trunk/koffice/kplato/patches:

Add a patches directory to store all non-ported
1.6 patches so we won't forget them.

Diffs: 1, 2, 3 Revision 528581

Konqueror

Eva Brucherseifer committed changes in /trunk/kdenox/konq-embed/src/pics/decrypted.png:

use grayscale pixmap for unencrypted connections

Multimedia

Leo Franchi committed changes in /trunk/extragear/multimedia/amarok/src:

Patch from Laszlo Pandy to let xine engine play .part files from KGet.
BUG: 110833

Sebastian Trueg committed changes in /branches/stable/extragear/multimedia/k3b:

Warn about shortened filenames before starting the burning.

BUG: 108429

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 528555
Ian Monroe committed changes in /trunk/extragear/multimedia/amarok:

The collection browser now has tabs to switch between flat and tree view
instead of KToggleActions.
Looking for feedback, should the buttons common to both be moved into
the toolbar?

Diffs: 1, 2, 3 Revision 528920
Ian Monroe committed changes in /trunk/extragear/multimedia/amarok/src:

*Collection browser remembers what mode its in between sessions again.
*Tabs have wheel support (though its kind of funky, since my wheel
often sends two events at once so it skips right back to where it started)

Diffs: 1, 2, 3 Revision 528934
Mark Kretschmann committed changes in /trunk/extragear/multimedia/amarok/src:

Move custom icons option to the Appearance settings.

Stephan Kulow committed changes in /trunk/KDE/kdemultimedia/kioslave/audiocd/audiocd.cpp:

forwardport adridg's changes of this january

Martin Aumüller committed changes in /trunk/extragear/multimedia/amarok:

extract embedded cover art from m4a files - thanks to an updated taglib m4a patch by Jochen Issing and a patch by Shane King this works for m4a w/o external dependencies (r/o) and via libmp4v2 (r/w)
BUG: 125414

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 529533
Jeff Mitchell committed changes in /trunk/extragear/multimedia/amarok/src:

Random string function implemented. Note that this function restricts the possible characters to 0-9a-zA-Z, which is good
because we can print to stdout, but bad because there's less bits to choose from. Also there is a little favoritism
because of avoiding non alphanumeric characters, but in general that's alright. Even with these drawbacks, assuming
that the randomization sequence is good and a decent seed is found using the chosen method, there are still up to
51649738599652491790651549397174942699476
584262665539608782445962684816148
42987330263563657801857314603738370932736
possible IDs. I think it'll suffice for now.

Gábor Lehel committed changes in /trunk/extragear/multimedia/amarok/src:

more work on context browser + ratings
i've introduced some new css classes, and ported the default theme (because it's the default), and example (because I use it)
there's still some issues, like the gray line on the left of the score boxes isn't continuous now, and in the current track info, if you displayed both rating and score, it'd mysteriously move next to the 'last played' text instead of above it, whereas it works fine if you only display one of them.
i've hacked around this for now by sticking a bunch of <br /> at the end, but if someone who actually understands this shit could take a look at it, that'd be good.

Diffs: 1, 2, 3 Revision 530215

Networking Tools

Michaël Larouche committed changes in /branches/kopete/0.12/kopete/kopete/chatwindowemaneman:

Adding 2 more validy tests for a style archive while keeping my current threshold. So if a package doesn't have Header or Footer, it will detected as valid

Michaël Larouche committed changes in /trunk/KDE/kdenetwork/kopete/protocols/CMakeLists.txt:

Compilation of Messenger plugin can now be optional (desatived via ccmake), can happen the plugin doesn't compile.

Olivier Goffart committed changes in /branches/kopete/0.12/kopete/libkopete:

Support .jisp theme (as described in the JEP-0038)
The old emoticons theme is of course still supported.
There are no new feature tha JEP-0038 has over the current format.
(xml:lang and sounds are not supported)

Diffs: 1, 2, 3 Revision 529897

Utilities

Dirk Mueller committed changes in /branches/KDE/3.5/kdeaddons/kicker-applets/ktimemon:

- added CPU iowait support. patch by Michael Blakeley, thanks!
- added kernel slab memory support. Finally :)
- some cleanups.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 529517

Games

Albert Astals Cid committed changes in /branches/work/kde4/playground/games/kombination/src:

new i18n framework

Diffs: 1, 2, 3, 4 Revision 528313
Andreas Beckermann committed changes in /trunk/KDE/kdegames:

Removing ksmiletris, as discussed a while ago, see
http://lists.kde.org/?l=kde-games-devel&m=112536434505736&w=2

Diffs: 1, 2, 3 Revision 529943

Optimization

Educational

David Saxton committed changes in /trunk/KDE/kdeedu/kmplotlist:

Moved all plot style group boxes to a custom widget.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 529025

KDE Base

Luboš Luňák committed changes in /branches/work/kdelibs4_snapshot:

Startup sequence reorder, see ksmserver README for how it works
now (in a nutshell: get kicker and kdesktop up as soon as possible,
start as much stuff as possible as late as possible).

Diffs: 1, 2, 3, 4 Revision 529157
Aaron J. Seigo committed changes in /trunk/KDE/kdebase/kdebugdialog/kdebugdialog.cpp:

remove silly code; doesn't really do anything and confuses covarity ;)

Luboš Luňák committed changes in /trunk/KDE/kdebase/workspace/kcontrol/background/bgdialog.cpp:

Forwardport of r455251, whatever that is exactly about. Penalty
points for missing a trunk commit for a 3.5 commit go to
Scott Wheeler this time.

Matt Broadstone committed changes in /trunk/KDE/kdelibs/kjsembed/kjscmd/kjscmd.cpp:

Updated kjscmd for better command line support, now also supports exec without gui support leading to ~0-2ms startup time instead of the usual ~200ms for QApplication..

Jos van den Oever committed changes in /branches/work/kde4/playground/libs/archivereader/src/streams/tests(fro:

Improved speed of valgrind unit tests.

Diffs: 1, 2, 3 Revision 528358
Daniel Teske committed changes in /branches/KDE/3.5/kdebase/konqueror/keditbookmarks:

If the listview is filtered, only iterate over visible items.

BUG: 125071
BUG: 124783

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 528704

KDE-PIM

Marco Gulino committed changes in /trunk/playground/pim/kmobiletools/kmobiletools/mainpart:

Avoid probing again devices is going back in the New Mobile Phone Wizard.

Michal Švec committed changes in /branches/KDE/3.5/kdepim:

Moved alarmclient to libkdepim and share it between kontact and korganizer.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 528308

Office

Bart Coppens committed changes in /branches/koffice/1.6/koffice/krita:

Due to popular request: ditch the madvise stuff to 'swap' out tiles, and actually swap them out with munmap. This introduces some complications like memory areas becoming invalid and so. That, and the fact that I did have to change some stuff for this, might cause some fallout. I didn't notice anything strange with it anymore, but please yell if you see odd behaviour or crashes that you can directly link to this commit :-)(This deprecates some functions, I won't remove them because afaik we'd want at least sourcecode compatibility with Krita 1.5. They exist, but _please_ don't use them anymore. To the best of my knowledge, all current occurances are gone, keep it that way :P)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 529585
Stefan Nikolaus committed changes in /:

operation 'Paste with Insertion'
Speed the insertion of columns and rows up. The related undo/redo
operations were also broken.

Diffs: 1, 2, 3, 4, 5, 6 Revision 528200

Konqueror

Eva Brucherseifer committed changes in /trunk/kdenox/konq-embed/src/preferences_road.cc:

improve felt performance for preference dialog

Eva Brucherseifer committed changes in /trunk/kdenox/konq-embed/src/view.cc:

we can enable the back button already when we start to load the next url

Multimedia

Jeff Mitchell committed changes in /trunk/extragear/multimedia/amarok/src/metabundle.cpp:

Change the rand function a bit. Why seed on every call? So do it once. Also call rand() directly after seeding, no point
in the extra function call 64 times.

Networking Tools

Hugo Parente Lima committed changes in /trunk/extragear/network/knetstats/src:

- Code cleanup.
- Auto detect interfaces every 5 seconds (maybe 10?, maybe in a configurable interval?)
- User dont need configure the program before use it, it simple detect the interfaces and show it.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 528810

Security

KDE Base

Dirk Mueller committed changes in /trunk/KDE/kdelibs/cmake/moduleskeke:

the usual security fixes:
- add proper quoting
- add proper LD_LIBRARY_PATH export's
- don't make world executable. Ok, it would be better to
honor umask, but I don't know how to do that..

Other

Development Tools

Andras Mantia committed changes in /branches/work/kdevquanta:

This is my first attempt to port some part of Quanta to KDE4:
- create cmake files- start to port "lib" to KDE/Qt4

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 50 more) Revision 529182
Jens Herden committed changes in /branches/work/kdevquanta:

first steps in porting

Diffs: 1, 2, 3, 4 Revision 529441

Educational

Pino Toscano committed changes in /trunk/KDE/kdeedu/kig:

make kig compile with the new snapshot

Diffs: 1, 2, 3, 4, 5 Revision 528301
Anne-Marie Mahfouf committed changes in /trunk/KDE/kdeedu/klettres/klettres:

more porting

Diffs: 1, 2, 3, 4 Revision 530190

KDE-PIM

Cornelius Schumacher committed changes in /trunk/KDE/kdepim:

Make KMail, KOrganizer and Akregator compile.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 528731
Frank Osterfeld committed changes in /trunk/KDE/kdepim/libkleo/ui:

convert ui files to Qt4

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 528944
Frank Osterfeld committed changes in /trunk/KDE/kdepim/korganizer:

add lib libkorganizer_interfaces for the moc files belonging to korganizer/interfaces/korganizer
fix mixup between targets korganizer (lib) and korganizer (bin).
korganizer now compiles and links for me using cmake (TM).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 529617

Office

Peter Simonsson committed changes in /trunk/koffice:

First baby steps towards the rewrite of kivio to be able to use Flake and support OpenDoc.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 528889
Adrian Page committed changes in /trunk/koffice:

Port the krita png filter. Currently saving crashes.

Diffs: 1, 2, 3, 4, 5, 6 Revision 529975
Laurent Montel committed changes in /trunk/koffice/libs/kotext/KoTextFormat.cpp:

Adapt to new kdelibs api

Networking Tools

Urs Wolfer committed changes in /branches/work/make_kget_cool/kget:

* port to new kdelibs snapshot* disable konqueror plugin for the moment because it doesn't link with cmake compiled kdelibs

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 528381

Utilities

Lothar Braun committed changes in /trunk/KDE/kdeadmin/kcron:

Port to new kdelibs snapshot
- fixed compiling
- removed use of deprecated methods

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 528826