Revision 545160

Go back to digest for 28th May 2006

Optimization in KDE Base

David Faure committed changes in /trunk/KDE/kdelibs/kio:

Rewrote KService::hasServiceType() to not use KMimeType (for the kdecore/kio split):
* Split into hasServiceType() and hasMimeType()
* Use the trader offers for the case where the service come from ksycoca, which makes
those methods much faster (13 times faster according to callgrind!)
* Use the old implementation for the case of KServices created from full paths
or KConfig objects, but without support for mimetype inheritance. If we really
need this one day (which I doubt), we'll still have solutions (cf comment in code).

File Changes

Modified 13 files
  • /trunk/KDE/kdelibs/kio
  •   /kio/kdedesktopmimetype.cpp
  •   /kio/kmimetype.cpp
  •   /kio/krun.cpp
  •   /kio/kservice.cpp
  •   /kio/kservice.h
  •   /kio/kservicefactory.cpp
  •   /kio/kservicefactory.h
  •   /kio/kservicegroupfactory.cpp
  •   /kio/kservicetype.cpp
  •   /kio/kservicetype.h
  •   /kio/kservicetypeprofile.cpp
  •   /tests/kmimetypetest.cpp
  •   /tests/kmimetypetest.h
13 files changed in total