Revision 599200

Go back to digest for 29th October 2006

Bug Fixes in KDE Base

David Faure committed changes in /branches/KDE/3.5/kdelibs/kio/kio/kmimetype.cpp:

Patch from Modestas Vainius to fix Bug 122020 (kdesvnd action menu issues)
He said, and I agree:

Do not time out when waiting for the reply for the X-KDE-GetActionMenu DCOP call. DCOP protocol is synchronouos by design and a reply for the timed out call (i.e. garbage) still arrives and might be falsely returned as a valid reply for the subsequent DCOP call on the same connection. The application currently known to be badly hurt by this is kdesvn and its konqueror service menu integration. Its X-KDE-GetActionMenu might take longer than current 100 milisecond timeout to complete. As a result then, a late reply will "pollute" a main DCOP connection of the client application (e.g. konqueror) causing further DCOP failures.

File Changes

Modified 1 files
  • /branches/KDE/3.5/kdelibs/kio/kio/kmimetype.cpp
1 files changed in total