Revision 840672

Go back to digest for 3rd August 2008

Other in Multimedia

Jeff Mitchell committed changes in /trunk/extragear/multimedia/amarok/src:

Massive patch changes the name of Meta::Track::url to Meta::Track::uidUrl.
From Max:

"Meta::Track::url() isn't anmed correctly anyway, but I'm too lazy to refactor it. Look at the documentation for that method, it *is* a uid, it's just not named correctly. the return value of that method may only be used within amarok. the sqlcollection plugin wuld have to interpret amarok-sqltrack urls, so it would be free to use some magic to figure out if the url contains a uid or a path."

I decided to fix his laziness :-)

This helps reinforce that it's a track specific unique ID method; in SqlCollection this uidUrl will eventually contain the AFT ID, i.e. amarok-sqltrack:/273ab6s5c5d6d or some such thing.

In fact, a portion of this (if not the mechanism that does the actual tracking) will be implemented soon, because the UID part of AFT is needed by xevix to do proper collection syncing with the iPod.

File Changes

Modified 51 files
  • /trunk/extragear/multimedia/amarok/src
  •   /dialogs/TagDialog.cpp
  •   /meta/M3UPlaylist.cpp
  •   /meta/Meta.h
  •   /meta/PLSPlaylist.cpp
  •   /meta/SqlPlaylist.cpp
  •   /meta/XSPFPlaylist.cpp
  •   /playlistmanager/PlaylistManager.cpp
  •   /podcasts/PodcastMeta.h
  •   /podcasts/PodcastReader.cpp
  •   /browsers/servicebrowser/ServiceMetaBase.cpp
  •   /browsers/servicebrowser/ServiceMetaBase.h
  •   /collection/daap/daapmeta.cpp
  •   /collection/daap/daapmeta.h
  •   /collection/ipodcollection/IpodCollection.cpp
  •   /collection/ipodcollection/IpodMeta.cpp
  •   /collection/ipodcollection/IpodMeta.h
  •   /collection/nepomukcollection/NepomukQueryMaker.cpp
  •   /collection/nepomukcollection/NepomukTrack.cpp
  •   /collection/nepomukcollection/NepomukTrack.h
  •   /collection/sqlcollection/SqlMeta.h
  •   /collection/sqlcollection/SqlQueryMaker.cpp
  •   /collection/support/MemoryCollection.h
  •   /collection/support/MemoryMatcher.cpp
  •   /meta/file/File.cpp
  •   /meta/file/File.h
  •   /meta/proxy/MetaProxy.cpp
  •   /meta/proxy/MetaProxy.h
  •   /meta/stream/Stream.cpp
  •   /meta/stream/Stream.h
  •   /podcasts/sql/SqlPodcastMeta.cpp
  •   /podcasts/sql/SqlPodcastProvider.cpp
  •   /browsers/servicebrowser/ampache/AmpacheServiceCollection.cpp
  •   /browsers/servicebrowser/ampache/AmpacheServiceQueryMaker.cpp
  •   /browsers/servicebrowser/jamendo/JamendoDatabaseHandler.cpp
  •   /browsers/servicebrowser/jamendo/JamendoXmlParser.cpp
  •   /browsers/servicebrowser/lastfm/AudioController.cpp
  •   /browsers/servicebrowser/lastfm/RadioAdapter.cpp
  •   /browsers/servicebrowser/magnatunestore/MagnatuneDatabaseHandler.cpp
  •   /browsers/servicebrowser/magnatunestore/MagnatuneMeta.cpp
  •   /browsers/servicebrowser/magnatunestore/MagnatuneSqlCollection.cpp
  •   /browsers/servicebrowser/magnatunestore/MagnatuneXmlParser.cpp
  •   /browsers/servicebrowser/opmldirectory/OpmlDirectoryDatabaseHandler.cpp
  •   /browsers/servicebrowser/opmldirectory/OpmlDirectoryInfoParser.cpp
  •   /browsers/servicebrowser/opmldirectory/OpmlDirectoryService.cpp
  •   /browsers/servicebrowser/opmldirectory/OpmlDirectoryXmlParser.cpp
  •   /browsers/servicebrowser/scriptableservice/ScriptableService.cpp
  •   /collection/daap/daapreader/reader.cpp
  •   /collection/ipodcollection/handler/IpodHandler.cpp
  •   /context/engines/lastfm/LastFmEngine.cpp
  •   /browsers/servicebrowser/lastfm/meta/LastFmMeta.cpp
  •   /browsers/servicebrowser/lastfm/meta/LastFmMeta.h
51 files changed in total