Discussion
Revision 851554
(Back to Digest)
next


Commit Details
Bug Fixes in KDE-Base
Rafael Fernández López committed changes in /trunk/KDE/kdelibs/kdeui/widgets:
Fix all (or almost all) toolbar problems.

Now, in detail:
- We need two restoreState method calls when applying the main window settings.
One before we set the toolbars again, and another after that.
The first call will setup them, the second will do the right math with them (since toolbar text position, icon size... was set).

- Actually compress potential sync's with a proper timer
- When dirtying the settings, save directly (of course, for almost all actions, not for moving or resizing, which are compressed).

This prevents us from saving incorrect settings if toolbars have been removed/changed on the meanwhile, and thus, making QMainWindow::saveState() storing incorrect values.
Diffs: 1, 2 Revision 851554

Discussion
From: Marijn Kruisselbrink Date: 25th August 2008 @ 01:38:09

> SVN commit 851554 by ereslibre:
> -class DockResizeListener : public QObject
> +class KMainWindowPrivate::DockResizeListener : public QObject
Why did you change this? It seems because you needed to access private part=

of KMainWindow from DockResizeListener? Unfortunately this way it is broken=

in gcc 3.4, and the only way I know to fix that is to make DockResizeListen=


KMainWindow.

Marijn

KDE Commit-Digest by Danny Allen, 2006-2009
All issues in archive by Derek Kite