Revision 868254

Go back to digest for 12th October 2008

Other in Office

Thomas Zander committed changes in /trunk/koffice:

Fixes: Tab & Backtab should be offered to the active tool.
Details; Use the way that Qt designed this to work. We implement focusNextPrevChild in KoCanvasController.

sidenote; I noted that the event filter solution was not present various apps meaning tools never got the chance to see those events.

This is what happens now; user presses [tab], KoCanvasController says it doesn't use it for focus issues and Qt offers a keyEvent instead.

The apps canvas forwards the event to the tool which decides if he wants to use it. (The text tool does, most others don't).

The app canvas notices the key is ignored by the tool and goes on to try to change the focus.

File Changes

Modified 13 files
  • /trunk/koffice
  •   /kchart/KChartCanvas.cpp
  •   /kformula/KFormulaCanvas.cpp
  •   /kword/part/KWCanvas.cpp
  •   /kword/part/KWCanvas.h
  •   /libs/flake/KoCanvasController.cpp
  •   /libs/flake/KoCanvasController.h
  •   /libs/kopageapp/KoPACanvas.cpp
  •   /libs/kopageapp/KoPACanvas.h
  •   /karbon/ui/widgets/KarbonCanvas.cpp
  •   /krita/ui/canvas/kis_qpainter_canvas.cpp
  •   /krita/ui/canvas/kis_qpainter_canvas.h
  •   /krita/ui/opengl/kis_opengl_canvas2.cpp
  •   /krita/ui/opengl/kis_opengl_canvas2.h
13 files changed in total