Issue 133

Just return zero, instead of asserting. This workaround the hated crash while startup, caused by the class-view.

I hoped that someone would rather fix the class-view, but well..

Bingo!
Now we have reproduced the bug 172309 (or found similar thing)

Made the order of the virtual keyword consistent with the rest of humanity.

(and this stops the bindings generater from choking)

This fixes (the worst of) the problems in week view in KOrganizer (and probably other places).

It makes the dimmed characters paint in the correct place, and stops character shuffling.
This leaves minor display problems, like alignment and icon placement, which are of much lower priority.

Patch by Shai berger.

Fix grave kio bug with FTP: if you delete a symlink to a folder, it would recursively delete the folder (!)

Sounds stupid, but it's FTP which is stupid; the only way to know if something is a link is by listing its parent dir, but this isn't always possible (if no permission to list the parent dir)... -> the URL isn't enough info, we need the KFileItem from the listing. Rather than adding KIO::del(KFileItemList) (and porting a lot of code), I simply grab the KFileItem from KDirListerCache, as discussed with Michael Brade in 2006 for other reasons.

As a side effect, this speeds up deletion (again!) in the case of remote protocols (saves a KIO::stat per toplevel item to delete).

Rework how we do onchange for input/checkboxes, unbreaking it and simplifying things.
As we only want to fire it in response to user events, this just does it in defaultEventHandler.

Fixes kde-look wallaper settings, and along with Germain's previous fix this covers bug #165607, #170451.
This also doesn't suffer from #148118

Refactor KoImageData and KoImageCollection

This fixes the following:
* copy of shapes with a pattern backgound run into an assert
* make copy and paste of images and objects with pattern background work
* fix bug in WMFImportParser to use the image collection correctly. the image collection was not found
* make it possible to add also remote images e.g. over fish://
* make copy and paste of pages with background images work in kpresenter and kivio

Also done
* make sure that if the same picture is added more then once to use the same data for it
* added first unit tests for KoImageCollection
* use the shape saving context to store the images which need to go into the saved store.
* don't stop loading if e.g. a image can not be loaded.

I hope I did not break anything. As far as I can see all works well.
The karbon filters should be tested to see if it is all working as expected.
I also disabled the code in the shapeselector to show the clipboard as it crashes as soon you twice copy a picture.

Solved two problems with the preliminary drag&drop support for the albums applet:
- Now the albums and tracks are correctly added to the playlist. Previously adding an album would not do anything at all and dropping a track would add the whole album.
- When dragging an album and (additionally) a track from that album the track is not added twice.

Load Service-associated tracks properly on startup

If the playlist is saved with tracks from a Service in it (eg, tracks from Magnatune) when Amarok is closed, we want those tracks to be properly reloaded when Amarok restarts.

This means that the ServicePluginManager has to be loaded before PlaylistModel reloads the tracks, so that ServicePluginManager can register as a TrackProvider for service-related tracks.

This patch forces ServicePluginManager to be loaded before tracks are restored into the playlist.

When the tracks are loaded into the playlist, their associated service is initialized in the plugin manager so that the track can be loaded properly into the playlist.

However, MainWindow also needs to initialize any remaining enabled services so that all enabled services can show up in the servicebrowser.

This patch also adds a check so that when the MainWindow tells ServicePluginManager to initialize all the services, it will skip the services that have already been initialized.

Fix for crash on startup with Ampache tracks in the playlist.
The code now ignores "Year - Album", but frankly, I don't give a fiddler's fart about that.
I don't want Amarok to crash, is all I care.

May the person fix that properly who came up with this ingenious code.

Fix bug 172485: Kopete has full CPU load (freezes) when receiving a long line.

The message.setHtmlBody( message.parsedBody() ); which should cache the emoticons actually didn't cache it and it made it even worse because setHtml is much slower than parsedBody if we have many emoticons (html tags).

So this patch removes this line and adds caching into the parsedBody function.
The great thing is that we don't have to call setHtml which was the bottleneck.

[important commit]
-ressurect spellchecking.
-ignore '&' accelerators (todo: handle xml markup correctly)
-autoignore words that are present in msgid (didn't need this in kde3 as ispell skipped non-cyrillic words anyway)

(i had problems spellchecking russian texts until i found out that their cause is old version of libenchant1c and not sonnet)

Kompare: Finally add support for refreshing diffs to the trunk.
(Though it was possible to get that effect with the "swap and swap back" hack which I got all too accustomed to. ;-) )

Partly based on revision 418173 by jkeel from 3_way_kompare, also incorporates my followup (revision 871142), the actual implementation of the refreshing reimplemented to work in trunk.

New preferences dialog.
Thanks apaku for the help.

Not yet adapted to the runcontroller so new features won't work.

Add a new Source-browsing using the mouse.
The code-browser has a new toggle-button now, that lets you enable "browse" mode.

In that mode, you can just click uses or special-objects items in the editor, and they will be jumped to, like when browsing a web-page.

Yet missing: Give some better visual feedback when the cursor is over a clickable item, activate this mode by CTRL key.

Give visual feedback when the cursor is over a clickable item: Make it a Hand.
This is sooooo cool. :-)

- More work on GeoDataLineString tesselation.
- getting GeoPainter::drawRect working for the isGeoProjected == true case ...

Next step: dealing with the polygons disappearing behind earth (aka horizon).

- Adding menu entry for Offline Mode ...

Implemented the 'Move Node' action.

commit finally an edge tool working ;D

Add first half of a lookup table for Winkel III generated using proj4.

Switch from a KSelectAction to a KActionMenu+KAction's, so the actions of the "View Mode" submenu can have custom shortcuts (and placed in toolbars, etc).

Add Cumulative Sum plugin.

Support reload in KPart.

* make feedKeys() take a qstring of keypresses instead of QKeyEvents. this will make it possible to pass register contents to it and thereby making it easy to add support for recording commands. ("macros").

* make recording of backspace work

* don't log modifiers key presses on their own

* renamed "escape" to "esc"

* use sendevent instead of postevent, making it possible to know that* we're running a macro

Add support for WPA-PSK encrypted networks to the UI.

added basic dashboard javascript support

* Support for Plasmoids in Python.

Added fancy geonames annotation plugin which gets geo names from the internet and links things to those.

For now we only do pimo:hasLocation.
But anything is possible. ;)

- implement HTTP 201 (PUT Created) semantics in the web service
- addition of an order-preserving non-optimising scheduler for state transfers
- more generic signal for successes for all methods

With these changes, and the KIO patches applied, RESTful web service access is now possible!

added cache configuration and cleanup to kio_bookmarks kcm

First step for having a details view, where only the icon + name act as selectable area (not the whole width of the name column - similar to KDE3).

Thanks to Simon St. James for the original patch!

Currently it is very confusing that although only the icon + name is selectable, still the selection and hovering is drawn above the whole column width. This will be fixed before KDE 4.2.

Eyes plasmoid now is SVG themable.
Why we don't move it to kdereview?

First version of configurable pastebin applet

Now we can create multiple backends for the different "pastebin servers" out there. When creating a new backend, one just needs to add it to backend.h and implement server.h API. The backend must emit a signal postFinished(const QString&) with the URL to be displayed in the applet.

Commit also implements another backend (pastebin.com). More to come.

Now we just put the URL in the clipboard, instead of the whole text that is displayed.

Added simple ontologyimportclient which only calls the dbus method on the ontology service.
The only reason for this being an app and not just a script using qdbus is the KPassivePopup information about the success of the import.

* GHNS support
* Option to show arrows/buttons only on hover
* Scale to content menu option

AudioDevice:
- for now every AudioDevice must use the config cache (needed for correct indexing)
- add another key to the config cache indicating whether the device was removed by the user (KConfigBase::deleteGroup doesn't do the job :( )

PhononServer:
- for ALSA virtual devices use the description text as unique ID
- for all devices the uniqueId needs to end with "playback" or "capture"
- handle multiple soundcards that we have no possibility to distinguish (except for the card number, but this number only depends on which card was found first)
- simplify reading audio device properties a bit by removing the type separation
- add functions to allow the KCM to remove devices
- use a 50ms timer to delay device relisting, this get's rid of some unnecessary full relistings when a single device removal/addition calls our slot multiple times

QEdje's wallpaper plugin is almost working

Some work is needed at QZion because right now we only have access to the canva's widget and in the wallpaper we have just the Painter (different from the edjescript where we have a qgw and we can use a proxy widget).

So if you are going to use this, you need to trigger the wallpaper's repaint all the time to see the animation =P.

configuration option: auto refresh interval (disabled by default) so a new dialog for it

oh, and warning--

The geonames annotation plugin now prefetches all countries in the background and stores them in Nepomuk.

This allows to disambiguate city names in a rather fancy way: show the *translated* name of the country the city is in after the city name itself.

I don't think anyone would really mind having 23000 something statements of country data in Nepomuk. ;)

* Implement serial, cdma and gsm devices in the NM 0.7 Solid::Control backend
* Enable instantiating these in the Solid::Control frontend
* Remove a couple of copy and paste errors

I coded this on tuesday at Dev Days, how the hell did I forget to commit it?

- merge of the lokarest patches which allow applications to use and control HTTP operations, e.g. for RESTful web services

* Components for constructing the new applet popup 3 layers:
* Popup
   * InterfaceGroups (that group like interfaces)
      * InterfaceItem (single interface in a group)
      * ConnectionItem (inactive connections for a group)
   * Auxiliary UI, configure button, flight mode etc

* Add RemoteConnection class to encapsulate connections on the service and save us from doing QVariantMap lookups all the time.

* Add ActiveConnection interface for finding out which connection on which service is active, so it can be displayed on the InterfaceItem.

Applet still displays the old networkmanagerpopup I blogged about, InterfaceGroup is still missing. When that is finished I will rewrite NetworkManagerPopup to use the new components.

commit klebezettel's patch for adding icons to more menu items.

Add a zoom dialog.

* Remove collectionanditemmodel in favour of Akonadi::EntityTreeModel.
* Use a EntitySortFilterProxyModel to order kjots books and pages in the model.
* Rework resource to add sorting attributes to kjots entities.
* Use an entity display attribute to display the correct text and icon in the model.
* Check in akonadi patch which makes all the magic happen (under review).

Reinstate the textpage concept after the pages refactor.
This means we again have page numbers in kword text with offsets and all

add some active layer switching magic:
- when clicking on a layer item in the layer docker, activate the corresponding layer
- when selecting a single shape, set its parent layer as the active layer

this make the tool disabling based on the layer state work as expected

Implement editing of dependencies using keyboard only.

Add linespacing ruler but disable for now.
Functionality will be added later on.

Added ability to link data from a chart, to data in the report, e.g. in msa child forms/reports and charts.
This makes it possible to have a slightly different chart in each section of a report, based on the main data in that section.

See <a href="/issues/2008-10-19/files/LinkedChart.pdf">http://www.piggz.co.uk/LinkedChart.pdf</a>; for a sample.

Preliminary drag and drop support for the Albums applet.
Patch by Andreas Mützel.

Added support for MTP devices.

add dbus folder and xml file for dbus connection in order to link kscd with now playing plasmoid

- Connection with dbus done
- primary functions (like play, stop...) are implemented

TODO: complete other functions, implemente tracklist and root handlers functions

First attempt at UPnP integration.

Not yet working, but now that one protocol is integrated, I can start bug fixing

* Add configuration tab in jabber edit account widget;
* Cleared up session incoming TODO's.

implement the sending of messages.

TODO: find a good place to check wether we should send a privmsg or execute a command

provide shade and unshade icons

Add shade and unshade buttons

First kpackagekit commit

Add the possibility to draw the pseudostates Deep History and Shallow History to state diagrams.

added: first primitive monitor to the view for the status bar, for offset, value/char coding, ins/ovr

Ark will now prompt to create unexisting directories in extractiondialog.

- Move the unloading/cleanup completely into a background-thread
- Do the cleanup in 2 phases. One "soft" phase, where no write-lock is held over the whole time.

This prevents the UI from blocking, the only problem is that it doesn't guarantee disk consistency.

Thus, after this phase, do the same again, this time with a complete write-lock.

We stop all parsing threads before the first phase, so the changes that happen are minimal.

Thus we only have to write very few data in the second phase, hold the write-lock for a very short time, thereby preventing the UI from blocking while waiting for a read-lock.

This fixes the annoying and very long UI lockups that happen time by time when a lot of parsing is going on, like parsing a whole project.

- improve class style selectors performance by better using AtomicStrings
- optimize a lot of DOM core stuff (fix some regressions introduced with IDStrings)
- small code cleanups on manual benchmark that uses real life css (~200kb) from facebook

I see about 8x speed up from kde4.1.2 in normal html case,and about 3x - for more rare things like xhtml

Saving an order of magnitude less information in closeditems_saved, and speeding up another order of magnitude the syncing of closeditems_saved by eliminating redundant syncs.

Things will get even better in following commits, but for now closeditems_saved shouldn't be hundreds of kbs big (or even 1-2 mb!) anymore, and it should be much faster now to load & save thecloseditems_saved config file.

Fix and optimization:
* only load icons when they are actually required (and cache the pixmap of the icon then)
* use existing icons (fixes really annoying issue that there was always a broken icon in statusbar)
* do not use a 'hack' width for the icon label; instead set a fixed size with is exactly the same size as the icons will be

Todays topic is speed!
Commiting two very effective optimizations to the gui loading code.

One that stops doing split, join all the time when searching for duplicates, which halves(!!) the loading time for opening qt's enormous tarball.

Another one uses a shortcut that assumes the next file to be read is probably from the same directory as the same one (correct about 90% of the time).

Loading time is now almost the same as just listing the file contents with tar.

Simple test application to simulate context menu actions (run multiple DVCSjobs at a time)

Add initial plasma runner template (not displayed in kapptemplate yet don't know why)

Enable browsing-mode whenever the CTRL key is pressed, including visual indication.
Now you can always push CTRL + click something to jump to it.

move the make plugin to unmaintained (replaced by katebuild-plugin)

- Never has finding the easter egg been easier...

this is for you, cniehaus!

- more steps towards supporting other planets than earth...

Remove Mollweide files because of the decision to use Winkel III instead

Remove the "old" way of configuring the toolbars and just use the XMLGUI facilities.

This makes the toolbar editing safer.

Re-enabled old 3-fields new-album GUI with some changes.

- Removed the "infamous" remote-gallery-setting from tools menu. Now it is integrated into gallery-export interface, with a "settings" button.
- Renamed config file from "kipirc" to "galleryrc"
- Added a simple check on that file to anyway use gallery-settings at 1st login.

Moved system-monitor to kdereview.

there is really no need for core developers to cc kde-devel or k-c-d ;)

* one minute between slideshow changes is a bit short for a default, make it 10
* recurse through directories
* randomize the order of the images (a config option for this would be nice)

usability++
see "kwin's KCM usability" mail.

New man page for kcookiejar4.
From Jaime.

Jaime, perhaps it is time for you to get your own SVN account??

move the applet browser stuff into the two shells that actually use it (desktop and overlay) so that we can unburden libplasma from it; makes me a lot more comfortable talking about BC with a straight face.

a new browser may end up going back in post-4.2 however

deleted kamera handbook without any content and replace it with a documentation for the kcontrol module kamera.

* Added the real rdf/xml mimetype application/rdf+xml which should replace text/rdf.
* Added TriG and Turtle mimetypes. TriG is used in Nepomuk to encode all ontologies (compare kdebase/runtime/nepomuk/ontologies/*.trig. Turtle, while not used to encode content in Nepomuk ATM, is used in the standard RDF query language SPARQL to encode graph patterns.

* All modifications have also been proposed to freedesktop.org as bugs.

Show error messages generated by KIO while listing a folder inside the folderview, instead of in a message box.

* Don't add the "Move to Trash" action to the context menu when the menu is shown for the trash link.
* Use the Dolphin setting for showing the "Move To" and "Copy To" menus.

Stat'ing is too technical (and makes people think this is a typo for Starting ;)
What is meant is more like Examining.

Now we've got an usable config UI.

Convert apple javascript import into native one.
Ship dummy javascript packages (everybody with js skills is welcome to join).

Wow, good thing I re-checked performance.
Forgot to set the bool to load only once, so the list of patterns ended up having 10000 entries, and the lookup time went from 6ms to 726ms...

Merge Libkdecoration2 Git branch.

WARNING: Breaks shadow effect. I don't think it causes anything to crash anymore but it is VERY ugly visually.

Contains:
- New decoration API that allows decorations to change the way shadows look.
- Shadows now wobble.
- API example code in the Oxygen decoration.
- Added buildQuads() effect plugin hook.
- Work on the shadow effect to use the new decoration shadow API as well.
- Added IDs to WindowQuads.
- Added public accessors to texture coords in WindowVertex.

Would like all this to be reviewed.

make the "zero" cache actually 100MB in size by default; now what is left is to grow the size of the file as we approach those limits. will do that later, but out of time for today... this at least gives plasma half a chance to store things properly.

Rename the new decoration API and mark it as unstable.
Supporting a hacked API is suicide.

Will correctly handle this in KDE 4.3 by using ARGB decorations, even if it's not pretty.

Remove the white frames from the previews and offset the shadows to make them look like the gwenview previews, as suggested by Peter.

Fade out the ends of the divider line under the folder title, as requested by pinheiro.

GUI touch-ups, tab fixes and other pretty stuff.

moving calendar widget to libplasmaclock (kdebase).

cleaned up the week printing:
1) 24 hour times now not overflowing left side of timeline
2) 12 hour times now not overflowing right side of timeline
3) removed duplicate header boxes
4) adjusted timeline to not start in header box
5) added missing header in left side of split week
6) shortened month name titles due to overflow of title boxes

Rewrite of memofileconduit, using base conduit.
Not there yet by any stretch of the imagination.

More work to come still, then we can get rid of the old one.

No idea what I am doing here.
There is no documentation about what .desktop files do.
This is a fact that I dislike a lot.

Re-enable display of optional info in gantt chart.

TODO: Only task name and resources implemented.
Also save/load context missing.

Move the indirect/direct paintop option to the paintop -- with a minimum of refactoring!
The rest of the refactoring, namely, making the paintop responsible for the actual painting mode implementation (or figuring out a plugin system for painting mode implementations...) will come with 2.1.

* open the file dialog when double click on a picture placeholder so that the user can select the picture he wants.

- New splash screen proposal for Kile 2.1.

Navigator Overhaul 2: Electric Boogaloo
I did a partial reworking of the navigators in the playlist overhaul, but they still needed some work.

They've now been significantly simplified, and should be chosen properly to the user's Repeat and Random settings.

Enable LyricWiki script by default, instead of Lyrc, cause it works much better. Finds most songs on the first try :)

Beginnings of a first run tutorial.
Idea below.
Yes, this will massively break string freeze.
Yes, it is worth it.

What the code currently does is, if you have FirstRunTutorial=true in the General section of your amarokrc, it will upon startup fade a semi-transparent overlay on top of the main window, then after a few seconds kill itself.

Here's my vision (read the comments in FirstRunTutorial.cpp too): Bottom right has next and prev buttons (like QGraphicsWidgets with QPushButtons); top right has close button. Next and prev flip through different "pages" of the tutorial. (Code has some ideas as to how to make this as painless and code reuse-ful as possible).

Arrows pointing to relevant parts of the window along with descriptive text fade in and out as pages transition.
Perhaps some buttons to launch a 1.4 database importer and/or collection setup as well.

For each page, have a description of a feature of Amarok and an arrow pointing to the relevant place. For instance, an arrow pointing to the left sidebar at the level of the Internet tab would then describe what's inside of that tab.

There's also no reason that pages couldn't activate various parts of Amarok as well, such as describing a tab, then on the next page activating it and describing subcomponents.

Leo and Seb and I think a few more are totally into the idea and think it's way worth breaking string freeze.
I'm committing it now because my time this upcoming week to hack doesn't look great, so I'd love help, even though i'd have loved to have it a bit further so that it'd be more obvious what I was thinking (hopefully the text above will be enough instead :-) )

Porting kdetv against KDE4 :
- migrating old qt3 ui files in qt4
- migrating old qt3 class to the qt4 style (class FooImpl : public QWidget, public Ui::Foo)
- Using KConfigGroup instead of KConfig, setGroup and friends
- kdDebug and kdWarning became kDebug and kWarning.Basicaly, this is just plain work in progress, nothing is working for the moment.

Give the Free Music Charts script a home.
This script allows listening to the Darkerradio.com Free Music Charts, a monthly charts show where only free (as in CC licensed) songs are taking part.

Screenshot: <a href="/issues/2008-10-19/files/amarok-fmc2.png">http://krohlas.de/amarok-fmc2.png</a>;

There are still some bugs to resolve and CMake magic is missing, but apart from that it seems to work.

* As GStreamer was not a good idea, back with the mediamanager;
* Fixed oRTP blocking functions;
* Fixed AlsaIO notifier issue.

Remove KNewsTicker.
It is broken in the current state, and there is another RSS applet for plasma in trunk.
8 years in KDE trunk is a nice time; rest in peace now :)

As agreed by Frerich Raabe (maintainer) and Aaron.

- Added new syndication plugin, which will become the succesor to the RSS plugin of KT 2.X
- Fixed some warnings
- Added posibility to load torrents via QByteArray in CoreInterface
- Make sure tabs of viewmanager are loaded before the tabs from plugins

Uploaded first version of skype protocol for Kopete ported to KDE4

Made some of the King, queen and jack cards background less saturated colour in line with the rest.
(Note): That these cards will not replace the oxygen theme but only replace them as default, Oxygen theme style will be still around as a choice.

New scrollbars, design by nuno pinheiro

Revert "Sync r872473 from oxygen." (r872702)
Resync after Oxygen have finished adding the shadow code.

Having to maintain both Oxygen and Ozone at the same time with incomplete code is a waste of time.

Move "refresh diff" to the File menu, next to swap.
Remove it from the default toolbar which is already overcrowded with the KDE 4 "Text below icons" settings.

Reenabling Alpm, it compiles again now.

I'm back, bitches!!
And I'm back to rock your heads!

Another bit of love for keyserver management in kpgp.
- First of all I fixed adding, changing the default, deletion and editting of servers.
- Only the additional servers are stored in the kgpgrc config file.
- Made the serverlist widget a bit bigger.
- Enabled sorting.

One whole second per diamond is too much (allows for endless games), half a second should be enough.

Moved kapman from kdereview to kdegames

added a class diagram, not for the faint of heart!

The game engine (i.e. everything which has to do with the Graphics View framework) is extracted from the app into libpalapeli.

Updated default theme with new look.

Big API change in Cholesky module:
* rename Cholesky to LLT
* rename CholeskyWithoutSquareRoot to LDLT
* rename MatrixBase::cholesky() to llt()
* rename MatrixBase::choleskyNoSqrt() to ldlt()
* make {LLT,LDLT}::solve() API consistent with other modules

Note that we are going to keep a source compatibility untill the next beta release.
E.g., the "old" Cholesky* classes, etc are still available for some time.

To be clear, Eigen beta2 should be (hopefully) source compatible with beta1, and so beta2 will contain all the deprecated API of beta1. Those features marked as deprecated will be removed in beta3 (or in the final 2.0 if there is no beta 3 !).

Also includes various updated in sparse Cholesky.

CampKDE initial website structure

Import Camp KDE event module

Started the third chapter of the tutorial on linear solvers.

It is only a first draft and I think it should be reorganized a bit in 2 parts:
1 - a compact table summarizing the main API and its use (this is what would expect an "expert" user)
2 - a discussion about the various algorithm in Eigen to guide the newbies in linear algebra

Currently I mixed the discussion with the API, but it is still better than nothing !