Revision 892242

Go back to digest for 7th December 2008

Other in Other

Benoît Jacob committed changes in /trunk/kdesupport/eigen2:

* Much better, consistent error msgs when mixing different scalar types:
- in matrix-matrix product, static assert on the two scalar types to be the same.
- Similarly in CwiseBinaryOp. POTENTIALLY CONTROVERSIAL: we don't allow anymore binary ops to take two different scalar types. The functors that we defined take two args of the same type anyway; also we still allow the return type to be different.
Again the reason is that different scalar types are incompatible with vectorization.
Better have the user realize explicitly what mixing different numeric types costs him in terms of performance.
See comment in CwiseBinaryOp constructor.
- This allowed to fix a little mistake in test/regression.cpp, mixing float and double
- Remove redundant semicolon (;) after static asserts

File Changes

Modified 22 files
  • /trunk/kdesupport/eigen2
  •   /test/regression.cpp
  •   /Eigen/src/Core/Assign.h
  •   /Eigen/src/Core/Block.h
  •   /Eigen/src/Core/CwiseBinaryOp.h
  •   /Eigen/src/Core/CwiseNullaryOp.h
  •   /Eigen/src/Core/Dot.h
  •   /Eigen/src/Core/Functors.h
  •   /Eigen/src/Core/Fuzzy.h
  •   /Eigen/src/Core/Map.h
  •   /Eigen/src/Core/Matrix.h
  •   /Eigen/src/Core/Part.h
  •   /Eigen/src/Core/Product.h
  •   /Eigen/src/Geometry/Hyperplane.h
  •   /Eigen/src/Geometry/OrthoMethods.h
  •   /Eigen/src/Geometry/ParametrizedLine.h
  •   /Eigen/src/Geometry/Rotation2D.h
  •   /Eigen/src/Geometry/RotationBase.h
  •   /Eigen/src/Geometry/Transform.h
  •   /Eigen/src/LU/Inverse.h
  •   /Eigen/src/Sparse/SparseBlock.h
  •   /Eigen/src/Core/util/Constants.h
  •   /Eigen/src/Core/util/StaticAssert.h
22 files changed in total