Issue 162

19th December 2010 by Alexander van Loon

Contributors

Alexander van Loon
Mutlu Inek
Vladislav Blanton
Marco Krohn

This Week...

The intense work throughout KDE-PIM and Akonadi continues. Nuno Pinheiro continues his massive updating of the Oxygen icon set, this time with 32x32 icons. Many bugs fixed in Phonon due to the extension of a hardware database. Simon Edwards introduces the "first big PyKDE4 update for the coming KDE 4.6." KSnapshot is ported to Windows. Digikam gains an image history feature. The KWebkitPart gains automatic ad filtering. Fixes in the NFS:// KIOSlave. Bug fixes and optimizations in Amarok, KAlgebra, KDevelop, Marble, Plasma, KOffice/Calligra, and the new UDev back-end for Solid. Work on Krita's Assistants amongst other things. A new Public Transport Runner in Plasma. HAL is officially retired for KDE on Linux. Oxygen-gtk is re-licensed under the LGPL v2 or later. Tellico 2.3.2 is tagged. Aki and AkiIRC move to Git.
The previous Commit-Digest mentioned the work done on the koffice-essen branch. There was a little confusion about the purpose of this branch, so Boudewijn Rempt provided a few details on what this branch was, why it was created and what happened to it:

What Happened in Essen

First the name: it was called Essen in honour of the previous KOffice developers sprint, held in the awesome Linux Hotel in Essen.

At the time of creating the branch, KOffice was still developed in KDE's Subversion, which means that it was difficult to manage branches. Very difficult. But we still felt it worthy to create a feature branch when KOffice trunk got frozen in preparation for the KOffice 2.3 release.

This branch gave all developers the opportunity to share work they were doing on new features, share refactorings and keep track of each others work, while at the same time pulling together to make trunk as stable as possible for the release. When the branch was created there were some fears that everyone would move to the branch and nobody would fix bugs and work on making trunk release ready, but those fears have been proven unfounded, just like the previous time we had a feature branch during release freeze.

Bug fixes always went into trunk – and trunk was regularly merged into the essen branch by Casper Boemann. So what went on in Essen specifically?

Optimization work on KWord was an important item - and these optimizations were quite dangerous in the shorter term, and really shouldn't be applied to a release branch. But they showed the way forward for the Calligra Words text layout re-engineering Words maintainer Casper Boemann has embarked upon.

Parts of the ODF specification that weren't supported previous were implemented by, among others, Sebastian Sauer, like ODF draw:auto-grow-width and draw:auto-grow-height.

Adam Celarek added a docker to Krita that provides an alternative way to select brush presets from the toolbar popup, following a wish by artist David Revoy.

Krita Preset Docker

Boudewijn Rempt (that's me!) worked on experimental caching for complex shapes. Currently, the text shape for instance always repaints the text in a paint event. This code caches the text shape as a QImage, and paints the QImage. It's still experimental! Marijn Kruisselbrink did the same for the KSpread canvas.

Adam Pigg started working on a mobile version of Kexi, after having received the donation of a Nokia N900.

Kexi Mobile

And so on – while at the same time, bug fixing and stabilisation of trunk proceeded at a strong pace in order to prepare for the 2.3.0 release.

After the release, Ian Monroe, sponsored by KO GmbH, finished the conversion of the KOffice svn repository to git, making Essen the new master branch from which the Calligra project is working now. (Ian, by the way, is also working on the kdelibs and kdebase Git conversion, which is expected to be finalized any time now, also sponsored by KO.) KOffice 2.3.1, with many fixes provided by the Calligra team, will have been released by the time you read this!

In the future, Calligra won't need feature branches during release freezes - with Git, branching is so cheap that only finished features will be merged into master, meaning that master is always ready for release!

Statistics

Commits 1987 by 167 developers
Open Bugs 22488
Open Wishes 17182
Bugs Opened 596 in the last 7 days
Bugs Closed 770 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
232
 
/trunk/KDE
153
 
/trunk/kdesupport
129
 
/trunk/l10n-support
47
 
/branches/extragear
42
 
/branches/stable
38
 
/trunk/extragear
36
 
/trunk/playground
32
 
/trunk/www
28
 
/trunk/koffice
14
 
Files Developer Commits
150
 
Patrick Spendrin
71
 
283
 
Nuno Fernades Pinheiro
68
 
80
 
Tobias Koenig
49
 
70
 
Aaron J. Seigo
46
 
86
 
Gilles Caulier
44
 
93
 
Wolfgang Rohdewald
40
 
121
 
Giovanni Sora
39
 
975
 
Chusslove Illich
39
 
49
 
Cristian Oneț
35
 
86
 
Marco Martin
35
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Portuguese (pt)
100%
 
Swedish (sv)
99%
 
Spanish (es)
96%
 
British English (en_GB)
96%
 
French (fr)
95%
 
Low Saxon (nds)
93%
 
German (de)
93%
 
Dutch (nl)
92%
 
Estonian (et)
90%
 

Bug Killers

Person Bugs Closed
Darío Andrés
142
 
Myriam Schweingruber
101
 
olivier jg gmail com
73
 
Aaron J. Seigo
49
 
Marco Martin
31
 
Milian Wolff
27
 
Christoph Feck
20
 
Christophe Giboudeaux
19
 
Harald Sitter
19
 
kde martin-graesslin com
18
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

  []    

Educational

[] [] []   

Graphics

[] [] []   

KDE Base

[] [] []   []

KDE-PIM

[] [] []   

Office

[] [] []   []

Konqueror

     

Multimedia

[]   []   

Networking Tools

[] []    []

User Interface

  [] []   

Utilities

[]   []   

Games

[]   []   

Other

[] [] []   

There are 170 selections this week

Bug Fixes

Educational

Aleix Pol Gonzalez committed changes in /trunk/KDE/kdeedu/kalgebra/analitza/analyzer.cpp:

Remove some wrong stack depth calculation.
Fixes the following bug, together with the last commit. (at last!)

Aleix Pol Gonzalez committed changes in /trunk/KDE/kdeedu/kalgebra/src/kalgebra.cpp:

Ask KFileDialog to ask the user if he _really_ wants to overwrite a file to be saved.

Aleix Pol Gonzalez committed changes in /trunk/KDE/kdeedu/kalgebra/src/viewportwidget.cpp:

We don't need to limit the viewport, so let's not force anything from the UI.

Aleix Pol Gonzalez committed changes in /trunk/KDE/kdeedu/kalgebra/analitza/analyzer.cpp:

Forget about the older value of the variable before defining the new one.

Dennis Nienhüser committed changes in /trunk/KDE/kdeedu/marble/src:

Ask for confirmation before removing all bookmarks.
Contains one new string (same string in marble_qt.po and marble.po), acked in http://lists.kde.org/?t=129236639300002&r=1&w=2, thanks.

RB: 6122

Graphics

Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core/libs/dimg/filters/icc/icctransform.cpp:

In our DImg, the input format is always BGRA, never grayscale or CMYK.
I cannot really see if the test grayscale image in 259182 is
properly color managed, but I hope lcms is clever enough to handle
applying a grayscale profile on an BGRA image.

KDE Base

Dawit Alemayehu committed changes in /trunk/extragear/base/kwebkitpart/src:

- Yet more createWindow related changes. Guess spoke too soon on previous commit.
This implementation is a robust generic fix that handles all window creation
requests from the browsing engine, i.e. QWebPage::createWindow.

Besides dealing with previous bugs such as 253708 and 258367 more appropriately,
it also prevents the duplicate creation of a new window if another one with the
same name already exists.

Dawit Alemayehu committed changes in /trunk/extragear/base/kwebkitpart/src/kwebkitpart.cpp:

Reverted previous commit and added a setLocationBarUrl signal emition instead to avoid about:blank being added to history list

Michael Zanetti committed changes in /trunk/KDE/kdebase/runtime/kioslave/nfs/nfs.protocol:

Added missing class information to nfs protocol. This fixes redirection from other kioslaves (e.g. like zeroconf)

Matthias Fuchs committed changes in /trunk/KDE/kdeplasma-addons/runners/contacts/contactsrunner.cpp:

Works around by using the form "NAME <EMAIL>" instead of "NAME<EMAIL>".
The first version is perfectly valid, the second that does not always work [1] might also be valid.

[1] Fails e.g. for NAME="a ü-a" or "ü-a"

Marco Martin committed changes in /trunk/KDE/kdebase/workspace/plasma/generic/applets/webbrowser:

move the border in its own widget

Michael Zanetti committed changes in /trunk/KDE/kdebase/runtime/kioslave/nfs/kio_nfs.cpp:

Don't use use fraction slash for nfs paths. This keeps the possibility to manually input the path and fixes

Michael Zanetti committed changes in /trunk/KDE/kdebase/runtime/kioslave/nfs/kio_nfs.cpp:

-Always decode the filename after incoming from network
-only encode the filename once before sending it out over the network

This fixes the ioslave when used with filenames containing non-ascii characters

John Layt committed changes in /trunk/KDE/kdelibs/kdecore:

KLocale fixes to make AM/PM symbols work properly

1) Fix spelling Meridian => Meridiem
2) Allow setting of null country meaning system country
3) Make sure Day Period config is read in with millisecond accuracy
4) Rework the saving of the config file, turns out taking a copy is a bad idea
as the existing code has a number of implicit sync() call that write the
config out, but calling markAsClean() is equally as bad, so instead keep a
pointer in the original form provided and operate on the config exactly as
previously to maintain consistant behaviour. Document the implicit sync().

Diffs: 1, 2, 3, 4 Revision 1205924
Petri Damstén committed changes in /trunk/KDE/kdelibs/kunitconversion/converter.cpp:
Anne-Marie Mahfouf committed changes in /trunk/KDE/kdelibs/kdecore:

fix wrong separation of French words with single quote
add general unit tests for preProcessWrap, thanks to Fredrikh
BUG=257988

John Layt committed changes in /trunk/KDE/kdebase/runtime/kcontrol/locale:

KCM Locale fix crash when using language other than en_US.

When you pass a KConfig to KLocale it calls setLocale() on the KConfig using
the KLocales current langauge. If this language is different to the KConfig's
language then a reparseConfiguration() is called to change any localized
settings. However, if your KCOnfig is enitrely in memory then you have no file
to reparse and you end up with null settings leading to crashes.

Fix makes sure that the KConfig and KLocale always have the same langauge set
before passing in the KConfig, thus making sure there's no force reparse and
the settings remain intact.

Aaron J. Seigo committed changes in /trunk/KDE/kdelibs/plasma:

the fix for 242173 in r1140471 broke use cases where the applet is activated and then showPopup(someInterval) is called.

the showPopup call would get made, and then it would be overridden at the next event loop with a timeout of 0 due to the QTimer::singleShot in appletActivated.

this queues _all_ calls to showPopup using a QBasicTimer, which should address the focus issues a bit more comprehensively for 242173 and not break, e.g., the autohide on the device notifier.

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/ui/taskarea.cpp:

Task objects may disappear on us while waiting for a relayout

Alex Merry committed changes in /trunk/KDE/kdelibs/solid/solid/backends:

Use PowerDevil's method of dealing with activatable services.

This should prevent connect() warnings when UDisks/UPower is not installed, but also ensure the service is activated if it is.

Lukáš Tinkl committed changes in /trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksstorageaccess.cpp:

check the mount point list before returning the first item, should fix a crash

Marco Martin committed changes in /trunk/KDE/kdelibs/plasma/extenders/extender.cpp:

auto resize at most at a third of the screen size.
this is still not perfect (should also take into account the user custom resize)
but avoids the widget being resize to completely ridiculous sizes

Peter Penz committed changes in /trunk/KDE/kdebase/apps/dolphin/src/views/viewproperties.cpp:

If "Use common view properties for all folders" is checked, the optimized view-modes for trash and searching should be replaced by the common view properties too.

FIXED-IN: 4.6.0

Jonathan Riddell committed changes in /trunk/KDE/kdelibs/kdeui/util/kcrash.cpp:

Description: declare the process that will be debugging the crashed KDE app.

Author: Kees Cook
Bug-Ubuntu: https://launchpad.net/bugs/589841

Peter Penz committed changes in /trunk/KDE/kdebase/apps/dolphin/src/views:

Fix issue that 2 files get deleted in the details-view instead of 1 when Shift+DEL is pressed for a longer time (and the confirmation dialog has been turned off).

FIXED-IN: 4.6.0

Peter Penz committed changes in /trunk/KDE/kdebase/apps/dolphin/src:

Fix issue that the enabled state of the "Create New..." menu is not updated correctly in the column-view.

FIXED-IN: 4.6.0

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer/appletsfiltering.cpp:

close the add widgets interface when going to get new widgets

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma/desktop/applets/tasks:

implement isPopupShowing (other applets are PopupApplets which do this for them)

Marco Martin committed changes in /trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/itemcontainer.cpp:

to show the correct items on all views without the qgv cache getting in the way, it seems to be necessary ItemCoordinateCache

Marco Martin committed changes in /trunk/KDE/kdebase/workspace/kcontrol/workspaceoptions/workspaceoptions.cpp:

actually restore, not only save the custom titlebar buttons positions

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelview.cpp:

adjust the shadow window geom on resizeEvent, just as it is with moveEvent. good chance it's the cause of ..

Giulio Camuffo committed changes in /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelapplethandle.cpp:

check for containment and corona validity, before using them.
they could be null if the applet was removed from the scene.

Marco Martin committed changes in /trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp:
Marco Martin committed changes in /trunk/KDE/kdebase/workspace/plasma/netbook/shell/plasmaapp.cpp:

eck for m_unHideTimer existence

Martin Gräßlin committed changes in /trunk/KDE/kdebase/workspace/kwin/effects/flipswitch/flipswitch.cpp:

Show desktop in flip stack when desktop should be shown.

Alex Fiestas committed changes in /trunk/KDE/kdelibs/solid/solid/backends/udev:

Fix support for AudioInterface in the udev backend by reimplementing some missing functionality from HAL

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1207126
David Faure committed changes in /trunk/KDE/kdelibs/kdecore/kernel/kstandarddirs.cpp:

findExe: do not look into the "exe" resource explicitely if KDE is installed into /usr. In that case
we know it will be part of the $PATH, and we better honour the ordering of $PATH.

I still want to keep the "exe"-lookup when KDE is in a custom prefix, so that it works [better]
even if $PATH doesn't have the custom prefix.
Kudos to Matthias Fuchs and Daniel Hahler for the complete investigation.

FIXED-IN: 4.6

Manuel Mommertz committed changes in /trunk/KDE/kdelibs/plasma:

allow SharedSvgRenderer to put interesting elements in the rect cache on load
fixes the detection of svgs that use a style for system colors

Harald Sitter committed changes in /trunk/KDE/kdebase/runtime/phonon/libkaudiodevicelist/hardwaredatabase:
Lukáš Tinkl committed changes in /trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/backlighthelper.cpp:

- adjust to work also with the nvidia proprietary driver which creates
/sys/class/backlight/nvidia_backlight
- take acpi_video0 into account first in case of switachable graphics

Thomas Lübking committed changes in /trunk/KDE/kdebase/workspace/kwin:

commiting http://svn.reviewboard.kde.org/r/6120/#review9304
this should improve v'syncing, maybe v'synced "smoothness"
remaining and exposed issue are "dirty textures" w/o damage events (see the requst description)
can be diminished by increasing MaxFPS above the fastest update (or shadowed below the slowest one)

KDE-PIM

Tobias Koenig committed changes in /trunk/KDE/kdepimlibs/akonadi/favoritecollectionsmodel.cpp:

Do not stop showing favorite collections if the config file contains out-dated favorite entries.

Tobias Koenig committed changes in /trunk/KDE/kdepim/messageviewer/markmessagereadhandler.cpp:

Do not mark messages as read if 'Mark message as read after' option has been unchecked.

Tobias Koenig committed changes in /trunk/KDE/kdepim/kmail/kmcommands.cpp:

Do not create a fake Akonadi::Item, the message viewer expects a real one if showMessage(Akonadi::Item) is called.

Use showMessage(KMime::Message::Ptr) instead, this can deal with plain kmime messages.

Laurent Montel committed changes in /trunk/KDE/kdepim/kmail:

Fix change to default trash when we remove a folder which is a trash used by imap account
(need to backport to 4.4.x)

Tobias Koenig committed changes in /trunk/KDE/kdepim/mailcommon/foldertreeview.cpp:

Restore the ToolTipDisplayRole correctly from the
config file.

Tobias Koenig committed changes in /trunk/KDE/kdepim/kmail/kmmainwidget.cpp:

Show 'Manage Local Subscription' menu entry only for IMAP folders

Sergio Luis Martins committed changes in /trunk/KDE/kdepimlibs/kcalcore/icalformat_p.cpp:

Recurring to-dos work again.
Before KCalCore, the date of the current to-do occurrence was stored in the RECURRENCE-ID property. With KCalCore, that had to be removed, because the RECURRENCE-ID property was needed to implement the recurrence-id features.
This commit makes Todo::dtRecurrence() to be saved in an X-property, so it persists, like it did in KDE 4.4.

Ingo Klöcker committed changes in /trunk/KDE/kdepim/messageviewer/util.cpp:

Show error message if an attachment could not be saved (e.g. because there's not enough space left on the hard disk).
Patch by George Metaxas

Tobias Koenig committed changes in /trunk/KDE/kdepim/messageviewer:

Further fixes to prevent conflict dialog

Block multiple calls of MessageLoadedHandlers for the same message caused by asynchronous rendering through mementos

Sergio Luis Martins committed changes in /trunk/KDE/kdepim/libkdepim:

Make subcategories work in korganizer.
" SubCategory" was being compared to "Category:SubCategory", and that failed.
We must use the same role in both sides.

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/contacts/mainview.cpp:

Do not crash if the ldap import dialog is called from Home context

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/calendar/agendaviewitem.cpp:

Always go backward/forward 7 days for work weeks

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/tasks:

Fix the lessThan operator to do proper thread grouping and resort model as soon as task status changes.

Tobias Koenig committed changes in /trunk/KDE/kdepim/runtime/resources/kolabproxy/kolabbase.cpp:

Always write out the creation-date and last-modification-date in Zulu time to be compatible with Kolab storage format.

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/tasks/mainview.cpp:
Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/mail:

Use the identity BCC addresses when composing mails.

Now the BCC addresses are applied initially on the new message
and updated whenever the user changes the identity via the identity combobox
in the composer.

Torgny Nyblom committed changes in /trunk/KDE/kdepim/kmail/kmsystemtray.cpp:

Partly fix the tray icon not showing message count.
Still need to figureout how to scale the text. The old way seemed to
make the text realy realy tiny.

Torgny Nyblom committed changes in /trunk/KDE/kdepim/kmail/kmsystemtray.cpp:

Fix the missing part of the unread message count in systemtray.
Text now scales to fit.

Till Adam committed changes in /trunk/KDE/kdepim/runtime/resources/imap/moveitemtask.cpp:

Don't crash when the target collection has no next uid attribute.

Mehrdad Momeny committed changes in /trunk/KDE/kdepim/blogilo/src/backend.cpp:

Blogspot(GData) doesn't support fetching drafts.

Office

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney:

Don't import zero prices from GnuCash
Print more details about the price to the console

Thomas Baumgart committed changes in /branches/kmymoney/4.5/kmymoney:

Don't import zero prices from GnuCash
Print more details about the price to the console

Backported to stable branch

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp:

Delete transaction editor upon an exception

Thomas Baumgart committed changes in /branches/kmymoney/4.5/kmymoney/converter/mymoneystatementreader.cpp:

Delete transaction editor upon an exception

Backported to stable branch

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney/converter/webpricequote.cpp:

Detect and use correct character decoder when scanning web-pages for price information

Stephane Mankowski committed changes in /trunk/extragear/office/skrooge:

Corrections for right to left language

Alvaro Soliverez committed changes in /trunk/extragear/office/kmymoney/kmymoney:

In price reports, only show a value if a price actually exists.
Patch originally contributed by Bernd Gonsior

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 1206085
Boudewijn Rempt committed changes in /branches/koffice/2.3/koffice/krita/plugins/paintops/defaultpaintops/smudge/kis_smudgeop_settings_widget.cpp:

Uncheck the pressure size option by default for smudge

Cyrille Berger Skott committed changes in /branches/koffice/2.3/koffice/krita/ui/kis_preference_set_registry.cpp:

Temporary fix for an exit crash, that happen after opening the settings dialog.

Reviewed by Adam and Boudewijn.

Cyrille Berger Skott committed changes in /branches/koffice/2.3/koffice/krita/image:

Fix: race conditions that happen mostly on systems with more than four cores.

Backport of 0a253ac8d265ac4bf5fdb805bf6ff7fba8d00170

Patch by dmitry, tested by Sven.

Cyrille Berger Skott committed changes in /branches/koffice/2.3/koffice/krita/CMakeLists.txt:

Ensure that OpenCTL and OpenShiva are visible to llvm. This is a workaround a bug in OpenGTL that does not load those library when installed in /usr/lib

Cyrille Berger Skott committed changes in /branches/koffice/2.3/koffice/krita/plugins/filters:

disable smalltiles, oilpaint, sobel filters, since they are broken

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp:

Make sure to delete the transaction editor before the dialog in any case to avoid crashes.

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney:

Improve handling if a file is loaded with an invalid base currency assignment

Benjamin Port committed changes in [calligra/stage-oulinemode-bport] kpresenter/part/KPrViewModeOutline.cpp:

Synchronise active page when launching outline mode

Multimedia

Raphael Kubo da Costa committed changes in /trunk/kdesupport/taglib-extras/taglib-extras/tfile_helper.cpp:

Add __DragonFly__ to the wcscasecmp #ifdef.

Fixes build on DragonFly BSD.

Original patch by Alex Hornung <alexh AT dragonflybsd DOT org>, thanks!
Ack-ed by Jeff Mitchell on IRC.

Networking Tools

Christian Weilbach committed changes in /trunk/playground/ioslaves/kio_magnet:

Adjusted to new stream dbus interface in KTorrent. Fixes.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1205728
Pau Garcia i Quiles committed changes in /trunk/KDE/kdenetwork/kopete/protocols/jabber/jabbercontactpool.cpp:

Explicitly disallow file transfers for Facebook contacts.

A better, more generic solution would be to check whether the Jabber server
supports (allows?) file transfer, but I don't know XMPP or Kopete enough to
do that and, well, this itches my scratch.

Utilities

Raphael Kubo da Costa committed changes in /trunk/KDE/kdeutils/superkaramba/src/CMakeLists.txt:

Fix build on DragonFly BSD.

DragonFly needs to link to libkvm, just like FreeBSD.

Tony Murray committed changes in /trunk/KDE/kdenetwork/krdc/mainwindow.cpp:

Check if the widget being closed is the new connection page, instead of the current widget.

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

now that we use the animation classes even for non animated changes,
wall building in scoring game did no work anymore.

Other

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/installer/ApplicationModel:

- Fix the action button not returning after cancel.
- A few more bits of polish

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/installer:

Fix a bug where a transaction cancelled due to an authorization error/cancelment wasn't removed from the transaction stack, as well as a bug where the ApplicationDelegate would not repaint after a cancel until the next mouseover.

Barth Netterfield committed changes in /branches/work/kst/portto4/kst:

A bunch of pre-flight fixes and upgrades:

-Fix bug with a link changing under a data source.
-Add an export vectors dialog.
-Fix up the export log message dialog.
-Add a read-to-end button in the toolbar.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision 1207487

Features

Development Tools

Simon Edwards committed changes in /trunk/KDE/kdebindings/python/pykde4/sip:

First big PyKDE4 update for the coming KDE 4.6.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 164 more) Revision 1206522

Educational

Aleix Pol Gonzalez committed changes in /trunk/KDE/kdeedu/kalgebra:

Let the user save 2D graphs without file extension.

Akarsh Simha committed changes in /branches/kstars/code-in/doc/kstars:

Commiting Ana-Maria Constantin's work on the "Telescopes" section of
the Astroinfo project. While I still have improvements to suggest and
maybe even some corrections to make, I thought this work could get
commited since it was already usable.

Thanks Ana! I hope we can polish this work a little more before we
close this task.

Note that I made a couple of changes to Ana's docbook file -- I fixed
a couple of syntax errors, and a small typo that prevented it from
compiling.

In addition to that, I also added the new article into the
indexes. I've created a new section called "Instrumentation" to adopt
this article under the Astroinfo project.

Diffs: 1, 2, 3, 4 Revision 1206655
Peter Hedlund committed changes in /trunk/KDE/kdeedu/kwordquiz/src:

Correct codec for html export. Printing enhancements

Graphics

Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core/libs/database/imagehistory/imagehistorygraph_boost.h:

Add some new features to the graph implementation.
Includes a DFS which allows to sort the vertices at discovery with a given lessThan.

Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core/libs/database/imagehistory:

First thorough implementation. Provides three modes:
1) a flat list. Images are sorted by depth first search,
in which edges are accessed modification date time order
2) a simple tree. Same order as above, but with added depth.
3) A combined view with FilterActions available. Uses longestPath
to get a main path. After the current item is reached on the path,
all leaf images (current versions) are listed flat,
with intermediates below a subitem (currently effectively hidden)

Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core/libs/imageproperties:

Adapt to new model.
Implement special items like categories and separators.
Strictly use style and styled item delegate,
avoid hardcoded sizes with a few small exceptions.

Sandro Andrade committed changes in /trunk/kdereview/controlflowgraph:

Supporting interruption also for interactive graph generation

Pau Garcia i Quiles committed changes in /trunk/KDE/kdegraphics:

Initial port of KSnapshot to Windows.
For now, just disable X11-specific stuff (child window, window under cursor). I'll implement that later.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1206685
Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core/libs/dimg/filters/icc/iccsettingscontainer.cpp:

I saw the color management is still disabled by default.

This means pictures with color profile are shown, simply
and plain, in wrong colors. I think the CM has matured enough:
It should be enabled by default, in a way that the user does not
notice it at all, using sRGB as workspace profile, never popping up any dialog.

Pau Garcia i Quiles committed changes in /trunk/KDE/kdegraphics/ksnapshot/kbackgroundsnapshot.cpp:

Make kbackgroundsnapshot fullscreen capture work on Windows as a feature instead of by accident

Albert Astals Cid committed changes in /trunk/KDE/kdegraphics/okular/core/document.cpp:

Implement memory functions for freebsd
Patch by Alberto Villa

KDE Base

Christoph Cullmann committed changes in /trunk/KDE/kdelibs/kate/syntax/data/latex.xml:

mludwig:
Add support for the 'comment' environment from the 'comment' package.

Patch by Mitchell Keith Bloch.

Tomaz Martins dos Santos Canabrava committed changes in /trunk/playground/libs/KWelcomeWidget:

preliminary code for KWelcomeWidget

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 1205921
John Layt committed changes in /trunk/KDE/kdelibs/kdecore:

Change algorithm used in calculating Indian National calendar to use the real
formulas defined by the reform comittee rather than a conversion from
Gregorian which should be quicker and more robust.

Tested to confirm match exactly with the old formulas.

Kevin Ottens committed changes in /trunk/KDE/kdelibs/solid:

Seems the new backends now work good enough. So retire the old HAL
backend on Linux, it's still the default on other unices though. On
Linux it can be reactivated using the SOLID_HAL_LEGACY environment
variable.

Patrick von Reth committed changes in /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt:

activated solid upnp for windows

Dario Freddi committed changes in /trunk/KDE/kdebase/workspace/powerdevil/daemon:

Add capabilities to the backend, and expose it to the bus

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1206695
Friedrich Karl Tilman Pülz committed changes in /trunk/playground/base/plasma/applets/publictransport:

Added a widget to show/change the currently active filters.
Combined "writeSettings" and "writeNoGuiSettings", added new "Changed_X"-enum-Values.

Diffs: 1, 2, 3, 4 Revision 1206766
Friedrich Karl Tilman Pülz committed changes in /trunk/playground/base/plasma/applets/publictransport:

Added a button "Open in TimetableMate..." to the accessor info dialog.

Friedrich Karl Tilman Pülz committed changes in /trunk/playground/base/plasma/runners/publictransport:

New publictransport runner, using the publictransport data engine.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 1206835
Dawit Alemayehu committed changes in /trunk/extragear/base/kwebkitpart/src:

- Implemented support for the automatic ad filtering feature. Now the automatic
ad filtering functionality should work exactly as it does in khtml except for
the UI related stuff. That however is outside the scope of kwebkitpart and
needs to be addressed in the adblock plugin itself.

KDE-PIM

Tobias Koenig committed changes in /trunk/KDE/kdepim/messagecore/stringutil.cpp:

Enable the 'replace dot by underscore in filenames' feature
only in enterprise build where the user base might not be familiar
with the special meaning of dots in filenames.

David Jarvie committed changes in /trunk/KDE/kdepimlibs/akonadi:

Add method to select default pages to display.
http://reviewboard.kde.org/r/5855

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile:

Add new long-press indicator icon from Nuno

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/calendar:

Add show timeline context action

Tobias Koenig committed changes in /trunk/KDE/kdepim/libkleo/ui/keyselectiondialog.cpp:

Bring back the key search line edit in mobile ui

Tobias Koenig committed changes in /trunk/KDE/kdepim/kaddressbook/mainwidget.cpp:

Disable the Grantlee-based contact viewer.

Grantlee in the version that is registered as dependency for KDE 4.6
does not support i18n strings, therefor we can't use it yet in an official
release.

This feature will be introduced in KDE 4.7

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/mail:

Add context action to viewer to switch HTML/plain-text mode

The viewer specific context action is preset with the folder wide
HTML/plain-text mode settings.

Diffs: 1, 2, 3, 4 Revision 1206980
Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/mail:

Add context action to invoke 'Apply Filters' on single
email or all emails from current folder(s)

Diffs: 1, 2, 3, 4, 5 Revision 1206993
Quentin Denis committed changes in /trunk/playground/pim/kmobiletools/kmobiletools/engines/gammu_engine:

port to the new engine

Diffs: 1, 2, 3, 4, 5 Revision 1207266
Quentin Denis committed changes in /trunk/playground/pim/kmobiletools/kmobiletools:

New device info page and working information + status queries in the gammu engine

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 1207589

Office

Stephane Mankowski committed changes in /trunk/extragear/office/skrooge:

FEATURE: Change icon on bookmarks

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1207077
Thomas Zander committed changes in /trunk/koffice:

Add support for colored bullets.
Author : Nandita Suri. Thanks to her!

Diffs: 1, 2, 3, 4 Revision 1207474
Stephane Mankowski committed changes in /trunk/extragear/office/skrooge:

FEATURE: Import csv supports more than one "category" column

Diffs: 1, 2, 3, 4 Revision 1207617

Networking Tools

Christian Weilbach committed changes in /trunk/playground/ioslaves/kio_magnet:

Works now as intended. Still problems with KLauncher to fire up KTorrent when needed...

Diffs: 1, 2, 3, 4, 5 Revision 1206054

User Interface

Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

new mimes 32x32, 120 to go (more tomorow)

Diffs: 1, 2, 3, 4 Revision 1205683
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

new mimes 32x32, 90 to go (aparently 8, that means tomorrow more icons)

Davide Bettio committed changes in /trunk/KDE/kdebase/workspace/wallpapers:

Added Horos. The new default wallpaper (created by Nuno Pinheiro).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 1206143
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

new mimes 32x32, 11 to go (29, more tomorrow)

Diffs: 1, 2, 3, 4 Revision 1206839

Other

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/installer/ApplicationDetailsView:

Add a KRatingWidget next to the application icon/name/description in the header to display the popcon rating.

Pali Rohár committed changes in /trunk/KDE/kdenetwork/kopete:

Enable iLBC codec support in libjingle again
Added ringtone for libjingle voice calls

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 1207531

Optimization

Educational

Thibaut Gridel committed changes in /trunk/KDE/kdeedu/marble/src/lib:

Do not make use of that many data roles from model when one knows that much of the model itself.
This spares a lot of casts and variants.

Etienne Rebetez committed changes in /trunk/KDE/kdeedu/kalzium/src:

reimplementing size hint and making the first start of kalzium look better.

Bernhard Beschow committed changes in /trunk/KDE/kdeedu/marble/src/lib:

cleanup StackedTileLoader

* The StackedTileLoader doesn't calculate the visibility of layers on the fly any more.
Instead, it gets a list of layers that it should handle.
Visibility changes of layers are signalled to the TextureLayer which re-calculates
the list of visible layers and passes the new list to the StackedTileLoader.
See TextureLayer::Private::updateTextureLayers().

* The TileLoader used to hold all GeoSceneTextures from all map themes and continues
to do so. However, it now manages the set of GeoSceneTextures itself rather than
relying on the StackedTileLoader.
See TileLoader::updateTextureLayers().

Diffs: 1, 2, 3, 4, 5, 6 Revision 1207518

Graphics

Marcel Wiesweg committed changes in /branches/extragear/graphics/digikam/core:

Code factorization: With these changes, the ImageDelegateOverlay is independent
from any special view or delegate class and can be reused.

Overlays can still declare to depend on a certain type of delegate.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 1205893

KDE Base

Dawit Alemayehu committed changes in /trunk/extragear/base/kwebkitpart/src/CMakeLists.txt:

- Get rid of the confusing "libkwebkit" library because
** It has been superceeded by libkdewebkit in terms an API library.
** KPart plugins no longer need to link directly against the parts they
support thanks to the new plugin interface APIs.

Albert Astals Cid committed changes in /trunk/KDE/kdelibs/plasma:

Replace slow foreach constructs with faster ones
Acked by Marco

Pascal Létourneau committed changes in /trunk/KDE/kdelibs/kate/view/kateview.cpp:

Optimization:
Clear selection range (it's moving range) before removing text

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma/desktop/shell:

* get rid of the delayedUnhide code -> it wasn't even being used anymore!
* correct signal/slot connection for autohiding
* don't autohide if the panel is asking for attention
* autohide when the panel is no longer asking for attention
* drop the should-we-autohide poll down to 500ms from 200s

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/libs/plasmagenericshell/widgetsexplorer:

* re-use the OpenAssistant dialog if already shown (now that it's non-modal this matters; kills that TODO)
* bring the #includes into this centry

Peter Penz committed changes in /trunk/KDE/kdebase/apps/dolphin/src:

Keeping DolphinDirLister and DolphinModel as DolphinViewContainers members is not needed anymore, as all the handling is encapsulated inside DolphinView in the meantime. The moving of the dirlister- and model-construction will be done after the 4.6 release, as some internal API adjustments are necessary.

Friedrich Karl Tilman Pülz committed changes in /trunk/playground/base/plasma/applets/publictransport:

Created new model classes LocationModel and ServiceProviderModel, now used instead of QStandardItemModel.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 1206769
Peter Penz committed changes in /trunk/KDE/kdebase/apps/dolphin/src/settings/general:

Remove the dynamic "Configure Tooltips..." button. The tooltip configuration is context specific anyhow and can be done inside the properties dialog.

Jeremy Paul Whiting committed changes in /trunk/KDE/kdelibs/plasma/private/packages.cpp:

Remove previous "preferred" file definition when path changes with single image paths.

Thomas Lübking committed changes in /trunk/KDE/kdebase/workspace/kwin/effects/presentwindows/presentwindows.cpp:

respect "ignore minimized" for all modes (except tabbox)

Lukáš Tinkl committed changes in /trunk/KDE/kdebase/workspace/powerdevil/daemon:

This patch adds a fallback mechanism for setting the display brightness
to the PowerDevil upower's backend using the udev
(/sys/class/backlight/) interface. It uses the KAuth framework to setup
a helper application that does the actual read/writes.

Reviewed by drf: http://svn.reviewboard.kde.org/r/6141/

Marco Martin committed changes in /trunk/KDE/kdelibs/plasma:

the dialog private is in its separate file cause it gets accessed by popupapplet to set an applet pointer

in this way we can use the corona to actually find out the real desktop geometry, that doesn't fail for extended monitors like QDesktopWidget does.

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/kmenuedit/preferencesdlg.cpp:

one of the benefits of plasma getting bug reports for _everything_ is i end up seeing things that bug me while triaging them ... e.g. the config dialog of kmenuedit. so:

* Misc -> General (i18n'd elsewhere in kmenuedit already, so no string breakage)
* give it an icon
* move it above spell check config as per most KDE apps
* add a spacer to the bottom of the layout so the UI is at the top, not floating in the middle vertically
* get rid of the superfluous groupbox

KDE-PIM

Tobias Koenig committed changes in /trunk/KDE/kdepim/libkleo/ui/keyselectiondialog.cpp:

Remove the 'Search for External Certificates' button in mobile UI

We have a 'Start Certificate Wizard' at the bottom of the dialog already
to start Kleopatra, and the functionality behind the search button is currently
just a forward call to the implementation of the start wizard button.

Tobias Koenig committed changes in /trunk/KDE/kdepim/mobile/lib:

Allow to repopulate the model on dataChanged signal of source model

We store the complete Item object in the ThreadGrouperModel to return
the thread leader or thread descendants on request. However if they change
in the EntityTreeModel we are not notified about that and our internal items
are not updated. As a fast fix we allow to repopulate the model on every
dataChanged signal of our source model. A smarter way would be to updated the
cached items or only store the QModelIndex of the sourceModel and request the
item on the fly.

Till Adam committed changes in /trunk/KDE/kdepimlibs/akonadi:

Compress progress updates to dbus to one per second per collection.

Office

Thomas Zander committed changes in /trunk/koffice:

Avoid API confusion, rename borderInsets to fetchInsets

In KoShape there is both a border and a shadow that you can set,
both of which have insets. A confusing moment ensued when asked
asked the question why there was no shadowInsets() but there is
a borderInsets().

Turns out that the answer is that one occupies space insde and the
other outside the boundingrect. So lets avoid the API naming
'border' and thus avoid having to know about this distinction.

Also change the API slightly to avoid copying mania, instead
pass in the object and just fill it.

Diffs: 1, 2, 3, 4 Revision 1205756
Cristian Oneț committed changes in /trunk/extragear/office/kmymoney/kmymoney/widgets:

Changed the UI usage from inheritance to composition to avoid intermodule dependencies like 'settings' depending on 'widgets' and the ui header is not yet generated in 'widgets' but it's included in settings.

Composition make the classes header less dependent on other headers.

Multimedia

Aurélien Gâteau committed changes in /trunk/KDE/kdemultimedia/kmix:

Start with a decently sized window

User Interface

Marco Martin committed changes in /trunk/KDE/kdebase/runtime/desktoptheme/air/widgets:

massively optimize: remove all the empty useless elements

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision 1205887
Marco Martin committed changes in /trunk/KDE/kdebase/runtime/desktoptheme/air/widgets:

remove tons of empty items

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1206122
Marco Martin committed changes in /trunk/KDE/kdebase/runtime/desktoptheme/air/translucent/widgets/panel-background.svgz:

border slightly more transparent

Marco Martin committed changes in /trunk/KDE/kdelibs/plasma:

disable borders near to the edge of the screen for extenders too

Alex Fiestas committed changes in /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp:

Use the processed text instead of the raw message (which otherwise is not being used anywhere), and reduce the elidedText to 3 lines

Rafael Fernández López committed changes in /trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp:

Notifications graphical changes:
* The body layout sets a 0 spacing, so there is a small amount of space between icon, message and buttons.
* The preferred width of the message label is 0, so it can still grow to a reasonable size and still be usable.
* The bigIconRect() was uniting the two rects (small icon and big icon), thus making long titles to overlap with the big icon itself. Big icon now is in its place.

Aurélien Gâteau committed changes in /trunk/KDE/kdepim/akregator/src:

More usable column widths:

- Resize the title column when ArticleListView is resized.
- By default, hide the feed column in feed mode.
- By default, set the date column wide enough to fit all dates.

Aurélien Gâteau committed changes in /trunk/KDE/kdepim/akregator/src:

Nicer subscription list columns

- By default, only show title column
- If unread column is not visible, append unread count to title column

Diffs: 1, 2, 3, 4 Revision 1207042
Hugo Pereira Da Costa committed changes in /trunk/KDE/kdebase/workspace/kstyles/oxygen/oxygenstyle.cpp:

Fixed positioning of text and icon in rlt mode.

Utilities

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/updater/UpdaterWindow.cpp:

Use the more efficient areChangesMarked() function to determine whether or not to enable the apply button should be enabled

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

restructure: Only def animate() decides whether to really animate
or to shortcut the animation. Allow for empty ParallelAnimationGroup.
Do not animate if the ParallelAnimationGroup holds too many animations
which would make it too slow.

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src/tile.py:

GraphicsTileItem: Cache: while moving use the faster ItemCoordinateCache.
When tile reaches final position, use the better DeviceCoordinateCache

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

For now disable animation for shuffling, wall building and initial
deal - this needs fast hardware or the raster graphicsengine

Other

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/installer/ApplicationModel:

Optimize: Create one KRatingPainter in the constructor, and don't create a new one for every paint()

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/libqapt/src:

Added an areChangesMarked() function to provide an easier way to check if there are pending changes without checking the emptiness of the QApt::PackageList that Backend::MarkedPackages() constructs and returns

Jonathan Michael Thomas committed changes in /trunk/extragear/sysadmin/muon/installer/ApplicationWindow.cpp:

Use the new Backend::areChangesMarked() function.
This avoids constructing a QApt::PackageList as well as 67,000 calls to QApt::Package::state() in the Backend::markedPackages() function

Other

KDE Base

Aaron J. Seigo committed changes in /trunk/KDE/kdebase/workspace/plasma/netbook/containments/sal/sal.h:

more unused QueryMatch members found and terminated.

"I am the termahnaytah, a rob-aht from tha few-chah. The Queery Matches must be eliminated. *flex*"

Office

Robby Stephenson committed changes in /tags/tellico/2.3.2:

Tellico 2.3.2

Networking Tools

Pino Toscano committed changes in /trunk/playground/network:

aki and akiirc moved to git.kde.org since some time

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 1205884