Revision 1205756

Go back to digest for 19th December 2010

Optimization in Office

Thomas Zander committed changes in /trunk/koffice:

Avoid API confusion, rename borderInsets to fetchInsets

In KoShape there is both a border and a shadow that you can set,
both of which have insets. A confusing moment ensued when asked
asked the question why there was no shadowInsets() but there is
a borderInsets().

Turns out that the answer is that one occupies space insde and the
other outside the boundingrect. So lets avoid the API naming
'border' and thus avoid having to know about this distinction.

Also change the API slightly to avoid copying mania, instead
pass in the object and just fill it.

File Changes

Modified 4 files
  • /trunk/koffice
  •   /libs/flake/KoShape.cpp
  •   /libs/flake/KoShape.h
  •   /plugins/textshape/Layout.cpp
  •   /plugins/dockers/shapeselector/RightClickStrategy.cpp
4 files changed in total