Anselmo L. S. Melo
|Commits||1749 by 162 developers|
|Bugs Opened||678 in the last 7 days|
|Bugs Closed||588 in the last 7 days|
|Hugo Pereira Da Costa||
|Jonathan Michael Thomas||
|Albert Astals Cid||
|Aaron J. Seigo||
Internationalization (i18n) Status
|Brazilian Portuguese (pt_BR)||
|British English (en_GB)||
|Low Saxon (nds)||
|Aaron J. Seigo||
|lamarque gmail com||
There are 137 selections this week
Fix detection of whether git-stash is needed.
I broke the code that determines whether git-stash is determined in
commit 2b0d0d62481880ffc1e1f0e4820f2944b78610d3. The problem is that
the system() Perl function returns the exit code and miscellaneous
process exit data (such as whether the process failed to run, etc.)
and I actually needed that data.
In the commit I refer to, I switched to my safe_system() which only
returns the exit code and now kdesrc-build thought there was an error
running git, when instead git was returning the proper exit code for
a module with local changes. Thanks to dfaure for the report.
Not closing the bug here in case I merge this somewhere else later.
share pseudo-static members
Do not assert while trying to make recovery copies when the home directory has no space available.
Instead, show a message box, and warn him that recovery failed, and that the app will probably crash if he doesn't free up space.
Ensure that digikam is using the correct version of the dbconfig.xml file.
From now on, if a wrong file is found, a big error message is displayed at startup.
An attempted schema update should fail.
You will need to "make install" after this change.
Update NEWS. These bugs/wishes are fixed in kipi-plugins 2 beta 2.
use a deep copy of demosaiced image to avoid cumulative post-processed changes
Move cache clearing out of ActionPool's destructor, and force Core to trigger cache clearing on destruction.
ActionPool is a global object, hence the destructor won't be called after Core has been deleted.
For this reason, clearing should occur inside Core itself, or upon a restart, thr cache could be corrupted.
return, don't assert, on incidence fetch failure
these asserts get compiled out of production builds, and it is indeed possible with Akonadi, at least currently, to get null results back.
so just live with that.
always check the unhide tool
ugh.. this work on the systemtray is getting ugly; i thought it was
going to be all 4.7 work, but it's turning out like i'll probably want
to have it all in 4.6 as well now that i'm 2 days into it :(
should have used a branch. BAD AARON! BAD!
Do not show error page when the request was blocked by adblock filter.
Other minor code cleanup.
Move DPMS handling in the constructor.
This makes more sense as
1. With the previous approach, DPMS support was queried everytime a profile changed, now it is queried on startup only.
2. It allows to disable DPMS on startup even if a profile has not loaded the action yet.
Add a new method to ActionPool, init(), to load on startup actions which require instant load.
Some actions, such as DPMS, require to be initialized even if no profile explicitly asked for the action itself,
as it might be necessary to perform some changes when the action is disabled.
- Switched back to using javscript to parse forms for login information due to problems
with QWebElement when form inputs are nested inside of a table row.
FIXED-IN: pending for v4.6.1
Temporarily workaround regression with NVIDIA.
KWin's new shaders fail with NVIDIA and present just a black screen
for the ortho shader (generic shader seems to work). Temporarily
disabling the shaders to force a fallback to old rendering code.
Of course the bug in the shader needs to be fixed.
Add new interface for kfileitem-action-plugins, to solve the "const" issue and deprecated the current one.
Yes, all this for a const, but that const makes writing plugins quite troublesome (const_cast or mutable), as afiestas found out.
(cherry picked from commit 6cb49dc9da47e314f1552a6059ec15318158dbda)
Fix change compression when editing fields: showBookmark was committing changes
and notifyManagers() was leading to a third save and a second full-tree-reload.
Removed these calls, since command::redo does it already.
Also fixed change compression messing up the "old value", so undo didn't restore
the orig value.
Fix crash when a glob file refers to a mimetype that doesn't exist anymore.
This made KMimeType::findByUrl return NULL, which is never supposed to happen.
Fix "undo" undoing two steps, and "redo" redoing two steps
save disabled screens, don't enable by accident
based on a patch by Alexey Chernov
Remove Shadow Effect.
The shadow effect is known to be broken since at least 4.5.
It is unfortunately in a state which makes it difficult to maintain
and the architecture has some serious drawbacks.
Therefore it is the best solution to replace the effect with a new and better
implementation. For more information about the new implementation
please see the discussion on KWin mailinglist
Removing Snow Effect.
The usefulness of the snow effect is doubtable and it is rather
difficult to port the effect to the new rendering architecture
introduced with GLES. It is probably easier to rewrite the complete
effect from scratch, therefore it is removed for now.
I might consider readding it for 4.7.
This kind of "fixes" snow related bug reports.
add Dell backlight interface
Instead of using QProcess to determine the version number of the update-mime-database executable, open it and read its contents directly to extract the version number.
This should fix the freezing issues exhibited in applications like VLC that block SIGCHLD, which QProcess needs to do its job.
See http://lists.kde.org/?t=129572447500001&r=1&w=2 for details on this issue.
Service objects are owned by the caller
don't bother asserting
the methods that call with the assertion don't seem to actually rely
on it, and akonadi is regularly returning non-existent incidences.
Guard ActionCollection with a QPointer.
It seems that kross engine is not prepared for big changes such that happen when lokalize creates a new project.
Do not overwrite the event organizer by own address
If the we are not the event organizer, we have to restore the
original organizer in IncidenceAttendee::save() again, otherwise
it is overwritten and a wrong mail is sent to the organizer on
every change instead of showing a warning dialog to the user.
Disable the quick search in thread content view
As long as the thread content view does not have its own quick search line edit, we disable the one from the message list if we are in thread content view.
Otherwise the filter will act on the message list, clears the current selection and a click on 'Back to Message List' won't have any effect because the call to clearSelection() does not emit any selectionChanged signal if the selection is empty already.
Fix displaying of time in message list
If the messages have 'Date:' headers from different timezones, the sorting algorithm sorts them in the right order, but the list view shows the timezone specific date.
So the user had the impression that sorting is broken, because a mail with 09:25 (GMT) had been placed between 10:28 (GMT+1) and 10:15 (GMT+1).
Delete invitation mail after acted on by default
Fix saving/restoring of 'Mark As' filter
We save the return value of MessageStatus::statusStr() in the config file to restore the message status flag later on.
Unfortunately statusStr() adds a 'U' for every state that is not 'Read'.
So instead of 'G' for 'Important' 'UG' will be saved.
This will fail when restoring the state.
We strip away the unnecessary 'U' for now.
Fix sorting/grouping of incoming messages
We have to resort the message list whenever new messages
are inserted to make it work in 'most-recent-message-in-thread'
Fix crash in NepomukCalendar in NO_NEPOMUK mode
Under certain conditions the NepomukCalendar is deleted and
all its children while the IncidenceFetchJob is still running.
This results in an invalid call to deleteLater() triggered by
the emitResult() call.
Don't make the job a child of the NepomukCalendar to prevent the
Fix encoding for initial invitation mails
During the port from mimelib to kmime the explicit setting of the charset and transfer-encoding has been lost.
Fix Adding a slide layout adds multiple commands
One problem that still existed was that when a view was closed and a new document
opened then muliple commands where inserted when a layout was selected.
Disconnect before connecting again.
Backport commit 131b513a8ab1349d19d43aaa352946d760924416
don't open a new document when deleting the open pane after a close event
Fixed empty folders removing after collection organization.
Fixed crash when trying to load cover for track/album without artist.
Do not show notifications about messages that have already been shown by the approver.
This patch actually splits the handleIncomingMessage() function into two functions, one that shows the message on the window and one that shows a notification, and connects them independently on the incoming message signal.
This way, while the chat is initializing, new incoming messages are shown in the notification area, but not on the chat view.
When the chat view is ready, it processes all the queued messages, which include the ones that were shown earlier on the approver and the ones that were shown while the view was initializing.
Use user modified path for file column in chunks view
Fix QM bug causing torrents to get started when it is not needed
yahoo protocol: Disconnect signals when login fails.
From the original ReviewBoard description:
Basically, sometimes, kopete is displaying in duplicate incoming
messages. Checking my log, I saw the following:
a) yahoo wasn't actually sending the message in duplicate.
b) but YahooACcount::slotGotIm() was called twice on that message
c) somewhere before the problematic thing - and I actually saw many
things being done in duplicate (not just messages), I saw this:
kopete(8352)/kopete (yahoo - raw protocol)
Client::slotLoginResponse: Emitting loggedIn
kopete(8352)/kopete (yahoo) YahooAccount::slotLoginResponse: -1 ,
d) checking code in yahooaccount.cpp - it seems that for that code
(and others), it considers that account is offline, but forgets to
also disconnect all the signals. So, next time user logins (even by
an auto-reconnect), the signals are connected *again* to the same
sources. And that's why it gets to do things 2 times.
This commit contains the disconnection code without the message box
part, which includes new strings and will be committed only to trunk.
Original patch by Cristi Posoiu <cristi.posoiu AT gmail>, thanks!
added "dirty" flag to tabWidgetData, to trigger full tabbar update.
added gdk_default_screen_is_composited method.
Do not force gtk_tree_view_set_show_expanders to true in TreeViewData
Check on gtk_tree_view_get_show_expanders to decide on whether tree lines should be painted or not.
No expander, no tree lines.
Don't call queryExit() when the "Quit" KAction is called.
KApplication::instance()->quit() already calls it for us.
This prevents double exit confirmation when quit via File -> Quit or the Quit toolbar button in the Muon Updater.
add support for Stroustrup and Horstmann bracket modes
add new formatting styles
add preliminary Qt and KDELibs coding styles
they need to be reviewed though and we should make sure it actually resembles the coding guidelines properly
- Improve the missing-declaration assistant so that it uses nice initial names for function-arguments, deduced from the names of the used declarations. for example, when calling a.test(myParam), the declared function will be "void test(int myParam)" instead of "void test(int param1)".
- Use the safe IndexedDeclaration instead of Declaration* in OverloadResolver::Parameter
add support for PointerAlignment (No Change, Name, Middle, Type) in astyle formatter
Add a new field to DataInformation to save the byte order
Following values are possible: FromSettings, Inherit, LittleEndian, BigEndian.
This saved value is then used to read the data instead of always the value from the setting.
This will allow updating some structures - like png which is always big endian - so that they are correct regardless of the current endianess settings and also allow structures containing values of mixed byte order.
This commit also fixes an issue where a value could be written to the wrong offset in the file (only with union members)
Allow setting the byte order of each element in the XML structure definitions.
An extra attribute is added to all elements named "byteOrder".
The following values are accepted: "inherit" (use value from parent, or if there is no parent the default setting), "fromSettings" (use the value from the settings), "littleEndian", "bigEndian".
The value is compared case-insensitively, so even "BiGENDian" will be accepted.
If no value is set it defaults to "inherit".
Allow the "continuous" selection of a tool by double clicking on it
Patch by Raffaele Mancuso cleaned up by me
This will be in KDE 4.7.0
This fixes the original report of bug 161020 so i'm closing it
If there were any other different wish report in that bug, do the proper thing an open a new one
Add Color Label Selector widget to Captions & Tags view, near Rating widget
add new method to context menu helper to assign Color label
Patch iconview context menu to provide Color Label selector.
Patch Metadata Manager to handle color Label information with metadata hub
Patch by Amir Pakdel:
Uses nie:mimeType of the resource to set the "type" and "iconName" of the search result. If the resourse does
not have nie:mimeType property, KMimeType::findByUrl(url) is used instead (in order to find the mime-type
associated with the url of the resource).
When running/opening the search result, preferredService of the mime-type is used in invokation of KRun::run;
therefore, the mime-type of the resource (or its url) indicates the service that would be used to run the resource.
Approved by review request: http://reviewboard.kde.org/r/6338/
Blur ported to GLES.
It now uses a GLShader for GLSL shaders and pushes it using the ShaderManager.
It does not work with the nouveau driver plus GLES, but it works with fglrx + desktop GL 2.x, so I assume it is a driver problem here.
Added the ColumnResizer by Aurelien Gateau to the StopSettingsDialog, to make all labels in the dialog the same width (details widgets, stop widgets, normal widgets).
Needed one addition to be able to remove widgets from the ColumnResizer again (maybe better to automatically do this, with eg. QPointer).
Improve touchscreen handling
By not using the whole area of the widget, but just the area around the
icon / preview on the left for drags, we can still easily drag and drop,
but also flick the list without starting a drag all the time. Much
better for touchscreens this way.
Core profile compatible basic scene rendering.
Adds a shader to render an untransformed scene. renderGLGeometry is not used any more and replaced by generated triangles stored in a GLVertexBuffer.
The GLVertexBuffer has a new attribute to decide whether a core profile compatible rendering has to be performed.
Currently windows and EffectFrames can make use of the new shader.
The shader contains a debug mode which colours all rendered fragments in green. It is currently enabled in scene_opengl.
Rendering transformed geometries (without shader) is currently broken.
And here comes the working OpenGL ES backend
Reflection plane in cube effect and GLSL
Combine built-in vertex with custom fragment shader
ShaderManager supports a new concept to load just a fragment shader from file and use a built-in shader for the vertex shader.
This allows an effect to use a custom fragment shader.
kio_sftp: Added async sftp download support.
Thanks to Philip Lorenz.
Welcome back Cube effect
* cube slide
* basic cube
* Cube Inside effects
* Reflection plane (needs to be done in a shader)
* cube caps
* filled in areas in multi desktop
Added "Sharing" in the transfer KCM together with his options.
The KCM is almost fully working though we're not using any of the
I also added a new setting for "Receiving" called AutoAccept
this is not fileSharing material but I will implement it anyway.
Reflected windows in coverswitch
Reflection plane is still missing
On special request I added showing the reflected windows during the animation when the shader is used
Implement obex ftp server in filereceiver helper.
Obex protocol has to modes "oop" and "ftp". The last one allow
us to share files trhough Bluetooth just like cellphones do.
The ShaderManager provides the built-in shaders for scene and effects.
Scene and effects can simply push one of those built-in shaders or a
custom one on a stack ensuring that the previously bound shader will be
rebound when the shader is poped again.
The class will be extended to not only have built-in shaders but also to
load custom shaders and being the only way to bind a shader at all.
implement the (missing) option to save the LUKS password into KWallet;
(the StorageVolume UUID is used as the key for the password entry)
Reflection plane in Coverswitch and GLES
CoverSwitch uses new concept of combining a custom fragment shader with the
built-in generic vertex shader. This shader is used to render the reflection
plane on top of the reflected windows.
The fragment shader uses two uniform colors for front and back and interpolates
between them based on the texcoords (which are not used for texture lookup).
The reflection plane vertices could be buffered.
Add code to create outlook-compatible invitations
The code is not enabled yet, since we have to find a way to
share config options between different libraries/applications.
Added new widget to select a backend manually
Much improved logging system.
Log is now displayed even if the command is successful.
The style of the log widget is also improved
Merge remote branch 'origin/words-toc-korinek-tvrdy'
* origin/words-toc-korinek-tvrdy: (30 commits)
Fix the rendering of the tab stops in the toc.
o little more robust loading o remove constant right tab position o setup right tab position as widht of the shape o change the condition which selects the blocks to be in the TOC
Coding style fixes and binary compatibility work
Added copyrights and trailing whitespaces removed.
o Saving of the table-of-content-source o Fixing memory leak
Remove superfluous include and comment
Clean the code
Fix the navigation with bookmarks.
Use int here.
some comments removed
pragma changed to not use prototype
toc update can replace page number more than once
o delete the loading data-structure in the destructor (memleak) o use replacement character as suggested by korco
refactoring on using alternative methods for analyze and knowleadge transfer
method loadTableOfContentsPalo is for analyze and knowleadge transfer purposes. Palo's verison means to use generatePalo and loadTableOfContentsPalo methods in KoTextLoader.cpp and TocGenerator.cpp
Created generator method generatePalo for analyze and knowleadge transfer purposes. Toc link generation algorithm desined
Rendering of the TOC index entries
Load also the text in index-title-template
variant pair defined
Added initial GHNS support for examples
Added option to keep the orientation of the image when mirroring.
Also converted the widgetToViewport method back to viewportToWidget.
ScheduleEditor: make it possible to detach a sub-schedule from it's parent to avoid having to work with too many children.
Improved configuration dialog.
Added new option for automatic backend selection
add a widget to be able to select multiple sensors
Improved the ImageView widget and created buttons in the main window
Added option to switch between manual and automatic backend selection
Adding options to configure saving format ( ODF 1.2 or DeltaXML ) and Author Name to Change Tracking Settings Dialog
o use the canvas resource axis center so far
o smoothed version of the stroke painting support
o initialize the GUI according the constructor value of the m_smooth
Adding a new widget to set change tracking options ( start/stop recording changes, show/hide changes ) to TextTool Options
Add more accepted caps so we can support more webcams.
Add more capabilities in the pipeline variating framerate and
Also, in order to add this new data into the pipeline in a clean
way a new private method has been added called "basicPipe" which
returns the first part of the pipeline which is common between
WebcamWidget::playFile and WebcamWdiget::recordVideo.
Brought back the menu button alongside fill status display for better discoverability of the menu.
A lot of people didn't know how to change medium size.
Now the button has "configure" icon and "Set medium size" tooltip.
Use libvlc in the application directory as primary library on Windows to support use cases where everything is bundled together.
Patch by Kamil Klimek.
User Agent Switcher.
This patch should implement the UA switcher ability for rekonq.
This is a first implementation, but it seems working quite well.
It is based on KDE UA management and should be fully compatible with konqueror's one
i.e. it should be possible using alternatively rekonq and konqueror sharing the same setting.
Anyway, this is a different implementation from the konqueror's one.
Simpler and based on the idea of a future moving to a plugin.
Added an option to show current website favicon as rekonq window icon
Reviewed by adjam
Extend the search system in preparation for adding other, non-quicksearch search methods.
Finish support for creating an Application object from a QApt::Package.
This enables us to show packages that aren't necessarily applications, but still are quite interesting to a user. (Fonts, for example)
Speaking of fonts, now that we can actually show them, add a "Fonts" category in the Muon Software Center.
Implement the dnd on projects
Now we can dnd the projects in the same collection or between two differents collections.
- Add onRowsAboutToBeMoved in TodoProxyModelBase and forward call to onSourceRemoveRows.
- Add onRowsMoved in TodoProxyModelBase and forward call to onSourceInsertRows.
- Add moveChildTodo to create the nodes for the children of moved
project in the destination and remove the old nodes.
Initial import of the .deb thumbnailer plugin for KDE
Use the new saveDownloadList and downloadArchives to create a user interface for downloading packages from a list.
Users without internet access can use this functionality to create a list of packages they want downloaded, take it to another computer, download them with Muon's download archives feature, and then take the USB stick back to their computer where they can add the packages to the package cache.
Game dialog redesign, thanks Dave Kaye.
Many settings have also been replaced to match the dialog.
Add the engine for the articleoftheday widget.
Gie some serious usability love to the grepview plugin:
- Don't show check-boxes when only a search was done. Show the check-boxes as soon as something was entered into the "replacement" field.
- Make the "history" line more meaningful: Also show the place where the search was started.
- Also exclude/include patterns around spaces, as the documentation staces.
- Disable the "Apply" button if no replacement text was entered
- Change the label of the "replacement" combobox and of the "Apply" button to "Replacement Text:" and "Replace", to make clearer what the widgets do
- Make the "Collapse All" button only collapse the tree until the "File" level. It doesn't make sense to only show the root item.
- Initially, expand all items automatically.
Greatly improve the capabilities of the "sync" button in the "Find/Replace" dialog.
Now it has a dropdown, where one can select each of the parent directories of the current file up to the project root and each of the open projects.
Additionally, now it is possible to search in "All Open Files" and "All Open Projects".
Further improve startup speed of Okteta.
This commit changes the way the width of the columns in the tree views are calculated. Now they are interactively resizable and not ResizeToContents which is very expensive to calculate.
On my system this reduces the time needed to start Okteta from ~1 seconds to under 500 milliseconds, roughly a fifth of what it was before this patch and the previous one.
Reduce memory usage of the structures tool.
Previously the current value for each element was stored in a union (64 bits) so that the field could be in the superclass.
Now every subclass for each primitive data type has its own member variable of the fitting size.
I.e. if there is a 150 char string withing the structure this already saves ~1K of memory (1050 bytes exactly)
- Don't show manpage documentation for declarations that are not in /usr/
- Don't show manpage documentation for declarations that are in the current project
It was very annoying to see manpage documentation just because the function-name accidentally matches something that has a manpage (for example "test")
Make CalendarSupport::incidences() 100x faster.
This has a noticeable impact with 10k events.
Removed the renderer from libcirkuit and created a more efficient separate threaded class
Send progress updates more frequently.
There is already a limitation on what is send to the user in KoProgressUpdater that only sends
updates only every 0.1 second. Without the change it can happen that the progress is only
reported every 0.4 seconds. With this change the progress bar advances more smooth and does
not jump as without the change.
Only record time values if it is used later.
Improved canvas rotation and mirroring.
- rotation is really smooth now
- it is now possible to rotate and mirror the canvas around an arbitrary point
Improve performance of chunk selection code when there are many chunks
Use QApt::Package::latin1Section() rather than section() when doing a PkgSectionFilter-type filter.
This speeds up filtering by package section ~30% in the Muon Software Center.
Harden SSL verification against poisoned DNS attacks
... in the case of certificates that are issued against an IP address rather than a hostname.
Patch by Tomas Hoger / Red Hat Security Response Team, reviewed by Jeff Mitchell and Richard Moore.
Treats UPS (uptype == 3) as batteries.
Powerdevil still does not treats my UPS as battery but solid-hardware query 'IS Battery' works after this change.
It is a start.
Move kdeplasma-addons to git
- You can find information about the project in the link below:
- And you can clone the repository using:
git clone git://anongit.kde.org/kdeplasma-addons
Thanks eean and all the sysadmins for the help.
start of clipping support
Show non-application packages in PPA views.
The theory behind this is that if a user is advanced enough to add a PPA, he/she probably can handle seeing a few packages.
Additionally, it could very well be that the PPA doesn't have any applications as recognized by app-install-data, so we shouldn't restrict usage of the PPA because of that.
Move the pile layout animation from KCardPile to KCardScene.
This was the last bit of animating code living outside of KCardScene,
causing some ugly workarounds to get specialised behaviour. This commit
doesn't fixed all those, but it should make it easier to do so in the
KCardPile is now only responsible for telling the KCardScene where it
thinks its cards should be placed (in layout space) and the scene
performs the animating and makes adjustments if things don't fit. All
in all this should be much cleaner.
Move the custom multiple step move logic from Freecell to DealerScene.
* Coolo wants to add similar functionality to Forty & Eight, so there
was a desire to abstract the existing Freecell code.
* Moving the code into DealerScene allowed for simpler implementations
in a couple areas.
* While the algorithm used should be unchanged, the code has been
almost completely rewritten and in many cases simplified. The new
implementation is probably less efficient than the previous one
(mostly do to more QList copying) but I think the improved
readability and maintainability are worth it.
* The code now has approximately 1000000% more comments.
Add support for projects.kde.org XML database.
This commit adds initial support for the projects.kde.org XML database as exported by https://projects.kde.org/kde_projects.xml
The short story is, to use the "use-xml-modules" option in a *module-set*. E.g., what I just tested was with
If you want --pretend to work you should throw a module set that uses
XML modules in somewhere and try having the XML-based module built, or
just download kde_projects.xml yourself and plop it right in the base
In theory a grouping module (such as extragear/utils) should allow you
to recursively grab and build every module composed within it.
However, modules that contain a <repo> tag, and then have children
underneath also containing <repo> tags only have the very base <repo>
tag working (if I coded it right ;)
The reasoning for this is to allow module groups where you can build the
entire module, or given subsets of it (e.g. Calligra allows this from
what I can tell, you can build Calligra or assuming you've met the
If a module has no direct <repo> tag, but includes modules or projects
or whatever that each have their own <repo>, then everything should be
kdesrc-build obeys the <active> tag, so modules that claim not to be
active will not be built by kdesrc-build (at this point, even if
directly passed on the command line, although that may change later).
I'm super-tired and won't have time to test throughout much of this
week, so I've put it in a branch. Feel free to test yourself if you're
I'd like to thank Allen Winter who contributed the core XML parsing
code, it was a big boost to getting something working. :)
Update qt-kde repository location.
kde-qt has become qt-kde, and moved from gitorious.org to git.kde.org.
This updates the locations in the kdesrc-buildrc-sample and the built-in configuration.
Rename sponsors because it triggers AdBlock