Issue 179

Check KMimeType::mimeType result for null.

The result is null if the argument represents an unknown mimetype.

Add "include" option for config file (try 2).

I actually did some testing of my last attempt at this, but I'm not sure
in retrospect how kdesrc-build even got something coherent from my first
patch given that I forgot to actually assign the output of the various
read line functions to $_ (which had previously been automatically
done), or how I passed the wrong object type to read_line (now
readLogicalLine).

I've increased the testing performed on the patch and it should actually
work this time. For serious.

Fix the dbus athentication token when passed through the forwarded dbus connection. Now it is possible to forward the connection through ssh, even when the user-id, user-name, or whatever, differs between client- and target machine.

Fix the problem that sometimes the input stream could be read over its end, leading to endless-loops or potentially even crashes. This could also be fixed by appending zeroes to the input, which would be the safer (but uglier) solution.

Fix peeking in astyle string iterator.

Implement a hidden switch that allows to disable automatic msgfmt-like wordwrap at 80 char width.
To enable it add the following lines in the project .lokalize file:

[RegExps]
WordWrap=-1


(to be backported into 4.6)

create states menu even for gettext files (with 'needs review' and 'ready' options).
i think this soultion will satisfy both

and

interpret symlinks for project file and for po/xliff files.

switch to knotification system for displaying fileopen errors.
this way they in particular can be disabled via systemsettings

disable autoadding space on Enter key press for chinese because it doesnt use spaces as European langs do.

anybody knows other languages that don't use space?

Fix some bugs with exporting images:
-Use specified path when exporting plots with multiple pages.
-Make exporting plots with multiple pages work for eps and pdf formats.
-Don't store automatically specified extension in default.

BUG:
Fix crash when attempting to place power spectrum in existing plot.

Don't crash at shutdown when configuring more than one map.

Removes the setParent(NULL) hack. Not a memory leak due to the commit
before which sets a parent on the created widgets.
(cherry picked from commit 699dd5d7cb555a06e4a16602d8c6d7ef2f01f47a)

Add the "Edit Map" action to the KDE application (osm theme only).

Synchronize settings storage between the Qt and the KDE application for
the "edit map externally" action. Add an "Always ask" value.

FIXED-IN: 1.1.0

Fixes: Bug 270712 - Overview map settings storage is broken

RevBy: Daniel Marth, Dennis Nienhüser

(cherry picked from commit 3ab98936c4f895b97d882686893d260e1e20ae08)

apply patch #58766 from Guillame Paumier

apply patch #58767 from Guillame Paumier

when an action is selection from menu view, close menu.
CC

Change GRUB values only when saving.

Use dirty bits to check if a GRUB value was modified and needs updating.

Reverting e831217493451118982629fb747dac04b5628076 and applying a better
solution suggested by André Wöbbeking. Thanks for helping me solve the
MMModemInterface invalid free problem.


(cherry picked from commit a0fc87f7e8ef5b01290a3ca5d2db59928e3d6449)

Re-add KFind shortcut for the Dolphin KPart

When the searching has been integrated into Dolphin the "Find File..."
entry had been removed from the Tools menu. Re-add it into the Dolphin
KPart so that it is still available for Konqueror.


FIXED-IN: 4.7.0

Only show one action for each shortcut, fixes cases where there are
two standard actions using the same shortcut and changes to the first
would be overwritten by the second.

Forward port SVN r1228245 to PyKDE4 git master:

Unbreak Python Phonon bindings. Now it is possible to use a VideoWidget again with a MediaSource object, which would throw a TypeError earlier (this was dueto a missing inheritance of a class). My testing confirms that it now works.
Original patch by Carlos Corbacho (with minimal changes on my part).
Thanks!

Correctly set locale on secondary screens in multi head configurations
REVIEW: 101133

Delegate PgUp/Down and Up/Down +Shift+AppScreen to terminal application.

After this patch, the following in the .keytab will work:

key Up+Shift+AppScreen : "appup"
key Down+Shift+AppScreen : "appdown"
key PgUp+Shift+AppScreen : "apppgup"
key PgDown+Shift+AppScreen : "apppgdown"

Patch by Tomáš Čech


FIXED-IN: 4.7

Fix directory navigation in Dolphin::Terminal.

When navigating in Dolphin it attempts to keep any open Terminal (F4)
in sync by changing the directory in the shell. It does this by
sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C"
as a literal string and not SIGINT. Fix this by sending SIGINT to the
shell instead of "^C".

It appears Linux does not exhibit this behaviour.

Patch originally written by David Naylor, from the KDE-FreeBSD team.



(cherry picked from commit 5f78219e18073e475ed1f1865a1a2be1fafd60cf)

Folders Panel: Don't open the properties dialog modal


FIXED-IN: 4.7.0

KDirSortFilterProxyModel: Fix sorting issues for e.g. search-protocols

For a e.g. search-protocol comparing KFileItem::text() or
KFileItem::name() is not sufficient as it may
show different files with the same filename in parallel. To assure a
defined order a comparison of the URLs is done as fallback.


FIXED-IN: 4.7.0

Add profile option to disable underlining links.

Add a configuration item that allows disabling of the underlined links
on mouse hover. The option is profile specific and defaults to the previous
behaviour where links are underlined on hover.

Patch by Amand Tihon


FIXED-IN: 4.7

Column View: Keep wheel-behavior consistent with other views

Using the wheel in the column view resulted in too big jumps. Keep it
consistent with the details view and icons view.


FIXED-IN: 4.7.0

Using static method KNotification::event() does not work here, creating a
KNotification object does.


FIXED-IN: 4.6.3

Quote/unquote GRUB values only when saving.

Preserve the original (quoted) strings internally, but show them in a
user-friendly manner. Implemented to minimize changes made to internal
structures. Also useful for command substibutions using echo. For
example:

GRUB_DISTRIBUTOR=`lsb_release -i -s 2> /dev/null || echo Debian`

but the user doesn't see this ugly command, he only sees the result.

Let each DolphinMainWindow run in a custom process

A possible crash in one Dolphin window should not result in crashing
other Dolphin windows. Beside this it also prevents issues with
modal dialogs or notifications.




FIXED-IN: 4.7.0

Details view: Fix jumping column-widths

If the view has a width where a horizontal scrollbar is required to
show all columns, an endless loop might get triggered that results in a
periodic jumping of the column-widths.


FIXED-IN: 4.7.0

Do not crash when closing everything before quitting. Set
pointers to 0 after deleting the content.

Bug 267772: don't restore all windows when New Alarm dialog is shown

When the main window is minimised to the system tray icon, and a
message window is also minimised, the New Alarm dialog restored them
when it was displayed. The New Alarm dialog is now an independent top
level window instead of being modal.

Use UTF-8 if the charset can't encode the string.

Hopefully the call to canEncode() won't affect the performance too
much...


(cherry picked from commit 7b75f8a769ef0e40e59dedb1327ff0ed51e63ba9)

Don't skip model indexes.

When the current index is the last child, the first parent's sibling
wasn't being checked.

Thiago, are you sure Ctrl+Minus also skips folders? I can only
reproduce with Ctrl+Plus, and that's fixed now.

Use UTF-8 if the charset can't encode the string.

Hopefully the call to canEncode() won't affect the performance too
much...

Maintain sort order when new articles are added

In Qt 4.7, QSortFilterProxyModels no longer maintain their sort order
unless explicitly told to. This meant that new articles would always
end up at the bottom of the list being displayed, even if the list was
sorted newest-first.

Incidentally, I could have sworn I tried this fix already and it didn't
work.


FIXED-IN: 4.6.0

Fix possible race between item loading and the busy splash timer.

In the rare but theoretically possible scenario that the splash timer
fired between item receiving and item fetch job end, it would result in
the busy splash shown instead of the message.

Handle mailto URLs with non-ASCII names correctly.

The problem was the conversion from QUrl to QString, which made it
impossible to re-parse the URL later.
Avoid this conversion.

Make sure we only have one auto correction menu item

The other one wasn't even connected to anything

Fixing the dash styles in filters

o fix the referencing of the dash style
o move the dash style definition to libmso

Now we generate odf that is displayed
correctly in OpenOffice

fixed stock charts legend handling, brush and pen handling
is still not working as expected

Fix: saving jpg/png when using non-ascii filename

fix crash when saving: there isn't always a changetracker

Fix Crash at start [@ StatusBar::shortMessage]

eliminate use-after-delete cases

Hopefully fix: Amarok crashed on exit

Fix crash with upcomming events

Increase compatibility with OPML directories.

Just ignore the outline type and look for a usable url.

Prevent crash setting cover from current track applet

Fix potential crash identified by valgrind.

AdBlock Improvements:
- implemented "third party" support
- do NOT block first requests (you cannot even see a blank page, sometimes...)



PS:
Alberto, can you pls check this really works for you before backporting to
0.7 and let me know about?
Many thanks for.

Do not show notification for appearing/disappearing access points if
already connected to one.

Fix bug 270345 : URL parser recognizes addresses starting with http:// or https:// only

now smb, ftp links are detected as well


REVIEW: David Edmundson

Per metacontact statistics DB is created only when contact goes online
or when statistics for an offline metacontact is requested.
This improves plugin startup and shutdown times and also helps with UI
responsiveness.

Now shutdown time is proportional to the number of metacontacts that went
online since Kopete has started plus the number of offline metacontacts
that the user requested statistics from. That is better then being
proportional to the number of all metacontacts registered but is not that
good yet.

, 138903

FIXED-IN: 4.6.3

Make Yahoo/Wlm mail notifications persistent.


FIXED-IN: 4.6.3

Re-apply fix for bug 131951. Somehow the fix got lost during KDE 3.x -> 4.x transition.


FIXED-IN: 4.6.3

Clear QPixmapCache since we're never going to reuse the generated icons

Fix some bugs in the tabular wizard.

In detail:
- Added booktabs-support
- Added a line edit to enter the table width for environments which need that
- Some cell types were not translated into LaTeX correctly (p, m, b, X)
- In multicolumn cells vertical lines got dropped sometimes

Patch by Felix Mauch.

Adapt to changes in the Google Maps API: google.maps.Point().toString() now returns floats instead of integers.

do not make matches bold

Make the Spider solver check all cards are face up before moving runs.

This was simply a missing check.

Add menu entry to update comets.dat file.

* Use planetary nebula texture for planetary nebulae

* Use nebula texture for supernova remnants, and not the globular
cluster texture.

Update supported languages list

Sound support was added for five new languages

Optional auto-centering of the map

Add UnixTimeStamp format to the date renaming option

handle absolute pathes as file:// URLs

Add RFC3339 string format support.

Provide KDateTime <-> string conversion for RFC3339 format times.

Allow all standard shortcuts to be edited, not only those used by a
standard action.



DIGEST:

Added option for configuring the 'Do Not Track' feature. It is on by default.
Cleaned up the code.

REVIEW:101124
GUI:

use the tablet keyboard layout, way less tedious and way more suitable for this target device

resources list

Basic applet to test resources visualization. Looks surprisingly a lot
like a stripped down Crystal. Just took about 100 times less to
implement. Thanks Plasma Quick. =)

Add user-visible name to the action collection.

Make also non-file queries work

The metadataengine becomes useful:
- query it with a searchterm, or a URL, and it'll spew out sources with
nepomukurls, that have your query as URL argument
This allows us to list resources from different sources, but also easily
find those that are already loaded (by just ignoring its query);

Make the battery applet to remain inactive when batteries are in "NoCharge" state

Fix , making the battery inactive when it's not charging. The systray
will make the work to show/hide the applet when necessary and the user can configure
it's behavior through systray's config options.

Bonus points for not adding a new option to the applet's settings ;)

Tested with kdelibs and kdebase-workspace, both master branches.

Patch by: Thiago Jung Bauermann
Signed-off-by: Artur Duque de Souza

Main Window: Modern Menu: escape key improvements, focus fixed, alt+f fixed

*Escape key closes the contents area, then second press closes the main menu
*enable Alt+F as accelerator for the main menu
*menu is focused after opening and first menu item is highlighted

added support for parsing and rendering character offsets

character offsets provide a way to position individual character
of a svg text shape other than by using the font specified advance
values. offsets can be specified as absolute offsets to the current
coordinate system or as relative offsets to the last character
position.

Add missing autoshapes

o add Lightning Bolt shape
o add Flow Chart Magnetic Disk

Still to be done:
o fix positions of the shapes

Support vertical alignment of text in the shape as a whole

: add a wallet as a distinct account

libmso: Merging mswordodf/graphicshandler stuff into libmso.

* The defineGraphicProperties f. is now completely merged. However the following graphic-properties
attributes require testing in stage and tables:
style:horizontal-pos, style:horizontal-rel, style:vertical-pos, style:vertical-rel

* Shapes which are still processed by graphicshandler use the client interface so dashStyles work!
There's too much differences compared to the other filters (ppt,xls) to process all shapes by libmso.

And since it's so easy with the new layout code let's add a new feature:
soft page breaks (not inside tables yet though)

Apply patch from

Introduce backends in TagaroAudio.

Only at compile-time, so no additional overhead. A Phonon backend
is now available as a fallback, so OpenAL/SndFile become optional
dependencies. The implementation of the Phonon backend is unfinished.
I'm hoping for Mathias' expertise here.

firefox-like autoscroll look

Add an icon to indicate the origin of an autoscroll action.

Patch by Johannes Tröscher, thanks!

REVIEW: 101068

AdBlock Improvements:
- implemented "third party" support
- do NOT block first requests (you cannot even see a blank page, sometimes...)



PS:
Alberto, can you pls check this really works for you before backporting to
0.7 and let me know about?
Many thanks for.

Make tabbar widget icons follow KDE size changes

Add systemwide connection support for NM 0.8.
There are still some things to fix in this patch, but it easier for me to
fix them if the patch is in the repository, so commiting it.
Many thanks to Gökçen Eraslan and Andrey Borzenkov for working in this
patch.


REVIEW: 100947

Finished full porting of KMLDonkey to KDE4 / Qt4, removing all Qt3 support classes that were still being used. Fixed also a couple of bugs that were lying around for some time in Bugzilla.

Changed version to 2.0.6.


FIXED-IN: 2.0.6


FIXED-IN: 2.0.6

a rough implementation of a new activity switcher

as discussed on the workshop, a wheel on the side of the screen for activities

update of Wesnoth Markup Language

Tabify plugin: make tabs movable

Thanks to Alex Smith for the initial patch!

RPM spec update by Tim Fechtner

Player/Examples: Add a new game draft called 'Jump'n bump'.

My favourite game from the elementary school times and it will establish the
opportunity for us to test the collide background operation properly and
demonstrate that. Moreover it is also a good option for the multiple input
testing and multiplayer gaming even though only just in a simple way.

First version of the new user management

import keymappings from vimrc

add functionality to attempt to import keymappings from a vimrc file.

patch by Korantin Auguste. Thanks!

publiclink plugin

Allows sharing files by creating a public link, no gui yet.

make lokalize preserve PO formatting better when user asks it.
Fisiu: the 80 formatting change was done consiously, to make diffs for KDE l10n look cleaner.
In KDE a msgfmt is applied automatically to all PO files when they are updates to reflect new sources.

please check if the current state is fine for you. maybe some other important changes are needed.

decrease process timeout in include path resolver to 10 seconds from 40k...

if make in -n (dry-run) mode takes longer something is wrong (e.q. infinite loop in qmake - yes that can happen with QtCreator e.g.)

Reduce CPU usage during route interaction.

Avoid recalculation of routes' screen regions if possible. Don't paint
the current route twice.

Factor out code for FPS calculation into SkyMapDrawAbstract class
and comment out actual printing to stderr.

It's somewhat pointless to calculate FPS and then throw it away
but it could be useful for debugging.

Improve polynomial detection for simplification.


REVIEW: 101137

- Move all MSVC pragma into config-digikam.h. If new ones needs to be add in this future, please use this common place.
No need to patch all source code with M$ pragma rules

- Script interface still experimental and uncomplete. I add anew Cmake option to compile all code relevant.
It disabled by default. We need to find a new contributor to finalize this implementation in the future,
to be able to use it in production (for next GSOC 2012 ?)

Improve stability of unit tests when running them with Valgrind

I noticed unexpected unit test failures when running the tests with
Valgrind. The reason was that test execution was slowed down a lot,
such that that TestBase::waitForFinishedPathLoading() did not receive
the view's signal within the default timeout of 2 seconds, and that
this failure was not detected in every test -> the tests failed later
on because not all expected items had been loaded yet.

To fix this, I changed two things:
1. Added an assert in TestBase::waitForFinishedPathLoading() that checks
if the signal has been received. Continuing does not make much sense if
that is not the case.
2. Increased the default timeout to 20 seconds. The reason why there is
a finite timeout at all is that I didn't want to waste too much time on
machines where the file kioslave seems to have problems loading a
directory (I've seen corresponding test logs at cdash.org). However, with
the first change I mentioned above, the waiting time is lost only once
(due to the assert) rather than every time a directory is loaded
-> I think that the timeout increase does not lead to an increased waste
of time on such machines.

compress the emf/wmf data

Emf/wmf files can be huge, like many megabytes, but they compress
very nicely. Only uncompress when we need to really repaint.

cache the output of the emf/wmf vector shape

Very simple-minded cache: if the zoom level changes, the cache gets
replaced. Because it is implemented inside the shape, instead of
a KoShapeManagerPainterStrategy like the generic shape caching, we
cannot keep a cache for every active canvas. Two canvases with two
different zoom levels means no actual caching.

xlsx filter: Speed up for files which have abundance of conditional styles.

Use the raster-graphicssystem per default for Words.
This speeds painting documents up by tons of factors. It makes only sense for Qt <4.8 cause with >=4.8 raster will be default anyways.
see http://www.mail-archive.com//msg00234.html

Improve efficiency and performance in loading and sorting models.

The result of a weekend of profiling, with the test case of opening
a large collection with many people showing an improvement from
65 seconds to 8 seconds (88%).

convert kdebug --> Log

- renamed log to Log (conflicts with natural logarithm)
- make Log thread-safe

Make the "Load from file..." menu item look the same as the other entries.
Reviewed by: David Edmundson
REVIEW: 101077

Make /dns non-blocking.

Replace pairs of spaces with "<space> " to preserve some semblance of text wrapping
code: filteredLine.replace(" ", " \xA0");
This used to work like above. But just for normal text like "test test"
It got replaced as "test \xA0 \xA0test" and QTextEdit showed 4 spaces.
In case of color/italic/bold codes we don't necessary get a real pair of spaces
just "test<html> <html> <html> <html> test" and QTextEdit shows it as 1 space.
Now if we remember the last char, to ignore html tags, and check if current and last ones are spaces
we replace the current one with \xA0 (a forced space) and get
"test<html> <html>\xA0<html> <html>\xA0test", which QTextEdit correctly shows as 4 spaces.

Do not condition "busy" progressbar animation by the global "enable animations" flag.
They must be disabled explicitly via oxygen-settings.

Reduce CPU usage during route interaction.

Avoid recalculation of routes' screen regions if possible. Don't paint
the current route twice.
(cherry picked from commit ed35feeb6a50941de16855c01a0ab9a177cc9d52)

Optimize bevelmap generation by approximating sqrt(x^2 + y^2) without sqrt().

I used the opportunity to split a quadratic approximation formula for cos()
into a separate function for readability.

Fixed speed issues in drawing things with more than 1000 items in the view

add description of search feature to documentation

Remove the sending of DNT:0 since it is redundant with the spec.
If the header is missing, it is assumed you want to OPT-IN to be tracked.

Also do not send the DNT:1 header by default. It must be explicitly enabled
by the user from the configuration dialog.

Finished Qt3 -> Qt4 porting : no more Qt3 support classes, nor deprecated calls.