Revision 8c9d69c...

Go back to digest for 22nd May 2011

Bug Fixes in Networking Tools

Ilia Kats committed changes in [networkmanagement/nm09] /:

first implementation of a user secret agent.

However, NM's support for user secret agents appears to be abysmal.
Secrets are not being saved when the connection is created, so
you have to create the connection, then edit it and type in your
passwords again to get them saved, as NM doesn't call the agent's
SaveSecrets method on connection creation, but only on edits. In
addition, connections with agent stored secrets can not be activated
(not even from nm-applet - yes, kded was running with the secret
agent at the same time), GetSecrets is not being called. Simply
nothing happens (tested with Wlan WPA2-PSK). NM crashes when trying
to create a connection which uses 802-1x-TLS, while nm-applet doesn't
even allow to do that, as no private key file can be selected
(gave it just a quick try, maybe I missed something).

This fixes the issue that insecure Wlan connections could not be edited.
This fixes storage of 802-1x secrets systemwide.

TODO: test it with KWallet
TODO: test GSM, CDMA and PPOE
TODO: major code cleanup (remove all settingpersistence etc)
TODO: someone should talk to the NetworkManager guys about secret agent support
(event nm-applet stores everything in NM's systemwide storage)

File Changes

Added 25 files
  •   backends/NetworkManager/nm-agent-manager.cpp
  •   backends/NetworkManager/nm-agent-manager.h
  •   backends/NetworkManager/nm-secret-agentadaptor.cpp
  •   backends/NetworkManager/nm-secret-agentadaptor.h
  •   backends/NetworkManager/nmdbussecretagent.cpp
  •   backends/NetworkManager/nmdbussecretagent.h
  •   libs/internals/paths.h
  •   libs/internals/secrets.cpp
  •   libs/internals/secrets.h
  •   libs/service/secretsprovider.cpp
  •   libs/service/secretsprovider.h
  •   libs/service/secretstorage.cpp
  •   libs/service/secretstorage.h
  •   backends/NetworkManager/introspection/nm-agent-manager.xml
  •   backends/NetworkManager/introspection/nm-secret-agent.xml
  •   libs/internals/settings/802-11-wireless-securitysecrets.cpp
  •   libs/internals/settings/802-11-wireless-securitysecrets.h
  •   libs/internals/settings/802-1xsecrets.cpp
  •   libs/internals/settings/802-1xsecrets.h
  •   libs/internals/settings/cdmasecrets.cpp
  •   libs/internals/settings/cdmasecrets.h
  •   libs/internals/settings/gsmsecrets.cpp
  •   libs/internals/settings/gsmsecrets.h
  •   libs/internals/settings/pppoesecrets.cpp
  •   libs/internals/settings/pppoesecrets.h
Deleted 4 files
  •   libs/internals/connectionpersistence.cpp
  •   libs/internals/connectionpersistence.h
  •   libs/service/connectionlistpersistence.cpp
  •   libs/service/connectionlistpersistence.h
Modified 44 files
  •   applet/nmpopup.cpp
  •   kded/service.cpp
  •   tests/CMakeLists.txt
  •   backends/NetworkManager/busconnection.cpp
  •   backends/NetworkManager/CMakeLists.txt
  •   backends/NetworkManager/connectiondbus.cpp
  •   backends/NetworkManager/connectiondbus.h
  •   backends/NetworkManager/nmdbussettingsconnectionprovider.cpp
  •   libs/internals/CMakeLists.txt
  •   libs/internals/connection.cpp
  •   libs/internals/knmserviceprefs.kcfg
  •   libs/internals/setting.cpp
  •   libs/internals/setting.h
  •   libs/internals/uiutils.cpp
  •   libs/service/CMakeLists.txt
  •   libs/service/connectionlistpersistencedbus.cpp
  •   libs/ui/connectioneditor.cpp
  •   libs/ui/connectionprefs.cpp
  •   libs/ui/connectionprefs.h
  •   libs/ui/connectionsecretsjob.cpp
  •   libs/ui/connectionsecretsjob.h
  •   libs/ui/gsm.ui
  •   libs/ui/gsmwidget.cpp
  •   settings/config/manageconnectionwidget.cpp
  •   settings/config/managetraywidget.cpp
  •   backends/NetworkManager/settings/802-11-wireless-securitydbus.cpp
  •   backends/NetworkManager/settings/802-1xdbus.cpp
  •   backends/NetworkManager/settings/cdmadbus.cpp
  •   backends/NetworkManager/settings/gsmdbus.cpp
  •   backends/NetworkManager/settings/pppoedbus.cpp
  •   libs/internals/settings/802-11-wireless-security.cpp
  •   libs/internals/settings/802-11-wireless-security.h
  •   libs/internals/settings/802-1x.cpp
  •   libs/internals/settings/802-1x.h
  •   libs/internals/settings/cdma.cpp
  •   libs/internals/settings/gsm.cpp
  •   libs/internals/settings/gsm.h
  •   libs/internals/settings/pppoe.cpp
  •   libs/ui/security/tlswidget.cpp
  •   libs/ui/security/wep.ui
  •   libs/ui/security/wepwidget.cpp
  •   libs/ui/security/wirelesssecurity.ui
  •   libs/ui/security/wirelesssecuritysettingwidget.cpp
  •   libs/ui/security/wpapsk.ui
73 files changed in total