Issue 185

29th May 2011 by KDE Commit-Digest Team

Contributors

Alexander van Loon
Marta Rybczynska
Marco Krohn
Vladislav Blanton
Danny Allen

This Week...

Calligra sees improved support for many file formats, an auto-updating Table Of Contents, configurable full-screen mode, column breaks, working even/odd headers/footers, and much bugfixing throughout. Krita, in particular, now has a GHNS tool bar to gradients, patterns and brushes, eci profiles, and many bugfixes. Secret object for VPN connections in Network Management, MAC spoofing for wireless, and further work on NM09 support. Work on Presence applet for Telepathy. Added a security warning for URLs with bogus username. Memory optimizations in Nepomuk and KDE-Libs amongst bugfixing. Reduced memory usage in Marble along with bugfixing. Improve randomized slideshow in Gwenview. Konsole Part no longer blocks the unmounting of removable media. Umbrello sees GSOC work on the port to QGraphicsView. Dolphin sees GSOC work with an implementation of a basic commit dialog interface. Kst now supports Scientific Notation for log mode. Editing HTML messages that are encrypted is now possible in KDE-PIM, Kontact now includes a Zanshin plugin, and much bugfixing. Amarok sees an expansion of the MusicBrainz dialog, Last.fm scrobbling using composer, and bugfixing. Work on Oxygen-Icons. Bug fixing in KDevelop, Plasma, KMyMoney, Oxygen-Gtk and Muon.

Statistics

Commits 1971 by 201 developers
Open Bugs 23973
Open Wishes 17452
Bugs Opened 517 in the last 7 days
Bugs Closed 658 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
176
 
/trunk/www
66
 
/branches/stable
64
 
/trunk/l10n-support
41
 
/trunk/KDE
40
 
/calendarsupport/freebusymanager.cpp
27
 
/branches/work
27
 
/trunk/extragear
17
 
/trunk/kdesupport
17
 
/libs/textlayout
15
 
Files Developer Commits
364
 
Aaron J. Seigo
85
 
153
 
Sergio Luis Martins
55
 
94
 
Gilles Caulier
46
 
137
 
Marco Martin
45
 
362
 
Sebastian Sauer
38
 
56
 
Hugo Pereira Da Costa
37
 
78
 
Harald Sitter
36
 
691
 
Burkhard Lück
35
 
68
 
Aleix Pol Gonzalez
33
 
91
 
Boudewijn Rempt
26
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Swedish (sv)
99%
 
Brazilian Portuguese (pt_BR)
99%
 
Spanish (es)
95%
 
Estonian (et)
95%
 
Dutch (nl)
94%
 
British English (en_GB)
92%
 
German (de)
91%
 
Low Saxon (nds)
90%
 
Italian (it)
89%
 

Bug Killers

Person Bugs Closed
John Layt
139
 
jamano910 gmail com
96
 
Aaron J. Seigo
67
 
Dawit Alemayehu
38
 
Beat Wolf
33
 
Christoph Feck
31
 
Myriam Schweingruber
26
 
lamarque gmail com
22
 
Boudewijn Rempt
22
 
Ben Cooksley
16
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[] [] []   

Graphics

[] []    

KDE Base

[] [] [] [] []

KDE-PIM

[] []    

Office

[] [] []   

Konqueror

     

Multimedia

[] [] []   []

Networking Tools

[] []    

User Interface

[] []    

Utilities

[]     

Games

[]     

Other

  []    

There are 149 selections this week

Bug Fixes

Development Tools

Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize/src/mergemode/mergeview.cpp:
Milian Wolff committed changes in [kdevplatform/1.2] plugins/subversion/svnjobbase.cpp:

try to protect against crash triggered by nested event loops and failing svn jobs

this needs some more work probably as explained in the comment

Aleix Pol Gonzalez committed changes in [kdevelop/4.2] projectbuilders/cmakebuilder/cmakebuilder.cpp:

Educational

Dennis Nienhüser committed changes in [marble] /:

Remember the active routing profile acress sessions.


FIXED-IN: 1.2.0

Bernhard Beschow committed changes in [marble] src/lib/ViewportParams.cpp:

ViewportParams: no need to set a different default projection depending on desktop/mobile use case because that is taken care
of in QtMainWindow

* keep Spherical the default projection for now, although this should probably be changed to Mercator in the future

Dennis Nienhüser committed changes in [marble] /plugins/runner/monav:

Various UI fixes.

Don't forget upgrade information for other maps after upgrading a map.
Filter the correct table view. Remove the "Any" option. Show version
info (date). Don't indicate a map can be deleted if its directory
is not writable.

Graphics

Gilles Caulier committed changes in [libkdcraw] libkdcraw/kdcraw.cpp:

If colors component is 1 (Grayscale), make demosaiced image as RGB for client application.

Aurélien Gâteau committed changes in [gwenview] lib/slideshow.cpp:

Improve randomized slideshow

- Make sure order is not the same between 2 runs of Gwenview
- When looping, make sure the new list does not start with the last
displayed image

Aurélien Gâteau committed changes in [gwenview] lib/documentview/documentview.cpp:

Focus the current document view

Avoids putting the focus on the zoom slider.

Gilles Caulier committed changes in [libkdcraw] libkdcraw/kdcraw_p.cpp:

create right PGM header with Grayscale image.
CC

KDE Base

Aaron J. Seigo committed changes in [kde-workspace] /generic/dataengines/nowplaying/playerinterface/mpris:

cache the last pixmap, don't try and load it ove rand over and over again

probably not the fix for the bug below, but certainly an improvement over the
reported behavior

Nicolas Lécureuil committed changes in [kdelibs] plasma/extenders/extenderitem.cpp:
Sebastian Trueg committed changes in [kde-runtime] nepomuk/services/storage/datamanagementcommand.cpp:

Fixed a major memory leak.

Actually this was not really a leak. The queue of outgoing DBus messages
just filled up and was never cleared. I am not entirely sure why but
the thread emitting the signals (the original signals which trigger
emitting of the final DBus signals) needs event handling. In this case
it was the DataManagementCommand. I decided to simply handle events
using QEventLoop::processEvents. While this might not be very clean
an actual execution of an event loop and a queued execution of the
command in question would have the same effect since all commands are
executed sync anyway.

Thus, while this fixes the memory leak it is not very satisfying as I
do not understand why. :(

Aaron J. Seigo committed changes in [kdelibs] /:

move applet handle handling (*cough*) to applet instead of contaiment

much cleaner and eliminates the possibility of odd crashes

Sebastian Trueg committed changes in [kde-runtime] nepomuk/services/queryservice/folder.cpp:

Fixed folder updating - no more "all resources removed" signals.

The problem was very simple in the end: the m_newResults set did not
get filled with all results from the new query run but only the ones
that were new. This obviously lead to an empty list almost all the time.

Matthias Fuchs committed changes in [kde-baseapps] dolphin/src/views/renamedialog.cpp:

Disallow renaming to names containing '/', names being equal to "." or "..".

REVIEW:101454

Max Lin committed changes in [kde-workspace] kcontrol/randr/krandrtray.cpp:

Fix krandrtray tooltip's tag mismatch

REVIEW: 101430

Matthias Fuchs committed changes in [kde-baseapps] /src/views:

DolphinColumnView navigation works more intuitively.

If no item is selected then pressing right moves to a column view with child url, instead of the first index.

REVIEW:101449

Martin Gräßlin committed changes in [kde-workspace] kwin/effects/desktopgrid/desktopgrid.cpp:

Ensure Lanczos is disabled during start animation

For what reason ever motion manager thinks that windows are not
moving during the start animation (but are during the stop animation).
So we also have to look on the timeline to decide whether we should
disable lanczos filter on the windows.

Now wonder the animation was stuttering.

FIXED-IN: 4.7.0

Frank Reininghaus committed changes in [kdelibs] /:

Fix crash in KDirOperator::Private::_k_slotExpandToUrl(...)

When entering '/' in the 'Name' line of the file open dialog, pressing
backspace and then pasting 'a/b', where a is a subfolder of the current
folder and b a file in that folder, KDirOperator may crash because it
accesses a null KFileItem. This commit fixes the crash. Unit test
included.

Sebastian Doerner committed changes in [kde-baseapps] /src:

Don't let hidden terminals prevent unmounting

Previous state: When the terminal is hidden, the cwd is not updated
anymore. If it was on a removable device when hiding, the hidden
terminal might prevent unmounting this device.
This patch fixes that bug by changing the cwd to "/" when hiding the panel.

REVIEW: 101387

FIXED-IN: 4.7.0

Maks Orlovich committed changes in [kdelibs] /:

Don't ask KHTMLRun to handle embedding cases with onlyLocalReferences, we want to
swallow them ourselves given what the mode is for.

Fixes what #248478 turned to (original issue got fixed organically, follow up
comments are technically unrelated)

+ Remove unused return and indent inconsistency while I am at it

Matthias Fuchs committed changes in [kdelibs] /kio:

Disallows names of files containing '/' or being equal to "." or "..".

REVIEW:101456

Martin Gräßlin committed changes in [kde-workspace] kwin/workspace.cpp:

Fix regression of setting a window to all desktops

The logic to prevent errornous desktops broke setting a window
to all desktops through the task manager. For some reason all
desktops is -1 which is of course less than 1 ;-)

Sascha Peilicke committed changes in [kdeplasma-addons] wallpapers/marble/marble.cpp:

Added patch by Kamil Iskra to fix timezone issue and terrain mark hiding.

KDE-PIM

Thomas McGuire committed changes in [kdepim/htmlreplies] templateparser/templateparser.cpp:

Use convertedTextContent() here as well.

Makes plain text replies to HTML-only mails work propertly again.

Sergio Luis Martins committed changes in [kdepim/enterprise/e3] /:

Fix kontact crash when switching components.

The crash could be reproduced by clicking on knode, then
going to config and disable it, then re-enable it, and clicking
on it again ( basically making knode's ctor being called twice ).

This KNGlobal stuff looks like a huge hack. So, KNGlobal creates
a bunch of variables, then KNMainWidget gets ownership on them,
but the getters are in KNGlobal. When ~KNMainWidget
is called, it deletes those variables but KNGlobal will still
hold pointers to them, and who ever calls the getters will
obtain dangling pointers.

Not sure why it was made that way, probably because KNGlobal
uses external linkage, and somebody wanted to recreate stuff
each time KNMainWidget gets recreated.

MERGE: trunk
Fixes kolab/issue4479

Diffs: 1, 2, 3 Revision 30126b9...
Andre Heinecke committed changes in [kdepim/4.6] mailcommon/filtermanager.cpp:

Fix message filtering on startup.

When the FilterManager was constructed it tried to filter the
unread messages in the inbox before it had loaded the filtersettings.
This caused it only to filter new messages while it was running.

With this patch the tryToFilterInboxOnStartup function will always
be called when new filters are added. (e.g. After the config is read)
The delay in which the filter checks if the inbox is valid has also
been reduced to avoid situations where the user can look at a mail
in the inbox which is about to be filtered.

This patch was provided by steveire

Thomas McGuire committed changes in [kdepim/htmlreplies] messagecomposer/composerviewbase.cpp:

Don't interpret HTML tags by accident.

If the mail has a HTML part, it is handled a bit further below anyway,
with a proper call to setHtml().
At this place however, we only get plain text, as it's the content of
the text/plain MIME part.

Office

Lukáš Tvrdý committed changes in [calligra] filters/libmso/shapes.cpp:

Add support for arc in libmso

o output from our filter is displayed correctly in OOo,
we don't display the enhanced path correctly

Allan Anderson committed changes in /trunk/extragear/office/kmymoney/kmymoney/converter/mymoneystatementreader.cpp:

The account contained in the 'L' record gets passed correctly from
kmymoney/kmymoney/converter/mymoneyqifreader.cpp to mymoneystatementreader.cpp,
as 'brokerageaccount'. There, however, the 'brokerageactid' does not get set
correctly.

REVIEW: 6688

Cristian Oneț committed changes in /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp:

Crash when the balance of an equity account was changed since equity accounts are not represented in the institutions model.

Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney/views/kpayeesview.cpp:

Clear search widget before using after update

Burkhard Lück committed changes in [calligra] plugins/textediting/thesaurus/ThesaurusPlugin.cpp:

load missing translation catalog for thesaurus plugin
REVIEW:101435

Boudewijn Rempt committed changes in [calligra] libs/main/KoMainWindow.cpp:

KoPartManager: Be extra careful in event filter

Under some circumstances, apparently Qt passes a 0 to the eventFilter
arguments. This caused a crash for a krita user under Ubuntu 10.4. The
user confirms that this change fixes the bug for him. We were not able
to figure whether it was the theme or Qt who caused this problem.

Sven Langkamp committed changes in [calligra] krita/ui/flake/kis_shape_layer.cc:

fix problem where the shape layer wasn't visible after making it visible
only use Krita visibility and not flake

Boudewijn Rempt committed changes in [calligra] krita/ui/kis_view2.cpp:

kisview: show just the canvas feature improved

Hide also the scrollbars and added a shortcut.

Manually hidden elements like statusbars are not shown when going for
just the canvas, but restored when going back to the full window. I think
I prefer this behaviour.

Lassi Nieminen committed changes in [calligra] filters/words/docx/DocxXmlDocumentReader.cpp:

Docx filter: Made sure line-breaks both follow the spec & confront with ms behavior.

Matus Uzak committed changes in [calligra] filters/libmso/pole.cpp:

libmso: Disabled storage objects validation in POLE.

* Word8 files representing flase postives for the validation against
invalid file format were found. At the moment detection of files
containing invalid storage objects is not possible.

Sebastian Sauer committed changes in [calligra] filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h:

Fix crash on opening docx file from Firefox

Sebastian Sauer committed changes in [calligra] libs/main/KoMainWindow.cpp:

Fix Words crashes while trying to close large ODT file

Thorsten Zachmann committed changes in [calligra] /main:

Fix crash in find when no result is found

Arjen Hiemstra committed changes in [calligra] words/part/KWView.cpp:

Words: Make finding work properly again.

This uses KPartManager's activePartChanged signal to trigger a
recheck for what QTextDocuments to search through, instead of
using the completed() signal which apparently is triggered before
KWView's constructor is executed.

Inge Wallin committed changes in [calligra] /:

WMF/EMF: Unify all definitions of enums and flags between WMF and EMF.

This means that there will no longer be some value doubly defined,
which created problems when another file used both WMF and EMF.

* Move all WMF enums that were previously defined in EmfEnums.h to
WmfEnums.h
* Remove those that were doubly defined from EmfEnums.h and include
WmfEnums.h instead.
* Create a somewhat ugly hack for those enums that were extended from
WMF to EMF.

Burkhard Lück committed changes in [calligra] krita/plugins/extensions/imagesplit/wdg_imagesplit.ui:

remove superfluous whitespace in user visible strings
REVIEW:101436

Matus Uzak committed changes in [calligra] filters/words/msword-odf/texthandler.cpp:

DOC: Improvements in identification of headings.

Matus Uzak committed changes in [calligra] /:

libmso: Relaxed the validation while parsing the FibBase structure.

* The FibBase structure is the fixed-size portion of the Fib.
The generated parser was strictly checking Word8 specific values,
which caused exceptions in parsing of Word7 and Word6 files.

Diffs: 1, 2, 3, 4 Revision 962a12c...
Lassi Nieminen committed changes in [calligra] /:

Ooxml Filter: Changed colormapping to be a common property for all, this will hopefully help solve
many color issues with schemeColoring in the future.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision a1891d1...
Jan Hambrecht committed changes in [calligra] plugins/artistictextshape/ArtisticTextShape.cpp:

when attempting to insert text into empty shape, use append text instead

Matus Uzak committed changes in [calligra] /words/msword-odf:

DOC: Bullet-proofing - session4

* Added validations into processing of tables.
* Readability improvements in TableHandler.
* Check the TextHandler state after parsing. Malformed fields are
causing a problems.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b271e7a...
Lukáš Tvrdý committed changes in [calligra] /libmso:

Improve autoshape support

o adding 137 autoshapes, old shapes were replaced
due to missing support of modifiers that modify the geometry
of the shapes and mirror modifiers were inconsistent

Sebastian Sauer committed changes in [calligra] /textlayout:

Fix sometimes invisible text.
The reason was that we sometimes asked for a scheduled layout while a layout was still running. The still
running layout then could probably not notice that already handled root-areas got dirty meanwhile. This
is fixed now by introducing the possibility to restart a layout-process. Now if we earn a scheduled
layout call during layouting we abort the current layout-process and restart from the beginning.

Sebastian Sauer committed changes in [calligra] libs/kotext/opendocument/KoTextWriter.cpp:

Fix crash when doing ctrl-a ctrl-c on a smallish document (Section vs SectionEnd-mismatch)

Matus Uzak committed changes in [calligra] /words/msword-odf/wv2/src:

DOC: Improvements in validation and processing of bookmarks.

* Check if the bookmark corresponds to a valid Character Position (CP).
* Skipp all invalid bookmarks. We can add some calligra specific logic in the future.

Diffs: 1, 2, 3 Revision e475e6b...
Matus Uzak committed changes in [calligra] filters/words/msword-odf/mswordodfimport.cpp:

DOC: Return InvalidFormat for unsupported files.

* Word2 files or files without FibBase.

Thorsten Zachmann committed changes in [calligra] libs/kotext/opendocument/KoTextWriter.cpp:

Make sure to produce valid xml

Close the tag that are opened. Always use the same machanism for closing the tags.
Therefore also insert empty tags into the stack.

This fixes bug 274064 - Corrupted odp file after removing slides.
Actually the removing of the slides is not needed th reproduces the problem.
Saving the file is enough.

Multimedia

Giorgos Kylafas committed changes in /trunk/KDE/kdemultimedia/juk/playlistcollection.cpp:

juk: fix showing the items of all the selected playlists.

When two or more playlists are selected from the PlaylistBox to the
left, a dynamic playlist is used which shows the union of their
contents. However, the first time this dynamic playlist is created, it
has to be set up properly, otherwise only the contents of the first
selected playlist will be shown.

More specifically, if it is not set up, i.e. not added to the stack of
playlists, QStackedWidget::setCurrentWidget() fails complaining that
"widget 0x... not contained in stack".

Ralf Engels committed changes in [amarok] src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp:

Amarok cannot detect non-partitioned device
Fixes an issue where not partitioned device will not show up in Amarok as for those devices from a solid-hardware point of view the StorageDrive and the
StorageVolume are the same device.

Fixes: 272401
Courtesy: Matthieu Pupat

Gerd Fleischer committed changes in [kaudiocreator] audiocd.cpp:

fix crash when ejecting with no drive

However, the button should be disabled
if no drive is detected, needs a bit more work.

Networking Tools

Lamarque Souza committed changes in [networkmanagement] libs/client/remoteactivatablelist.cpp:

Another hack to try to prevent dangling pointers. When I have more time
I will try to make things in the correct way, for now this will just
make the crashes much less likely to happen.


(cherry picked from commit 93322e13815a92cf3357f38eb152cf3f456629f7)

David Edmundson committed changes in [telepathy-contact-list] /:

Replace passing round QModelIndexes with ContactModelItem* this fixes various crashes when using proxy models.

Reviewed by Martin Klapetek



REVIEW: 101448

Igor Poboiko committed changes in /trunk/KDE/kdenetwork/kopete/plugins/translator/translatorplugin.cpp:

Fix crash when user is trying to set language from contactlist menubar and no contacts are selected.
Now action is disabled in this case.

Ilia Kats committed changes in [networkmanagement] settings/config/manageconnectionwidget.cpp:

Prevent crashes when closing kcmshell too fast after closing the connection
editor. Hacky, but seems to be the best option so far.


(cherry picked from commit 9c4d7b49b691b6ba67b4cca0981bdabc847b675d)

Ilia Kats committed changes in [networkmanagement/nm09] /:

fix switching from wpa2-psk to insecure and back

Diffs: 1, 2, 3, 4, 5, 6 Revision 374943f...
Ilia Kats committed changes in [networkmanagement/nm09] /:

delete secrets from storage if they are no longer needed

Diffs: 1, 2, 3, 4, 5, 6 Revision 4b2b8ef...
Ilia Kats committed changes in [networkmanagement/nm09] /:

don't use a pointer to a connection in the list when editing a connection,
but make a copy of the connection instead. That way, if the edit fails
(the kauth dialog gets canceled, for example), the manageconnectionwidget
will still have the current connection settings, not the new ones that didn't
make it to NM. The connection list is updated by nmdbussettingsconnectionprovider
anyway.

This implements copy constructors for Knm::Connection, Knm::Setting and
subclasses, Knm::Secrets and subclasses.
This adapts the DBus interface to NM 0.9 (the updated() signal does
no longer contain the connection map)
Some minor fixes to KAuth in nmdbussettingsconnectionprovider

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 46 more) Revision 4cb9252...
Lamarque Souza committed changes in [networkmanagement] /:

Test the RemoteGsmInterfaceConnection object before using it.

Ilia Kats committed changes in [networkmanagement/nm09] settings/config/manageconnectionwidget.cpp:

Prevent crashes when closing kcmshell too fast after closing the connection
editor. Hacky, but seems to be the best option so far.

Eike Hein committed changes in [konversation] /:

Fix tooltip text lookup by event coords in NickListView and ViewTree.

Thanks to Nicolás Alvarez for reporting the bug and testing the fixes.

Diffs: 1, 2, 3 Revision bc90e92...
Lukáš Tinkl committed changes in [networkmanagement/nm09] /ui/security:

fix the WEP widget

do not show/hide the key/pass labels (leads to broken layout),
reuse one label instead

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Get secrets at first try when editing.

The problem was that NMDBusSettingsConnectionProvider maintains two list
of connections, one passed to the constructor and another created
in a private class (d class). When
NMDBusSettingsConnectionProvider::onConnectionSecretsArrived gets the
secrets it was updating only the connection in the d class class but
manageconnectionwidget uses the other connection list.

To make things simpler I added the secrets to the signal
manageconnectionwidget already listen to.

Maybe in the future we could use only one list of connections instead of
two.

Diffs: 1, 2, 3, 4, 5 Revision d7f8257...
Lukáš Tinkl committed changes in [networkmanagement/nm09] /:

fix loading/saving of VPN connections

still can't be activated due to non-functional SecretAgent but we're
on the good path :)

If you run nm-applet along with nm-plasma and try to activate a VPN connection
from our applet, nm-applet correctly asks for the passwords using its builtin
SecretAgent

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision f840553...

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk] src/oxygenstylewrapper.cpp:

re-adjusted scrollbar handle when rendered in cellviews, to match new rendering from commit
37a4a68baf1dc63e4fb7b38c53e51c1946bda853.

Ruslan Kabatsayev committed changes in [oxygen-gtk] /:

Don't fill groupbox when useFlatBackground() returns true.
This makes groupbox children have consistent color in Eclipse.

Ruslan Kabatsayev committed changes in [oxygen-gtk] src/oxygenstyle.cpp:

Draw flat background in renderWindowBackground when useFlatBackground() returns true
This fixes entries in Eclipse

Hugo Pereira Da Costa committed changes in [oxygen-gtk] src/oxygenstylewrapper.cpp:

also re-adjusted scrollbar handle in isEntryProgress, to match new rendering from commit
37a4a68baf1dc63e4fb7b38c53e51c1946bda853.
.

Utilities

Raphael Kubo da Costa committed changes in /branches/KDE/4.6/kdeutils/ark/plugins/clirarplugin:

Remove trailing '/'s from directories passed to clirarplugin.

The proprietary unrar program does not accept directories with a
trailing slash when they are passed to it when extracting some files
(think drag'n'drop).


FIXED-IN: 4.6.4

Jonathan Michael Thomas committed changes in [muon] libmuon/PackageModel/PackageWidget.cpp:

Do not search if we are in the middle of a cache reload, like when the "Unmark All Changes" button is pressed.
This prevents a crash that occurs when the proxy model's source model is null during reload.

Jonathan Michael Thomas committed changes in [muon] installer/ApplicationDetailsView/ApplicationDetailsWidget.cpp:

Don't handle events from orphaned transactions

Jonathan Michael Thomas committed changes in [muon] libmuon/PackageModel/PackageWidget.cpp:

I already had code in place to enable the search bar only after the backend was ready. Unfortunately I accidentally removed the single line that disables the search bar in the first place whilst doing other things. :/
On the plus side this doesn't affect Muon 1.1.


FIXED-IN:1.1.90

Jonathan Michael Thomas committed changes in [muon] libmuon/MuonMainWindow.cpp:

Fix some situations where APT errors would prevent Muon from being able to quit.
Also fix erronous toolbar re-enablement that resulted from CommitErrors.

Jonathan Michael Thomas committed changes in [muon] kded/event.cpp:

Make sure to initialize the KStatusNotifierItem object's pointer with 0,
otherwise crashes will occur when trying to delete it due to the undefinied
behavior of accessing an un-initialized pointer. Fixes a crash that occurs
when muon-notifier is configured to show only popup icons.

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src/tilesetselector.py:

Revert r1231677

That commit resizes the tiles in the tileset preview (config/tileset
selector) whenever the user selects a different tileset.
Since that commit, it is no more possible to edit a ruleset name in
the ruleset editor. This is very strange, I can see no connection
between this commit and the effect.

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

HumanClient(Client1) should never directly call Client.x

but only Client1.x, otherwise using Client1 for better robot AI
would not always work.

Features

Development Tools

Camila San Martin Ayres committed changes in /branches/work/soc-umbrello-2011/umbrello:

Working on the port to QGraphicsView.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 18 more) Revision 1233474
Vishesh Yadav committed changes in /branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg:

Implemented basic commit dialog interface, with KTextEditor as diff viewer.

Jon Ander Peñalba committed changes in [kdeexamples] /:

Basic Solid demo added

Diffs: 1, 2, 3, 4, 5 Revision cb0b89f...

Educational

Barth Netterfield committed changes in /branches/work/kst/portto4/kst/src/libkstapp:

Scientific Notation for log mode.

When in log mode, the numbers will be 10^i.

This is the RightThing (tm) except, maybe, for 10^0 (ie 1) and 10^1 (ie, 10).

What we do for 1 and 10 may need some discussion.

Barth Netterfield committed changes in /branches/work/kst/portto4/kst/src/libkstapp:

View Items are transparent during a drag so you can see where you are putting them.

Graphics

Jesper Pedersen committed changes in [kphotoalbum] AnnotationDialog/KDateEdit.cpp:

Improved handling of events in date edits in annotation dialog

In the annotation dialog the linedit for date supports that you e.g.
just type 1979. This text is expanded to "jan 1st 1979" when you press
enter in the line edit, and it should also do so when the focus leaves
the lineedit. There was code in place for this, which relied on a focus
out event send to the line edit. We, however, never saw that event. So
now it is rewritten to used the editFinished signal from the line edit
instead, which is cleaner anyway.

Aurélien Gâteau committed changes in [gwenview] /:

Make it possible to switch between views with Tab and Shift+Tab

Diffs: 1, 2, 3, 4 Revision ef3ce79...

KDE Base

John Layt committed changes in [kdelibs] /:

kdeui: DateTime widgets improve api and implementation, add tests

Sorry guys, meant to push this before Beta 2 but clean forgot, one
downside to git and feature branches is loosing track of things...

Update new KDateComboBox, KTimeComboBox and KDateTimeEdit widgets with
improved api and add unit tests. These classes are now ready for final
review. The KDateTimeEdit may need a couple more bug-fixes.

Remove new KDateEdit and KTimeEdit sub-classes as I decided their use
case was very limited and not properly understood.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 14 more) Revision 1150d67...

KDE-PIM

Thomas McGuire committed changes in [kdepim/htmlreplies] /:

Use the new OTP::htmlContent() function when setting a message.

As a side effect, editing HTML messages that are encrypted is now
possible.

Kevin Ottens committed changes in [zanshin] /:

Add a Zanshin plugin for Kontact

Added a ReadOnlyPart and a KontactInterface::Plugin to integrate
Zanshin directly in the Kontact window. Also tune the ActionListEditor
so that it doesn't set a shortcut for the "New Action" action when the
"ZANSHIN_KONTACT_PLUGIN" environment variable is set. This variable is
set only from the plugin before the part (and then MainComponent) is
created.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 794ad94...

Office

Sebastian Sauer committed changes in [calligra] /part:

Made even/odd headers/footers working.

Diffs: 1, 2, 3 Revision 015f042...
C. Boemann committed changes in [calligra/textlayout-linespacing-boemann] libs/textlayout/KoTextLayoutArea.cpp:

Seems like presentation mode linespacing is working now

Sven Langkamp committed changes in [calligra] /:

save mirror, erase, composite op and mirror settings to presets

Srikanth Tiyyagura committed changes in [calligra/krita_resource-management-taggi] /:

Added the GHNS tool bar to gradients, patterns and brushes.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 2866147...
Boudewijn Rempt committed changes in [calligra] /data/profiles:

add eci profiles -- we have a grant to redistribute them with krita now

Diffs: 1, 2, 3, 4 Revision 2d88b45...
Sebastian Sauer committed changes in [calligra/text-layoutprogressupdater-sebs] /:

First try to get a progressUpdater for layouting done. The calculation is fine and is passed to the KoUpdater but somehow the progressBar stays at 100% all of the time for whatever reason :-/

Diffs: 1, 2, 3, 4 Revision 3a46808...
Lassi Nieminen committed changes in [calligra] /:

Docx filter: Implemented reading colorMap (still unused though)

Diffs: 1, 2, 3, 4, 5 Revision 3e30529...
C. Boemann committed changes in [calligra/textshape-references-boemann] /textlayout:

Auto updating Table Of Contents has landed

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 50fb9a2...
Lassi Nieminen committed changes in [calligra] /:

Ooxml filter: VML added support for N number of group items inside existing groups & improved fill and stroke support for groups.

Diffs: 1, 2, 3, 4, 5 Revision 59b9625...
Stephane Mankowski committed changes in [skrooge] skrooge_report/skgreportpluginwidget.cpp:

First draft of forcast computed by interest rate.

Paul Mendez committed changes in [calligra/stage-gsoc-paulm] /part:

Fix some bugs and make selection manager independent of the document

Make selection manager independient of the document makes it more reusable

Diffs: 1, 2, 3, 4, 5 Revision 7d6c3d5...
Radosław Wicik committed changes in [calligra/kexi-maps-wicik] /reporting:

Raports - frame plugin for maps based on Image plugin

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 94e6d1e...
Pierre Ducroquet committed changes in [calligra] /:

Change the break after/before property on paragraph to support column breaks too (and simplify the code, and pass the unit test...)

Diffs: 1, 2, 3 Revision a692df1...
Stephane Mankowski committed changes in [skrooge] /:

Better computation of forecast period for "Scheduled" and "Budget" modes

Diffs: 1, 2, 3 Revision aee6448...
Boudewijn Rempt committed changes in [calligra] /ui:

Make full-screen mode configurable.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision b528c42...
Sebastian Sauer committed changes in [calligra/text-layoutprogressupdater-sebs] words/part/KWDocument.cpp:

and made the progressBar proper update if the progress changed.

Alexander Potashev committed changes in [calligra] /:

Add libkundo2 to Calligra

kundo2 is a fork of Qt's Undo Framework (QUndoStack, QUndoView, ...).
It contains two bugfixes the are going to be available only in Qt 4.8:
https://qt.gitorious.org/qt/qt/merge_requests/1212
https://qt.gitorious.org/qt/qt/merge_requests/2610

To start using kundo2, one should port Calligra to it. This can be done
by adding target_link_libraries(... kundo2) into CMakeLists.txt files
for all modules from Calligra that use Qt Undo Framework, and by
switching from QUndo**** classes to KUndo2**** classes.
(switching to KUndo2 classes can easily be done by using a script)

After Calligra starts requiring Qt 4.8+, this library can be removed,
because it has no advantages over Qt's Undo Framework 4.8.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision ce619d0...

Multimedia

Ralf Engels committed changes in [amarok] src/dialogs/MusicBrainzTagger.cpp:

Expansion of MusicBrainz dialog

inspired by Felix Mauch

Christoph Pfister committed changes in [kaffeine] /backend-mplayer:

implement deinterlacing in mplayer backend

Ralf Engels committed changes in [amarok] /:

Last.fm scrobbling using composer
There was a discussion a few months ago about using composer tags in last.fm scrobbling. The patch did what I wanted it to, but after being checked in it was reverted when some people complained. Fair enough. I have got round to adding a config option for this behaviour.

Feedback in particular: I am new to amarok, so might be using the config system incorrectly. It does work though.

Behaviour implemented: when config option is set, scrobble composer preferentially to artist; when not set, always use artist data (default, and same behaviour as before)

Implements 254580
Courtesy: Nicholas Wilson

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision cd8f786...
Ralf Engels committed changes in [amarok] /context/applets/lyrics:

Add autoscroll function to the lyrics applet.
The text of the current song is automatically scrolled according to the position in the song. If the scrollbar is pressed and moved the autoscroll is disabled till the scollbar is released and it can be disabled/reactivated manually by clicking on an action. Whether autoscrolling is enabled or disabled is saved over Amarok restarts.

Courtesy: Jan Gerrit Marker

Networking Tools

Eduard Huguet committed changes in /trunk/extragear/network/kmldonkey:

- Added bandwidth toggle from main GUI to KMLDonkey
- Definitely get rid of anything Qt3-support related...
- Needs translation for new commands added

GUI:

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 1233729
Andrea Diamantini committed changes in [rekonq/NewDownloadManager] /:

Adding DownloadManager class, following Pierre and Benjamin code changes.

First step in the introduction of the new rekonq pages

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 25802e9...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /ui:

ADD special case for online presence

Added a special case for setting available presence.
The presence dataengine sends "available" as a status but kde icon is "user-online".

Andrea Diamantini committed changes in [rekonq] /:

Adding DownloadManager class, following Pierre and Benjamin code changes.

First step in the introduction of the new rekonq pages

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 47bd57b...
Ilia Kats committed changes in [networkmanagement/nm09] /:

Implement MAC spoofing

Diffs: 1, 2, 3, 4, 5 Revision 4ac1e35...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /ui:

Plasmoid can now set various statuses for the user's im accouts

Diffs: 1, 2, 3 Revision 4ce90fc...
Francesco Nwokeka committed changes in [telepathy-presence-applet/nwoki-qml-rede] /contents/ui:

ADD protocol icons for each account

Diffs: 1, 2, 3 Revision 51e4ec8...
Lamarque Souza committed changes in [networkmanagement/nm09] /:

Implement secret object for VPN connections. They work now. The are some
KNotification glitches that I will try to fix later. For instance
sometimes, only sometimes, both the VPN connection and the real connection
VPN uses emmit the "activated" notification.

Diffs: 1, 2, 3, 4, 5 Revision 62a8afe...
Francesco Nwokeka committed changes in [telepathy-presence-applet/nwoki-qml-rede] package/contents/ui/Avatar.qml:

Avatar is now a clickable IconWidget + disabled when offline

The avatar is an IconWidget so that it can easily accept click signals. When account is offline,
the avatar is disabled

Ilia Kats committed changes in [networkmanagement/nm09] /:

make new connections user-scope by default

Ilia Kats committed changes in [networkmanagement/nm09] /:

MAC spoofing for wireless

Diffs: 1, 2, 3, 4, 5, 6 Revision 869e3d5...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /:

First layout of presence applet

Only shows user avatar for stored accounts

Diffs: 1, 2, 3, 4 Revision 9a08a5b...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /:

ADD contactlist and account manager launchers

Diffs: 1, 2, 3, 4 Revision ae7c201...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /ui:

ADD UserInfo + Avatar borders + License

the avatar borders change color following the account status.
Started designing the UserInfo component to add to the delegate
Added missing licenses

Diffs: 1, 2, 3, 4 Revision f445e70...
George Goldberg committed changes in [telepathy-presence-applet/nwoki-qml-rede] /ui:

ADD PresenceChooser + PresenceIcon

the presence chooser is a flipable item containing the available presence icons for the user to
use to set the account status

Diffs: 1, 2, 3, 4 Revision f8379bf...
Andrea Diamantini committed changes in [rekonq] /bookmarks:

- Bookmark can now be dropped inside folders :
- Correctly hide a folder menu if there is a click outside

User Interface

Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

more work IM icons

Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

more work IM icons

Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

more work, one less ugly old icon

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 1233744
Nuno Fernades Pinheiro committed changes in /trunk/kdesupport/oxygen-icons:

more work IM icons

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 12 more) Revision 1233889

Other

Vishesh Yadav committed changes in /branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg:

Renaming implemented. Status messages not working though

Diffs: 1, 2, 3, 4, 5 Revision 1233466
Timothy Pearson committed changes in /branches/trinity/applications/katapult/katapult:

TQt4 port Katapult
This enables compilation under both Qt3 and Qt4

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 86 more) Revision 1233929

Optimization

Educational

Dennis Nienhüser committed changes in [marble] /osm-addresses:

Reduce memory usage by about 75%.

Let the pbf parser do a three-pass scan of the file to be able to know
which ways and nodes are simple (no address/poi data) and are not
referenced by any administrative boundary and thus can be discarded.
Distinguish between nodes and coordinates (simple nodes). Use hashes
instead of maps for faster lookups. Free data not needed anymore as
early as possible. The memory needed to process a .pbf file is now
around three times the size of the file (varies depending on the data).

Diffs: 1, 2, 3, 4, 5, 6 Revision 3a3c714...

KDE Base

Sebastian Trueg committed changes in [kde-runtime] nepomuk/services/storage/datamanagementmodel.cpp:

Split main removeDataByApplication query in two.

The main query just blocks Virtuoso forever if we include the third
sub-query. More optimization is still necessary.

Sebastian Trueg committed changes in [kde-runtime] nepomuk/services/storage/datamanagementmodel.cpp:

Query optimization.

Use FILTER(?r in (...)) instead of FILTER(?r=.. || ?r=...).

Sebastian Trueg committed changes in [kdelibs] /:

Optimization of several ResourceTypeTerms in one OrTerm via a FILTER.

Queries are sped up a lot when using
?r a ?t . FILTER(?t in (<type1>,<type2>,...) .
as compared to
{ ?r a <type1> . } UNION { ?r a <type2> . } UNION ...

Diffs: 1, 2, 3, 4, 5, 6 Revision 9cf42ae...
Sebastian Trueg committed changes in [kdelibs] /:

Yet another performance improvement based on the previous.

Now that we have the crappy inferencer 2 we do not rely on crappy
inferencer 1 (man, this is confusing) anymore to query types.
Thus, we can use ResourceTypeTerm instead of ComparisionTerm for the
file/folder query. This allows the previous optimization to be used
for FileQuery, too.

Office

Sebastian Sauer committed changes in [calligra/textlayout-documentChangedPerfo] libs/textlayout/KoTextDocumentLayout.cpp:

Better patch for made layouting way more faster by only layout the dirty, it's prev and the next root-area if something changed.

Stephane Mankowski committed changes in [skrooge] /:

New setting to enable/disable balances computation
Better performance in advice for scheduled operations

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 7fdfe60...
Sebastian Sauer committed changes in [calligra/textlayout-documentChangedPerfo] libs/textlayout/KoTextDocumentLayout.cpp:

Made layouting way more faster by only layout the dirty, it's prev and the next root-area if something changed. For everything else we have the isStartingAt logic.
This makes following relayouts caused by anchor-movings, etc. way more faster.

Multimedia

Trever Fischer committed changes in [phonon-gstreamer/plumbing] /:

Move all source handling into Pipeline, and make playbin2 deal with it. Massive code size reduction.

Diffs: 1, 2, 3, 4 Revision 381dbd7...

Security

KDE Base

Dawit Alemayehu committed changes in [kdelibs] kioslave/http/http.cpp:

Show a security warning when a URL includes a bogus username intended to fool
users into visiting sites they had no intention of visiting.

Note: new string.


FIXED-IN: 4.7.0
REVIEW: 101440

Other

Aaron J. Seigo committed changes in [kde-workspace/qt3support] /:

progress, progress, progress towards the death of qt3support

Multimedia

Nicolás Alvarez committed changes in /trunk/extragear/multimedia/kaudiocreator:

Delete kaudiocreator from SVN, replace with readme pointing at git.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 55 more) Revision 1233737