Issue 187

12th June 2011 by KDE Commit-Digest Team

Contributors

Vladislav Blanton
Alexander van Loon
Marco Krohn
Marta Rybczynska
Shafqat Bhuiyan

This Week...

Amongst much bugfixing and optimization work, Calligra sees further improvements to .doc, .xls, .xlsx, and .odt support, work on Stage, new Kexi web widgets, and improvements to Save Incremental support, finishing touches to the new strip presets picker and flow and opacity functionality equal to photoshop in Krita. In KDevelop, major bugfixing and work on new implementation of the "Ideal" UI, jumping to error lines in executescript plugin, cleanup of patch review toolview, new sessions runnner, autosaving and more. Much work in NetworkManagement including further NM09 support and enabling of Nm08Connection's importer. Initial implementation of a Wayland Server in KWin. Amarok sees much bugfixing, a scripting interface added to KNotify and drag and drop suppport between any collection. Bugfixing and feature work in Skrooge including graphs in "Bank and Account" page. Phonon-VlC adds .s3m and .xm as supported mimetypes. Support for RAW image in HTML export in Kipi-Plugins. Preview support for ICO files in Dolphin, along with bugfixing. Font DPI now fully configurable by the user. Work on Plasma's Share-Like-Connect project. OwnCloud sees work on media player and initial setup of sharing app. Bugfixing throughout Gwenview, KDE-Libs, KDE-Workspaces, and Juk.
An update on Phonon-Xine with Trever Fischer, maintainer of Phonon-GStreamer:

We here at the Commit-Digest asked Trever Fischer, maintainer of Phonon-GStreamer and libphonon, about why the Xine backend has become officially unmaintained. To begin, Trever first outlined the most recent commit history, which is lacking:

"First, the last commit (excluding icons or Scripty translations) was back on January 2nd 2011. The commit was Harald Sitter (apachelogger) lowering the backend's priority to third place, behind VLC and GStreamer. Prior to that, there is another commit on November 28th 2010 by Harald which is the last time that any code was actually touched."

"It is pretty obvious that nobody in the KDE Multimedia community feels like stepping up to fix it. I myself tried to add video capture support to it, but the first step was getting v4l2 support into Xine. Xine now has v4l2 support, but I just never got around to sitting down and taking on the project of bringing phonon-backend-xine up to speed."

However, Trever quickly pointed out to us that this wasn't the core issue, but rather the Xine project itself.

"The last release of xine-lib was 2010-07-25, almost a year ago. There seems to be a bit of activity on the xine-devel mailing list I am subscribed to, but nothing noteworthy or anything indicating an upcoming release. There are numerous patches sent every month or so, but they often fall on deaf ears."

"In short, the Xine project is looking for new developers but nobody is answering the call with as much enthusiasm as is needed to breathe life back into the project."

"I myself haven't used/tested the Xine backend for a number of months, so I can't comment on it's quality. Browsing bugs.kde.org can give a good hint of its reliability compared to GStreamer or VLC."

At this time (June 13th, 2011), a search for Phonon + Xine brought up 39 open bugs, 16 in phonon-backend-gstreamer, and 6 in phonon-backend-vlc. The next question, of course, is what is to be done?

"In order for the backend to come up to speed and be risen out of the 'unmaintained' status, someone first needs to jump in and help out the Xine project. It doesn't make sense to us for someone to spend a lot of time on a Phonon backend that relies on software that isn't actively developed. Having said that, the KDE multimedia developer community is always looking for more hands. I'm currently the sole maintainer of the GStreamer backend, with Harald handling the VLC one. Together, we both maintain libphonon. Additionally, Phonon isn't exactly a fringe project. There are a lot of high-profile applications out there that use Phonon and depend on us."

"While this isn't a call for help, this is more of a call for awareness. Xine is a very good project; it would be a shame to see it wither on the vine due to lack of developer interest. Phonon-Xine will continue to be unmaintained until upstream garners more support. After that, improving the Xine backend would be a worthwhile endeavor."

It is clear that the KDE Multimedia team is small, and yet maintains an important and high profile part of our ecosystem. Intrigued to join in?

"Those interested in helping out KDE-MM, or learning more about how to help out Xine can contact us via IRC in #kde-multimedia or #phonon on Freenode. Asking around on the phonon-backends@kde.org and kde-multimedia@kde.org mailing lists would work too."

KWin goes Wayland (from this commit by Martin Graesslin):

Initial Implementation of a Wayland Server in KWin. The current state allows to render Wayland "Clients" in the normal EGL compositing backend. The content gets updated correctly when other windows are damaged at the same time, but Wayland damage events seem to be lost, when there are no other triggered repaints.

Wayland clients are added to the scene in the same way as Unmanaged X11 windows and Deleted windows: on top of everything else. It is currently not yet possible to interact in any way with the clients. They do not get input events and you cannot move them or do anything else fancy with them. Though they are already nicely integrated into the Effects system. So all effects which handle unmanaged should also handle the Wayland clients.

All new Wayland relevant code can be found in the directory wayland. It contains the Server implementation (wayland.(cpp|h)), a representation for Surfaces (surface.(cpp|h)) and a new subclass of Toplevel (wayland_client.(cpp|h)).
All new classes are in a new namespace KWin::Wayland, the idea is to move all X11 classes in a namespace KWin:X11 to better separate what is generic (namepsace KWin) and what is backend specific.

The changes in the existing code base are tried to be kept to a minimum. The biggest change is in the OpenGL EGL Scene which now has to render Wayland buffers and XPixmaps. Also composite.cpp has seen some changes to start/stop the Wayland server and adjust the Toplevel's compositing functions to not create any X resources for the Wayland client. This has to be split in a better way by moving all X11 related code in a X11 specific implementation.

Statistics

Commits 2230 by 220 developers
Open Bugs 23601
Open Wishes 17453
Bugs Opened 435 in the last 7 days
Bugs Closed 621 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
263
 
/trunk/www
121
 
/trunk/l10n-support
120
 
/branches/stable
83
 
/trunk/kdesupport
49
 
/trunk/KDE
30
 
/Necessitas_SDK/build_sdk.sh
16
 
/contents/ui
16
 
/krita/ui
16
 
/krita/plugins
14
 
Files Developer Commits
231
 
Marco Martin
96
 
1258
 
Chusslove Illich
72
 
151
 
Lamarque Souza
57
 
2401
 
Karl Ove Hufthammer
47
 
1191
 
Frederik Schwarzer
43
 
145
 
Aleix Pol Gonzalez
42
 
51
 
Gilles Caulier
37
 
219
 
Hugo Pereira Da Costa
34
 
44
 
Harald Sitter
34
 
42
 
Sebastian Kügler
33
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
99%
 
Spanish (es)
95%
 
Dutch (nl)
94%
 
Estonian (et)
94%
 
British English (en_GB)
91%
 
German (de)
91%
 
Low Saxon (nds)
90%
 
Italian (it)
89%
 

Bug Killers

Person Bugs Closed
Dawit Alemayehu
50
 
kollix aon at
47
 
lamarque gmail com
45
 
Myriam Schweingruber
34
 
Boudewijn Rempt
30
 
Sergio Luis Martins
29
 
Christoph Feck
22
 
dehtris yahoo de
19
 
Thomas Lübking
14
 
Gilles Caulier
13
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] [] []   

Educational

[] []    

Graphics

[] []    

KDE Base

[] []    

KDE-PIM

[]   []   

Office

[] [] []   []

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    

User Interface

[] []    

Utilities

[] []    

Games

  []    

Other

  []    

There are 165 selections this week

Other

KDE-PIM

David Jarvie committed changes in [kdepim] /:

Fix resource and application overwriting each other's changes

If the resource updates the collection's compatibility status, it may
clash with the application updating other collection parameters, with
resulting data loss.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 507bac2...

Bug Fixes

Development Tools

Milian Wolff committed changes in [kdevplatform] language/duchain/builders/abstractcontextbuilder.h:

Revert "add assertion for misuse of AbstractContextBuilder::openContext"

This usage is apparently sometimes used in the CPP lang plugin,
I have to investigate whether it's a bug there or whether
it depends on this usage implicitly, maybe as requirement for
contexts in macro expansions...

To unbreak master, lets revert this for now.

This reverts commit b494fac2293237ab095f040cace27b7f3e899d80.

Niko Sams committed changes in [kdevelop] /gdb:

Fix Internal Debugger Error when clicking step into too fast

Always wait for a gdb reply (^done or ^running) before sending
the next command. *stopped is not a reply, as ^done will follow
and everything will get out of sync.
Also remove a workaround for handling attach response, as this
had apperently the same problem.

Niko Sams committed changes in [kdevplatform] vcs/widgets/vcsdiffpatchsources.cpp:

set Commit-Message Textfield LineWrapMode to NoWrap

because else the user might have the impression the message
is wraped - but it is not. This is especially bad as commit
messages should wrap at 72 chars.

Milian Wolff committed changes in [kdevplatform] /:

properly export IOutputView and push dtor implementation into cpp file

our other interfaces do the same and I remember issues on windows if that
is not done.

furthermore I noticed failing dynamic casts without exporting the header
on the unit-test machine

Diffs: 1, 2, 3 Revision b01b8ca...
Milian Wolff committed changes in [kdevplatform] shell/languagecontroller.cpp:

use IDocument for mimetype query when available in language controller

this way we get proper language support when opening files without extension
like e.g. <memory> or similar system headers. Furthermore there are scripting
languages that use the shebang instead of the extension to advertise their mimetype

Niko Sams committed changes in [kdevplatform] sublime/mainwindow.cpp:

Fix saving debug toolbar visibility

The debug toolbar visibility wasn't saved correctly when the
mainwindow was closed while debug area was active, as the mainwindow
was hidden and so isVisible returned always false. isVisibleTo does
what we want.

Aleix Pol Gonzalez committed changes in [kdevplatform] plugins/patchreview/patchreview.cpp:

Prevent crashing when trying to update the current patch.

Olivier Jean de Gaalon committed changes in [kdevplatform] language/duchain/stringhelpers.cpp:

Fix clearComments() to work with "//*" and "/*//*/" stuff that it used to choke on
(See testClearComments in test_cppcodecompletion)

Niko Sams committed changes in [kdevelop] /gdb:

When starting gdb read breakpoints and merge them with existing ones

That way we don't get duplicates when the user adds new ones using .gdbinit
for every session, and we save them additionally.

Educational

Laurent Garnier committed changes in [kgeography/cherry_field] /:

Made placeasker give more consistent results.

If part placing is considered good enough, reported color should be the
good one.
And conversely if placing is considered not good enough,
reported color should not be the good one. Chosen way to achieve this is
to compare the part displaced pixels with what is beneath. The
represented color(s) are collected with the count of pixels for each.
I introduced a second chance to consider the placing good enough
if sufficient a ratio of matching pixels is found.
If no such "good" ratio is found, we choose the most represented color
that is not the good answer.

Diffs: 1, 2, 3, 4, 5 Revision 8f84b55...

Graphics

Aurélien Gâteau committed changes in [gwenview] /:

Force refresh of selected thumbnails when F5 is pressed.

Aurélien Gâteau committed changes in [gwenview] /:

Follow KDE settings for double-click vs single-click on start page as well



@Christopher: After playing around with various settings, I realized the UI
of the start page is too similar to the thumbnail view to use a different
behavior.

Marcel Wiesweg committed changes in [digikam] /:

Do not handle rotation by exif flag with libtiff, which will do weird stuff
like only rotating rows.

Marcel Wiesweg committed changes in [libkface] libkface/image.cpp:

d can be null. Add missing checks to avoid crash.

Marcel Wiesweg committed changes in [digikam] /:

Use fromLocal8Bit to convert gphoto2's strings to QString

Aurélien Gâteau committed changes in [gwenview] lib/thumbnailview/thumbnailview.cpp:

Regenerate thumbnails when the files are modified outside of Gwenview

KDE Base

Dawit Alemayehu committed changes in [kwebkitpart/1.2] src/kwebkitpart_ext.cpp:

- Use QWebPage's built-in actions to copy link url so that URL are properly encoded.
- Make sure the URL we copy from a media element, which is not supported by a
QWebPage action, is properly precent encoded.

Dawit Alemayehu committed changes in [kdelibs] kioslave/http/http.cpp:

Workaround yet another broken server that sends the incorrect mime-type information.

This time it is the ArchLinux servers sending application/x-xz instead of
application/x-xz-compressed-tar when downloading packages.


FIXED-IN: 4.6.5

(cherry picked from commit 3332be75106b7d555e7a44a24875b0b5085821f1)

Dawit Alemayehu committed changes in [kde-runtime] /:

- Removed the regular expression check for IP addresses since QUrl/KUrl now
correctly parse almost all short url addresses.
- Create the remaining QRegExp checks once instead of on demand.
- Use KUser for username name and directory shortcuts, e.g. ~/, resolution.
- Percent-encoded extra '@' within a URL's username component (Workaround).
- Added unit tests for IPv6 URLs and escaping of '@' in usernames.



FIXED-IN: 4.6.5
REVIEW: 101576

(cherry picked from commit d1101e6dae09c73bbf319061fc229da936c4e4bf)

Matthias Fuchs committed changes in [kdeplasma-addons] /comic:

Implements a timeout. If a comic plugin did not provide the image after 15 seconds automatically report an error.

Oswald Buddenhagen committed changes in [kde-workspace/KDE/4.6] /backend:

use monotonic clock if available, take 2


FIXED-IN: 4.6.5

(cherry picked from commit a38d29482cbada78f1ab9f894c871c4135cd8c17)
(cherry picked from commit 7cec744e7f32da33c612288b4cffdf954ee12b06)
(cherry picked from commit 4ce1bda0decb3a5f3be9c4eed29154ae599fe14b)
(cherry picked from commit 42dbcf6de248231a430ff4199a324881ecedaa89)
(cherry picked from commit 17e305fb3e3aa8ed0048e2683b2a7a0a3506f9b6)

Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqmainwindow.cpp:

Do not provide "http://www" completion when the typed in text contains any kind
of white space.


FIXED-IN: 4.6.5
REVIEW: 101552
(cherry picked from commit 3f8f8d1d96d407e7959c7063a1ff7f9923a889ae)

Dawit Alemayehu committed changes in [kde-baseapps] lib/konq/favicons/favicons.cpp:

Include the port number in the favicon URL name.


FIXED-IN: 4.6.5
REVIEW: 101577

(cherry picked from commit aaa3b61edc4cdeaf67c8a3d6a0eacbd15e044469)

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.6] konq-plugins/searchbar/opensearch/OpenSearchEngine.cpp:

Treat returned content as Utf8 since that is what we requested to recieve
in the first place.


FIXED-IN: 4.6.5

Kurt Hindenburg committed changes in [konsole] src/SessionController.cpp:

For remote session, 'Open File Manager' will open the user's home path.

Currently, when using 'Open File Manager' on a remote session,
unexpected results will occur. For example, for ssh, it will try to
open another Konsole to ssh into the remote server.
Other options to consider in the future, disabling the menu and
transforming URL into what the user might expect.

Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqview.cpp:

Do not change the tab icon if the supplied url is invalid, e.g blank.


FIXED-IN: 4.6.5
REVIEW: 101626

(cherry picked from commit 831d3d151f517e41c87bd1c6f8338cec225959ea)

Dawit Alemayehu committed changes in [kdelibs] kdewebkit/kwebpage.cpp:

Check the QAction returned by QWebPage::action before using it.

A regression in QtWebKit 2.2 branch returns a NULL for the SelectAll action and
causes the previous code to crash. As an added bonus we now set all the shortcut
keys instead of only the primary ones.

Thomas Lübking committed changes in [kde-workspace] /:

avoid calling QPixmap::paintEngine() in scene rendering

by checking the graphicssystem at startup
also avoid pixmap and memory leaking on the xrender backend, validate some pointers
on deletion in SceneOpnGL and avoid attempts to render ::isNull pixmaps

Diffs: 1, 2, 3, 4, 5 Revision 606983a...
Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqmainwindow.cpp:

Show the correct url when switching tabs after clearing Konqueror's location
bar using the clear button in the line edit or the backspace key.


FIXED-IN: 4.6.5
REVIEW: 101558

(cherry picked from commit e8abdb8bfe6f4973ceb47db487dfc61d0aefd8eb)

Dawit Alemayehu committed changes in [kdelibs] kio/kio/global.cpp:

Show proper error message message when a user attempts to access non-existent
files or directories.


FIXED-IN: 4.7.0

Oswald Buddenhagen committed changes in [kde-workspace] /backend:

be posix-compliant about monotonic clock detection

in theory, the libc could support it while the kernel does not, so a
compile-time check may be insufficient.

Aaron J. Seigo committed changes in [kde-workspace] krunner/krunnerdialog.cpp:

bigger default minimum size; prevents squishies.

Sebastian Trueg committed changes in [kde-runtime] nepomuk/servicestub/main.cpp:

Use the correct cataloge for the stub app itself and the service.

Thanks go to Lasse Liehu for the patch which loads the cataloge for the
started service and, thus, makes sure messages from the file indexer
service are translated.

Dawit Alemayehu committed changes in [kde-baseapps] /src:

Show proper error message when a malformed url is entered, e.g. www.kde,org.
Avoid converting a error url into another error url.


FIXED-IN: 4.6.5

(cherry picked from commit 69de0ca6475e8523c2b7de5bdd2471b68024912a)

Christoph Cullmann committed changes in [kate] kate/app/katedocmanager.cpp:

error check for loading of editor, output nice error message then die

thanks for the hint Marcel, better tell the user why we fail!

Peter Penz committed changes in [kde-baseapps] dolphin/src/dolphinmainwindow.cpp:
Matthias Fuchs committed changes in [kde-baseapps/KDE/4.6] dolphin/src/dolphinviewcontainer.cpp:

Return the url of the view instead of the url of the url navigator.

That way if a wrong protocol had been entered the currently watched directory will be returned.

REVIEW:101580
(cherry picked from commit 7c85b6206b76c434738ff6a5d2379a1c7d58fdb7)

Albert Astals Cid committed changes in [kdelibs/KDE/4.6] kdecore/kernel/kglobal.cpp:

Rebuild locale as soon as possible

By calling locale() instead of d->locale we ensure we kill the fake locale and rebuild the good one as soon as possible in the chain. This way we avoid that functions in klocale can end up calling kglobal::locale again that might kill the fake locale and then we end up in trouble because we just killed ourselves ( see backtrace in https://bugs.kde.org/show_bug.cgi?id=274169 )

acked by dfaure

REVIEW: 101509

Oswald Buddenhagen committed changes in [kde-workspace] kdm/backend/dm.c:

fix various timeouts when using a monotonic clock

we assume the value 0 to be "long ago", which is of course not true when
the clock starts at that value and the boot finishes in 2 seconds ...

Aaron J. Seigo committed changes in [kdelibs/KDE/4.6] kio/kio/kdirlister.cpp:

check value of itemList, can be null

REVIEW:101560

Christoph Cullmann committed changes in [kate] kate/plugins/externaltools/externaltools:

remove broken commands
thanks for pointing this out to Jon Nelson

David Faure committed changes in [kdelibs/KDE/4.6] /kernel:

Fix DBus timeout when kbuilsycoca takes too much time to run

... or when a kuniqueapplication takes time to start.

This should fix a large number of bugs where ksycoca code crashes
due to not waiting enough for kbuildsycoca.

I'll also get a patch into future versions of Qt to make the timeout
configurable in QDBusAbstractInterface, so that we don't have to port
all the possibly-long dbus calls to QDBusConnection like in this patch.

KDE-PIM

Stephen Kelly committed changes in [kdepim] /:

Set the charset and content transfer encoding on saved and new notes.

Office

Boudewijn Rempt committed changes in [calligra] libs/kotext/KoBookmark.cpp:

KoBookMark: make sure end and start bookmark have matching names

Set the name on the endbookmark if we set the endbookmark on the
startbookmark: the name was only set on the endbookmark if we set a
name on the startbookmark, but often people create a start bookmark,
set a name, create an endbookmark and set it on the startbookmark.

Sebastian Sauer committed changes in [calligra] words/part/frames/KWCopyShape.cpp:

Fix crash on scrolling through the doc attached to bug 274905
The root-area can be NULL.

[KCrash Handler]
6 0x00007fb31e1344fa in KoTextLayoutRootArea::setPage (this=0x0, textpage=0x1901780) at /home/snoopy/src/calligra/libs/textlayout/KoTextLayoutRootArea.cpp:79
7 0x00007fb3104c98bf in KWCopyShape::paint (this=0xb2a360, painter=..., converter=...) at /home/snoopy/src/calligra/words/part/frames/KWCopyShape.cpp:92
8 0x00007fb324bad8ca in KoShapeManager::paintShape (this=0x1471640, shape=0xb2a360, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManager.cpp:369
9 0x00007fb324babdb7 in KoShapeManagerPaintingStrategy::paint (this=0x1471bb0, shape=0xb2a360, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManagerPaintingStrategy.cpp:52
10 0x00007fb324bad64a in KoShapeManager::paint (this=0x1471640, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManager.cpp:335
11 0x00007fb3104787c8 in KWCanvasBase::paint (this=0x1471108, painter=..., paintRect=...) at /home/snoopy/src/calligra/words/part/KWCanvasBase.cpp:316
12 0x00007fb31047e94c in KWCanvas::paintEvent (this=0x14710e0, ev=0x7fff99ccd5a0) at /home/snoopy/src/calligra/words/part/KWCanvas.cpp:156

Lukáš Tvrdý committed changes in [calligra] /libmso:

Convert DIB images into PNG images

o rendering engine does not support displaying DIB format,
therefore we convert the image to PNG
o enumerify
o coding style

Lukáš Tvrdý committed changes in [calligra] filters/libmso/shapes2.cpp:

Fix the size of the ellipse

Use draw:ellipse tag instead of enhanced geometry
as there is probably some bug in engine when
interpreting enhanced geometry

Cyrille Berger Skott committed changes in [calligra] krita/plugins/formats/raw/kis_raw_import.cpp:

make the preview directly as 8bit image

fix crash when loading the preview with kdcraw >= 4.6, still crash later

José Luis Vergara committed changes in [calligra] krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp:

Temporary bug fix of the Krita layerbox to let artists paint with the master branch

o Minimal bugfix, good for the user, but probably not correct from a coder's point of view.
o It will be replaced by a more correct bugfix later (unless this was actually the most correct way to fix it).

Matus Uzak committed changes in [calligra] /words/msword-odf:
Boudewijn Rempt committed changes in [calligra] krita/image/kis_async_merger.h:

Fix crash when updatable rect is empty

Fix by Cerebrosus. We should't actually do anything if the updaterect
is empty for some reason.

Sebastian Sauer committed changes in [calligra] filters/words/msword-odf/wv2/src/styles.cpp:

Fix invalid data-pointer in the msword-filter.
The reason for the bug was that we where ending with random values
what could work but sometimes didn't.

Matus Uzak committed changes in [calligra] filters/words/msword-odf/graphicshandler.cpp:

DOC: Ignore topmost group shape as we do in libmso.

* The topmost group shape (patriarch shape) is ignored in libmso.
* It was not ignored in the mswordodf filter, because the group rectangle
was always set to a NULL rectangle and I was waiting for some test data
to get into problems. A few test files where the rectangle is set
to negative values were found and now the patriarch can be ignored properly.

Sebastian Sauer committed changes in [calligra] /textlayout:

Pass the name of the master-page on to subframe- and table-iterators.

Stephane Mankowski committed changes in [skrooge] /:

BUG: No display of initial value (0000) in graph when history mode is not selected
BUG: Now the forecast period is equal to the real period

Diffs: 1, 2, 3 Revision 28c6be3...
Sebastian Sauer committed changes in [calligra] /:

Fix Hyperlink with in the table should be displayed clearly.
The reason was that we never handled the 'normal' case where the text should not be
super- or subscript and therefore once super- or subscript was set all child-styles
inherited it and where not able to go back to 'normal' state. This is fixed now
by using the "0% 100%" hack OO.org uses too to define the 'normal' text-position.

Sebastian Sauer committed changes in [calligra] libs/textlayout/FrameIterator.cpp:

Fix words hangs loading this document.
FrameIterator's with different addresses can be the same.

Sven Langkamp committed changes in [calligra] /ui:

use presets instead of paintops in popup palette

Sebastian Sauer committed changes in [calligra] /:

Also proper position textframe's anchored to pages.
This fixes the positions of the textboxes at the doc attached to bug 274905.

Cristian Oneț committed changes in /trunk/extragear/office/kmymoney/kmymoney/wizards/newloanwizard/keditloanwizard.cpp:

Allow entering an interest rate with three decimal places when editing the loan just like when creating it.

Sebastian Sauer committed changes in [calligra] libs/textlayout/KoTextLayoutArea_paint.cpp:

Fix crash on editing.
Should not happen but happens on loading the doc attached to bug 274905, navigating the
textcursor to the end at the last page, pressing a few dozend times enter to add a new
page, add some text and scroll down.

[KCrash Handler]
6 0x00007f979def2ab5 in raise () from /lib64/libc.so.6
7 0x00007f979def3fb6 in abort () from /lib64/libc.so.6
8 0x00007f979ec50ef8 in qt_message_output (msgType=QtFatalMsg, buf=0x1a379a8 "ASSERT failure in QList<T>::operator[]: \"index out of range\", file /home/kde4/qt/include/QtCore/qlist.h, line 464") at /home/kde4/svn/qt/src/corelib/global/qglobal.cpp:2259
9 0x00007f979ec51074 in qt_message(QtMsgType, const char *, typedef __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7f979edf9818 "ASSERT failure in %s: \"%s\", file %s, line %d", ap=0x7fffb9c7e9b0) at /home/kde4/svn/qt/src/corelib/global/qglobal.cpp:2305
10 0x00007f979ec518e2 in qFatal (msg=0x7f979edf9818 "ASSERT failure in %s: \"%s\", file %s, line %d") at /home/kde4/svn/qt/src/corelib/global/qglobal.cpp:2488
11 0x00007f979ec50aeb in qt_assert_x (where=0x7f979d432088 "QList<T>::operator[]", what=0x7f979d432075 "index out of range", file=0x7f979d432050 "/home/kde4/qt/include/QtCore/qlist.h", line=464) at /home/kde4/svn/qt/src/corelib/global/qglobal.cpp:2012
12 0x00007f979d40e241 in QList<QRectF>::operator[] (this=0x1837770, i=1) at /home/kde4/qt/include/QtCore/qlist.h:464
13 0x00007f979d4093a2 in KoTextLayoutArea::paint (this=0x1837690, painter=0x7fffb9c80690, context=...) at /home/snoopy/src/calligra/libs/textlayout/KoTextLayoutArea_paint.cpp:136
14 0x00007f978ae83678 in TextShape::paintComponent (this=0x10bf640, painter=..., converter=...) at /home/snoopy/src/calligra/plugins/textshape/TextShape.cpp:140
15 0x00007f97a3c6d517 in KoShapeContainer::paint (this=0x10bf640, painter=..., converter=...) at /home/snoopy/src/calligra/libs/flake/KoShapeContainer.cpp:157
16 0x00007f97a3c7293a in KoShapeManager::paintShape (this=0x14bf070, shape=0x10bf640, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManager.cpp:369
17 0x00007f97a3c70e27 in KoShapeManagerPaintingStrategy::paint (this=0x14bf5e0, shape=0x10bf640, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManagerPaintingStrategy.cpp:52
18 0x00007f97a3c726ba in KoShapeManager::paint (this=0x14bf070, painter=..., converter=..., forPrint=false) at /home/snoopy/src/calligra/libs/flake/KoShapeManager.cpp:335
19 0x00007f978f75b244 in KWCanvasBase::paint (this=0x14beb08, painter=..., paintRect=...) at /home/snoopy/src/calligra/words/part/KWCanvasBase.cpp:316
20 0x00007f978f7613c8 in KWCanvas::paintEvent (this=0x14beae0, ev=0x7fffb9c81160) at /home/snoopy/src/calligra/words/part/KWCanvas.cpp:156
21 0x00007f97a0169181 in QWidget::event (this=0x14beae0, event=0x7fffb9c81160) at /home/kde4/svn/qt/src/gui/kernel/qwidget.cpp:8346

Thorsten Zachmann committed changes in [calligra] /:

Fix 275376 - Indent of first line in list wrong

Thanks to Matus Uzak for providing the updates to the mswords filter
which are part of the patch.

Cyrille Berger Skott committed changes in [calligra] krita/ui/kisexiv2/kis_exif_io.cpp:

fix reading of ExifVersion, when it is returned as a string

Lukáš Tvrdý committed changes in [calligra] filters/libmso/shapes2.cpp:

Render the cycle diagram correctly

Circular Arrow shape returns the adjustedValue,
adjustedValue2 16 bit shifted. adjustedValue3 is not shifted.

Multimedia

Teo Mrnjavac committed changes in [amarok] src/likeback/LikeBack.cpp:

Fixed bug with the LikeBack reappearing even if disabled.

Even if the LikeBack icons in the top right of every window were
disabled, they used to reappear after reporting an issue because of poor
logic with a signal/slot connection.

FIXED-IN: 2.4.2

Rick Chen committed changes in [amarok] /:

Fix google cover fetching


FIXED-IN: 2.4.2

Giorgos Kylafas committed changes in /trunk/KDE/kdemultimedia/juk/playlistsearch.cpp:

juk: load search playlists even when containing empty patterns.

When a new search playlist is created, we are allowed to not fill any
"search lines" with our criteria. This means that when a new search
playlist is created/saved, it may contain search components with empty
patterns. However, when loading a search playlist from disk, we signal
an error if we read an empty search pattern. As a result, the playlist
does not get loaded and JuK gives the impression that it does not save
the search playlists.

Since we are presented with two search lines when creating a new search
playlist (see AdvancedSearchDialog's ctor), the above has a rather high
chance of happening.

So, upon loading, we should not consider the presense of empty patterns
as an error.

Giorgos Kylafas committed changes in /trunk/KDE/kdemultimedia/juk/playlist.cpp:

juk: keep the order of tracks when loading a plain playlist.

Plain Playlists are saved by explicitly writting the filenames of the
tracks they contain (in contrast, SearchPlaylists store only their
search pattern and FolderPlaylists only their folder). The filenames are
written to the disk in the order they appear in the playlist.

So, when loading such Playlists, disable sorting before adding the
tracks, so that they appear in the order they were saved.

Giorgos Kylafas committed changes in /branches/KDE/4.6/kdemultimedia/juk/juk.cpp:

juk: save the collection list cache no matter how the app exits.

Cache::save() was called from JuK::slotQuit(), which was triggered only
by "File->Quit". So, the cache was not saved when closing the window or
right-clicking the system tray and selecting "Quit",

JuK::queryExit() is called in every case, so put Cache::save() there.
Besides, according to KMainWindow's documentation, "a typical usage of
queryExit() is to write configuration data back".

While at it, remove saveConfig() from slotQuit(), since it is already
being called from queryExit().

This is a backport of r1236077 from trunk to branch 4.6 (KDE SC 4.6.5).

Giorgos Kylafas committed changes in /trunk/KDE/kdemultimedia/juk:

juk: no crash-on-exit while playing, no matter how we exit.

Since r921339, we stop the playback during exit, otherwise some phonon
backends will crash. However, the relevant code was only executed when
selecting "File->Quit", not when closing the window nor when quitting
from the system tray.

So, similarly to r1236077, put the stopping of playback into queryExit()
to get executed in every case.

Being in queryExit() means quit() has already been called. So, we can no
longer wait for Phonon's StoppedState and then call quit(), as was done
in r921339.
However, waiting for Phonon's state change does not seem to be necessary
any more, so we can safely remove slotPlaybackStopped().

Kevin Funk committed changes in [amarok] src/context/engines/videoclip/VideoclipEngine.cpp:

Fix possible crash in VideoClipEngine

FIXED-IN: 2.4.2

Trever Fischer committed changes in [phonon-gstreamer/plumbing] /:

Fix signal emission of the source change.

Previously, it emitted currentSourceChanged up to 30 seconds in advance.
Thats because the source really did /technically/ change, from the
pipeline's view. This introduces another viewpoint by having the
mediaobject keep track of the source the hardware is actually seeing
(and thus the user hearing).

Ralf Engels committed changes in [amarok] src/dialogs/DatabaseImporterDialog.cpp:
Kevin Funk committed changes in [amarok] /:

Apply background images to the various browsers

Actually, setAnimated(true) (which is used on all browsers) causes the
bg images to flicker when collapsing the upper level item view items.

Not sure if that's important to fix. FYI, reimplementing paintEvent does
*not* solve this. It's a bug in Qt.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 7a39afb...
Kevin Funk committed changes in [amarok] /:

Fix playlist tooltip getting too tall

Might be the case if comment strings are too long.

FIXED-IN: 2.4.2

Harald Sitter committed changes in [phonon-vlc] /:
Kevin Funk committed changes in [amarok] src/context/containments/verticallayout/VerticalAppletLayout.cpp:

Networking Tools

Ilia Kats committed changes in [networkmanagement/nm09] /:

let the user decide if he wants to store his GSM PIN or type it in
every time

Diffs: 1, 2, 3, 4 Revision bb4ce85...
George Kiagiadakis committed changes in [telepathy-chat-handler] lib/chat-widget.cpp:
Yoann Laissus committed changes in [rekonq] src/bookmarks/bookmarkstoolbar.cpp:

Don't close Bookmark Toolbar's subfolders on a click

Lamarque Souza committed changes in [networkmanagement] /:

Try to prevent opening kwallet when there is no secret to retrieve.

Martin Klapetek committed changes in [telepathy-contact-list] main-widget.cpp:

Fix a crash when the config contains invalid account ID for setting avatar.

Reviewed-by: David Edmundson

Lamarque Souza committed changes in [networkmanagement/nm09] vpnplugins/openvpn/openvpnwidget.cpp:

Use KStandardDirs to find openvpn binary. I have added the second parameter
because by default findExe does not search in "/sbin:/usr/sbin" path.

Thanks Rajeesh K Nambiar for this patch.

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Import VPN connections from configuration files. Only VPNC is
implemented so far.
Thanks Rajeesh K Nambiar for implementing this patch.



REVIEW: 101419

Lamarque Souza committed changes in [networkmanagement/nm09] libs/internals/settings/gsm.cpp:

Set default Gsm's pin flags to NotSaved, which is the default in master
branch. The default is NotSaved because we do not have any guarantees
that the modem/phone that is connecting is the same one that was there
when the connection was created. Everybody knows what happens when we
send the wrong pin many times so let's try to prevent that as most as we
can.

Lamarque Souza committed changes in [networkmanagement/nm09] applet/nmpopup.cpp:
Francesco Nwokeka committed changes in [telepathy-presence-applet] /contents/ui:

ADD: scrollbar effects when resizing plasmoid


the scrollbar fades out when not needed and back in when needed.

User Interface

Ruslan Kabatsayev committed changes in [oxygen-gtk] src/animations/oxygeninnershadowdata.cpp:

Disable inner shadow hack for GtkPizza

Ruslan Kabatsayev committed changes in [oxygen-gtk] /:

Set GtkNotebook to not show border when tabs are not shown in 'realize' signal hook instead of when drawing shadow.
This removes flicker on first drawing of such notebook

Utilities

Burkhard Lück committed changes in /branches/KDE/4.6/kdeutils/sweeper/privacyfunctions.cpp:

fix to clear 'Closed Items History'
REVIEW:6708

FIXED-IN:4.6.5

Jan Lepper committed changes in [krusader] /:

FIXED: [ 2773302 (sf.net) ] krarc can't handle brackets in file paths inside ZIP archive

Features

Development Tools

Alexander Dymo committed changes in [kdevplatform] plugins/grepview/grepoutputview.cpp:

Support F4/Shift-F4 shortcuts in find/replace plugin for jumping between search results from keyboard

Olivier Jean de Gaalon committed changes in [kdevelop] /cpp:

Get proper completion for "friend" and "friend class", add tests

Niko Sams committed changes in [kdevelop] /cpp/codecompletion:

When executing codecompletion item try to be smart and don't always delete following text

Use case:
QString str;
str|append(); //executing codecompletion item str doesn't remove append
//and inserts .
This works because append is a QString property.

In the worst case it behaves like before.

It also works for pointers, references and smart pointers.

Sebastian Kügler committed changes in [kdevelop] /:

New KDevelop sessions runnner

Adapted from the Kate session runnner.

You just type the session name, the runner will do partial or full
name matching, or list sessions when typing "kdevelop".

Diffs: 1, 2, 3, 4, 5, 6 Revision 6a2f317...
Aleix Pol Gonzalez committed changes in [kdevplatform] /patchreview:

Attempt to make the patch review toolview a little cleaner.
- after committing change again to localpatchsource.
- reorganize the location tab bar
- Add tooltip text to the next/previous hunk buttons

Diffs: 1, 2, 3 Revision 7e5df10...
Sven Brauch committed changes in [kdevplatform] /:

Made it possible to jump to error lines in executescript plugin

If you want to add a new RegularExpression to jump to, just add it in the ExecuteScriptOutputModel constructor. Currently there are PHP stacktraces, PHP errors / warnings, and python tracebacks.

Changes reviewed by Milian.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 461c4a3...
Alexander Dymo committed changes in [kdevplatform] /:

New implementation for the KDevelop "Ideal" UI based purely on QDockWidget's:
- our custom main window and layout (IdealMainWidget and IdealMainLayout) are gone
- toolviews are now managed as regular dockwidgets (with all benefits that Qt dockwidgets bring)
- buttonbars are implemented as toolbars (not movable/closeable)

New features comparing to the old implementation:
- drag-n-drop support for toolviews (with proper toolview button positioning)
- no bugs in toolview resizing (because we no longer have our custom layout)

This change will allow us in the future to show several toolviews on one
side without significant effort.

Removed features:
- "top" area is neither allowed nor used for toolviews nor is present in UI configuration
- no "maximizing" for toolviews (this might be brought back, but only if enough people use it)
- no "anchoring"/"locking" for toolviews (this will never be brought back,
it requires custom layout which we will not try to implement anymore)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 4e204dc...
Alexander Dymo committed changes in [kdevplatform] /grepview:

Make next/previous search result actions in find/replace plugin work even
when no result is currently selected in the output.

Olivier Jean de Gaalon committed changes in [kdevelop] /cpp:

Allow enum best-matches for binary operator functions

Aleix Pol Gonzalez committed changes in [kdevplatform] /:

Improve the IBranchingVersionControl interface.
Adapt nowadays branching solutions to the new interface, including git plugin and the
branching module.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 0908d79...
Jonathan Schmidt-Dominé committed changes in [kdevelop-pg-qt] /:

Added support for *ast-fwd.h, usages relying on *ast.h inclusion (php, sgml, css, java) have been fixed (erlang and C# do not compile because of smartrange changes)

Diffs: 1, 2, 3, 4 Revision 2670ce2...

Educational

Laurent Garnier committed changes in [kgeography/cherry_field] /:

placeasker fairer for parts not yet connected to any visible border.

If a part to place has no visible border yet in the current game, it is
more difficult to place than a part for which at least a portion of
border is "visible" (a neighbouring part with a common border is
already shown or the part has a border with a not clickable --and thus
already visible-- part).
One way to counterbalance this is to be more lenient on distance
criterium when the part to place has no visible neighbour than for a
place that has. So we have to know common borders. We get this by
scanning pixels at placeasker creation.

Diffs: 1, 2, 3, 4 Revision af5cdd1...

Graphics

Gilles Caulier committed changes in [kipi-plugins] /:

support RAW image for HTML export

KDE Base

Martin Gräßlin committed changes in [kde-workspace/kwin-wayland] kwin/toplevel.h:

Make opacity virtual

With non-X windows the window opacity will be determined in
a different way. So we need to reimplement the method.

Niko Sams committed changes in [kate] part/script/data/utils.js:

improve moveLinesUp/Down scripts

- keep selection, don't expand it
- only move selection, even if cursor is in next line

Martin Gräßlin committed changes in [kde-workspace/kwin-wayland] /:

(Un)Bind Wayland Display in EGL

Adding support to bind/unbind a Wayland display in EGL.
This is required for Wayland clients to get the display.

EGL Extension currently only supported by Mesa 7.11.

Diffs: 1, 2, 3, 4 Revision 3805c4b...
Matthias Fuchs committed changes in [kdelibs] kfile/kfilepreviewgenerator.cpp:
Thiago Macieira committed changes in /trunk/KDE/kdeartwork/kscreensaver/kdesavers:

Add an option to disable the effects in the slideshow screensaver.

The effects take a lot of CPU time, not to mention that they make
unlocking slow (the effect needs to end before the screen unlocks).

Martin Klapetek committed changes in [kde-runtime] knotify/notifybypopup.cpp:

Enable Plasma popup notifications to have different icons per defined event in .notifyrc file. Also keeps compatibility with current applications.

Reviewed-by: Aaron J. Seigo
REVIEW: 101470

Lukas Sommer committed changes in [kde-workspace] /:

Make font dpi fully configurable by the user

Adopts startkde.cmake to accept dpi values different from 96 and 120.

Adopts the UI in kcontrol to make dpi values from 1 to 1000 possible.
The spinbox uses steps of 24 dpi because the common dpi values 72,
96 and 120 are all multiples of 24. As some fonts are optimized for
these resolutions, this could make fonts look better.

FIXED-IN: 4.7
REVIEW: 101410
GUI:
DIGEST:

Dawit Alemayehu committed changes in [kde-runtime] kioslave/thumbnail/imagethumbnail.desktop:

Added preview support for ICO files.


FIXED-IN: 4.6.5

(cherry picked from commit 1749449fa96ac3a64896eaa94688cba5dea11a04)

Martin Gräßlin committed changes in [kde-workspace/kwin-wayland] /:

Infrastructure to inform Toplevels when a frame is rendered

We need this for Wayland clients as we have to pass a timestamp
to the Wayland client when the client got rendered. As we only
need it for Wayland, the base implementation in Toplevel does nothing
and the frameRendered method is only invoked after swapping the EGL buffer.

Diffs: 1, 2, 3, 4, 5 Revision cd481c8...
John Layt committed changes in [kdelibs] /:

kdeui: Add isNull() to new date/time widgets

Realised that a client wouldn't be able to tell the difference between
the user entering an invalid/incomplete date and not entering a date.

Also const fixes and some other small changes from review, apidox to
follow.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision d81cd46...
Martin Gräßlin committed changes in [kde-workspace/kwin-wayland] kwin/toplevel.cpp:

Use dummy WindowType for invalid NETWinInfo

A Wayland Client does not support NETWinInfo, so in the long this
method has to become virtual.

Martin Gräßlin committed changes in [kde-workspace/kwin-wayland] /:

KWin goes Wayland

Initial Implementation of a Wayland Server in KWin. The current
state allows to render Wayland "Clients" in the normal EGL
compositing backend. The content gets updated correctly when other
windows are damaged at the same time, but Wayland damage events
seem to be lost, when there are no other triggered repaints.

Wayland clients are added to the scene in the same way as Unmanaged
X11 windows and Deleted windows: on top of everything else. It is
currently not yet possible to interact in any way with the clients.
They do not get input events and you cannot move them or do anything
else fancy with them. Though they are already nicely integrated into
the Effects system. So all effects which handle unmanaged should
also handle the Wayland clients.

All new Wayland relevant code can be found in the directory wayland.
It contains the Server implementation (wayland.(cpp|h)), a representation
for Surfaces (surface.(cpp|h)) and a new subclass of Toplevel
(wayland_client.(cpp|h)).
All new classes are in a new namespace KWin::Wayland, the idea is
to move all X11 classes in a namespace KWin:X11 to better separate
what is generic (namepsace KWin) and what is backend specific.

The changes in the existing code base are tried to be kept to a
minimum. The biggest change is in the OpenGL EGL Scene which now
has to render Wayland buffers and XPixmaps. Also composite.cpp
has seen some changes to start/stop the Wayland server and adjust
the Toplevel's compositing functions to not create any X resources
for the Wayland client. This has to be split in a better way by
moving all X11 related code in a X11 specific implementation.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision e62eed9...

Office

Thorsten Zachmann committed changes in [calligra] /tables/excel/import:

Improve xls progress reporting

If there where a lot of embedded object there was not progress update for quite some time.
Also fot the odf loading part there was no update as the sidewinder updates reached 100%
before.
This commit changes the wight of the different parts of loading and adds reporting to loading
of embedded objects/shapes.

Stephane Mankowski committed changes in [skrooge/Feature] /:

FEATURE: Graphs in "Bank and Account" page

Diffs: 1, 2, 3 Revision 97c3742...
Boudewijn Rempt committed changes in [calligra] /pictureshape:

PictureShape: Make it possible to create an image shape with an image

Implement the createShape() method to look for a parameter called
"qimage" that contains a QImage and use that to properly create an
image shape programmatically.

Matus Uzak committed changes in [calligra] /words/msword-odf:

DOC: Improvements in processing of the background shading.

* Sharing one conversion function that translates the shading information
into a color in the format "#RRGGBB".
* Returning a reasonable default instead of shading patterns at the moment.
* Also some readability improvements.

José Luis Vergara committed changes in [calligra/krita-improvedpresetcreation-pe] /ui:

Finish connecting the new strip presets picker

In this commit:
o Connections have been made between kis_small_preset_handler and
kis_paintop_presets_popup as well as kis_paintop_box, thus allowing
the presets picker responds to most relevant signals (ie: paintop selected)
o Commented out code has been removed and the rest beautified.

Diffs: 1, 2, 3, 4, 5, 6 Revision 570ca57...
Shreya Pandit committed changes in [calligra/kexi-web-Shreya] /:

initial web widget for forms

Diffs: 1, 2, 3, 4, 5 Revision 60ab799...
Sebastian Sauer committed changes in [calligra] /part:

Turn page and line statusbar-items into editable ones like the zoom to allow jumping to page/line.

Sebastian Sauer committed changes in [calligra] /part:

Editable page-style statusbar-item that calls the 'Page Layout' dialog.

Diffs: 1, 2, 3 Revision c466b68...
Matus Uzak committed changes in [calligra/words-autocolor-uzak-ltvrdy] /words/msword-odf:

DOC: Improved support for a table cell shading color set to cvAuto.

* Looking for the base color of the paragraph or for a built-in style
in the styles hierarchy with a font color not set to cvAuto.

TODO: Not sure which background color to provide. Test files required!

Matus Uzak committed changes in [calligra/words-autocolor-uzak-ltvrdy] /words/msword-odf:

DOC: Automatic colors update.

* For built-in styles stored in the stylesheet, apply properties of a style
in the following order: CHP, PAP. Usually shading colors are set to cvAuto,
so the only relevant context to set shading properly are the font color
and the background color from CHPs. There's only one set of CHPs for built-in
styles of course.

Diffs: 1, 2, 3, 4, 5, 6 Revision c581207...
Stephane Mankowski committed changes in [skrooge] /:

Skrooge 1.0.0

Paul Mendez committed changes in [calligra/stage-gsoc-paulm] kpresenter/part/KPrSlidesSorterDocumentModel.cpp:

Stage: Add support for copy slides from other documents just by dragging

Refactor some code to let copy slides from other documents just by dragging
between slides sorter views. The context menu is modified, to avoid show
the move option when dragging from other document.

Matus Uzak committed changes in [calligra] /words/msword-odf:

DOC: TOC update (again)

This one got lost after the following revert:
commit 75d1438eb15719b23f7101dfe76bcbd9d2e3d08d

* Check the whole style inheritance tree to decide whether the current
paragraph is a heading.
* Added support for the \t switch of the TOC field. If this one is present,
then TOC includes paragraphs formatted with styles other than the built-in
heading styles. Making use of text:index-source-styles elements.
* Provide the style-name in the text:index-title-template element if possible.

Diffs: 1, 2, 3, 4, 5 Revision adc206e...
José Luis Vergara committed changes in [calligra/krita-saveincremental-pentalis] /ui:

Make Save Incremental avoid overwriting files and to be disabled on new files that haven't been saved

o Save incremental will use an auxiliary letter (a to z) and append it to the filename whenever it finds
an existing version with the same name.
o If the name of the file already included an incremental version with letters (i.e.: file_005b) it will
respect the letter and continue saving with it.
o Save incremental will be disabled on new files, it will become enabled when the file has been
saved at least once.

Thomas Zander committed changes in [koffice] /flake:

Remove old shapeConfigWidget usage and add new one.

The shape configureation concept before was mixing 3 usecases and
overly complex and to be honest, it failed at being sufficient for
2 out of 3 usecases.

This change makes the KoShapeConfigWidgetBase a lot more simple
and only for the usecase where a shape provides a configuration option
to a generic tool (as opposed to having a new specialized tool).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision d9caa31...
Lukáš Tvrdý committed changes in [calligra/words-autocolor-uzak-ltvrdy] /:

Implement the autocolor computation

o implemented algorithm for computation of the auto color in MS Docs as specified here

Torio Mlshi committed changes in [calligra/krita-animator-plugin-mlshi] /plugins/extensions/dockers/animatordocker:

Improve light table

1) Align sliders to center of docker
2) Add slider for current frame

Diffs: 1, 2, 3, 4, 5, 6 Revision 68d9ed1...
Dag Andersen committed changes in [calligra] /libs/ui/reports/odt:

Add report picture to odt export, to get chart as image.

Diffs: 1, 2, 3 Revision 1ab1f3d...
Silvio Heinrich committed changes in [calligra] /:

Implemented flow and opacity functionality equal to photoshop.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 23 more) Revision 31ad2b8...
Stephane Mankowski committed changes in [skrooge/Feature] /:

FEATURE: Addition of "Jump to the operation" in contextual menu of "Scheduled operations" page

Diffs: 1, 2, 3 Revision 31d5f00...
Lassi Nieminen committed changes in [calligra] /:

Xlsx filter: Support for groupshapes, shape rotation, reading chartsheets, diagramsheets,
initial support for legacydrawing, coding style improvements.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 3dc53e1...
Paul Mendez committed changes in [calligra] /:

Stage: Add support for standard Actions in Slides Sorter View

Integrate the following standard Actions in Stage Slides Sorter View
(connect actions to standard shortcuts and toolbar/menu buttons):
- Copy, Cut, Paste
- Select/Deselect all
- Delete current selection
REVIEW: 101562

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 12192be...

Multimedia

Kevin Funk committed changes in [amarok] /:

Add scripting interface for KNotify

Currently supports two methods:
* show(titleStr, bodyStr[, pixmap]);
* showCurrentTrack();


FIXED-IN: 2.4.2

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 83533cb...
Bart Cerneels committed changes in [amarok] /:

Enable drag and drop tracks to any collection.

Works inside the collection browser and from The Playlist.
Tested to/from USB, iPod and MySQL-collections.

funds += €250 http://mail.kde.org/pipermail/amarok-devel/2011-May/009047.html ?

Networking Tools

Marco Martin committed changes in [share-like-connect] /providers:

a provider to add/remove bookmarks

Diffs: 1, 2, 3, 4, 5, 6 Revision 499d015...
Marco Martin committed changes in [share-like-connect] /contents/ui:

support for share and like services

Diffs: 1, 2, 3 Revision 1da6571...
Francesco Nwokeka committed changes in [telepathy-chat-handler] /:

Part 1of3 - ADD new action buttons to caht handler

The new buttons are :
~ start a audio call
~ start a video call
~ start a file transfer
~ invite contact to chat

None of these are connected yet.

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Enable Nm08Connection's importer by default, old configuration files
will be deleted when imported.

Marco Martin committed changes in [share-like-connect] /providers:

an example for Share: send by email

Diffs: 1, 2, 3, 4, 5 Revision b36d6e4...
George Kiagiadakis committed changes in [telepathy-chat-handler] app/chat-window.cpp:

Set the default size of the window to be something sensible (460x440 looks good to me).

REVIEW: 101519
Reviewed-by: David Edmundson

User Interface

Hugo Pereira Da Costa committed changes in [kde-workspace] kstyles/oxygen/oxygenstyle.cpp:

Utilities

Jan Lepper committed changes in [krusader] /:

ADDED: option: Panel > Status/Totalsbar > Show space information

Diffs: 1, 2, 3, 4 Revision be38e2d...

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

improve framework for testing AI variants

this is not a bug fix, but no normal user will execute this code so
it should be safe to add. This is only of interest for somebody
wanting to improve the robot player artificial intelligence.

In demo mode, the csv records for game results now have a new first
field holding the AI variant used for the human player.
Adapted kajonggtest.py and made it more tolerant against missing
single games

Diffs: 1, 2, 3, 4 Revision 1235790

Other

Michael Gapczynski committed changes in [owncloud/sharing] /:

Initial setup of sharing app

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 8603b09...
Robin Appelman committed changes in [owncloud] /:

try to adjust times to the clients timezone

Diffs: 1, 2, 3, 4 Revision d65f8bb...

Optimization

Development Tools

Alexander Dymo committed changes in [kdevplatform] sublime/mainwindow_p.cpp:

Set 0 margins for toolbars that hold ideal button bars.
This means when KDevelop window is maximized, it will comply with
the "Fitts's law": the screen edge will be clickable.

Aleix Pol Gonzalez committed changes in [kdevplatform] shell/projectcontroller.cpp:

Save the files automatically, less dialogs, more happiness.

KDE-PIM

Volker Krause committed changes in [kdepim] messagelist/storagemodel.cpp:

Use QCryptographicHash instead of KMd5 and don't base64 encode the MD5 hash.

QCryptographicHash is about 2x faster for the input sizes we have here
(see benchmark in kdecore). The base64 encoding was totally pointless,
wasting 24 byte per message item (when threading is enabled) and slowing
down comparison/hashing by about 30%.

Volker Krause committed changes in [kdepim] /:

Remove some counter-productive premature optimizations.

Formatted size, date and max date are only used for visible items and
obtaining them is comparatively cheap. So, there is no point in wasting
memory by having a cache for them in every item.

Diffs: 1, 2, 3, 4 Revision 35fa2b5...
Volker Krause committed changes in [kdepim] /:

Reorder private class members to optimize memory layout.

Saves 16 bytes for MessageItem (on 64bit systems).

Diffs: 1, 2, 3 Revision 1d4330d...
Volker Krause committed changes in [kdepim] /:

Don't store the sender/receiver twice.

Not as bad as it looks, due to implicit sharing of QString's, but still
unnecessary. Instead use a bool to decide between sender and receiver. This
is of course global and not something that needs to be stored per item, but
it's much easier this way (and less risky to change for now). Since we
still have a few bits left in the ItemPrivate memory layout it doesn't cost
us anything.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision fa46627...
Volker Krause committed changes in [kdepim] /:

Use a QByteArray instead of a QString for the threading MD5 hashes.

This saves 88 byte per message item when threading is enabled.

Diffs: 1, 2, 3, 4, 5 Revision bd50801...

Office

Boudewijn Rempt committed changes in [calligra] /part/dialogs:

Don't use KoAction anymore

This was the last place KoAction was used. We can remove it now.

Boudewijn Rempt committed changes in [calligra] /main:

KoPrintingDialog: print in gui thread

Originally, the printing dialog used KoAction, which was buggy and the
actual printing was done in the gui thread anyway. Move the printing to
the gui thread, but use processEvents to allow the user to cancel the
print job.

Sebastian Sauer committed changes in [calligra] krita/ui/kis_statusbar.cc:

Expand KSqueezedTextLabel in Krita's statusbar to available height.
More pixel-perfect less-noise statusbar.
see before/after on http://kross.dipe.org/KritaStatusBar.png
Ok?

Boudewijn Rempt committed changes in [calligra] /:

Remove KoAction system

KoAction was based on ThreadWeaver and a system to kick off
background actions. It never worked very well and was more
or less untestable. And it was used in only two places:
the statistics docker and the printing dialog.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 92bd044...
Thorsten Zachmann committed changes in [calligra] /part:

Don't read styles 3 times

Reuse the KoShapeLoadingContext for loading of headers and footers. With
this change it is no longer needed to parse the styles again when loading
the headers/footers as it reuses what is already there.
This should speedup loading of text documents having a lot of styles as the
styles loading will be done in a 1/3 of the time then before.

Other

Sebastian Sauer committed changes in [calligra] /:

restore 16280fad7b90f41b4b43c90371e35b35c92b6b25
Seems the merge of master into master was correct and the revert done in 75d1438eb15719b23f7101dfe76bcbd9d2e3d08d was not.
Probably all that was the result of me not using anongit at all cause of the performance and push problems we had? Maybe
somehow that resulted now in two repos not being in sync? Well, who knows :-/ Let's hope it doesn't happen that often.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 2bfcf45...