Issue 195

7th August 2011 by KDE Commit-Digest Team


Danny Allen
Marta Rybczynska
Alexander van Loon

This Week...

Calligra sees work on DOC list styles, improved drag-and-drop in Document Structure Docker and multiple bugfixes; kformula becomes a shape. The split/migration of image and thumbnails databases has started in Digikam. There is a new and improved describeResources method in KDE-Runtime. Kate now highlights GNU LD scripts. There is a new journey search string parser in PublicTransport. Optimizations have been made in route rendering in Marble, and preview rendering in KDE-Base. Umbrello receives work on the new code importing wizard. The way Konsole queries for the PTY size is changed, this should fix multiple problems with terminal dimensions. Bugfixes in Kate, Amarok, Phonon, Network Management.


Commits 2352 by 216 developers
Open Bugs 23314
Open Wishes 17491
Bugs Opened 559 in the last 7 days
Bugs Closed 669 in the last 7 days

Commit Summary

Module Commits
Files Developer Commits
Iñigo Salvador Azurmendi
Gilles Caulier
Laurent Montel
Harald Sitter
Burkhard Lück
Robin Appelman
Timothy Pearson
David Faure
Patrick von Reth
Sairan Kikkarin

Internationalization (i18n) Status

Language Percentage Complete
Brazilian Portuguese (pt_BR)
Swedish (sv)
Estonian (et)
Spanish (es)
Dutch (nl)
German (de)
British English (en_GB)
Italian (it)
Low Saxon (nds)
French (fr)

Bug Killers

Person Bugs Closed
Christoph Feck
Jekyll Wu
Darío Andrés
Gilles Caulier
Christophe Giboudeaux
Dominik Haumann
Myriam Schweingruber
bbeschow cs tu-berlin de
kollix aon at
Laurent Montel

Commit Countries

Commit Demographics




  Bug Fixes Features Optimization Security Other



Development Tools

  []    []


[] [] []   


[] []    []

KDE Base

[] [] []   []




[] []    []




[] []    []

Networking Tools

[] []    []

User Interface



  []    []


   []   []


  []    []

There are 103 selections this week

Bug Fixes


Volker Lanz committed changes in /trunk/playground/edu/workout/src/core/activity.cpp:

Fix calculations for average speed, heart rate, cadence and pace. Original
patch suggested by Anton Rasmussen.


Marcel Wiesweg committed changes in [digikam] /:

Fix detection of chosen image format if the selected filter has more than one "*.xy" suffix
in the filesaveoptionsbox. In that case, we need to analyse the string and just
use the first suffix.

Francesco Riosa committed changes in [digikam] data/database/dbconfig.xml.cmake:

Migration: splitted mysql database fixes

Migration of a sqlite database to a mysql one didn't create
create_index_if_not_exists() stored procedure in the thumbnail database,
leading to failed update if index already existed.

Data of the thumbnail database is not copyed at all, but the content of
the "Settings" table are needed and checked. Workaround the problem
checking/inserting the two needed records at creation time.

Gilles Caulier committed changes in [digikam] /cameragui:

Do not overwrite download status from DB when thumb/info are get on the fly. This fix download indicators over icon view items.
Do not overwrite file mtime get at camera connection when metadata are updated with thumbnails. This fix Ordering of icon view items.
Fix loop to get download status. No need to copy map.
Improve and simplify icon-view loop to refresh items depending of sort order.
Less CameraIconItem dependency to preprare camera Icon View Qt4 model/view port.

KDE Base

Burkhard Lück committed changes in [kdelibs/KDE/4.7] kdeui/dialogs/kdialog.cpp:

Resize KMessageBox::detailedError at start to display all text

Quoting the BR:
'When using KMessageBox::detailedError() it sometimes doesn't resize properly to
show all the text'

commit this on behalf of Dario Andres (

(cherry picked from commit 370d3ed6e5153fc61b774cf2640acc72d334033d)

Sebastian Trueg committed changes in [kde-runtime] /services:

Made the file indexer's indexFile honor the scheduler's queue.

Now the file to be indexed is enqueued in the filesToIndexQueue. That
way the file watcher can use the indexFile method to update modified
and newly created files without updating the whole folder.

REVIEW: 102197

Diffs: 1, 2, 3, 4 Revision c7b518e...
Jan Gerrit Marker committed changes in [kde-workspace] plasma/generic/applets/systemtray/ui/applet.cpp:

Let the hide configuration dialog look better

Now the columns are resized to fit there content.

REVIEW: 102210

Sebastian Trueg committed changes in [kde-runtime] /services/storage:

Handle special case in removeDataByApplication.

When a call to removeDataByApplication removes the entire resource but
there is still an incoming relation created by another application
then we keep the metadata of the resource. But only if the resource has
a nie:url. Without a nie:url the left over metadata is pointless but
with a nie:url the resource can still be identified even outside of
This fix is important for any indexer like the file indexer or the
Akonadi indexer since they use removeDataByApplication do update
resources. Without this fix incoming relations would be deleted and
the resource URI would change.

The same fix still has to be implemented for the other variant of
removeDataByApplication. It is, however, by far not as urgent since
it is not used anywhere yet.

Diffs: 1, 2, 3 Revision f0c0322...
Anton Kreuzkamp committed changes in [kde-workspace] libs/taskmanager/groupmanager.cpp:

On VD- or activity change just add a launcher if it should be shown.

Rolf Eike Beer committed changes in [kdelibs/frameworks] kioslave/http/http.cpp:

accept HTTP headers that are not followed by whitespace after the colon

>From RfC 2616, section 4.2 (Message Headers);

Each header field consists of a name followed by a colon (":") and the
field value. [...] The field value MAY be preceded by any amount of LWS,
though a single SP is preferred.

"any amount" includes "nothing".

Kai Uwe Broulik committed changes in [kde-baseapps] dolphin/src/dolphinmainwindow.cpp:

Add missing separators to the "Help" sub-menu of Dolphin's menubar replacement like all KDE apps have

Andrea Iacovitti committed changes in [kdelibs/frameworks] /rendering:

Unbreak completion on tab-out.

KLineEdit no longer emits textEdited signal when scrolling completion
list (see commit 8db60a2f) then use textChanged as in the past.

FIXED-IN: 4.7.1
(cherry picked from commit 2a90109ab5ff7f53b4ed0555eef3e45428619f9b)

Kurt Hindenburg committed changes in [konsole] /:

Make sure pty device has right size before terminal process queries it.

Whenever TeminalDisplay is resized, konsole tells the underlying
pty device its new size by calling Pty::setWindowSize(). However,
current code can't guarantee when the terminal process starts and
queries the pty device about its size, the pty device already has the
right info. This has caused some long known bugs, such as #176902.

This patch tries to guarantee that important assumption. It currently
uses a hard-coded small delay, which works pretty well in practice
although not that elegant.

Patch by Jekyll Wu

I think this is better than leaving the situation as it is. This may
be backported if no issues are found.

REVIEW: 102061

Aaron J. Seigo committed changes in [kde-workspace/KDE/4.7] /desktop/shell:
Burkhard Lück committed changes in [kde-workspace/KDE/4.7] klipper/generalconfig.ui:

Delete duplicated configuration options

Klipper's configuration dialog has duplicated options
kcfg_ReplayActionInHistory + kcfg_StripWhiteSpace on
the General + Actions page.

Commit log of Revision 1052730 (added kcfg_ReplayActionInHistory
+ kcfg_StripWhiteSpace to actionsconfig.ui) reads:
'Move actions-related config to action config dialog...'

Apparently it was forgotten to delete these actions from generalconfig.ui,
so in fact it was a Copy not a Move.

(cherry picked from commit 3326a0f1c58809176020be54aa17d52ca94878ef)

Dominik Haumann committed changes in [kate] /:

remove search/replace bar from view bar, to minimize the height

Dominik Haumann committed changes in [kate/KDE/4.7] part/syntax/data/makefile.xml:

fix {...) and (...} matching

Kurt Hindenburg committed changes in [konsole] src/main.cpp:

Add --nofork to the --help output.

--nofork is under --help-kde which is often overlooked by users.
Placing a comment under --help should cause less problems for users.

Andrea Iacovitti committed changes in [kdelibs/KDE/4.7] /rendering:

Fix infinite loop that can happen in some cases where colspan=0 or rowspan=0
because accessing empty structures. Tracking for not empty qmap by using
additional flag is redundant and buggy in this case.

(cherry picked from commit 543c2751da42c1664171685e25fbce594024d9cd)

Rolf Eike Beer committed changes in [kdelibs] /http:

properly handle empty HTTP auth challenges


Laurent Montel committed changes in [kdepim] /:

Fix Bug 279290 - Emails being sent are briefly shown as unread in the system tray icon


Pierre Ducroquet committed changes in [calligra] libs/odf/KoBorder.cpp:

Fix parsing of borders to support the fact that in OpenDocument (and XSLT/CSS), every part of the borders description is optionnal, hence 'black' is a perfectly fine border...

Matus Uzak committed changes in [calligra] /kpresenter/powerpoint:

PPT: Updated inheritance of text/paragraph properties.

* A common shape (opposite of a placeholder) SHOULD contain text of type Tx_TYPE_OTHER,
but MS Office 2003 does not follow this rule.

Cristian Oneț committed changes in /trunk/extragear/office/kmymoney/kmymoney/models/accountsmodel.cpp:

Update all the model items even if an account is favorite in which case there are two items which correspond to the same account. This is another case of account data change that affects the model layout that was not handled correctly.
And extra fix of the AccountsFilterProxyModel::removeAccountType which now really removes the account type even if the type is present in the list more then once (m_typeList should really be a set).

Inge Wallin committed changes in [calligra] /vectorshape/libsvm:

SVM: Fix painting of polypolygons

To do this, we introduce a new function in the backend, specialized
for polypolygons.

Unfortunately this also means that we had to disable the so called
"complex polygons" feature when the PolyPolygon action had version >= 2.
We were never really able to understand the ideas behind them and we
could not decipher the LibreOffice source code.

Anyway, now the Desktop Summit template shows correctly in Stage.

Diffs: 1, 2, 3, 4 Revision cf9dd1a...
Matus Uzak committed changes in [calligra] /words/msword-odf:

DOC: Put back an assert for table cell styles.

The assert was removed by:
commit 873b9867bb9ce5b4d4e59ff93258a44bb16a99ea

Let's keep the assert to detect broken files, which can't
be handled at the moment. The assert started to cause problems
because of changes of mine, which didn't consider covered table cells.

Matus Uzak committed changes in [calligra] /:

libmso: Added a separate custom-shape of type rectangle.

* The separate rectangle shape was required to make use of draw:mirror-vertical
and draw:mirror-horizontal, which are usable only with the draw:enhanced-geometry

* The existence of placeholder shapes in MS-PPT requires some rectangles
to be processed as text-boxes to make use of the presentation:placeholder

Lukáš Tvrdý committed changes in [calligra] filters/libmsooxml/MsooXmlCommonReaderDrawingMLImpl.h:

Fix the black border of the image

o make the pixels transparent

Sebastian Sauer committed changes in [calligra] tables/part/Doc.cpp:

Fix Calligratables crashes when importing just ANY document.
That's the same ugly workaround Words uses to update the option widgets :-/


David Faure committed changes in [k3b] /:

application/x-iso (kde3 naming) -> application/x-cd-image (shared-mime-info)

(detected by the kbuildsycoca4 warning that nobody reads)

Diffs: 1, 2, 3, 4 Revision 114a7af...
Sergey Ivanov committed changes in [amarok] /:

Made possible to empty numerical fields in TagDialog (track number, year, etc.).

FIXED-IN: 2.4.4

Sergey Ivanov committed changes in [amarok] src/dialogs/TagDialogBase.ui:

Disabled keyboard tracking for TagDialog's SpinBoxes to fix the bug with messed typing order (caused by right text alignment).

FIXED-IN: 2.4.4

Harald Sitter committed changes in [phonon/qml] declarative/mediaelement.cpp:

Introduce workaround to make dvd playback work.

Currently the MediaElement has QUrl as source property,
which of course fails for anything but actual urls.
Four options present themself here:
a) use QVariant so that a QML consumer can throw a url at us
AND a mediasource
b) introduce MRL support
c) provide two interfaces, one for url and one for mediasource
d) functions on mediaelement to expose advanced features (e.g. payDvd)

Andreas Hartmetz committed changes in [phonon-vlc] /:

Make audio output device selection work.

Currently it is broken due to a bug in libvlc that should be fixed soon.
We have to defer setting the output device until the player object
exists, which requires a somewhat ugly hack. That hack might break
if output devices are added or removed at the wrong time.

Diffs: 1, 2, 3 Revision ae853de...
Sergey Ivanov committed changes in [amarok] src/dialogs/TagDialog.cpp:

TagDialog's Open destination button now opens correct path instead of parent directory.

FIXED-IN: 2.4.4

Networking Tools

David Edmundson committed changes in [telepathy-chat-handler] lib/adium-theme-view.cpp:

Fix a bug in which emoticons can appear in URLs in messages, by swapping the order of processing

Reviewed by: David Edmundson

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Fix crash when creating connections with networkmanagement_configshell.
Thanks David Narvaez for this patch.

Lamarque Souza committed changes in [networkmanagement/nm09] backends/NetworkManager/nmdbussettingsconnectionprovider.cpp:

Since NM guys are being too slow to fix this bug I am adding this hack until
they fix it for good. Please try and see if it does not bring new bugs.

Lamarque Souza committed changes in [networkmanagement/nm09] backends/NetworkManager/nmdbussettingsconnectionprovider.cpp:

Since NM guys are being too slow to fix this bug I am adding this hack until
they fix it for good. Please try and see if it does not bring new bugs.

Christoph Feck committed changes in /trunk/KDE/kdenetwork/krdc/vnc/vncclientthread.cpp:

Keep eventQueue locked while dequeuing events

Urs, please post-review :)


Development Tools

Aleix Pol Gonzalez committed changes in [kdevplatform] /patchreview:

In case that we have Kompare installed, make it possible to export
our differences to Kompare.

Andi Fischer committed changes in /trunk/KDE/kdesdk/umbrello:

New code importing wizard allows to select one ore more files from different directories or a whole tree.
Also special file extensions can be entered for file selection.
Feedback of the import procedure is shown.

There is still some unfinished work and bugs, but that will be done in the next weeks.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 17 more) Revision 1244195


Guillaume Martres committed changes in [marble/socis-2011-sat-orbits] /:

New satellites plugin

This is the first draft of the Satellites plugin, using TLE data from

Daniel E. Moctezuma committed changes in [kiten/gsoc2011] /:

Deinflection system now fully recognizes between verbs and adjectives to show a more appropiate message to the user.

Diffs: 1, 2, 3, 4, 5, 6 Revision c032c0c...


Gilles Caulier committed changes in [digikam] digikam/main/digikam.desktop:

add camera type mime to handle digiKAm as camera interface unde Gnome

Alexander Potashev committed changes in [kipi-plugins] /:

Add first version of KIPI export plugin for VKontakte

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision f42b5c4...
Gilles Caulier committed changes in [digikam] /:

implement a cache of tumb/info for camera interface.
It work fine if you change icon view item sort method.
TODO : do not store item pixmap to icon view, but use pixmap cache instead.

Marcel, just take a look if all is fine for you about cache cost management. I have a doubt here...

Diffs: 1, 2, 3, 4, 5, 6 Revision cc64213...
Francesco Riosa committed changes in [digikam/sql/2.0] /:

Split of settings/migration for images/thumbs DB

This is the first step in really managing the Image metadata database
and the Thumbnail cache database as different entities.

Only changes in the gui are included and as is the code is not
functional, still need to be done:

1) change the structure of digikamrc and it's migration
2) define interaction between widgets in the new migration dialog
3) port and possibly unify "Settings -> database migration" with
"Settings -> configure digikam -> database settings"
4) add a "Backup" button

GUI: some new strings, work in progress

Gilles Caulier committed changes in [digikam] /cameragui:

new camera thumbnails controller.
This one manage thumb request from icon view and pass it to camera controller. It prevent duplicate request.
Source code from cameragui to get thumbs from KDEPreview kio slave take place here now. this simplify code to read.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 9a97515...

KDE Base

Kurt Hindenburg committed changes in [konsole] /:

Add shortcuts to jump to top & bottom of history.

The shortcut of jumping to top of history is for the request of #45950

The shortcut of jumping to bottom of history is added not only for
consistency, but also to be used for #38390, especially its comment #9
and #10.

Patch by Jekyll Wu

REVIEW: 102124

Timothy Pearson committed changes in /branches/trinity/kdelibs/kstyles:

Add Asteroid widget theme to kdelibs

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1244309
Vishesh Yadav committed changes in /branches/work/soc-kdesdk-dolphin-plugins-hg/dolphin-plugins/hg:

Changes -
* Force add/remove (to make Add/Remove work with files
with VersionState Added/Removed
* Rename dialog - Old name and text box aligned to left
* Removed line edit for StatusList (planned to make it
filter in future)
* Fixed a new born bug which made commit dialog crash
when a file is selected from StatusList to get its diff
* Changed label for Hg Init dialog
and some other dialogs
* Solved UTF problem in many dialogs.
* Fixed bug where \s character is pushed at front in
HgConfig, replacing space character
* Fixed SEGFAULT when Edit is clicked in Ignored Files
in Config Dialog
* Error message if changes not pulled succesfully and
information message when changes not available in
Push and PUll dialog

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 8 more) Revision 1244687
Timothy Pearson committed changes in /branches/trinity/kdebase:

Add initial support for Kicker "Deep Buttons", a more highly textured style than the normal "flat" Kicker GUI
Add preliminary GUI and configuration structures needed for hot-resizing panels

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 1244835
Erlend Hamberg committed changes in [kate] /:

added syntax highlighting for GNU LD scripts

Written by Lyle Putnam. Highlighting test included.

Kai Uwe Broulik committed changes in [kde-workspace] /effects:

Add option to make login effect fade via black instead of a long transition to your desktop.

Nuno has to decide whether the new option will become default or not, for now it is disabled by default.
You can enable it in effects kcm, now Login effect has a configuration dialog.

It does not (yet) however check for non-fullscreen effects, so they might look weird when this is enabled.

REVIEW: 101812

C +22 -17 kwin/effects/login/login_config.h [from: kwin/effects/login/login.h - 057% similarity] [License: GPL]

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 25e0a48...
Dominik Haumann committed changes in [kate] part/view/kateviewinternal.cpp:

make shift+enter work if shortcut for smart return is removed

Kurt Hindenburg committed changes in [konsole] src/TerminalDisplay.cpp:

Accept drag and drop event from non-KDE Filemanagers

Thunar uses 'text/uri-list' in its mimetype, but konsole only accept
d&d events whose mimetype contains 'text/plain'.

Patch by Jekyll Wu

REVIEW: 102176

Sebastian Trueg committed changes in [kde-runtime] /services/storage:

New and improved describeResources method.

The DataManagementModel's describeResources now uses flags instead of
the boolean parameter. The supported flags are
- ExcludeDiscardableData - does exactly what it says: it excludes all
data from discardable graphs.
- ExcludeRelatedResources - excludes related resources except sub-
resources. By default all related resources are returned with their
identifying properties. If this flag is set only sub-resources are

As mentioned before sub-resources are now always included. A sub-
resource is defined as being part of the super-resource and not making
any sense without it. Thus, excluding sub-resources is pointless.

The method also includes a third parameter: targetParties. This is not
implemented yet but will be used to specify the nao:Partys that the
data should be sent to. describeResources will then filter out data
that is not public to all of the parties.

Many situations are covered in the unit tests although probably not all.

One Virtuoso issue remains: all queries have to be executed for each
resource individually. I already asked on the Virtuoso mailing list[1]
about this issue. To me it seems like a bug.


Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 12 more) Revision 57f3963...
Kevin Kofler committed changes in [kdelibs] /:

Add an API (currently private) for installing missing Plasma engines.

Use it when a requested data or script engine is not found.

REVIEW: 102175

Diffs: 1, 2, 3, 4, 5 Revision 5bf9e0a...
Frank Reininghaus committed changes in [kde-baseapps] /src/kitemviews:

Underline the current item in KFileItemListView

It still looks a bit ugly, but at least we can see the current
item now :-) It is only updated by mouse clicks at the moment.

Diffs: 1, 2, 3, 4 Revision ec22f85...
Kurt Hindenburg committed changes in [konsole] /:

Add a checkbox to hide the size widget upon resizing window.

Re-add the KDE 3 option to show/hide the size widget when the window is

Patch is years old from Chali Ahmul M.P.U


Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b40a006...
Adrian Lungu committed changes in [kate] /:

Automatic folding (remember folding from last sesion) was implemented


Boudewijn Rempt committed changes in [calligra] /:

Change kformula from an application to a shape, like the chartshape

The application hasn't worked since circa 2006, so simplify everything
a lot and just make it a shape.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 17 more) Revision 5659fca...
Matus Uzak committed changes in [calligra] /words/msword-odf:

DOC: Updated processing of list styles.

* Preparing a text style based on the lists related information for the bullet/number,
which overrides text-properties applied to the list-item text (by either the text style
or the paragraph style). That one is referenced from the corresponding <text:list-level-style-*>

NOTE: OOo lacks support for such approach, they store the info into the <style:text-properties>
child element of the <text:list-level-style-*> element.

* Providing proper value for the text:list-tab-stop-position attribute of the <style:list-level-label-alignment>
element. TODO: There might be problems on complex test files (nested list, etc.).
NOTE: Added a number of test into kofficetests.


TODO: Several level inheritance of font-size from some of the built-in paragraph styles (styles.xml)
is not working properly for the bullet/number of lists items in the layout. For text of the list item
it's working fine. Have to discuss that on #calligra.

TODO: Positioning of list items is not working properly in the layout.

Both TODOs can be tested with attachments to

Stephane Mankowski committed changes in [skrooge/Feature] /:

: Possibility to display different accounts in different currency units
In "Account" page, a new attribute name "Amount entered" as been added to be able to see the amount of the account in his unit

Paul Mendez committed changes in [calligra] /:

Improve drag & drop and selection in Document Structure Docker

this patch include:
The following features for Document Structure Docker:
- Integration of +/- selection buttons
- Draw thumbnails of dragged pages
- Show context menu on dropping for copy/paste pages.
- Improve moving pages.
- Move KPrSelectionManager and KPrSelectionToggle classe to libs/widgets and rename to:
KoSelectionManager, KoSelectionToggle (these classes provide +/- selection buttons for QAbstracView classes).
- Selection of pages after move/copy on Custom Slide Shows View.

REVIEW: 102120

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision c84e329...
Bruno Ferreira committed changes in [calligra/krita-siox-bruno_moraix] /plugins/tools:

SIOX selection tool created.

Diffs: 1, 2, 3, 4, 5, 6 Revision fb8eaa3...
Sebastian Sauer committed changes in [calligra/libs-toc-sebsauer] /:

Work on ToC.
This lands following in the branch;
1) Be sure we always set the QTextBlock and always regenerate the toc
2 times at the beginning.This reintroduces the generate() during
layout-run logic which we indeed needto minimize the numbers of
relayouts needed. That reopens the original problemwe had with
headers that are above the toc may result in us dealing with
the wrong QTextBlock cause the position() changed then. Will
look how to solve thatin a better way.Also this still does not
fix the problem that thoseThe_Miscellaneous_Icons_And_Scroll_Bars.odt
produces wrong anchor-position resultscause of the toc's relayout.
But for that we probably need to repair the way how anchor
repositioning is done atm (to be more exact it's not done at all).
2) Proper right-align position the page-numbers.

Diffs: 1, 2, 3, 4 Revision 0e7be50...
Bruno Ferreira committed changes in [calligra/krita-siox-bruno_moraix] krita/plugins/tools/sioxselection/kis_tool_sioxselection.h:

Very first version for a color signature implementation.

It is a clusterization based on a modified kd-tree algorithm.

Dmitry Kazakov committed changes in [calligra/krita_strokes_framework_kazakov] /:

Added our own undo stack

The new stack doesn't start undo/redo if there is any processing
in progress. We might add block/unblock() calls to the stack, but
this will be very inefficient, due to the huge synchronization


Harald Sitter committed changes in [phonon-gstreamer/qml] /:

support rgb32 and yv12 all at once

A given format can be enforced by exporting PHONON_COLOR to either
yuv or rgb.

Mind that currently no painter has implementations for yuv.

Harald Sitter committed changes in [phonon/qml] phonon/graphicsview/glslpainter.cpp:

GSLS YV12 support, shader from nokia

colors are still broken, not quite sure why, could be inverted UV
as the shader usually expects inversion by shuffling the texture
order around, not sure I like that

Trever Fischer committed changes in [phonon-gstreamer] /:

Add multichannel support to AudioDataOutput

Thanks for the patch, Alessandro!
Signed-off-by: Trever Fischer

Sven Krohlas committed changes in [amarok] /:

Current track applet: show number of artists instead of genres

There are not many genres. ;-) So the number of artists is a much better
way to express some statistics about the collection.


Networking Tools

Urs Wolfer committed changes in /trunk/KDE/kdenetwork/krdc/mainwindow.cpp:

Make tabs movable.


Andrea Diamantini committed changes in [rekonq] /:

Tools Action Menu

- Removed showDeveloperTools action
- Moved adblock GUI to adblock part
- renamed toolsMenu and developerMenu to reflect their real/new roles
- Added UserAgent action to the tools menu


REVIEWED-BY: fritz_van_tom

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 309cd39...
Ilia Kats committed changes in [networkmanagement/nm09] /:

let the user decide if he wants to store his 802.1x passwords or type them
in every time, add real auth dialogs for 802.1x and wireless (needed for

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 24 more) Revision a209f30...


Eike Hein committed changes in [yakuake/feature-activity-and-silence-mon] /:

Add version checks for 4.7.1 for activity/silence monitoring.

I can't begin to tell you how much I wanted to make this a runtime
check instead of build time, but it would have meant non-working
entries in "Configure Notifications" and non-working API on D-Bus.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 942e500...
Eike Hein committed changes in [yakuake] /:

Add a "Configure Notifcations" dialog.

The startup notification popup configuration has moved there. I've
incluced a kconf_update script to migrate an existing user setting.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision eb1e948...
Friedrich Karl Tilman Pülz committed changes in [publictransport/NewJourneySearchParser] /:

Updated journey search analyzers with better autocompletion/correction

- Only add spaces into the output string after a syntax item,
if there was a space in the input string, too. This way, the correction doesn't
get in the way too much. Stored in Lexem.
- Turn struct JourneySearchAnalyzer::Results into an own class
- New function Results::updatedOutputString, which returns an output string with
updated item values and/or added/removed items by type. Used to update the stop
- Calculate cursor position/selection changes on input corrections in the analyzers.
The cursor position can be set on each analyzer and it returns the cursor offset
and selection length to set.
- Add a lookahead iterator, which is always one item after the default iterator.
Maybe this should be removed again?
- Rename SyntacticalAnalyzer::parseX functions to matchX, as they are called to
match something - The parsing happens by calling the right matchX functions.
- These renamed matchX functions now all return true only if they have matched and
move the iterator after the matched item(s).
If they return false, the iterators remain unchanged/get restored.
- New function SyntacticalAnalyzer::matchNumber to match a number in a given range
with good corrections
- Use SyntacticalAnalyzer::matchKeywordInList function also to match prefix keywords
- matchKewordInList now also matches beginnings of keyword, if the cursor position
is after the keyword part (as it is typed in so far). The keyword then gets
completed with the completed part selected.
- Update JourneySearchParserTest, insert into tests/CMakeLists.txt

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision ba2b943...
Friedrich Karl Tilman Pülz committed changes in [publictransport/NewJourneySearchParser] /:

New journey search string parser

- The old code was redundant and not easy to read
- There are now three analyzer steps: Lexically, syntactically and
contextually (checking keyword order and other input errors).
- One class JourneySearchAnalyzer, that uses these three analyzers to
parse an input string and update the cursor position if there are
new items inserted (correction) before the current cursor position
- Not ready yet: Completion for the "at" keyword works, for "in" it has
to be implemented. Some other mistakes like double quotation marks
after clicking on a stop suggestion. Another TODO are more/better
- The new parser should be quite performant (optimized with help of KCachegrind)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 734a081...


Michael Gapczynski committed changes in [owncloud/sharing] /files_sharing:

New implementation of share dialog

Diffs: 1, 2, 3 Revision 0d79560...



Dennis Nienhüser committed changes in [marble] /lib:

Speedup route rendering during panning/zooming.

Don't cache the route region (needed for mouse hover) while panning/
zooming where it's not really needed. Calculating the route region
is the most time consuming operation in route painting.

Diffs: 1, 2, 3 Revision a2c5513...

KDE Base

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Improve performance for creating previews

The overall time for creating previews is faster the more items
are passed to KIO::previewJob() in parallel instead of passing
e.g. only 100 items once and start several KIO::previewJobs

However in the worst case KIO::previewJob() might
block the application for several seconds if the
MIME-type of the passed KFileItems are unknown and e.g. 10000 items
are forwarded.

So KFileItemModelRolesUpdater will now take care to resolve as many
MIME-types as possible until a timeout is reached and will only pass
those items to KIO::previewJob().

For huge image folders, where the MIME-type can be determined very
fast, this means that the overall time for creating previews will
decrease without blocking the application. For "worst case" directories
where resolving the MIME-type can get very expensive this approach
assures no blocking of the user-interface although the overall time
until all previews are generated might slightly increase.


Laszlo Papp committed changes in [gluon] core/gluonobject.cpp:

Fix the type(value) regexp parser in the setPropertyFromString method

It now performs better and hs less extraneous information.
Also, the way it was before would also accept (foo).


Development Tools

Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize/src:

explain why tm is not working in case no qsqlite plugin is present in the system.
thanks to Marta Rybczynska for pointing me to the problem

also dont show PostreSQL option if the corresponding plugin is not there

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1245238


Gilles Caulier committed changes in [digikam/gsoc/clone] /dimg/filters/clone:

add copy CloneBrush constructor to be able to use it with QMap.
use more private internal container.
Huge fixes in CloneSettings to be able to compile it as well. It miss some FIXME to check.
Polish Polish and polish again.

Why CloneContainer store brushDia and mainDia ? It store already CloneBrush which has already dia value. What's the difference between brushDia and mainDIa ?

How are you tested this implmentation ? It doesn't compile as well ? Strange...

Diffs: 1, 2, 3, 4, 5 Revision 4678b4a...

KDE Base

Kurt Hindenburg committed changes in [konsole] src/ViewManager.cpp:

New tabs will be placed to the right of the current tab.

Currently new tabs are placed at the end which is not very convenient.

Patch by Jekyll Wu


Artem Serebriyskiy committed changes in [nepomuk-web-extractor/smoke] /:

Initial preparations for SMOKE library generation

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision afd49c9...
Aaron J. Seigo committed changes in [kdelibs] kdeui/notifications/kstatusnotifieritem.cpp:

only notify the dbus object when actual changes happen

this prevents a TON of spamming of the system tray from happening with certain applications

Martin Gräßlin committed changes in [kde-workspace] kwin/effects/CMakeLists.txt:

All effects need to link X11

The Plasma Active build of kwin was broken because of that.
We really should get the effects X free...

David Faure committed changes in [kdelibs] kdecore/sonnet/globals.cpp:

Add TODO for someone who would have time to make things faster

Kurt Hindenburg committed changes in [konsole] src/Profile.cpp:

Change the default LocalTabTitleFormat to use %D instead of %d

%d will shorten the directory name whereas %D will not. For some
users, having %d as the default is confusing as they don't understand
why some directories are not displaying correctly in the tab text.
Currently there is no UI to examine or change which folder names will be


Robert Mathias Marmorstein committed changes in [koffice] plugins/textshape/Layout.cpp:

Make erasing iterator-safe in textshape layout.

This may or may not be causing problems now, but it doesn't
hurt to do it right.

Dmitry Kazakov committed changes in [calligra/krita_strokes_framework_kazakov] libs/kundo2/kundo2stack.h:

Made KUndo2Stack polymorphic.

Well, now we need to explain this to Nokia.


Harald Sitter committed changes in [phonon-gstreamer/qml] gstreamer/videographicsobject.cpp:

fix bad code copies, so that tdfischer has less reason to shout at me

Networking Tools

Ilia Kats committed changes in [networkmanagement/nm09] /:

Don't copy certificates for 802-1x connections to our own storage.

I've thought a lot about this, and while this was a very cool feature
for NM 0.8, where we had our own little connection list that only we
could access, this doesn't fit into NM 0.9 anymore. As soon as the
connection gets modified/deleted by something other than ourselves, be
it nm-applet or the sysadmin editing the files in
/etc/NetworkManager/system-connections by hand, we get problems, like
deleted/missing certificates or obsolete certificates still floating

Everything still works, tested with WPA2-EAP-PEAP and WPA2-EAP-TTLS

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 11 more) Revision db3bb8a...
Andrea Diamantini committed changes in [rekonq] src/webview.cpp:

Revert vi-like shortcuts implementation

In fact, until we have one way to understand if a widget (eg: a
lineedit or a textarea) steals the focus before, this feature will
break their usage.

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Set Connections entry in networkmanagementrc file to empty after
importing NM-0.8 connections. The old files are still instact in
case someone needs to redo the importing process.


Rolf Eike Beer committed changes in /trunk/KDE/kdeutils/kgpg:

move "revoke key" from context menu to key menu

The context menu is already cluttered enough and this is used so seldomly that
even I did not know of the existence of this action.


Laszlo Papp committed changes in [gluon] /:

Add the KDE, KDE Ext, Plasmoid and Touch players to the Windows Installer pack

Diffs: 1, 2, 3, 4, 5, 6 Revision f0f262e...
Laszlo Papp committed changes in [gluon] core/directoryprovider.cpp:

Add the proper Windows Registry Entry in case of 64 bit architecture

It makes possible to get the proper install prefix path in case of 64 bit
architecture meaning that, for instance the games will be properly listed inside
the gluon_qtplayer, but it also takes effect on any codebase that uses the
relevant methods from the directoryprovider class.


Jan-Christoph Borchardt committed changes in [owncloud] /:

removed log feature because it is a privacy issue

Diffs: 1, 2, 3 Revision e79c827...