Revision 4022057...

Go back to digest for 4th September 2011

Other in Educational

Bernhard Beschow committed changes in [marble] /lib:

HttpDownloadManager: neither take ownership of nor expose StoragePolicy

The StoragePolicy is accessed outside of HttpDownloadManager, where methods are accessed that are only available in subclasses.
Since it was unsafe to keep a pointer to the concrete StoragePolicy around, downcasts from HttpManager's storagePolicy() were needed to access these methods.

By not having HttpDownloadManager take ownership, it is now safe to keep a concrete object of StoragePolicy around.
As a result, casts are unnecessary.

File Changes

Modified 4 files
  • /lib
  •   src/AbstractDataPluginModel.cpp
  •   src/HttpDownloadManager.cpp
  •   src/HttpDownloadManager.h
  •   src/MarbleModel.cpp
4 files changed in total