Issue 203

2nd October 2011 by KDE Commit-Digest Team

Contributors

Gaël Beaudoin
Vladislav Blanton

This Week...

Group By Time feature available in Digikam. Calligra gets Web Report Element and incremental backup in Krita. Introduction of the KSecret tool. Optimizations in KDE-Base. Bugfixes in in password saving and HTTP authentication caching in KDE-Libs, KDE-PIM, Network Management, Kile and others.

Statistics

Commits 2566 by 191 developers
Open Bugs 23155
Open Wishes 17263
Bugs Opened 400 in the last 7 days
Bugs Closed 518 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
188
 
/branches/stable
124
 
/trunk/l10n-support
39
 
/trunk/www
27
 
/trunk/KDE
25
 
/libs/textlayout
18
 
/plugins/stardict
18
 
/src/lib
14
 
/trunk/playground
13
 
/branches/work
11
 
Files Developer Commits
246
 
Laurent Montel
84
 
225
 
Marco Martin
84
 
129
 
Aleix Pol Gonzalez
46
 
129
 
Laszlo Papp
43
 
126
 
Michael Georg Hansen
42
 
108
 
Cornelius Schumacher
38
 
111
 
C. Boemann
38
 
105
 
Burkhard Lück
35
 
102
 
Jekyll Wu
34
 
90
 
Daniele E. Domenichelli
30
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
99%
 
Spanish (es)
95%
 
Polish (pl)
94%
 
Dutch (nl)
94%
 
German (de)
93%
 
Estonian (et)
93%
 
Low Saxon (nds)
90%
 
Italian (it)
90%
 

Bug Killers

Person Bugs Closed
Andreas Beckermann
121
 
Darío Andrés
43
 
Dario Freddi
42
 
trueg kde org
36
 
Christophe Giboudeaux
36
 
C. Boemann
21
 
Klaus Staerk
19
 
Myriam Schweingruber
18
 
Christoph Feck
16
 
Jekyll Wu
13
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

     

Educational

[]     

Graphics

  []    

KDE Base

[] [] []   []

KDE-PIM

[] [] []   

Office

[] []    

Konqueror

     

Multimedia

[]     

Networking Tools

[] []    

User Interface

     

Utilities

[] []    

Games

     

Other

   []   

There are 74 selections this week

Bug Fixes

Educational

Dennis Nienhüser committed changes in [marble] src/plugins/positionprovider/filereader/FileReaderPositionProviderPlugin.cpp:
Aleix Pol Gonzalez committed changes in [kalgebra] /:

Add a function to generate the graph of all the loaded functions

KDE Base

Dario Freddi committed changes in [kde-workspace] /:

Move handling of the OSD widget from the applet to the daemon. This also allow us to control it properly

Sebastian Trueg committed changes in [nepomuk-core] libnepomukcore/query/querybuilderdata_p.h:

Convert search excerpt method input to utf8.

Virtuoso's bif:search_excerpt does not understand unicode character,
thus the input has to be converted to utf8.
Hopefully this will be done automatically in a future version of
Virtuoso.

Ralf Jung committed changes in [kde-workspace] kcontrol/standard_actions/standard_actions_module.cpp:

standard shortcuts KCM: Hide 'Global' column, and give the shortcut group a name


REVIEW: 102709
FIXED-IN: 4.8

Dario Freddi committed changes in [kde-workspace] powerdevil/daemon/powerdevilcore.cpp:

Move the activity simulation AFTER removing idle timeouts. Otherwise, timeouts might be
triggered out when the actions are still being unloaded, and hence still listening to them.

Thomas Lübking committed changes in [kde-workspace] kwin/scene_xrender.cpp:

fix xrender scale+shadowed toplevel geometry
(cherry picked from commit 01ea7ad7f2a97924f4b6ee41adde01eef27b6e8b)

REVIEW: 102703
FIXED-IN: 4.7.3

Dario Freddi committed changes in [kde-workspace] powerdevil/daemon/backends/upower/backlight_helper_actions.actions:

The system should always be able to fetch brightness. For this reason, allow
this action to be performed even on inactive consoles - after all, it's anything
but harmful.

Note this depends on KAuth's 96cafc57a6f2faf3c18f087b15d72aca56bd4895 in KDE 4.7
to work properly.


FIXED-IN: 4.7.2

Michael Pyne committed changes in [kdelibs/frameworks] kdeui/widgets/kcharselect.cpp:

kcharselect: Improved precondition checking.

Apparently bug 235020 (crash in KCharSelect) is still around even in
kdelibs 4.7.0.

Harald Sitter had noted in comment 46 to that bug that the QModelIndex
should be checked before it is used, and the int type of pos means it
could overflow to be negative. Neither condition is checked for yet, so
check for them now.

Hopefully we really fix bug 235020 (or at least reduce severity away
from being a crasher).

This commit is for what will become kdelibs 5.

.

Dario Freddi committed changes in [kde-workspace] /daemon:

Removing Disable Desktop Effects in 4.8.

Besides the fact this feature has never worked correctly, Martin confirmed it is
no longer useful, but instead harmful, for how compositing is handled in 4.8+.

Dario Freddi committed changes in [kde-workspace] /daemon:

Handle timeout resets in a 2-stage way

Thomas Lübking committed changes in [kde-workspace] kwin/workspace.cpp:
Christoph Feck committed changes in [kdelibs/KDE/4.7] kdeui/itemviews/kwidgetitemdelegate.cpp:

Fix crash when no model has been set (yet)

In the case a view is shown before its model has been set,
QAbstractItemView internally uses an "empty" model. Instead of
connecting to the empty model, we check for the null pointer.


FIXED-IN: 4.7.2

Sebastian Trueg committed changes in [kde-runtime] /services/storage:

Make sure all commands are finished before shutting down.

This fixes a potential crash when the DMS model is deleted while
another thread is still working on some command.

Albert Astals Cid committed changes in [kde-runtime] khelpcenter/toc.cpp:

Fix first sect link not working


FIXED-IN: 4.7.2
David any reason why you took this out?

(cherry picked from commit 8b000b91c928cae3cb5169826dc98611ae80f10e)

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] /http:

Make sure HTTP authentication is properly cached in persistent storage whenever
the user has checked the 'Remember password' checkbox in the password dialog.

This commit correctly addresses the issue reported in
https://git.reviewboard.kde.org/r/102729/.

Diffs: 1, 2, 3 Revision c0cb2f6...
Aaron J. Seigo committed changes in [kde-workspace] kmenuedit/basictab.cpp:

fix "only show in KDE" toggling

patch by Ralf Jung
REVIEW:102713

Dawit Alemayehu committed changes in [kde-baseapps] konqueror/settings/kio/kcookiespolicies.cpp:

Sort the cookie policy list box in ascending order.


FIXED-IN: 4.7.2

David Faure committed changes in [kdelibs/KDE/4.7] kioslave/http/http.cpp:

Use HTML escaping on texts that come from the website

Interestingly enough, this is yet another use case for moving Qt::escape
to QtCore, which I made a merge request for.

KDE-PIM

Laurent Montel committed changes in [kdepimlibs] kmime/kmime_content.cpp:

Fix Bug 279809 - KMail2 crash on viewing mail in gb2312 encoding, edit to UTF-8 fixes it

Patch from Axel Gonzalez tested by Oliver
The code is borrowed from Content::fromUnicodeString().
FIXED-IN:4.7.2

Laurent Montel committed changes in [kdepim] mailcommon/kmfilterdialog.cpp:

Bug 145985 - Ordering filter list by drag-and-drop

FIXED-IN: 4.7.2

Dan Vratil committed changes in [akonadi-google] /:

Wait for all events to be fetched before calling itemsRetrieved() (fixes bug#282509)

Items in Calendar resource are queued in a list until GAM emits
requestFinished() signal (when last page of feed is retrieved) and
then commits the whole list at once (using itemsRetrieved() or
itemsRetrievedIncremental()).

If this appears to work as expected, it should be implemented in other
resources as well to prevent crashes like in bug #282509 and #282799.

Diffs: 1, 2, 3, 4, 5 Revision bff6460...
Andras Mantia committed changes in [kdepimlibs] akonadi/pastehelper.cpp:
Laurent Montel committed changes in [kdepim] /:

Bug 232910 - Move to top/bottom buttons for filters

FIXED-IN: 4.8

Laurent Montel committed changes in [kdepim] messagecomposer/akonadisender.cpp:

Fix Bug 282954 - Activating Manual Filter which forwards mail crashes kmail2

FIXED-IN: 4.7.2

Laurent Montel committed changes in [kdepim] /ksieveui:

Fix Bug 280568 - Kontact/KMail crashes when closing the Sieve dialog

When we call kill() we send a signal result() and result remove job in mJobs
=> list of mJobs is not good after that.
So when we close dialog we disconnect signal before to call kill and mJobs is clear at the end of function

FIXED-IN: 4.7.2

Dan Vratil committed changes in [akonadi-google] libkgoogle/services/calendar.cpp:

Fix creating events in Google calendar (bug #282705)

"when" field in event JSON data must be a list, not a field, otherwise
Google won't accept it and automatically sets event start to current time.

Allen Winter committed changes in [kdepimlibs] /:

Fixes contributed by the MeeGo project:
- With UTF8 enconding it is decoding wrongly.
- Also some recurrence rule properties are missing.
Thanks for the patch Alvaro
REVIEW: 102731

Office

Sebastian Sauer committed changes in [calligra] /kotext/opendocument:

Fix copying text within a table or list duplicates whole table or list instead of the text

Dan Leinir Turthra Jensen committed changes in [calligra] libs/main/rdf/KoDocumentRdf.cpp:

Use deleteLater on QObjects - you never know who's listening ;)

This fixes some crashes in the converter tool, and hopefully also
in some instances for people who seem to run into similar instances
elsewhere (see referenced bug reports)

Robby Stephenson committed changes in [tellico] /collections:

Differentiate bibliographic volume from file catalog volume with i18nc

Boudewijn Rempt committed changes in [calligra] /plugins/formats/psd:

Make loading multi-layer psd files work

Patch mostly by Siddharth.

Todo: grayscale, lab, cmyk. Test the 16 bit implementation. However, for
now this is already quite useful

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision f06705e...
Jarosław Staniek committed changes in [calligra] /main:

GUI: Main Window: Added "Import, Export or Send" menu item and assistant

*Rearranged Kexi menu items for usability
*Settings menu item disabled for now

DIGEST: Added "Import, Export or Send" menu item and assistant for Kexi

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision f667ec9...
Jarosław Staniek committed changes in [calligra] /main:

GUI: Main Window: "Open Recent" page becomes more generic "Welcome" page

DIGEST: In Kexi, "Open Recent" page becomes more generic "Welcome" page

Diffs: 1, 2, 3, 4 Revision a13c40c...

Multimedia

Soren Harward committed changes in [amarok] /:

Overhaul of Automated Playlist Generator algorithm

Completely rewrote the ConstraintSolver to use a genetic algorithm
rather than simulated annealing. This trades off some speed for a vast
reduction in the amount of code needed to write individual constraints,
and makes the whole component less prone to crashing.

Networking Tools

Mehrdad Momeny committed changes in [choqok] choqok/systrayicon.cpp:

Hide Choqok icon from systray, when there's no new dent

Alex Fiestas committed changes in /trunk/KDE/kdenetwork/kopete/kopete/systemtray.cpp:

Only show kopete in systray if something is happening

As far as I know kopete has no maintainer and since this
is how all KDE applications should behave at least when
running in our workspace I'm feeling confident enough to
do the commit without reviewboard.

Please, if I'm wrong revert the commit and I will send
the patch to reviewboard.

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Hide wifi shared connections and <hidden network> item if wireless is
disabled.

Andrea Diamantini committed changes in [rekonq] src/mainview.cpp:

Remove a minor focus glitch on webpage load

It happened when loading a favorite page via shortcut.
It is fixed now :)

REVIEW: 102695
REVIEWED-BY: adjam

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Limit connection's name to 20 characters when exibiting them in
connection list.


FIXED-IN: nm09

Andrea Diamantini committed changes in [rekonq] /:

Fix KGet "list all links" feature

the contextual menu action was not working cause of a wrong
signal/slot connection.
This commit fixes it :)

REVIEW: 102708
REVIEWED-BY: adjam

Diffs: 1, 2, 3 Revision 7055c0b...
Mehrdad Momeny committed changes in [choqok] /:

Show in reply to @USERNAME for statuses, because of new change in statusnet that doesn't add the @reply to dents :/
Also sending User to conversation page on web

Diffs: 1, 2, 3, 4, 5, 6 Revision dea3158...
Eli MacKenzie committed changes in [konversation] /:

Changed method of remember/marker line tracking.

Qt 4.7.4 introduces a change to the handling of
QTextBlock::userState that makes it unusable for the purposes of
tracking which block represents a marker or remember line. Previous
versions of Qt also changed or otherwise corrupted the userState
value causing the loss of synchronization with the data held in the
IRCView itself. Blocks are now tracked via the userData field, which
was unmolested in the change made to QTextDocument.

Warning: this commit introduces a large volume of debugging output.

For more information about the Qt change, see QTBUG-20916.

Daniele E. Domenichelli committed changes in [telepathy-filetransfer-handler] /:

Handle other states in incoming file transfer

Also set better notification messages.
This commit plus the previous commits make the notifications
acceptables, therefore I'm closing bug #282710 (better notifications)

Daniele E. Domenichelli committed changes in [telepathy-kded-module] /:

Restyling of the ui + new settings

* Download directory for file transfers
* Auto accept file transfers
* Now playing text (disabled)

Reviewed-by: Martin Klapetek

David Edmundson committed changes in [telepathy-text-ui] config/appearance-config.cpp:
Ilia Kats committed changes in [networkmanagement/nm09] /:

Improve connection sorting

Previously, sorting was done by the plasmoid in a very simple way. newly
added activatables were not being sorted at all. But since we already
have a sorted list on the session bus which resorts every time an activatable
is added, we can just use that.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision 53c55be...

Utilities

Michel Ludwig committed changes in [kile/livepreview] /:

Avoid crashes due to an event loop being executed while code in some tool class is running

It must be ensured that no event loop is started whenever some tool operation is running. This
includes running code inside the tool classes!

The reason for that is that an event loop might trigger the deletion a tool object for which code
is currently executed, for instance with the 'stopLivePreview' method.
An event loop is executed, for example, within the 'documentSave' method of KatePart. Although the event
loop doesn't process user events, the document modification timer might still be triggered in such
an event loop and 'stopLivePreview' will be called. Now, no document saving is performed inside tool
classes anymore (including the tool manager).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 9dddf52...
Michel Ludwig committed changes in [kile/livepreview] /:

Avoid crashes due to accessing 'm_previewStatusLed' when it has been deleted already

Aaron J. Seigo committed changes in [ksnapshot] /:

move the timeout helper when the mouse moves into it

also moves the initial position of the timer into the middle of the screen and properly centers the text

based on a patch by Jignesh Kakadiya

Raphael Kubo da Costa committed changes in [ark] /:

Kill process when no cancel option exists for a cli tool.

Some cli programs (such as zipinfo) do not have an option to cancel the
extraction when a file already exists. In this case, we resorted to
autoskipping, which is not really the same thing.

When a program does not have the cancel option, we now resort to closing
it manually.

Patch by Theofilos Intzoglou, thanks a lot!

REVIEW: 102702
(cherry picked from commit 2320fa06276ac48038bd1f9c7349fc04c68a738c)

Features

Graphics

Albert Astals Cid committed changes in [okular] /:

Added configuration setting for default zoom


FIXED-IN: 4.8.0
REVIEW: 102491

Petri Damstén committed changes in [digikam] /:

Group By Time feature

Petri Damstén committed changes in [kipi-plugins] printimages/wizard/wizard.cpp:

Center portrait images

KDE Base

Sebastian Kügler committed changes in [plasma-mobile] /webbrowser/src:

Page loading error handling

Displays an HTML page showing the network error.

Kindly borrowed from Rekong / Arora.

Peter Penz committed changes in [kde-baseapps] /src:

Implement smooth-scrolling for horizontal and vertical scrollbars

Currently only a smoothscrolling was provided into the
scroll-direction, but not in case of the details-view where a
horizontal scrollbar might be shown too.

Some minor adjustments of the private KItemListSmoothScroller interface
will be done later...

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision acd03f4...
Jekyll Wu committed changes in [konsole] /:

Allow users to control where the newly created tab should be placed.


REVIEW:102685

KDE-PIM

Thorsten Staerk committed changes in [kdepim] /:

Allow adding a description to a task.

Office

Jarosław Staniek committed changes in [calligra] kexi/main/startup/KexiRecentProjectsModel.cpp:

Startup: Improve info for recent entries
*text now skips filename if there is caption for file-based entries
*tooltips show server type or full filename path

José Luis Vergara committed changes in [calligra] /:

Add Save Incremental Backup to Krita.

o Works by saving a backup preceded by ~ at the same time it saves the current file.
o Good for multiapplication workflow.
o Debated during the Krita Sprint, so it fits under the category "previously discussed new features".

Diffs: 1, 2, 3 Revision 66a6163...
Jarosław Staniek committed changes in [calligra] /reporting:

Web Report Element by Shreya Pandit, fixed all issues noted in review
Also cleaned up code using astyle

REVIEW:102046

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 0ce7fe0...
Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney:

Added capability to select the payee source when importing OFX files. More information can be found on https://svn.reviewboard.kde.org/r/6777/


REVIEW: 6777
GUI:

Networking Tools

Matthias Fuchs committed changes in /trunk/KDE/kdenetwork/kget:

Adds KSelectAction for after download finished actions.

This KSelectAction is hidden by default but can be added to
the toolbar manually. Making it possible to choose an after
download finished action without navigating to the corresponding
settings.

Daniele E. Domenichelli committed changes in [telepathy-filetransfer-handler] /:

Make FileTransferJobs killable

Daniele E. Domenichelli committed changes in [telepathy-filetransfer-handler] /:

Show a progressbar for the file transferred

Utilities

Valentin Rusu committed changes in [ksecretservice] /:

Introducing ksecrets tool

This tool will be handy for manipulating KSecretsService collections
and secrets

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1266059...
Raphael Kubo da Costa committed changes in [ark] /:

Add support for LHA archives.

This introduces a run-time dependency on the lha utility, available in

Optimization

KDE Base

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Details view: Improve performance when expanding items

Prevent unnecessary calls to visibleRolesSizes() when
expanding items. Also the performance has been improved when
resizing the window.

Diffs: 1, 2, 3, 4 Revision 4384ba7...
Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Details view: Improve performance

When inserting items or when updating the item-roles there is no
need to recalculate the column-widths for all items to get an
optimized column-width.

Diffs: 1, 2, 3, 4 Revision 479739a...

KDE-PIM

Laurent Montel committed changes in [kdepim] /core:

optimization: const'ify, use isEmpty(), use 'if(...) else if(...) etc. Clean up code

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 752798a...

Other

Jos van den Oever committed changes in [libstreams] include/strigi/streambuffer.h:

Fix bug where parsing a pdf is slow.
The problem was caused by a the StreamBuffer that was increased with only one byte in a loop. The fix is to increase the buffer size in more reasonable steps.

Jos van den Oever committed changes in [libstreams] lib/skippingfileinputstream.cpp:

Increase the buffer size in larger steps.
This drastically improves performance.

Jos van den Oever committed changes in [libstreams] lib/skippingfileinputstream.cpp:

Fix bug where a buffer of size 1 was used.
The small buffer size cause slow analysis.

Other

KDE Base

Luboš Luňák committed changes in [kde-workspace] /:

gee, is this come-up-with-the-most-useless-variable-name competition or what?

And they are both pointless anyway, simplify code.