Issue 204

9th October 2011 by KDE Commit-Digest Team

Contributors

Gaël Beaudoin
Vladislav Blanton
Marta Rybczynska
Alexander van Loon
Shafqat Bhuiyan
Marco Krohn
Jaka Kranjc

This Week...

New features in KMail: renaming attachments, disabling filters. Telepathy gets KWallet support for passwords, integration of global presence into kded-modue. Rewritten array classes in Okteta. Improved reliability of session closing in Konsole. Fix of broken root certificates in KDELibs KSSL. First version of a QML screen locker using KGreeter. Bug fixes in KTorrent, digikam, BlueDevil, Calligra.

Statistics

Commits 2396 by 178 developers
Open Bugs 23237
Open Wishes 17278
Bugs Opened 422 in the last 7 days
Bugs Closed 378 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
165
 
/branches/stable
101
 
/trunk/www
45
 
/plugins/stardict
33
 
/trunk/l10n-support
29
 
/trunk/KDE
26
 
/branches/trinity
22
 
/trunk/playground
19
 
/trunk/extragear
18
 
/branches/work
16
 
Files Developer Commits
312
 
Laurent Montel
105
 
204
 
Laszlo Papp
68
 
144
 
Sebastian Kügler
55
 
138
 
Allen Winter
49
 
129
 
Aleix Pol Gonzalez
44
 
99
 
Hugo Pereira Da Costa
38
 
69
 
Alex Fiestas
33
 
90
 
Burkhard Lück
30
 
78
 
Marco Martin
29
 
78
 
Sairan Kikkarin
26
 

Internationalization (i18n) Status

Language Percentage Complete
Brazilian Portuguese (pt_BR)
99%
 
Portuguese (pt)
99%
 
Swedish (sv)
99%
 
Dutch (nl)
94%
 
Spanish (es)
94%
 
Estonian (et)
93%
 
German (de)
93%
 
Polish (pl)
93%
 
French (fr)
90%
 
Low Saxon (nds)
90%
 

Bug Killers

Person Bugs Closed
Christoph Feck
49
 
Alex Fiestas
42
 
Christophe Giboudeaux
15
 
Jekyll Wu
15
 
Boudewijn Rempt
13
 
Myriam Schweingruber
13
 
javier opensuse org
12
 
trueg kde org
12
 
Marcel Wiesweg
10
 
Joris Guisson
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]   []   

Educational

     

Graphics

[]     

KDE Base

[] [] []   

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

     

Networking Tools

[] []    

User Interface

[] []    

Utilities

  []    

Games

[]   []   

Other

  [] []   

There are 68 selections this week

Bug Fixes

Development Tools

Sebastian Trueg committed changes in [nepomuk-core] libnepomukcore/query/querybuilderdata_p.h:

Now a "real" hacky "fix" for the problem with wide characters in queries.

My last "fix" just used bif:charset_recode on the search terms. This,
however is no real solution as it makes the query fail if the terms
do not contain any wide character. Thus, the problem was simply
inverted.
How I do it the brute-force way: I simply truncate the terms at the
first wide char and use the rest. The search excerpts have the same
quality as with the bif:charset_recode hack but it works for wide and
non-wide terms.

Milian Wolff committed changes in [kdevplatform] /:

Fix opening of tabs when using buddy documents and split views


REVIEW: 102806

Graphics

Marcel Wiesweg committed changes in [digikam] /:

Fix two typos which broke pick labels assigning, display and sometimes crashed

Marcel Wiesweg committed changes in [digikam] /:

Honour "Save As New Version" when prompting user for save options on image editor closing

Albert Astals Cid committed changes in [okular] generators/dvi/dviRenderer_prescan.cpp:

Fix creation of the TOC tree for dvi files

The old code assumed the number of children would be
"-NUMBER "
while this file has
"-NUMBER/"
so what we do now is looping after the - until we find a non digit
All this code would better be done using a regexp and not that many section calls
but i did not want to touch it more than needed

FIXED-IN: 4.7.3
(cherry picked from commit 83df127ac057d98e6e4f67e07074675c8830198a)

Benjamin Girault committed changes in [kipi-plugins] panorama/manager/actionthread.cpp:

Panorama: bugfix

Extra test for an empty string.

Marcel Wiesweg committed changes in [digikam] /:
Marcel Wiesweg committed changes in [digikam] /:

Rewrite of the ImageInfoCache infrastructure with fixed crashes and better granularity

- apply save atomic operations and drop ImageInfoDatas from the cache if ref count is 0
- remove dependency on the big database lock, use a finer grained readwritelock for ImageInfo
- cache image infos by name as well, used for thumbnail info retrieval
- rewrite the getter methods in ImageInfo for the ReadWriteLock

Gilles Caulier committed changes in [digikam] utilities/cameragui/views/cameraiconview.cpp:
Marcel Wiesweg committed changes in [digikam] /:

When creating or moving a tag under the person parent tag, make it a person tag

KDE Base

Jekyll Wu committed changes in [konsole] src/SessionManager.cpp:

Always read/write the 'DefaultProfile' entry from/into 'konsolerc'.

That means the default profile is shared among konsole and all host
apps of konsole kpart. That is not ideal enough, but much better than
current inconsistent read/write for the 'DefaultProfile' entry.


FIXED-IN: 4.8

Alex Fiestas committed changes in [bluedevil/1.1] src/daemon/helpers/filereceiver/openobex/filetransferjob.cpp:

Do not report unstranslatable technical errors




FIXED-IN: 1.0.6
FIXED-IN: 1.1.3
FIXED-IN: 1.2.2

Aaron J. Seigo committed changes in [kde-workspace] plasma/generic/wallpapers/image/backgrounddelegate.cpp:

fix the problem that the text below the selected wallpaper is barely readable if the window is inactive

REVIEW:102772

Jekyll Wu committed changes in [konsole] /:
Sebastian Trueg committed changes in [kde-runtime/KDE/4.7] nepomuk/servicestub/main.cpp:

Delete the service before quitting the application.

This is required since the service shutdown sometimes requires a fully
funcational QCoreApplication. Not having that leads to crashes.

Alex Fiestas committed changes in [bluedevil] /daemon/kded:

Replaced AgentListener (QThread) by delayed DBus messages

This thread has been causing many crashes for some people, and
as far as I remember all the backtraces show weird things not really
within BlueDevilcode, and of course none of the BlueDevil developers has
been able to reproduce the bug. So the best/easy/simpler way of fixing
this is by removing the Thread which shouldn't be there in the first
place.

Dario Freddi committed changes in [kde-workspace/dafre/new-powerdevil] /daemon/actions/bundled:

Be smart enough to avoid bringing brightness up when switching to a more conservative profile.

Sebastian Trueg committed changes in [kde-runtime/KDE/4.7] nepomuk/common/removablemediacache.cpp:

Fixed encoding conversion of paths with spaces.

This includes any character that is percent encoded in URLs.
This fixes a bug where the metadata from files on removable media was
removed when restarting Nepomuk.

Dario Freddi committed changes in [kde-workspace] /daemon/actions/bundled:

Be smart enough to avoid bringing brightness up when switching to a more conservative profile.

Alex Fiestas committed changes in [bluedevil/1.0] src/kcmodule/bluedevildevices.cpp:

Close the renameAlias dialog if the devices change

This is not perfect since this will be triggerd when ANY change
happens in any device but is better than crashing. Will try to fix
better in future versions of BlueDevil.


FIXED-IN: 1.0.6

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/kitemlistview.cpp:

Don't apply an empty item-size to the layout

This fixes strange layout-issues when turning on/off previews in the
details-view.

Timothy Pearson committed changes in /branches/trinity/kdelibs/kio/kssl/kssl/caroot/ca-bundle.crt:

Fix broken root certificates in kdelibs kssl
This repairs spurious certificate warning errors on secure connections via Konqueror/KHTML

Thomas Lübking committed changes in [kde-workspace] kwin/effects/presentwindows/presentwindows.cpp:

don't scale highlighted window in present windows during de/activation


it's even worse, since it interferes with generally upscaled windows
(keeps them big, applies false transition and causes a final snapback)
and windata->highlight doesn't end at zero, so the entire screen is
still a little scaled when the effect ends (and snaps down afterwards)

now it snaps down when starting the leave what is better in general
and the only usable solution for upscaled windows.
some day presentwindows might be derived from the yet-to-add
animationeffect class ;-)

KDE-PIM

Kevin Ottens committed changes in [zanshin] /:

Workaround Qt 4.8 behavior change of QAbstractProxyModel

OK, that one was tough! Turns out that in Qt 4.8 the behavior of
QAbstractProxyModel changed because it now provides a reimplementation
of hasChildren() not based on rowCount() & columnCount(), but by
forwarding the request to the source model (which in my opinion doesn't
really make sense...).

Because of that, all the proxies or views on top of subclasses of
TodoProxyModelBase were getting totally confused because of
contradictions between hasChildren() and rowCount() results.

That explains the random crashes, or empty views experienced by users
running with Qt 4.8 beta.

Pfew! I'm glad I finally noticed those reports were mentionning Qt 4.8.

Grégory Oestreicher committed changes in [kdepim-runtime] resources/dav/common/davcollectionsfetchjob.cpp:

Correctly read collection permissions

Igor Poboiko committed changes in [kdepim] /themes/xml_output:

Make KJots create valid XML

Laurent Montel committed changes in [kdepim] kmail/kmcomposewin.cpp:

Fix Bug 263313 - inserts line breaks in quoted messages, missing quote signs


FIXED-IN: 4.7.3

Laurent Montel committed changes in [kdepim-runtime] migration/kmail/localfolderscollectionmigrator.cpp:

Fix Bug 283467 - Kmail has duplicated folders after migration from previous version.

By default in config we don't translate config name.
We use "inbox" "sent-mail" etc.


FIXED-IN: 4.7.3

Office

Robby Stephenson committed changes in [tellico/2.3] /:

Only show boolean checkmarks when field values are not empty

The entry value was not read before returning a checkmark icon
for boolean fields. This was a regression in Tellico 2.3.4.

FIXED-IN: 2.3.5

Jarosław Staniek committed changes in [calligra] /main:

Main Window: Simple support for global search box in Kexi (unfinished)
+Global search box accessible using Ctrl+K
+Fixed setup of global shortcuts

Diffs: 1, 2, 3, 4, 5 Revision 66bf187...
Boudewijn Rempt committed changes in [calligra] /ui:

Do not crash when opening the scratchpad

There's something rotten in our handling of the display manager through
the resource server. So for now, get the scratchpad's display profile
just like the canvas does.

When we move to colord and oyranos (and colorsync and so on), we need
to krita's displayprofile code quite carefully.

Boudewijn Rempt committed changes in [calligra] krita/ui/openrastertk/kis_open_raster_stack_save_visitor.cpp:

ORA: do not save opacity fraction using locale decimal separator

This would sometimes save opacity as 0,45 instead of 0.45 which
severly impairs interoperability.

Boudewijn Rempt committed changes in [calligra] /:

Remove split view functionality

The Calligra split view functionality has some serious problems:

* we cannot split and have two documents in one view
* it is buggy
* the action list is loaded twice when splitting the view, which means
that all shortcuts stop working because they are duplicated

REVIEW:101993





We need to redesign this feature and implement it properly. The age-old
hacks (veryHackyActionList...) cannot be fixed, so remove the current
implementation.

Networking Tools

Joris Guisson committed changes in [ktorrent] /:

Fix move on completion location not being set when open all torrents
silently is enabled

Andrea Diamantini committed changes in [rekonq] src/networkaccessmanager.cpp:

use language, NOT country!!!

This should fix bad language detection. Please, let me know about

Joris Guisson committed changes in [libktorrent] src/download/packet.cpp:

Fix bug causing 100% CPU usage in the packet sending code when there are no upload limits

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] kdecore/network/kssld/kssld.cpp:

Correctly apply the policy for self signed certificates with unqualified
hostnames, e.g. localhost.

Credit for this patch goes to Florent Bondoux.


FIXED-IN: 4.7.3

Francesco Nwokeka committed changes in [telepathy-presence-applet] package/contents/ui/main.qml:

Fixed problem with plasmoid not maintaining size

This because plasma introduced two new properties in the plasmoid API that weren't set in the
plasmoid: minimumWidth & minumumHeight

Joris Guisson committed changes in [ktorrent] /:

Relabel Change Tracker button into Switch Tracker to avoid user confusion, also add tooltip and only enable the button, when the torrent is private.

Lamarque Souza committed changes in [networkmanagement/nm09] libs/ui/gsmwidget.cpp:

Set default GSM's "password" flag to AgentOwned to prevent the password
from not being saved at all and, consequently, the secrets dialog appearing
at each connection attempt.


FIXED-IN: nm09

Martin Klapetek committed changes in [telepathy-contact-list] /:

Save group's expanded state and restore it upon contact list reopening

Reviewed-by: David Edmundson
REVIEW: 102728

Joris Guisson committed changes in [ktorrent] /:

Revamp IP filter widget

Sune Vuorela committed changes in /trunk/KDE/kdenetwork/kopete/protocols/oscar:

Put the Oscar Client class in a namespace.
Thanks to Ralf Jung to track down the issue

Matthias Fuchs committed changes in /trunk/KDE/kdenetwork/kget/ui/linkview:

Filtering for mime type works again and is more robust.

Also removes methods what are not used.
Adds acceptText which returns true if the text is to be
accepted based on the user's filter.
Instead of relying on the exact position of the combobox
entry now we depend on the entry's data.

Diffs: 1, 2, 3, 4, 5 Revision 1257582
Joris Guisson committed changes in [libktorrent] /:

Prevent file descriptor exhaustion from happening, fixes several crashes

User Interface

Hugo Pereira Da Costa committed changes in [kde-workspace] kstyles/oxygen/oxygenstyle.cpp:
Hugo Pereira Da Costa committed changes in [kde-workspace] kwin/clients/oxygen/oxygenclient.cpp:

Turn off antialiasing when rendering window outline borders.

Games

Stefan Majewsky committed changes in /trunk/KDE/kdegames/kolf:

Fix some more Z-ordering bugs with static struts and b2ContactListener.

As described in bug 280943, the problem is that the old b2ContactFilter
implementation detected wall-ball collisions too early (when the AABBs
of the participating objects touched for the first time). Especially for
diagonal walls, the ball has not yet been strutted when ShouldCollide()
is called.

This problem is solved by switching from b2ContactFilter to
b2ContactListener, which kicks in only when a collision has really been
detected. (The contact is then disabled if appropriate, as recommended
by the Box2D manual.)

This solution unfortunately introduces a new problem: Walls around
RectangleItems are now invisible for balls coming from inside the
RectangleItem (e.g. bridges and windmills). Actually I have no idea why
this problem didn't appear previously. I solve this by introducing the
notion of "static struts": The rectangle item is the static strut for
its walls and raises them all, even if they are not colliding with the
rectangle item (WindmillGuard, you're an a**hole).


FIXED-IN: 4.8

Features

KDE Base

Christoph Cullmann committed changes in [kate] part/syntax/data/css.xml:

Support new CSS3 units
patch by Vincent Ricard

Dario Freddi committed changes in [kde-workspace] /daemon:

Interface PowerDevil with Plasma activities.

>From now on, the daemon will be activity-aware and will be able to trigger special behaviors
depending on the activity's configuration.

Frank Reininghaus committed changes in [kde-baseapps] /src:

Add function KItemListSelectionManager::isSelected(int index)

This function is used in KItemListView::updateWidgetProperties()
to find out if an item is selected in a more efficient way.
The new function is tested in KItemListSelectionManagerTest.
I've factored out some code from
KItemListSelectionManagerTest::testChangeSelection() to a new
member to simplify the test.

Diffs: 1, 2, 3, 4 Revision 1e16b68...
Martin Gräßlin committed changes in [kde-workspace/farhad_hf/lockscreen] /effects/screenlocker:

QML screen locker using KGreeter

ScreenLocker uses a QML scene with the wigdets provided by the
KGreeterPlugins embedded as proxy widgets (yes that sucks, but
it's the best we get without breaking everything).

When clicking the unlock button in the QML scene a signal is emitted
which triggers the greeter verify process. If it succeeds the lock
screen is removed. Failure is not yet supported (restart of greeter).

Currently there are the following remaining issues:
* bad layout of proxy widget
* proxy widget is not auto-focues
* return key does not accept
* switch user not yet implemented
* messages from greeter not passed to view
* authentication failure not yet supported

Diffs: 1, 2, 3, 4, 5, 6 Revision 2433807...

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Now we can disable a filter. Not necessary to delete it to disable it :)

Diffs: 1, 2, 3, 4, 5, 6 Revision 6851bb3...
Laurent Montel committed changes in [kdepim] /:

Fix Bug 276776 - no option to rename file when saving attachments

FIXED-IN: 4.8

Dan Vratil committed changes in [akonadi-google] libkgoogle/kgoogleaccessmanager.cpp:

Handle daylightsaving correctly (bug #283180)

The UTC-offset for a KDateTime-value passed to dateToRFC3339String as parameter
is calculated for the current time instead for the KDateTime-value itself.

Office

Shantanu Tushar Jha committed changes in [calligra] /:

Add zoom-to-fit support to text documents.
Remove "prev"/"next" text from buttons.

Stephane Mankowski committed changes in [skrooge/Feature] /:

feature: New tag for grantlee to be able to use standard palette. Colors of the "Default" template are coming from the KDE palette now.

Diffs: 1, 2, 3 Revision b0c9b05...
Stephane Mankowski committed changes in [skrooge] /:

feature: "Monthly report" widgets for the dashboard can be set on current month

Diffs: 1, 2, 3 Revision a23cfe2...
Thomas Baumgart committed changes in /trunk/extragear/office/kmymoney/kmymoney/dialogs/kequitypriceupdatedlg.cpp:

Allow online price update during account creation

Needs to be backported to stable branch

Networking Tools

Martin Klapetek committed changes in [telepathy-kded-module] /:

Integrate global presence into kded-modue with autosaving last presence

Reviewed-by: David Edmundson
REVIEW: 102782

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision f24e51f...
David Edmundson committed changes in [telepathy-accounts-kcm] /:

Add KWallet support for loading/saving passwords.

Diffs: 1, 2, 3, 4, 5 Revision 3f23456...

User Interface

Ruslan Kabatsayev committed changes in [oxygen-gtk] src/oxygenstylewrapper.cpp:

Implement checkbox focus for Xul apps

Utilities

Jörg Ehrichs committed changes in [conquirere] /:

initial bibtex importer try

M +- -- nbib/design_overview.jpeg

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision a842f97...

Other

BogDan Vatra committed changes in [ministro/java_redesign] /:

Begin java redesign.

- move strings to resources, add Romanian translation.
- rename package domain name from eu.licentia.* to org.kde.*
- handle .jar/.apk files in Ministro.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 5853d88...

Optimization

Development Tools

Alexander Richardson committed changes in /trunk/KDE/kdesdk/okteta/kasten/controllers/view/structures:

Mostly completed rewrite of array classes (they are editable again)

Should be almost feature complete now and use less memory than before
if they are arrays of integers or floats

KDE Base

Peter Penz committed changes in [kdelibs/KDE/4.7] kfile/kfilepreviewgenerator.cpp:

Fix performance regression in KFilePreviewGenerator

When switching from the details-view to the icons-view in Dolphin/
Konqueror a freeze might occur for several seconds. The root cause
for this is commit 41854146040f8638fffb13b20a75f6ecda2837a6. Using
the DateChangeObtainer only worked for the icons-view but in case
of the details-view still inside Qt a layout change got triggered.
As we know that in our case changing the icon won't result in a
change of the layout the signals of the directory-model will get
blocked temporary. By using the new view-engine such ugly workarounds
won't be needed anymore but KFilePreviewGenerator is still used
by other applications.

Thanks to David Faure for investigating into the root-cause!


FIXED-IN: 4.7.3

Games

Stefan Majewsky committed changes in /trunk/KDE/kdegames:

On X11, choose raster graphicssystem automatically in libkdegames apps.

The QApplication::setGraphicsSystem calls in Kapman and Palapeli are
removed, as libkdegames does now care about this.

DIGEST: This quite improves the rendering performance on Qt <= 4.7.


FIXED-IN: 4.7.3

Other

BogDan Vatra committed changes in [android-qt/java_redesign] /android:

Java redesign ++

R +319 -28 src/android/jar/src/org/kde/necessitas/industrius/QtActivityDelegate.java [from: src/android/jar/src/org/kde/necessitas/industrius/QtActivity.java - 067% similarity]

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 8 more) Revision b7140bc...