Issue 206

23rd October 2011 by KDE Commit-Digest Team

Contributors

Gaël Beaudoin
Vladislav Blanton
Jaka Kranjc
Shafqat Bhuiyan
Marta Rybczynska

This Week...

Work on grouping for names in KDE Base. Added minimal global search implementation with autocompletion in Kexi. New Gaussian autobrush type in Calligra. Amazon-based music store in Amarok. Fixed handling of redirections with HTTP DELETE and PUT requests in KDE Libs. Geolocation filter option added to Digikam filtering sidebar.

Statistics

Commits 2276 by 181 developers
Open Bugs 23370
Open Wishes 17291
Bugs Opened 573 in the last 7 days
Bugs Closed 512 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
161
 
/branches/stable
109
 
/branches/trinity
59
 
/trunk/l10n-support
55
 
/trunk/www
17
 
/trunk/KDE
15
 
/lib/documentview
14
 
/branches/work
14
 
/libkcoreaddons/src
14
 
/trunk/playground
13
 
Files Developer Commits
246
 
Laurent Montel
84
 
177
 
Timothy Pearson
59
 
120
 
Marco Martin
45
 
132
 
Jekyll Wu
44
 
129
 
Aurélien Gâteau
43
 
120
 
Vit Pelcak
40
 
99
 
Sebastian Kügler
35
 
90
 
Friedrich Karl Tilman Pülz
33
 
96
 
Sairan Kikkarin
32
 
84
 
Albert Astals Cid
28
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Portuguese (pt)
100%
 
Swedish (sv)
99%
 
Spanish (es)
95%
 
Polish (pl)
94%
 
Dutch (nl)
94%
 
Estonian (et)
93%
 
German (de)
93%
 
Low Saxon (nds)
91%
 
French (fr)
90%
 

Bug Killers

Person Bugs Closed
Christoph Feck
173
 
Dawit Alemayehu
37
 
trueg kde org
34
 
Jekyll Wu
22
 
Laurent Montel
19
 
Julian Seward
17
 
neoclust kde free fr
16
 
Christophe Giboudeaux
15
 
Lamarque Souza
13
 
Ben Cooksley
11
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] [] []   

Educational

[]     

Graphics

[] [] []   

KDE Base

[] [] []   []

KDE-PIM

[] []    

Office

[] []    []

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    

User Interface

     

Utilities

[]     

Games

[] []    

Other

[] []    

There are 61 selections this week

Bug Fixes

Development Tools

Bernd Buschinski committed changes in [kdevelop] projectbuilders/makebuilder/outputfilters.cpp:

Educational

Jeremy Paul Whiting committed changes in [parley] src/settings/languagepropertiespage.cpp:

Make sure we have an identifier before trying to dereference it.
Fixes add language crash.

Graphics

Albert Astals Cid committed changes in [okular/KDE/4.7] generators/poppler/generator_pdf.cpp:

Do not assume pdfdoc hints won't change

Since sometimes we even change the pdfdoc pointer itself ;-)
This was working previously by pure luck (read bug in poppler :D)

FIXED-IN: 4.7.3

Albert Astals Cid committed changes in [okular] generators/poppler/generator_pdf.cpp:

Do not assume pdfdoc hints won't change

Since sometimes we even change the pdfdoc pointer itself ;-)
This was working previously by pure luck (read bug in poppler :D)

FIXED-IN: 4.7.3
(cherry picked from commit eb705417fac06ad7a29b9f05f00c825ded886334)

Andi Clemens committed changes in [digikam] /:

The "hide thumbbar in fullscreen mode" setting was not respected in albumUI,
only in the image editor.
Also the state before entering fullscreen mode was not restored properly, e.g.
the toolbar was shown, although the user might have hidden it in the first
place.

While fixing the issue, I asked myself: We do we have these two fullscreen mode
settings in the editor window page of the setup dialog? They are used for
albumUI as well (maybe even for lighttable?).

Shouldn't these settings be moved to the "General" page?
Also, an action is missing in the context menu for returning from the
fullscreen mode if the toolbar is hidden. How should a normal user know the
shortcut for this action?
At least my parents wouldn't know it, and I guess they can be considered as
"normal users" ;-)

Andi

Diffs: 1, 2, 3, 4 Revision a97fcf4...

KDE Base

Esben Mose Hansen committed changes in [kde-workspace] /:

Fix and improve shortcuts "next history item" and "previous history item" in klipper, provided by Michal Seben

REVIEW: 102672
(cherry picked from commit a6b69cb3781b4e3d6b39c8f391e08695a9cb9b75)

Dawit Alemayehu committed changes in [kwebkitpart] src/kwebkitpart_ext.cpp:

Properly close all the QIODevice instances after use.

This should fix the issue where unnecessary session files are left lingering
around whenever kwebkitpart terminates normally.

Tomaz Martins dos Santos Canabrava committed changes in [kdeplasma-addons] /virus:

Make the Virus wallpaper selector behave equally as the normal wallpaper selector.

Diffs: 1, 2, 3, 4 Revision 8f1ca06...
Dawit Alemayehu committed changes in [kde-baseapps] /src:

- Prevent KonqMisc::konqFilteredURL from reparsing _url when the filtering test fails.
Since the filtering failure means _url is definitely invalid.

- Prevent both KonqFrameTabs::slotMouseMiddleClick functions from opening a URL when
it is not valid or is an error URL.


FIXED-IN: 4.7.3
REVIEW: 102931
(cherry picked from commit b1b13ebbfdde78248297d286ad454b19d08666a0)

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/views/dolphinview.cpp:

Sort the items in DolphinView::selectedItems(), part 2

I forgot this change in the last commit.

Christoph Feck committed changes in [kdelibs/KDE/4.7] kfile/kfileplaceeditdialog.cpp:
David Faure committed changes in [kdelibs/KDE/4.7] /:

Fix DirectorySizeJob counting hardlinks multiple times.

This required to pass the device number and inode number from kio_file
to the job, which is only enabled when the details level is set to 3,
so as to not impact performance in other cases.

It's never too late to fix a bug from 2003.

FIXED-IN: 4.7.3

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] /http:

Make sure both DELETE and PUT requests properly handle redirection requests
to address the issue reported in bug# 267063. In the process of addressing the
afformentioned bug the following related changes and cleanups were performed:

- Removed the check for HTTP_POST on redirection so that kio_http behaves
exactly like Firefox and Chromium except for HEAD requests. Converting
HEAD requests to GET makes no sense.

- Changed both ::del and ::put to leave the query component of the request
URL alone except for WebDAV requests. Not sure why it is removed for DAV
requests either.

- Changed ::del to properly handles any message body returned by the server.

- Renamed sendHttpPutError to sendHttpError and converted it to handle HTTP
response code errors for all HTTP methods, not just PUT.

- Changed proceedUntilResponseContent to use the new sendHttpError function
to send error to the client.

- Converted both ::del and ::put to use proceedUntilResponseContent since it
now correctly handles errors returned by the server.


FIXED-IN: 4.7.3

Jekyll Wu committed changes in [konsole] /:

Ensure %w and %# are also expaned in the 'Copy input' dialog

The fix is quite simple. Just move the existing code for expanding
%# and %w into Session::getDynamicTitle(), where all other tab title
formatters are expanded. That also makes the code simple and natural.


FIXED-IN:4.8

Sebastian Trueg committed changes in [nepomuk-core] /:

Handle parent folders or convertable URLs.

So far we converted URLs which actually exist. Now we also handle
partial URLs like /media/foo if a storage is mounted on /media/foobar.
This is handled by adding additional regex filters to the already
existing one.

Dawit Alemayehu committed changes in [kde-runtime] /ikws:

When creating a new web shortcut desktop file, make sure the desktopEntryName
is properly set. Otherwise, it will show up as an empty entry in the preferred
web shortcut list.


FIXED-IN: 4.7.3
(cherry picked from commit ef70e0fe2504a9b49457a01dce19f822f3237081)

Jekyll Wu committed changes in [konsole] /:

Allow activity notification to be triggered more than once.

The activity notification is now masked for a while after it is triggered.
That is basically what KDE3 konsole does. The mask interval is intended
to avoid the flooding of notification and is hardcoded as 15 seconds
at the moment. Maybe that interval should be user configurable.

FIXED-IN:4.8

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Don't allow to create a snippet without parent otherwise it's converted to a group not as user wants

Laurent Montel committed changes in [kdepim] /:

Fix Bug 261830 - text snippets can not be moved via drag and drop between groups

FIXED-IN: 4.7.3

David Faure committed changes in [kdepim/KDE/4.7] messagecomposer/messagefactory.cpp:

Fix assert when Mail-Followup-To contains two emails, as Ossi's Mutt does

Thanks to Andras for the hint about how to fix it

David Faure committed changes in [kdepimlibs] akonadi/typepluginloader.cpp:

Resolve alias read from the desktop file too.

Fixes a crash with shared-mime-info 0.91 where text/directory
was replaced with text/vcard (which was made an alias).

FIXED-IN: 4.7.3

Laurent Montel committed changes in [kdepim] messageviewer/headerstyle.cpp:

Fix 277626 - Enterprise header swallows text in pointed brackets in the subject


FIXED-IN: 4.7.3

Laurent Montel committed changes in [kdepim-runtime] /ispdb:
Laurent Montel committed changes in [kdepim] kmail/kmcomposewin.cpp:

Fix 283115 - "Edit" duplicates the message if changes are not saved

FIXED-IN:4.7.3

Office

Cristian Oneț committed changes in /branches/stable/extragear-kde4/office/kmymoney/kmymoney/views:

Fix to make changes to payee data persistent upon selection of another payee

Backported to stable branch.

Multimedia

Matěj Laitl committed changes in [amarok] /:

Properly recognize iPod 3G in MediaDeviceCache (extend iPod Touch 3G quirk)

We already had special case for devices whose product attribute
contained "iPod" in slotAddSolidDevice(), extend this special case also
for devices whose product attribute contains "iPhone".

This could fix bug 281738 and should end up in Amarok 2.5 beta 1, so
please test and reopen the bug if it still appeard in beta 1.

REVIEW: 102864

Networking Tools

David Edmundson committed changes in [telepathy-text-ui] /:

Tidy up all key handling code.

Remove signals and slots, and use event propogation where it makes more sense to pass events to parents.

REVIEW: 102908

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport] applet/publictransport.cpp:

Fix crash when resizing the widget when not in departure view

- When the departure view is not shown no filter widget is shown
but on resize the applet tries to adjust the filter widget,
which leads to a crash

Eike Hein committed changes in [yakuake] app/mainwindow.cpp:

Fix geometry in multi-screen cases

Commit 81484067 addressed and issue with multi-head setups where the
top strut of a window not visible on yakuake's display would be removed
from its work area. However, it did not consider bottom, right, and left
struts, and also prevented the left, right and bottom struts of windows
on the same display as yakuake from being removed from its work area.
This patch fixes this issue and tries to make the code more explicit.

Rolf Eike Beer committed changes in [kgpg/KDE/4.7] /:

ask the user before overwriting files when exporting keys

Now when the user wants to export the public key to a file and that file
already exists the user is asked about overwriting the file.


REVIEW:102786

Games

Jeffrey Kelling committed changes in /trunk/KDE/kdegames/konquest:

Konquest: Fix re-new game

Fix following bugs when a new game is created after a previous match:
Crash due to paint events for deleted planets: check for null pointer.
Superfluous players being added

Other

Sebastian Trueg committed changes in [soprano/2.7] soprano/nrlmodel.cpp:

Fixed a deadlock in NRLModel caused by a non-recursive mutex.

Thanks to Jonathan Marten for the hint.

Jeremy Paul Whiting committed changes in [attica] lib/provider.cpp:

Fix upload by setting contentId.
Fix provided by Stephane MANKOWSKI

Features

Development Tools

Milian Wolff committed changes in [kdevelop] /cpp:

c++11 support: folow spec and use/introduce expression-list where required

this way we can finally pass init-lists as arguments to a function call

NOTE: binary-expression is not (anymore?) in the spec and should probably
be reomved. Also the m_arguments* code, esp. related to binary-expressions
in the expressionvisitor should be cleaned up now as it's most probably
obsoleted by the new (simpler) code.

NOTE2: also fixes an issue with variadic template pack-expansion in
function pointers

Diffs: 1, 2, 3, 4, 5 Revision ce9930d...
Aleix Pol Gonzalez committed changes in [kdevelop/welcomepage] /:

First approach to a welcome page for KDevelop.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision d4dea1f...
Aleix Pol Gonzalez committed changes in [kdevelop/welcomepage] /:

First approach to a welcome page for KDevelop.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b7fff1a...

Graphics

Michael Georg Hansen committed changes in [digikam] /:

Add a geolocation filter option to the filtering sidebar.

The setting of the filter is not yet restored when digikam is restarted.

KDE Base

Lukáš Tinkl committed changes in [kdelibs/frameworks] /solid/solid/backends/udisks:

Show LUKS crypted partitions on local hard drive in Dolphin

REVIEW: 102529

Matthias Fuchs committed changes in [kde-runtime] /:

Enhances BugReport to have a Resolution and Status enum.

Dawit Alemayehu committed changes in [kde-runtime] /ikws:

Added a search edit for web shortcuts.


FIXED-IN: 4.8.0

Sebastian Trueg committed changes in [nepomuk-core/server/serviceControllerRed] /:

Shutdown and initialize services asyncronical.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 9c9c3fe...
Thomas Lübking committed changes in [kde-workspace] /libkwineffects:

Add AnimationEffect class
REVIEW: 102922

Diffs: 1, 2, 3, 4, 5 Revision b10f7f5...
Peter Penz committed changes in [kde-baseapps] /src:

Implement grouping for names

- Use a custom header for KFileItems
- Cache the groups
- Allow enabling/disabling grouping dynamically

Currently there is a random crash in combination with the
groupheader-recycler, this will be fixed during the next
days.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b62890d...
Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] /:

- Added SOCKS proxy support.
- Added support for dealing with more than on proxy server URL.

REVIEW: 102923

Diffs: 1, 2, 3 Revision 0957587...
Matthias Fuchs committed changes in [kde-runtime] /:

Can fetch and parse bug reports and compare backtraces.

Actual comparing part needs work!

Diffs: 1, 2, 3 Revision 3ddebad...
Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Implement group-header layouting

The most tricky part for groups - the layouting - basically works
now for all views (grouping was available only in the icons views
for Dolphin 1.x) and is nearly equally fast as without groups.

Still open:
- Group headers are ugly screen rectangles
- Return valid groups in KFileItemModel instead of the currently
hardcoded testing values
- Dynamically turning on/off groups does not work currently, the
directory must be reentered

Diffs: 1, 2, 3, 4, 5, 6 Revision 365c467...
Jekyll Wu committed changes in [konsole] /:

Support using Ctrl+<mouse-wheel> for zooming text size


FIXED-IN:4.8

KDE-PIM

Allen Winter committed changes in [kdepim] /:

add a Settings->Show QR Codes configuration (when libprison is avail)

cannot backport to 4.7 since there are new strings
and this arguably a new feature.

Diffs: 1, 2, 3, 4 Revision 02b2e0d...

Office

Geoffry Song committed changes in [calligra] /:

New autobrush type: Gaussian

The Gaussian autobrushes use a Gaussian blur for their fade, rather than
the linear function used by the default autobrushes. The result is that
the brushes look softer and have less of an edge, as well as having
fewer aliasing issues.

Jarosław Staniek committed changes in [calligra] /:

Kexi: Added minimal global search implementation with autocompletion

MainWindow
*Added minimal global search implementation with completion list, now just searches within Project objects
**after pressing Enter - select object name in Project Navigator
**on highlighting in completion list, highlights the object name
**[code]QCompleter which cannot do substring matching (https://bugreports.qt.nokia.com/browse/QTBUG-3414)
**[code]KCompletion is not better
**[code]Forked QCompleter and related classes and put in KexiUtils

DIGEST: Kexi: Added minimal global search implementation with autocompletion

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 5faf150...

Multimedia

Sven Krohlas committed changes in [amarok] /:

Amazon-based music store

We now have a music store, absed on the Amazon catalogue.

Searching works for DE, FR, JP, UK, US. Checking items out is broken atm
for US, but should work in a few days after we get a ok from Amazon.

Not yet implemented:
* viewing the shopping cart in Amarok
* limiting search to albums/tracks only
* track previews
* you might also see some albums without a price
* artwork is still missing.


DIGEST: Amazon-based music store in Amarok

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 27 more) Revision 2e57ad6...

Networking Tools

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Make Network Manager show signal strength in system tray also for mobile
broadband connections.
Thanks to Kai Uwe Broulik for this patch.

REVIEW: 102827

FIXED-IN: 0.9.0_beta2

Francesco Nwokeka committed changes in [telepathy-presence-applet] package/contents/ui/main.qml:

Add context menu for setting global status

Games

Jeffrey Kelling committed changes in /trunk/KDE/kdegames/konquest:

Implement standing orders


REVIEW: 6805
GUI: Add checkbox for standing orders to fleet setup area. While this
item is checked larger values than ships currently available can be
entered. Standing order will be executed whenever enough ships are
available.
GUI: If a planet has standing orders the number of ships needed for them
is displayed in the planets tooltip.
GUI: Standing orders are marked in the fleet dialog and can be removed
there at any time.

Other

Ralf Habacker committed changes in [kdewin-installer] /:

added dedicated start menu support for single packsge installation.

When installing single packages, we use the name and version of the installed
package to generate the start menu root entry. Otherwise the name 'KDE' and
the version number reported by kde4-config is taken.

The installer runs kwinstartmenu with the installed package name and version,
which are stored by kwinstartmenu in <install-root>/share/config/kwinstartmenurc
and are used to generate the start menu entries.

Storing the package name and version in a installation related config file
let kwinstartmenu be able to find the correct entry on further remove or
updates either from installer, kded winstartmenu module or installers.

Diffs: 1, 2, 3 Revision c47e0a0...

Optimization

Development Tools

Lambert Clara committed changes in [kdevplatform] plugins/grepview/grepoutputview.cpp:

Speed up collapsing of all elements in Find/Replace treeview.

REVIEW: 102894

Graphics

Aurélien Gâteau committed changes in [gwenview/agateau/xfade-qgv] /documentview:

Massive refactor:

- makes it possible to use QGraphicsSvgItem in SvgImageView
- implements drag to scroll for both raster and svg

Diffs: 1, 2, 3, 4, 5, 6 Revision 8a87978...

KDE Base

David Faure committed changes in [kdelibs/KDE/4.7] kdecore/services/kmimetyperepository.cpp:

Read the first 16K of the file upfront, to minimize seeks and reads.

Patch by Miroslav Ľos - thanks!


FIXED-IN: 4.7.3
REVIEW: 102391

Other

Sebastian Trueg committed changes in [nepomuk-core/server/serviceControllerRed] server/main.cpp:

nepomukserver does not need to be a KApplication.

The only reason to use KApplication or rather KUniqueApplication before
was to ensure that only one server is running. However, we do not need
to be able to attach to a running server or provide it with command
line arguments. Thus, a simple DBus service test is perfectly sufficient
and allows us to scale the server down to a QCoreApplication.

That way we also do not expose the KApplication DBus interface. This is
important since we do not want anyone to call the quit method without
the server being able to gracefully shut down.

Ben Cooksley committed changes in [kde-workspace] /app:

Show a seperately named item named 'KDE System Settings' when not under KDE.
Whilst this will ultimately make KDE support harder, it is the only thing we can do to ensure that System Settings remains accessible outside KDE

Diffs: 1, 2, 3 Revision c763e39...

Office

Jarosław Staniek committed changes in [calligra] kexi/plugins/forms/kexiformmanager.cpp:

Changed Form Design Toolbar icons order and set to have text under icon
Congratulations Dimitrios, first commit!

DIGEST: First commit to Kexi Forms from new Kexi contributor