Issue 210

20th November 2011 by KDE Commit-Digest Team

Contributors

Roger Pixley
Vladislav Blanton
Gaël Beaudoin
Jaka Kranjc
Paulo Dias
Marta Rybczynska
Marcin Dominiak

This Week...

Progress in the work to separate QGraphicsView from libplasma. Calligra sees work on docx support and autocolor. Telepathy sees UI refactoring; there is now extended away support and dialog-less setup for link-local XMPP. Marble gets 'space view' activity. Digikam gains Aspect Ratio Crop tool and Kodak HIE infrared filter in Image editor converter. Plasma Active gets UI for setting start page, adblock and history; lockscreen. KMyMoney can show the balance of a budget.
Krita -- Getting Closer to 2.4 (step by step) by Boudewijn Rempt

So, what's up with Krita? I haven't been able to write weekly development updates for Krita for some time now, being too busy with work, triaging Krita bugs and hacking, so when I was asked to give a short update for the commit digest, I agreed with alacrity.

We're moving forward to the 2.4 release, and that means nearly no big changes in recent times. Except for the merging of the Google Summer of Code projects by Srikanth, Dmitry and Siddharth, of course. The SIOX tool that Bruno is developing isn't quite done yet, but he will continue after his current round of examns. There's plenty left to do of course, quite a few bugs to fix, even some regressions... We did select a new splash screen for 2.4 already:

But on the whole, Krita has never been so functional. The "Comics with Krita" Training DVD (+ comic book) is very popular, the local post office is loving me! And we're getting to hear comments like:

It literally has an Alchemy brush engine and a mirror/pull function just like alchemy.
It has a Painter style engine allowing color blending and mixing and papers/textures.
It has Photoshop like functions allowing image stamps and custom brushes.
It has a Mypaint style procedural brush engine allowing for brush texture experimentation.
It has a Harmony style brush engine, with those cool soft webbed drawing lines.
It has vector - pretty much everything (brushes, text, art)

Basically this program kicks ass

Wayne Parker, Concept Art

This really is a large part of why we're working on Krita. To see people love the application and do work with it. The remaining part is the fun we have hacking on it, of course!

If this has wetted your appetite, why not take one of the visual tours:

Or check out the code and try to build it... If you have any problems, join us on #krita on irc.freenode.net. We can get you started!

Statistics

Commits 2198 by 192 developers
Open Bugs 23460
Open Wishes 17321
Bugs Opened 538 in the last 7 days
Bugs Closed 666 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
220
 
/branches/stable
77
 
/trunk/l10n-support
46
 
/branches/work
30
 
/trunk/www
21
 
/plasma/declarativeimports
16
 
/akonadi/calendar
16
 
/trunk/KDE
16
 
/libs/textlayout
14
 
/libs/flake
8
 
Files Developer Commits
222
 
Laurent Montel
74
 
210
 
Marco Martin
73
 
156
 
Martin Gräßlin
52
 
114
 
Yuri Chornoivan
38
 
90
 
Sergio Luis Martins
30
 
81
 
Dawit Alemayehu
27
 
78
 
Martin Klapetek
26
 
72
 
Burkhard Lück
26
 
78
 
Sairan Kikkarin
26
 
72
 
Chusslove Illich
24
 

Internationalization (i18n) Status

Language Percentage Complete
Brazilian Portuguese (pt_BR)
99%
 
Dutch (nl)
94%
 
Polish (pl)
94%
 
French (fr)
93%
 
German (de)
93%
 
Estonian (et)
92%
 
Italian (it)
90%
 
Low Saxon (nds)
90%
 
British English (en_GB)
87%
 
Danish (da)
86%
 

Bug Killers

Person Bugs Closed
Christoph Feck
99
 
Dawit Alemayehu
91
 
Beat Wolf
52
 
Christophe Giboudeaux
44
 
Myriam Schweingruber
34
 
trueg kde org
32
 
Aaron J. Seigo
27
 
Laurent Montel
24
 
Ben Cooksley
23
 
Lamarque Souza
18
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

[] []    

Graphics

[] []    

KDE Base

[] [] []   

KDE-PIM

[] [] []   

Office

[] [] []   

Konqueror

     

Multimedia

[]   []   

Networking Tools

[] [] []   []

User Interface

[] []    

Utilities

[] []    

Games

     

Other

[] []    

There are 126 selections this week

Bug Fixes

Development Tools

Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize/src:

correctly do spellcheck when accel is _

David Nolden committed changes in [kdevplatform] plugins/reviewboard/reviewboardplugin.cpp:

Make the link in a message box in review board plugin work
REVIEW: 103139

Milian Wolff committed changes in [kdevplatform] plugins/subversion/kdevsvncpp/context.cpp:

properly initialize client context for compatibility with subversion API

this should hopefully fix the crash with svn 1.7 in kdevelop, please test

Educational

Torsten Rahn committed changes in [marble] src/plugins/render/satellites/SatellitesItem.cpp:

Fixes: The arab and australo-asian people want satellites, too!

Prior to this commit satellites only appeared on the western
hemisphere due to non-normalized longitudes fed into
GeoDataCoordinates objects.

Aleksey Khudyakov committed changes in [kstars] /widgets:

Fix crash in moon phase almanach

1. Read Moon images from texture manager
2. Store array of pixmaps instead of array of pointers to pixmap
and avoid manual memory management entirely.

Graphics

Marcel Wiesweg committed changes in [digikam] /:

Remove secondary shortcut Shift+Del from Cut action, so that Delete permanently can work

Martin Koller committed changes in [kolourpaint] /selections:

make transparent copy/paste and transparent text writing work again

Albert Astals Cid committed changes in [okular] ui/pageview.cpp:

Fix repainting for repaints with small regions

Makes this statement similar to the one that uses pe->rect() instead of pe->region().rects()

You can test it by:
* Opening a document with okular
* Scroll down a bit so that you are not on the top of the viewing area
* Open the review tool
* Move the review tool around
* See how it leaves unrepainted garbage
* See how this patch fixes it
(cherry picked from commit 9f654a0029976965024a09bf3c095f9f07d031cd)

KDE Base

Matthew John Dawson committed changes in [kdeplasma-addons] applets/systemloadviewer/systemloadviewer.cpp:

Make the swap disappearing issue more robust.

Before there was some questionable logic surrounding the swap detection
code. Make this logic more understandable and robust. This should fix
random resizes that occur for some people.

FIXED-IN: 4.8.0

Matthias Fuchs committed changes in [kdeplasma-addons] applets/comic/comic.cpp:

Set pointer to 0 after deleting.


(cherry picked from commit 5e6e56e5249d1f0215b59d798e27b09b15d44fbc)

Dawit Alemayehu committed changes in [kwebkitpart] src/webpage.cpp:
Martin Gräßlin committed changes in [kde-workspace/screenlocker] /greeter:

Move SessionSwitching into declarative plugin

SessionSwitching becomes a reusable component which handles all the
interaction with the underlying session handling by itself. No need
any more for exposed properties or context properties.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 47cb6ce...
Dawit Alemayehu committed changes in [kde-baseapps] konq-plugins/searchbar/searchbar.cpp:

Changed the default shortcut key to CTRL+SHIFT+S to avoid conflict.



FIXED-IN: 4.7.4
(cherry picked from commit d800e027f994dccbe7089a306a42d2bff4e193ce)

Andriy Rysin committed changes in [kde-workspace] /keyboard:

Fix keyboard layout global shortcuts

Thomas Lübking committed changes in [kde-workspace] kwin/effects/windowgeometry/windowgeometry.cpp:

use contentsrect to calculate window size if baseUnit isn't 1,1

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/kfileitemlistview.cpp:

Improve dragging pixmap

When dragging multiple files, those files should be shown as part
of the dragging pixmap like in Dolphin 1.7.


FIXED-IN: 4.8.0

Kurt Hindenburg committed changes in [konsole] src/Screen.cpp:

Prevent crashing when dumping binary files to terminal.

"cat"ing binary files often crashes Konsole. This patch checks the
indicies.
Note that there are tons of 'undecodable sequences' that also print
out. These likely should not be displayed unless debugging.

FIXED-IN: 4.8

Peter Penz committed changes in [kde-baseapps] dolphin/src/dolphinmainwindow.cpp:

Fix crash when toggling the menu-bar visibility

Use a queued connection to prevent that the menu
gets hidden during it is still open. Thanks to
Christoph Feck for the hint!

Frank and I could not reproduce the issue in our
environments even when following the steps from
bug 278366, however Christoph's hint sounds sane
and let's hope it works (leaves a bad gut feeling
to "fix" bugs without being able to verify them).



FIXED-IN: 4.7.4

Christoph Feck committed changes in [kde-workspace] kcontrol/randr/outputconfig.cpp:

Fix "Changing positions does not enable Apply button"

We had two identical bug reports ... therefore, we got two review
request... Closing both.


REVIEW: 102631

See also:

REVIEW: 103093

Matthew John Dawson committed changes in [kdeplasma-addons] applets/systemloadviewer/systemloadviewer.cpp:

Fix issue with the system/cores value not being received.

The systemmonitor data engine is 100% asynchronous. Unfortunately this
makes polling any source impossible. This caused a hard to pin down
bug related to certain cpu sources not being connected. To correct this
the system/cores value is now properly polled. This should avoid/fix
any issues with 'show usage of all processors' option.

FIXED-IN: 4.8.0

Dawit Alemayehu committed changes in [kde-baseapps] /searchbar:

Avoid potential crashes by using a QWeakPointer to store the reference to the
broweser KPart.


FIXED-IN: 4.7.4

(cherry picked from commit 8c33c21e3382febf8a04713c7f6f975bb74cd8a3)

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] kioslave/http/http.cpp:

In sendBody if the specified content-length is 0, then simply return without
any attempt to obtain data to send to the server.

Prevents potential crashes in the screwed up client code. See bug # below.

Sebastian Trueg committed changes in [nepomuk-core/symlinkHandling] /storage:

Delete the OntologyLoader once the repository goes down.

This is required to make sure the ontology loader does not try to use
the repository while it is being re-opened and thus, does not work
(even asserts on queries).

FIXED-IN: 4.7.4

Dawit Alemayehu committed changes in [kde-baseapps] /src:

Guard against use of NULL pointers.


FIXED-IN: 4.7.4

(cherry picked from commit d5675e5850b1d25d55c9482ed8deff712b9bcc6f)

Thomas Lübking committed changes in [kde-workspace] kwin/client.cpp:

don't ::updateRules() in ::updateActivities()

breaks remember rules when called by ::setActivity() in ::manage()
TODO: add activity rules and make remember state applying more robust in 4.9

Lukáš Tinkl committed changes in [kde-workspace] plasma/generic/dataengines/powermanagement/powermanagementengine.cpp:

unify source names, it might confuse the battery plasmoid when devices get added/removed

(possible fix for https://bugzilla.redhat.com/show_bug.cgi?id=753429)

Aaron J. Seigo committed changes in [plasma-mobile] virtualkeyboard/keyboardshell/keyboarddialog.cpp:

don't crash, but rather exit, if the keyboard plasmoid is unavailable

Thomas Friedrichsmeier committed changes in [kdelibs/KDE/4.7] kio/kfile/kurlcombobox.cpp:

Do not crash when setting maximum number of items to something smaller than the number of default items.

Sebastian Trueg committed changes in [nepomuk-core] /storage:

Delete the OntologyLoader once the repository goes down.

This is required to make sure the ontology loader does not try to use
the repository while it is being re-opened and thus, does not work
(even asserts on queries).

FIXED-IN: 4.7.4

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] kioslave/http/http.cpp:

Workaround brain dead clients that set the username and password of the
request URL to "undefined".

Peter Penz committed changes in [kde-baseapps] /src:

Remove "Rename inline" option

The new view-engine currently does not support inline-renaming
and because of more important pending issues this cannot be
implemented for the 4.8 release of KDE applications.

The plan for 4.9 is to implement inline-renaming again and
to make it "so good" (tm) that it is always turned on (-> there is
no need anymore for an option to disable it ;-)

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] kio/kio/accessmanager.cpp:

Do not crash when QNetworkRequest::ContentLength is either 0 or not specified
for a PostOperation.

KDE-PIM

Mario Bensi committed changes in [zanshin] src/kdateedit.cpp:

Fix date value when date was selected

When the date is selected and the Key_Return/Key_Enter pressed, the value in the
QLineEdit is set to the value of the first item in the QCompleter, here "friday".

To fix this issue, we deselect the date when the Key_Return/Key_Enter
are pressed.

Laurent Montel committed changes in [kdepim] /:

Fix Bug 286889 - Move Thread to Trash Context Menu

FIXED-IN: 4.7.4

Laurent Montel committed changes in [kdepim] /ksieveui:

Fix Bug 286663 - Kontact crashed when canceling creation of sieve script

FIXED-IN: 4.7.4

Laurent Montel committed changes in [kdepimlibs] akonadi/contact/editor/contacteditorwidget.cpp:

Hide tag editor if nepomuk is not initialized

Allen Winter committed changes in [kdepim] libkdepim/progressmanager.cpp:

add a crash and sanity check in removeChild() in case the child map
is empty or the specified item to remove is not in the map.

might fix bug 258080.
but can't know for sure since I can't reproduce.
appreciate testing by those affected by the crash.

Laurent Montel committed changes in [kdepim] kmail/messageactions.cpp:

Fix Bug 278060 - Mailing list detection does not work

FIXED-IN: 4.7.4

Grégory Oestreicher committed changes in [kdepim-runtime/origin/KDE/4.7] resources/dav/protocols/caldavprotocol.cpp:

Filter out collection when listing items
(cherry picked from commit 4cc4a63e55900cc1eabb685ea38a864287344a73)

Andras Mantia committed changes in [kdepimlibs] /:

Make GetQuotaRootJob more robust to accept different responses and fix some bugs in it.
Create a unit test for GETQUOTAROOT.
Based on patch by Lukáš Krejčí.


REVIEW: 103150

Allen Winter committed changes in [kdepim] /:

In mailkernel, create a new method kernelIsRegistered() that says
whether or not the interface dealing with the mail settings has
been registered yet.

Then, in KMail::IdentityPage ctor do not attempt to access the
IdentityManager unless the mail settings interface has been
registered; since the IdentityManager lives in that interface.

This allows one to use the Kontact configuration dialog even if
KMail is not loaded.


MERGE: 4.7

Sergio Luis Martins committed changes in [kdepim] calendarviews/eventviews/month/monthview.cpp:

Event crossing month bounderies wasn't being shown.

Patch by Reimar Imhof.

I changed it a bit and replaced downcasts with date roles.

Laurent Montel committed changes in [kdepim] /:

Fix Bug 286875 - Redirected email is stored in wrong sent-folder

FIXED-IN: 4.7.4

Laurent Montel committed changes in [kdepim] kmail/kmmainwidget.cpp:

Fix Bug 276343 - Incorrect message is displayed when move of messages to trash and elsewhere is completed

FIXED-IN: 4.7.4

Laurent Montel committed changes in [kdepim] /:

Fix Bug 286922 - edited mail from outbox deleted after closing

FIXED-IN: 4.7.4

Office

Inge Wallin committed changes in [calligra] plugins/vectorshape/libemf/EmfOutputPainterStrategy.cpp:

EMF: Fix bug 286713: EMF: Crash: Assert "0", EmfOutputPainterStrategy.cpp

The reason for the crash were unnecessary ASSERT(0) in
SelectStockObject. I removed all asserts there and made sure that a
font was always selected. So no more crashes for stock objects, at
least.

Sebastian Sauer committed changes in [calligra/plugins-chart-datasetcategories] plugins/chartshape/kdchart/src/KDChartPieDiagram.cpp:

Better fix for the text-shrinking logic for pie-charts in KDChart.
The whole logic was flawn by design so I had to rewrite it. Results look pixel-perfect now.

Thomas Baumgart committed changes in [kmymoney] kmymoney/mymoney/storage/mymoneymap.h:

Don't create multiple rollback records in case the same object
gets modified more than once during the same transaction. Keeping
the state before the transaction started once is enough.

Dmitry Kazakov committed changes in [calligra] /image:

Fix update bug for moving nodes

Modified KisFullRefreshWalker to calculate change rect of the nodes
in right way.

See comment in KisFullRefreshWalker::changeRect()

Jan Hambrecht committed changes in [calligra] libs/flake/KoPathShape.cpp:

fix saving quadratic bezier curves

quadratic bezier curves need to properly converted to a cubic
bezier curve to be written out (at least odf does not understand
quadratic bezier curve, which sucks)
the old code attempted to do a very naive conversion to a cubic
bezier curve, which was wrong.
Fixed by using the correctly working KoPathSegment::toCubic function
to do the conversion.

Sebastian Sauer committed changes in [calligra] /:

Fix 'whole column' and absolute definitions in Excel formulas.
Excel allows to define a whole column in a cell-region like "A:B" whereas that is not possible in ODF. So we need to translate that to something like "A$1:B$65536" to be sure the proper cells are evaluated in Tables.

This fixes the VLOOKUP problem visible in the document attached to bug 284601 but was a more general issue not related to only one formula but to all Excel formulas that where using such 'whole column' definitions.

Also it should fix a few cases where we did not proper evaluate absolute vs relative column/row definitions.

QA done with cstester and unittests.

Sebastian Sauer committed changes in [calligra] tables/RecalcManager.cpp:

Fix don't recalc during loading just because a sheet got added.
This makes loading the HeroForge_V6.1.0.1.xls from
bug 284325 by a few *factors* faster.

Yue Liu committed changes in [calligra/filters-visio-yue] /:

repalced wpd/wpg/vsd import filter with writerperfect, added microsoft works document import filter, added WriterPerfect as new dependency, removed depency LIBWPG, WPD remained for wpd export filter

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 34 more) Revision 45bcd9d...
Marijn Kruisselbrink committed changes in [calligra/tables-rtlfixes-mek] /tables/excel:

read layout direction from xls files, now all the rendering bugs in RTL just need to be fixed...

Diffs: 1, 2, 3, 4 Revision 12ae48e...
Dmitry Kazakov committed changes in [calligra] /ui/canvas:

Fixed lines appearing on a canvas on non-integer zooms

This happens because for scaling we may need some areas outside
current update rect. And these external areas may not be prepared yet
by other threads. So our current thread reads empty (not-yet-updated)
areas and uses them for scaling. This causes while lines.

Now the problem is solved like it is solved in
KisLayer::needRect/changeRect. The update, updates it's own rect, and
small adjoining areas around which depent on it, that may be called
"changeRect". Then the patch (KisImagePatch) requests even more pixels
to make the scaling right (that may be called "needRect").

Dmitry Kazakov committed changes in [calligra] /image:

Fixed a bug in the KisUpdateSubtreeWalker

If we update a subtree with some root, we should not write
anything into the root's projection. We use N_EXTRA type of
"dirtiness" for that.

Dmitry Kazakov committed changes in [calligra] /ui:

Workaround for a scaling bug in the canvas

The line at the bottom-right corner appears due to different
behavior of QPainter while scaling. Added a workaround and reported
a bug: https://bugreports.qt.nokia.com/browse/QTBUG-22827

Stephane Mankowski committed changes in [skrooge/Feature] /:

: Renaming categories doesn't rename relevant search/process rules (not fixed but better error management)

Dmitry Kazakov committed changes in [calligra] /:
Sebastian Sauer committed changes in [calligra/plugins-chart-datasetcategories] /chartshape:

Fixed createDataSetsFromRegion, labelRegion and categoryData.

* Fixed createDataSetsFromRegion

The way we where dealing with multi-dimensional cell regions, means cellRegion.width()>1 %% cellRegion.height()>1, was wrong. That could lead in us completly ignoring complete rows/columns.

1) proper sorted either from left-to-right if the dataDirection is Qt::Horizontal or from top-to-bottom when Qt::Vertical.
2) have multiple dimensions proper split-up into single rows/columns to produce one DataSet per row/column.

* Fixed labelRegion

1) Fallback to internalTable for labels.
2) Fix random index-number fetching caused by using depending on a proper value for dataSetNumber to calc the labelRowCol index offset.

* Fixed DataSet::categoryData to return the expected category-data for multi-dimensional cell regions.

* Use table:table-columns and table:table-header-columns to set the number of columns to a minimum rather then ignoring such definitions.

* Guard against multiple table-header-rows definitions in the XML that could end in us dealing with wrong header vs data offsets.

Diffs: 1, 2, 3, 4, 5 Revision 969ef60...
Stephane Mankowski committed changes in [skrooge/Feature] /:

BUG: Better default size of the "category" panel in the split table to avoid manual resizing

Diffs: 1, 2, 3, 4 Revision a42f801...
Dag Andersen committed changes in [calligra] /:

Update reports automatically when schedule changes

Boudewijn Rempt committed changes in [calligra] krita/ui/openrastertk/kis_open_raster_stack_load_visitor.cpp:

Make ora work with calligraconverter

The ora importer used KisImage::resize to resize images after loading
all the layers. This broke when KisImage::resize was ported to the
strokes framework and actually became an asynch crop+resize implementation.

Somehow, the resize never finished when run in batch mode, which meant
that subsequently the png export couldn't even start.

Sebastian Sauer committed changes in [calligra] /tables/xlsx:

Fix handle multiLvlStrRef (a multidimensional stringlist) in the category-definition.
This fixes quit a bunch of 2007 issues where we completly
ignored the categories.

Multimedia

Sergey Ivanov committed changes in [amarok] /:

Fixed crash during MusicBrainz search.

FIXED-IN: 2.5

Sam Lade committed changes in [amarok] /:

Fix audio CD detection on Amarok start

Get a list of optical discs, rather than looking for optical discs in
StorageAccess devices.
This does not fix other audio CD issues such as "play audio CD with Amarok" not
working.

Patch by Luc Menut.



REVIEW:102580

Networking Tools

Joris Guisson committed changes in [ktorrent] /:

Hide chunkbar when download of stream is complete

Rohan Garg committed changes in [telepathy-contact-list] /:

Update icon as per choosen profile when a new account is added

Reviewed By : David Edmundson and Martin Klapetek

Martin Klapetek committed changes in [telepathy-contact-list] main-widget.cpp:

Use correct slots for blocking/unblocking contacts

Lamarque Souza committed changes in [networkmanagement] /:

Reload config and secrets when changing EAP method for WPA2 TTLS wifi
connections.

Lamarque Souza committed changes in [networkmanagement] /:

Prevent connection activation from freezing plasma-desktop for a few
seconds.

Lamarque Souza committed changes in [networkmanagement] /:

Fix creation of Bluetooth PAN connections.

NM refuses to add Bluetooth PAN connections if they include settings for
Gsm, Ppp and Serial configurations. On the other hand those settings are
required by Bluetooth DUN connections. Because of the way our internal
libraries are coded it is not that trivial to check the correct type
(DUN / PAN) before creating a connection, so I am removing the unneeded
settings when creating / editing a connection.

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk] /:

check that parent groupbox is registered to engine before rendering groupbox
background.

Utilities

Jonathan Michael Thomas committed changes in [muon] /:

Discard pending changelog fetch jobs before cache reloads. This prevents changelog jobs
finishing when the QApt::Backend is in a state where package pointers are invalid.

Other

Riccardo Bellini committed changes in [bookmanager] /:

Fix signal/slot connection between import dialog and query engine.

Set signals between worker thread and QueryEngine as direct
connections.
Set signals/slots between QueryEngine and the import dialog as queued
connections.

Signed-off-by: Riccardo Bellini

Nils Fenner committed changes in [libqgit2] /:

Compile against updated libgit2 API

* All object setter functions removed
* Single-function API to create objects shall be added

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 0d70192...

Features

Educational

Dennis Nienhüser committed changes in [marble] /:

Add a 'space view' activity.

Defaults to showing a globe with satellite theme, options to enable
clouds and satellites as well as switching to other planets easily.

Diffs: 1, 2, 3, 4, 5, 6 Revision fe5940c...
Dennis Nienhüser committed changes in [marble] /:

Connect routing UI options (motorcar, bike, pedestrian) to the model.

Diffs: 1, 2, 3 Revision ac7f1f5...
Dennis Nienhüser committed changes in [marble] /lib:

Kinetic spinning for Marble (by Ariya Hidayat).

Now Marble behaves even more like the globe on your desktop.
Thanks for the patch, and sorry for having it sit in svn.reviewboard
unnecessarily long.
REVIEW: 6171

Diffs: 1, 2, 3 Revision bc50bb9...

Graphics

Gilles Caulier committed changes in [digikam] /:

Apply patch #65631 to prevent Overexposure with Withe Balance adjustement.
Modify patch to always compute RGB multipliers over original image in case of preview rendering in image editor.
Use more private internal container plus code polish

Gilles Caulier committed changes in [digikam] /transform:

Ratio Crop Tool is now able to display Histogram from selected region to crop

Gilles Caulier committed changes in [digikam] /transform:

Aspect Ratio Crop tool : new section to display crop information. Currently resolution of cropped image in Mpx

Gilles Caulier committed changes in [digikam] /dimg/filters/bw:

add Kodak HIE infrared filter to the list of B&W analog films simulated by digiKam black and white Image editor converter.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 9f0b7b4...

KDE Base

Alexey Chernov committed changes in [kdelibs/KDE/4.7] /kio:

Pretty resize RenameDialog form to show more information

Several fixes to make RenameDialog look prettier and show more
information if it's possible.

What's done:
- new private slot added to resize information scroll area after
metadata for items is fetched
- preview job is deferred to the moment when metadata is fetched
to show it a little bigger according to updated size of metadata

REVIEW: 103160

Marco Martin committed changes in [plasma-mobile] applets/active-welcome/contents/code/welcome.qml:

switch pages with a drag gesture

Martin Gräßlin committed changes in [kde-workspace/screenlocker] /greeter:

Support for Caps Lock warning in Greeter

Same event filter needs also to be installed in the Plasma Overlay.

Diffs: 1, 2, 3, 4 Revision 2765cd9...
Aaron J. Seigo committed changes in [kdelibs/frameworks] /:

massive step towards QGraphicsView being separated from libplasma

* remove extenders (never panned out, used by exactly two components that we can find .. anywhere)
* move animations to libplasmagqv
* schedule js anims to be put into the js scriptengine
* move all QGraphicsProxyWidgets, except for IconWidget which is still used by PopupApplet, into libplasmaqgv
* create a subclass-able private class for Applet

TODO: move out icon widget, address FIXMES in graphicswidgetappletprivate.cpp and decide how to register the "right" private class for instantiation in Applet ctors

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 38 more) Revision 37643a9...
Martin Gräßlin committed changes in [kde-workspace/screenlocker] plasma/screensaver/shell/qml/lockscreen.qml:

Add session switching to Plasma Overlay

Sebastian Kügler committed changes in [plasma-mobile] applications/settings/modules/web/contents/ui/Web.qml:

UI for setting start page, adblock and history

Only half-kinda-works, but good progress. It currently writes to the
wrong configgroup, that's something to be streamlined in the
webbrowser's config, or we just use separate objects for the different
config groups.

Sebastian Kügler committed changes in [plasma-mobile] /mobilecomponents:

Add ActivateAnimation to mobilecomponents plugin

Animation itself is not very good yet, but allows us to steer this in a
central place.

Martin Gräßlin committed changes in [kde-workspace/screenlocker] /:

Support Plasma Active lockscreen

A new config option is added to specify the main qml file used
by the greeter. The Active lockscreen qml is imported and works
together with the greeter.

Diffs: 1, 2, 3, 4 Revision d84ecfa...

KDE-PIM

Torgny Nyblom committed changes in [kdepim] /:

Add support for multipart/related messages

Add support to templateparser for handling inline images.

Office

C. Boemann committed changes in [calligra] libs/kotext/styles/KoCharacterStyle.cpp:

Let's support embedded fonts too ! Have fun showing off at the plugfest :)

Lukáš Tvrdý committed changes in [calligra] /plugins/tools/defaulttools:

Add and use new multihand icon

Icon created by Animtim

Matus Uzak committed changes in [calligra] /:

docx: Write text-properties only in case of empty paragraphs.

* From MSWord point of view the text-properties in a paragraph style are meant for
the paragraph mark and should not be used to format any of the text chunks.

* text-properties of the paragraph mark are used to format the list label, so they
are part of the inheritance hierarchy, which I broke at the moment.
I will fix it ASAP.

* Sync with the DOC filter.

Matus Uzak committed changes in [calligra] /words/docx:

docx: paragraph/text styles inheritance Kung Fu

* Let's set line-height=100% in the default paragraph style if the corresponding part
of the w:spacing element is not provided.

* Do not interpret a default named style (w:default attribute in the w:style element)
as additional information for the defaults. The "Normal" style for example on top
of the defaults was applied to any paragraph which was not correct. Then finally
the corresponding style referred by a paragraph was applied. So the "Normal" style
messed up the formatting.

* Any paragraph and text chunk that does not provide the style information should used the
corresponding default named style (w:default attribute in the w:style element).

* paragraph/text styles for footnotes/endnotes belong into content.xml, not styles.xml
and also make use of the default named styles.

* headers/footers also make use of default named styles.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 38f3390...
C. Boemann committed changes in [calligra] /:
Aakriti Gupta committed changes in [calligra/stage-singlecanvas-aakriti] /:

Added setHeader method to svgwriter to add a customized header according to application creating the svg

Diffs: 1, 2, 3 Revision 4341163...
Pierre Ducroquet committed changes in [calligra] /cstester/visualimagecompare:

visualimagecompare: support for viewing PDFs

We generated PDFs for almost every document in our document pool.
Now, this patch allows us to display them directly in visualimagecompare.

Usage :
- launch visualcompare with the --pdf /home/of/pdfs option
- key P will switch from/to the PDF view
- buttons +/- allow to navigate in the PDF (if there is an offset between
the pages we generated and the PDF pages)

If you want that feature, you must compile visualimagecompare with poppler.

Diffs: 1, 2, 3, 4, 5, 6 Revision 33ea04b...
Dag Andersen committed changes in [calligra] /libs/models:

Use calendar popups for all datetimes

Boudewijn Rempt committed changes in [calligra/kotext-inlinecommand-rempt] /:

Create a command for inserting an inline object

Inserting inline objects was not undoable. Creating a shape was. Undoing
the creating of shape without undoing the creating of an inline object
that refers to the shape, like an anchor, leads to crashes when the
undo action command gets deleted.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 7ea809e...

Networking Tools

Francesco Nwokeka committed changes in [telepathy-presence-dataengine/telepathy-] /:

Added extended away support

Diffs: 1, 2, 3, 4 Revision 2db96e7...
Andrea Diamantini committed changes in [rekonq/SyncRebased4] /:

let history, bookmarks and passwords sync on change (first bits)

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 54032af...
Francesco Nwokeka committed changes in [telepathy-presence-dataengine/telepathy-] global/globalpresencesource.cpp:

add global presence message

Anthony Vital committed changes in [wicd-kde] /:

NetworkPropertiesDialog refactoring.

Diffs: 1, 2, 3, 4, 5 Revision 9ceb2c3...
Joris Guisson committed changes in [ktorrent] /:

Suspend/resume queue when middle clicking on tray icon

Martin Klapetek committed changes in [telepathy-accounts-kcm] /:

Use dialog-less setup for link-local xmpp (salut)

Reviewed-by: Dario Freddi
REVIEW: 103117

David Edmundson committed changes in [telepathy-presence-applet] /:

Removed right panel and added Extended Away status

Diffs: 1, 2, 3, 4, 5, 6 Revision d75e6c3...

User Interface

Cristian Oneț committed changes in [kmymoney] /views:

Display the balance of a budget. I would have liked to have this information several times while creating a budget.

REVIEW: 103134

Diffs: 1, 2, 3 Revision 491daa8...
Hugo Pereira Da Costa committed changes in [kde-workspace] kstyles/oxygen/oxygenstyle.cpp:

enable hover effect on sunken scrollareas that supports focus.

Utilities

Matteo Agostinelli committed changes in [cirkuit] /:

Improve positioning of the message widget

The popup message widget is now centered both horizontally and
vertically over the image preview. The WidgetFloater class has been
borrowed from GwenView.

Props to Aurélien Gâteau for writing the class and suggesting to use it.

Diffs: 1, 2, 3, 4, 5, 6 Revision bd13a28...
Raphael Kubo da Costa committed changes in [ark/KDE/4.7] /:

Use the RPM support detection code from f8a2d09 in master.

*sigh* It looks like in the conversion from svn to git the changes to
FindLibArchive.cmake in SVN r1209188 which defined LIBARCHIVE_VERSION
were did not make it to git.

This means the version check always failed and Ark always thought
libarchive did not have RPM support...

Other

Valentin Rusu committed changes in [ksecrets] /:

Placing libksecretsservice in the ksecrets repository

See the kde-core-devel for context information about not putting this
into the kdelibs branch 4.7.

The code was reviewed by Albert Astals Cid and by Kevin Krammer at
the time it was in kdelibs.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 24 more) Revision 8bf0445...

Optimization

KDE Base

Sebastian Trueg committed changes in [nepomuk-core/symlinkHandling] /storage:

Better duplicate merging in storeResources

This is an inefficient way of doing this, but it's better than not
having duplicate merging at all.

The problem is finding duplicates in the graph provided when those
resources do not already exist in the repository. Previously, we
used to hash each of the resources, check for duplicates, and then
merge. Then we would perform the whole identificiation & merging
code.

This suffered from the draw back that it would not recognize
duplicates of the form -

:a a nco:Contact ;
nco:fullName "Peter" ;
nco:hasEmailAddress :b .

:b a nco:EmailAddress;
nco:hasEmailAddress "" .

:c a nco:Contact ;
nco:fullName "Peter" ;
nco:hasEmailAddress :d .

:d a nco:EmailAddress;
nco:hasEmailAddress "" .

Here :d and :b would be found as duplicates, but :a and :c would not
as their nco:hasEmailAddress property is different, and therefore
the hash would be different.

This has been solved by looking for duplicates multiple time. So, the
code is something like this -

do {
// Look for duplicates using hashing
// merge the duplicates

} while( there are duplicates );

// continue with the identification and merging process

Also added a unit test.

Diffs: 1, 2, 3, 4 Revision 8d23f36...
Dawit Alemayehu committed changes in [kwebkitpart] /:

Workaround QtWebKit's propensity to emit the loadFinished signal multiple
times causing kwebkitpart to unnecessarily perform rather CPU intensive
actions like filling forms on a page over and over again.

Sebastian Kügler committed changes in [plasma-mobile] /settings:

Writing of config entries entries

When writing an entry, a 5 second timer is started until the config is
synched, this also compresses multiple config changes in quick
succession into one sync event.

This seems to work quite well already for clearing the browser's history
and enabling / disabling adblock. The webbrowser doesn't correctly
reload history while running, it reloads but reads the old config
apparently, so the history isn't cleared until restart.

Diffs: 1, 2, 3, 4 Revision 45515df...

KDE-PIM

Torgny Nyblom committed changes in [kdepim] templateparser/templateparser.cpp:
Allen Winter committed changes in [kdepim/KDE/4.7] libkdepim/progressmanager.cpp:

add a crash and sanity check in removeChild() in case the child map
is empty or the specified item to remove is not in the map.

might fix bug 258080.
but can't know for sure since I can't reproduce.
appreciate testing by those affected by the crash.


(cherry picked from commit f8c0f7eed9fa980ad31856d28266c2612e994cf0)

Torgny Nyblom committed changes in [kdepimlibs] kpimtextedit/textedit.cpp:

Don't try and embed remote images

Office

Dag Andersen committed changes in [calligra] /:

Qt 3 support gone

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 9fdfab9...
C. Boemann committed changes in [calligra] /:

Handling the fact that qt insists on having a paragraph in front of tables.

The solution is not to try and remove it (because we can't) but to make
sure there is always an extra empty paragraph in front of a table. The paragraph
is sort of hidden and only shows up as a cursor position to the left of the table

Diffs: 1, 2, 3, 4, 5, 6 Revision 4918636...
Yue Liu committed changes in [calligra/libs-connectionrouting-yue] /:

Merge branch 'master' into libs-connectionrouting-yue

Multimedia

Raphael Kubo da Costa committed changes in /trunk/KDE/kdemultimedia/CMakeLists.txt:

Remove the optional dependency on libxine from kdemultimedia.

r1253879 made Dragon libxine-free, and nothing else depended on it.

REVIEW: 6826

Bart Cerneels committed changes in [amarok] /:

Don't block the UI while scanning UMS device.

Diffs: 1, 2, 3, 4 Revision cf52f1a...

Networking Tools

Andrea Diamantini committed changes in [rekonq/SyncRebased4] /:

BookmarkProvider --> BookmarkManager

We have 7 managers and 1 provider... finally fixing this strange
thing!

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 7f95c27...

Other

Andrea Diamantini committed changes in [rekonq] src/rekonq.kcfg:

Adblock disabled by default for 0.9

This was an initial misconception on adblock use (moreover considering
it is our worst bottleneck...)
If you wanna it, just enable it on your own...