Issue 214

18th December 2011 by KDE Commit-Digest Team


Vladislav Blanton
Jaka Kranjc
Marta Rybczynska
Paulo Dias
Danny Allen

This Week...

In Calligra, extended undo/redo functionality, updated Excel 2000/2003 support, optimization of formula parsing and numerous bugfixes. Kmix now shows MPRIS2 streams. More useful capacity bar when hovering collection in Amarok. Work on import feature in Umbrello. Command line parameters support in kmail-mobile. Incremental fetching of GAL in Akonadi.


Commits 1720 by 183 developers
Open Bugs 22106
Open Wishes 17262
Bugs Opened 512 in the last 7 days
Bugs Closed 876 in the last 7 days

Commit Summary

Module Commits
Files Developer Commits
Gilles Caulier
Ralf Habacker
Laurent Montel
MohamadReza Mirdamadi
Aaron J. Seigo
Marco Martin
Lamarque Souza
Albert Astals Cid
Yuri Chornoivan
Dennis Nienhüser

Internationalization (i18n) Status

Bug Killers

Person Bugs Closed
Gilles Caulier
Peter Penz
Jekyll Wu
Dawit Alemayehu
Andrea Diamantini
sebsauer kdab com
Aaron J. Seigo
Thijs Heus
Christoph Feck
Myriam Schweingruber

Commit Countries

Commit Demographics




  Bug Fixes Features Optimization Security Other



Development Tools

[] [] []   []




[] []    []

KDE Base

[] []    []


[] [] []   


[] [] []   




[] []    []

Networking Tools

[] [] []   []

User Interface





[] []    



There are 102 selections this week

Bug Fixes

Development Tools

Aleix Pol Gonzalez committed changes in [kdevelop] projectmanagers/cmake/parser/cmakeast.cpp:

Fix OptionAST precondition.


Albert Astals Cid committed changes in [okular] part.cpp:

Use a queued connection instead of direct call

It seems some shells (like konqueror and kile) are too smart and play with the focus and the focus ends up in the wrong place because they "overwrite" our setFocus call, now we workaoround that by using the queuedconnection

FIXED-IN: 4.8.0

KDE Base

Aaron J. Seigo committed changes in [kde-workspace] /desktop/shell/activitymanager:

manager the lifespan of the icon dialog to match that of the activity icon

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Update the roles if items have been changed

The code "// TODO..." in slotItemsChanged() obviously was not
sufficient ;-)

FIXED-IN: 4.8.0

Dario Freddi committed changes in [kde-workspace] powerdevil/daemon/actions/bundled/brightnesscontrolconfig.cpp:

The slider should react whenever the value changes, and not just on move.

Thanks Amos Kariuki for suggesting the fix

(cherry picked from commit 57307a33f3cd6872c9f136e47b13336560f2ab5c)

Dawit Alemayehu committed changes in [kde-runtime] /:

Changed maxInstances property to 20 and maxInstancesPerHost to 5.

Dawit Alemayehu committed changes in [kdelibs/KDE/4.7] kio/kfile/kpropertiesdialog.cpp:

* Use KIO::copyAs and KIO::moveAs to rename/move files so that the
user is properly prompted when an existing name is used.

* Changed assert calls to Q_ASSERT calls.

FIXED-IN: 4.8.0

Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqmainwindow.cpp:

Do not enable the "Link View" action initially.

FIXED-IN: 4.8.0

Marco Martin committed changes in [kde-workspace] plasma/desktop/shell/panelcontroller.cpp:

use font metrics to decide if the text is enabled

using the kayout size hint causes a loop because the hint will be smaller when the text is off

John Layt committed changes in [kdelibs/KDE/4.7] /:

KLocale: Fix readNumber() and readMoney() for lenient group parsing

Restore the old pre-4.7 behaviour of accepting as valid any numbers
that do not contain any group separators but strictly enforce group
rules when the number contains 1 or more group separators.

Distro's will really want to backport this fix to all versions of 4.7
as previously number entry for all KDE apps would have been seriously

I'm amazed I wasn't beaten up for this earlier!

FIXED-IN: 4.7.5

Marco Martin committed changes in [kde-runtime] /declarativeimports/core:
Aaron J. Seigo committed changes in [kdelibs/KDE/4.7] /:

delay showing popups until the next processing of events

allows things like hidden panels to show before calculating where to show the popup

Lamarque Souza committed changes in [plasma-mobile] applications/about/package/contents/ui/FlickableWebView.qml:

Open links in external browser instead of loading then in about app's

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Fix several sort-issues

- Treeview: When sorting descending assure that the parent item is still
ordered before the child items and not afterwards.
- Treeview: When sorting by other roles than names expansionsLevelCompare()
had been buggy and resulted in ordering child items below wrong parent
- General: When sorting by another role than names and the role of
two items had been equal a case sensitive sorting of the names had
been done. This has been fixed by using the default name sorting
as fallback.

FIXED-IN: 4.8.0

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/kitemviews/kitemlistcontroller.cpp:

Start an anchored selection when clicking a selection marker


Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqview.cpp:
Thomas Lübking committed changes in [kde-workspace] kwin/composite.cpp:

fix gravitation after compositor "polluted" it by updating the decoration _before_ placement

REVIEW: 103391


Allen Winter committed changes in [kdepim] messagelist/core/view.cpp:

in messageItemBefore(), in the case that there is no current item
and starting from the deepest item, make sure that deepest item
has a parent else there will be a crash.

FIXED-IN: 4.8.0

Laurent Montel committed changes in [kdepim-runtime] agents/maildispatcher/sendjob.cpp:

Start to fix Bug 282721 - no filtering on sent mails


Laurent Montel committed changes in [kdepim] kmailcvt/filter_pmail.cxx:

Fix Bug 289100 - Pegasus Mail Import crashes regularly in kmailcvt


Allen Winter committed changes in [kdepim] calendarviews/eventviews/agenda/timescaleconfigdialog.cpp:

First part of the fix for bug 285118:
- when creating the initial list of choices for the combobox, exclude
those timezones we are already have chosen from user prefs
- when adding a view timezone, remove that from the combobox choices
so the user can't add it again
- when removing a view timezone, add that back to the combobox choices


Boudewijn Rempt committed changes in [calligra] krita/image/

KisSelection: delete default bounds object if it hasn't a parent

It's conceivable that a selection is createde but never used, in which
case the default bounds object isn't passed to to a pixel selection,
in which case it doesn't have a parent, and isn't deleted.

So if the defaultbounds object doesn't have a parent, explicitly delete it.

Sven Langkamp committed changes in [calligra] /plugins/extensions/dockers/advancedcolorselector:

add workaround to prevent color chooser to jumb to state that was used before picking a color
Adam please check

Sebastian Sauer committed changes in [calligra] /part:

Fix crash if either the Sheet or the SheetView got destroyed without letting the View know about it.
This commit makes sure we proper remove the Sheet and it's associated SheetView from the sheetViews-QHash the View holds if the Sheet is deleted. Also it makes sure that if the SheetView is deleted then we proper set it to NULL so we do not deal with dangling pointers what would lead to a crash latest if the View itself is destroyed.

Boudewijn Rempt committed changes in [calligra] /plugins/tools:

Disable the per-input-device switch of krita tools

I already (in eab5746f9f94b48f67ec20cc6d28e9221c53fef1) disabled the
switching of tools when switching input devices. This patch makes sure
we don't create tools for new input devices either, which fixes a problem
with the tool action shortcuts being reset to default when switching between
mouse and tablet.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 55452f8...
Marijn Kruisselbrink committed changes in [calligra] tables/ui/RightToLeftPaintingStrategy.cpp:

don't crash in the RTL painting strategy if the canvas is qgraphicsview based

Silvio Heinrich committed changes in [calligra/words-fix_double_image-silviohe] /part:

Fix writing one image tag twice to an odf document.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 46f4423...
Sebastian Sauer committed changes in [calligra] libs/kotext/opendocument/KoTextWriter_p.cpp:

Fix mem-leak.
Don't leak the just created new auto-KoCharacterStyle which is only temporary used to generate a proper auto-style while saving the QTextCharFormat.
The mem-leak was introduced in e66889d566e.

Robby Stephenson committed changes in [tellico/2.3] /:

Fix importing and exporting of multi-line note fields using Alexandria

Tellico was not using the YAML multi-line scalar correctly.

FIXED-IN: 2.3.5

Sebastian Sauer committed changes in [calligra] libs/kotext/styles/KoCharacterStyle.cpp:

Fix styles are changed during saving.
This is especially fatal if the used KoCharacterStyle is the default KoCharacterStyle in which case we modify the character-style properties in a rather random way just because we try to save the content.
The bug was introduced with commit e66889d566e. Verified that bug 260115 the commit fixed is not reopened and things still work as expected.

Jan Hambrecht committed changes in [calligra] plugins/defaultTools/defaulttool/ShapeResizeStrategy.cpp:

guard against resizing shapes in the direction where the shape size is zero

Cristian Oneț committed changes in [kmymoney] kmymoney/converter/mymoneygncreader.cpp:

Disable MyMoneyFile signals while we import a GnuCash file.

This is needed to avoid updating views while the import is not
finished and the data in the MyMoneyFile is not ready to be used.

Sebastian Sauer committed changes in [calligra] /:
Boudewijn Rempt committed changes in [calligra] /kotext:

Do not create rdf objects if the xml:id doesn't start with rdfid-

Following the deprecation of draw:id and text:id, elements that used to
just save draw:id and text:id now also save these id's as xml:id.

Calligra's rdf support thinks that every xml:id is a reference to some
rdf metadata. This breaks because there _is_ no rdf data associated.

Until I've found a proper solution to shared xml:id's between various
parts of calligra, check whether the xml:id starts with rdfid- and only
then load the metadata.

Yes, this probably means we can no longer load documents with rdf saved
by other applications like abiword. I'm working on a "proper" solution.

Diffs: 1, 2, 3 Revision c8277fb...
Sebastian Sauer committed changes in [calligra] filters/tables/xlsx/XlsxXmlCommonReader.cpp:

Fix italic and underline default values.
The spec says for them "If omitted, the default value is true." what means it's italic/bold if val is not defined.
One step closer to fix bug 286158. But there still seems to be a problem with Tables not proper rendering/diplay bold fonts.


Matěj Laitl committed changes in [amarok/strohel-for-2.6] /:

media device collection: get rid of CustomReadCapability - was unused

Since Bart ported UMS, this class was not instantiated anywhere, so
remove the cruft.

Diffs: 1, 2, 3, 4, 5, 6 Revision 4a77c01...
Matěj Laitl committed changes in [amarok] /:

Fix bogus logic when opening KWallet in configuration

The logic is still a bit convoluted, but at a last-minute fix this
suffices and should introduce no problems.


Matěj Laitl committed changes in [amarok] /:

iPod handler: do not crash when master playlist is null

This is a late fix for bug 288936. I've added i18n( "Unknown" ) during
string freeze, but this exact string is already used elsewhere.

Sorry for such a last-minute commit, but this was an easy crashfix.


Networking Tools

Dario Freddi committed changes in [telepathy-presence-applet] /:

Fixed memory leak craeted by actions

new actions were created every time the context menu was called. Now context menu is created
immediatly and kept only once in memory

Andrea Diamantini committed changes in [rekonq/Branches.0.8] src/iconmanager.cpp:

Do NOT search for (probably) non extant favicons

also use KIO::copy instead of KIO::file_copy to delegate file
management to KIO

This should hopefully fix||workaround HTML code shown bug. Anyway,
I cannot understand why KIO merges the two different jobs data together

Andrea Diamantini committed changes in [rekonq] src/urlbar/urlresolver.cpp:

show history entries also when no favorite search engine is set

Bug investigation and courtesy patch by Gabo Menna.
Many thanks for :D


Rolf Eike Beer committed changes in [kgpg] /:

put compression and encryption of a folder into a KJob

This fixes an empty KPassivePopup showing up in the top left of the screen,
which is a remnant of KDE 3.5 days. It also improves the feedback to the user
on what's happening a lot.

And while at it this also fixes a couple of memleaks and other stuff.



Ian Wadham committed changes in /trunk/KDE/kdegames/ksudoku/src/gui/views/view2d.cpp:

FIXED IN: KDE SC 4.8 Ensure that markers are displayed after a Load action.

Christian Krippendorf committed changes in /trunk/KDE/kdegames/kmahjongg:

REVIEW: 6839

Fixes selecting the wrong stone if clicking on a shadow of a stone.


Nick Shaforostoff committed changes in [polkit-qt-1] /:

use stricter refing in all places of 'identity' keeping.
it is interesting that it would be much harder
to accidentaly make same mistake if G API was C++ style and not C.

i also moved cleanup of successful sessions in time from system shutdown
to session completion as polkit docs say it should be


Development Tools

Ralf Habacker committed changes in /trunk/KDE/kdesdk/umbrello/umbrello:

added import feature

If enabled in the new code import settings page for each imported c++ file
an artifact will be created in the component view.
The rational of this feature - when it is completed - is to generate files
completly from the parsed content including file header comments and the
exact collection of which classes belongs to a file.

To achieve this, a new class FileAST has been created, which holds all
file related informations not fitting into other declarations.

The implementation creates artifacts with the raw file name because there
are problems in Model_Utils::findUMLObject searching full pathes.

To complete this feature the following is to do:

- UMLArtifact has to be extended to hold uml objects collected for this file.

- ArtifactWidget has to be extended to let users editable the lists provided
by UMLArtifact.

- The parser should add the collected uml objects to the related UMLArtifact

- The artifacts in the component view should be structured into folders using
abolute pathes or based on the import root (switchable in the code import
settings page)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 10 more) Revision 1268827
Ralf Habacker committed changes in /trunk/KDE/kdesdk/umbrello/umbrello/umllistview.cpp:

a try to implement iteration over the list view items using keyboard

Aleix Pol Gonzalez committed changes in [kdevelop] projectmanagers/cmake/parser/cmakeprojectvisitor.cpp:

Add support for properties appending in set_property.

David Narváez committed changes in [kdevelop] /kdeprovider:

Replace Projects QComboBox by Filtered QListView in KDE Provider

It should help developers find projects faster

REVIEW: 103383
GUI: QComboBox now replaced by a filtered QListView


Riccardo Bellini committed changes in [bookmanager] /:

Create a dialog to modify one or more books.

Class ModifyDialog allows the user to edit data of one or more than
one book. Special "Previous" and "Next" button are provided,
to navigate through the entries.
There is also a checkbox which allows the user to edit multiple kind
of data at the same time, for all selected books.

Signed-off-by: Riccardo Bellini

Diffs: 1, 2, 3, 4, 5 Revision fbf7ee8...


Gilles Caulier committed changes in [digikam] /dmetadata:

new wrapper to extract ISO speed info from more tags, especially makernotes

Gilles Caulier committed changes in [libkdcraw] /:

update internal libraw to 0.14.4 release :
- Fixes to Panasonic/Leica file parser to prevent crash on broken jpegs.
- Fixes to include order in src/libraw_datastream.cpp to better compile with KDEWIN
- Floating-point DNGs are rejected on early processing stage.
- Support for new cameras: Canon S100, Fuji X10, Panasonic GX1, Samsung NX200, Sony NEX-7.

Diffs: 1, 2, 3, 4, 5, 6 Revision 6d999b0...
Gilles Caulier committed changes in [digikam] /:

in icon-view mode, zoom button named "Fit to Window" can be used now to fill all icon rows with thumb contents automaticaly. The right thumbs size is computed accordingly with space available...

Gilles Caulier committed changes in [digikam] /dialogs:

delete dialog is now able to display thumbnails of items to delete

KDE Base

Lamarque Souza committed changes in [kde-workspace/ksmserver/qml-shutdowndlg] /themes/default:

Add keyboard navigation support to qml-shutdowndlg. Use the TAB key to
nagivate between the buttons and the ENTER key to trigger the action. I
was not able to make the first button be the "zero TAB key". You have to
press TAB once to make the first button the first TAB key and a second
time to go to the second button.

Thomas Lübking committed changes in [kde-workspace] /:

add support for graphicssystem selection

REVIEW: 103430

Aaron J. Seigo committed changes in [kdelibs/KDE/4.7] /:

allow controlling the resize a bit more

this allows e.g. popupapplet to put constraints on where the edges of the window can resize to
and react differently when the user is actively resizing the dialog.

Thomas Lübking committed changes in [kde-workspace] /effects/highlightwindow:

Highlight window: support minimized windows

- replace QHash::operator[]
- replace double by float (-> ARM, and we don't need that precision)
- weaken some value checks ("== 1.0f")
- fix last paint of hiding windows (w->addRepaintFull() trap)

REVIEW: 103404

Nicolas Lécureuil committed changes in [kdelibs/frameworks] /tests:

Port to QTemporaryDir

Diffs: 1, 2, 3, 4, 5, 6 Revision 882b091...


Allen Winter committed changes in [kdepim] plugins/messageviewer/bodypartformatter/application_ms-tnef.cpp:

Inline TNEF support is Back!
The separate MS-TNEF viewer tool 'ktnef' is gone so

in format():
- don't ever return with AsIcon since we no longer have ktnef
- don't make winmail.dat a hyperlink since we no longer have ktnef
- deal with empty TNEF attachments -- keep a placeholder in the
message to show that we do have an attachment, albeit an empty one.
this is ugly, but probably best not to make the user think that
the attachment is lost somehow.
in subtype():
- support subtype

Torgny Nyblom committed changes in [kdepim] messagecore/stringutil.cpp:
Dan Vratil committed changes in [akonadi-google/v0.3] /:

Refactor and rewrite KGoogleAuth and AuthDialog.

KGoogleAuth is now KGoogle::Auth (in auth.h and auth.cpp). It
supports multiple Google accounts and acts as a frontend to a
secure storage (KWallet in this case). It still provides methods
for authenticating new accounts or refreshing access tokens to
an existing one, the API is much more simple and straightforward though.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 0298d83...
Lamarque Souza committed changes in [kdepim] /:

Add command line parameters support to kmail-mobile.

REVIEW: 8985

Shaheed Haque committed changes in /trunk/playground/pim/akonadi/exchange:

Migrate Contacts resource:

1. Support the user's personal Contacts as well as the GAL.

2. Design in support for incremental fetching of the GAL. This
does not work yet; only the first 100 items are fetched.

3. Rebase on MapiResource.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 1268880
Shaheed Haque committed changes in /trunk/playground/pim/akonadi/exchange:

Implement incremental fetching of GAL.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1268986
Dan Vratil committed changes in [akonadi-google/v0.3] /:

Introduce KGoogle::Account class and common.h

This class represents a single Google account, holds authentication tokens
and list of scopes the tokens are valid for.

Introduce common.h as header with common values and objects. For now it
contains KGoogle::Error enumarator and few basic exceptions

The "KGoogle" in name was dropped since all classes are in KGoogle namespace
so there is no need to have KGoogle::KGoogleSomeClass.

Diffs: 1, 2, 3, 4 Revision 70f7a62...


Smit Patel committed changes in [calligra/words-references-bibliography-s] /kotext:

1) support for sorted bibliography

2) using default entry templates instead of creating one in BibliographyGenerator

Sebastian Sauer committed changes in [calligra] plugins/chartshape/Axis.cpp:
Silvio Heinrich committed changes in [calligra/pictureshape-filters_and_croppi] /pictureshape:

Extend undo/redo functionality.

Extend the ChangeImageCommand class to be able to undo/redo changes
done to the cropping area and the color mode.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 48583b4...
Robby Stephenson committed changes in [tellico/2.3] /:

Updated to use DIscogs API v2

Some deprecated endpoints are still used, in order to have XML
results. Full usage of API v2 will require using JSON.

Diffs: 1, 2, 3 Revision 497ab6a...
Jörg Ehrichs committed changes in [conquirere/syncstorage] /:

allow adding zotero contacts to akonadi

Diffs: 1, 2, 3, 4 Revision 4c57e4f...
Sven Langkamp committed changes in [calligra] /:

if file already exists, save resource with a new name

Sebastian Sauer committed changes in [calligra] /tables/excel:

Implement rich-text support for table-cells for Excel 2000/2003 documents.

Lukáš Tvrdý committed changes in [calligra] /libmsooxml:

Add support for draw:text-areas in msooxml autoshapes

Tested with cstester. No regression found, only positive changes.

Thomas Baumgart committed changes in [kmymoney] /:

Highlight the online statement balance if different from current file balance

REVIEW: 103264


Sven Krohlas committed changes in [amarok] /:

Amazon store artwork, part 1: logo and emblem

Thanks to "Fabi" (whatever your real name is).

To make them show up I had to delete some caches:

So if the icons don't show up try that.

"since i dont know much about licences.. choose whatever you want :)"
So we make that GPLv2.1 or later.

M +- -- src/images/emblem-amazon.png
M +- -- src/images/icons/hi16-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi22-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi32-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi48-action-view-services-amazon-amarok.png

Christian Esken committed changes in /trunk/KDE/kdemultimedia/kmix:

Show and remove MPRIS2 Streams (Stream hotplugging)

Christian Esken committed changes in /trunk/KDE/kdemultimedia/kmix/backends/mixer_alsa9.cpp:

INital try to fix missing controls. Needs verification from affected users.

Matěj Laitl committed changes in [amarok/strohel-for-2.6] /:

Collection browser: show absolute free space on hover, thicker bar

For collections that support capacity (iPod, UMS, MTP), change text on
capacity bar from "80% used" to "1,2 GiB free". Rationale:
* relative emptiness is already indicated using bar
* absolute free space is the most relevant information when
transferring tracks
* this is consistent with Dolphin

Additionally, the capacity bar is made thicker and the font is non-bold
so that the font is readable when rendered on it. (this is done by
using KCapacityBar's minimumSizeHint() - however it is bounded between
MIN and MAX values)

This may be a little controversial change of the look, here are some
screenshots, speak up if you don't like it:
* before:
* after:

DIGEST: feature: more useful capacity bar when hovering collection

Diffs: 1, 2, 3, 4 Revision 293caa0...

Networking Tools

Martin Klapetek committed changes in [telepathy-kded-module] /:

Enable setting presence message for auto-away

Reviewed-by: Dario Freddi
REVIEW: 103417

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 54a4839...
Andrea Diamantini committed changes in [rekonq] CMakeLists.txt:

rekonq 0.8.56

- sync! (just with ftp sites for now...)
- bookmarkprovider --> bookmarkmanager
- docs --> doc
- etc...

DIGEST: sync feature merged in rekonq master

Dominik Cermak committed changes in [telepathy-common-internals] /Models:

Add filtering for filetransfer-capability and make filtering more generic

Add the possibility to filter for contacts with filetransfer capability
as it is needed for send-file.
Filtering for name now respects showOfflineUsers.

REVIEW: 103409

Martin Klapetek committed changes in [telepathy-send-file] /:

Add a filter bar to quickly find contacts

REVIEW: 103390

Daniele E. Domenichelli committed changes in [telepathy-text-ui] app/chat-window.cpp:


Christian Krippendorf committed changes in /trunk/KDE/kdegames/kmahjongg:

REVIEW: 6837

After shuffle the stones because no moves left, you will now get a dialog about "No moves left" if the game isn't solvable.


Development Tools

Michael Pyne committed changes in [kdesrc-build] /:

Improve split_quoted_on_whitespace.

Apparently Perl has included (since version 5.0, no less) a module that
handles almost the exact case split_quoted_on_whitespace exists for.

The impetus for this is that the '${MODULE}' syntax for dest-dir is
apparently broken due to problems with the mixture of braces and quotes
in split_quoted_on_whitespace.

This change does not break the test suite (but does add a relevant test)
and does seem to fix the issue with strings with braces.


Shaheed Haque committed changes in /trunk/playground/pim/akonadi/exchange:

Improve performance by:

1. Eliminate use of strings for ids in mapiconnector2.

2. Use the shortest/densest string format when storing ids in Akonadi.

Also, move the implmentation of MapiItem into the .cpp file.

Diffs: 1, 2, 3, 4 Revision 1268377


Jan Hambrecht committed changes in [calligra] karbon/ui/dockers/KarbonLayerModel.cpp:

use official icons for visibility

Thorsten Zachmann committed changes in [calligra] /chartshape:

Don't initialize ChartShape with default values

to then just overwrite them in loading. This speeds up loading by
30%-50%. The worldmapper file does load with that change 5 seconds
faster 25 seconds comared to 30 seconds.

Sebastian Sauer committed changes in [calligra] /:

Improve performance while scrolling around the sheet attached to bug 281910.
Intel's VTunes shows 3 hotsports. This commit fixes two of them. The theird and yet not fixed case is CellStorage::isPartMerged which does an expensive RTree-lookup. Probably we should cache that info?

Thorsten Zachmann committed changes in [calligra/tables-optimize-loading-zachman] /:

Optimize formula parsing by a factor of 2-4

This optimizes formula parsing by a factor of 2-4. The file
loads now in 25 instead of 30 seconds.

The patch tries to avoid creating QString objects when not necessary and reuse
QString object when possible. The reduces the number of allocations quite a lot.
Also implicit casts of 'x' and "foo" are avoided where ever possible as these
are also quite expensive.

e.g. some of the easy optimizations are

if (QString::operator[0] == '$')

is better written as

if (QString::operator[0] == QChar('$', 0)

as this can be optimized already be the compiler and thus reduces the stuff needed

Also initialize class members in initialization list of the constructor where possible
as this avoids copying the data a second time which is also expensive if it is e.g. a

Additionally to the speed up also the formula parsing now can recognice a escaped " in
a formula and parsing of error codes has been updated to follow ODF 1.2. This fixes the
failing unit tests in TestFormula.

Added unit test for decodeFormula.

This code also contains some debug code to check that the new results is actually the
same as the old results. Due to the fixes in the formula parsing that might no longer
be true for some of the formulas. This check will be removed in the next commit so that
it is easy to get it back if more testing is needed. When running against a set of ods,
xls and xlsx it showed no difference before fixing the formula parsing.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 85efba9...

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/urlbar/urlresolver.cpp:

minor startup speed improvement (QL1C && QL1S)


Development Tools

Aleix Pol Gonzalez committed changes in [kdevelop] /cmake:

In cmake, Don't reuse declarations if they are not in a cmake script.


Gilles Caulier committed changes in [digikam] /date:

usability issue : use whole timeline cursor to make date selection, and not only bottom sqare.


KDE Base

Anne-Marie Mahfouf committed changes in [kde-workspace] libs/plasmaclock/calendarConfig.ui:

Make string more understandable for users

Users confused Kontact events with holiday events.
Got the permission from i18n

T.C. Hollingsworth committed changes in [kdelibs/KDE/4.7] kdoctools/customization/kde-include-common.xsl.cmake:

get rid of 'title' attribute in DocBook generated HTML
fixes annoying tooltips in KDE documentation


David Faure committed changes in [kdelibs/frameworks] staging/libkarchive/autotests/CMakeLists.txt:

No need to link to kdecore anymore

Sebastian Trueg committed changes in [nepomuk-core] /:

Use a QApplication and a KComponentData instead of a KApplication.

This removes the KApplication DBus interface which allows us to
control how the services are shut down, ie. deleting the service itself
before shutting down the QCoreApplication.


Sven Krohlas committed changes in [amarok] /:

Amazon store artwork, part 3: cart icons

The shpping cart icons are there. :-) Wohoooooooo!

-> We are ready for release.

Popup dropper SVGs are not yet included, I have to check out how that
beast works. But that can be done for 2.6.

Thanks again Fabi for the great work.

Btw: I had to re-run cmake to make the build scripts fetch up those
new icons. So might you.

A +- -- src/images/icons/hi16-action-amarok_cart_add.png
A +- -- src/images/icons/hi16-action-amarok_cart_remove.png
A +- -- src/images/icons/hi16-action-amarok_cart_view.png
A +- -- src/images/icons/hi22-action-amarok_cart_add.png
A +- -- src/images/icons/hi22-action-amarok_cart_remove.png
A +- -- src/images/icons/hi22-action-amarok_cart_view.png
A +- -- src/images/icons/hi32-action-amarok_cart_add.png
A +- -- src/images/icons/hi32-action-amarok_cart_remove.png
A +- -- src/images/icons/hi32-action-amarok_cart_view.png
A +- -- src/images/icons/hi48-action-amarok_cart_add.png
A +- -- src/images/icons/hi48-action-amarok_cart_remove.png
A +- -- src/images/icons/hi48-action-amarok_cart_view.png
A +- -- src/images/icons/svg/action-cart_add.svgz
A +- -- src/images/icons/svg/action-cart_remove.svgz

Diffs: 1, 2, 3, 4, 5 Revision a0d02cc...
Raphael Kubo da Costa committed changes in [k3b/2.0] libk3bdevice/k3bscsicommand_bsd.cpp:

Refactor the FreeBSD SCSI/CAM interface.

>From the review request:
Main idea of the change is to improve the case where SCSI sense data
is not automatically provided and has to be explicitly requested.

Current code essentially duplicates main transport code for this task.

The proposed code recursively calls into the transport code with
MMC_REQUEST_SENSE command. This also fixes a problem with the existing
code where it re-uses a CCB of the original command for sense fetching
but doesn't ensure that all the previously used bytes are reset to
proper values.

This can result in a malformed MMC_REQUEST_SENSE CCB which can confuse
certain hardware (e.g. it hangs Optiarc DVD RW AD-7191S 1.02). Also the
style of the code is cleaned up.

Because of the code re-use the code is now more compact. Additionally
some historic and useless code was dropped - the code for setting errno.
errno value is not used by the calling code and this is an artifact of
the FreeBSD-specific code having been borrowed from a different project
(as attested by Heiner Eichmann).

Patch by Andriy Gapon, thanks a lot!

REVIEW: 103293
(cherry picked from commit dfe605a68406bd8830d3ab6c6e228f2c387a4122)

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

Ask for secrets only once per connection.

FIXED-IN: 0.9.0_rc4

Dario Freddi committed changes in [telepathy-accounts-kcm] /:

Replaced all occurrences of FeedbackWidget with KMessageWidget.
Also turned two Informative messages into Error messages to make it consistent.

Signed-off-by: Dario Freddi