Issue 216

1st January 2012 by KDE Commit-Digest Team

Contributors

Vladislav Blanton
Jaka Kranjc
Danny Allen
Mutlu Inek

This Week...

Work on inter-file search in Lokalize. New weather services: geonames and favourite weather station. GCI work on Marble plugins integrated. MLT clip analysis and freesound.org integration in kdenlive. Usability changes in Network Management

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    []

Educational

[] []    

Graphics

[] [] []   

KDE Base

[] []    

KDE-PIM

[] []    

Office

[] [] []   

Konqueror

     

Multimedia

[] []    

Networking Tools

[] [] []   []

User Interface

  []    

Utilities

  []    

Games

  []    

Other

     

There are 74 selections this week

Bug Fixes

Development Tools

Niko Sams committed changes in [kdevplatform/1.3] debugger/variable/variablecollection.cpp:

automatically expand watches after adding a watch

Niko Sams committed changes in [kdevelop/4.3] /gdb:

gdb process selection: remember state of dialog

Sebastian Doerner committed changes in /trunk/KDE/kdesdk/dolphin-plugins/git:

Use --porcelain mode for parsing git status, which was introduced by a (more or less) recent git version. This should be a stable interface now.

As we can easily get ignored files this way, the map now contains all but the NormalVersion stated files.


FIXED-IN: 4.8

Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize/src:

hightlight bookmarked entries in translation units list view
nice stoppage of filesearch
forward-port few fixes

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 1270909
Niko Sams committed changes in [kdevelop] debuggers/gdb/debugsession.cpp:

output exit code when debugee exits with a exit code != 0

Educational

Dennis Nienhüser committed changes in [marble] data/placemarks/moonlandingsites.kml:

Update moon landing sites.

GCI task by Gábor Péterffy (melange key: 7236202)
REVIEW: 103463

M +- -- data/placemarks/moonlandingsites.cache

Dennis Nienhüser committed changes in [marble/Touch/1.3] src/lib/PluginManager.cpp:

Do not unload plugins in PluginManager dtor.

According to qt documentation this is not needed. Not unloading plugins
avoids timing issues at destruction time: Plugin related instances can
be deleted after the deletion of MarbleModel now. Previously
MarbleModel deleted the PluginManager, which unloaded the plugins and
then created dangling pointers for plugin related instances not cleaned
up at that time.

Should be backported to the KDE/4.8 branch after testing.



(cherry picked from commit 4a1af05a822894d77bacac0932df6d38e74bcc10)

Dennis Nienhüser committed changes in [marble] src/lib/PluginManager.cpp:

Do not unload plugins in PluginManager dtor.

According to qt documentation this is not needed. Not unloading plugins
avoids timing issues at destruction time: Plugin related instances can
be deleted after the deletion of MarbleModel now. Previously
MarbleModel deleted the PluginManager, which unloaded the plugins and
then created dangling pointers for plugin related instances not cleaned
up at that time.

Should be backported to the KDE/4.8 branch after testing.

Graphics

Aurélien Gâteau committed changes in [gwenview/KDE/4.8] /documentview:

Double clicking the view toggle fullscreen

KDE Base

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.8] konqueror/src/konqmainwindow.cpp:

Append "-viewmode" to the view mode actions added to the action collection in
order to avoid overwritting an existing action with the same name, e.g. konsolepart.


FIXED-IN: 4.8.0
REVIEW: 103590

Ralf Habacker committed changes in [kdelibs/KDE/4.7] kdoctools/xslt.cpp:

crash fix on windows

transform() is called recursive, which sets xsltprocExternalEntityLoader()
as default external entity handler. The default handler is called in
xsltprocExternalEntityLoader(), which calls itself until kioslave crashes
on stack overflow.

The bug is fixed by only setting the default handler on the first call.

Shaun Reich committed changes in [kde-workspace] plasma/desktop/applets/pager/pager.cpp:

Prefer KIconLoader::Small icon sizes for window thumbnails when possible

This makes the pager actually abide by the system settings designated
Small icon size. So increasing it to e.g. 42x42 would make the window
icons in the pager use that size.

It's set to use the width/height (whichever is smallest), and the
KIconLoader::Small. Whichever value is smaller.

Was previously hardcoded to 16x16. Should be a safe change, going to
backport.

Dawit Alemayehu committed changes in [kde-baseapps] konqueror/client/kfmclient.cpp:

Make kfmclient use BrowserApplication for local html files too.

NOTE: This fix requires commit c230e107 in kdelibs.


FIXED-IN: 4.8.0
REVIEW: 103524

(cherry picked from commit b7a55b94873a8731a8381f8642d60db7306503fb)

John Layt committed changes in [kde-runtime/KDE/4.8] kcontrol/locale/kcmlocale.cpp:

KCM Locale: Fix date code conversion for common stems

Fix the KCM so that it checks for the longest date/time codes first when
converting between user visible codes and the real codes. This si
especially a problem in languages like German.

Distro's may want to backport to 4.7 and 4.6


FIXED-IN: 4.8.0

Shaun Reich committed changes in [kde-workspace] plasma/desktop/applets/pager/pager.cpp:

Use KIconLoader::Small for tooltip thumbnails as well.

It's possible ::Small should not be used for the tooltips of the pager,
perhaps ::Panel or ::Toolbar, etc. etc.?

This should present no change to anyone, since the defaults for ::Small
is 16x16 anyways.


FIXED-IN: 4.8

Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] kdewebkit/kwebwallet.cpp:

Since QWebFrame::url() always returns an empty URL for child frames, use
QWebFrame::baseUrl() instead.

Sebastian Trueg committed changes in [kdelibs/KDE/4.8] kio/kfile/kpropertiesdialog.cpp:

Make sure only the filename is shown in edit box of the properties dialog.


FIXED-IN: 4.8.0
REVIEW: 103594

Sebastian Trueg committed changes in [kdelibs/KDE/4.8] solid/solid/networking.cpp:

Re-establishes connection with networkstatus module when kded restarts.
The OrgKdeSolidNetworkingClientInterface object becomes invalid when
kded exits and should be recreated on every kded restart.

Peter Penz committed changes in [kde-baseapps] /src:

Fix inconsistency in selection manager

When a selection has been done with non-linear ranges, it was possible that
the anchor item pointed to an invalid index that resulted into an invalid
selection.

As part of this fix the sorting for DolphinView::selectedItems() has been
disabled (if the caller assumes a sorted selection he must manually adjust it).


FIXED-IN: 4.8.0

Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] kio/kfile/kpropertiesdialog.cpp:

Make sure only the filename is shown in edit box of the properties dialog.


FIXED-IN: 4.8.0
REVIEW: 103594

Sebastian Trueg committed changes in [kdelibs/KDE/4.8] kdewebkit/kwebwallet.cpp:

Since QWebFrame::url() always returns an empty URL for child frames, use
QWebFrame::baseUrl() instead.

Peter Penz committed changes in [kde-baseapps/KDE/4.8] /src/kitemviews:

Fix keyboard issues when groups are enabled

When groups are enabled in Dolphin the key-up and key-down keys did not behave
consistent in comparison to traditional views or like done in editors.

Jekyll Wu committed changes in [kde-workspace/KDE/4.8] klipper/klipperpopup.cpp:

Pressing 'Enter' should close the popup menu after selecting item

This fix is not that elegant, but currently I can't figure out a better
way. From a pragmatic perspective, it is better to fix it now in a ugly
way than waiting for the elegant solution. It has been broken for one
year :(


FIXED-IN:4.8.0

Jekyll Wu committed changes in [kde-workspace/KDE/4.8] klipper/klipper.cpp:

Make the global shortcuts of Klipper work as expected

The old code just does not work. The influenced global shortcuts always
reset to 'None' after klipper restart, and users can't even set it to
its default value.


FIXED-IN:4.8.0

Shaun Reich committed changes in [kde-workspace] /desktop/applets/pager:

Revert "show/hide pager when there is many/1 desktops"

Fixes bug where setting VD's == 1 results in an invisible, still there,
still taking up space applet with no ability to get to applet settings
or even remove it.

Only way to get it back would be going into Virtual Desktop kcm and
upping the count.

The behavior with that commit ends up creating what seems like a bug.

I'm sure it sounded good in theory, but in practice it ends up being
confusing and bug-like.




This reverts commit c92ccc4dd37ce6d2c1e53f146c1acfb432472f78.

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/kitemlistcontroller.cpp:

Fix issue that dragging pictures/videos to Google-Search/YouTube fails



FIXED-IN: 4.8.0

KDE-PIM

Allen Winter committed changes in [kdepimlibs] akonadi/entitytreemodel.cpp:

in ~EntityTreeModel(), don't crash deleting all the Nodes
in the childEntities lists. Will this still fix the crash
for those using Qt4.8? I hope people will test that for me.

MERGE: 4.8

Bug 289381:
 
15337 days
Diffs: 1 Revision 0eec12d...
Jekyll Wu committed changes in [kdepim] knotes/knotesapp.cpp:

Fix the problme of global shortcuts getting reset to 'None' on restart

REVIEW:103531



FIXED-IN:4.8.0

Office

Lukáš Tvrdý committed changes in [calligra] krita/image/kis_transform_worker.cc:

Fix artefacts when upscaling

o overflow in arithemthics caused opaque
pixels, might fix crashes for scaling for MSVC compiler
o removed alias variable
o fix coding style: add braces to single-line if conditions
o add asserts to catch overflows

Boudewijn Rempt committed changes in [calligra] libs/widgets/KoResourceItemChooser.cpp:

Only show the GHNS upload button if the attica version is high enough

Attica is buggy prior to 3.0 (a.k.a. 2.9) because of bug 281850. This
caused Krita bug 285441, where upload would fail sometimes because of
missing content-id. There's nothing we can do to fix that from within
Krita, so only show the upload button if the version of attica is new
enough. The download button is always enabled.

Matus Uzak committed changes in [calligra] /:

libmsooxml: updated processing of the graphicFrame element.

* The graphicFrame/graphic/graphicData element MAY contain a
group of graphic objects, which requires a draw:g element
instead of draw:frame as the containing frame.

* Updated docx/xlsx/pptx filter.

TODO:
docx/pptx: The tranformation and coordinates of child
custom-shape elements in the containing frame are wrong.
Seems we don't respect the group coordinates.

xlsx: A filter specific graphic style for the containing element
is required.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 264328f...
Lukáš Tvrdý committed changes in [calligra] krita/plugins/paintops/experiment/kis_fixed_painter.cpp:

Fix shaking of the experiment/shape brush

The problem was float coordinates and rounding.

Sven Langkamp committed changes in [calligra] /plugins/filters/colorsfilters:
Jarosław Staniek committed changes in [calligra] /:

Fixed two bugs related to image box form widget appearance

Forms

*Fixed bug: Image box does not store image pasted to it in design time


*Fixed bug: Changing Horizontal Alignment in image box has no effect
unless user resizes it or reopens the form

Sven Langkamp committed changes in [calligra] krita/ui/dialogs/kis_dlg_filter.cpp:
Dmitry Kazakov committed changes in [calligra] /ui/opengl:

Made KisOpenGLImageTextures::updateCache do not access any UI data

Boudewijn Rempt committed changes in [calligra] /:

Make the global selection a mask on the rootlayer

This way, the selection will be cropped, resized etc. together with
the other nodes. It will also make it possible in the future to use the
paint/fill/gradient/filter tools on the selection.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision f0bbb80...

Multimedia

Christian Esken committed changes in /branches/KDE/4.8/kdemultimedia/kmix:

Fix broken Enum controls in ALSA Backend: A "penum" will now get a different ID as a "cenum", so a selem's with both won't interfere. (Adding patch also to 4.8, as it is already fixed in trunk, 4.7 and 4.6 - thanks for the notification, A Rojas).

Christian Esken committed changes in /trunk/KDE/kdemultimedia/kmix/gui:

Fix infinite loop leading to 100% CPU usage (on reconstruction a newly connected signal would be implicitely emitted ("again"), which leads to reconstruction and newly connecting the signal, and so forth).
Fixed in trunk. This MUST be committed to all affected branches!!!
CC

Networking Tools

Matthias Fuchs committed changes in /trunk/KDE/kdenetwork/kget/core/kget.cpp:

Uses KSaveFile to avoid losing the transfer state when KGet crashes during
saving.

Andrea Diamantini committed changes in [rekonq] src/mainwindow.cpp:

Features

Development Tools

Ralf Habacker committed changes in /trunk/KDE/kdesdk/umbrello/umbrello/codeimpwizard:

refactored import processing to a signal/slot based approach

There is also an additional try to implement threading support, which
do not work because there are runtime errors reporting that objects
derived from QObject could not be called in a different thread.

No idea how to solve.

Diffs: 1, 2, 3, 4 Revision 1270601
Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize/src:

first round of work on inter-file search (and replace -- in future) feature.
basic searching and navigating found occurences in KBabel style is working (use Win+F3 for this)

Sebastian Doerner committed changes in /trunk/KDE/kdesdk/dolphin-plugins/git:

Parse output of "git pull". Show individual messages for up-to-date repository and merge conflicts.


FIXED-IN:4.9

Niko Sams committed changes in [kdevelop/4.3] debuggers/gdb/gdb.cpp:

show error message explaining that gdb crashed

this should help getting better bug reports and people knowing it's not our fault
that the debug session ended

Educational

Dennis Nienhüser committed changes in [marble] /plugins/render/weather:

Geonames weather service.

GCI task by Valery Kharitonov
REVIEW: 103534

Diffs: 1, 2, 3, 4, 5, 6 Revision 938b24c...
Dennis Nienhüser committed changes in [marble] /plugins/render/opendesktop:

Settings dialog for OpenDesktop plugin

GCI task by Valery Kharitonov
REVIEW: 103229

Diffs: 1, 2, 3, 4, 5 Revision 37e249c...
Dennis Nienhüser committed changes in [marble] /plugins/render/weather:

Favorite weather stations

GCI task by Valery Kharitonov (melange key: 7154206)
REVIEW: 103444

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision b119891...
Dennis Nienhüser committed changes in [marble] /plugins/render/measure:

Settings dialog for Marble's measure tool plugin

GCI task by Valery Kharitonov
REVIEW: 103372

Diffs: 1, 2, 3 Revision e74a65d...
Dennis Nienhüser committed changes in [marble] /lib:

Generic "mark favorite" option (to be implemented plugin specific).

GCI task by Valery Kharitonov (melange id 7246245)
REVIEW: 103582

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision d558307...
Dennis Nienhüser committed changes in [marble] /:

Replace the Measure Tool with the Measure Tool plugin.

GCI task by Mike Henning.
REVIEW: 103262

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision f381788...

Graphics

Michael Georg Hansen committed changes in [digikam] /:

Apply patch by Menopia to fix wishlist bug 283416.

Sort the list of supported MIME-types by alphabet.

Matthias Welwarsky committed changes in [digikam] imageplugins/color/adjustlevelstool.cpp:

Enable Color Channels histogram type in Levels tool

This patch enables the "Color Channels" histogram type in the Levels
tool. It is helpful when adjusting luminosity to observe if any of the
color channels clip, which leads to false highlight colors.

The patch also implements a second function:
if Color Channels is selected, Black and White tone pickers work on all
of the color channels simultaneously instead of having to iterate over
R, G and B. It is very helpful for removing the color mask of a scanned
film negative.

KDE Base

Thomas Lübking committed changes in [kde-workspace] /:

add dbus debug "activeEffects"

REVIEW: 103572

Jekyll Wu committed changes in [kde-workspace/KDE/4.8] klipper/urlgrabber.cpp:

Support the %i and %c filed codes in the Exec key of .desktop file

The code is not ideal. But it works in practice.


FIXED-IN:4.8.0

Lamarque Souza committed changes in [kdelibs/KDE/4.8] solid/solid/networking.cpp:

Re-establishes connection with networkstatus module when kded restarts.
The OrgKdeSolidNetworkingClientInterface object becomes invalid when
kded exits and should be recreated on every kded restart.

Kurt Hindenburg committed changes in [konsole] /color-schemes:

Change the KDE3 color schemas to KDE4 colorschemes format.

Convert the 3 KDE4 color schemas files to the KDE4 colorscheme file
name and file format. The format conversion was done inside the
Konsole color scheme editor.
They are not installed yet - there still needs a plan on how to
move people off the old format.

Diffs: 1, 2, 3 Revision f6253ae...
Shaun Reich committed changes in [kde-workspace/plasma/sreich/applet/hdd-a] /generic/applets/system-monitor:

Initial commit for hdd activity plasmoid.

It's going to be showing HDD throughput like the CPU and Net graphs. The
current hdd widget only displays disk *usage*, not activity/throughput.

Diffs: 1, 2, 3, 4 Revision 6829893...

KDE-PIM

Grégory Oestreicher committed changes in [kdepim-runtime] /dav:

Add basic replay cache
This will store and replay changes that were missed in
cases not caught by standard means. The base is to lure
Akonadi into thinking that the changes succeeded while
nothing can guarantee this.

Office

Sebastian Sauer committed changes in [calligra] /tables/excel/sidewinder:

Initial work to get data-style formatting also working for MSOffice 2000/2003 documents.

Diffs: 1, 2, 3, 4 Revision 489317a...

Multimedia

Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Introduce MLT clip analysis, can now be used for getting auto normalize data in sox gain effect

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision d43bad1...
Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Freesound.org integration (in progress)
You can now easily search and import audio clips

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision a3912e3...
Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Freesound: save audio file url in clip comment (for attribution)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 4d59dfa...

Networking Tools

Florian Reinhard committed changes in [ktp-accounts-kcm] /:

New fancy shiny AddAccount dialog.

Tells you if a major telepathy connection manager is missing. (haze/gabble)

REVIEW: 103562
Reviewed-by: David Edmundson
Reviewed-by: Martin Klapetek

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 5207551...
Dominik Cermak committed changes in [telepathy-contact-list] /:

Support drag and drop file transfer

Now one can drop a file (or more) on a contact to start the file
transfer.
Additionally all drag and drop related code moved from the model to
here.


REVIEW: 103520

User Interface

Ivan Čukić committed changes in [contour/ivan/location-manager] /:

Started basic support for connman

Diffs: 1, 2, 3 Revision ff95e48...

Utilities

Michel Ludwig committed changes in [kile] /:

Add live preview support for projects that use subdirectories

The same subdirectory structure has to be recreated in the temporary directory.
However, this only works if every project item occurs below the project's base
directory.

Raphael Kubo da Costa committed changes in [ark] /:

Merge Archive and ArchiveBase.

This commit only puts the ArchiveBase code into the Archive class
itself, including headers where needed. Further changes will come in
separate commits.

Digging through the history of these files is a bit difficult due to the
renames and the partial rewrite in the `libarchive-based-ark' work
branch.

This is what I was able to recover:
* A long time ago (since Ark was added to KDE's CVS repository), there
was arch.h, which provided a class named Arch. It was a virtual base
class, and plugins were implemented by subclassing it and
implementing its methods (such as open(), addFile() etc).
archiveinterface.h and archivebase.h did not exist.
* During the libarchive-based-ark rewrite, henrique committed a429011
(svn r676929) added archiveinterface.{cpp,h}. There was no
archivebase.h yet. The commit message only said "Cleanups".
* Later during the libarchive-based-ark work, henrique committed
10d49b6 (svn r686058), which created archivebase.{cpp,h} out of the
LibArchiveHandler class in the libarchive plugin and added a
ReadOnlyArchiveInterface pointer as a data member. ArchiveBase
inherited and implemented the interface defined in Arch.
* Still in the libarchive-based-ark branch, henrique committed 13980c2
(svn r690340), which removed arch.{cpp,h} and created
archive.{h,cpp}. Archive was also a pure virtual class, but was much
smaller and did not even inherit from QObject.

So even though plugins started inheriting from ReadOnlyArchiveInterface
as early as a429011, the Archive/ArchiveBase division persisted up to
now.

Since Archive is only inherited by ArchiveBase and the latter is not
inherited anywhere, the mental class diagram of Kerffuffle can be
simplified by merging both. The few unit tests we have still pass after
this change.

Diffs: 1, 2, 3, 4, 5 Revision af60a9e...

Games

Christian Krippendorf committed changes in /branches/work/krippendorf-kdegames/kmahjongg:

Add BoardEditor menu item.

Add a menu item - Game->Board Editor - for opening the board editor again.

GUI

Optimization

Graphics

Andi Clemens committed changes in [digikam] libs/widgets/metadata/metadataselector.cpp:

Make "check all" / "clear" 100 times faster

I actually wanted to implement this with a model-view based concept, but this solution is much easier to implement.
Just collapse all tree items, check them, and expand all items again. Checking all makernotes items took 30 seconds on my machine, now it is done in less than a second.

Office

Sebastian Sauer committed changes in [calligra] /words/ascii:

Made loading text-files double as fast.
We are using the Word's API direct now rather then generating ODT.
The previous way, output to ODT, can still be enabled with a compile-switch for demonstration to show how to write filters.
With my 40k lines test-file the time for loading+layouting went down from ~8 seconds to ~4 seconds.

Diffs: 1, 2, 3 Revision 1e15ee4...

Networking Tools

Matthias Fuchs committed changes in /trunk/KDE/kdenetwork/kget/ui/newtransferdialog.cpp:

Optimizes the visual input handling:
The timer restarts now and takes longer to timeout, thus there will be
less flickering when entering addresses manually.

Other

Development Tools

Jon Ander Peñalba committed changes in [kdeexamples] /:

New KIO example

Simple FTP browser that lists the content of KDE's main FTP server.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision e1ce44b...

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

First wave of usability changes in the GUI.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 20 more) Revision aeb896f...