Revision 3b6e3ad...

Go back to digest for 26th February 2012

Optimization in KDE-PIM

Till Adam committed changes in [kdepim] mailcommon/foldercollection.cpp:

Hold strong references in the FolderCollection object cache.

With the weak reference used before, and nothing really holding longer
living references to these objects, the cache was effectively bypassed,
since for every access new objects were being created. These objects are
needed mostly in the folder proxy models, to check things like whether a
particular folder should be hidden. Keeping effectively all
FolderCollection objects in memory as we now do is not optimal, from a
memory point of view, and could be optimized potentially by caching only
the "should the folder be hidden" information in the proxy models, but
the current state has a very noticeable performance hit, most notably in
the folder selector used in quick move and copy as well as jump. Since
the memory hit even with huge folder lists is bearable, this seems the
better trade off, for the moment.

File Changes

Modified 1 files
  • mailcommon/foldercollection.cpp
1 files changed in total