Issue 230

8th April 2012 by KDE Commit-Digest Team

Contributors

Mutlu Inek
Marta Rybczynska
Jaka Kranjc

This Week...

In KDevelop, C++11 now gets noexcept keyword support; external scripts can be run from Project context menu; performance improved in compiler error-detection regexps. Amarok gets a diagnostics dialog to easy bug reporting. Konversation supports SSL Client Certificate authentication using PEM files. Nepomuk metadata can be shown inside views. Amarok can distinguish between mp4, m4a, m4v types in Amarok::FileType. New functions in Kate document JavaScript API. New option that allows to specify whether an upscaling of images should be done.

Statistics

Commits 1969 by 169 developers
Open Bugs 22005
Open Wishes 16834
Bugs Opened 437 in the last 7 days
Bugs Closed 446 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
137
 
/trunk/KDE
92
 
/branches/stable
79
 
/branches/work
42
 
/trunk/www
36
 
/trunk/l10n-support
22
 
/src/oxygenthemingengine.cpp
19
 
/muon-mobile/qml
17
 
/resources/krsslocal
15
 
/plasma/generic
11
 
Files Developer Commits
252
 
Gilles Caulier
86
 
132
 
Hugo Pereira Da Costa
61
 
162
 
Frank Osterfeld
55
 
159
 
Sebastian Kügler
55
 
159
 
Wolfgang Rohdewald
53
 
150
 
Daniele E. Domenichelli
50
 
141
 
Laurent Montel
47
 
135
 
Ralf Habacker
45
 
114
 
Ingo Malchow
39
 
114
 
Sven Brauch
38
 

Internationalization (i18n) Status

Language Percentage Complete
Brazilian Portuguese (pt_BR)
100%
 
Ukrainian (uk)
100%
 
Swedish (sv)
99%
 
Polish (pl)
99%
 
Spanish (es)
97%
 
Dutch (nl)
95%
 
German (de)
94%
 
Estonian (et)
93%
 
French (fr)
92%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Martin Gräßlin
56
 
Peter Penz
24
 
Jekyll Wu
21
 
David Solbach
17
 
Christoph Feck
12
 
Milian Wolff
11
 
Anne-Marie Mahfouf
11
 
Myriam Schweingruber
10
 
Ingo Malchow
10
 
Eike Hein
10
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

  [] []   

Educational

  []    

Graphics

[] []    

KDE Base

[] [] []   []

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    

User Interface

   []   

Utilities

[]     

Games

  []    

Other

     

There are 52 selections this week

Bug Fixes

Graphics

Andi Clemens committed changes in [digikam] /:

Do not start a tool immediately in the constructor. This will lead to race conditions.
Also we try to connect signals to tools AFTER they started doing their job. This will not work for tasks that close immediately, e.g. "Scan for new items" on a very small collection. In this case the signal becomes connected AFTER the tool is done, therefore never executing the assigned slot. There are still some race conditions left, I need to check them, but for now the main issue in this bug report should be solved.

Albert Astals Cid committed changes in [okular] core/generator.cpp:

Do not set mTextPageReady to true

mTextPageReady is only used for threaded generation and this is a sync one so resetting it to true make very bad things happen
An improvement of this area is needed since it makes no sense canGenerateTextPage returns mTextPageReady when generateTextPage doesn't use itB

FIXED-IN: 4.8.3
(cherry picked from commit c29ce712cf699e38a3a384fc69e5bf36cd26fd8e)

KDE Base

Lukáš Tinkl committed changes in [kde-workspace] plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml:

fix showing remaining free space (in both the progress bar and the
tooltip)

Thomas Lübking committed changes in [kde-workspace] kwin/effects/presentwindows/presentwindows.cpp:

guard a remaining m_closeView pointer

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/kitemlistview.cpp:

Fix filtering issue

When filtering items it might be possible that the update of
the widgets is wrong although the model internally has a correct
state.


FIXED-IN: 4.8.3

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Fix focus-rectangle issues

Assure that the focus-rectangle exactly matches to the bottom of
the rendered text.



FIXED-IN: 4.9.0

Eike Hein committed changes in [kde-runtime] kcontrol/locale/kcmlocale.cpp:

Use the right category when poking KGlobalSettings into announcing the changes.

Apparently this was added to KGlobalSettings for Plasma Mobile's System
Settings equivalent and updating the KCM was forgotten.



CCMAIL:

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/kitemlistcontroller.cpp:

Fix drag & drop cursor issue

When dragging a file within the same Dolphin window and the Ctrl, Shift
or Alt-key is pressed the shape of the cursor was not changed to
indicate the copy/move/link-operation.


FIXED-IN: 4.8.3

Kai Uwe Broulik committed changes in [kde-workspace] plasma/desktop/containments/desktop/desktop.cpp:

Only printable characters may trigger KRunner, otherwise a white-space character
is introduced and the term you've entered is not recognized.

REVIEW: 104497
FIXED-IN: 4.8.3

Anne-Marie Mahfouf committed changes in [kdeplasma-addons] applets/leavenote/leavenote.cpp:

Fix QProcess call to start KNotes in LeaveNote

Line 218 in leavenote.cpp knotes.waitForStarted(); was a red herring

4.8.3
104484

Lamarque Souza committed changes in [plasma-mobile] components/metadatamodel/metadatamodel.cpp:

KDE-PIM

Laurent Montel committed changes in [kdepim] templateparser/templatesconfiguration.cpp:

Fix Bug 161598 - configuring templates: add "revert to default" to context menu

I don't add a new menu entry but a kmessagebox::questionyesnocancel to ask what we want to reset
FIXED-IN: 4.9

Kevin Krammer committed changes in [kdepimlibs] /vcardparser:

Treat \N as a valid new line sequence in vcard input

The vCard RFC has a note on fields of type text that suggests that
both \n and \N are to be treated as new line sequences:

. The method for specifying CRLF character sequences in text
type values has been changed. The CRLF character sequence in
a text type value is specified with the backslash character
sequence "\n" or "\N".


FIXED-IN: 4.8.3
REVIEW: 104509

Office

Sven Langkamp committed changes in [calligra] krita/ui/dialogs/kis_dlg_filter.cpp:

workaroung to be able to resize the filter dialog after it's centered

Sven Langkamp committed changes in [calligra] krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp:
Boudewijn Rempt committed changes in [calligra] krita/ui/kis_config.cc:

Anti-alias the curves by default

Because it looks prettier :-)

Inge Wallin committed changes in [calligra] /pictureshape:

Implement loading and saving for style:mirror for pictures.

This part prevents data loss.
Next step is painting.

C. Boemann committed changes in [calligra] words/part/frames/KWFrameLayout.cpp:

Make sure the background is always drawn below everything else

Boudewijn Rempt committed changes in [calligra] /:

Don't crash when d&d'ing a shape layer

The content of the shape layer isn't visible yet, though.

Multimedia

Bart Cerneels committed changes in [amarok] /browsers/playlistbrowser:

Improve activate (double click) handling, fix bug.


FIXED-IN:2.6

Matěj Laitl committed changes in [amarok] /:

distinguish between mp4, m4a, m4v types in Amarok::FileType

iPod Collection (the new one) needs to distinguish somehow between
MPEG-4 audio and video files; to make this generic, least bad approach
it probably to use Meta::Track:type().

MetaFile::Track's type() is okay, as it just returns lowercased file
extension. SqlTrack stores file type in db as numeric index to the
Amarok::FileType enum, which currently has just one generic entry for
MP4 files.

This patch extends Amarok::FileType with M4a and M4v values and
TagHelper to try to detect more specific MP4 file format. (currently
just file extension based, can be extended in future) Users will need
to do a full rescan for Local Collection to pick up more specialised
file types.

I'm running this through review board as there seems no general
agreement on Meta::Track:type() semantics. (Speaking of which, I'd be
most satisfied if it returned (the most specific) mime-type represented
using dedicated class that would support mimetype hierarchy)


FIXED-IN: 2.6
REVIEW: 104481

Networking Tools

Daniele E. Domenichelli committed changes in [ktp-text-ui] /:

Added a method that enables/disables the block action so that we

disable the block action when switching to a group chat.

Daniele E. Domenichelli committed changes in [ktp-text-ui] lib/chat-widget.cpp:

Displayed a message to the user that tells him the contact is blocked

Lamarque Souza committed changes in [networkmanagement/nm09] solidcontrolfuture/solid/networkmanager-0.9/manager.cpp:

Do not send the interfaceRemoved signal if NM stopped or crashed. If it
has crashed we can crash too if we send the interfaceRemoved signal here.

David Edmundson committed changes in [ktp-text-ui] /:

Entity filter in the log viewer

REVIEW: 104055

Utilities

Daniel Nicoletti committed changes in [apper] /:

Fix updating that requires installing/updating packages from untrusted sources

Daniel Nicoletti committed changes in [apper] /:

Fix crash when quiting apper-sentinel due to late deleting

Michel Ludwig committed changes in [kile] /:

Correctly convert special characters into LaTeX that were typed with caps lock enabled

This fix works from KDE 4.3 and upwards as the class 'KModifierKeyInfo' is used.

Rolf Eike Beer committed changes in [kgpg/KDE/4.8] transactions/kgpggeneratekey.cpp:

fix generation of DSA/ElGamal keys with GnuPG 1.x

The name "ELG" for ElGamal keys only works with 2.x. Use ELG-E which works with
both 1.4 and 2.0.18. It will not work with 2.0.0, but given that it's only that
single version and it is more than 5 years old I don't care.


FIXED-IN:4.8.3

Features

Development Tools

Michael Pyne committed changes in [kdesrc-build] /:

Support defaulting to stable branches from proj.k.o.

Valery Yundin has kindly submitted a patch (including documentation!)
resurrecting the old "use-stable-kde" option to allow for defaulting
kde-projects modules to the stable branch (if defined for that module).

This should track with changes to the stable branch as defined, so it
would be a good way to track the "not quite bleeding-edge" of
development.

A hearty thanks to Valery for making up a patch and then adapting it to
make use of the old use-stable-kde option.


FIXED-IN:1.15

Milian Wolff committed changes in [kdevelop/4.3] /cpp/parser:

c++11 support: handle noexcept-specification and noexcept-expression in our parser

This is particularly useful with new GCC toolchain version 4.7.0, where these keywords
are frequently used throughout STL.

thanks to Ivan Shapovalov for the patch, I just cleaned it up a bit and added a unit test

REVIEW: 104498

Milian Wolff committed changes in [kdevelop/4.3] /cpp/parser:

properly handle l, lu, ul integers in our preprocessor

this finally fixes parsing of gcc 4.7 headers

thanks again to Ivan Shapovalov for this patch, which
I cleaned up a bit and added a unit test

the question now: how should ll, ull, llu integers be
handled by a c++11 compliant preprocessor?


REVIEW: 104498

Milian Wolff committed changes in [kdevplatform] /externalscript:

make extern scripts available through context menu

Now, the context menu in the project manager view, tab and editor
show a submenu "external scripts" which holds the available scripts
which can then be executed for the selected file(s).

scripts that depend on a user selection are only shown in
the editor context menu.

thanks to Ghislain Mary for the patch

REVIEW: 104133

Educational

Akarsh Simha committed changes in [kstars] kstars/skycomponents/customcatalogcomponent.cpp:

Allow a lot more object types in custom catalogs. The most probably
reason why these object types were not included earlier is that they
were added after the customcatalogcomponent code was written.

Supernovae are not addable in custom catalogs since the supernova
feature updates the supernova data anyway.

Asterisms, Dark Nebulae, Quasars, Galaxy Clusters etc are now addable.

Graphics

Frédéric Coiffier committed changes in [kipi-plugins] /:

piwigoexport : Support the new Piwigo Web API 2.4

Reorganize the interface (now, looks like Picasa/Facebook plugin
interface)
Retrieve the title, the comment, the date and the authors with
KPImageInfo API
Remove useless options in the dialog box
Replace the old Piwigo icon by the new one
Replace the old Piwigo logo in the dialog box

M +- -- piwigoexport/icons/hi16-action-piwigo.png
M +- -- piwigoexport/icons/hi22-action-piwigo.png
M +- -- piwigoexport/icons/hi32-action-piwigo.png
M +- -- piwigoexport/icons/hi48-action-piwigo.png
M +- -- piwigoexport/icons/hisc-action-piwigo.svgz
M +- -- piwigoexport/piwigo_logo.png

Diffs: 1, 2, 3 Revision 8c14aa5...

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Allow showing Nepomuk metadata inside views

Metadata like image-size, rating, comments, tags, ... can be shown
now in the view (e.g. as column in the Details mode).

Still open: The rating-information needs to be shown as stars.

In the context of this feature also the following bugs have been
fixed:
- Fix visual glitches in the header of the Details mode
- Improve the minimum column width calculation to respect also
the headling and not only the content


FIXED-IN: 4.9.0

Dominik Haumann committed changes in [kate] /script:

extend document javascript api

new functions are:
- Range document.wordRangeAt(int line, int column)
- Range document.wordRangeAt(Cursor cursor)
Return the range of the word at the given cursor position. The returned range
is invalid (check range.isValid() in the script), if the text position is after
the end of a line. If there is no word at the given cursor, an empty range is
returned.

- bool document.wrapLine(int line, int column)
- bool document.wrapLine(Cursor cursor)
Wraps the line at the given cursor position.

Maybe backport to 4.8 branch for 4.8.3.

Peter Penz committed changes in [kde-baseapps] /src:

Allow to specify whether an upscaling of images should be done

The option is currently hidden as up to now only Nuno requested it,
but it seems to be urgent: "my icon making productivity has drop subtantialy"
((c) 2012 Nuno)

As I don't want to get blamed for an outdated Oxygen-icon-set I have
no other choice ;-)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 99e4eb0...
Martin Gräßlin committed changes in [kde-workspace] /:

Add notifications for Window goes to/fro Fullscreen


FIXED-IN: 4.9.0
REVIEW: 104457

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Fix Bug 192825 - Smiley selector in composer

FIXED-IN: 4.9

Office

Stephane Mankowski committed changes in [skrooge/Feature] /:

feature: Skrooge is now able to import file have amounts with unit symbole (example: -$8.35)

Diffs: 1, 2, 3, 4, 5 Revision 50aa454...
Stephane Mankowski committed changes in [skrooge/Feature] /:

: mt940 import mode not yet implemented

Multimedia

Andrzej Hunt committed changes in [amarok] /:

Diagnostics Dialog for Amarok.

REVIEW: 104449
GUI:

Bart Cerneels committed changes in [amarok] /:

Make DiagnosticDialog non-modal and changelog

DIGEST:Amarok gets a diagnostics dialog to easy bug reporting.

After seeing it implemented in Tomahawk we blatently copied it.
Patch provided by Andrzej Hunt implementing a Junior Job listed
on bugs.kde.org.

Diffs: 1, 2, 3, 4 Revision cdcb603...

Networking Tools

Eike Hein committed changes in [konversation] /:

Add support for SSL Client Certificate authentication using PEM files.



The additional info label unfortunately makes the Qt 4.8 regression
in QFormLayout even more annoying; I'll have to deal with this later.

Games

Christian Krippendorf committed changes in /branches/work/krippendorf/kmahjongg:

Replace BoardWidget with GameWidget... it starts but no game is possible yet. This is just a basic implementation.

Diffs: 1, 2, 3, 4, 5 Revision 1288195

Optimization

Development Tools

Milian Wolff committed changes in [kdevelop] /makebuilder:

greatly improve performance of our compiler error-detection regexps

errors start at the beginning of a line, by adding this information
to the regexps (^ at the beginning) they can perform much better for
very long lines which can occur during linking of large projects

also adds a unit test with some error messages I found on the net
to "proof" it's still working as intended

KDE Base

Sebastian Trueg committed changes in [nepomuk-core/feature/virtuosoInference] /query:

Better visibility filtering.

Instead of adding a type query pattern which drains performance we now
simply copy the visibility pattern into each UNION to make sure the
main variable is always accessible.

This results in more complexity once more but is worth it.

Tests still need to be updated.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 8 more) Revision 8623d2b...
Sebastian Trueg committed changes in [kdelibs/nepomuk/virtuosoInference] /query:

Better visibility filtering.

Instead of adding a type query pattern which drains performance we now
simply copy the visibility pattern into each UNION to make sure the
main variable is always accessible.

This results in more complexity once more but is worth it.

Tests still need to be updated.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 8 more) Revision 7305ed5...

User Interface

Aleix Pol Gonzalez committed changes in [kalgebra] /plugins:

Small mobile UI improvements

- Make the neutral UI suck a bit less, sightly.
- Show the back icon at the bottom
- Add images in the main page
- Put plot2d's input at the top

Diffs: 1, 2, 3, 4 Revision dae038d...
Lamarque Souza committed changes in [plasma-mobile] /:

Add busy indicator to ViewSearch.qml to indicate ongoing search.

Other

KDE Base

David Faure committed changes in [kdelibs/frameworks] /:

Ported to QMimeType

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision ed588e1...