Issue 231

15th April 2012 by KDE Commit-Digest Team

Contributors

Mutlu Inek
Jaka Kranjc
Marta Rybczynska

This Week...

Dolphin now uses KMessageWidget for error and information messages and has faster file sorting. Initial Fuse backend implementation for Solid. It is now possible to save images from HTML mails in KMail. OSRM (Open Source Routing Machine) is supported as routing backend in Marble. Lokalize adds basic support for QT Linguist's .ts files. Improved sorting by meridian transit time / observation time for an observation session in KStars; improved DSS image retrieval feature.

Statistics

Commits 1834 by 156 developers
Open Bugs 22040
Open Wishes 16810
Bugs Opened 429 in the last 7 days
Bugs Closed 394 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
163
 
/trunk/KDE
101
 
/branches/stable
99
 
/trunk/l10n-support
29
 
/trunk/www
27
 
/trunk/playground
17
 
/branches/work
8
 
/themes/userbar
8
 
/portage/libs
7
 
/libs/service
7
 
Files Developer Commits
180
 
Wolfgang Rohdewald
60
 
123
 
Milian Wolff
49
 
135
 
Laurent Montel
45
 
72
 
Hugo Pereira Da Costa
36
 
99
 
Roman Paholík
33
 
87
 
Sebastian Kügler
29
 
81
 
Yuri Chornoivan
27
 
81
 
Boudewijn Rempt
27
 
75
 
Patrick von Reth
26
 
69
 
Gilles Caulier
25
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Portuguese (pt)
100%
 
Polish (pl)
99%
 
Swedish (sv)
99%
 
Spanish (es)
97%
 
Dutch (nl)
96%
 
Estonian (et)
94%
 
German (de)
94%
 
French (fr)
92%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Martin Gräßlin
30
 
Christophe Giboudeaux
19
 
Christoph Feck
18
 
Andrea Diamantini
18
 
Jekyll Wu
17
 
Thomas Lübking
16
 
C. Boemann
15
 
Laurent Montel
13
 
Christian Esken
13
 
Peter Penz
13
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

  []    

Educational

  []    

Graphics

     

KDE Base

[] [] []   []

KDE-PIM

[] []    []

Office

[]   []   

Konqueror

     

Multimedia

     

Networking Tools

[] []    

User Interface

[]     

Utilities

[]     

Games

  []    

Other

   []   

There are 44 selections this week

Bug Fixes

KDE Base

Jekyll Wu committed changes in [konsole] src/Session.cpp:

Introduce small delay to avoid updating Pty size too quickly

Some terminal application does not update its display when Pty size
changes quickly in a row. Zsh seems a typical example.

Thanks to Franz Fellner for the research
and solution.



FIXED-IN: 4.8.3

Milian Wolff committed changes in [kate] part/render/katerenderer.cpp:

don't crash when line has no width and cursorToX is called

see also bug 292947

Jekyll Wu committed changes in [konsole] src/Session.cpp:

Use $PWD as the fallback value for setting initial working directory

This means running "konsole" literally in a terminal will open a konsole
which starts in the same directory as the current terminal. "konsole
--workdir ." is no more needed. This makes Konsole behave like most
other emulators.

Another befinit is it is now easier to use konsole for the "Open
terminal here" feature provided in file managers other than dolphin.
Note: due to the "single process" model of konsole, konsole sometimes
does not open the expected the direcotory when used by this "Open
terminal here" feature.

REVIEW: 104518

FIXED-IN: 4.9.0

Thomas Lübking committed changes in [kde-workspace] /:

merge geom_pretile & geom_restore
remove some patch bodies
checkWorkspacePosition on geom_restore


reviewed-by: graesslin

Martin Gräßlin committed changes in [kde-workspace] kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml:

Horizontal center the Thumbnail ListView

This ensures that also for a small TabBox with just one item
the thumbnail is nicely centered.

REVIEW: 104541

Thomas Lübking committed changes in [kde-workspace] kwin/kcmkwin/kwinoptions/windows.cpp:
Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] kioslave/http/http.cpp:

Removed debug statement that was printing out password

Dawit Alemayehu committed changes in [kde-runtime/KDE/4.8] kioslave/sftp/kio_sftp.cpp:

Fixed authorization retry when original login+pass combination fails.

REVIEW:104529

Peter Penz committed changes in [kde-baseapps] /src:

Ignore maximum size for local files when creating previews

It is up to the plugins to decide what sensible size is required for
creating a preview, this cannot be decided by the user for all
plugins. A maximum size only makes sense for remote files, where
the user implicitely decides how much of the bandwith may be used
for having previews.


FIXED-IN: 4.9.0

Marco Martin committed changes in [plasma-mobile] /activityswitcher/contents/ui:
Peter Penz committed changes in [kde-baseapps] dolphin/src/views/dolphinview.cpp:

Fix outdated statusbar message when entering an empty folder


FIXED-IN: 4.9.0

Martin Gräßlin committed changes in [kde-workspace] /effects:

Save and restore zoom value for desktop zoom and magnifier effects

REVIEW: 104597

FIXED-IN: 4.9.0

Thomas Lübking committed changes in [kde-workspace] /:

move sync dbus calls to kactivitymanagerd into extra thread
to prevent broken dbus chain from blocking the compositor


REVIEW: 104563

Kurt Hindenburg committed changes in [konsole] /:

Allow non-English for program names; useful w/ -e

The old code used Latin1() to check program names and also used
QFile::encodeName().

Thanks to Eugene Shalygin for report and research.

Example:
cp `which vi` ./编辑器
konsole -e ./编辑器

FIXED-IN: 2.8.3

Martin Gräßlin committed changes in [kde-workspace] /:

Keep position in stacking order for deleted windows

Workspace::addDeleted swaps the Client with the Deleted in the
stacking order. For Unmanaged windows the Deleted is appended
to the stacking order which is the same layer.

When the deleted is closed the window is removed from the stacking
order.

The result is that a deleted window is no longer raised above all
other clients.

REVIEW: 104519

FIXED-IN: 4.9.0

Marco Martin committed changes in [kde-workspace] plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml:

KDE-PIM

Laurent Montel committed changes in [kdepim] messagecomposer/messagefactory.cpp:

Fix Bug 297934 - BCC is not removed when attaching messages

FIXED-IN: 4.8.3

Office

Boudewijn Rempt committed changes in [calligra] krita/plugins/tools/tool_text/kis_tool_text.cc:

Fix position of the text shape inserted by krita's text tool

Apparently KoShape::setPosition() sets the position of the center
of the shape, not topleft.

Networking Tools

Marco Martin committed changes in [share-like-connect] components/SlcMenu.qml:

move menu offscreen until has the correct size

items have to be actually painted before their implicit width is really know, so the first paint has to be done off screen to avoid size jumps and the menu of 0x0 size for an instant

Joris Guisson committed changes in [ktorrent] /:

Fix Queue Manager widget getting the priorities wrong

Nicolás Alvarez committed changes in [konversation] src/viewer/ircview.cpp:

Fix misleading log formatting when /msg'ing from a channel window.

When doing "/msg foo bar" in a channel, we used to log "<foo> bar"
in the channel log. This is very misleading, since it looks as if
'foo' said it rather than sending it *to* foo. This commit changes it
to "<-> foo> bar", which looks a bit odd to me but it's consistent
with what gets shown in the ircview.

This partially fixes the complaints in bug 100369. The other part of
that bug is logging the message in the recipient's log
instead of the channel's, but that's apparently quite hard.

Joris Guisson committed changes in [ktorrent] /:

Make float comparison factor smaller in ViewModel when checking if share ratio has changed

User Interface

Hugo Pereira Da Costa committed changes in [kde-workspace] kstyles/oxygen/oxygenstyle.cpp:

use QStyleOptionSpinBox::stepEnabled flag to decide arrow color.

Utilities

Jonathan Michael Thomas committed changes in [muon] /:

Show the package name as a technical package's name, and its short description as the comment.
This is necessary for displaying technical packages in the MSC, since sorting by short desc. takes 11 seconds on 50,000 packages.

With this change, I've also made all of the non-categorized app views (E.g. per-origin ones) display technical packages by default.
I'll probably also add a runtime toggle so that the "Provided by Kubuntu" entry doesn't become *totally* unnavigable if somebody doesn't care about technical packages.

As a side effect, the Muon Updater now shows the package name for the updates in the "System Updates" category.



FIXED-IN:1.4.0

Features

Development Tools

Nick Shaforostoff committed changes in /trunk/KDE/kdesdk/lokalize:

basic support for qt linguist's .ts files, including handling for plurals and translator's comments
todo: other comment types, check syncview usage with .ts files

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 1289146

Educational

Akarsh Simha committed changes in [kstars] kstars/skymap.cpp:

Improving the DSS image retrieval feature (as accessed from
KSPopupMenu) smarter.

For deep-sky objects, it now uses an image height and width computed
to fit the deep-sky object with some additional padding (currently
hardcoded). Absurd values are replaced by a default size (which is
currently hard-coded to 15 arcminutes).

It uses the hardcoded default size value for all other objects.

FEATURE

Dennis Nienhüser committed changes in [marble] /:

Add OSRM (Open Source Routing Machine) as routing backend.

Akarsh Simha committed changes in [kstars] /:

The sorting by meridian transit time / observation time for an
observation session is not the same as a simple QTime compare.

Any observation session starts at sunset and stops at sunrise --
midnight is not the starting point. So the objects that should be
observed first are those which transit meridian just after 12 PM. So
the correct sorting procedure would place 12 PM first, followed by 1
PM and so on till 11 PM, followed by 12 AM and so on till 11:59 AM.

This sorting is achieved easily by sorting the time + 12 hours instead
of the time itself. Since QTime wraps around after 24 hours, this
works well.

This commit introduces this by:

1. Creating a SessionSortFilterProxyModel, subclassed from
QSortFilterProxyModel, reimplementing lessThan()

2. Using this sort model rather than the default one for the session
planner.

Diffs: 1, 2, 3, 4 Revision 75ecf39...

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Allow to optionally limit the maximum number of text lines

Showing the whole filename unclipped seems to be a good default,
however for users with a lot of files that have extremely long names
this might get a problem especially in the icons-view.

- Allow to limit the maximum number of lines in the icons-view
- Allow to specify a maximum width in the compact-view

(No limit is required for the details-view, as the name is shortened
automatically to show other columns)


FIXED-IN: 4.9.0

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 9541f9e...
Peter Penz committed changes in [kde-baseapps] /src:

Use KMessageWidget for error- and information-messages

See http://agateau.com/2011/04/21/kde-ux-2011/ for more details.
This simplifies the statusbar in Dolphin a lot and allows to
do a proper eliding in case if status-messages are too long: In
this case a tooltip will show the whole status-message (thanks
to Wolfgang Mader for the initial patch!).

There is still missing some finetuning but the general approach
seems to work quite nice.




FIXED-IN: 4.9.0

Thomas Lübking committed changes in [kde-workspace] /tabbox:

use compositor to elevate current tabbox window


REVIEW: 104538

Ivan Čukić committed changes in [kdelibs/ivan/solid-fuse-access] /solid:

Initial Fuse backend implementation

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision dcb4377...
Martin Gräßlin committed changes in [kde-workspace] /:

Introduce post Workspace init phase

Workspace emits a signal when the initialization finished and
interested parties can connect to this signal to perform post
init actions. That is everything that does not have to be
performed to have a completely working Window Manager.

As an example loading the scripts is moved into this post init
phase.

REVIEW: 104580

Diffs: 1, 2, 3 Revision edcad2b...

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Fix Bug 41738 - possibility for saving images from HTML mails

FIXED-IN: 4.9

Networking Tools

Eike Hein committed changes in [konversation] /:

Post a list of shared channels at query start.

Games

Albert Astals Cid committed changes in /trunk/KDE/kdegames/kiriki/src:

Patch by Arjun Basu to let the user choose the font size

Stefan Majewsky committed changes in /trunk/KDE/kdegames:

Add the KgTheme framework.

The KGameRenderer API is adjusted to use a KgThemeProvider instead
of KGameTheme. To ensure that everything still compiles, games using
KGameRenderer are ported to KgTheme immediately.

Some comments about how the games were ported:

* KAtomic, Kolf, Kollision and KReversi don't install .desktop files for
their themes anymore. They are not really needed since there is only
one theme per game, but KGameRenderer previously required a .desktop
file for KGameTheme. KgTheme works with hardcoded SVG paths, too.

* I found that Granatier abuses the KGameRenderer framework in a quite
interesting way to add support for a fallback theme. The proper
solution is to integrate this functionality in KGameRenderer. This
commit does a very direct port to KgTheme only.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 59 more) Revision 1289083

Optimization

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Improvements for slow sorting roles

If the sorting is done for data which is resolved asynchronously
(e.g. rating), it is important to give a visual feedback about
the state of the sorting. This is done now by a progress
indication in the statusbar.

Also optimizations for "Sort by type" have been done: Although
resolving a type can be expensive in the most often case it is a
very cheap operation. So it the sorting is done by type, try
to resolve the type synchronously for at least 200 ms to prevent
a asynchronous resorting. This is usually sufficient to have
resolved types even for directories with several thousands of
items.


FIXED-IN: 4.9.0

Martin Gräßlin committed changes in [kde-workspace] /:

Perform detection of CompositingPrefs async

Detecting CompositingPrefs invokes an external program. Waiting
for this can be moved in a second thread.

Due to the introduction of the thread the initialization order
of KWin is changed: the WindowManager is initialized before the
Compositor. Interestingly this makes KWin felt more responsive
as the screen is not frozen for several seconds.

REVIEW: 104579

Thomas Lübking committed changes in [kde-workspace] kwin/effects/presentwindows/presentwindows.cpp:

Avoid continious repaints in Present Windows effect

REVIEW: 104787

Office

Boudewijn Rempt committed changes in [calligra] libs/pigment/KoBasicHistogramProducers.cpp:

Make histogram calculation faster

By converting all pixels in one go, instead of pixel by pixel.
KoColorSpace::convertTo is really expensive.

This helps with the startup speed of the levels filter on large
images.

Ok to backport to 2.4?

Other

Sebastian Trueg committed changes in [soprano] /:

New Virtuoso backend option: noStatementSignals.

This will disable Model::statementsAdded() and friends which increases
performance in case those are not used.

Diffs: 1, 2, 3, 4, 5, 6 Revision 9739cc7...

Other

KDE Base

Peter Penz committed changes in [kde-baseapps/KDE/4.8] /src:

Revert the 2.0 decision to always use KB for file-sizes

The feedback on bugs.kde.org has shown that the previous behavior
(= show size with best-matching unit) is preferred by most users.
I initially wanted to make this configurable, but for implementing
it in a non-hacky way extending KLocale from kdelibs would have
been required. I'm not sure whether the usecase in Dolphin justifies
having such a configuration in KLocale - however as kdelibs is frozen
at the moment this is no option and the old behavior has been
restored.


FIXED-IN: 4.8.3

KDE-PIM

Frank Osterfeld committed changes in [kdepimlibs/akregator_port] /:

Re-license to LGPL