Issue 232

22nd April 2012 by KDE Commit-Digest Team

Contributors

Mutlu Inek
Marta Rybczynska
Jaka Kranjc

This Week...

Konsole gains Web Shortcus menu that allows searching selected text using any of the search providers; search scrollback is now possible in Konsole KPart. New placement policy is now possible in KDEWorkspace: under mouse; work t include screenlocker into ksmserver. Amarok ships the Free Music Charts by default; Amarok's iPod completely rewritten. Digikam supports keyboard shortcuts in the timeline view. GlobalShortcuts Plugin added into ActivityManager in KDE-Base. Work on the rule files in kdemultimedia.

Statistics

Commits 2407 by 161 developers
Open Bugs 22086
Open Wishes 16814
Bugs Opened 408 in the last 7 days
Bugs Closed 362 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
221
 
/branches/stable
168
 
/trunk/KDE
34
 
/trunk/l10n-support
33
 
/trunk/www
28
 
/themes/userbar
19
 
/styles/Neverland
15
 
/timeadjust/timeadjustdialog.cpp
15
 
/muon-mobile/qml
15
 
/template/en
10
 
Files Developer Commits
207
 
Aleix Pol Gonzalez
69
 
204
 
Roman Paholík
68
 
186
 
Laurent Montel
62
 
177
 
Patrick von Reth
61
 
177
 
Gilles Caulier
60
 
159
 
Burkhard Lück
54
 
144
 
Sayak Banerjee
51
 
117
 
Marco Martin
42
 
120
 
Boudewijn Rempt
40
 
111
 
C. Boemann
39
 

Internationalization (i18n) Status

Language Percentage Complete
Dutch (nl)
95%
 
German (de)
94%
 
Estonian (et)
93%
 
French (fr)
92%
 
Italian (it)
90%
 
Danish (da)
86%
 
Low Saxon (nds)
86%
 
Chinese Traditional (zh_TW)
84%
 
Norwegian Bookmal (nb)
83%
 
British English (en_GB)
83%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
42
 
Boudewijn Rempt
40
 
C. Boemann
34
 
Dawit Alemayehu
33
 
Christoph Feck
18
 
Myriam Schweingruber
18
 
Alex Fiestas
16
 
Thomas Lübking
15
 
Christophe Giboudeaux
14
 
Martin Gräßlin
13
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

[]     

Graphics

[] []    []

KDE Base

[] []    []

KDE-PIM

[]     

Office

[]     

Konqueror

     

Multimedia

[] []    

Networking Tools

[] [] []   

User Interface

[]     

Utilities

   []   

Games

     

Other

  []    

There are 60 selections this week

Bug Fixes

Development Tools

Andi Fischer committed changes in /trunk/KDE/kdesdk/umbrello/umbrello/codeimpwizard:

Resizing of code import wizard fixed and improved. Wizard is now usable also for small screens.

Milian Wolff committed changes in [kdevplatform] plugins/quickopen/projectitemquickopen.cpp:

stable sorting for equal-matched ProjectItems

Without this patch, items that are equally well matched
by a filter string might change their order randomly
when the filter string is refined but the match-quality
stays equal

Educational

Bernhard Beschow committed changes in [marble] src/lib/MarbleWidget.cpp:

Resizing the widget changes the viewport.

(cherry picked from commit 2266a469a990acbfd3f969107a725b36957f12dc)

Rafal Kulaga committed changes in [kstars] kstars/texturemanager.cpp:

Try to load textures from main data directory if they aren't in 'textures' dir.

This fixes the issue reported by Manfred. This might not be the best option available,
but we don't want to break anything for people that are happy with textures in
main data directory.

Graphics

Smit Mehta committed changes in [kipi-plugins] NEWS:

KDE Base

Martin Gräßlin committed changes in [kde-workspace] /scripting:

Export workspace as global property on ScriptEngine in QML bindings

If workspace is exported as a context property there seem to be
issues with the signals which are not bound to a property of
WorkspaceWrapper.

This problems seems to be fixable by exporting the workspace
property as a global property on the script engine.

As a side-effect this also resolves the issue with the clientList,
so we can drop the hack again.

REVIEW: 104682

Diffs: 1, 2, 3 Revision 2810e27...
Ivan Čukić committed changes in [kdelibs/ivan/plasma-active-patches] kioslave/http/kcookiejar/kcookiejar.cpp:

Fixed the issue of some cookies not showing up in the cookie management dialog.


FIXED-IN: 4.8.3

Thomas Lübking committed changes in [kde-workspace] kwin/client.cpp:

do not setActive clients which don't take focus on ShadeHover - by this resort re-shade restacking code


FIXED-IN: 4.9
REVIEW: 104622

Thomas Lübking committed changes in [kde-workspace] /:

export clientpopup mapping state and use it to skip mouse driven focus changes


FIXED-IN: 4.9
REVIEW: 104620

Ivan Čukić committed changes in [kdelibs/ivan/plasma-active-patches] khtml/rendering/render_form.cpp:

Fix rendering of text input elements having padding by removing the use
of cached parent's proxy style, that end up to return a wrong content rect
size, and using ad-hoc style() function instead. Actually only KLineEdit
inherits KdeUiProxyStyle (since kde 4.5) so the behavior of our internal
proxy is unchanged for the other form elements (i.e m_proxy was always 0 for them).

Also the crash reported in #197270 is no longer reproducible after this change,
likely it has been fixed elsewhere...

, 280226
FIXED-IN: 4.8.3

Peter Penz committed changes in [kde-baseapps] /src:

Ensure authentication data is cached properly

The attached patch sets the main window on the main directory
lister in DolphinView and KIO jobs in DolphinMainWindow to ensure
that login data for remote protocols such as sftp, ftp are cached
properly for the duration of the application. Otherwise, the end
user is going to end up being unnecessarily re-prompted to enter
password login information.

Thanks to Dawit Alemayehu for the patch!

REVIEW: 104614
FIXED-IN: 4.9.0

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision ff37139...
Erlend Hamberg committed changes in [kate] part/vimode/katevivisualmode.cpp:

Make <del> delete visual selection by default

Lukáš Tinkl committed changes in [kdelibs/frameworks] /solid/src/solid/backends/udisks2:

don't crash on querying udev properties of optical media

Thomas Lübking committed changes in [kde-workspace] kwin/useractions.cpp:

make the rmb popup move trigger an unrestricted move


FIXED-IN: 4.9
REVIEW: 104620

Jekyll Wu committed changes in [konsole] src/MainWindow.cpp:

Ensure the confirmation dialog for closing window is visible to users


FIXED-IN: 4.9.0

Jekyll Wu committed changes in [konsole/KDE/4.8] src/MainWindow.cpp:

Ensure the confirmation dialog for closing window is visible to users


FIXED-IN: 4.8.3
(cherry picked from commit cf5ccf5f65fa490411a27f6a5ada271bdc188d3b)

Jekyll Wu committed changes in [konsole] src/main.cpp:

Konsole should use new process when some Qt/KDE options are given

One typical option is "--display", because two konsole windows
belonging to the same process are destined to be shown in the same
display, which defeats the purpose of the "--display" option





FIXED-IN: 4.9.0
REVIEW: 104653

Thomas Lübking committed changes in [kde-workspace] kwin/events.cpp:

store focusMousePosition on unmapNotify events


FIXED-IN: 4.9
REVIEW: 104620

KDE-PIM

Dan Vratil committed changes in [akonadi-google] calendar/resource_events.cpp:

Bug #298519 - Deleting events incorrectly reports an error

Resource now correctly handles the error code returned by Google
when an event is succesfully deleted.

Andre Heinecke committed changes in [kdepim] messageviewer/objecttreeparser.cpp:

Fix parsing of combined encrypted/signed messages

In the case that a mime object was encrypted and signed the
rendered mail showed an incorrect signature status because the
signature was aready checked with the decryptverifyjob and the
key object not available in writeOpaqueOrMultipartSignedData.
(So only the fingerprint was used).

In the case that writeOpaqueOrMultipartSignedData is called
to show OpenPGP Encrypted and Signed data with a valid signature,
the signature's key is now fetched from the OpenPGP backend using
the fingerprint from the signature.
The Key is then used as in the other cases to show the details
(Name / Trustlevel etc.)

This fixes the rendering of openpgp mails signed with the combined
method which is used by mutt, gnus etc.

Laurent Montel committed changes in [kdepim] /:

Fix bug when we reply and it doesn't take good identity when we use

default identity from account.

David reported me it and it was reported to Bug 297912 - 'Reply to' uses
wrong identity if not explicitly set in 'folder properties'

FIXED-IN: 4.8.3

Office

Jarosław Staniek committed changes in [calligra] /:

Kexi Tables: Fixed bug: Cannot update field name from Property Editor


FIXED-IN:2.4.1 (Calligra 2.4.1)

REVIEW:104600

C. Boemann committed changes in [calligra/tuneKoUnitAPI] libs/odf/KoXmlWriter.h:

With gcc 4.7 installed we where not able to save a odt file because the xml file that was generated was
missing the '>' for a tag. Example
<manifest:file-entry manifest:media-type="" manifest:full-path="Thumbnails/thumbnail.png"
</manifest:file-entry>

The missing close tag was because while doing a stack.pop the hasChildren (a bitfield) of Tag was not
populated correctly. This patch fixes this problem(workaround for a gcc bug? not sure)


REVIEW: 104677

C. Boemann committed changes in [calligra/tuneKoUnitAPI] libs/main/KoFilterManager.cpp:

Don't show messagebox when converting in batch mode

Batch mode is batch mode: we don't want any dialog messing up the
conversion queue.

Thorsten Zachmann committed changes in [calligra] libs/flake/svg/SvgUtil.cpp:

Fix crash in loading svg file from blender

The svg file blender writes out contains a viewBox with wrong content

<svg width="2048px" height="2048px" viewBox="0px 0px 2048px 2048px"
xmlns="http://www.w3.org/2000/svg" version="1.1">

Workaround the bug by removing the px from the viewBox string before loading
the viewBox values.

C. Boemann committed changes in [calligra] /textshape/dialogs:

Make sure linespacing is applied and also make usre we do the inheritance check

However the fix contains a new string so it can't be backported to 2.4 series

C. Boemann committed changes in [calligra] /widgets:

Remove the filter colors functionality in in the color popup
This should fix a crash due to index not being correct

Also make sure we actually intialize with a palette

Okay to backport?

Gopalakrishna Bhat committed changes in [calligra] libs/odf/KoXmlWriter.h:

With gcc 4.7 installed we where not able to save a odt file because the xml file that was generated was
missing the '>' for a tag. Example
<manifest:file-entry manifest:media-type="" manifest:full-path="Thumbnails/thumbnail.png"
</manifest:file-entry>

The missing close tag was because while doing a stack.pop the hasChildren (a bitfield) of Tag was not
populated correctly. This patch fixes this problem(workaround for a gcc bug? not sure)


REVIEW: 104677

C. Boemann committed changes in [calligra] /flake:

Fix shadows for both single shapes and shape group

it also fixes if a shape is child of another shapecontainer

There is some lingering bug with the default tool not using the bounding box
correctly (which can be seen by rotating a shape group)

Shadows for shape groups also don't work correctly through load/save/edit
cycles, but that is not really related to this.

Multimedia

Sven Krohlas committed changes in [amarok] src/services/amazon/AmazonStore.cpp:

Do not show the missing Amazon location warning on startup if the service is hidden

This is annoying for users who do not want or cannot use the store.


FIXED-IN:2.6

Alex Merry committed changes in [amarok] /:

MPRIS2 compliance: do not use track ids that start with /org/mpris/

The spec says these are reserved.

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/rekonqmenu.cpp:

Get extremely sure rekonq menu button exists when used :)

Andrea Diamantini committed changes in [rekonq] src/urlbar/urlresolver.cpp:

Let rekonq work everytime with uppercase digited urls

David Edmundson committed changes in [ktp-accounts-kcm] src/add-account-assistant.cpp:

Don't set initial presence message to the string "online"


Reviewed-by: Martin Klapetek

Joris Guisson committed changes in [ktorrent] /:

Catch SIGINT and SIGTERM and do a clean shutdown

David Edmundson committed changes in [ktp-text-ui] lib/chat-widget.cpp:

Mark the channel as disconnected when the channel disconnects, instead of watching the connection status




Reviewed-By: Dominik Cermak

Joris Guisson committed changes in [libktorrent] /:

Webseeds now follow connection limits

User Interface

Hugo Pereira Da Costa committed changes in [kde-workspace] kwin/clients/oxygen/oxygenclient.cpp:

mark title transition as dirty when resizing client, to avoid flicker.

Features

Graphics

Islam Wazery committed changes in [digikam] /:

Added keyboard shortcuts to timeline view

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Implement inline-renaming for the new view-engine


FIXED-IN: 4.9.0

Thomas Lübking committed changes in [kde-workspace] /:

allow "under mouse" as regular placement strategy


REVIEW: 104650

Lamarque Souza committed changes in [kde-workspace/screenlocker] /:

Changes to incorporate screenlocker into ksmserver.
kscreenlocker is now a static library linked against
libkdeinit4_ksmserver.so. There is still another executable
(kscreenlocker_greet) that is responsible for drawing the QML unlock
screen (the one with the clock). I changed ksmserver to close
screenlocker right before closing the window manager, that is needed to
prevent kwin from becoming a "zoombie". Because of that sometimes you
will still be able to see the home screen right before the computer
finally shuts down.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision 0954749...
Jekyll Wu committed changes in [konsole] /:

Add support for KDE Web Shortcus

There is a submenu in the context menu for searching selected text using
any of the enabled search provider and opening the result in the default
web browser.

This could be useful for searching compilation failure messages, warning
messages in logfile, etc.

DIGEST:
FEATURE:
FIXED-IN: 4.9.0
REVIEW: 104493

Diffs: 1, 2, 3, 4, 5 Revision caaa91a...
Jekyll Wu committed changes in [konsole] /:

Allow searching scrollback in konsolepart

No keyboard shortcuts are provided because they often conflict with
actions from hosting applications. The only way to use this searching
feature is from context menu


FIXED-IN: 4.9.0
REVIEW: 104608

DIGEST:

Thomas Lübking committed changes in [kde-workspace] /:

detach killHelper process from KWin


FIXED-IN: 4.9
REVIEW: 104627

Lamarque Souza committed changes in [kactivities/KDE/4.8] service/plugins/CMakeLists.txt:

GlobalShortcuts Plugin for ActivityManager (kamd).
Thanks to makis marimpis for this patch.

REVIEW: 104428
, 273467
FIXED-IN: 4.8.3

Multimedia

Sven Krohlas committed changes in [amarok] /:

move the Free Music Charts script from playground/ to src/

That feature is part of VLC by default and is going to be included in
Tomahawk soonish, too.

The script is very well tested, very popular and received a lot of
positive feedback during the last few years. So I don't see any reasons
not to include it. Don't prove me wrong. ;-)

Also there is a massive copyright debate going on in Germany and some
free music artists complained to me, that it is nearly impossible to get
attention for their music, as traditionial media are more or less dominated
by the large major labels. So let's help those artists. :)

DIGEST: Ship the Free Music Charts script with Amarok by default

Matěj Laitl committed changes in [amarok] /:

Complete iPod collection rewrite (also supports iPad, iPhone)

This is a result of 3-month effort to make Amarok iPod-like device
support future-proof and less buggy by using more modern MemoryMeta
framework to manage tracks internally.

The new plugin still uses libgpod [1] to access the devices and
supports all devices supported by it. The newest models may need the
infamous libashab.so library.

FEATURES:
* Small configuration dialog for iPods that shows troubleshooting information
and allows to change iPod name.
* Improved usability of iPod playlists: iPod collection automatically transfers
tracks dropped to iPod playlists to iPod when it is needed.
* Tracks can now be transcoded when transferring them to iPod.

CHANGES:
* optional libgpod dependency raised to 0.8.2 to support newest iPods.
* Amarok now prevents accidental unmounting of iPods in (small) time-frames
when iTunes database on iPod is not yet updated.
* Amarok detects when iPod is to be ejected from system and gracefully
disconnects it when it occurs.
* Hitting the eject button on iPod collection ejects it also from the system.
* iPod collection now detects whether iPod is safe to write and marks iPod
as read-only if not. This prevents "iPod shows 0 tracks" problem.
* Correct progress bar advancement when transferring tracks to iPod.
* iPod Collection supports multiple simultaneous cancellable transfers.
* Improved dialog to initialize iPod.

BUGFIXES:
* Detection and elimination of stale and orphaned iPod tracks now works
correctly; users are notified about these when iPod is plugged in.
* iPod playlists now work correctly.
* Show correct error when transferring unsupported files to iPod.

[1] http://www.gtkpod.org/wiki/Libgpod







FIXED-IN: 2.6
DIGEST: Amarok's iPod support is completely rewritten fixing many bugs
and adding features

Nicolás Alvarez committed changes in [kde-ruleset/kdemm-myway] /:

kdemultimedia: turn into a more traditional layout of rule files.

The kdemultimedia rule files were intentionally missing the final
'match /' rule, so that they could run at the same time by passing all
the files to svn2git at once, followed by a kdemm-bottom-rules file
containing *only* the 'match /' rule.

The problem is that then the rule files by themselves are incomplete,
they won't work without the bottom-rules file. This is incompatible with
the automation scripts I use to run conversions (especially the 'convrun'
that runs them on dewey).

In addition, I fear it could cause problems with the conversions
themselves: if a path is matched by more than one rule, its presence
in the repos would depend on the order the rule files are given to svn2git.

This commit adds the "match /" rule to all the individual rule files
and removes kdemultimedia-bottom-rules.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision c09b685...

Networking Tools

Joris Guisson committed changes in [ktorrent] /:

Add bytes left to download column in View

Joris Guisson committed changes in [ktorrent] /:

Tracker grouping script now uses the domain name of the tracker

Joris Guisson committed changes in [ktorrent] /:

Add new add trackers dialog with url completion

Dominik Cermak committed changes in [ktp-kded-module] /:

Make it possible to restore presence on login

It uses the ConnectsAutomatically property and the AutomaticPresence.
In the kcm you can enable/disable this feature (ConnectsAutomatically
is set) and on every presence change the new presence is set as the
AutomaticPresence.
This way mission-control cares for setting the saved presence as soon as
possible.

If you want to manage this manually you can change the setting in
ktelepathyrc:

[KDED]
autoConnect=manual



REVIEW: 104363

Other

Ben Cooksley committed changes in [repo-management] hooks/hooklib.py:

Add support for the new Commit Link field in Bugzilla.

Bug 298120:
 
15450 days
Diffs: 1 Revision 40671ef...

Optimization

Networking Tools

Bernd Buschinski committed changes in [konversation] /dcc:

Set DCC Transferview update interval based on global KDE GraphicEffectLevel

ComplexAnimationEffects 500ms
SimpleAnimationEffects 1000ms
NoEffects/GradientEffects 2000ms

As KDE default is ComplexAnimationEffects, the default remains 500ms

Utilities

Aleix Pol Gonzalez committed changes in [muon] discover/MuonInstallerMainWindow.cpp:

Create a disk cache for the images

Improves dramatically the experience on the grid view with all the screenshots.

Other

Graphics

Aurélien Gâteau committed changes in [gwenview] lib/crop/cropwidget.cpp:

Rework crop ratio combobox

- Name the ISO sizes more appropriately
- Introduce sections to group landscape and portrait ratio

KDE Base

David Faure committed changes in [kdelibs/frameworks] /:

Some more KUrl-QUrl conversion.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 732e452...
David Faure committed changes in [kdelibs/frameworks] /:

kdeui is KUrl-clean now

Diffs: 1, 2, 3, 4, 5 Revision 2f980f0...
David Faure committed changes in [kdelibs/frameworks] /:

Fix QUrl porting bug; documented the trap more clearly.