Issue 233

29th April 2012 by KDE Commit-Digest Team

Contributors

Mutlu Inek
Marta Rybczynska
Jaka Kranjc

This Week...

Dolphin view can be synchronized with terminal location. Konsole has two new profile options for the copy & paste mouse behavior. More search options in Dolphin with Nepomuk. Google Sync Bookmarks implemented in rekonq. The order of units is now ensured in the whole Calligra UI. The star rating may be hidden in KPhotoAlbum.

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

[]     

Graphics

[] []    

KDE Base

[] [] []   

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

[]     

Networking Tools

[] []    

User Interface

[]     

Utilities

     []

Games

  []    []

Other

[]     

There are 60 selections this week

Bug Fixes

Development Tools

Sebastian Doerner committed changes in /trunk/KDE/kdesdk/dolphin-plugins/git/pushdialog.cpp:

Git push dialog: Don't segfault at hitting git-svn's pseudo branches

Sebastian Doerner committed changes in /trunk/KDE/kdesdk/dolphin-plugins/git/pulldialog.cpp:

Git pull dialog: Don't segfault on git-svn's pseudo branches, disable ok if no valid branch selected

Sven Brauch committed changes in [kdev-python] /:

Fix a crash with fancy generator ranges, and add a unit test for that

Educational

Barth Netterfield committed changes in /branches/work/kst/portto4/kst/src:

When saving data objects, sort them first so that they are not saved
before things they depend on. This will not fix old kst files where
the data objects are out of order, but it will prevent bad kst files
from being created in the future.

Barth Netterfield committed changes in /branches/work/kst/portto4/kst/src/libkst/datavector.cpp:

BUG:
data vectors were reloading the entire file each time they got new data,
rather than shifting them. And shifting didn't use memmove.

These changes should speed up real time significantly.

Dennis Nienhüser committed changes in [marble/Touch/1.3] src/lib/routing/RoutingModel.cpp:

Graphics

Tobias Koenig committed changes in [okular] /:

Improve auto play behaviour of videos

Use the auto play property of movies that are not started via
the 'page open' action. That's the case for Rendition-based videos
from PDF documents for example.

Diffs: 1, 2, 3 Revision 8683822...
Marcel Wiesweg committed changes in [digikam] /imageeditor:

Use FileActionMngr to copy attributes in ImageWindow.
Add code to reset the database rotation flag in case of replacing a preexisting file.

Marcel Wiesweg committed changes in [digikam] /database:

Consolidate code for copying attributes in CollectionScanner and fix copying of tags.

Tags cannot simply be copied at the lowest level: The SQL fails in case tags
are already set, but much more important: internal tags such as history tags
must not be copied. Use TagsCache and ImageInfo facilities to copy tags properly.

KDE Base

Peter Penz committed changes in [kde-baseapps] dolphin/src/kitemviews/private/kitemlistheaderwidget.cpp:

Reset to ascending sort order when changing the column

When changing the sort-column the sort order should always be reset
to 'ascending' to by consistent with the QListView behavior.


FIXED-IN: 4.9.0

Jekyll Wu committed changes in [konsole] data/keyboard-layouts/default.keytab:

Allow Shift+Arrow to be passed into to applications like mc and vim

Note: action shortcuts take precedence of keybindings. So to use
Shift+Arrow in mc/vim, make sure they are not set as action shortcuts.



FIXED-IN: 4.8.3

Alex Fiestas committed changes in [bluedevil/1.1] src/wizard/pages/discoverpage.cpp:

If the device is a Keyboard, move to the keyboard page.

Thanks to rbelem for lettimg me steal his bt keyboard at UDS xD

Frank Reininghaus committed changes in [kde-baseapps] /src/kitemviews:

When Esc is pressed, clear the selection and cancel the keyboard search

This patch restores the Dolphin 1.x behaviour that Esc clears the
selection (Dolphin 2.0 did not have an easy way to clear the selection
using the keyboard so far). Moreover, Esc now also cancels the current
keyboard search. This fixes the problem that the only way to cancel the
search is to wait until the timeout has expired.



(cherry picked from commit d3b1312d3edc615b03fb17c1a5fa62ccb61cdabd)

Aurélien Gâteau committed changes in [kde-runtime] plasma/declarativeimports/plasmacomponents/qml/ToolButton.qml:

Toolbutton: Fix layout issues

- Improve spacing between icon and text
- Do not enforce a minimum width

Having a minimum width does not make much sense for a ToolButton:
1. It should aim at using the minimum amount of horizontal space when
used in a ToolBar.
2. It looks unbalanced when used with an icon because the content is
flushed to the left, leaving a large amount of white-space on the right.

REVIEW: 104735

Alex Fiestas committed changes in [bluedevil/1.1] src/daemon/obexftpkded/ObexFtpDaemon.cpp:

Cleanly remove all ObexSession


(cherry picked from commit fa722d611c661509d8fd819f484cc748d060e8b3)

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Details mode: Fix wrong required column-width calculation


FIXED-IN: 4.9.0

Peter Penz committed changes in [kde-baseapps] /src/views:

Never pass null-items to version-control-plugins

Some plugins are not prepared for this and might crash. Although
the additional check in VersionControlObserver::actions() should not
be necessary because of the fix in DolphinView, it is left here
to catch potential other cases where a null-item might get passed
accidently.

Thanks to Ilya for initially patching the Box-plugin which gave
a hint whats going wrong.


FIXED-IN: 4.9.0

Alex Fiestas committed changes in [bluedevil/1.1] src/daemon/helpers/filereceiver/openobex/filetransferjob.cpp:

This job should be async to do not run into race conditions.


(cherry picked from commit 0ffccae9e54bca8bcfb6be28903c29ed809c06e1)

Alex Fiestas committed changes in [bluedevil] /daemon/kded:

Set a new Object as parent of BlueZAgent

You can't register a child of a parent exposed with ExportChildObjects, if
you do so the app may crash.

for not making this patch too big I'm using the parent() reference from
the BlueAgent object itself to delete the parent and this will delete
the agent. I will improve it in BlueDevil 2.0

Versions minor to 1.3 are not affected by this bug since they use qApp
as a parent instead of BlueDevilDAemon.

Alex Fiestas committed changes in [bluedevil/1.1] src/monolithic/monolithic.cpp:

Only empty the Overlay if there are powered devices.

Patrick Spendrin committed changes in [kate] kate/plugins/filetree/katefiletreemodel.cpp:

check for an absolute path in the correct way.

Frank Reininghaus committed changes in [kde-baseapps] /src/kitemviews:

When the current item is removed, make -1 the current index temporarily

This fixes two problems:
1. KItemListKeyboardSearchManger can cancel the current search when a
new folder is opened (note that this action removes the current item
from the view).
2. The view can underline the new current item (which is the item that
used to be below the removed item). Note that this did not work
before because the view did not receive a currentChanged() signal in
this case and therefore did not update the "current item" status of
the new current item.



REVIEW: 104709
(cherry picked from commit 68ce395a192362969783615e50a8004d3029eb7e)

Alex Fiestas committed changes in [bluedevil/1.1] src/wizard/pages/ssppairing.cpp:

If the device gets paired and no button has been clicked, page is valid

Wiimote is (I think) the first case where SSP is done without having
to confirm any code, this happens because Bluez is doing everything
internally for us (generating the pin for Wiimote). Actually Wiimote
uses legacyPairing internally though bluez is returning false on
legacypairing.

To make this work BlueZ 4.96 is needed

Aaron J. Seigo committed changes in [kde-workspace] /taskmanager:

tired of launchers not working because there isn't a .desktop file

we KNOW when there is an exec that we can run it; for the broken apps out there
that do not have a .desktop file, are not in the fix-up lists AND can not be run
from their executable .. screw 'em. i'd rather have the real world work even if
that means edge case applications written by idiots fail.

Diffs: 1, 2, 3 Revision 3a4b9c8...
Thomas Lübking committed changes in [kde-workspace] kwin/geometry.cpp:
Martin Gräßlin committed changes in [kde-workspace] /:

Do not create Deleted on Workspace Shutdown

When the Workspace is shutting down the compositor is torn down
before Clients and Unmanaged are released. This means that there
is no need to create the Deleted windows.

Furthermore creating the Deleted manipulates the stacking_order
while Workspace dtor loops over this list to release all clients.
This may cause crashes.


FIXED-IN: 4.9.0
REVIEW: 104690

KDE-PIM

Laurent Montel committed changes in [kdepim] libkdepim/recentaddresses.cpp:

Fix Bug 128365 - edit recent addresses: add sorting order and modifier

selection
FIXED-IN: 4.9

Dan Vratil committed changes in [akonadi-google] /:

Don't update event UID after it's created

Untill now we tried to update UID of a newly created event after we received
the UID from Google, but KOrganizer didn't cope well with this.

This patch removes the IteModifyJob which was updating the UID. We rather
keep the KOrganizer-generated UID and we only change it in the payload before
serializing it and sending it to Google (for instance when we want to modify
the event). This makes KOrganizer happy.


FIXED-IN: 0.3.1

Christian Mollekopf committed changes in [kdepim-runtime] /nepomukfeeder:

Don't remove resources before updating them.

We can simply overwrite the properties. Before also PIMO things were removed because they are marked as subresource of the item,
(which is correct), but therefore linked resources were lost on every update.
This patch resolves that, with the drawback that plugins need to take care of outdated subresourcecs themselves.

Diffs: 1, 2, 3, 4, 5 Revision efa7604...
Laurent Montel committed changes in [kdepim] kmail/kmreadermainwin.cpp:

Fix Bug 298181 - add title of messagesright window

FIXED-IN: 4.8.3

Laurent Montel committed changes in [kdepim] kontact/plugins/korganizer/todosummarywidget.cpp:

Fix Bug 298861 - Kontact crashes when switching to summary.

Todo can be null. Need to verify it

FIXED-IN: 4.8.4

Office

Boudewijn Rempt committed changes in [calligra/krita-iterators2-rempt] /image/tiles3:

Handle the situation where the ng iterators get an empty stretch

Assert in developer mode so we know where to add the check for emptiness
before creating the iterator; make the iterator check at least a pixel
in release mode.

We cannot re-instate the old isDone() api because that would impair
performance too much:

13:26:45 < boud> CyrilleB: do you remember why the NG iterators don't have an isDone() check so the loop always checks at least once? (with do {} while
(it-NextPixel())
13:45:34 < CyrilleB> boud: performance
13:46:13 < CyrilleB> boud: especially since in 99.99% of the case, one does have something to iterate over
13:50:34 < boud> aah
13:50:49 < boud> because it's the reason of the crash in KisSelection::invert
13:52:29 < boud> maybe if the rect is empty we should make it have a width/height of one so there's always one pixel read in all cases
13:53:04 < CyrilleB> or rather have an assert if you try to create an iterator with a null width/height
13:53:20 < CyrilleB> (or both, if you want to ensure good behaviour for users)
it goes wrong
13:53:35 < CyrilleB> s/good behaviour/non crashing behaviour/

Diffs: 1, 2, 3 Revision 3c5acc6...
Alvaro Soliverez committed changes in [kmymoney] /views:

To delete a report from the list, do not open the report.
This helps when trying to remove a faulty report, which cannot be opened
correctly.

REVIEW:104763

Sven Langkamp committed changes in [calligra] krita/plugins/formats/pdf/kis_pdf_import.cpp:

fix crash on opening pdf with special characters in the path

Friedrich W. H. Kossebau committed changes in [calligra] /:

Fixes: ensure same order of units in whole Calligra UI, have ruler and page layout dialog update to change of document's unit type

also tune KoUnit API a little:
* rename KoUnit::unit(...) to KoUnit::fromSymbol(...) <- more Qt'ish
* turn static KoUnit::unitName(KoUnit) into member method KoUnit::symbol() <- as typical use-case is on existing KoUnit instance, also shorter and more OOed
* rename KoUnit::Unit to KoUnit::Type <- "type" feels a better term here
* added KoUnit::type() and KoUnit::setFactor(...) <- useful in a few places
* remove KoUnit::unitDescription(...) from API <- not used outside
* rename KoUnit::PixelVisibility to KoUnit:: ListOption <- more general, some might want to add other flags like HideImperial

And adds unit tests for the touched KoUnit API

Thanks to boemann and Cyrille for making it compile with Qt 4.7 as well

REVIEW: 104626

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 32 more) Revision 5b31b80...
Alvaro Soliverez committed changes in [kmymoney/4.6] kmymoney/reports/pivottable.cpp:

Bugdet reports: Skip budget account if periods for the account
have not been loaded

REVIEW:104766

Multimedia

Matěj Laitl committed changes in [amarok] src/core-impl/collections/ipodcollection/IpodCollectionFactory.cpp:

IpodCollection: rework iPhone identification to prevent false-positives

...false-positives that would otherwise appear once the change [1] is
merged into kdelibs. (should happen for 4.8.4)

[1] https://git.reviewboard.kde.org/r/103028/

Colin Guthrie committed changes in /branches/KDE/4.8/kdemultimedia/kmix/backends/mixer_pulse.cpp:

Prevent kmixctrl running with PulseAudio.

kmixctrl should not save/restore volumes when PulseAudio is used, but
our event loop detection was such that the PulseAudio mixer would refuse
to run as kmixctrl was marked as a non-GUI program

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

DSL: do not send empty service field to NetworkManager or it will not
create the connection.


FIXED-IN: 0.9.0.2

Andrea Diamantini committed changes in [rekonq] /:

Fix opensearch add shortcut handling

(at least on every site tested, but opensearch.org itself. Broken?)

Andrea Diamantini committed changes in [rekonq] /:

Clean up url management

- Let ftp url(s) work again
- Do NOT check url twice via KUriFilter (removed MainWindow::filterUrl)
- ensure we are lowering just http url hosts
- mailto via urlbar handling

Andrea Diamantini committed changes in [rekonq] /:

Do not show "closed tabs" page after crash when directly opening an URL

User Interface

Ruslan Kabatsayev committed changes in [oxygen-gtk/gtk3] src/oxygenthemingengine.cpp:

Other

David Edmundson committed changes in [lightdm] /:

Make sessions model class with a property to show/hide the entry "Show Last Used Session"

Updated the classic theme to use this. Userbar theme does not have this entry.

David Edmundson committed changes in [lightdm] themes/classic/main.qml:

In the classic theme highlight select password field content and force focus on wrong passwords

Features

Graphics

Miika Turkia committed changes in [kphotoalbum] /:

Toggle showing of rating on Viewer InfoBox

Added possibility to toggle on or off the viewing of rating in InfoBox
in Viewer.

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Provide additional default groups for the Places Panel

If Nepomuk is enabled, it is now possible to easily search for
some most common queries by having additional groups.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 07176a8...
Alex Merry committed changes in [kdelibs/KDE/4.8] /:

Allow QML items to be associated with operations in Plasma::Service

QML items derive from QGraphicsObject, but not QGraphicsWidget. We
actually only need QGraphicsObject (for the enabled property).

This allows calling (dis)associateWidget from QML (eg: in javascript
plasmoids) and passing in a QML item.

Diffs: 1, 2, 3 Revision 4699bac...
Martin Gräßlin committed changes in [kde-workspace] /:

Key Bindings for Switching between Windows of current Application

Additional TabBox Mode which allows to switch between all open
windows of the current selected application. By default Alt+tilde
is used which is on qwerty just one key above tab. For non-qwerty
layouts the shortcut is unfortunately not convenient.

REVIEW: 104730

FIXED-IN: 4.9.0

Frank Reininghaus committed changes in [kde-baseapps] /src:

Update the view when changing the directory using 'cd' in the terminal

Thanks to Jekyll Wu for helping to implement this feature!


FIXED-IN: 4.9.0

Jekyll Wu committed changes in [konsole] /:

Add two profile options for the copy & paste behavior of mouse

* support "automatially copy selected text into clipboard"
* mouse middle button can be customized to paste from selectio or
clipboard

The first feature might look like a unnecessary duplicate of the
"synchronize selection and clipboard" feature of Klipper. However, that
klipper feature is generally problematic, while doing it only in Konsole
is generally useful and harmless.


FIXED-IN: 4.9.0
REVIEW: 103861
DIGEST:

KDE-PIM

Laurent Montel committed changes in [kdepim] /core:

Fix Bug 298245 - google like search behaviour in quick search

now we can search in search line as separate string. So it will improve
search.

FIXED-IN: 4.9

Laurent Montel committed changes in [kdepim] /:

Now we can specify what we want to backup/restore

Diffs: 1, 2, 3, 4, 5 Revision 91d5f92...

Office

C. Boemann committed changes in [calligra] /:

Make the Video shape loading and saving work, even to and from
LO/OO Impress (although impress and multimedia atm is useless)

also improve the painting of the actual shape with a nice icon

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision c5a81cf...

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Google Sync Bookmarks in rekonq!

- Added UI bits to configure Google Bookamrks Sync
- Implemented sync, 2-way merging local and remote bk
- Remember to not update local history while remotely
adding bookmarks
- Encode parameters of add bookmarks request while posting data.
- (adjam) fix compile warnings

This is the squashed commit of Situ's work on Google Bookmarks Sync
SQUASHED BY: adjam ;)

REVIEW: 104673
DIGEST: Google Bookmarks Sync
REVIEWED BY: adjam

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision cd6eee4...

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

more possibilities how to instantiate Hand()

so we can give Hand a pointer to Game.
This weakens the very strict API where Hand knows nil about Game
but that would probably be difficult to maintain longterm anyway.
In practice, the API is still the same - we do not have to define
a game but if we do we get better debug log messages (next commit)

Diffs: 1, 2, 3, 4, 5 Revision 1291841
Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

framework for defining AI filters in rules

the standard AI filters would never be able to reach those limit
hands which do not have the standard pattern.
One empty example is included.

Optimization

KDE Base

Martin Gräßlin committed changes in [kde-workspace] kwin/composite.cpp:

Only create decoration once during Client::manage

Client::manage calls setupCompositing on the not
yet fully managed client before it wants to create
the window decoration. This means the decoration is
created twice and maybe even if not needed (noBorder
not yet set).

If the Client is not yet managed setupCompositing
will not update the decoration - it will be handled
by manage later on.

Furthermore if compositing is not active, setup
compositing does not have to perform any action.

REVIEW: 104758

Other

Utilities

Aleix Pol Gonzalez committed changes in [muon] discover/qml/ApplicationsGridDelegate.qml:

Improve ApplicationGridDelegate in many ways

- Reduce redundant constructions and unneeded id's
- only set the description component when needed
- remove conflicting width definitions: anchors.left/right
vs. width
- Don't show any rating if there are no reviews.

Games

Christian Krippendorf committed changes in /branches/work/krippendorf/kmahjongg:

Items are shown and got their layout on the board. For now, the whole tile group is not centered! Also the size changed to fit on the given space of the GameWidget.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1291336