Issue 235

13th May 2012 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Jaka Kranjc
Mutlu Inek
Myriam Schweingruber

This Week...

KPhotoAlbum can search for videos without thumbnails on startup. Dolphin allows to remember view properties for the search mode. Screen edge bindings for scripts and scripted effects implemented in KDE Workspace. New assert methods and Get Hot New Stuff support are available for KWin scripts. Abstract calendar and printing of the highlighted part of an email in KDE-PIM. In Calligra, author information gets configurable on a settings level, floating message class added. GSoC work in cantor and bibliography database in Calligra. Bugfixes in Amarok, KDE-PIM and the KDE base packages.

Statistics

Commits 2451 by 162 developers
Open Bugs 22480
Open Wishes 16908
Bugs Opened 455 in the last 7 days
Bugs Closed 650 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
175
 
/branches/stable
129
 
/trunk/KDE
33
 
/trunk/www
29
 
/branches/work
18
 
/trunk/l10n-support
18
 
/trunk/playground
13
 
/src/oxygenthemingengine.cpp
11
 
/doc/kate
9
 
/services/amazon
9
 
Files Developer Commits
306
 
Jesper Pedersen
102
 
216
 
Laurent Montel
72
 
132
 
Gilles Caulier
50
 
111
 
Yuri Chornoivan
40
 
114
 
Sebastian Kügler
39
 
99
 
Alexander Neundorf
34
 
96
 
Burkhard Lück
34
 
96
 
T.C. Hollingsworth
34
 
99
 
Aleix Pol Gonzalez
33
 
93
 
Marcus Gama
31
 

Internationalization (i18n) Status

Language Percentage Complete
Dutch (nl)
96%
 
German (de)
94%
 
Estonian (et)
94%
 
French (fr)
92%
 
Italian (it)
90%
 
Danish (da)
87%
 
Chinese Traditional (zh_TW)
84%
 
Catalan (ca)
83%
 
British English (en_GB)
82%
 
()
79%
 

Bug Killers

Person Bugs Closed
Dawit Alemayehu
27
 
Laurent Montel
25
 
Boudewijn Rempt
22
 
Myriam Schweingruber
20
 
Jekyll Wu
18
 
Christian Esken
17
 
Christoph Feck
16
 
Christophe Giboudeaux
13
 
Martin Gräßlin
12
 
Dennis Nienhüser
12
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

[] [] []   

Graphics

[] []    

KDE Base

[] [] []   []

KDE-PIM

[] []    

Office

[] [] []   []

Konqueror

     

Multimedia

[] []    

Networking Tools

[]     []

User Interface

     

Utilities

[] [] []   

Games

     

Other

     

There are 69 selections this week

Bug Fixes

Development Tools

Aleix Pol Gonzalez committed changes in [kdevelop] /cmake:

Prevent different threads to modify the KDirWatcher instance at the same time

Educational

Dennis Nienhüser committed changes in [marble] /:

Handle download of map regions for themes without texture layers.

Fixes crash when opening the download region dialog when e.g. the plain
map is opened. Related: Crash when attempting to download an empty set.
Crash when switching to a map theme without texture layers after the
download region dialog was opened at least once before.

Aleix Pol Gonzalez committed changes in [kalgebra] src/consolehtml.cpp:

When adding plots from the console, use the resulting expression instead of the input

This way we don't move declarations around.

Graphics

Alexander Potashev committed changes in [kipi-plugins] vkontakte/vkalbumdialog.cpp:

Fix crash due to infinite recursion

Guilty commit: 0e0318e5fed517f50a2d356fda88fa3ec3c7d90f "use dedicated namespace"

CCMAIL: Gilles Caulier

Marcel Wiesweg committed changes in [digikam] /:

Signal toggled() to apply state will not be emitted when the per default unchecked checkbox remains unchecked.
Call explicitly.

KDE Base

Jekyll Wu committed changes in [konsole] src/TerminalDisplay.cpp:

Do not clear selection after pasting.

The old behavior has a long history, initially introduced by commit
1e3c3e27 more than 10 years ago. I fail to understand its intention
(some safeguard?), and I think keeping the selection is more useful in
work flow.

Keep it in master branch for now. No backporting.

Peter Penz committed changes in [kde-baseapps] /src:
Martin Tobias Holmedahl Sandsmark committed changes in [kdelibs/KDE/4.8] /:

Fix animation of scaled GIF images.

Firstly, implement the AnimProvider::clone function in the GIF loader.
This enables the creation of scaled AnimationProviders.

Secondly fix the ImagePainter so that it uses the set size instead of
the size of the base (unscaled) image.

Lastly fix RenderImage::updatePixmap so that it takes scale into
account when deciding which rect to repaint.

Diffs: 1, 2, 3 Revision 35526c4...
Thomas Lübking committed changes in [kde-workspace] kwin/effects.cpp:

handle m_currentBuildQuadsIterator validation independent form painting pass

issue is that the effect chain may (will) change between two paint passes and buildQuads is called outside the paint pass
(shadows / decos whatever changes) so that the iterator may dangle


FIXED-IN: 4.9
REVIEW: 104881

Martin Gräßlin committed changes in [kde-workspace] kwin/effects/fadedesktop/package/contents/code/main.js:

Exclude minimized and windows not on current desktop from fade desktop


FIXED-IN: 4.9.0

Martin Gräßlin committed changes in [kde-workspace] kwin/effects/cube/cube.cpp:

Ensure ScreenTransformation matrix is reset after rendering cube

Cube effect modifies the ScreenTransformation matrix. While each
window resets the matrix on a global level it's not reset. That
means if the last rendered window had the screen rotated the
ScreenTransformation keeps the rotation even after the cube
ended. This causes a rotated window in e.g. TaskbarThumbnails.

REVIEW: 104918

Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] kioslave/http/http.cpp:

Reprompt the user with a proxy authentication dialog even when the last proxy
authentication dialog was cancelled.


FIXED-IN: 4.8.4

Michael Pyne committed changes in [kdelibs/KDE/4.8] kdeui/icons/kiconloader.cpp:

Delete cached icons in-memory when changing icon theme.

This should hopefully fix bug 294044 ("Dolphin won't accept custom
icons"), although I can only partially reproduce it. I was able to
verify that icons left in the KSharedDataCache for running processes are
preferred without checking the new theme, which this patch fixes.


FIXED-IN:4.8.4

KDE-PIM

Laurent Montel committed changes in [kdepim] mailcommon/filter/filteractionsetstatus.cpp:

Fix Bug 297134 - Filter action "mark as read" doesn't mark as read

anymore since 4.8.1
FIXED-IN: 4.8.4

Allen Winter committed changes in [kdepim] /dialogs:

Fix connect() when checking radio buttons

FIXED-IN: 4.8.4

MERGE: 4.8

Laurent Montel committed changes in [kdepim-runtime] agents/maildispatcher/sendjob.cpp:

Fix Bug 299344 - Original sender is not kept when using "Send Again"

FIXED-IN: 4.8.4

Office

Thorsten Zachmann committed changes in [calligra] filters/stage/kpr2odf/Filterkpr2odf.cpp:

Strip white spaces when importing kpr files

Seems this breakage went unnoticed when the stripping of whitespaces was removed.
Fix the problem by stripping the white spaces when importing the old documents
which always stripped the white spaces.

Ok to backport?

Boudewijn Rempt committed changes in [calligra] /:

Do not delete some static stuff on exit

Depending on the order of deletion and other variables, these delete
calls might cause a crash on exit or not. And there's actually no
memory leak, since this is all static stuff that's present for the
lifetime of the application.

In this case, it's better to just quit, than explicitly free all memory.
The bytes are gone with the process, and there isn't stuff that needs
to be written on quit here.

Boudewijn Rempt committed changes in [calligra] /plugins/extensions/dockers/advancedcolorselector:

Don't add colors to the history while erasing



We probably have multiple color history implementations in Krita though,
those really should be squashed together.

Boudewijn Rempt committed changes in [calligra] libs/widgets/KoDockWidgetTitleBar.cpp:

Do not resize the docker column when collapsing the docker

We keep track of the pre-collapsed titlebar widget width now and use
that in the sizeHint() method.

Cristian Oneț committed changes in [kmymoney] /widgets:

Use a safer way to set the minimum width of the account combo.

Using QFontMetrics::maxWidth() was a bad idea because some fonts could
contain really wide characters (with a very low probability of appearing
in the account names) - see the bug that is fixed.

Instead of the width of the widest character in the font use the width of
the 'W' character which will produce a much more predictable result.

Even the Qt implementation uses the width of a know character ('x') to
compute a kind of minimum size.

Boudewijn Rempt committed changes in [calligra] /:

Fix issues with recovering autosave files

1) X-KDE-NativeExtension can be empty, in that case take mime->mainExtension.

Otherwise our autosave files are called .autosave, and that's not something
the filter's mime detection can handle

2) don't overwrite autosave files when running multiple unnamed modified
documents

3) tag the autosave files with the pid and use dbus to check which processes
that have autosave files are still active; don't offer to recover those

4) show the autosave files in a nice dialog with the ora/odf thumbnail
as a preview, and offer to recover them all.

REVIEW:104892

Multimedia

Matěj Laitl committed changes in [amarok] /:

Collection browser: don't add duplicate tracks in mimeData

That could have happened when you selected e.g. both album and a track
from that album -> the track would be added twice.

The implemented algorithm is done at QModelIntex level and is O(n)
where n is the number of selected tracks so this should be okay.

There is an unrelated bug with the Various Artists item that behaves
as entire collection when dragged. This will be fixed soon.

BUGFIXES:
* Don't add duplicates to playlist when dragging from collection


FIXED-IN: 2.6
DIGEST: Bugfix: Amarok now doesn't add unwanted duplicates to playlist

Sam Lade committed changes in [amarok] /:

Remove context view video applet

Unmaintained and broken for quite some time.


FIXED-IN:2.6

Matěj Laitl committed changes in [amarok] /:

AudioCdCollection: don't create a reference out of temporary var (crashfix)

There's following code in AudioCdCollection::updateProxyTracks():
const QString &urlString = url.url().remove( "audiocd:/" );

Which I think is wrong, because url.url() returns a temporary QString
and QString::remove() returns a reference to itself. However, the
temporary is AFAICS destroyed as soon as this line ends. This IMO
results in urlString being an invalid reference.

I'm not really sure about this, I haven't read C++ spec, but given many
users report crash on the following line, this could be the culprit.
I was never able to reproduce the bug, so I'm shooting blindly.

Reporters, please test reproducibility with current git and reopen if
this is not fixed.


FIXED-IN: 2.6
DIGEST: fix grave crash

Matěj Laitl committed changes in [amarok] /:

Daap::Reader: Don't use QList::[ on unreliable input, use ::value()

This should fix bug 280774, but I don't use DAAP collection, do I'm
shooting blindly.

BUGFIXES:
* Fix crash related to DAAP collection.

Reporters, if this doesn't solve your bug, please reopen.


FIXED-IN: 2.6
DIGEST: bugfix

Matěj Laitl committed changes in [amarok] /:

Hopefully fix crash in ContextView on startup

It is strange that simple initialization to zero fixes the problem, but
it fixes the crash for at least one reporter.

Reporters, please rebuild Amarok from current git and should loudly if
you can still reproduce the bug.

BUGFIXES:
* Fix crash on startup related to ContextView


FIXED-IN: 2.6
DIGEST: Amarok crashfix

Matěj Laitl committed changes in [amarok] /:

Move WriteTagsJob out of IpodCollection and use it everywhere

CHANGES:
* Album cover images are written in background to prevent freezes


FIXED-IN: 2.6
DIGEST: Amarok now writes back covers in background to prevent freezes

Networking Tools

Pali Rohár committed changes in /trunk/KDE/kdenetwork/kopete/kopete/contactlist/kabcexport.cpp:

Kopete export contacts dialog - Fix checking if contact was already exported

Before this commit Kopete show that all contacts (with contacts already
linked into addressbook) were not in addressbook.

Lamarque Souza committed changes in [networkmanagement/nm09] settings/configshell/manageconnection.cpp:

Fix hidden wireless network creation.


FIXED-IN: 0.9.0.2

Martin Klapetek committed changes in [ktp-common-internals] KTp/Models/contact-model-item.cpp:

Fix null pointer crash

Reviewed-by: David Edmundson

Andrea Diamantini committed changes in [rekonq] /:

move left modify action in favorites to be the update one

Also implement ThumbUpdater class to easily manage thumb updates

Martin Klapetek committed changes in [ktp-contact-list] /:

Make the delegate overlays code signicitantly simpler, fixes crash in the process

The overlays were in several classes, all deriving one from another. This commit merges several of the classes into one and removes unused and/or useless methods, thus simplifying the code and making it more readable, effective and easier to maintain.

Reviewed-by: David Edmundson
REVIEW: 104887

Utilities

Michel Ludwig committed changes in [kile] src/kile.cpp:

Force termination of Kile when the main window is closed.

Under some circumstances the Kile process would still remain in memory otherwise.

Features

Educational

Martin Küttler committed changes in [cantor/gsoc2012] /:

The basic featues of CommandEntry work

CommandEntry is usable, but not everything works as of yet:
- SyntaxHighlighting is crippled. It does not work in Maxima, but
in Qalculate some things are highlighted.
- Completion does not work, because Tabs are not recognised.
- The WorksheetTextItems do not look nice: They have a wierd border,
and the cursor is not shown.
- WorksheetTextItems are also too small, they should fill the whole
line.
- Cursor movement does not work for additional information blocks.
But I am not sure whether one should be able to navigate out of
those, as any modification outside should abort the evaluation
and destroy the additional information.
- There most certainly is more.
Other Entries can not yet be added to the Worksheet.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 40 more) Revision c79cb0b...

Graphics

Jesper Pedersen committed changes in [kphotoalbum] /:

Search for videos without thumbnails on startup

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 826c5b3...

KDE Base

Peter Penz committed changes in [kde-baseapps] /src:

Allow moving items to trash also for non-local files

See bug 188032 for an ongoing discussion. In case if this behavior
is really not wanted by users (the feedback on bugs.kde.org will
show), the review-request
https://git.reviewboard.kde.org/r/104915/ should be merged too
(after adjusting some parts of the code).

Jekyll Wu committed changes in [konsole] /:

Make sure the translucent background is available whenever possible

Now the Qt::WA_TranslucentBackground attribute is always set for the
mainwindow of konsole(regardless of whether compositing is available
when the window is created), just like in konsolepart.

I'm not 100% sure this approach is problem-free, but it works for me so
far under various environments and conditions. Do not hesihate to revert
it if you notice it causes big trouble.

Martin Gräßlin committed changes in [kde-workspace] /:

Asserts for KWin scripts

Further debugging functionality for KWin scripts. Added assert
methods validate the to be tested parameter and throw a script
error if the value is not valid.

Following methods are available:
* assert(value)
* assertTrue(boolean)
* assertFalse(boolean)
* assertEquals(expected, actual)
* assertNull(nullValue)
* assertNotNull(notNullValue)

All methods take an additional optional parameter which is used
as the error message if provided.

Methods to validate the number of arguments and types of the
parameters are added and throw syntax or type errors.

REVIEW: 104870

Diffs: 1, 2, 3, 4, 5 Revision 7d6d03d...
Peter Penz committed changes in [kde-baseapps] /src:

Allow to remember view-properties for the search-mode

Per default Dolphin remembers the view-properties for each search-URL
individually. However when being in the search-mode, where the
search-URL is different each time by definition, it should also
be possible for the user to adjust the view-properties. The DolphinView
is not aware about any "search-mode", so an interface has been added
to provide a "context" for storing the view-properties. The context
will be adjusted by the DolphinViewContainer in case if the search-mode
is active.

Diffs: 1, 2, 3 Revision 22cd19b...
Martin Gräßlin committed changes in [kde-workspace] /:

Screen Edge bindings for Scripts and Scripted Effects

ScreenEdge is changed to emit a signal whenever a screen edge
got activated without an action or effect taking care of it.

A Script can reserve one to many callbacks for an edge and the
callback get's triggered whenever the signal is emitted. On
deconstruction of the Script the edge is unreserved again.


FIXED-IN: 4.9.0
REVIEW: 104904

Peter Penz committed changes in [kde-baseapps] /src/views:

Allow to remember view-properties for search-results

Until now it was only possible to adjust the view-properties for
searching in general. Now the view-properties can be adjusted
dependent on the query (e.g. images, documents, ...).

Martin Gräßlin committed changes in [kde-workspace] /kcmkwin/kwinscripts:

Get Hot New Stuff support for KWin Scripts

Button currently not yet shown as the category on kde-look is
still missing. This means the code is also completely untested.

REVIEW: 104877

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Fix Bug 259784 - It would be nice to be able to print only highlighted

parts of an email

FIXED-IN: 4.9

Albert Astals Cid committed changes in [kdepim] /:

Save size of message/mime splitter on change

This way when you change the mime size splitter and select a new message in the list
the expect thing happens (i.e. the sizes of the message/mime widgets remain the same)
(cherry picked from commit 1c448b1dbdceeb5a456ba7a4431551792a43ce1c)

REVIEW: 104916

Laurent Montel committed changes in [kdepim] /:

Add abstract Calendar (Evolution has calendar so we can import it)

Diffs: 1, 2, 3, 4, 5 Revision 6b9348e...

Office

Stephane Mankowski committed changes in [skrooge/Feature] /:

Better CSV and TXT exports of tables grouped by a column

Diffs: 1, 2, 3 Revision 5432d03...
C. Boemann committed changes in [calligra] /:

Make author information configurable on a settings level.

The Document Information dialog's Author tab becomes read only and just shows who
last saved the document.

The author information is shared across all calligra apps, and can hold any number of
author profiles. The user creates and deletes author profiles through the settings dialog.

The profiles are stored in the calligra wide config.

In the settings menu a submenu should be added where you can choose the active profile.

The active profile is stored in the application's config.



It also solves the bug (no number) that save cycles number was never incremented

Boudewijn Rempt committed changes in [calligra] /ui:

Add a floating message class

This can be used to show a transient message that fades after some
time. It's used here to show the user the shortcut for getting out
of the full-screen mode.

Smit Patel committed changes in [calligra/words-gsoc-smit] /textshape:

Bibliography database user interface.
Loads citation database from sqlite file.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 44c61fb...

Multimedia

Sinny Kumari committed changes in [plasma-mediacenter] /:

Don't stop playing Music or Videos while viewing Pictures

Diffs: 1, 2, 3, 4, 5, 6 Revision ada11d6...
Martin Tobias Holmedahl Sandsmark committed changes in [juk/lyricswidget] /:

add lyricswidget

Diffs: 1, 2, 3, 4, 5 Revision 9fb22c5...
Sven Krohlas committed changes in [amarok] /:

Amazon store: popupdropper icons

Thanks again Fabi for the great work.

Hopefully I added them correctly to the popup dropper, but things seem
to work fine here. I also just realized that one icon is still missing:
load details.

Utilities

Michal Sciubidlo committed changes in [ark] /:

Add read support for cab archives.

Diffs: 1, 2, 3 Revision 4ede2c0...
Raphael Kubo da Costa committed changes in [ark] kerfuffle/extractiondialog.cpp:

Add Retry button to one of the extraction dialog's prompts.

As written by the patch author:
With this patch, there will be a working Retry button on the dialog
box made in ExtractionDialog::accept().

This implements an old TODO item written by Harald a few years ago
(commit f761cbd164c1015100d810ec3c02a60b78969891), and users are now
able to retry when an extraction into a subdirectory will overwrite an
existing location.

Submitted by: Nathan Mills
REVIEW: 104869

Aleix Pol Gonzalez committed changes in [muon] /:

Set a configuration KConfig file to provide the app some data.

The idea is that the packager should be able to provide some data
to the application to specify some distro specific sources.

At the moment there are 3 of them: it lets you choose what debian
screenshots instance you'd like to pull your information from, also
the ratings and reviews server and the featured apps.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 22b4628...
Alex Fiestas committed changes in [lightdm] /:

When the lid is closed, suspend the computer

REVIEW:104914

Diffs: 1, 2, 3, 4, 5 Revision dc77459...

Optimization

Educational

Andreas Cord-Landwehr committed changes in [rocs] /Interface:

Configure data types in separate dialog.

This solves the mixture of settings with global effect (to all
data elements of a type) with settings that only affect the current
data element. All configurations are now possible by calling the
data type properties menu.

Diffs: 1, 2, 3 Revision 16d0b61...

KDE Base

Jekyll Wu committed changes in [konsole] /:

Add cmdline options for the visibility of menubar and tabbar

Since the menubar and tarbar settings are now global instead of per
profile , those cmdline options are useful to allow users to override
the defautl behavior.

The --hide-menubar and --hide-tabbar options can be used together
to simulate the miminal interface of xterm. I'm not sure whether
--show-menubar and --show-tabbar will be widely used , but add them at
the moment for the sake of completeness.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 3ddc649...
Peter Penz committed changes in [kde-baseapps] /src:

Places Panel: Implement eject and teardown actions

Further fixes:
- Add/remove item when device has been added/removed
- Update emblem if the accessibility-state has been changed

Diffs: 1, 2, 3, 4, 5, 6 Revision 5640acb...

Office

C. Boemann committed changes in [calligra] plugins/textediting/spellcheck/SpellCheck.cpp:

Do layout too much. On big documents that can disasterous

In fact it's annoying we have to layout for this at all. We should store
this info in KoTextBlockData, and do our own drawing. It will be both more beautyful
and be prepared for visualizing both spelling and grammar and similar.

C. Boemann committed changes in [calligra] libs/textlayout/KoTextLayoutArea_paint.cpp:

Don't find x positions unless we need to, this should give a factor 2 speed up in text rendering

Boudewijn Rempt committed changes in [calligra] krita/image/kis_paint_device.cc:

Only clear pixels inside a paint device

On clearing pixels, only clear the pixels that actually have content, so
use the paint device's default bounds object to get the intersection
between the selection and the paint device.

Utilities

Aleix Pol Gonzalez committed changes in [muon] discover/qml/ApplicationsGridDelegate.qml:

Improve memory consumption of the screenshots in the grid delegate

Set a source size for the screenshots so that it doesn't keep
the full size version in memory.

Other

KDE Base

Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] /kio:

Revert commit 462a06ea as it causes many regressions. Use KIO::synchronousRun
to fulfill synchrounous XmlHttpRequest instead.

Unofrtunately this means that the fix for the crash reported in bug# 287778
is reverted until we can find a solution for the side effects of using nested
event loops.





FIXED-IN: 4.8.4

Dawit Alemayehu committed changes in [kde-runtime] /ikws:

- Moved the checkbox used to select preferred shortcuts into its own column to
prevent user confusion.

- Allow the shortcut list to be filtered using the shortcut texts.



FIXED-IN: 4.9.0
REVIEW: 104900
GUI: New translatable text

Dawit Alemayehu committed changes in [kde-runtime] /ikws:

- Replaced all references of 'search' with 'web shortcuts' since web shortcuts
are not only for doing search.

- Replaced all the WhatsThis help text with equivalent ToolTip text.

Note that this change only renames related config options, variables and GUI text.
In the future eveything, including file and class names, should be renamed to
reflect the current functionality of this plugin.


FIXED-IN: 4.9.0
GUI:

Office

C. Boemann committed changes in [calligra] words/part/KWGui.cpp:

Have a border around the canvas - it's the widgetstyle's responsibility to make sure
it looks nice

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Downloads search