Issue 237

27th May 2012 by KDE Commit-Digest Team

Contributors

Frederik Schwarzer
Marta Rybczynska
Myriam Schweingruber
Jaka Kranjc
Danny Allen

This Week...

Okular saves annotations locally. Delayed search in Calligra allows the users to type the whole word, adding of image lists possible; brush rotation is absolute to canvas rotation. Amarok is now capable of transcoding music when copying it to USB Mass Storage devices. Exponential notation supported in Kst. Play Previous and Play Next and other updates in miniplayer. Further preparations for drag-and-drop support in the places panel in Dolphin. Refactoring work in kdenlive. GSoC work in Cantor.

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[] [] []   

Graphics

  []    []

KDE Base

[] []    []

KDE-PIM

[] []    []

Office

[] [] []   []

Konqueror

     

Multimedia

[] []    []

Networking Tools

[] [] []   []

User Interface

     

Utilities

  []    

Games

  []    

Other

[] []    []

There are 80 selections this week

Bug Fixes

Development Tools

Oliver Kellogg committed changes in /trunk/KDE/kdesdk/umbrello:

PostgreSQLWriter::defaultDatatypes(): Fix last list entry as proposed in PR.
Thanks Nikita for well written bug reports.

Sebastian Doerner committed changes in /trunk/KDE/kdesdk/dolphin-plugins/git:

Correctly show the version state for directories containing ignored files.

Ignored files do not cause these directories to be shown as Unversioned any more.
Ignored files in the current directory are now also shown in a different color (by marking them as Ignored instead of simply Unversioned).


FIXED-IN: 4.9

Educational

Dennis Nienhüser committed changes in [marble] /:

Use smaller .png instead of .xpm cursors. Load from qresource.

This avoids runtime problems when the installation is incomplete
(data missing).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 0299004...

KDE Base

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.8] konqueror/src/konqmainwindow.cpp:

Avoid delayed popup of the bookmark menu when it is inserted into the toolbar.


FIXED-IN: 4.8.4

Jacopo De Simoi committed changes in [kde-workspace] plasma/generic/dataengines/soliddevice/devicesignalmapmanager.cpp:

Re-organize the map manager connections

Avoid connecting multiple times to the same map for the same device

Bernd Buschinski committed changes in [kdelibs/KDE/4.8] /:

kjs: Fix Errorprototype inheritance, it must inherit from ErrorInstance to get the correct classInfo

Without the patch

Error.prototype.toString=Object.prototype.toString;
print(Error.prototype.toString());

will tell us that Error is an Object, not an Error

before:
[object Object]

after:
[object Error]

REVIEW:104908

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.8] konq-plugins/khtmlsettingsplugin/settingsplugin.cpp:

Make sure mConfig is properly initialized even when the part does not support
the HtmlSettingsInterface extension.


FIXED-IN: 4.8.4

Michael Pyne committed changes in [kdelibs/KDE/4.8] kdecore/util/kshareddatacache.cpp:

kshareddatacache: Adopt KSDCCorrupted for exceptional errors.

This involves converting many present assertions (which crash no matter
what) and error-code return values (which have to be checked everywhere
the return value is used at) into using the KSDCCorrupted exception.

The nice thing about using the exception is that it can be trapped and
handled so that it does not cause an application crash.

There's still a bit more to do -- the end goal is that all accesses to
shm, no matter how minor, are vetted beforehand to ensure it won't cause
a page fault or bus violation.

,253665,243573,281217,297815,293954,293447,270915,255233

Casian Andrei committed changes in [kde-workspace] kwin/client.cpp:

Fix windows like kickoff from disappearing

When trying to launch kickoff (start menu) or the add widgets from
Plasma, they disappeared immediately after appearing, making them
completely unusable.

This regression was traced back to commit
bf0a241c2462072fbc52012784fa51b9b42a1baf.

In Client::setOnActivities, if newActivitiesList was empty, after
joining it and splitting it back, it would contain an empty string, i.e.
it would have a different size than before. This eventually caused the problems.

REVIEW: 105016

Aurélien Gâteau committed changes in [kde-runtime] plasma/declarativeimports/core/datamodel.cpp:

Do not reset model while changing the regexp

There is no need to do so, QSortFilterProxyModel correctly adjust rows

REVIEW: 105042

Martin Gräßlin committed changes in [kde-workspace] /:

Use smart pointers to protect access to TabBoxClient

Client holds a SharedPointer to the TabBoxClient and only
provides access to a WeakPointer which is passed to TabBox.
ClientModel is adjusted to hold a list of WeakPointers instead
of the direct pointers.

This fixes the following reproducable crash:
1. Configure both primary and secondary TabBox with different
layouts
2. Use primary TabBox
3. Close a window, best the one which used to be active
4. Use secondary TabBox
-> Crash

The reason is that the ClientModel still contains the pointer
to the deleted TabBoxClient in step 3 and while creating the
layout access to the TabBoxClient is needed to get the Client's
icon.

By using the weak pointer it can be ensured that we don't try
to dereference the deleted pointer and prevent the crash.




REVIEW: 105000

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/panels/places/placespanel.cpp:

Enable the "Empty Trash" action if items are deleted by non-KDE apps

To achieve this, the Places Panel context menu now checks the icon of
the "Trash" item (which is updated by a dir lister that watches the
state of the trash), rather then reading a config file which is only
used by KDE applications.


FIXED-IN: 4.9.0

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.8] dolphin/src/kitemviews/kfileitemmodel.cpp:

Show all items in the directory when the name filter is cleared

The problem was the following: While a QMutableSetIterator iterates the
items in the QSet m_filteredItems, all items that match the new filter
are removed from the set. However, to ensure that the iterator still
reaches all items in the set, one must not use QSet::remove(), but
rather the iterator's remove() method (see QMutableSetIterator docs).


FIXED-IN: 4.8.4

David Narváez committed changes in [kactivities/KDE/4.8] /:

Use Config to Provide Activity Icons

Use the information in the activities config file to provide icons
since Nepomuk's async ontology loading will not be able to provide
that info on session startup.


FIXED-IN: 4.8.4
REVIEW: 105008

Dawit Alemayehu committed changes in [kwebkitpart] src/kwebkitpart.cpp:

Properly handle openUrl requests when the URL entered is a local URL without
a path, e.g. bookmark:


FIXED-IN: trunk (future version)

Marco Martin committed changes in [nepomuk-core] services/fileindexer/indexer/nepomukindexwriter.cpp:

force epub files as Document

strigi only recognizes them as nfo:Archive (they are compressed html files)

Dominik Haumann committed changes in [kate] part/view/kateviewinternal.cpp:
Dawit Alemayehu committed changes in [kde-baseapps] konqueror/src/konqview.cpp:

Do not reset the URL entered into Konqueror's location bar URL
when the URL is handled by an external application.


FIXED-IN: 4.8.4
REVIEW: 104982
(cherry picked from commit 98f63a671d0b8b76d69c7d4b5fc06c5837408672)

KDE-PIM

Laurent Montel committed changes in [kdepim/KDE/4.8] mailcommon/filteraction.cpp:

Fix Bug 294131 - Kmail filter rewrites subject, but it keeps displaying

old one

FIXED-IN: 4.8.4

Dan Vratil committed changes in [libkgoogle] libkgoogle/services/calendar.cpp:

Do not add an organizer to appointments without attendees

Laurent Montel committed changes in [kdepim] mailcommon/filter/filteractionrewriteheader.cpp:

Fix Bug 294131 - Kmail filter rewrites subject, but it keeps displaying

old one

FIXED-IN: 4.8.4

Lamarque Souza committed changes in [plasma-mobile] config/emaildefaults:

Fix kmail-mobile configuration.

Dan Vratil committed changes in [libkgoogle/0.3] libkgoogle/services/calendar.cpp:

Do not add an organizer to appointments without attendees

Office

Martin Küttler committed changes in [cantor/gsoc2012] /:

Fixed zooming and resizing

- removed WorksheetStaticTextItem
- WorksheetEntries do not use QGraphicsLayout anymore, they now have
their own layout-code
- removed FormulaTextObject
- all eps rendering is now done by the new class EpsRenderer

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 10 more) Revision 88d5a2e...
Boudewijn Rempt committed changes in [calligra] krita/plugins/formats/pdf/kis_pdf_import.cpp:

Fix bug 300554

We used to get 1000x1000 pixel tiles from poppler. However asking
poppler to render those tiles is a) slower b) our calculation was
buggy.

I suspect that poppler renders the whole page anyway, then gives us
the part we asked for.

Burkhard Lück committed changes in [calligra] /:

Fix wrong function type description for 'Date'
REVIEW:104954

Thorsten Zachmann committed changes in [calligra/libs-kodocument_split_boud_and_] /kopageapp:

Fix update of document structure docker.

The problem was that the docker was created to late and therefore setCanvas was
not called. Now we create the docker earlier and setCanvas gets called and the
content in the docker is shown again.

Diffs: 1, 2, 3 Revision f81211b...

Multimedia

Matěj Laitl committed changes in [amarok] /transcoding:

TranscodingJob: cleanups, corrections

Including:
* much more useful debugging log spam
* set KJob error on ffmpeg error
* pass -n to ffmpeg so that is is not interactive when target file
already exists; in past it hanged in these situations

Martin Tobias Holmedahl Sandsmark committed changes in [phonon-vlc] /:

fix local file loading, remember to prepend the scheme and path, and also update for vlc 2.0, where we need an env variable for the plugin path

Matěj Laitl committed changes in [amarok] /:

TranscodingJob: don't pass -n to ffmpeg, check file existence manually

BUGFIXES:
* Transcoding: fix compatibility with libav's ffmpeg


FIXED-IN: 2.6
DIGEST: Bugfix

Networking Tools

Eike Hein committed changes in [konversation] /:

Don't perform wildcard expansion on input line contents starting with a command alias.

Wildcards should only be (and now are) expanded in the alias replacement pattern instead.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 98f74ee...
Lamarque Souza committed changes in [networkmanagement] libs/service/secretstorage.cpp:

Fix detection of stale secret requests. The same connection may contain
secrets in different settings, delete the connection only if there is no
more secrets to read from it.


FIXED-IN: 0.9.0.3

Other

Harald Sitter committed changes in [xsettings-kde] xsettings-kde.c:

The IM support patch from [1], imported into Mageia in [2] adds a
conditional sleep() call when the infinite loop runs into an empty
event queue which is bound to happen quite a few times.

This introduces pointless code and pointless wake ups as the used
XNextEvent function blocks on an empty queue anyway [3], thus
rendering the manual sleep() call superfluous.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=727822
[2] http://svnweb.mageia.org/soft?view=revision&revision=2011
[3] http://tronche.com/gui/x/xlib/event-handling/manipulating-event-queue/XNextEvent.html

Features

Development Tools

Miha Čančula committed changes in [kdevplatform/class-templates] /:

Add a class generator subclass

Diffs: 1, 2, 3, 4 Revision d57e5bd...

Educational

Martin Küttler committed changes in [cantor/gsoc2012] /:

Tab Completion works, mostly

Tab completion can be used now, but the position of the completion box
is not perfect yet. I know why that is, but I do not yet know how to
fix it.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 8f972e8...
Barth Netterfield committed changes in /branches/work/kst/portto4/kst/src/libkstmath:

Fix the parser to recognise scientific notation of the form 3.0E3 in
addition to 3.0E+3

Graphics

Fabio D'Urso committed changes in [okular] /:

Ask "Save annotation changes?" if there are unsaved annotations that cannot be saved locally

This patch turns Okular into a ReadWritePart. Annotation editing is always
disabled if we're loaded as ReadOnlyPart, no matter the document type.

REVIEW: 105020

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision e3f1c38...
Marco Martin committed changes in [okular/mart/okularActive] active/app/package/contents/ui/FullScreenDelegate.qml:

mousewheel support for zoom

Islam Wazery committed changes in [digikam] /:

Added an option to turn on/off high quality thumbs loading

KDE Base

Peter Penz committed changes in [kde-baseapps] /src/kitemviews:

Colorize icons when an item is selected


FIXED-IN: 4.9.0

Erlend Hamberg committed changes in [kate] /vimode:

Add folding shortcuts

Add normal mode folding shortcuts "zo", "zc", "za", "zr" and "zm".

Shaheed Haque committed changes in [kate] /pate/src:

Add a plugin management UI for Pate

Convert Pate::Engine into a QStandardItemModel, and use that to store
information about the plug directories, and their content.

Add a configuration page to Pate::Plugin (this currently has a few
spurious buttons, which wil be removed later).

Diffs: 1, 2, 3, 4, 5 Revision 48fed0a...
Shaheed Haque committed changes in [kate] /pate/src:

Reload support for Python plugins

First, wrap the majority of all interactions with the Python library,
with comprehensive error reporting.

Second, simplify/rationalise all (re-)initialisation logic.

Third, add a "reload" button to the configuration page.

Diffs: 1, 2, 3, 4 Revision 4d749e9...
Michał Dutkiewicz committed changes in /trunk/playground/base/plasma/applets/miniplayer:

Update to 2.4:
- updated DBus interface to MPRIS2 specification;
- added Current Track Once playback mode;
- fixed Play Previous and Play Next actions;
- enable Apply button when configuration values are changed;
- added Play Previous and Play Next to set of available controls and to toolbars of playlist dialog and full screen view;
- some other fixes and lots of internal changes.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 33 more) Revision 1296543
Luís Gabriel Lima committed changes in [kdeplasma-addons/plasma/luisgabriellima/] /weatherstation:

First static version of weatherstation

The plasmoid UI is almost as the original one, but using static
data and fixed positions. Some XXX comments were added to assign
where is still needing some adjustments related to resizing and
positioning.

Signed-off-by: Luís Gabriel Lima

Diffs: 1, 2, 3, 4 Revision c8d5e51...
Frank Reininghaus committed changes in [kde-baseapps] /src:

Use an italic font for symbolic links


FIXED-IN: 4.9.0

Jekyll Wu committed changes in [konsole] src/ViewContainer.cpp:

Dragging tab onto its existing position should not make it detach

This is a follow up of commit b8b8ef74, which adds the support of
dragging tab out of current window and into its own window.

Marco Martin committed changes in [plasma-mobile-config] /:

new default setup: more empty look

Peter Penz committed changes in [kde-baseapps] /src:

Further preperations for drag & drop support in the places panel

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 6c35095...
Marco Martin committed changes in [plasma-mobile] applications/filebrowser/CMakeLists.txt:

install books desktop file

KDE-PIM

Laurent Montel committed changes in [kdepim] archivemailagent/archivemaildialog.cpp:

Allow to sort column

Office

Gopalakrishna Bhat committed changes in [calligra] /main:

Delayed Search: Give the user a chance to enter the whole word before begining search

When we try to search for a text that is most common in a large document the ui used to hang when the first letter was entered in the search box i.e. hung until the search for the first letter
in the whole document is over. With this commit we delay the begining of search for 1sec giving the user a chance to type the whole word he wants to search.

REVIEW: 104996

Gopalakrishna Bhat committed changes in [calligra] /:

Currently we have the ability to load and save image lists and not create new ones. With this patch we add the ability to add new image lists.

This review request partially fixes bug 298061.

REVIEW: 105033

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision e7256f5...
Lukáš Tvrdý committed changes in [calligra] /:

Make brush rotation absolute to canvas rotation

o pass the canvas rotation to rotation sensor
and remap the rotation accoring current status
of the canvas

o also rendering of the brush outline has to respect
canvas rotation

Multimedia

Matěj Laitl committed changes in [amarok] /:

Transcoding for UMS collection, yay!

+ a couple of very small fixes to UmsCollection.

FEATURES:
* Support for transcoding when copying tracks to USB Mass Storage devices;
per-device transcoding preference can be saved, too.

FIXED-IN: 2.6
DIGEST: Feature: Amarok is now capable of transcoding music when copying it
to USB Mass Storage devices.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision bcbc9bd...
Sven Krohlas committed changes in [amarok] /:

Amazon store: try to show a sensible default in the country selection

If the user has not set a location we now try to guess one by asking
KLocale for the country setting. This is then being displayed as default
choice in the country selection dialog.

This does NOT yet save this determination or even use it to query the
service, as sending data to an internet service without explicit
consent from the user is a bad, bad thing. It just sets the default
value in the dialog the user still has to confirm.

Sven Krohlas committed changes in [amarok] /:

Amazon store: improved icons

As always created by Fabi. Thanks agein. :-)

>From his description of changes:
"OK Finally I'm ready. the emblem is now the same as the 16x16 Icon and all
icons are new with KDE Oxygen colors and the card Icon so you can see that
its a store attaches 3 pictures from amarok so you can see its eyefriendlier
on dark colors. so far - I Hope you like it and if something is wrong I will
fix it"

Note: I had to remove the icon cache at
/var/tmp/kdecache-$USER/icon-cache.kcache
to make them show up. Maybe that trick is needed for you, too. ;-)



M +- -- src/images/emblem-amazon-scalable.svgz
M +- -- src/images/emblem-amazon.png
M +- -- src/images/icons/hi16-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi22-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi32-action-view-services-amazon-amarok.png
M +- -- src/images/icons/hi48-action-view-services-amazon-amarok.png
M +- -- src/images/icons/svg/action-view-services-amazon-amarok.svgz

Bart Cerneels committed changes in [amarok] /:

Switch between trash/del copy/move using Shift.

Make the context menu respond dynamically to modifier button press.

Diffs: 1, 2, 3 Revision 1751924...
Matěj Laitl committed changes in [amarok] src/core-impl/collections/ipodcollection/jobs/IpodCopyTracksJob.cpp:

IpodCollectionLocation: when looking for duplicate tracks, disregard genre

Genre is seldom used to differentiate between different tracks, ID3 v1
tags have a limited set of available genres so that may create false
negatives.

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

Add "Automatic (DHCP only)" as possible IPv6 activation method. The
default IPv6 activation method is "Automatic" now.
IPv6 supports "Automatic", "Automatic (addresses only)" and
"Automatic (DHCP only)". IPv4 supports "Automatic (DHCP)" and "Automatic
(DHCP) addresses only".


FIXED-IN: 0.9.0.3

Andrea Diamantini committed changes in [rekonq] /sync:

Final refactoring and clean up to support Opera bookmarks.

Eike Hein committed changes in [konversation] /:

Implement a new %i placeholder to grab the input line contents.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 177b90b...

Utilities

Jekyll Wu committed changes in [krusader] krusader/GUI/terminaldock.cpp:

Use KService to lookup the library name of konsolepart

See https://git.reviewboard.kde.org/r/105028/

Games

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

improve removal of popups

now they are all removed when the next player becomes active

Other

Jeff Mitchell committed changes in [attica] /:

Warning: Non-*ABI* compatible commit. You must rebuild KDE plugins after
updating or you might/will experience crashes. API compatible.

This commit:

1) Adds the ability for applications using attica as a library to pass
flags to the provider manager, notably to disable plugin loading so that
deterministic QtPlatformDependent behavior can be used.

2) Updates the PlatformDependent API to add a setNam call to allow
setting a custom QNetworkAccessManager.

3) Implements setting/getting QNAMs in the ProviderManager in a
thread-safe way. QNetworkAccessManager is not thread-safe and so using
the same QNAM across multiple threads can result in crashes if one of
them is deleted, most notably because it takes ownership of a
QNetworkProxyFactory object so simply passing in a proxyfactory is not
good enough.

Diffs: 1, 2, 3, 4, 5 Revision ad715b9...

Optimization

Educational

Aleix Pol Gonzalez committed changes in [pairs] src/pairsview.cpp:

Reduce new game layouting time, like aaron suggested.

Office

Boudewijn Rempt committed changes in [calligra] libs/pigment/KoColorSpaceAbstract.h:

Make converting pixels much faster

The check for id() is really expensive (see valgrind log attached
to bug 300285), so short-circuit that in the common case where it's
not necessary.

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/protocolhandler.cpp:

Minor speed-up

moving const chars to QL1S in file:// pages

Other

Graphics

Gilles Caulier committed changes in [libkipi/development/2.0.0] /:

libkipi 2.0.0 developmemnt is open for GoSC 2012. fix lib API/ABI id
remove deprecated methods

Diffs: 1, 2, 3, 4, 5 Revision 3a31fbb...

KDE Base

Lamarque Souza committed changes in [kactivities] /:

Make activity password dialogs for private Activities use capital title
names to comply with HIG.

Philip Muskovac committed changes in [nepomuk-core] /:

Add copies of the GPL-2 GPL-3 LGPL-2 LGPL-2.1 LGPL-3 and BSD License

As required by the licenses for proper licensing as well as the
Debian/Ubuntu world.

Diffs: 1, 2, 3, 4, 5, 6 Revision 03176be...
Martin Gräßlin committed changes in [kde-workspace] /tabbox/qml:

Window Switching layouts are not flickable over bounds

Flicking has to stop at the bounds in the window switcher
layouts. It's not natural on the desktop that they are
flickable in the first place.

Window Strip is unchanged as this layout is intended to be used
on touch and flickable user experiences.

REVIEW: 105001

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 59072d0...
Burkhard Lück committed changes in [kde-runtime] /plugins:

add desktop file for KDE Fundamentals to get a toplevel item in khelpcenters navigation tree
use system-help icon for now

Vishesh Handa committed changes in [kde-runtime] /:

Merge branch 'nepomuk/PortToNepomukCore'

Remove most of the Nepomuk services from kde-runtime, as they are now
providied by NepomukCore. Also port the remaining stuff (kiosalves, kcm,
and controller) to the new Nepomuk2 interface.

kde-runtime now depends on nepomuk-core.

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Use a copy from "resourcewatcher.cpp" Vishesh Handa told me it's a

good method before that kdepim will depend against nepomuk-core

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision a666277...

Office

C. Boemann committed changes in [calligra/libs-kodocument_split_boud_and_] /:

Port Stage to the new document/part/view structure

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision acab76c...

Multimedia

Till Theato committed changes in [kdenlive/refactoring] /:

First work on new project tree ("Bin").

A data -> model -> view separation is used to make it easy to add new
views in the future. The data which consists of clips and folders has a
common base class AbstractProjectItem to make data -> model interaction
and loading of documents straight forward. Inside the document file the
items are now stored in a more hierarchical way to represent this object
structure.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 17 more) Revision b5a933e...
Till Theato committed changes in [kdenlive/refactoring] /:

Initial work on project and timeline.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 27 more) Revision 74505ee...

Networking Tools

Eike Hein committed changes in [konversation] /:

Alphabetize and document missing %k placeholder.

Other

Dan Vratil committed changes in [libkgoogle] /:

Convert AuthDialog to AuthWidget which can be embedded to a 3rd party application

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision fd8aa70...