Issue 238

3rd June 2012 by KDE Commit-Digest Team

Contributors

Frederik Schwarzer
Marta Rybczynska
Myriam Schweingruber

This Week...

Android native look&feel plugin added to android-qt. New assistant for new classes from templates in KDevelop. Fancy bookmarking on rekonq. Experimental rgbaf32 colorspace in the lcms color engine, all missing chart marker types implemented in Calligra. Rewrite the Topic tab in the Channel Options dialog in Konversation. GSoC work in KStars and Calligra. SoK work in Marble.

Statistics

Commits 2125 by 173 developers
Open Bugs 22112
Open Wishes 16903
Bugs Opened 372 in the last 7 days
Bugs Closed 1133 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
180
 
/branches/stable
119
 
/trunk/KDE
54
 
/trunk/l10n-support
43
 
/doc/index.docbook
27
 
/src/qml
21
 
/trunk/www
20
 
/src/app
13
 
/branches/work
9
 
/src/oxygenstylewrapper.cpp
9
 
Files Developer Commits
204
 
Roman Paholík
68
 
120
 
Jesper Pedersen
40
 
120
 
Aleix Pol Gonzalez
40
 
114
 
Harald Sitter
39
 
96
 
Gilles Caulier
37
 
96
 
Aaron J. Seigo
35
 
99
 
Andreas Cord-Landwehr
33
 
96
 
David Faure
32
 
93
 
Yuri Chornoivan
31
 
87
 
Miha Čančula
30
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Swedish (sv)
99%
 
Polish (pl)
99%
 
Estonian (et)
96%
 
Spanish (es)
96%
 
Dutch (nl)
96%
 
German (de)
94%
 
French (fr)
91%
 
Italian (it)
89%
 
Danish (da)
87%
 

Bug Killers

Person Bugs Closed
Myriam Schweingruber
574
 
Jekyll Wu
158
 
Harald Sitter
34
 
Thijs Heus
31
 
Christoph Feck
23
 
dehtris yahoo de
17
 
Peter Penz
15
 
C. Boemann
11
 
Tom Albers
10
 
Martin Gräßlin
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    []

Educational

[] []    []

Graphics

[] []    

KDE Base

[] []    []

KDE-PIM

     

Office

  []    

Konqueror

     

Multimedia

[] [] []   

Networking Tools

[] []    

User Interface

     

Utilities

  []    []

Games

[] []    

Other

  []    

There are 60 selections this week

Bug Fixes

Development Tools

Raphael Kubo da Costa committed changes in [kdevelop/4.3] /:

Look for ext/hash_map and unordered_map instead of checking gcc's version.

Follow-up to commits 9f8e8f662974a1035ea64f0ab9404b8858a02a57 and
5c59bd61b1df1b963959f086c5202689c084e0f3. The decision of whether to
include <ext/hash_map> or <unordered_map> for gcc/clang was based on
whether gcc > 4.3 was installed or whether clang was being used. The
latter implicitly assumed a recent enough libstdc++ version (ie. >=
4.3) was being used, which might not be the case on systems such as
FreeBSD and possibly OS X.

Instead of checking for compiler versions, we now look for these
headers: CMake first detects whether <unordered_map> is present and,
in case it is not, it looks for <ext/hash_map>. The checks in
languages/cpp/parser/parser.h have been updated as well. This should
cover all the cases being previously detected, as well as fix the
checks for FreeBSD and other systems where the build was failing
before with clang.

Reviewed-by: Millian Wolff
REVIEW: 105067

Diffs: 1, 2, 3, 4 Revision e37294e...
Miquel Sabaté committed changes in [kdev-ruby/gsoc] /:

This commit fixes a few things regarding class subclassing:

- Fixed visitors of methods/classes/modules from modifying the original AST.
- Properly importing the context of the base class.
- Implemented tests (both duchain and uses) regarding subclassing.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 95c6675...

Educational

Aleix Pol Gonzalez committed changes in [pairs] /:

Fix text being cut in some text cards

When we read a element's text, trim the result,
otherwise it contains some whitespaces we're not interested in.
Use the actual size we're going to use instead of the QRectF we're given,
which should be correct but it could be a bit too big.

Graphics

Marius Orcsik committed changes in [kipi-plugins] /:

Fix for removing images from the upload queue

when removing them from the widget

Small code polishes

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 90dc1a6...
Fabio D'Urso committed changes in [okular] /:

Fixes against causes of annotation data loss + Improved GUI message logic

1) If the user had previously annotated the document with an old okular
version and the document contains existing annotations and no /Encrypt
(ie the case where annotation changes are no longer saved locally), make
Document::saveDocumentInfo write the original unmodified local
annotations back to XML, so that it seems that the original file was not
changed. If the user makes annotation changes, code from previous
patches already asks him to save them to a different document on close.

2) Ask "Save changes?" if the user has modified annotations in a .okular
archive.


3) Turned a "sorry" message in a "information" (with dontshowthisagain),
because now we also have the "Save changes?" prompt to inform the user.

4) Suppressed all annotation-related message boxes on document opening

Aurélien Gâteau committed changes in [gwenview] app/fullscreencontent.cpp:

Fix thumbnail resizing not working after 240px

Fabio D'Urso committed changes in [okular] ui/presentationwidget.cpp:

Do not crash if the user attempts to draw on the presentation summary frame

Fabio D'Urso committed changes in [okular] /:

Don't produce unusable file if user presses "Save As" on a .okular archive

Make "Save As" behave like "Export as Document Archive" if we are
saving a .okular file.

KDE Base

Jekyll Wu committed changes in [konsole] /:

Do not reset previous searching after switching tab

Thanks to Lindsay Roberts for the research and patch


FIXED-IN: 4.9.0
REVIEW: 105121

Peter Penz committed changes in [kde-baseapps] dolphin/src/panels/places/placespanel.cpp:

Always use single-click for the places panels


FIXED-IN: 4.9.0

Dawit Alemayehu committed changes in [kdelibs/KDE/4.8] kdewebkit/kwebwallet.cpp:

- Fixed the issue of login @ some websites not being filled in at all.
- Greatly improved the javascript code used to parse HTML forms.


FIXED-IN: 4.8.4

Jekyll Wu committed changes in [konsole] src/SessionController.cpp:

Get back F3 as the default shortcut for the "Find Next" action.

Another stupid mistake by me. Wonder why it goes unnoticed for
such a long time.

Thomas Lübking committed changes in [kde-workspace] /:

cache blocked tabgroup state updates and do not check group breaking issues not being part of the updated states


FIXED-IN: 4.9
REVIEW: 105114

Aaron J. Seigo committed changes in [kde-workspace/KDE/4.8] /generic/runners/calculator:

libqalculate uses a global (!) object for the calculator; refcount our use of it

still not entirely safe -> if ANYTHING else uses the CALCULATOR object, iow
uses libqalculate, problems will ensue.

libqalculate really ought to be improved in this regard.

Multimedia

Matěj Laitl committed changes in [amarok] /:

EngineController: thread safety for supportedMimeTypes()

This hopefully fixes mentioned bug.

BUGFIXES:
* Fix crash on startup due to EngineController.


FIXED-IN: 2.6
DIGEST: Bugfix

Bart Cerneels committed changes in [amarok] src/context/applets/lyrics/LyricsApplet.cpp:

Fix / zero in LyricsApplet.

Cought right in time for beta, so not adding a Changelog entry.

Matěj Laitl committed changes in [amarok] src/core-impl/collections/ipodcollection/support/IphoneMountPoint.cpp:

IpodCollection: compatibility with ifuse 1.1.2

--uuid option changed to --udid in ifuse 1.1.2. Fortunately, the short
form, -u, is unchanged, whew...

Sam Lade committed changes in [amarok] /:

Fix dynamic playlist album play bias with MetaProxy

If a partial album was loaded with MetaProxy (e.g., when the current
playlist is loaded after starting Amarok), the album play bias would
fail to continue the album due to Meta::Track and MetaProxy::Track being
unequal. Use a comparison function that ensures the comparison is
correct.

Diffs: 1, 2, 3 Revision e83b4d4...
Harald Sitter committed changes in [dragon] /app:

fix vidoe resume

phonon does not support seeking before playback is started, this was
recently removed as it was supporting wrong(tm) code. playback
functions of phonon are either async or semi-async, therefore any
state bound actions must only be taken when the appropriate state was
entered

Networking Tools

Dominik Cermak committed changes in [ktp-kded-module] telepathy-module.cpp:

Fix presence saving

Use the presence given as parameter.

REVIEW: 105131

Eike Hein committed changes in [konversation] src/viewer/topicedit.cpp:

Fix a bunch of appearance problems.

- Base the geometry calculations for the KMW on heightForWidth() rather
than its bogus minimumSizeHint().
- Disable animations for now to avoid tripping a bug in KMW's content
size calculation.
- Hide the undercarriage if the splitter collapses the KTE.

Games

Mathias Kraus committed changes in /trunk/KDE/kdegames/granatier/src/player.cpp:

if a speed bonus is taken, apply the speed increase immediately, not only after pressing a moving key

Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src/playerlist.py:

Editing players: do not show robot players

because editing their names will cause problems. Some parts in kajongg
rely on robot player names starting with ROBOT. (note: the user never
sees ROBOT but a translation)

Features

Development Tools

Aurélien Gâteau committed changes in [kdevplatform] /:

Make area switcher usable when kdevelop runs on an appmenu-enabled system

When running on an appmenu-enabled system, one cannot add widgets in the
menubar corner. In this case, move area switcher to main toolbar.

REVIEW: 105116

Diffs: 1, 2, 3, 4, 5, 6 Revision c2bb0fa...
BogDan Vatra committed changes in [android-qt/unstable] /:

Add Android native look&feel plugin

This QStyle plugin uses the data extracted by Ministro on every device,
we can't hardcode any attributes(colors, fonnts, images, etc.) because
evey OEM, device, android version uses a different theme.

Currently the plugin supports only the most immportant controls.

DIGEST:

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision da00b33...
Miha Čančula committed changes in [kdevplatform/class-templates] /filetemplates:

Create a whole new assistant for new classes from templates, and implement the ITemplateProvider interface

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision e5f0a8e...
David Faure committed changes in /trunk/KDE/kdesdk/scripts/kf5:

Script to port KStandardDirs::locate/locateLocal to QStandardPaths

Aaron J. Seigo committed changes in [plasmate] /:

make switching editors work again (and a lot more efficient)

* if the widget stack is asked to switch to the already current widget -> do nothing
* hang on to the KService to see if we're loading the same thing (and if so, don't bother)
* only recreate the gui when first loading a part (removes flicker, makes things instant)
* don't create TextEditor widgets over and over for each file (they were actually leaking)
* be careful when accessing the m_textEditor pointer

Educational

Dennis Nienhüser committed changes in [marble/sok-2012-plasma-active] /:

Open WLAN Map position provider.

Uses libwlocate to determine the current position based on neighboring
WLAN access points or (as a fallback) the IP address. Contrary to other
position provider plugins this is currently implemented as a one-shot
position determination since that is the major use case.

Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

new library : analitzaplot ... support drawing many kind of curves and surfaces

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision f2144b5...
Samikshan Bairagya committed changes in [kstars/gsoc2012-samxan] /:

Introducing feature "What's Interesting..." A QML based test interface has been designed.
SkyObjListModel is a subclass of QAbstractListModel. Objects of SkyObjListModel can
represent any sky-object(any type). Currently test models for Planets, Stars, Galaxies,
Constellations, Star Clusters and Nebulae are used in class Modelmanager. The QML UI is
maintained by the WIView class.

The models are loaded everytime "What's Interesting..." is opened. It takes a long
time to load all the models. This is because currently the models checks through all
sky-objects. A reduced list will definitely be required.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision b66fd2d...

Graphics

Aurélien Gâteau committed changes in [gwenview] lib/documentview/birdeyeview.cpp:

Animate showing/hiding the bird-eye view

This is the first step toward autohiding it

KDE Base

Shaheed Haque committed changes in [kate] /pate/src:

When Pate fails to load aplugin, show the error in the UI.

1. Add a utility wrapper to hel pprevent PyObject reference leaks.

2. Rewrite the traceback handling to print it using kError, and capture
the result.

3. Use the catured traceback to show the faailed load status in the UI.

4. Don't reload the configuration just becuase the UI is to be
rendered!

Diffs: 1, 2, 3, 4 Revision 0d8c8b6...
Michał Dutkiewicz committed changes in /trunk/playground/base/plasma/applets/fancytasks:

Update to 1.1.1:
- reuse launcher icons by tasks also when using manual sorting;
- let startups connect to launcher icons (when there is no sorting or it set to manual);
- do not lose connection with launcher when group is created (if grouping by program);
- enable Apply button when configuration values are changed;
- do not propose to drop icon in place which equals its current index;
- enable Add / Remove action buttons;
- many other fixes and changes.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 8 more) Revision 1297688
Peter Penz committed changes in [kde-baseapps] /src:

Implement dropping of items into the Places Panel

Some polishing regarding the icons and group-alignment must still
be done, but at least the basic functionality is back again.

Diffs: 1, 2, 3, 4 Revision dd29b4c...
Sebastian Trueg committed changes in [nepomuk-core] /:

Do not touch special characters in a regex when converting URLs.

This is mostly backslashes but can be anything else. The point is that
we need to keep QUrl out of it to avoid percent-encoding of these
characters.

Diffs: 1, 2, 3, 4 Revision a7c4e07...
Craig Drummond committed changes in [kdeplasma-addons] applets/icontasks/abstracttaskitem.cpp:

When acting upon middleClick on a tooltip, the middleClick action should only apply to the window clicked on.

Peter Penz committed changes in [kde-baseapps] /src:

Provide a default name when adding a search query to the places panel


FIXED-IN: 4.9.0

Office

Boudewijn Rempt committed changes in [calligra/pigment-lcms2_rgbaf32-rempt] /:

lcms color engine: add an experimental rgbaf32 colorspace

This uses the new floating point capabilities of lcms2 to create a
hdr rgba colorspace that automatically uses all the templated functions
of pigment.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 57f2b02...
Robby Stephenson committed changes in [tellico/2.3] /:

Add localized IMDB sites as data sources

Add IMDB data source for France, Spain, Germany, Italy, and Portugal

Diffs: 1, 2, 3, 4, 5 Revision 85e4df7...
Inge Wallin committed changes in [calligra] /chartshape:

FEATURE: Implement all missing chart marker types.

Diffs: 1, 2, 3, 4, 5 Revision d5c83b4...
Jan Hambrecht committed changes in [calligra] /flake/tools:

improve visual feedback when dragging path curve

when changing a path curve directly by dragging it,
there was no real feedback for the user to see if
starting to drag would change the curve or doing a
rubberbanbd selection. now the cursor is being updated
to reflect if the mouse is onb a path segment. additionally
a status text is shown in the status bar.
i also refactored the corresponding code a little to reuse
the result of the path segment under the mouse cursor.

Smit Patel committed changes in [calligra/words-gsoc-smit] /textshape:

add/edit filters UI for citation database

Diffs: 1, 2, 3, 4, 5, 6 Revision 0c4f897...

Multimedia

Harald Sitter committed changes in [phonon-vlc/bluray] src/mediaobject.cpp:

implement what is supposed to be bluray loading

of course I have no drive nor disc, so I would not know if it works...

Trever Fischer committed changes in [dragon/tdfischer/make-dragon-sexy] /app:

Rewrite the recentlyPlayedList to be a proper ItemView, and use a Zeitgeist model if available

Trever Fischer committed changes in [bangarang] src/app/common/bangarangapplication.cpp:

Enable zeitgeist integration via phonon.

REVIEWBOARD:105106

Networking Tools

Eike Hein committed changes in [konversation] /:

Rewrite the Topic tab in the Channel Options dialog and the backing code.

Changelog excerpt:

* The Topic tab in the Channel Options dialog has been redesigned and
rewritten from scratch, featuring a much improved UI and many bug fixes:
- In place of the previous UI with a multi-column topic history list and two
distinct text fields for browsing and editing there is now only the list
and an edit field. The list has been redesigned to show all of the data for
a topic, with visually distinct headers serving to delineate individual
entries and showing the author and timestamp, above the full text for each
topic.
- Entries in the history list now sport a context menu allowing to copy the
topic text and querying the topic author.
- A new search field above the history list allows filtering it by looking
for the search string in the text, author name and timestamp of all topics.
- When an encryption key is set for a channel an attempt is now made to
decrypt all of the topics in the history, not just the current topic.
- When editing the topic any text entered past the server's maximum
allowed topic length will now be drawn in the color scheme's negative
text color (i.e. usually red). Further, if Konversation has been built
against KDE Platform v4.7.0 or higher, a warning is shown at the bottom
of the text field explaining the limit and offering the option - via a
button - to delete the excess text.
- The text cursor is now automatically placed at the end of the edit field,
making the common use case of adding to the topic more convenient.
- The location of the splitter handle inbetween the history list and the edit
is now remembered across all Channel Options dialogs and application
restarts.
- Storing the topic history for each channel now takes up less memory, and
general efficiency in handling with topic data has been improved greatly.
- Fixed a bug causing redundant entries to accumulate in the topic history
across reconnects when the last entry in the history corresponds to the
topic given by the server at rejoin.
- Fixed a bug causing the "Undo" action in the edit field to occassionally
stop working, making it impossible to return the field to the unmodified
state in which its contents sync to the selected history list entry.
- Fixed a bug causing the topic not to return to its encrypted form when the
decryption key for a channel has been deleted.
- Fixed a bug causing the author of a topic to sometimes be shown as the full
user mask instead of consistenty showing only the nickname.
- Fixed a bug causing the "Unknown" placeholder that is used when the author
of a topic is unknown not to be translated.
- Fixed the incorrect tab key order in the Topic tab.
* The size of the Channel Options dialog is now synchronized between the dialogs
for different channels and remembered across application restarts.
* The widths of the columns in the Ban List tab in the Channel Options dialog
is now synchronized across all Channel Options dialogs.
* Fixed a bug causing the topic at the top of channel tabs not to return to its
encrypted form after the decryption key for a channel has been deleted.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 6ea8eb4...
Andrea Diamantini committed changes in [rekonq] /:

Fancy bookmarking on rekonq :)

- Fancy bookmarking's resource link dialog added to bookmark context menu
- UI improvements in bookmarks dialog
- WARNING: Nepomuk/soprano dependencies added

NB: Merged and squashed by adjam ;)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision c4e2c25...

Utilities

David Edmundson committed changes in [kwhiteboard] launcher/mainwindow.cpp:

Make sure launcher loads kblackboard if requested

Games

Mathias Kraus committed changes in /trunk/KDE/kdegames/granatier/players:

updated player graphics

Diffs: 1, 2, 3, 4, 5 Revision 1296792
Wolfgang Rohdewald committed changes in /trunk/KDE/kdegames/kajongg/src:

Improve scoring explanation

when I have to discard a tile, I have 14 tiles which was explained as
a long hand with score 0. Now Kajongg explains score for the hand
without the focussed tile. So when moving the cursor between tiles,
the scoring explanation and the current total shown on the wall
adjust immediately.
Also, suppress output for players with score 0

Diffs: 1, 2, 3, 4, 5 Revision 1297823

Other

Trever Fischer committed changes in [libqzeitgeist] /:

Introduce the LogBrowser, a widget for applications to quickly and easily view relevant application events

Diffs: 1, 2, 3, 4 Revision 7e6f5b9...

Optimization

Multimedia

Harald Sitter committed changes in [dragon] src/app/stateChange.cpp:

increase startup speed by not messing with powermanagement

Other

Development Tools

Aurélien Gâteau committed changes in [kdevplatform] sublime/ideallayout.h:

Make it easier to reach buttons on the edges

Remove the 2px margin between border buttons and the edges of the screen

REVIEW: 101506

Educational

Aleix Pol Gonzalez committed changes in [pairs] src/qml/TogglableButton.qml:

Make the UI a bit more uniform.

Make the toggable buttons the same size as the regular
ones.

KDE Base

Kurt Hindenburg committed changes in [konsole] src/tests/DBusTest.cpp:

For Qt4.8 the dbus Qt service name changed

David Faure committed changes in [kdelibs/frameworks] /:

Port from KStandardDirs to QStandardPaths

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 7f2363b...
Raphael Kubo da Costa committed changes in [kdelibs/KDE/4.8] kjs/wtf/HashSet.h:

Fix the build with clang 3.1 (and possibly ICC).

Use the `template' keyword to disambiguate the calls here. Similar to
what was done in WebKit's WTF revision 37062.

Reviewed-by: SadEagle on IRC

David Faure committed changes in [kdelibs/frameworks] /:

Port away from KStandardDirs.

This commit is dedicated to 60 co-workers at KDAB, currently visiting
a distillery in Scotland.

Diffs: 1, 2, 3, 4, 5, 6 Revision d1ce9b4...

Utilities

Dan Vratil committed changes in [libkgoogle] /:

Rename LibKGoogle to LibKGAPI

Due to possible trademark violation, the library has been renamed.

The library is now called LibKGAPI. The API is wrapped in KGAPI
namespace. Headers are now installed to %prefix%/include/libkgapi.

See http://lists.kde.org/?l=kde-core-devel&m=133820238403101&w=2
for discussion.

Diffs: 1, 2, 3, 4, 5 Revision 4e225a0...