Issue 243

8th July 2012 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Vladislav Blanton
Myriam Schweingruber
Danny Allen

This Week...

Kexi's data handling library KexiDB became common component of Calligra. Remote installer implemented in Plasmate. Work on the GUI for video slide shows in Kipi. Smarter manual save dialog in Skanlite. Digikam can be compiled with paralelized PGF codec. DocumentCursor class added to Kate. Activity ranking plugin in its own thread and a separate GlobalShortcuts plugin added to KActivities. Work on recursive move replay in KDE-PIM. In Phonon-VLC, new videomemorystream is implemented and vdo is based on it now. Performance improvements in KDE-PIM. Important refactoring work in libksane and kdelibs. Bug closing continues: 320 opened, 843 closed.

Statistics

Commits 1960 by 201 developers
Open Bugs 21445
Open Wishes 16898
Bugs Opened 320 in the last 7 days
Bugs Closed 843 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
198
 
/branches/stable
152
 
/branches/work
30
 
/trunk/l10n-support
22
 
/trunk/www
17
 
/engine/timetablemate
16
 
/trunk/KDE
10
 
/trunk/playground
9
 
/kate/plugins
9
 
/branches/KDE
8
 
Files Developer Commits
309
 
Laurent Montel
127
 
300
 
Roman Paholík
100
 
198
 
Friedrich Karl Tilman Pülz
70
 
93
 
Gilles Caulier
36
 
99
 
David Faure
34
 
96
 
Dominik Haumann
32
 
75
 
Sayak Banerjee
31
 
87
 
Khoem Sokhem
29
 
78
 
Sergio Luis Martins
26
 
66
 
BogDan Vatra
24
 

Internationalization (i18n) Status

Language Percentage Complete
Estonian (et)
97%
 
Dutch (nl)
96%
 
German (de)
94%
 
French (fr)
92%
 
Italian (it)
90%
 
Danish (da)
88%
 
Low Saxon (nds)
86%
 
Catalan (ca)
85%
 
Chinese Traditional (zh_TW)
85%
 
Norwegian Bookmal (nb)
83%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
469
 
Christoph Feck
120
 
Laurent Montel
42
 
Andrea Diamantini
29
 
Christoph Cullmann
16
 
Dominik Haumann
13
 
Myriam Schweingruber
12
 
Ben Cooksley
11
 
Allen Winter
10
 
Thomas Lübking
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    []

Educational

[]     

Graphics

[] [] []   []

KDE Base

[] [] []   []

KDE-PIM

[] [] []   []

Office

[] []    

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    []

User Interface

[]     

Utilities

[] []    []

Games

  []    

Other

[]     

There are 85 selections this week

Bug Fixes

Development Tools

Ralf Habacker committed changes in /trunk/KDE/kdesdk/umbrello/umbrello/codeimport:

Cancel file import in case of internal lexer errors and print a related error message. It is better to have a single file not imported instead of an application freeze. Remaining parse problems could be fixed now easier.

Alexander Dymo committed changes in [kdev-ruby/gsoc] parser/parser.y:

Ruby lexer: increase the buffer size for heredoc strings and expressions interpolated into strings.
That buffer is currently quite large (will hold approx 2k of unicode strings).

The real fix would be buffers that get increased in size dynamically (realloc)
similarly to how original ruby parser does.

Educational

Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

fix field spacedimension of cartesiansurface and complete the ctor of Graph2d

Andreas Cord-Landwehr committed changes in [rocs] /Interface:

Fix crash when project import is cancelled.

Import function now guarantees on exit the existence of a project,
graph document, and script document.


FIXED-IN: 1.7

Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

Fix many Graph2D issues (guards before using a model, verify a curve have points before plot, etc) Fix 2D backends and planecurve. Finally, created a new test: View2DTest (this is a demo not a unit test)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 3ef718f...

Graphics

Aurélien Gâteau committed changes in [gwenview/KDE/4.9] lib/thumbnailview/thumbnailview.cpp:

Fix weird behavior when dropping an image in the thumbnail view

Before this change, if the thumbnail view had an image selected, attempting
to drop an image in it, would result in a new drag being started using the
selected image.

There is apparently no need to turn mouse tracking on for the thumbnail
speed bar anymore, so just disable this code.

Marcel Wiesweg committed changes in [digikam] /:

When copying/moving from within digikam, include all grouped images into the operation.

KDE Base

Dominik Haumann committed changes in [kate] /render:

make font "Courier New" work

FIXED-IN: 4.9

Vishesh Handa committed changes in [kdelibs/KDE/4.9] nepomuk/core/nepomukmainmodel.cpp:

ResourceManager: Do not double initalize the NepomukMainModel

The NepomukMainModel is initalized once when it is created and then the
second time in ResourceManager::init.

This results in a second connection being made to nepomukstorage, and an
extra thread being spawned over there. The old thread is eventually
deleted, but the whole process is rather pointless.

REVIEW: 105281

Copied from nepomuk-core 847d642f876507bda220750468afbba3adbccbfa

Dominik Haumann committed changes in [kate/KDE/4.9] part/document/katedocument.cpp:

fix " matching, it simply will never work

FIXED-IN: 4.9

Stefan Majewsky committed changes in [kdelibs/frameworks] kdecore/io/kmountpoint.cpp:

fix KMountPoint::List::findByPath() for non-existing file argument

dfaure says this is a porting bug because of moving from KStandardDirs
functionality to QFileInfo::canonicalFilePath(). The latter returns
empty if the file does not exist.

But this usecase is important for KIO::CopyJob: It wants to check the
available space on the target mount point.

KDE-PIM

Laurent Montel committed changes in [kdepim] kmail/collectionmaintenancepage.cpp:

Fix Bug 303069 - KMail2 folders get indexed even when the Enable Full

Text Indexing option is unchecked

Remove indexed text from collection when we unchecked it.

I can't backport to 4.9 because kdelibs/nepomuk was not full.
Now that we depend against nepomuk-core we can do it.

FIXED-IN: 4.10

Laurent Montel committed changes in [kdepim/KDE/4.9] messagecomposer/composerviewbase.cpp:

Fix bug found by David. Ask to put online maildispatcher if we send

immediatly not when we store it as template/draft or send later

Laurent Montel committed changes in [kdepim/KDE/4.9] messageviewer/viewer_p.cpp:

Start to fix Bug 202043 - huge icons for attachments in kmail when

mimetype icon only exists as svg
Limit size of icon.

Volker Krause committed changes in [kdepimlibs] akonadi/recursivemover.cpp:

Reset the pending replay flag once we actually do the replay.

Laurent Montel committed changes in [kdepim/KDE/4.9] messageviewer/htmlquotecolorer.cpp:

Security fix found by David yesterday during debug

Sergio Luis Martins committed changes in [kdepim-runtime] resources/kcal/kcalresource.cpp:

Emit configuration accepted/rejected when creating kcal resources.

Otherwise the agent creation job will not die, and the next time
you'll cancel the configuration dialog, the job will delete
the created instance.

David Faure committed changes in [kdepim/KDE/4.9] /:

A large number of fixes in this proxy, for proper handling of extra columns.

Lost much hair in the process of debugging this, though.
The worst bit was that mapSelectionToSource, whose purpose is to remove
the extra columns, was ending up with duplicates in the QItemSelection list,
which then confused KSelectionProxyModel. Very tricky.

This fixes a number of asserts, which started with the port to KIdentityProxyModel.

Laurent Montel committed changes in [kdepimlibs/KDE/4.9] kabc/ldifconverter.cpp:

Fix Bug 280997 - ldif importer does not import home street

FIXED-IN: 4.9

Laurent Montel committed changes in [kdepim/KDE/4.9] plugins/messageviewer/bodypartformatter/text_calendar.cpp:

Fix Bug 302344 - kmail sends invitation confirmation using wrong smtp

transport
FIXED-IN: 4.8.5

Laurent Montel committed changes in [kdepim/KDE/4.9] console/kabcclient/src/main.cpp:

Fix Bug 274847 - kabc2mutt crash codec was not defined.

FIXED-IN: 4.9

Andras Mantia committed changes in [kdepim] /:

A biggish refactoring of the filter functionality:

1) Do not take the items from the cache only, as they might be incomplete (especially in online imap case, but not only).
This should fix the body loss bug on spam filtering.(Bug 287752 and similar ones + countless of reports on user list)
Might fix 293768.

2) Download only what is really needed for the filter and add safety checks that
the mail is not modified if the requested part is missing. So far the distinction
was only betwee the body and rest. This should speed up filtering.
Also related to 287752, but should fix also 292283, 288109.

3) Rename qDebug->kDebug + fix some includes

4) The code should also fix the duplicate mails appearing after filtering (some of the duplicates
with empty content), eg. 275233

All bug reporters: in case you still see the bug, reopen the corresponding one.
For the reports that were CC'd, but not closed, please try to reproduce and tell
the result.

So far the bug is fixed on master, but might be backported later to 4.9.

Laurent Montel committed changes in [kdepimlibs/KDE/4.9] /:

Fix Bug 293232 - Writing a SMS via Kadresbook do not work, assign empty

parameter.
Parameter was changed from kde3 and kde4

David Jarvie committed changes in [kdepim] kalarm/kamail.cpp:

Bug 301946: fix sender address errors sending emails

Fix failure to send emails for some users, with the error message:
"The server did not accept the sender address ..."

Thanks to Laurent Montel for identifying the problem and providing a
fix.

Laurent Montel committed changes in [kdepim/KDE/4.9] kontact/src/mainwindow.cpp:

Fix Bug 301466 - "Configure Kontact as Groupware Client" link broken

FIXED-IN: 4.9

Laurent Montel committed changes in [kdepim/KDE/4.9] /:

Fix crash when we dnd

Thanks Aurelien/Benjamin Port/David to help to debug it.

Laurent Montel committed changes in [kdepim/KDE/4.9] messageviewer/htmlquotecolorer.cpp:

Fix Bug 286307 - Kmail crash

(QNetworkAccessHttpBackend::replyDownloadMetaData,
QNetworkAccessHttpBackend::qt_static_metacall, QObject::event)

FIXED-IN: 4.8.5


We debugged it with David yesterday.
We hope that it will fix it.
Reopen it if it's still crash

David Faure committed changes in [akonadi] server/src/storage/itemretriever.cpp:

Fix logic in item retriever to avoid requesting stuff we already have.

It used to delete the empty temp request too early, and then recreate it
with a final part (e.g. ENVELOPE) plus RFC822, remove ENVELOPE (because available)
and end up performing a request for RFC822 even though it is available too.

This fixes "Unable to fetch item from backend" errors when offline,
i.e. the inability to read emails while being offline sometimes,
and should also speed things up.

Fixed with Volker's help.

Laurent Montel committed changes in [kdepim/KDE/4.9] kmail/kmcomposewin.cpp:

Reenabled composer when we have an error. Otherwise we can't send mail

and can't fix email address for example.
Bug found by David :)

Office

Sven Langkamp committed changes in [calligra] krita/plugins/extensions/dockers/artisticcolorselector/kis_color_selector.cpp:

don't load alpha value as color choosers don't use that anyway

Thorsten Zachmann committed changes in [calligra] /:

Improve painting of stretched pattern background

For page backgrounds it happens that the image gets shown quite badly when stretch
mode is used. See bug. When tesing the fix I found out that this effects quite a
lot presentations. Not all as bad as in the bug report. With the patch all the images
improve nicely.
Problem was that the images generated for the pattern background did not generate a
image as big as needed but some fixed one that resulted in not so good looking background
images.

The patch is quite big as 2 new parameters (KoViewConverter and KoShapePaintingContext)
are added to the KoShapeBackground::paint method. The KoShapePaintingContext is not yet
used but this is needed for animations in stage that change the background color and as
I was already at it I added it too.


REVIEW: 105458

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 23 more) Revision f1003bd...
Timothée Giet committed changes in [calligra] /data/templates/design:

Fix design template icons

New icons to fit 128pix with alpha borders,
rename icons,
move them to calligra icons for possible reuse not only in krita,
fix icon names in desktop files.

Diffs: 1, 2, 3, 4, 5, 6 Revision e4edb8d...
Thorsten Zachmann committed changes in [calligra] libs/kopageapp/KoPAView.cpp:

Don't recurse function before everything is done

This fixes but Bug 302043 - Cropped display when with fit-page switching to notes view

Dag Andersen committed changes in [calligra] /koreport:

Fix xml save/load report definition

Fix bug in margins (mixup in namespace)
Save all distances (postions, sizes) non-localized, in/with unit 'pt'

REVIEW: 105305

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 8a95b8c...

Multimedia

Robert Riemann committed changes in [kubeplayer] lib/provider/youtube/Youtube.rb:

fix for new youtube formats (version 1.2)

this bugfix release resolves minor issues:
- adjustments related to automated packaging
- minor GUI adjustments for usage on tablet devices
- fix for new youtube file format (itag 36)

Christian Esken committed changes in [kmix] core/mixdevice.cpp:
Matěj Laitl committed changes in [amarok] /:

AmarokPlaylistScript: play all media in {add,play}Media(), add playMediaList()

No need to convert to tracks (this way it excluded playlists),
PlaylistController is good enough to read all kinds of urls including
playlists.

Add playMediaList() method for symmetry with addMediaList() when at it.

We thought it worked for other than .m3u playlists, but it was by
chance becasce CollectionManager::trackForUrl() returned something
(probably the first track) for other playlists.


FIXED-IN: 2.6

Matěj Laitl committed changes in [amarok] /:

EditFilterDialog: add "Last Played" back

It was assumed that his is a recent regression, but looking at the
code, this bug was present at least in January 2011.


FIXED-IN: 2.6

Matěj Laitl committed changes in [amarok] /:

TagDialog: correct rounding for rating

I still wonder how observant our users are. :-)


FIXED-IN: 2.6

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Get sure UrlBar is deleted well (i.e. later) and in the right place
(i.e. the WebTab dtor).

I cannot no more reproduce the problems described in #296346, #300892
and #268328

What about you?

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-transparent] style/oxygenstyle.cpp:

Fixed rendering of detached toolbars and dock widgets.

Ruslan Kabatsayev committed changes in [oxygen-gtk] /:

Fix treeview lines look with new expander-size

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport/0.10] applet/publictransport_p.cpp:

Fix busy state not ending when departure data was received

- Checked for the state of journey data instead of departure data
- Was fixed after 0.10 in commit 967e2f4ea637b11d584a48cf1c3b3d6cf9b82a19

Dan Vratil committed changes in [libkgoogle/LibKGAPI/0.4] libkgapi/auth_p.cpp:

Automatically fill username in Auth dialog when reauthenticating

When using multiple Google accounts, the Auth dialogs does not state
for which account it wants to confirm the privileges.


FIXED-IN: 0.4.2

Andrey Matveyakin committed changes in [krusader] /:

FIXED: Queue manager closed when any of the queues finished

REVIEW: 105636

Friedrich Karl Tilman Pülz committed changes in [publictransport] /:

Fix number of minutes from/to route stops to/from the home stop

- This is the number displayed at route stops in the applet
- The solution only works if the route extends over less than three
days, which should always be the case

Raphael Kubo da Costa committed changes in [ark/KDE/4.8] /:

cliinterface: Do not leak the pattern cache across different instances.

Since the pattern cache was a method-static variable, it was shared
among all CliInterface instances created during Ark's lifetime, which
meant that the same pattern cache ended up being used if one opened a
zip archive and then a rar one.

Fix that by making the pattern cache an actual member variable, so
each CliInterface instance has its own.

Reported by: Torsten Rahn

Friedrich Karl Tilman Pülz committed changes in [publictransport/0.11] engine/serviceproviderscript.cpp:

Fix features lists of script providers

- The feature list was read from the cache
although it has not been written there

Other

David Faure committed changes in [soprano] client/socketstream.cpp:

Fix 100% CPU usage when killing virtuoso.

read() returned 0 bytes, select() returned "ready", GOTO 10.
Apparently 0 bytes means "end of file", so error immediately when it happens.

Features

Development Tools

Giorgos Tsiapaliwkas committed changes in [plasmate/terietor/remoteinstallerV2] /:

Implement the remote installer

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 9ef1461...
BogDan Vatra committed changes in [android-qt/unstable] src/android/jar/src/org/kde/necessitas/industrius/QtActivityDelegate.java:

Add support for QML debugging.

Big thanks to Tyler Mandry for this patch.

Graphics

A Janardhan committed changes in [kipi-plugins/development/3.0.0] /:

basic gui for video slide show

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 132ecd1...
Kåre Särs committed changes in [skanlite] /:

Make the manual save dialog smarter.

- Make the save dialog remember the last name prefix and suggest
a name based on that.
- Add version.h.cmake for better version handling
- Use normally formated email in copyright headers
- General C++ enum fixes
- Remove the all automatic save as you probably want to check where it goes the
first time anyways

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision a7c7921...
Gilles Caulier committed changes in [digikam] /:

New experimental CMake option to compile digiKam with paralelized PGF codec.
Report this settings in Help/Components Info dialog.
This option is disabled by default. Paralelized PGF encoding give sometime corrupted thumbnail data stored in DB when it run through QThread.
Note : running paralelized PGF thumb encoding in main thread with QtPGFTest program always give a valid PGF image.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision e4cd65f...

KDE Base

Dominik Haumann committed changes in [kate] /:

add DocumentCursor class

DocumentCursor extends Cursor by several functions to work with cursors
on a specific Document (e.g. wrapping cursor). However, it is not registered
like the MovingCursor, meaning that its position is not updated automatically.
DocumentCursor is much more efficient that MovingCursor, if you do not need
the automatic maintaining of the correct position in the document.

For KDE5, KTextEditor::DocumentCursor will be moved to KTextEditor :)

Diffs: 1, 2, 3, 4 Revision bc03d69...

KDE-PIM

Volker Krause committed changes in [kdepimlibs] /:

Make sure we also provide the full collection object for the parent.

Diffs: 1, 2, 3 Revision f8273de...
Volker Krause committed changes in [kdepimlibs] /:

Sort pending collections so that we process them top to bottom.

Ivan Čukić committed changes in [kactivities/activity-manager-v3] /:

Activity ranking plugin lives in its own thread

Diffs: 1, 2, 3, 4, 5, 6 Revision b9f6633...
Ivan Čukić committed changes in [kactivities/ivan/plugin-refactor] /:

GlobalShortcuts plugin online

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision be6e243...
Volker Krause committed changes in [kdepimlibs] /:

Add recursive move replay in ResourceBase.

This addresses the problem that cross-resource collection moves only added
the top-level collection to the backend and kept everything else in the
Akonadi cache only.

It's not complete yet, so far only one hierarchy level is handled properly.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 2370af0...
Laurent Montel committed changes in [kdepim] /:

Now we can use nepomuk-core class

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 2a1d19e...
Ivan Čukić committed changes in [kactivities/activity-manager-v3] /:

Virtual desktop switching moved into a plugin

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 404ae33...
Sergio Luis Martins committed changes in [kdepim-runtime] resources/kabc/kresourceassistant.cpp:

Filter out kresources for which we have an akonadi counter-part.

Ldap is the only remaining one now.

Office

Jarosław Staniek committed changes in [calligra] /:

Move core parts of KexiDB lib to libcalligradb

Move core parts of KexiDB lib from kexi/kexidb to calligra/libs/db (libcalligradb) for reuse by Word's Biblio module

* GUI- or Kexi-related bits such as validators are still in Kexi
* Only the SQLite3 driver is moved to libcalligradb, others stay within Kexi
** thus, calligra libs depend on the driver, i.e. depend on SQLite3 (this was the case already for Words and Kexi)
** calligra libs depend on ICU as well for proper unicode handling (which is dependency of Qt 5 anyway)
* Predicate library, as a Qt-only component, will replace functionality of the calligradb lib
* sqlitedump tool used for database for interactive database compacting stays in Kexi; if needed could be moved to libs/ too
* a few functions from libkexiutils moved to libcalligradb, so libkexiutils is not dependency
* for simplicity/API stability, namespace stays as KexiDB
* README.PACKAGERS file updated

REVIEW:105464
DIGEST:Kexi's data handling library KexiDB become common component of Calligra.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 301 more) Revision 414b046...
Timothée Giet committed changes in [calligra] /data/templates:

Add design templates from deevad

Some common useful basic templates.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 08e1c0a...

Multimedia

Harald Sitter committed changes in [phonon-vlc] /:

implement new videomemorystream and base vdo on that

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 967085f...

Networking Tools

Andrea Diamantini committed changes in [rekonq] src/mainview.cpp:

Delete tab later to get sure everything has been finished.

Lasath Fernando committed changes in [ktp-text-ui] /searchexpansion:

Implement Searchexpansion filter

This simply takes the whole message and passes it to KUriFilter
to 'filter'. If it was succesful (meaning message was a web
shortcut), it replaces it with the filtered uri.

Note: The stuck in Url doesn't go through UrlFilter again, so
it won't be clickable. Should it matter, since this is outgoing
anyway?

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport] engine/timetablemate/src/timetablemate.cpp:

Store last active project and make it active again on restart

Daniel Nicoletti committed changes in [apper] libapper/PkTransaction.cpp:

Add support to display the download size remaining when downloading

Friedrich Karl Tilman Pülz committed changes in [publictransport/0.11] /:

Also show synchronously downloaded URLs for script tests

- Also show number of found journeys
- Add signals to Scripting::Network, emitted when synchronous
requests get started/finished

Diffs: 1, 2, 3, 4 Revision 1c5d3f7...

Games

Christian Krippendorf committed changes in /branches/work/krippendorf/kmahjongg:

Add first demo animation code.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1303802

Optimization

Graphics

Fabio D'Urso committed changes in [okular] /:

Clean pixmap cache in order of descreasing distance from current viewport

Previously it was cleaned in FIFO order

I also moved the pixmap selection logic in a separate function, that
will be needed in the next patches.

Note: This behaviour is yet not optimal for the thumbnails panel,
because it is allowed to be at a page different than the current
viewport

KDE Base

Sergio Luis Martins committed changes in [kdelibs/KDE/4.8] kdecore/date/ktimezone.cpp:

Don't detach our transitions list.

20% performance improvement in korganizer.

KDE-PIM

Sergio Luis Martins committed changes in [kdepim] calendarsupport/utils.cpp:

Reduce Item::hasPayload() calls.

Item::payload() already calls hasPayload() internally, and emits
an exception if the item does not have a payload.

So, use a try-catch block instead, to save 1 hasPayload() call,
which results in a 7% performance improvement.

I also added a incidence->type() comparison first, to avoid
throwing exceptions, because _cxa_rethrow appeared on callgrind,
so this is the fastest we can get.

Sergio Luis Martins committed changes in [kdepim] /:

17% performance improvement with big calendars.

Use the julian day ( int ) to hash the QDate.

date().toString() is expensive.

Sergio Luis Martins committed changes in [kdepim] calendarsupport/calendar.cpp:

Comment debug statement, no longer needed.

It's also a huge performance impact when kDebug is enabled.

Other

Development Tools

Aleix Pol Gonzalez committed changes in [kdevplatform] shell/projectsourcepage.cpp:

Improve usability of the "fetch project" feature

When we go through "Fetch project", automatically select the first
source instead of none.

Graphics

Kåre Särs committed changes in [libksane/nextgen] /:

Major refactoring with unusable middle steps -> no commit earlier...
This compiles but only the KSaneDevice works somehow not KSaneWidget.

Changes:
- Remove the namespace KSaneIface and make sure all classes start with KSane as
they mostly have done already.

- Remove the creategui() function KSaneOption -> gui-less
- Rename Class files to the same name to simplify #include "..."
- Rename header protections to be the Class name + "_h" for easier class renames
- Rework authentication and sane access (only one sane_init() / process)
- Replace float with qreal
- And more...

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 21 more) Revision 530b45d...

KDE Base

David Faure committed changes in [kdelibs/frameworks] /:

Port kwidgets away from kdecore as much as possible.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 69a3878...
Martin Gräßlin committed changes in [kde-workspace/KDE/4.9] /clients/aurorae/src/qml:

Do not use States and Transitions in QML of Aurorae

According to Nuno it's much better to define the animations in
a Behavior element as that is together with the element which
gets animated.

Also he recommends to not use states but just property binding
for the properties which are animated in the Behavior.

And I must admit that this produces cleaner code, though the
conditions are now scattered all over the source code and not
nicely put together in one state section. Let's just hope I got
the logic right.

Well seems like it is useful to go to a QML training, at least
it made me aware of my State definitions are not good and then
talking to Nuno and giving a try to his recommendations.

REVIEW: 105426

Diffs: 1, 2, 3, 4 Revision 4e6ab04...
Michael Palimaka committed changes in [kde-runtime] /:

Move KdepimLibs check to /drkonqi, since that's where it's required.

This assists downstream packaging.

REVIEW: 105402

KDE-PIM

Ivan Čukić committed changes in [kactivities/activity-manager-v3] /:

Everything now organized like KDE Frameworks 5 should be

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 8ab6b53...

Networking Tools

Bernd Buschinski committed changes in [konversation] src/notificationhandler.cpp:

Make krazy signal/slot normalisation happy.
NOTE: this is really special, the signal parameter is defined as "unsigned int",
so using it as "unsigned int" sounds logical, but makes krazy sad.
If we look at how connect works, it basically only looks at the first parameter,
so just using unsigned will work and does, tested.
Also note, as its compared as string using quint32 wont work.

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport/0.12] engine/timetablemate/src/project.cpp:

Improve stop suggestion test

- Use maximally 4 characters of the first sample stop name
to request stop suggestions