Issue 246

29th July 2012 by KDE Commit-Digest Team

Contributors

Jos Poortvliet
Marta Rybczynska
Aleix Pol

This Week...

  • Improvements to KStars' QML UI.
  • KDE Frameworks ported to the new Qt5 event filter API.
  • Vishesh's work on greatly improving Nepomuk stability and design marches onward!
  • A handful of Amarok bugs related to Phonon about-to-finish behaviors closed.
  • Multi monitor support in lightdm Userbar theme.
  • The new "drawer" QML component added to plasma-mobile.
  • Kamera kioslave is able to use libgphoto2 2.5

Statistics

Commits 2358 by 177 developers
Open Bugs 21420
Open Wishes 16886
Bugs Opened 284 in the last 7 days
Bugs Closed 274 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
226
 
/branches/stable
78
 
/trunk/l10n-support
68
 
/trunk/KDE
30
 
/trunk/www
27
 
/themes/wordpress
22
 
/src/lib
22
 
/krita/sketch
21
 
/branches/KDE
15
 
/branches/work
14
 
Files Developer Commits
222
 
Laurent Montel
81
 
189
 
Ingo Malchow
69
 
168
 
Jean-Baptiste Mardelle
57
 
150
 
Allen Winter
50
 
117
 
Vishesh Handa
41
 
117
 
Sayak Banerjee
39
 
87
 
David Edmundson
36
 
105
 
Arjen Hiemstra
35
 
87
 
Burkhard Lück
30
 
87
 
Chusslove Illich
29
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Polish (pl)
99%
 
Swedish (sv)
99%
 
Estonian (et)
98%
 
Spanish (es)
97%
 
Dutch (nl)
96%
 
French (fr)
96%
 
German (de)
95%
 
Italian (it)
91%
 
Danish (da)
88%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
38
 
Laurent Montel
27
 
Myriam Schweingruber
16
 
Andrea Diamantini
12
 
Albert Astals Cid
12
 
Vishesh Handa
11
 
Thomas Lübking
9
 
Christoph Feck
7
 
Gilles Caulier
7
 
Allen Winter
7
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

[] []    

Development Tools

[] []    

Educational

[] []    []

Graphics

[] []    []

KDE Base

[] [] []   []

KDE-PIM

[] [] []   []

Office

[] [] []   []

Konqueror

     

Multimedia

[]     []

Networking Tools

[] []    

User Interface

     []

Utilities

[] []    

Games

  []    

Other

     []

There are 123 selections this week

Bug Fixes

Accessibility

Yash Shah committed changes in [simon/facedetection] /simonvision:

Fixing simoncv and removing global varaibles in the face analyzer

Diffs: 1, 2, 3, 4 Revision 7bc2c95...

Development Tools

Eike Hein committed changes in [kdevplatform] language/codecompletion/codecompletionitemgrouper.h:

Fix downstream builds (thanks apaku).

Ivan Shapovalov committed changes in [kdevplatform] /cvs:

Separate "directory valid" and "file is known" conditions in CVS plugin.

This fixes behavior of "Add"/"Revert" actions, allowing to add new files
to the CVS index.

REVIEW: 105795

Diffs: 1, 2, 3 Revision 0eed181...
Alexander Richardson committed changes in /trunk/KDE/kdesdk/okteta/kasten/controllers/view/structures/datatypes/primitive:

Fix the EOF flag not being unset after a new read in structures tool

Aleix Pol Gonzalez committed changes in [kdevelop] projectmanagers/cmake/parser/cmakeast.cpp:

Initialize all the members

Otherwise valgrind reports problems when printing the debug information.

Ivan Shapovalov committed changes in [kdevplatform] plugins/cvs/cvsdiffjob.cpp:

Set base directory of the CVS diff job properly.

This fixes behavior of "Show differences..." command with CVS:
the changed files are properly displayed in the toolview.

Educational

Sebastian Gottfried committed changes in [ktouch/next] src/qml/SelectionGrip.qml:

resource editor: fix a subtle bug in the key resizing code

There was a circular binding in the QML code handling changed
coordinated of the grips ultimately corrupting the undo stack.

Sebastian Gottfried committed changes in [ktouch/next] /editor:

resource editor: fix spontaneous key resizing bug

Sometimes when selecting a new key in the keyboard layout editor its
size would change for no apparent reason. This is fixed now.

Wagner de Melo Reck committed changes in [rocs/KDE/4.9] src/Interface/VisualEditor/GraphScene.cpp:

Fix crash in rooted tree

This fix is a workaround to avoid a crash in Rooted tree plugin.

This commit should not be applied to master, we need to find
a better fix.

Thibaut Gridel committed changes in [marble] /:

PositionTracking: store current track to file, and reload on next launch

User will not lose his data as it is saved on closing the application
and reopened at startup.
Applications which want to benefit this need to call:
marbleModel()->positionTracking()->readSettings() and writeSettings()

Samikshan Bairagya committed changes in [kstars/gsoc2012-samxan] kstars/tools/whatsinteresting/qml/wiview.qml:

Got the "Go Back" button working, allowing smooth migration between the category selection, skyobject list and skyobject details views.

Graphics

Fabio D'Urso committed changes in [okular] part.cpp:

Moved m_findBar->resetSearch() from closeUrl() to notifySetup()

As a side effect, this change fixes bug 303998, that caused a crash if
the part's widget was destroyed before the part itself, because
m_findBar had already been destroyed.


FIXED-IN: 4.9.0

KDE Base

Dominik Haumann committed changes in [kate/KDE/4.9] /:

last minute fix for KDE 4.9: hard code search&replace colors

workaround, until we have a better solution

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] /storage:

ResourceMerger: Fix equalGraphs check

This fixes the failing storeResources unit tests in the DMM.

I cannot seem to find who wrote the earlier code, but it was clearly
wrong. Git blame doesn't give me much information.

REVIEW: 105714

Vishesh Handa committed changes in [nepomuk-core/testLibrary-resourceRefacto] libnepomukcore/datamanagement/simpleresource.cpp:

SimpleResource: Avoid duplicates when adding another PropertyHash

We need to add each (key, value) pair separately, so as to avoid
duplicates. A QMultiHash can contain the same (key, value) pair
multiples times.

This fixes SimpleResourceSubsystemTest::testSimpleResourceGraphAdd

Kurt Hindenburg committed changes in [konsole] src/SessionListModel.cpp:

Expand %# %w in the "Copy Input To" dialog session list.

Duplicate the code in SessionController.cpp to expand %# %w in the
copy input dialog. This is not the ideal solution but it not trivial
to fix w/ all the tab/window titles issues in Konsole.


FIXED-IN: 4.10

Gregor Tätzner committed changes in [kde-workspace] libs/taskmanager/groupmanager.cpp:

Fix deletion of preferred application launchers

In default panel config the host of that magic preferred app url is used
as the key. So lets use that key to delete the launchers, too.


FIXED-IN: 4.9.1
REVIEW: 105374

Vishesh Handa committed changes in [nepomuk-core] /:

Merge branch 'KDE/4.9'

* Fix Resource tests
* Other miscelanous fixes

Full change log -

414fd4c Introduce fall-back indexing
75723eb ResourceWatcher: Convert uris to QUrls
64890e1 Move the SimpleResource tests to libnepomukcore
979f656 Report the Indexer error
be31679 ClassAndPropertyTree - Always make sure a url has a scheme
41c1e33 ResourceWatcher: Send the values as QVariants not QDBusVariants
64ccfe1 Fix ResourceTests: the nie:url will have a file protocol
5f5291f Fix ResourceTests - typeTopMost and resourceDeletion
825ea14 Fix DMMTest::removeDataByApplication10 - FileIndexer case
c42e7eb Loose ResourceManager::clearCache
a28d758 ResourceData::store - Give the correct type to createResource()
93d0c6b DescribeResources: Do not use inferencing when listing properties
b20140f Fix ResourceTests:newFolder
c0365a8 ResourceData: Connect the watcher for new resources
cea8e6f ResourceMerger: Fix equalGraphs check
14e67cf DMMTest: Fix testRemoveResources_invalid_args
4cb118c SimpleResource: Avoid duplicates when adding another PropertyHash
027e57d DMS: RemoveAllResources - Emit propertyRemoved for object resources
4325b20 DataManagementModel: Do not add type nfo:FileDataObject if it already exists
8a1ceb4 Ractor ResourceData and ResourceManager

Vishesh Handa committed changes in [nepomuk-core/testLibrary-resourceRefacto] services/storage/resourcewatchermanager.cpp:

ResourceWatcher: Send the values as QVariants not QDBusVariants

I have no idea why we chose to send them as QDBusVariants, but it causes
problems in extracting the data at the other end.

Also pass resources as strings, and not QUrls. DBus does not natively
support QUrls and passes them as -

struct { string nepomuk:/res/.. }

instead of just 'string nepomuk:/res/..'

David Faure committed changes in [kdelibs/frameworks] /:

Fix build with Qt4 (for real this time)

Diffs: 1, 2, 3 Revision e56efc9...
David Faure committed changes in [kdelibs/frameworks] /kwindowsystem/src:

Fix build with qt4, moc is too stupid to parse Qt version checks...

Diffs: 1, 2, 3 Revision 6a1212b...
David Faure committed changes in [kdelibs/frameworks] /:

Fix compilation with Qt5

Francesco Cecconi committed changes in [konsole] /:

Fix issue where new profiles are not saved correctly

Due to new code untranslatedName, the saving of the profile was not
correct. This patch fixes that.


REVIEW: 105648
FIXED-IN: 4.9.0

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] services/filewatch/test/kinotifytest.cpp:

Fix KInofyTests

* testRenameFolder
* testMoveFolder

It turns out that there is nothing wrong with the tests, just the wrong
signal name.

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] services/storage/test/datamanagementmodeltest.cpp:

Fix DMMTest::removeDataByApplication10 - FileIndexer case

When the nie:url is saved, if the scheme is not specified, it gets the
'file' scheme, which is the correct behavior.

This test issues a sparql query without the 'file:/' in the url.

REVIEW: 105716

Lamarque Souza committed changes in [kde-workspace/KDE/4.9] /themes/default:

Fix regression in QML shutdown menu. Ampersands should be removed from
menu entries' text by default.

Diffs: 1, 2, 3 Revision 8290c87...
Vishesh Handa committed changes in [kdelibs/KDE/4.9] nepomuk/core/nepomukmainmodel.cpp:

Fix crash due to other threads using the model at the time it gets deleted.

Patch by David Faure
Ported from nepomuk-core - 9bd45eea17deb4a93c774697550238251b048f07

Laurent Montel committed changes in [kdelibs/KDE/4.9] kdeui/widgets/ktextedit.cpp:

Fix mem leak. Sonnet dialog box was never deleted

Vishesh Handa committed changes in [kde-workspace] plasma/generic/runners/nepomuksearch/nepomuksearchrunner.cpp:

Make the Nepomuk runner forward all the nie:urls

Not just the ones that are local files. This fixes opening of emails,
and other akonadi resources directly from the runner.

REVIEW: 105738

FIXED-IN: 4.9.1

Cherry-picked from edd4ee05f50eb84d6ed3eb87696fb9350d2b6b37

David Narváez committed changes in [kactivities/KDE/4.8] service/ActivityManager.cpp:

Hook Activity Manager Icons Config to Nepomuk and Write Icons

These changes were missing from the set of changes that introduced
icons config in 4.8


FIXED-IN: 4.8.5

Kurt Hindenburg committed changes in [konsole/KDE/4.9] /:

Fix issue where new profiles are not saved correctly

Due to new code untranslatedName, the saving of the profile was not
correct. This patch fixes that.

Patch by Francesco Cecconi

Francesco, please commit to trunk when you have time. I'm committing
this to make sure it goes in 4.9

Lamarque Souza committed changes in [kde-workspace] /themes/default:

Fix regression in QML shutdown menu. Ampersands should be removed from
menu entries' text by default.

Diffs: 1, 2, 3 Revision 23a034c...
Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] libnepomukcore/datamanagement/simpleresource.cpp:

SimpleResource: Avoid duplicates when adding another PropertyHash

We need to add each (key, value) pair separately, so as to avoid
duplicates. A QMultiHash can contain the same (key, value) pair
multiples times.

This fixes SimpleResourceSubsystemTest::testSimpleResourceGraphAdd

REVIEW: 105718

Dawit Alemayehu committed changes in [kwebkitpart] /:

Fix on demand plugin loading on reloads

Dawit Alemayehu committed changes in [kwebkitpart] /:

Honor Konqueror's on demand plugin loading and per host plugin configuration.


FIXED-IN: 1.3.0

Thomas Lübking committed changes in [kde-workspace/KDE/4.9] kwin/geometry.cpp:

un-Q'tile partially max'd clients on startMoveResize


REVIEW: 105699

KDE-PIM

David Faure committed changes in [akonadi] server/src/handler/store.cpp:

Give more details in the LRCONFLICT error message.

Allen Winter committed changes in [kdepim] korganizer/printing/calprintpluginbase.cpp:

Fixes to make the printing inside dayboxes (esp month prints) look nicer
and fit better.
Includes a patch from Fred Feuerstein, Thanks!

REVIEW: 105609
,237292,251681,263442
FIXED-IN: 4.8.5
MERGE: 4.8,4.9

Volker Krause committed changes in [akonadi] /:

Fix wrong column types used in older instances for n:m helper tables.

Now that we use the same column types as in the corresponding parent
tables, automatically adding the missing foreign key constraints actually
works.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 54eeea3...
Andre Heinecke committed changes in [kdepim/KDE/4.9] calendarviews/eventviews/month/monthview.cpp:

Fix display of recurring multiday events

If an event did not recurrOn a day in the currently selected
date range but recurred before that and was "still happening"
it was not painted.
Now we check for all recurrences that "still happen" on the
first day of the selected monthview.


(cherry picked from commit 99f24760b2d30a8abbf63f0a7247415578f32deb)

Andre Heinecke committed changes in [kdepim] calendarviews/eventviews/month/monthview.cpp:

Fix display of recurring multiday events

If an event did not recurrOn a day in the currently selected
date range but recurred before that and was "still happening"
it was not painted.
Now we check for all recurrences that "still happen" on the
first day of the selected monthview.

Allen Winter committed changes in [kdepim/KDE/4.9] /printing:

Honor the start and end time range when printing filofax.
This is a partial fix for bug 251710


MERGE: 4.8, 4.9
(cherry picked from commit 2dac6e943fa6cc295e7aa6bb9d5ef49ef8158c01)

Laurent Montel committed changes in [kdepim/KDE/4.9] /:

Fix impotrt ldap in thunderbird. And start to support import ldap in

evolution

Diffs: 1, 2, 3, 4 Revision e390ccd...
Burkhard Lück committed changes in [kdepim] /kmail:

Store Password option was removed in 4.8

Sergio Luis Martins committed changes in [kdepimlibs/calendaring] /calendar:

Make MailScheduler fully async, with proper error handling.

Now MailScheduler will only report success/error when
MailClient finishes sending the e-mail.

Will fix cases where no invitation was sent and no error was shown
to the user.

Diffs: 1, 2, 3 Revision afbf8c8...
Volker Krause committed changes in [akonadi] server/src/storage/dbinitializer.cpp:

Compare referential actions as well when checking existing foreign keys.

Ugly, but does the job for now.

Laurent Montel committed changes in [kdepim/KDE/4.9] /:

Hide nepomuk checkbox (not implemented). Will implement in 4.10

Allen Winter committed changes in [kdepim] /printing:

Fix the "Extend time range to include all events" option
in day timetable print mode.

also fix a bug where the footer was misplaced in this print mode.


FIXED-IN: 4.8.5
MERGE: 4.8,4.9

Allen Winter committed changes in [kdepim/KDE/4.8] /printing:

Honor the start and end time range when printing filofax.
This is a partial fix for bug 251710


MERGE: 4.8, 4.9
(cherry picked from commit 2dac6e943fa6cc295e7aa6bb9d5ef49ef8158c01)

Laurent Montel committed changes in [kdepim/KDE/4.9] kmail/kmreadermainwin.cpp:

Fix Bug 302108 - do not include folder name in taskbar entry of a message

Change order of caption => "name - folder name"
FIXED-IN: 4.8.5

Laurent Montel committed changes in [kdepim/KDE/4.9] kmail/kmmainwidget.cpp:

Fix Bug 303841 - message list does not remember its size

FIXED-IN: 4.9

Laurent Montel committed changes in [kdepim/KDE/4.8] kmail/kmreadermainwin.cpp:

Fix Bug 302108 - do not include folder name in taskbar entry of a message

Change order of caption => "name - folder name"
FIXED-IN: 4.8.5

(cherry picked from commit 201032304d721bbb8558104dd0c01d5c4cbd8476)

Office

Martin Küttler committed changes in [cantor/gsoc2012] /:

Fixed some bugs in the ui

- Removed the option for inline completion, because the new interface
only has popup completion.
- Changed the cursor to an IBeamCursor for editable TextItems
- Pressing Shift+Del repeatedly does not remove the last entry anymore,
it should not be possible to get a worksheet without any entry.
- Entries that are wider than the window now make the horizontal
scrollbar appear, and the scroll width is adjusted appropriately
when new items are created or existing items are destroyed.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 2ca22a0...
Stephane Mankowski committed changes in [skrooge/Feature] /:

: Crash when removing transaction number of transactions with duplicate account numbers

Friedrich W. H. Kossebau committed changes in [calligra/calligra/2.5] libs/kopageapp/KoPADocumentStructureDocker.cpp:

remove icons from "Add Slide/Page or Layer" menu (missing layer-new icon)

REVIEW: 105687

thanks thorsten for review

Thorsten Zachmann committed changes in [calligra] /main:

Write recent file list when it is cleared

When the recent file list is cleared it is not saved to the config file and therefore
the files reappear on the next opening of the document.

Martin Küttler committed changes in [cantor/gsoc2012] /:

Fixed two bugs in the interface

- Fixed a bug where an entry would evaluate multiple times, if the
previous entry received multiple statusChanged(Done) signals.
- Fixed a bug where a child item was not deleted by fadeOutItem() when
there already was an animation.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision a21d662...
Friedrich W. H. Kossebau committed changes in [calligra/calligra/2.5] krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp:

fix missing icons "edit-duplicate" & "edit-merge" with "edit-copy" & no icon (Krita context menu on layers)

REVIEW: 105692

thanks boudewijn for review

Boudewijn Rempt committed changes in [calligra/calligra/2.5] /ui/input:

Multimedia

Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Avoid crash - check if dialog pointer is still valid

Diffs: 1, 2, 3, 4 Revision 10c313e...
Matěj Laitl committed changes in [amarok] src/EngineController.cpp:

EngineController: if supportedMimeTypes contains x-m4a, add mp4 too

So that we announce correct mimetypes in MPRIS2. Patch from Andrea on
CCed bug.

Matěj Laitl committed changes in [amarok] /:

EngineController: don't do serious work in slotAboutToFinish()

...because slotAboutToFinish() may be called twice (or not at all) per
track by some Phonon backends (hi, vlc) - increase play count rather in
slotNewTrackPlaying() or in slotFinished(). This also needs to change
how m_currentTrack is handled, because slotNewTrackPlaying() needs to
have the old one in m_currentTrack.

Also, PlaylistActions::requestNextTrack() is changed to be a read-only
method that shouldn't change playlist state especially when there is no
next track. PlaylistActions::reflectPlaybackFinished() is introduced to
do the thing and is called from EngineController::slotFinished(), which
is a much better place for it than slotAboutToFinish().

Reporters of CCed bugs, please re-test your bug with this commit
applied, it is possible it has been resolved by this patch.







FIXED-IN: 2.6

Myriam Schweingruber committed changes in [amarok] src/widgets/BookmarkPopup.cpp:

Correct Icon call

There is no KIcon called "bookmark", it should read "bookmarks"

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Fix search engine(s) for KDE 4.9

This is basically Johannes patch with checks added for kde version and
with code duplicated for kwebapp.

PS: I tried using KUriFilterData API to do it, without positive results.
Postponing a code review here for KDE 5, hoping variables won't change
another time name...



REVIEW: 303872

Utilities

Jan Lepper committed changes in [krusader] /:

"Combine Files" overwrites existing target file without confirmation
and general cleanup of Combiner

Features

Accessibility

Yash Shah committed changes in [simon/facedetection] /simonvision:

Adding lip analyzer

Diffs: 1, 2, 3 Revision 4fbc99e...
Yash Shah committed changes in [simon/facedetection] /simonvision:

Adding Simon computer vision library

Diffs: 1, 2, 3, 4 Revision 51a7151...

Development Tools

Alexander Richardson committed changes in /trunk/KDE/kdesdk/okteta/kasten/controllers:

Add a new templated class extending PrimitiveDataInformation

This reduces code duplication and will hopefully increase maintainability

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 1307658
Alexander Richardson committed changes in /trunk/KDE/kdesdk/okteta/kasten/controllers:

Simplified value reading code for structures tool

Also probably slightly optimized it since it uses the builtin bswap

Friedrich W. H. Kossebau committed changes in /trunk/KDE/kdesdk/okteta/kasten/gui/system:

Added: version check for the bytearray viewprofile files

If you already added some viewprofiles because you have been running previous
development versions, open all the files in .../share/apps/okteta/viewprofiles/,
add the lines
--- 8< ---
[OBAVP]
Version=1.0
--- 8< ---
and save. The viewprofiles should now automagically reappear also in running Okteta instances.

Educational

Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

Better code for drawPolar and Cartesian coords, this comes from GPLACS: improvements like limits on zoom (on mouse scroll event) and more configurable grid.

Sebastian Gottfried committed changes in [ktouch/next] /:

resource editor: make keyboard layout properties editable

Not the title, name and size of an keyboard layout can be viewed and
edited using the property panel.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 368fa4d...
Samikshan Bairagya committed changes in [kstars/gsoc2012-samxan] /tools/whatsinteresting:

Introducing another user interface for "What's Interesting" feature. Took some risk and decided to go for an unconventional design.

Diffs: 1, 2, 3 Revision 38ee0eb...
Cezar Mocan committed changes in [marble] /lib:

DGML Maps improvement. Added more possible
formats and customizable ground layers.

Diffs: 1, 2, 3, 4, 5 Revision de72864...
Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

Accessibility feature, the text of grid's ticks/scale now follow the pallete of text group. Also, the behaviour of zommig is even better now, avoiding the user see many grid divisions and text when scroll the mouse #accessibility

Diffs: 1, 2, 3, 4 Revision 6a198b2...

Graphics

Abhinav Badola committed changes in [digikam/development/3.0.0] /:

Made all text entries in video metadata database

Changed all entries to text in datbase. Improved data reading functionality.

Marcel Wiesweg committed changes in [digikam] /:

Store color profile in Exif as a workaround for missing support in the PGF format.

Attempt to do the same for JP2K, but that does not work: When reading, the library successfully
returns an sRGB profile, while we cannot change this when creating a file.

Islam Wazery committed changes in [digikam/development/3.0.0] /:

support both libgphoto2 2.5.0 and 2.4.0

I also rewrote findConnectedUSBCamera to work with both 2.4 and 2.5,
also to be a bit more simple and less quadratic or O(n^3)

Diffs: 1, 2, 3 Revision b224133...
Abhinav Badola committed changes in [digikam/development/3.0.0] /:

Added support for Video metadata in Image Properties Sidebar

Though the entries are visible in the sidebar, the values are not being read properly. Needs revision.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision e9727d9...
Marcel Wiesweg committed changes in [digikam] /:

Record color profile and metadata in undo history in editor.

So far only the history was recorded. Add a container to store history and icc profile.
Undo/redo now works cleanly when a plugin changes the color profile.
DMetadata is currently not kept in undo because either an imageplugin (only two atm, noncritical)
or a concurrent user metadata editing operation can change the metadata; essentially,
all critical metadata editing would need to be applied before saving.
In ImageWindow, we re-write from the database to metadata before saving, so probably all will work.

KDE Base

Marco Martin committed changes in [plasma-mobile] /mobilecomponents:

new components: drawers

David Faure committed changes in [kdelibs/frameworks] /kwindowsystem/src:

Port to Qt5 new native event filter API

(which makes the whole class obsolete though)

Not tested, for lack of unittests in this framework...

David Edmundson committed changes in [lightdm] /userbar:

Multi monitor support in Userbar theme


Reviewed-by: David Edmundson

Thomas Lübking committed changes in [kde-workspace/KDE/4.9] kwin/tabgroup.cpp:
Gregor Tätzner committed changes in [kdeplasma-addons] applets/konsoleprofiles/package/contents/ui/konsoleprofiles.qml:

Add keyboard navigation to konsoleprofiles widget


FIXED-IN: 4.9.0
REVIEW: 105765

Martin Gräßlin committed changes in [kde-workspace] /clients/aurorae:

Port of Plastik decoration to QML

The Plastik decoration buttons are provided by a declarative
extension plugin as the canvas drawing API would be needed to
draw these buttons. This should be changed with Qt 5.

But it's also a nice example to show how a QML based decoration
can have an extension in C++.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision e817af5...
Francesco Cecconi committed changes in [konsole] /:

Make 'Find' action consistent with other KDE applications

When search bar is visible, pressing the shortcut/menu item for the second
time give focus to the search lineEdit. This patch remove toggleable property
from the action.


REVIEW: 105723
FIXED-IN: 4.10.0

Martin Gräßlin committed changes in [kde-workspace] /clients/aurorae/src:

Declarative extension plugin for window decorations

The generic QML components from Aurorae are split out into an
own declarative plugin. In addition two new helper classes are
added to this plugin:
* A ColorHelper to map a few function of KColorSheme and making
it possible to actually work with colors in QML. The need
emerged from trying to port Plastik to QML which makes strong
use of color shading.
* A DecorationOptions class which is a wrapper around KWin's
KDecorationOptions but in a more useable way for QML. The
various options are provided as properties and the value of
the properties changes automatically depending on whether the
decoration is active or inactive.

Aurorae itself is not yet adjusted to these changes, but it
should also be adjusted as some of the options are currently
exported in the factory and the factory is injected into the
Aurorae QML decoration.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision c469768...

KDE-PIM

Laurent Montel committed changes in [kdepimlibs] /:

Allow to define table alignment

Diffs: 1, 2, 3 Revision e86586d...
Laurent Montel committed changes in [kdepim/KDE/4.9] importwizard/thunderbird/thunderbirdsettings.cpp:

import ldap settings

Volker Krause committed changes in [akonadi] /src/storage:

Add API to DbIntrospector to query for existing foreign keys.

So far only implemented for MySQL, and going to be used to add missing
foreign key constraints.

Diffs: 1, 2, 3, 4 Revision 249c2de...
Laurent Montel committed changes in [kdepimlibs] kpimidentities/signatureconfigurator.cpp:

Enable table support

Laurent Montel committed changes in [kdepimlibs] kpimtextedit/tableactionmenu.cpp:

Improve table support

Office

Yue Liu committed changes in [calligra/connector-control-point-yue] /flake:

initial code for connection control point handlers, still buggy

Diffs: 1, 2, 3 Revision 8e756bc...
Sven Langkamp committed changes in [calligra] krita/ui/widgets/kis_paintop_presets_popup.cpp:
Dag Andersen committed changes in [calligra] /:

Add a task module docker to make it easier to add tasks in task editor

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision efecbc1...
Dag Andersen committed changes in [calligra] /libs/ui/reports:

Improve operation, layout of section editor dockers

Networking Tools

Dan Vratil committed changes in [ktp-text-ui] /:

Global search in LogViewer

REVIEW: 105586

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision a283477...

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport] /:

Simplify color groups, only use the Target

- After some more commits additional data can be added to existing
data sources, therefore it's better to use data that is always
there (required), so that the group of a departure never changes

Michel Ludwig committed changes in [kile] /:

Add Unicode representation for the provided symbols

Thanks to Olivier Delaune for providing the extended symbol files!
In case no Unicode representation is available, the regular LaTeX markup representation
is inserted.

Friedrich Karl Tilman Pülz committed changes in [publictransport] /:

Use timetable service in the applet, expand items to request more data

- Add expadedStateChanged() signal to departure items and connect it
to the applet to request additional data for the item
- Add data source name and index to DepartureInfo to identify the
item to update at the timetable service
- Fade in the route item if it was added later using the service
- Do not use "auto update" setting anymore in the applet, disable
polling (see last commit)
TODO: Remove setting completely and from the GUI

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision cd0eeca...

Games

Shreya Pandit committed changes in [gluon/creator-contextlayout-shreya] /:

Adding a final state to the slideshow. Enable load/play of games again.

Diffs: 1, 2, 3, 4, 5 Revision 3a11c2d...
Jakob Gruber committed changes in [picmi] /logic:

Pass the new signals on from Picmi

Nice to see that connecting signals to signals is also possible.

Optimization

KDE Base

David Faure committed changes in [kdelibs/frameworks] kdecore/io/kurl.h:

KUrl: remove encode_string and friends, deprecated since KDE-4.0 (2005)

Vishesh Handa committed changes in [kde-runtime] nepomuk/kioslaves/search/searchfolder.cpp:

Improve Folder listing in nepomuksearch kioslave

Set the UDS_TARGET_URL for directories.

Patch by Simeon Bird (sbird)

REVIEW: 105158

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] /:

Do no depend on kdelibs Nepomuk

* Removed find_package(Nepomuk REQUIRED), and other unnecessary commands
* We do not need to include NEPOMUK_INCLUDE_DIR in the list of includes

REVIEW: 105766

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision c7974ab...

KDE-PIM

Volker Krause committed changes in [akonadi] server/src/storage/datastore.cpp:

Avoid a whole bunch of queries in cleanupCollection().

If we have working foreign key constraints, the database will automatically
clean up all child tables for us. The only thing we have to handle manually
is deleting external parts.

Office

Boudewijn Rempt committed changes in [calligra/krita-sketch-rempt] /plugins/assistants/RulerAssistant:

Remove load/saving of assistants if dbus isn't present

Because that kills the job class as well.

Other

Educational

Sebastian Gottfried committed changes in [ktouch/next] src/editor/resourceeditorwidget.cpp:

resource editor: give additional space to the editor widget

And not to the resource list when the window size increases.

Graphics

Burkhard Lück committed changes in [kipi-plugins-doc] acquireimages.docbook:

acquire documentation

KDE Base

David Faure committed changes in [kdelibs/frameworks] /kidletime/src:

Port the native event filtering to XCB, to fix compilation with Qt5.

Started to port the rest of the code to XCB too, but found a bug in
xcb_sync_systemcounter_name()...

Idle detection doesn't fully work, maybe due to another bug, or maybe
due to the X11/XCB mix in here.

Diffs: 1, 2, 3 Revision 65f1172...
David Faure committed changes in [kdelibs/frameworks] /:

Split the HTTPFilter tests out of karchive's kfiltertest

They belong with HTTPFilter itself, no point in duplicating that code
into karchive autotests just to test it...

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 2ba9625...
David Edmundson committed changes in [lightdm/v0.2] themes/userbar/main.qml:

Focus password input on wrong password in userbar theme

Vishesh Handa committed changes in [nepomuk-core/testLibrary-resourceRefacto] services/storage/datamanagementmodel.cpp:

DMS: RemoveAllResources - Emit propertyRemoved for object resources

If a tag is deleted, then all the resources which are connected, to the
tag should be informed that the nao:hasTag relation has been removed.

Thomas Lübking committed changes in [kde-workspace/KDE/4.9] /kcmkwin/kwindecoration:

KDE-PIM

Volker Krause committed changes in [akonadi/1.8] /:

Prepare Akonadi 1.8.0 release.

Diffs: 1, 2, 3 Revision 4178063...
Volker Krause committed changes in [akonadi] /tests/unittest:

Extend the unit test to also cover removal of wrong foreign keys.

Office

Boudewijn Rempt committed changes in [calligra/krita-sketch-rempt] krita/CMakeLists.txt:

Link krita.exe only to komain

This is neater, though it doesn't solve the linker issue with icl.exe,
for that everything needs to be compiled with /bigobj anyway.

Friedrich W. H. Kossebau committed changes in [calligra] stage/part/KPrViewModeSlidesSorter.cpp:

remove unneeded margin around slideshow toolbar at bottom of slide sort view

more vertical pixels for content :)

REVIEW: 105684

thanks thorsten for review

Boudewijn Rempt committed changes in [calligra] libs/main/KoDocument.cpp:

Don't double-check the mimetype for raw files

Raw files like CR2 and NEF are actually a weird kind of file, NEF for
instance identifies as TIFF, but isn't. So if people rename their NEF
file to PNG, they are screwed, we cannot check the actual file contents
to determine the mimetype.

Multimedia

Marcus Meissner committed changes in [kamera] /:

port to libgphoto2 2.5

Hi,

This ports kamera ioslave to be able to use either libgphoto2 2.4 or libgphoto2 2.5.

Diffs: 1, 2, 3, 4 Revision cdcf420...

User Interface

Andreas Pakulat committed changes in [kdev-custom-buildsystem] /:

Improve comments on the desktop files

Let the comments say what the kcm and the plugin are being used for
instead of just referring the plugin name. Thanks to Ivan Shapovalov for
stirring up the discussion about this and making me think about better
texts.

Other

Jarosław Staniek committed changes in [predicate] CHANGELOG:

update CHANGELOG

DIGEST: Predicate library received massive improvements in parsing and stability