Issue 250

26th August 2012 by KDE Commit-Digest Team

Contributors

Martin Cigorraga
Aleix Pol
Myriam Schweingruber

This Week...

Calligra adds a new application, Author. Kexi gets support for user data storage and remembers column widths of table views. Aurorae supports Plastik's configuration options. KGeography can scramble colors. PublicTransport improves the presentation of a journey. User can configure application shutdown time in KDE Workspace. Numerous refactorings in KDE Workspace in Bookmarks runner, including new support for Chrome/Chromium bookmarks, and both Chrome and Firefox favicons. Phonon-VLC offers a new state: paused before playing.

Statistics

Commits 2850 by 187 developers
Open Bugs 21290
Open Wishes 15910
Bugs Opened 332 in the last 7 days
Bugs Closed 388 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
208
 
/branches/stable
115
 
/trunk/l10n-support
73
 
/trunk/www
34
 
/krita/sketch
24
 
/plugins/project
22
 
/trunk/KDE
18
 
/branches/work
14
 
/mailcommon/filter
13
 
/plugins/render
12
 
Files Developer Commits
282
 
Nicolas Lécureuil
95
 
249
 
Aleix Pol Gonzalez
84
 
207
 
Laurent Montel
78
 
138
 
Dan Leinir Turthra Jensen
46
 
135
 
Ludovic Grossard
45
 
135
 
Gilles Caulier
45
 
114
 
René Küttner
40
 
120
 
Arjen Hiemstra
40
 
102
 
David Faure
36
 
102
 
Jörg Ehrichs
36
 

Internationalization (i18n) Status

Language Percentage Complete
Estonian (et)
98%
 
Dutch (nl)
96%
 
French (fr)
96%
 
German (de)
95%
 
Italian (it)
91%
 
Danish (da)
88%
 
Chinese Traditional (zh_TW)
84%
 
Catalan (ca)
84%
 
Hungarian (hu)
81%
 
Galician (gl)
81%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
50
 
Myriam Schweingruber
38
 
kollix aon at
27
 
Christoph Feck
20
 
Albert Astals Cid
16
 
Laurent Montel
15
 
Thomas Lübking
14
 
Martin Gräßlin
12
 
Vishesh Handa
11
 
gregor freenet de
10
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

  []    

Development Tools

[] []    []

Educational

[] []    

Graphics

[] [] []   

KDE Base

[] [] []   []

KDE-PIM

[] [] []   

Office

[] [] []   []

Konqueror

     

Multimedia

[]   []   []

Networking Tools

[] []    []

User Interface

     

Utilities

[] [] []   []

Games

   []   

Other

     

There are 111 selections this week

Bug Fixes

Development Tools

Friedrich W. H. Kossebau committed changes in /trunk/KDE/kdesdk/okteta/kasten/CMakeLists.txt:

Fixed: ensure dependencies between base Kasten libs and OktetaKasten libs (using targetnames, not output names)

As long as the base Kasten libs are part of the build tree of Okteta, the linking lists need to use the
the target names instead of the output names, otherwise the dependency is not known.

Ben Cooksley committed changes in [websites/build-kde-org/development] /:

If there are no test results, do not fail.
Adjustment to RSync procedure, to make it more reliable

Aleix Pol Gonzalez committed changes in [kdevplatform] project/projectmodel.cpp:

Invalid indexes shouldn't return the root item

The root item has its own index
This fixes a crash in the execute plugin, when having inexisting
dependencies.

Aleix Pol Gonzalez committed changes in [kdevelop] /cmake:

Change from KDirWatch to QFileSystemWatcher

I've been having some problems with KDirWatch lately and I couldn't find
a proper way of fixing it in kdelibs, so I decided to change to
QFileSystemWatcher.
I've been using it for some weeks and it works fine, maybe it should be
put in 4.4?

Aleix Pol Gonzalez committed changes in [kdevplatform] plugins/execute/executeplugin.cpp:

Notify when an executable dependency can't be found

Or you could get to the awkward situation that it's not being compiled and
your changes aren't being tested.

Educational

Jasem Mutlaq committed changes in [kstars] /fitsviewer:

Fixing HFR calculation. Adding a low pass and equalize filters for images

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 752aba3...
Percy Camilo Triveño Aucahuasi committed changes in [analitza/aucahuasi/analitzaplot] /:

Import more concepts related to plots-dictionaries from khipu and gplacs. Minor fixes in spacesdelegate. Create the data folder when we can save the *.plots files that contains plots definitions in analitza syntax

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 17 more) Revision de3726d...

Graphics

Tobias Koenig committed changes in [okular] /:

Switch from poster image to video player after video has started playing

If we switch immediately after the play() trigger, a black frame is visible
for a moment, which looks ugly.

Mailson Menezes committed changes in [okular/tiled-rendering] core/page.cpp:

Fix crash when changing between memory profiles

Jesper Pedersen committed changes in [kphotoalbum] /:

Changed when the thumbnail cycler is active
Now it is always active, unless the cursor is over an image that is selected and the control key is pressed down
This allows contrl+plus/minus to work to chaning the current video image, while maximizing the visibility of the thumbnail cyckling

Diffs: 1, 2, 3, 4 Revision 37ff44e...
Mailson Menezes committed changes in [okular/tiled-rendering] ui/pageview.cpp:

Fix bug of not showing tiles in low profile mode

Albert Astals Cid committed changes in [okular] /:

Make --unique also raise the window


FIXED-IN: 4.10.0

Jesper Pedersen committed changes in [kphotoalbum] /:

extract fractions of seconds when extracting thumbnails for videos
This addresses bug #305328. The problem was that several frames extracted was
the same, and therefore the algorithm for finding the current image was broken, as when I was at image 2,
it found image 1 as being the current, as image 1 and 2 both where the same

Fabio D'Urso committed changes in [okular] shell/shell.cpp:

Do not show the save changes prompt twice if the main window is closed

Call m_part->closeUrl with promptToSave=false in the Shell dtor, so that
the save changes prompt is not shown again (it's already shown because
of Shell::queryClose)

Jesper Pedersen committed changes in [kphotoalbum] ImageManager/ExtractOneVideoFrame.cpp:

format number correctly for mplayer.

Gilles Caulier committed changes in [digikam] imageplugins/enhance/localcontrasttool.cpp:

don't use downscaled image to render preview, it will differs than final rendering

KDE Base

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/kitemviews/kstandarditemlistwidget.cpp:

Do not crash when finishing inline renaming in unusual ways

The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.


(cherry picked from commit a9c2bdc3b53955693e716bbab58c318fe25bdc9b)

Christoph Feck committed changes in [kdelibs/KDE/4.9] kdeui/widgets/kpushbutton.cpp:

Fix KPushButton(QIcon)

Ack'd by tsdgeos

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.9] dolphin/src/kitemviews/kstandarditemlistwidget.cpp:

Do not crash when finishing inline renaming in unusual ways

The crash was caused by a null pointer dereference when, e.g.,
minimizing Dolphin. The root cause was that
KStandardItemListWidget::closeRoleEditor() was called twice: once when
the role editor loses focus, and once again when the window is resized.
After m_roleEditor was set to 0, the second call dereferenced this null
pointer. I think the best solution is to disconnect from the role
editor's signals when the editor is not needed any more by the
KStandardItemListWidget.


FIXED-IN: 4.9.1

Oswald Buddenhagen committed changes in [kde-workspace] kdm/backend/client.c:

don't crash when PAM prompts at the wrong time

Jacopo De Simoi committed changes in [kde-workspace/KDE/4.9] plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml:

Delay setting passive status

Set passive status after some delay
to allow users to be notified that it is safe to
remove the device before the applet becomes hidden


FIXED-IN:4.9.1

Thomas Lübking committed changes in [kde-workspace/KDE/4.9] /:

fix untabbing position

the geometry setting needs to happen out of recursion,
has to be smarter for unmaximizing and also no real
place in TabGroup - the client is no longer tabbed thus
it's not the groups task to manage it's geometry.


REVIEW: 106182
FIXED-IN: 4.9.1

David Faure committed changes in [kdelibs/KDE/4.9] /file:

Fix copying of files with extended ACLs.

The switch to #cmakedefine01 in KDE Frameworks has detected a missing
#include <config-acl.h> in file_unix.cpp ever since it was splitted
out. In case we still had a doubt about how much more superior the
cmakedefine01 (#if instead of #ifdef) solution is...


(not tested, but might help...)

Christoph Feck committed changes in [kdelibs/KDE/4.9] kdeui/fonts/kfontcombobox.cpp:

Use correct font for metrics calculation


FIXED-IN: 4.9.1

Thomas Lübking committed changes in [kde-workspace] /:

fix untabbing position

the geometry setting needs to happen out of recursion,
has to be smarter for unmaximizing and also no real
place in TabGroup - the client is no longer tabbed thus
it's not the groups task to manage it's geometry.


REVIEW: 106182
FIXED-IN: 4.9.1

Yuen Hoe Lim committed changes in [nepomuk-metadata-extractor] /:

- allow plugins to have config dialogs
- add a part to config to list plugins and show info or config dialog
- simple working plugin config dialog for tvdbmal plugin
- minor bugfixes

REVIEW 106169

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 9541c0f...
David Faure committed changes in [kdelibs/frameworks] /tests:

Fix abort with Qt5

Thomas Lübking committed changes in [kde-workspace] /:

correctly align tabbing shade mode, including hover

REVIEW: 106258

FIXED-IN: 4.9.2

Martin Gräßlin committed changes in [kde-workspace] kwin/opengltest/opengltest.cpp:

Whitelist AMD Catalyst for kwin direct rendering


FIXED-IN: 4.10
REVIEW: 106050

Christoph Feck committed changes in [kdelibs/KDE/4.9] dnssd/avahi-publicservice.cpp:
Jacopo De Simoi committed changes in [kde-workspace] plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml:

Show icon tooltips in systray

At last, re-add icon tooltips to the QML version of the
device notifier.
This fixes a long overdue regression introduced in 4.8
We should consider backporting to 4.9. Unfortunately we had to introduce
a new string so I have to think if it is really worth it.

Thomas Lübking committed changes in [kde-workspace] /:

fix flicker with fullscreen effects


FIXED-IN: 4.9.1
REVIEW: 106142

Emmanuel Pescosta committed changes in [kde-baseapps] dolphin/src/dolphinapplication.cpp:

Fix wrong behaviour, when Dolphin is started with --split argument.

Actual Results:
dolphin starts without split view

Expected Results:
dolphin starts with split view

New behaviour:
* no url given - use default url for all two views
* one url given - use given url for all two views
* two urls given - open the first url in the left view and the second url in the right view


REVIEW: 106171

(cherry picked from commit d430a1c3b3c7485149f5486e38f4188074d09c0d)

David Faure committed changes in [kde-runtime/KDE/4.9] /ikws/searchproviders:

Send DuckDuckGo t=kde rather than t=KDE, at their request.

Diffs: 1, 2, 3 Revision 17c42fb...
Christoph Cullmann committed changes in [kate] kate/plugins/project/kateprojectcompletion.cpp:

show right completion name

David Faure committed changes in [kdelibs/KDE/4.9] kdecore/io/kmountpoint.cpp:

NTFS doesn't support chmod, so ignore chmod errors when copying files.

FUSE doesn't make it easy to detect NTFS mounts, though...
In this code we have to hardcode "fuseblk" and hope that more recent versions
of FUSE indeed show "fuseblk.ntfs-3g" instead, as a bug report suggested.

But even worse: I want to replace this code with KFileSystemType which
uses statvfs(), which is much faster and less code, but on linux that method
returns the same number (FUSE_SUPER_MAGIC, 0x65735546) for all fuse filesystems :(

Also add SMB/CIFS mounts to the list of filsystems "made by microsoft and therefore
doesn't support chown, chmod, utime, nor proper symlinks".

FIXED-IN: 4.9.1

Christoph Feck committed changes in [kde-workspace/KDE/4.9] kcontrol/colors/colorscm.cpp:

Fix multiple issues in colors KCM

- do not offer "Current" (or "Default") name for saving
- update preview icon when a colors gets changed
- write "Current" as scheme name, when the temporary theme is used
- upon loading the "Current" scheme, mark it as "needs saving"
- update preview icon for "Current" scheme when it is applied

See review description for details.

REVIEW: 106066

FIXED-IN: 4.9.1

Martin Gräßlin committed changes in [kde-workspace/KDE/4.9] /tabbox:

Start building up of ClientModel with the first Client to include

So far the first Client to be shown in the list (that is the
currently active window) was inserted as the last client into
the list by prepending it to the list.

This meant that if another Client actually blocks the inclusion
of the currently selected Client (e.g. only one window per app)
the currently active Client never got included in this list.

This change ensures that the recently used model switching has
the starting Client as the first Client in the list and also
simplifies the code.

Stacking order switching mode is not adjusted as it seems rather
broken, like the comment already says.


FIXED-IN: 4.9.1
REVIEW: 106139

KDE-PIM

Dan Vratil committed changes in [libkgapi/LibKGAPI/0.4] libkgapi/services/contacts.cpp:

Store gd:fullName as formatted name

Store display format of the name directly in gd:fullName.
Google can apparently deal with it well and KABC can parse
the reply as well.


FIXED-IN: 0.4.2

Laurent Montel committed changes in [kdepim] mailcommon/searchpatternedit.cpp:

Fix Bug 183448 - not intuitive drop-down filter criteria - add default

text

FIXED-IN: 4.10

Volker Krause committed changes in [akonadi] server/src/handler/fetchhelper.cpp:

Only update the item access time if we actually retrieve payloads.

So far even a simple meta-data listing updated the atime, which includes
syncing resources. This should explain why barely any cache content was
purged (e.g. IMAP syncs list every item, and thus did update their access
time) and it also seems to massively reduce disk I/O during syncing.

Andras Mantia committed changes in [kdepim] mailfilteragent/mailfilteragent.cpp:

Now fix for real the mail loss on spam filtering. The previous fix's idea was good, just that unfortunately the default value is "setCacheOnly(true)" set in AgentBasePrivate, so we have to explicitely set the cacheonly to false, otherwise mail content is not fetched from the mail server when passing through a filter that *needs* a content.

FIXED-IN: 4.10

Laurent Montel committed changes in [kdepim/KDE/4.9] messagecomposer/kmeditor.cpp:

Fix Bug 255008 - external editor: string replace for the window id to be

used with xembed

use %w for windows id.

and fix command line parsing when we have "emacs --toto=%w"

FIXED-IN: 4.9.1

Laurent Montel committed changes in [kdepimlibs] /:

Fix Bug 97239 - better support for including own vCard into mails

(need kdepim)

FIXED-IN: 4.10

Laurent Montel committed changes in [kdepim/KDE/4.9] messagelist/core/view.cpp:

Fix Bug 264153 - KMail crashes whne using the Prev. Message button

FIXED-IN: 4.9.1

David Jarvie committed changes in [kdepim/KDE/4.9] /:

Bug 266082: Fix KAlarm button not highlighting alarm in main window

Clicking the KAlarm icon button in the alarm message window didn't
always highlight that alarm in the main window's alarm list.
Applies to KResources build only.

Diffs: 1, 2, 3, 4 Revision 6f924f5...
Dan Vratil committed changes in [libkgapi/LibKGAPI/0.4] libkgapi/services/contacts.cpp:

Fix contact birthday synchronization

Apparently, QDateTime::isValid() returns false when only
the date is valid, but time not.


FIXED-IN: 0.4.2

Bug 350374:
 
15572 days
Diffs: 1 Revision 2888b2a...
Allen Winter committed changes in [kdepim/KDE/4.9] akregator/src/mainwidget.cpp:

In feedListToOPML(), add a crash guard for m_feedList

Should fix the case of even the default feedlist being empty.

FIXED-IN: 4.9.1

Office

Francisco Fernandes committed changes in [calligra/krita-sandpaintop-chicao] /plugins/paintops/sand:

Better mouse velocity calculation based on the dynamic brush mouse filter. Impulse and dumping calculation corrected.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 416ee99...
Boudewijn Rempt committed changes in [calligra] krita/ui/kra/kis_kra_saver.cpp:

Re-enable document compatibility with 2.4

But only if there aren't any compositions. Krita 2.4 can only load
documents where there is nothing else but layers in the image; 2.5
adds compositions and master adds assistants.

So, if there are no compositions, don't save an empty composition tag,
then 2.4 can still load the document. If there are compositions or
assistants, it's tant-pis...

C. Boemann committed changes in [calligra] words/part/KWOdfWriter.cpp:

We shouldn't modify the document on saving, by adding a masterpagename to first paragraph
which is not what the user would expect. Think if the user would later on copy paste this paragraph
to somewhere in the middle of another master page. That would copy the masterpagename to causing an
unwanted pagebreak and masterpage change

This was originally added in 9472dc5b to fix pagestyle not being saved, but a quick check
shows that the original bug https://bugs.kde.org/show_bug.cgi?id=184858 is not reopenend by
removing this code now.

Thorsten Zachmann committed changes in [calligra] /:

Fix memory leaks

==31293== 1,708 (136 direct, 1,572 indirect) bytes in 1 blocks are definitely lost in loss record 2,039 of 2,111
==31293== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==31293== by 0x6B512A1: QObject::QObject(QObject*) (qobject.cpp:721)
==31293== by 0x8767D6D: KoCharacterStyle::KoCharacterStyle(QObject*) (KoCharacterStyle.cpp:343)
==31293== by 0x8773CDF: KoParagraphStyle::KoParagraphStyle(QObject*) (KoParagraphStyle.cpp:97)
==31293== by 0x7F6E40C: KoTextShapeData::loadStyle(KoXmlElement const&, KoShapeLoadingContext&) (KoTextShapeData.cpp:331)
==31293== by 0x8B8EDDD: KoTosContainer::loadText(KoXmlElement const&, KoShapeLoadingContext&) (KoTosContainer.cpp:88)
==31293== by 0x22E762B6: EnhancedPathShape::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (EnhancedPathShape.cpp:585)
==31293== by 0x8B3C5D0: KoShapeFactoryBase::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoShapeFactoryBase.cpp:228)
==31293== by 0x8B38735: KoShapeRegistry::Private::createShapeInternal(KoXmlElement const&, KoShapeLoadingContext&, KoXmlElement const&) const (KoShapeRegistry.cpp:313)
==31293== by 0x8B382BB: KoShapeRegistry::createShapeFromOdf(KoXmlElement const&, KoShapeLoadingContext&) const (KoShapeRegistry.cpp:268)
==31293== by 0x1D047D12: KoPAPageBase::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KoPAPageBase.cpp:212)
==31293== by 0x1CD5DBEA: KPrPage::loadOdf(KoXmlElement const&, KoShapeLoadingContext&) (KPrPage.cpp:126)

here the default style is not freed as the paragraph styles.

REVIEW: 106154

Paul Mendez committed changes in [calligra/stage-paulm-test3] /part/tools/animationtool:

Fix memory leaks

Diffs: 1, 2, 3 Revision 8bad67f...
Boudewijn Rempt committed changes in [calligra] krita/ui/kis_layer_manager.cc:

Fix crash when merging down the top layer if there is a selection

Multimedia

Harald Sitter committed changes in [phonon-vlc] /:

make mimetype generation largely done by cmake

pvlc only features static mimetype listing (i.e. even the runtime
function returns a compile-time static list of mime types as VLC plays
all and everything anyway). up until now this list was manually maintained
in both the desktop file *and* the backend.cpp, this is now replaced by
*one* list in cmake which is consequently put into a c-string array for
backend.cpp (accessed via mime.h as generated by cmake) and regular
list form (; del) for the desktop file.

this also addresses the issues raised in
REVIEW: 106075

Diffs: 1, 2, 3, 4, 5, 6 Revision 80b235b...
Sam Lade committed changes in [amarok] /:

Fix repeat playlist with a single track

If there was only one track in the playlist, it would not be repeated
correctly.


FIXED-IN:2.7
REVIEW:106175

Yuri Chornoivan committed changes in [amarok] /:

Fix various typos (mostly found by Krazy2).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 04bf226...
Sam Lade committed changes in [amarok] src/playlist/layouts/LayoutEditWidget.cpp:

Fix playlist layout 1% width being treated as auto

Items set with a custom fixed width of 1% were erroneously being treated
as if they were set to automatic width.


FIXED-IN:2.7

Harald Sitter committed changes in [phonon-vlc/0.6] src/mediaobject.cpp:

fix aboutToFinish thresh calculation

for continuous streams we get a length of 0, so we need to exclude <= 0
from delta calculation, otherwise aboutToFinish gets immediately emitted
for streams triggering a bogus source change in a consumer

Networking Tools

Joris Guisson committed changes in [libktorrent] /:

Do not pass link local IPv6 addresses to ip parameter of tracker

Joris Guisson committed changes in [ktorrent] /:
Lukas Appelhans committed changes in /trunk/KDE/kdenetwork/kget:

Utilities

Aleix Pol Gonzalez committed changes in [libkpeople/apol/messingup] src/nepomuk-tp-channel-delegate.cpp:

improve nepomuk-tp code

--warnings
don't leak d-pointers

Aleix Pol Gonzalez committed changes in [kde-gtk-config] src/gtkconfigkcmodule.cpp:

Fix setting bogus icon theme

If the settings were wrong it would leave the combo box
empty, now it's just using the first theme in the combo.

David Edmundson committed changes in [ktp-common-internals] KTp/global-presence.cpp:

Don't treat MC errors as fatal


Reviewed-by: Martin Klapetek

Daniel Nicoletti committed changes in [print-manager] /:

Fix some race conditions, and improve PPD selection when called from the new printer popup

Diffs: 1, 2, 3, 4 Revision f6fe421...
Aleix Pol Gonzalez committed changes in [muon/1.4] discover/qml/SourcesPage.qml:

Improve SourcesPage visualization glitch

When the suites and the repo name overlap, elide the repository
name.
I had to remove the italics because of a QML Text limitation.

Features

Accessibility

José Millán Soto committed changes in [qtatspi] /simple:

Added "Rename" and "Reorder"

Added buttons in the List tab to rename a list item and to reorder the
list in order to be able to check that TableModelChanged event is handled.

Diffs: 1, 2, 3 Revision 3c6f6fa...

Development Tools

Michael Pyne committed changes in [kdesrc-build] kdesrc-build-setup:

Add support for specifying an HTTP proxy to setup script.

A prompt is used to ask if a proxy is required, unless the normal
http_proxy env. variable is set, at which point the proxy URL will be
queried for directly (and the value of http_proxy used as the default).

This should implement wish 305410.


FIXED-IN:1.16

Educational

Laurent Garnier committed changes in [kgeography] /:

Added color scramble and option

* Added the possibility to play place clicking with scrambled colorset
in order to not let player memory leniently remember country by color
but really by shape and or place.
* Added an option in configuration dialog for setting "scrambled" or not.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 3ce07a2...

Graphics

Gilles Caulier committed changes in [digikam] /:

apply patch from Marcus Meissner to support libgphoto 2.5.0 API
CC

KDE Base

Martin Klapetek committed changes in [kdeplasma-addons] applets/nowplaying/package/contents/ui/MetadataLine.qml:

Add fade effect to strings change in Now playing plasmoid when in a panel

Reviewed-by: Marco Martin
REVIEW: 106095

Jörg Ehrichs committed changes in [nepomuk-metadata-extractor] /:

Allow to search with a different plugin when no search result could be found

This is pach from Yuen Hoe Lim with some modifications to adapt to the latest changes

The first selected plugin is the one configured as favorite plugin in the KConfig file.
Afterwards all available plugins will be used until a some metadata could be found or no plugins are left.

Martin Gräßlin committed changes in [kde-workspace] /:

Option to disable window close on menu double click in Aurorae

For each theme the setting can be enabled individually with the
default being enabled by default. It is completely handled
inside the MenuButton QML component so each QML theme benefits
from the option automatically, too.


FIXED-IN: 4.10
REVIEW: 106160

Martin Gräßlin committed changes in [kde-workspace] /clients/aurorae/themes/plastik/package/contents:

Support for Plastik's configuration options

Adding a KConfigXT xml file and an ui file to configure the QML
variant of Plastik.

Currently supported options:
* title alignment
* title shadow
* animation of buttons

Missing option:
* colored borders

Diffs: 1, 2, 3, 4 Revision 43fdfe1...
Martin Koller committed changes in [kde-workspace] /:

make the client shutdown timeout configurable

sometimes the timeout for applications to shutdown is too short, e.g.
when running on old hardware, having lots of applications open,
browsers with many tabs, etc.
This patch adds two config entries with which you can define the
timeout before ksmserver kills the apps.
In the [General] section of ksmserverrc you can define:
legacySaveTimeoutSecs (default = 4 seconds)
clientShutdownTimeoutSecs (default = 15 seconds; was 10 before)



FIXED-IN: 4.9.1
REVIEW: 106090

KDE-PIM

Sergio Luis Martins committed changes in [kdepimlibs/calendaring] /calendar:

Introducing sendiTIPMessage().

Was missing in the API.

Implementation was based on kdepim/calendarsupport/utils.cpp
scheduleITIPMethods(). Has async error handling now.

This is used by korganizer's "schedule" menu.

Diffs: 1, 2, 3, 4 Revision aa3e859...
Volker Krause committed changes in [akonadi] /src/storage:

Recover from lost external payload files.

This will reset part table entries for those, so that we'll re-retrieve
them from the corresponding resource.

Diffs: 1, 2, 3, 4 Revision b61141b...
Laurent Montel committed changes in [kdepim] importwizard/thunderbird/thunderbirdsettings.cpp:

Now kmail support attach vcard

Office

Gopalakrishna Bhat committed changes in [calligra] /part:

Introduce Author into the Calligra family.

REVIEW: 106064

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 29d5bb3...
Jarosław Staniek committed changes in [calligra] /:

Add support for user data storage and remember column widths in table

Core
*Add support for user data storage


Table View
*Remember column widths in tabular data view


REVIEW:106132
DIGEST:Kexi gets support for user data storage and remembers column widths of table views.

Networking Tools

Alexander Reinholdt committed changes in /trunk/playground/network/smb4k/smb4k/browser:

Implemented unmounting from within the browser.

Utilities

Jan Lepper committed changes in [krusader] /:

show busy cursor while an application launched by krusader starts up

Michel Ludwig committed changes in [kile/2.1] /:

Add 'Save', 'Save As' and 'Save Copy As' actions to the tab context menu

Friedrich Karl Tilman Pülz committed changes in [publictransport] /timetablemate/src:

Improve presentation of sub journey and binary data in variable dock

- Show binary data in hexadecimal format, add context menu action
to open binary data in Okteta
- Show deeper levels of results in the variable model for the result
script object, this makes data of RouteSubJourneys vivisble in
the variable dock

Diffs: 1, 2, 3 Revision 1bc1877...

Optimization

Graphics

Albert Astals Cid committed changes in [okular] /:

Make the openRecent just be open recent

Stop being too smart for own our good, try to merge open and openRecent actions in just one action
confuses the hell out of people, so let's KISS and just make open recent be open recent


FIXED-IN: 4.10.0

KDE Base

Marco Martin committed changes in [kde-workspace/screenlocker] /screenlocker/greeter:

use Plasma::Package for finding files

however they don't have globally installed desktop files, can't be queried by sycoca

Diffs: 1, 2, 3, 4 Revision 972d146...
David Faure committed changes in [kdelibs/frameworks] /:

Remove the last mentions of KDEHOME everywhere in kdelibs.

Port tests to QStandardPaths::enableTestMode.

Port kstandarddirstest to its own XDG_*_HOME vars (can't use enableTestMode
there, we need to know expected results). That makes it unix-only, probably.

This also meant getting of lnusertemp, which was creating symlinks inside
KDEHOME.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 11 more) Revision 4646c54...
Martin Gräßlin committed changes in [kde-workspace] /kcmkwin/kwindecoration:

Support for custom configuration dialogs for QML decorations

If the decoration package contains a ui file in ui/config.ui and
and KConfigXT xml file in config/main.xml the configure dialog
is extended by the custom values.

For this the ui file is loaded and included in the dialog's
layout. To make this possible the AuroraeConfigForm is changed
to a VBoxLayout containing the so far used FormLayout.

The configuration settings are loaded using Plasma's ConfigLoader
and attached to the widget through a KConfigDialogManager.

Marking this commit as the one which implements QML support for
Aurorae themes:

REVIEW: 105751
REVIEW: 105768

FIXED-IN: 4.10

Vishesh Handa committed changes in [nepomuk-core] /storage:

Merge branch 'storage/mergeBackupService'

The BackupSync service does almost nothing and it doesn't make sense for
it to exist in another process. Combine it with the storage service.

Another reason for doing this is that eventually we will close up the
traditional Soprano interfaces, and the backup service needs special
privileges in order to restore the backup. It can only do so if it
exists in the Storage Service.

Also, I would like to "lock up" the storage service when a backup is
being restored.

Conflicts:
services/backupsync/service/CMakeLists.txt

Diffs: 1, 2, 3, 4, 5 Revision 17a2262...
Jörg Ehrichs committed changes in [nepomuk-metadata-extractor] /nepomukpipe:

Remove old metadata created by the extractor before new data is added again

If the old data is not removed, properties with a cardinality > 1 will still have the old and possibly wrong metadata attached to the file
This patch ensures only the newly selected metadata will be used.

All metadata will be attached with the KComponentData("metadataextractor").
This should ensure adding/removing works even if the library is used outside of the extractor

Diffs: 1, 2, 3, 4 Revision 271cd52...
Vishesh Handa committed changes in [nepomuk-core] /:

Merge branch 'mergeQueryService'

Merge the QueryService into the storage service. This allows the query service
to directly access the virtuoso model instead of using the NepomukMainModel
which uses a local socket to communicate with the model in the storage
service.

Results in a big performance boost for queries using the QueryServiceClient

David Faure committed changes in [kdelibs/frameworks] /solid/src/solid:

Remove xdgbasedirs copy, replace with a call to QStandardPaths.

Cool, huh? :-)

Diffs: 1, 2, 3, 4 Revision ccdef39...
Martin Gräßlin committed changes in [kde-workspace] /:

Split the User Actions Menu out of Workspace

All methods and variables related to the User Actions Menu
(rmb window deco, Alt+F3) is moved out of the Workspace class
into an own UserActionsMenu class.

The class needs only a very small public interface containing
methods to show the menu for a Client, closing the menu and
discarding the menu. Everything else is actually private to the
implementation which is one of the reasons why it makes sense
to split the functionality out of the Workspace class.

As a result the methods and variables have more sane names and
the variable names are standardized.

REVIEW: 106085

FIXED-IN: 4.10

Vishesh Handa committed changes in [kde-workspace] /:

NepomukRunner: Port to NepomukCore

REVIEW: 106117

Diffs: 1, 2, 3, 4, 5, 6 Revision e132740...
David Faure committed changes in [kdelibs/frameworks] /:

Port KStandardDirs to QStandardPaths for XDG_*_HOME, fixes 2 unittests.

(i.e. with Qt5, this makes kbuildsycoca respect --testmode)

Diffs: 1, 2, 3, 4, 5 Revision 7dc82f0...

KDE-PIM

Raphael Kubo da Costa committed changes in [kdepim/KDE/4.9] kmail/avscripts/kmail_clamav.sh:

Use a more portable ps(1) call in the clamav script.

-e means all processes are selected on Linux's ps, while on the BSDs
and OS X it means the environment should be printed along with the
commands.

Replacing -e with -a -x should work on all platforms according to the
Linux, OS X, FreeBSD, OpenBSD and NetBSD man pages.

REVIEW: 106111

Volker Krause committed changes in [kdepimlibs] /:

Allow to use the real Session scheduler when using FakeSession.

This allows easy testing of Akonadi::Job, as well as parts of Session
itself.

Diffs: 1, 2, 3, 4, 5, 6 Revision 4506cc4...
Allen Winter committed changes in [kdepim] libksieve/kmanagesieve/session.cpp:

wrap the KPasswordDialog in a QPointer to inhibit crashes.

Office

Stephane Mankowski committed changes in [skrooge/Feature] /:

Set default type as "currency" in "Units" page when primary and secondary units are already defined

Diffs: 1, 2, 3 Revision 3bb639e...

Multimedia

Harald Sitter committed changes in [phonon-vlc] /:

implement pausedplay mechanic

phonon's api suggest that pausing before playing is possible (through
naming of the interfaces) however vlc does not provide any such
functionality so once again we do a nasty intercept-hack.

pausedPlay issues a regular play but then intercepts the VLC playing
event and directly switches to paused.
nothing outside MediaPlayer ever knows that VLC actually was in playing
state and a completely transparent switch from non-playing to paused
becomes possible.

please note that this does not in any way guarantee that no audio/video
samples are already sent to the output. it merely tries to reduce the
chance of this happening by calling pause in the event callback, which
is of course threaded from the pipeline so anything can happen between
us getting the signal and asking VLC to pause.

verification for backport pending.

Utilities

Friedrich Karl Tilman Pülz committed changes in [publictransport] /:

Add RouteSubJourneys and RouteNews

- RouteNews contain information strings about each connection
between two route stops
- RouteSubJourneys contain data about routes between connecting stops
- There are now intermediate stops that are also connecting stops,
ie. intermediate stops in journeys where the vehicle gets changed
- Intermediate (not connecting) stops can be toggled in the applet
with the context menu
- Update DepartureProcessor to load sub journeys into a new
RouteSubJourney struct
- Update JourneyRouteGraphicsItem to show routes with/without
intermediate stops, but always with connecting stops
- Without RouteSubJourneys information from the engine journeys
should be drawn like before
- Add routeNews() and routeSubJourneys() to DepartureInfo
in libpublictransporthelper and add struct RouteSubJourney

TODO: Maybe turn the intermediate stop toggle action into
a StopAction to toggle specific sub journeys and not all at once
TODO: Update providers to provide such information

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 06128e8...
Jonathan Michael Thomas committed changes in [libqapt/1.4] src/history.cpp:

Delete invalid history items to avoid leaking memory in this case.

Games

Arjen Hiemstra committed changes in [gluon/graphics-backendabstraction-ahiems] /examples/invaders.gluon:

Player/Invaders: Use the new components for interface rendering.

Diffs: 1, 2, 3, 4 Revision a0015ff...

Other

Development Tools

Ivan Shapovalov committed changes in [kdevelop] projectmanagers/cmake/cmakemanager.cpp:

Replace custom CMakeLists.txt creation with call to createFile().

REVIEW: 106155

KDE Base

David Faure committed changes in [kdelibs/frameworks] kioslave/http/tests/httpheaderdispositiontest.cpp:

Finish fixing this unittest for Qt5, with the use of more QString::fromLatin1

Marco Gulino committed changes in [kde-workspace] /:

Merge branch 'plasma/bookmarksrunner-chrome-gulino' of git.kde.org:kde-workspace
Merging Bookmarks runner refactorings, including new support for Chrome/Chromium bookmarks,
and both Chrome and Firefox favicons.

Office

Dan Leinir Turthra Jensen committed changes in [calligra/krita-sketch-rempt] /sketch:

Skeleton for layers model

Diffs: 1, 2, 3 Revision ee68070...

Multimedia

Sinny Kumari committed changes in [plasma-mediacenter/sinny-picasa] /onlineservices:

Added existing Picasa Backend. Need to be modified now to make it working

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision e91c960...

Networking Tools

Alexander Reinholdt committed changes in /trunk/playground/network/smb4k/CMakeLists.txt:

Increase minimal KDE version to 4.6 because of the use of KDualAction.

Utilities

Aleix Pol Gonzalez committed changes in [muon] /:

Make it possible to detect the disabled sources