Issue 253

16th September 2012 by KDE Commit-Digest Team

Contributors

Aleix Pol
Martin Cigorraga
Marta Rybczynska
Michael Torres

This Week...

Amarok adds support for mod, s3m, it and xm with TagLib 1.8. Konsole can trim spaces at end of line. Conquirere replaces KBibTeX online search with the Metadata Extractor plugin version. Work on packagekit dataengine for use in application launchers in KDE-Workspace; ongoing work on KDE Frameworks. Amarok updates Amazon store support. Bugfixes in KDE-PIM, KDE base applications, Calligra.

Statistics

Commits 1880 by 157 developers
Open Bugs 21379
Open Wishes 15952
Bugs Opened 332 in the last 7 days
Bugs Closed 327 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
175
 
/branches/stable
86
 
/trunk/www
43
 
/trunk/l10n-support
32
 
/krita/sketch
23
 
/trunk/KDE
12
 
/utilities/imageeditor
12
 
/generic/applets
11
 
/sketch/qml
10
 
/messagecomposer/autocorrection
9
 
Files Developer Commits
321
 
Wolfgang Rohdewald
107
 
246
 
Gilles Caulier
106
 
264
 
Laurent Montel
95
 
171
 
Aurélien Gâteau
57
 
144
 
Aleix Pol Gonzalez
48
 
114
 
Dan Leinir Turthra Jensen
38
 
102
 
Albert Astals Cid
34
 
93
 
Marco Martin
33
 
96
 
Jonathan Michael Thomas
32
 
87
 
Roman Paholík
29
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
99%
 
Swedish (sv)
99%
 
Polish (pl)
98%
 
Estonian (et)
97%
 
French (fr)
96%
 
Spanish (es)
96%
 
Dutch (nl)
96%
 
German (de)
94%
 
Italian (it)
91%
 
Danish (da)
88%
 

Bug Killers

Person Bugs Closed
Myriam Schweingruber
90
 
Jekyll Wu
33
 
Gilles Caulier
20
 
Dawit Alemayehu
16
 
Christoph Feck
13
 
Ben Cooksley
13
 
Thomas Lübking
9
 
Laurent Montel
8
 
Jarosław Staniek
7
 
Frank Reininghaus
6
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]   []   

Educational

[]   []   []

Graphics

[]     

KDE Base

[] [] []   

KDE-PIM

[]     

Office

[]   []   

Konqueror

     

Multimedia

[] [] []   []

Networking Tools

[] [] []   

User Interface

[]     

Utilities

     

Games

     

Other

   []   []

There are 67 selections this week

Bug Fixes

Development Tools

Aleix Pol Gonzalez committed changes in [kdevelop/4.4] projectmanagers/cmake/parser/cmakeprojectvisitor.cpp:

Improve properties fetching

In case it's a directory property and the directory is not specified,
use the cmake_current_source_dir value as the directory.

Educational

Sebastian Gottfried committed changes in [ktouch/next] src/qml/TrainingScreenToolbar.qml:

training screen: fix appearance of toolbar

Apparently one can't have PlasmaCore.FrameSvgItem with bottom border
without having a top border, too.

M +- -- images/trainingscreen.svgz

Aleix Pol Gonzalez committed changes in [analitza/aucahuasi/analitzaplot] /:

Fix PlotsView3D

- Remove Proxy complexity, like we did for 2D.
- Compare spaceDimension to Dim3D instead of just 3, this doesn't hold
anymore

Graphics

Aurélien Gâteau committed changes in [gwenview/texture] /:

Don't block thumbnail creation when scrolling

Instead of blocking thumbnail generation when scrolling, make sure thumbnailing is only restarted every 500 ms.
This also removes the delay that occurs between entering a new folder and starting of thumbnailing.

Diffs: 1, 2, 3, 4 Revision 1e68214...

KDE Base

Lamarque Souza committed changes in [kde-workspace/KDE/4.9] ksmserver/themes/default/main.qml:

Do not unnecessarily show "Restart Computer" button and remove excess of
free space in shutdown dialog.


FIXED-IN: 4.9.2
(cherry picked from commit fab7292269777ed2e46cf444a47a9e8da950fcbe)

Emmanuel Pescosta committed changes in [kde-baseapps/KDE/4.9] dolphin/src/kitemviews/kitemlistcontroller.cpp:

Fixes Bug 305783 - dragging a file over a directory #c4
does not expand the dir => Bug discovered: When you drag a
item onto a folder-view-item and then move it away
instantly before the autoactivation event is triggered
(After 750ms), the folder will be opened anyway.


REVIEW: 106381
FIXED-IN: 4.9.2
(cherry picked from commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881)

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] libnepomukcore/query/query.cpp:

QueryLib: Fix FileQuery::QueryFolders

Since nfo:Folders contain a nie:url, they are also nfo:FileDataObjects.
If we only want folders in our search results, we must only select the
nfo:Folders.

Currently we contruct a term with nfo:Folders and no nfo:FileDataObject.
This results in empty results being returned.

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.9] /src:

Re-enable renaming items with the rename dialog

User feedback has shown that many users used the dialog for renaming
files. Since the dialog is still used when renaming multiple files, I
think there is no good reason not to use it for renaming single files
as well if the user wants.

Note that we cannot add an option in the settings dialog due to string
freeze issues. For the time being, you will have to add the line
"RenameInline=false" to the [General] section of
$KDEHOME/share/config/dolphinrc.


FIXED-IN: 4.9.2

Dawit Alemayehu committed changes in [konsole] src/SessionController.cpp:

Fixed the 'Search for' URL filtering support.

REVIEW: 106419
(cherry picked from commit d07c5be899b8bfafabeba57eeaaf011b3ce7db98)

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.9] dolphin/src/kitemviews/kstandarditemlistwidget.cpp:

Fix possible crash in KStandardItemListWidget::paint()

According to the backtrace in the bug report, it is possible that
KStandardItemListWidget::paint() is called if the hash m_textInfo has
not been initialised. The widget's index must be -1 in this case, see
KStandardItemListWidget::triggerCacheRefreshing(). It looks like this
can only happen if the item is about to be removed from the view, see
KItemListView::slotItemsRemoved().

I could not reproduce the crash, so I'm not sure why exactly this
happens, but this commit should at least prevent the crash.


FIXED-IN: 4.9.2

Vishesh Handa committed changes in [nepomuk-core/KDE/4.9] autotests/test/querytests.cpp:

QueryTests: Fix the File Tests

The tests exposed a bug in virtuoso, which made it return incorrect
results when querying for the type of resources, with inferencing
enabeled. Therefore, we are now querying for the nie:url.

This commit may be reverted when virtuoso has been fixed.

Dawit Alemayehu committed changes in [kdelibs/KDE/4.9] kdewebkit/kwebwallet.cpp:

Do not prompt the user when a website login credential is unchanged and had
previously been saved in persistent storage.


FIXED-IN: 4.9.2

Dawit Alemayehu committed changes in [kdelibs/KDE/4.9] kio/kio/kautomount.cpp:

Fixed hard disk shortcuts not launching the mounted partition in a file manager when the
mounting is done through a LABEL or a UUID.


FIXED-IN: 4.9.2
REVIEW: 106446

Vishesh Handa committed changes in [nepomuk-core/feature/newIndexer] /:

FileIndexer: Remove Strigi

Do not use Strigi for file indexing. Instead, we use our SimpleIndexer
which just extracts the basic metadata for the file.

This patch almost all traces of strigi from the Nepomuk Code base.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 7 more) Revision aa06cc7...
Ralf Jung committed changes in [kde-workspace/KDE/4.9] libs/plasmaclock/calendar.cpp:
Dawit Alemayehu committed changes in [kde-baseapps] lib/konq/favicons/favicons.cpp:

Allow proxy authentication when attempting to retrieve favorite icons.


FIXED-IN: 4.9.2
(cherry picked from commit 73bb93cdd424e12f431cec356a1a5a26710a2451)

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.9] /shellcmdplugin:

Fixed the shell command plugin to show the selected items when launched.


FIXED-IN: 4.9.2
REVIEW: 106440

Luca Beltrame committed changes in [kde-workspace] plasma/generic/scriptengines/python/plasma_importer.py:

Unbreak Python 2 applet loading.

exec() is a function in Py3, but the syntax used in this file does not
allow it for being called as a function in Python 2. Thus, a simple check
is made, calling the right function depending on the Python version.

Anyone who has Python3 installed, please confirm that it works.

KDE-PIM

Laurent Montel committed changes in [kdepim/KDE/4.9] /:

Fix Bug 306700 - Command line option --msg does not work

FIXED-IN: 4.9.2

Laurent Montel committed changes in [kdepim/KDE/4.9] /:

Fix Bug 298831 - Kmail2 crash on save as draft

FIXED-IN: 4.9.2

Laurent Montel committed changes in [kdepim/KDE/4.9] mailcommon/searchpatternedit.cpp:

Fix Bug 150410 - configure filter rules: suggest mail field as-you-type

FIXED-IN: 4.9.2

David Jarvie committed changes in [kdepim-runtime/KDE/4.9] plugins/akonadi_serializer_kalarm.cpp:

Bug 297039: Improve diagnostics for attribute error.

Put out diagnostic messages to show what went wrong if an
EventAttribute cannot be fetched.

Use the correct debug area.

Backport edae867614453fedd09aff54b45b6276e5ba840a (master)

Office

Jörg Ehrichs committed changes in [conquirere] src/core/queryclients/queryclient.cpp:

Fixed bug where chanegd resources do not change in the table model

This uses a workaround with an additional QEventloop to cope with some problems in the ResourceWatcher
see bug: 306091 for more.

Jarosław Staniek committed changes in [calligra/calligra/2.5] kexi/kexidb/connection.cpp:

Fix possible crash when saving changes to design of table used elsewhere


FIXED-IN:2.5.3

Francisco Fernandes committed changes in [calligra/krita-sandpaintop-chicao] /plugins/paintops/sand:

Fixed the crash in the settings preview widget: only possible to "Pouring" operations.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision f215b63...
Jarosław Staniek committed changes in [calligra/kexi-altertable-staniek] /:

Force lowercase letters for object ids; fix for not-all-lowercase names

General
*Force lower case letters for object identifiers (except for widget names)
**This adds consstency and fixes issue with
**Also fix support for objects renamed to not-all-lowercase in earlier version of Kexi.

Multimedia

Sven Krohlas committed changes in [amarok] src/services/amazon/AmazonStore.cpp:

use a unique prefix for messages from the mp3 store


FIXED-IN:2.7

Martin Blumenstingl committed changes in [kaffeine] src/dvb/dvbdevice_linux.cpp:

Fix the "No device found." error when switching channels.

libvlc forks another thread. This is a problem when trying to close file
descriptors, because these can only be closed if all child-threads are
finished.
The correct fix for this is to simply set O_CLOEXEC when opening the
file descriptor of the frontend.
This lets the dvbdevice-thread close the handle again.

REVIEW: 106259

Harald Sitter committed changes in [phonon-vlc] src/devicemanager.cpp:

force pulse aout injection

if the injection code is reached pulse is not active in libphonon which
essentially means that device listing/selection is also not pulse driven,
in that case it would then be impossible to output to pulse directly if
we do not inject the aout manually

Sven Krohlas committed changes in [amarok] /:

Use the context info applet to show further infos about a selected item

An artist might be handy to give it a better look, but the functionality
is there and doesn't look that bad. It shows the contents of an album
including cover, artist search, add to cart and preview links.


FIXED-IN:2.7

Martin Blumenstingl committed changes in [kaffeine] src/backend-vlc/vlcmediawidget.cpp:

Fixed a crash in libvlc if there are no subtitles available

kaffeine crashes, when watching DVB and there are no subtitles for the
current channel available.
DvbLiveView::pmtSectionChanged sets subtitlePid to -1 if there are no
subtitles available. VlcMediaWidget::setCurrentSubtitle unconditionally
adds 1 to the requested subtitle index.
Now we're trying to activate subtitle 0 which does not exist.
If subtitle -1 was given then we really want to disable subtitles
(= sending -1 to libvlc).

This patch also makes setCurrentSubtitle more robust.

REVIEW: 106297

Jekyll Wu committed changes in [bangarang] src/platform/utilities/mediaitems.cpp:

fix one typical typo between "=" and "==" operators

Now the code matches the comment and makes sense.

Sven Krohlas committed changes in [amarok] /:

Amazon store: we now have our own .amz downloader :)

* requires clamz, qt -> portable and also interesting for other projects
* patch includes MIME-types for .amz files and hooks in .desktop files
so that a user just needs to click on an .amz file to make the magic
happen
* still a very basic app, but it works

FIXED-IN:2.7

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 5df2891...

Networking Tools

David Edmundson committed changes in [networkmanagement] libs/ui/security/wirelesssecurityauth.cpp:

Fix a bug in which the wireless password prompt dialog would be shown at an incorrect size


REVIEW: 106437

Martin Klapetek committed changes in [ktp-contact-list/kde-telepathy-0.5] tooltips/tooltipmanager.cpp:

Remove hide timer from tooltips


FIXED-IN: 0.5.1
Reviewed-by: David Edmundson

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-transparent] style/oxygenblurhelper.cpp:

Do not set opaque region behind konsole, since it breaks transparent themes.

Features

KDE Base

Gregor Tätzner committed changes in [kde-workspace/kickoff-qml] /:

Created packagekit dataengine for use in application launchers

It provides an uninstallApplication service to remove applications and
you can also check if packagekit is available

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision cd0d95b...
Vishesh Handa committed changes in [nepomuk-core/feature/newIndexer] /:

FileIndexer: Poppler Based Extractor

Added a very simple extractor for PDF files based on poppler. The
indexing is currently done in two parts. The first part is just the
basic metadata via the SimpleIndexer, and the second part is the file
specific metadata.

We have a simple Extractor class, from which the Extractors are
derived. Eventually, the architecture will need to be improved, but for
this this will have to work.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 658b36e...

Multimedia

Harald Sitter committed changes in [phonon-vlc] /:

Always build with pulseaudio enabled

PA support in libphonon is run-time dependent, so excluding backend
support at build time makes little sense as the API is there anyway

REVIEW: 106326

Diffs: 1, 2, 3, 4 Revision 2052134...
Sven Krohlas committed changes in [amarok] /services/amazon:

Amazon store: give the user hints to a simpler checkout

Amazon asks the user to download their downloader as long as the
"download installed" cookie is not set in the browser. The checkout
process is hard to compelte without that cookie (you have to find quite
well hidden links to continue).
Therefore I'm putting links to set that cookie at several places in
the gui.

Diffs: 1, 2, 3, 4, 5 Revision beef4be...
Matěj Laitl committed changes in [amarok] /:

Tag reading/writing support for mod, s3m, it and xm files with TagLib >= 1.8

This patch adds read/write tag support for mod, s3m, it and xm files if
TagLib supports it. All new parts are #ifdefed so it won't break if an
old TagLib version is used.

REVIEW: 101598
DIGEST: Feature: add support for mod, s3m, it and xm with TagLib 1.8

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision bf97fa3...

Networking Tools

Lamarque Souza committed changes in [networkmanagement/arthur] /:

Add bluetooth interface item.

Optimization

Development Tools

Ivan Shapovalov committed changes in [kdevplatform] /:

Add class OutputExecuteJob.

It will be a common base class for all jobs which execute processes
and need their input to be processed somehow.

It allows to configure process working directory and environment,
privilege helper, model's filtering strategy and custom job name.

This is for code deduplication.

Diffs: 1, 2, 3 Revision f6f66e0...

Educational

René Küttner committed changes in [marble] /:

StarsPlugin: add the Sun

REVIEW: 106375

Diffs: 1, 2, 3, 4 Revision 6d9e83c...
Aleix Pol Gonzalez committed changes in [analitza/aucahuasi/analitzaplot] analitzaplot/private/abstractfunctiongraph.h:

when requesting the errors for a plot, provide the analyzer errors too

otherwise we get to those dumb situations where it's not correct and the
errors are empty

Aleix Pol Gonzalez committed changes in [analitza/aucahuasi/analitzaplot] analitzaplot/plotter2d.cpp:

Always use updateFunctions for recalculating the curves

...or we get in situations like this, where we had a code path without
filtering for isVisible

Aleix Pol Gonzalez committed changes in [analitza/aucahuasi/analitzaplot] /:

Use the intervals to tell if a plot should be updated

If the plot has no intervals specified, we automatically consider the
viewport as the source of those intervals.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 8f172a3...

KDE Base

Kurt Hindenburg committed changes in [konsole] /:

Allow option to trim spaces at end of line

In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces. By default, it is disabled so only
people who need this will be affected.

Many thanks to David Smid

Marco Martin committed changes in [plasma-mobile] applications/filebrowser/package/contents/ui/Browser.qml:

better drag behavior

slightly transparent drag delegate

David Faure committed changes in [kdelibs/frameworks] kdecore/date/ksystemtimezone.cpp:

Use DBus autostart for kded5.

This removes the dependency on KToolInvocation::klauncher() at compile time,
and on kdeinit/klauncher at runtime.

Fredrik Höglund committed changes in [kde-workspace] kwin/libkwineffects/kwingltexture.cpp:

kwin: Don't enable/disable texturing when using shaders

This state has no affect on the programmable pipeline.

Vishesh Handa committed changes in [nepomuk-core/feature/newIndexer] /fileindexer:

FileIndexer: Remove threading code from the IndexScheduler

Since most of the work of the IndexScheduling work is done by a separate
process, there is no need for it to run in a separate thread.

The only slight amount of blocking work that is done is listing the
contents of a directory and testing if they should be indexed. And that
is fairly fast in practise.

Diffs: 1, 2, 3, 4 Revision 86dd25f...
David Faure committed changes in [kdelibs/frameworks] /:

Port SlaveBase from KUrl to QUrl

kioslave authors will have to really watch for -Woverloaded-function warnings,
but this is the only way to clean up the API and deprecate KUrl afterwards.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 07b38ce...
Vishesh Handa committed changes in [nepomuk-core/feature/newIndexer] /fileindexer/indexer:

FileIndexer: Create plugins for individual extractor

Each Extractor is now a plugin, and is optionally compiled

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 11 more) Revision 0aa8f5a...
Vishesh Handa committed changes in [nepomuk-core/feature/newIndexer] /fileindexer:

File Index Scheduler: Remove the concept of Indexing Speeds

We can now only switch indexing on or off.

When the system is being used, no files will be indexed. This detection
is done via KIdleTime.

Diffs: 1, 2, 3 Revision 1b7075d...
Fredrik Höglund committed changes in [kde-workspace] /:

kwin: Don't hold an X server grab while painting the screen

According to Pierre-Loup Griffais (Plagman on IRC) this is causing
choppy VDPAU video playback when compositing is enabled.

Removing these calls doesn't seem to cause any regressions, and the
commit that added them doesn't give a reason. So let's just get rid
of them for now.

This commit should be cherry-picked to the stable branch if no one
else notices any regressions.

Office

Jörg Ehrichs committed changes in [conquirere] /:

Replace KBibTeX online search with the Metadata Extractor plugin version

Instead of KBibTeX search plugins that are written in C++ and harder to maintain
The publication websearch now uses the Metadata extractor library.

This reduce the available website a bit for now, but is a lot easier to extend via python
in the future. This also adds the ability to download references for the selected publication
while importing them.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision d2d233d...
Dan Leinir Turthra Jensen committed changes in [calligra/krita-sketch-rempt] /sketch/qml/panels:

Panels should now be behaving much more pleasantly

Sorting out the interaction of multiple interdependent tri-state
state machines is all sorts of fun, so let's just not. They are now
no longer interdependent, and simply ignore input from other panels
which ensures that only the actually peeked item is handled.

This commit also clears the peek state when going from peek to full

Multimedia

Sven Krohlas committed changes in [amarok] src/services/amazon/AmazonInfoParser.cpp:

Amazon store: waaaay improved context view design

Preview:
https://dl.dropbox.com/u/14741730/amazon-amarok-19.png

Btw:
Currently prices for tracks in compilations and artist names in normal
albums are wrong, due to changes at Amazon. We are going to fix that
on the server side soonish.

Harald Sitter committed changes in [kmix] /:

implement runtime KSNI updates

previously kmix would throw away the KSNI and completely recreate it to
pick up mixer changes. incidentally enough doing that triggers repaints
and rescaling in plasma leading to utterly silly flickering. paritcularly
since pulseaudio stream changes (e.g. a track change in amarok) would
cause such an "update" you'd have a steady flow of flickering systray

the situation was resolved by introducing a MetaMixer in the DockWidget.
MetaMixer behaves like an abstraction wrapper around the actual Mixer. it
replicates the necessary interfaces/signals/slots and internally
controls the wiring to the actual mixer. that way the dockwidget can
connect() once to the metamixer signals while internally the mixer might
be constantly changing. then when an update is required the new update()
function is called, which calls reset() on the metamixer, which rewires
against the new master mixer and then automatically triggers UI updates

Diffs: 1, 2, 3 Revision d1344b6...
Sven Krohlas committed changes in [amarok] /:

Amazon Store: Support adding items to the cart using amarok:// URLs

Now you can click on a URL like

amarok://service-amazonstore?asin=B004UQSB8I&command=addToCart&name=The%20Cure%20-%20Disintegration%20(Remastered)&price=989

and one of the best albums ever recorded is being put into your shopping
cart. This is going to be used in the info applet, hopefully soonish.

Btw, searching has also been available for some time now:
amarok://navigate/MP3%20Music%20Store/?filter=something_to_search_for

So script writers have something to play with. :-)

Networking Tools

Dan Vratil committed changes in [telepathy-logger-qt] /:

Move API for clearing logs to Tpl::LogManager

- move the API from Tpl::Logger to Tpl::LogManager and drop the Logger
- rename Tpl::PendingLogger operation to Tpl::PendingClear

REVIEW: 106228

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision df9d4fb...
Emmanuel Lepage Vallee committed changes in [sflphone-kde] /:

[ #15382 ] Rewrite DTMF handling, behavior is now consistent

There is 5 cases
1) There is no call, then create one
2) There is one or more call and the active call is also selected, then send DTMF to the active call
3) There is multiple call, but the active one is not selected, then create a new call or add to existing dialing call
4) There is only inactive calls, then create a new one or add to existing dialing call
5) There is only FAILURE, BUSY or UNKNOWN calls, then create a new one or add to existing dialing call

When adding to dialing call, select it to give user feedback of where the tone went.

Any other comportment need to be documented here or treated as a bug. This commit also strenghen client against daemon crashing.

Diffs: 1, 2, 3, 4 Revision 9e3f11d...

Other

Daniel Calviño Sánchez committed changes in [veritas] /:

Refactor to move counters from view to model.

The model emits signals when the number of items change, but it did not
provide get methods to know that number of items, so the view had to
keep its own counters and update them when the model emitted the
signals. Get methods were added to the model and the counters were
removed from the view.

Diffs: 1, 2, 3, 4, 5 Revision c44ba69...

Other

Educational

Aleix Pol Gonzalez committed changes in [analitza/aucahuasi/analitzaplot] /private:

In the builder make the arguments a string list

there's not really a point in creating them every time. Also this makes
it possible to store them sorted, so we can properly match functions.

(x,y)->... is the same type as (y,x)->...

...no?

Multimedia

Matěj Laitl committed changes in [amarok] /:

Merge branch 'meta-observer-refactor'

* meta-observer-refactor:
Meta::Observer: observing no longer prevents destruction
Make Meta::Observer thread-safe
Meta::Observer: use a bit of templating to remove ~150 lines of code
Document Meta::Observer::subscribe() methods

CCing amarok-devel because this changes semantics of the core API
a bit.

CC

Other

Daniel Calviño Sánchez committed changes in [veritas] /:

Unify message shown when the tests are completed.

Instead of using a specific message, add "Finished" or "Stopped" before
the "Ran X tests in Y seconds" message shown after finishing each test.
Moreover, the previous message of "All tests completed" could be
confusing, as it was used even when some tests were not selected.

Diffs: 1, 2, 3 Revision 1914428...