16th September 2012by KDE Commit-Digest Team
|Commits||1880 by 157 developers|
|Bugs Opened||332 in the last 7 days|
|Bugs Closed||327 in the last 7 days|
|Aleix Pol Gonzalez||
|Dan Leinir Turthra Jensen||
|Albert Astals Cid||
|Jonathan Michael Thomas||
Internationalization (i18n) Status
There are 67 selections this week
Improve properties fetching
In case it's a directory property and the directory is not specified,
use the cmake_current_source_dir value as the directory.
training screen: fix appearance of toolbar
Apparently one can't have PlasmaCore.FrameSvgItem with bottom border
without having a top border, too.
M +- -- images/trainingscreen.svgz
- Remove Proxy complexity, like we did for 2D.
- Compare spaceDimension to Dim3D instead of just 3, this doesn't hold
Don't block thumbnail creation when scrolling
Instead of blocking thumbnail generation when scrolling, make sure thumbnailing is only restarted every 500 ms.
This also removes the delay that occurs between entering a new folder and starting of thumbnailing.
Do not prompt the user when a website login credential is unchanged and had
previously been saved in persistent storage.
plasmaclock: Fix calendar resizing
Fixed hard disk shortcuts not launching the mounted partition in a file manager when the
mounting is done through a LABEL or a UUID.
QueryTests: Fix the File Tests
The tests exposed a bug in virtuoso, which made it return incorrect
results when querying for the type of resources, with inferencing
enabeled. Therefore, we are now querying for the nie:url.
This commit may be reverted when virtuoso has been fixed.
QueryLib: Fix FileQuery::QueryFolders
Since nfo:Folders contain a nie:url, they are also nfo:FileDataObjects.
If we only want folders in our search results, we must only select the
Currently we contruct a term with nfo:Folders and no nfo:FileDataObject.
This results in empty results being returned.
Fix possible crash in KStandardItemListWidget::paint()
According to the backtrace in the bug report, it is possible that
KStandardItemListWidget::paint() is called if the hash m_textInfo has
not been initialised. The widget's index must be -1 in this case, see
KStandardItemListWidget::triggerCacheRefreshing(). It looks like this
can only happen if the item is about to be removed from the view, see
I could not reproduce the crash, so I'm not sure why exactly this
happens, but this commit should at least prevent the crash.
Fixes Bug 305783 - dragging a file over a directory #c4
does not expand the dir => Bug discovered: When you drag a
item onto a folder-view-item and then move it away
instantly before the autoactivation event is triggered
(After 750ms), the folder will be opened anyway.
(cherry picked from commit 9ab8bcd6aa3ce5d96ee380d5f22d77c2f0a38881)
Unbreak Python 2 applet loading.
exec() is a function in Py3, but the syntax used in this file does not
allow it for being called as a function in Python 2. Thus, a simple check
is made, calling the right function depending on the Python version.
Anyone who has Python3 installed, please confirm that it works.
Fixed the shell command plugin to show the selected items when launched.
Do not unnecessarily show "Restart Computer" button and remove excess of
free space in shutdown dialog.
(cherry picked from commit fab7292269777ed2e46cf444a47a9e8da950fcbe)
Allow proxy authentication when attempting to retrieve favorite icons.
(cherry picked from commit 73bb93cdd424e12f431cec356a1a5a26710a2451)
Re-enable renaming items with the rename dialog
User feedback has shown that many users used the dialog for renaming
files. Since the dialog is still used when renaming multiple files, I
think there is no good reason not to use it for renaming single files
as well if the user wants.
Note that we cannot add an option in the settings dialog due to string
freeze issues. For the time being, you will have to add the line
"RenameInline=false" to the [General] section of
Bug 297039: Improve diagnostics for attribute error.
Put out diagnostic messages to show what went wrong if an
EventAttribute cannot be fetched.
Use the correct debug area.
Backport edae867614453fedd09aff54b45b6276e5ba840a (master)
Fix Bug 306700 - Command line option --msg does not work
Fix Bug 150410 - configure filter rules: suggest mail field as-you-type
Fixed bug where chanegd resources do not change in the table model
This uses a workaround with an additional QEventloop to cope with some problems in the ResourceWatcher
see bug: 306091 for more.
Force lowercase letters for object ids; fix for not-all-lowercase names
*Force lower case letters for object identifiers (except for widget names)
**This adds consstency and fixes issue with
**Also fix support for objects renamed to not-all-lowercase in earlier version of Kexi.
Fix possible crash when saving changes to design of table used elsewhere
Fixed the crash in the settings preview widget: only possible to "Pouring" operations.
Fix the "No device found." error when switching channels.
libvlc forks another thread. This is a problem when trying to close file
descriptors, because these can only be closed if all child-threads are
The correct fix for this is to simply set O_CLOEXEC when opening the
file descriptor of the frontend.
This lets the dvbdevice-thread close the handle again.
force pulse aout injection
if the injection code is reached pulse is not active in libphonon which
essentially means that device listing/selection is also not pulse driven,
in that case it would then be impossible to output to pulse directly if
we do not inject the aout manually
Use the context info applet to show further infos about a selected item
An artist might be handy to give it a better look, but the functionality
is there and doesn't look that bad. It shows the contents of an album
including cover, artist search, add to cart and preview links.
fix one typical typo between "=" and "==" operators
Now the code matches the comment and makes sense.
Fixed a crash in libvlc if there are no subtitles available
kaffeine crashes, when watching DVB and there are no subtitles for the
current channel available.
DvbLiveView::pmtSectionChanged sets subtitlePid to -1 if there are no
subtitles available. VlcMediaWidget::setCurrentSubtitle unconditionally
adds 1 to the requested subtitle index.
Now we're trying to activate subtitle 0 which does not exist.
If subtitle -1 was given then we really want to disable subtitles
(= sending -1 to libvlc).
This patch also makes setCurrentSubtitle more robust.
Amazon store: we now have our own .amz downloader :)
* requires clamz, qt -> portable and also interesting for other projects
* patch includes MIME-types for .amz files and hooks in .desktop files
so that a user just needs to click on an .amz file to make the magic
* still a very basic app, but it works
Remove hide timer from tooltips
Reviewed-by: David Edmundson
Do not set opaque region behind konsole, since it breaks transparent themes.
FileIndexer: Poppler Based Extractor
Added a very simple extractor for PDF files based on poppler. The
indexing is currently done in two parts. The first part is just the
basic metadata via the SimpleIndexer, and the second part is the file
We have a simple Extractor class, from which the Extractors are
derived. Eventually, the architecture will need to be improved, but for
this this will have to work.
Amazon store: give the user hints to a simpler checkout
Amazon asks the user to download their downloader as long as the
"download installed" cookie is not set in the browser. The checkout
process is hard to compelte without that cookie (you have to find quite
well hidden links to continue).
Therefore I'm putting links to set that cookie at several places in
Tag reading/writing support for mod, s3m, it and xm files with TagLib >= 1.8
This patch adds read/write tag support for mod, s3m, it and xm files if
TagLib supports it. All new parts are #ifdefed so it won't break if an
old TagLib version is used.
DIGEST: Feature: add support for mod, s3m, it and xm with TagLib 1.8
Add bluetooth interface item.
Add class OutputExecuteJob.
It will be a common base class for all jobs which execute processes
and need their input to be processed somehow.
It allows to configure process working directory and environment,
privilege helper, model's filtering strategy and custom job name.
This is for code deduplication.
when requesting the errors for a plot, provide the analyzer errors too
otherwise we get to those dumb situations where it's not correct and the
errors are empty
Always use updateFunctions for recalculating the curves
...or we get in situations like this, where we had a code path without
filtering for isVisible
better drag behavior
slightly transparent drag delegate
Use DBus autostart for kded5.
This removes the dependency on KToolInvocation::klauncher() at compile time,
and on kdeinit/klauncher at runtime.
Allow option to trim spaces at end of line
In the ongoing issue with spaces at the end of lines, this allows for
an option to trim the spaces. By default, it is disabled so only
people who need this will be affected.
Many thanks to David Smid
FileIndexer: Remove threading code from the IndexScheduler
Since most of the work of the IndexScheduling work is done by a separate
process, there is no need for it to run in a separate thread.
The only slight amount of blocking work that is done is listing the
contents of a directory and testing if they should be indexed. And that
is fairly fast in practise.
kwin: Don't enable/disable texturing when using shaders
This state has no affect on the programmable pipeline.
File Index Scheduler: Remove the concept of Indexing Speeds
We can now only switch indexing on or off.
When the system is being used, no files will be indexed. This detection
is done via KIdleTime.
kwin: Don't hold an X server grab while painting the screen
According to Pierre-Loup Griffais (Plagman on IRC) this is causing
choppy VDPAU video playback when compositing is enabled.
Removing these calls doesn't seem to cause any regressions, and the
commit that added them doesn't give a reason. So let's just get rid
of them for now.
This commit should be cherry-picked to the stable branch if no one
else notices any regressions.
Panels should now be behaving much more pleasantly
Sorting out the interaction of multiple interdependent tri-state
state machines is all sorts of fun, so let's just not. They are now
no longer interdependent, and simply ignore input from other panels
which ensures that only the actually peeked item is handled.
This commit also clears the peek state when going from peek to full
Replace KBibTeX online search with the Metadata Extractor plugin version
Instead of KBibTeX search plugins that are written in C++ and harder to maintain
The publication websearch now uses the Metadata extractor library.
This reduce the available website a bit for now, but is a lot easier to extend via python
in the future. This also adds the ability to download references for the selected publication
while importing them.
Amazon store: waaaay improved context view design
Currently prices for tracks in compilations and artist names in normal
albums are wrong, due to changes at Amazon. We are going to fix that
on the server side soonish.
implement runtime KSNI updates
previously kmix would throw away the KSNI and completely recreate it to
pick up mixer changes. incidentally enough doing that triggers repaints
and rescaling in plasma leading to utterly silly flickering. paritcularly
since pulseaudio stream changes (e.g. a track change in amarok) would
cause such an "update" you'd have a steady flow of flickering systray
the situation was resolved by introducing a MetaMixer in the DockWidget.
MetaMixer behaves like an abstraction wrapper around the actual Mixer. it
replicates the necessary interfaces/signals/slots and internally
controls the wiring to the actual mixer. that way the dockwidget can
connect() once to the metamixer signals while internally the mixer might
be constantly changing. then when an update is required the new update()
function is called, which calls reset() on the metamixer, which rewires
against the new master mixer and then automatically triggers UI updates
Amazon Store: Support adding items to the cart using amarok:// URLs
Now you can click on a URL like
and one of the best albums ever recorded is being put into your shopping
cart. This is going to be used in the info applet, hopefully soonish.
Btw, searching has also been available for some time now:
So script writers have something to play with. :-)
[ #15382 ] Rewrite DTMF handling, behavior is now consistent
There is 5 cases
1) There is no call, then create one
2) There is one or more call and the active call is also selected, then send DTMF to the active call
3) There is multiple call, but the active one is not selected, then create a new call or add to existing dialing call
4) There is only inactive calls, then create a new one or add to existing dialing call
5) There is only FAILURE, BUSY or UNKNOWN calls, then create a new one or add to existing dialing call
When adding to dialing call, select it to give user feedback of where the tone went.
Any other comportment need to be documented here or treated as a bug. This commit also strenghen client against daemon crashing.
Refactor to move counters from view to model.
The model emits signals when the number of items change, but it did not
provide get methods to know that number of items, so the view had to
keep its own counters and update them when the model emitted the
signals. Get methods were added to the model and the counters were
removed from the view.
In the builder make the arguments a string list
there's not really a point in creating them every time. Also this makes
it possible to store them sorted, so we can properly match functions.
(x,y)->... is the same type as (y,x)->...
Merge branch 'meta-observer-refactor'
Meta::Observer: observing no longer prevents destruction
Make Meta::Observer thread-safe
Meta::Observer: use a bit of templating to remove ~150 lines of code
Document Meta::Observer::subscribe() methods
CCing amarok-devel because this changes semantics of the core API
Unify message shown when the tests are completed.
Instead of using a specific message, add "Finished" or "Stopped" before
the "Ran X tests in Y seconds" message shown after finishing each test.
Moreover, the previous message of "All tests completed" could be
confusing, as it was used even when some tests were not selected.