Revision 948a97f...

Go back to digest for 4th November 2012

Bug Fixes in Development Tools

Milian Wolff committed changes in [kdevplatform] /:

Ensure that registerToolView returns the existing tool view if possible.

This partially reverts 9efeb310a84f48a5015599aa24d02cbe29aa16aa but the
changed hunk in registerToolView there does not look correct anyways.

New tests where added that try to assert the proper behavior.

Note: Constness of ToolViewData is now ensured for the OutputWidget.
This further shows that we should refactor out its views member and
move it to the stnadard output view.

Thanks to David Narváez for showing this broken behavior.

REVIEW: 107126

File Changes

Modified 7 files
  •   outputview/ioutputview.h
  •   plugins/standardoutputview/outputwidget.cpp
  •   plugins/standardoutputview/outputwidget.h
  •   plugins/standardoutputview/standardoutputview.cpp
  •   plugins/standardoutputview/toolviewdata.h
  •   plugins/standardoutputview/tests/standardoutputviewtest.cpp
  •   plugins/standardoutputview/tests/standardoutputviewtest.h
7 files changed in total