Issue 269

Fix Bug 291011: Clicking on a configuration error in the Build toolview does not bring you to the line in the CMakeLists.txt file.

REVIEW:108024

Fix double-rendering of text in "Solve" button of the problem navigation context.

Fix the text of "Solve: ..." button/menu in the problem navigation
context being rendered two times and overlaid.

Don't know whether not giving the text to style options will have any
nasty side-effects, but well... Problem navigation context is so far the
only user of the rich-text push buttons.

REVIEW: 108144

kde-projects: Support "catch-all" dependencies.

The most noticeable effect is probably that it should be damn near
impossible not to have automoc build first now, at least in comparison
to other kde-projects modules. It also should take care of the vast
majority of the code needed for bug 312324. Still needed is handling for
Qt/Qt5.


FIXED-IN:1.16

Invalidate outputpage if a target directory is not writable.

GeoDataPoint: Change GeoDataCoordinates inheritance to containment.

If you run into this, please be reminded of GeoDataPoint's purpose:
"Nevertheless GeoDataPoint shouldn't be used if you just want to store
3d coordinates of a point that doesn't need to be inherited from GeoDataGeometry
In that case use GeoDataCoordinates instead which has nearly the same features
and is much more light weight.
Please consider this especially if you expect to have a high
amount of points e.g. for line strings, linear rings and polygons."

Fixes bounding box calculation.

quick fix to make Marble's UI fit on netbook screens again

Marble's UI should fit on a netbook screen (minus e.g. the Plasma panel), even when Marble's status bar is visible.
To help achieve this goal, the following measures are applied to widgets that get wrapped in QDockWidgets:
* set minimum sizes of resizable widgets to zero (although not always respected)
* set margins to zero

Although this patch helps to preserve vertical space, more needs to be done for a real fix.
For instance, the RoutingWidget still consumes too much vertical space when via points are added, which has been a problem on Maemo for a while already.

Orbital Elements pixmap displaying were fixed in Satellites plug-in

Clenaup document size accessor/setter methods.

These methods are not needed and origin from ancient "design hacks"
where the visual graph representation took care for the data model
in the back.

OpenDesktop Plugin was migrated to the usage of MapInfoDialog

+ Code from Weather Plugin was fixed a bit

REVIEW: 108130

Prevent a memory leak that can occur after switching
to the next/previous video. For details see:
https://git.reviewboard.kde.org/r/108070/

REVIEW: 108070

Read pattern history before writing the new values.

The pattern history will not be saved correctly when the AdvancedRename tool is used, but the pattern history in the BQM is not updated.
Therefore closing digiKam will result in an empty pattern history in the config file because the BQM is the last instance that will be destroyed when closing the main application.

This does not fix the problem described in this bugreport, but it is somehow related.

Fix crash when a movie view is deleted

When a view is being deleted we do not want to receive signals from it
anymore, so disconnect it from us.


FIXED-IN: 4.10.0

Fix for bug 306013 - Gwenview crash when updating folder-tree in
the sidebar

Thanks to Ilya Basin for helping to fix this.


REVIEW: 108042
FIXED-IN: 4.10.0

Fix usage of cache.

Patch by Dave Vasilevsky.

Check if the map contains the session.

Nepomuk FolderSelectionModel: Improve checked state

Mark certain folders as PartiallyChecked. We now use the following
criteria -

* Qt::Checked - When the directory and all its subdirectories are
included
* Qt::PartiallyChecked - When a directory is included but its
sub-directories contain an excluded directory
* Qt::Unchecked - When a directory is excluded


FIXED-IN: 4.10

kio_sftp: Use proper boundary when queueing requests.

This fixes an off-by-one error when deciding whether the sftp_get code
path needs to make another request or not. This appears to be involved
in a data corruption bug (bug 312320) where file sizes that are a
multiple of the request buffer size (60*1024) end up getting an extra
full buffer of gibberish appended. E.g. a 61440-size file gets
downloaded to a 122880-sized file.

The bug report and proposed fix were both provided by Peter Klotz. I do
not yet understand at this point why this off-by-one error would cause
the extra packet to be appended, but I can confirm that the fix works.
It's at least easy enough to prove that a valid offset will not be == to
the file size (compare with the test on line 1151, for instance), and I
can confirm the fix seems to work.

It still doesn't make sense to me that the bug would be here though;
reading from an sftp channel that's already at EOF just returns 0 bytes,
and our code appears to handle that condition properly. In fact, the
check that is being corrected happens only *after* unconditionally
queueing up a first request packet, so you'd think the second EOF
response wouldn't even be an issue. Yet here we are.


FIXED-IN:4.10

kio_sftp: Disable parallel fetching as it is unsafe.

In code review of libssh while reviewing for bug 312320 I noticed that
attempting to download a file faster by having multiple concurrent
requests can be problematic.

The issue is that these async requests are done in two parts, sharing
the sftp_file struct between them.

When a request is first sent to the server (by sftp_async_read_begin),
the libssh code examines the first parameter (a sftp_file) to determine
what offset to start reading from in the request to the server, while
our code provides the *expected* length. Immediately after the request
is prepared and sent, the libssh code updates the sftp_file's offset to
provisionally include the length of the expected response.

When the response does arrive and is read by application code (in
sftp_async_read()), the libssh code is smart enough to correct the
sftp_file's offset if the actual data length received wasn't the same as
that which was expected. So as long as sftp_async_read_begin is
immediately followed by sftp_async_read there is no issue (and this is
how those functions are used in the libssh example code on their
website at http://api.libssh.org/stable/libssh_tutor_sftp.html)

However, if you start a sequence of sftp_async_read_begin()'s (and we
do, in ::enqueueChunks()), the offset for the second and following of
those functions are based on the *provisional* offset length, which can
be adjusted by the first sftp_async_read(). If this adjustment is made
we will likely corrupt data on download.

So, my quick-and-dirty fix is to disable concurrent fetching by limiting
to one sftp_async_read_begin/sftp_async_read pair at a time for now (so
as to avoid getting too invasive with the code). This probably needs to
be rewritten in the future however, either with a plain synchronous
function (and let the library do it right) or with proper tracking of
<offset,length> tuples for each request to make sure there are no
collisions or gaps in the resultant file.

Make sure that in simpleOutput() case the output is enabled

Unplugging external monitor while laptop lid is closed
causes no outputs to be enabled, not even after opening
the lid, so make sure that the embedded output is always
enabled.


REVIEW: 108062

WidgetFactory: Properly handle multiple file tagging

When multiple files have been selected then setProperty should not be
used, as the tag widget will only show the common tags, and changing
that list of common tags will result in the not-common tags being
removed.

Instead, we use addProperty to add the changed tags. This way the old
tags are preserved. Additionally, we maintain a list of the previous
tags, and calculate the difference to remove the previous tags.


FIXED-IN: 4.11

Handle spurious instances of the prompt

Sometimes, even in MI mode, GDB spits out "(gdb) " at unexpected times,
seemingly as an adjunct to OOB messages (and thus presumably intended
for human consumption). So, now we check that we have seen a result
record before accepting the prompt.

All cli.py tests now pass!

FileWatch: Do not add watches for system links

Following system links can lead to various infinite cycles, which is
something we do not ever want.

I'm not sure if there is any advantage gained by adding watches to them?


REVIEW: 108025

Revert "Disable powerdevil and screensaver for pvr"

Thanks to Ruediger Gad for his x11-resume-hack package.
By this we can enable the screensaver and suspend for archos gen9 pvr
again.

This reverts commit 6cbd7cb2716b700f257ae0b8530bf7ae9f635899.

Check if the reply is an error before using the value.

Fix Kross apidocs links

Doxygen was not finding the referenced apidox parts because they were
not proper pages (or contained in pages).

They are now all in Mainpage.dox.

Fix crash when browsing bluetooth device.

When trying to browse a N900 it crashed here because pathA was empty. Which
lead to index = maxIndex beeing -1 and pathA.at(index) crashing.

Reorder the while condition to prevent that courtesy of tsdgeos.

RemovableMediaCache: Thread safety++

Make sure to always lock the mutex when accesing m_metadataCache

Initialize datetime of tags in tags:// protocol

REVIEW: 107910

FileIndexer: Proper user status strings

The old indexer used to actually follow a directory based indexing
scheme, where at any time you would know which directory it was
indexing. This new one doesn't exactly follow that scheme, plus with the
2 queues, it makes reporting that information harder.

Therefore, I've changed the way the userStatusStrings are reported. This
new method provides less information, but at least it is accurate.

Fix Bug 285167 - Ability to disable "Save to Sent Mail Folder" feature

FIXED-IN: 4.11

Delete the temporary file after 10 seconds after opening the attachment

"cor3ntin" on #qt claims that Thunderbird deletes the temporary files after a
couple of seconds. This code works for me on X11.

Do not set inheritFromParent = true for collections

Setting this overrides everything else, we'll also need to manually apply the
archiving and fetch settings from the feedpropertiesattribute to the cache policies,
otherwise the hierarchical logic won't work correctly.

Fix Bug 312492 - kmail freezes when trying to send a message from

dolphin

Be sure that we select files.
Otherwise it will try to add all home in attachement.
=> with this fix we will be sure that it's a file and will not freeze
all kde

For folder I will implement it in 4.11 we need to add a dialogbox to
confirm it etc.

FIXED-IN: 4.10

Apply patch from Torsten Grote

"Currently, the AttachmentMissingWarning at the bottom of the compose
window is only closed when attaching a file with its own button, but not
when attaching files by other means. I made showAddAttachmentDialog()
emit a fileAttached() signal which in turn deactivates the warning.
Maybe there is a better place to emit this signal e.g. when a file has
successfully been attached."

REVIEW: 107916

handle the case were you get an invitation but you are not listed
as an attendee. so you don't get the opportunity to respond, but you
get the opportunity to add to your calendar, or delegate or forward.

: Banks widgets at the dashboard show wrong values

Don't crash when creating a new flipbook

The crash would happen when creating a new flipbook while there was
no current flipbook open, but only if there was an open image.

Have ok/cancel/etc. buttons consistently at the bottom in dialogs, not the right side

REVIEW: 108066

Thanks jarosław and inge for review

Remove default paragraph style from user visible lists.

The default paragraph style was seen in user visible lists (as blank
item). This style is not supposed to be user visible/selectable.

Time to implement a fix for an old bug

Happy new year

Fix bug 312611.

Fixing this involves two parts
1) Fixing the dynamic_cast for KoTextBlockData(continuation from my previous commit)
2) Fixing the styleChanged signal that was not being emitted on check/uncheck of "Restart List Numbering" checkbox

Fix sorting of style names.

The style names were not sorted in natural order.
Use KStringHandler::naturalCompare to fix the problem.

The sorting of styles per category (ie. list styles,...) belongs to
a wish item, and needs debating first.

REVIEW: 108020

Change the way we draw markings of speeling errors. Instead of using the qt way we draw it ourselves.
This has the following benefits:
- we don't have to relayout after finding spelling errors
- we can have more than one type of marking (spelling, grammar, etc)

This commit also changes the way we ask for spellchecking to be performed. The old way had some
shortcommings that could lead to text not being checked at all

Fix cannot pause near end of clip with SDL

Fix a small memory leak
CC

AudioCdCollection: refactor initialization, trackForUrl() + cleanups

Might also fix bug 279485, please test.

BUGFIXES:
* Audio CD: fix track recreation on startup.



FIXED-IN: 2.7

BrowserBreadcrumbItem: treat folder names with & in them accordingly


FIXED-IN: 2.7

BrowserBreadcrumbWidget, ElidingButton: fix lay-outing issues wrt minimumSize

BUGFIXES:
* Fix Media Sources pane growing in size when navigating in it. (BR )
* Fix Media Sources breadcrumb items sometimes appearing as new windows. (BR )



FIXED-IN: 2.7

BrowserCategory: (hopefully) definitely fix crash bug 265626

The cause is in the code comments.


FIXED-IN: 2.7
CCMAIL: Ian Monroe

Select all should not select items in locked tracks: http://kdenlive.org/mantis/view.php?id=2917

QtGroupingProxy: implement buddy() to work-around design issues

This is effectively a work-around for a big design flaw in
QtGroupingProxy (which is that it "invents" its own items not present
in the original model). Technical description in the code comments.

^^^^ Bart, because of the above reason I'd prefer not to use
QtGroupingProxy in Amarok at all in long-term. Instead, we should do it
the other way around: original model would be hierarchical and the
proxy would flatten it into a table.

This fixes some bugs in the Saved Playlists and perhaps more:

BUGFIXES:
* Fix editability and drop-ability of playlist folders.


CCMAIL: Bart Cerneels

Quote file names when exporting openvpn configuration file in case they contain
white spaces in their file names.


FIXED-IN: 0.9.0.7

Ignore connections with empty settings.


FIXED-IN: 0.9.0.7

Restore rekonq 1.x shortcuts

ALT + #number to change tabs
CTRL + #number to load favorites

properly synchronize connection history

cleanup some vnc stuff which might also fixes crashes

Backport:
SVN commit 1330194 by uwolfer:

fix crashes releated to open a new connection while another connection is still in process

, 296525, 225694, 242586
FIXED-IN: 4.10

- Fix insufficiant if mounting of a share is already running.
- Fix crash bug in Smb4KMounter::slotAuthError(). Smb4KMOuntJOb sent the
authError() signal while it was processing the mounted shares and not
after it finished with that. This led to invalid data at some point and
made the application crash.
- Added Smb4KPasswordDialog class.
- Rewrote Smb4KWalletManager::showPasswordDialog() function.

Use comparison with localized string

Change Plasma::PushButton to Plasma::IconWidget to workaround visual glitch.


FIXED-IN: 0.9.0.7

Don't show incorrect presence while everything is loading

Now it shows an empty combobox with the spinner spinning on it
before GlobalPresence is ready (then it changes the combo to
proper index).

Reviewed-by: David Edmundson

FIXED-IN: 0.5.3

load the images for the themes correctly

REVIEW: 106680

FIXED: [ 309119 ] Wrong "New directory" dialog behavior: can't clear all typed text
return QValidator::Intermediate instead of Invalid when input is empty

Temporary fix for ignoring paths, thanks to Stefan Majewsky for the patch.

Fix random crashes with script providers

Synchronous network requests could not be aborted,
now they can, using abortSynchronousRequests().
Network::hasRunningRequests() now also returns true if a
synchronous request is running and runningRequestCount()
adds running synchronous requests.

Abort synchronous requests in Network destructor.

Fix Bug 312500 - kmail can't set always expand groups

FIXED-IN: 4.10

Fix crash when saving configuration with a disabled output

REVIEW: 108031

KML tag writers for ground and photo overlay, polygon and time span.

REVIEW: 107972

Custom map theme view item delegate.

Shows map theme icon overlayed with favorite indicator, and map theme
name and description to the right.

- More constellation lines (Norma, Musca, etc.)

Toolbar for the routing widget has been created

REVIEW: 108083

Config Dialog for the Photo Dialog: number of items and licenses

REVIEW: 108009

Greatly expanded configuration dialog for stars plugin.

GeoData: trigger visibility of documents from the theme legend

For this purpose, a property attribute is brought in the following:
- GeoSceneGeoData (aka geodata layer)
- FileManager and FileLoader
- GeoDataDocument
Then MarbleModel reacts to mapTheme settings signals and toggles
GeoDataDocument visibility.
The property name is generic and simply needs to be coordinated in
the dgml file in the following sections:
- <layer><geodata property="rivers">
- <settings><property name="rivers">
- <legend><section checkable="true" connect="rivers">

New default view

Nations were migrated to the usage of MapInfoDialog

REVIEW: 108111

Show paper size names like "ISO/DIN A4" instead of just paper size in numbers

REVIEW: 107350

GUI to configure the Text/Graphics Anti-alias and Text hinting


REVIEW: 106660
GUI:

Support for new decoration border sizes BorderNoSides and BorderNone

BorderNoSides is what is known from Oxygen as "No Side Borders". The name
should indicate that there is only a border at the bottom. BorderNone is
a mode with no borders at all.

The new enums are added to KDecoration and the KCM so that all decos can
make use of it.

Aurorae is adjusted to support the new sizes for QML themes (it breaks
the old svg based themes) and Plastik makes use of it, by rendering a
one-pixel border around the window, which illustrates that it's still up
to the decoration to decide how to make use of the setting.

REVIEW: 108164

move the position property in the page

makes the scroll animation work with the page and not the parent, trying to avoid crashes

Merge branch 'package'

REVIEW: 107900

Connect up real GDB invocation

1. Replace the default invocation of GDB with a real one.
2. Further tighten error reporting.

The result is we can now launch and run a real program!

FileMetadataProvider: Improve data merging when provided with multiple resources

For all the resources, each property is compared with the other
resources and the least common denomiator is shown to the user.

Eg - If the album is common to all the resources, it will be shown. For
resources which have been tagged, only the tags which are present in all
the resources will be shown.

Remember and show the time information of the crashed application


REVIEW: 107775
FIXED-IN: 4.11.0

Nepomuk KCM: Show symlinks in "Customize Folders" as disabled items

Nepomuk currently does not follow symlinks when indexing. When marking
folders to be indexed in the KCM ("Indexing" tab, "Customize Folders"
button), the user now sees the symbolic links are there, but is not
allowed to mark one for indexing, nor its children. Symbolic links
were hidden before this.


REVIEW: 108056

Show statusbar progress widget when syncing collections

Allow to attach folder. But ask if it's not an error. so we know

what we will attach.
For example it will avoid to attach $HOME :)

Implement line smoothing in Krita

REVIEW:108049

Change the way we draw markings of speeling errors. Instead of using the qt way we draw it ourselves.
This has the following benefits:
- we don't have to relayout after finding spelling errors
- we can have more than one type of marking (spelling, grammar, etc)

This commit also changes the way we ask for spellchecking to be performed. The old way had some
shortcommings that could lead to text not being checked at all

feature: New option for import to "Import only operations since the last imported one"

Activate Lanczos3 filter

After fixing maths in the KisTransformWorker it works perfectly.

Draw the line to the last cursor position when using weighted smoothing

However, the last bit isn't drawns with weighted smoothing.

Connected the new implementation of the transformations to KisTransformWorker

Some highlights:
1) The new implementation gives much better transformation quality,
because it calculates correct offsets inside the pixel. The comparison
of the images can be found on page [0]
2) The rotation is now 2-pass instead of 3-pass it used before. There is
almost no difference in quality (I'm not sure that initially the third
pass was introduced for quality reasons). This speeds up the rotation
by 40%.
3) Some fast-path optimizations are done for the pure shear operations,
which make up to two times better performance.
4) Implemented a simple wrapper for the progress updates
(ProgressUpdateHelper)


[0] - http://krita.org/item/126-focus-on-transformations

add QML export

Filter config page for motion blur filter

Config page for oil paint filter

TagHelper: provide meaningful default implementation of render()

render() is used to calculate unique id of a track that doesn't have it
embedded. Providing default implementation means that track metadata of
more obscure formats (MP4, ASF) will have the metadata contained in
the unique id hash in addition to file size and first 16 KB of a file.

This can change hashes of existing files, but thanks to recent fixes,
Amarok can cope with it and update them as needed. (even in playlists)

Rewrite screen capture to use FFmpeg instead of recordMyDesktop, fixes many issues like:

Make it easier to save render scripts with custom names: http://www.kdenlive.org/mantis/view.php?id=2913

Add kded-appmenu support, first attempt

To test this:
$ git clone git://anongit.kde.org/rekonq
$ cd rekonq
$ git checkout kded-appmenu-support
$ mkdir build
$ cd build
$ cmake..
$ make
and see... Please, help me to test this if you wanna support for this

Add action to reset the auto-detected bibliography back end

The auto-detected back end is also reset now when the user selects a back end
manually.

Patch by Eugene Shalygin.

Make it possible to every backend to install its own categories

This way we don't have a huge categories file with everything mixed but
each backend telling how to organize its own data.

Distinguish stop names from IDs in the engine

Let the engine know whether it gets a stop name or an ID in requests
by adding a "stopid" data source parameter for stop IDs (previously
IDs were simply given as "stop"). Scripts still get the stop name or ID
in values.stop, but a boolean values.stopIsId was added. For journeys
values.originStopIsId and values.targetStopIsId were added.

Existing providers work like before, but can now use this information.
Done for HAFAS script providers to build better URLs and for GTFS
providers to not unnecessarily try to query the database for the ID.

Use new stop ID parameters in the applet where possible.

Update documentation accordingly.

Accept application/x-source-rpm mimetype

REVIEW: 108187

Always use our own implementation of file system clobbering.

Make it possible to find categories

Add a method to the CategoryModel that will tell us what category matches
a said name.

Update item access time less often.

Making this fully correct is tricky (starting with "correctness" not being
easy to define for all corner cases such as arbitrarily changing cache
policies), and slow.

So, instead just improve the approximation slightly for now. So far we
updated the access time on each access asking for any kind of payload.
This included for example mail folder listings. Which is slow and avoids
cache expunging for anything in folders you opened recently. Instead, just
update the atime for full payload requests.

This makes cache expunging for online accounts actually behave like one
would expect, and it improves folder listing performance, especially under
high I/O load.

Handle inline math formulas in the epub filter.

This is part 2 of the MathML-in-epub implementation.

DirectoryLoader: load tracks asyncly in a background thread

Also, load playlists even in subdirectories.

CHANGES:
* Make dropping large directories into playlist more responsive by reading
track metadata asynchronously in a background thread.

DIGEST: Amarok is now more responsive loading large directory
structures into playlist

Native menus support for Android

Several EBN Krazy fixes

Fixing various issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Mohammed Nafees, completing
a Google Code-in task.


REVIEW: 108166
DIGEST: Google Code-in contribution

Poles and Shipwreck were migrated to MapInfoDialog + minor fixes

REVIEW: 108109

- Add lots of icons to the menus. Fix routing icon in KDE settings dialog.

Icons have been added to the plugin setting dialog

REVIEW: 108073

Several EBN Krazy fixes

Fixing various issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Kyle Morris, completing
a Google Code-in task.


REVIEW: 108069
DIGEST: Google Code-in contribution

Home button artwork

A +- -- src/plugins/render/navigation/data/navigational_homebutton.png
A +- -- src/plugins/render/navigation/data/navigational_homebutton_hover.png
A +- -- src/plugins/render/navigation/data/navigational_homebutton_press.png

Several EBN Krazy fixes

Fixing various issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Mayank Madan, completing
a Google Code-in task.


REVIEW: 108048
DIGEST: Google Code-in contribution

Several EBN Krazy fixes

Fixing various issues found by the EnglishBreakfastNetwork's
code checker Krazy.

Submitted by Mayank Madan, completing
a Google Code-in task.


REVIEW: 108052
DIGEST: Google Code-in contribution

- Icons for all render plugins

A +- -- src/icons/addressbook-details.png
A +- -- src/icons/applications-internet.png
A +- -- src/icons/atmosphere.png
A +- -- src/icons/coordinate.png
A +- -- src/icons/directions-from.png
A +- -- src/icons/measure.png
A +- -- src/icons/positionmarker.png
A +- -- src/icons/stars.png

Removed the encryption feature

Removed components
- Encryption jobs
- UI plugins and UI system

Use KSystemEventFilter instead of QAbstractEventDispatcher

Using QAbstractEventDispatcher bypasses other filters installed
by KSystemEventFilter and breaks others who used KSystemEventFilter
to install their event handlers.


REVIEW: 108065

Ignores state changes for unknown activities

Patch by Thomas Luebking

FDO "Keywords" entry use semicolon as separator

Several compiler warningy fixes

Submitted by Mohammed Nafees, completing
a Google Code-in task.


REVIEW: 108036
DIGEST: Google Code-in contribution

FileView, FileBrowser: rework of keyboard, mouse & context menu behaviour

Also, some minor fixes to enable smooth keyboard navigation are done

CHANGES:
* Harmonize keyboard, mouse and context menu behaviour of the Files pane
so that it matches Local Music and Saved Playlists panes.


FIXED-IN: 2.7