Issue 274

10th February 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Jürgen Appel
Aleix Pol

This Week...

KDE Telepathy fixes having a notification "a new contact has added you" even when you are offline, adds .desktop-based tubes channel approver. Nepomuk changed DBus interface to the FileIndexer for status messages. Improvements in kscreen API. Calligra changes as to when config ui are in a docker and when it is in a tool. Work on new dashboard in Skrooge. Amarok optimizes dynamic playlist generation.

Statistics

Commits 2992 by 187 developers
Open Bugs 21220
Open Wishes 15817
Bugs Opened 440 in the last 7 days
Bugs Closed 390 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
344
 
/branches/stable
225
 
/trunk/l10n-support
59
 
/trunk/www
57
 
/project/reports
25
 
/repo-configs/email
20
 
/trunk/KDE
17
 
/applets/folderview
15
 
/trunk/kde-common
12
 
/tags/KDE
11
 
Files Developer Commits
477
 
Chetan Khona
159
 
300
 
Laurent Montel
117
 
282
 
Roman Paholík
94
 
216
 
Gilles Caulier
75
 
207
 
Marco Martin
70
 
138
 
Alexander Neundorf
46
 
120
 
Marco Nelles
41
 
114
 
Burkhard Lück
38
 
108
 
Chusslove Illich
36
 
96
 
Albert Astals Cid
34
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Ukrainian (uk)
100%
 
Estonian (et)
99%
 
Swedish (sv)
99%
 
Polish (pl)
98%
 
Spanish (es)
97%
 
German (de)
96%
 
Dutch (nl)
96%
 
French (fr)
95%
 
Galician (gl)
92%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
43
 
Thomas Lübking
20
 
Christoph Feck
19
 
David Solbach
18
 
Gilles Caulier
18
 
Ben Cooksley
18
 
Martin Gräßlin
13
 
kollix aon at
12
 
Myriam Schweingruber
10
 
ralf-engels gmx de
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]   []   

Educational

[] []    

Graphics

[]     

KDE Base

[] [] []   []

KDE-PIM

[] []    []

Office

[] []    []

Konqueror

     

Multimedia

[]   []   

Networking Tools

[] []    

User Interface

     

Utilities

[] []    

Games

     

Other

     

There are 55 selections this week

Bug Fixes

Development Tools

Alexander Richardson committed changes in /branches/KDE/4.10/kdesdk/okteta/kasten/controllers/view/structures/parsers/osdparser.cpp:

structures: fix null pointer dereference

Alexander Richardson committed changes in /trunk/KDE/kdesdk/okteta:

structures: (probably) make it work on big-endian systems

Note that I have no machine to test this.
If the unit test structures-all-primitive-types passes it works.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1338871
Kevin Funk committed changes in [kdevplatform/1.5] /:

Fix parenting in BuilderJob::addSubjob()

Fixes a bug in kdelibs, which is fixed in KDE 4.11.
At this point we can easily work-around this issue.
See cc'ed bug for explanation(s).

This fixes a crash-on-exit with a build running.

REVIEW: 108848

Educational

Bernhard Beschow committed changes in [marble] /plugins/runner/local-osm-search:

create a unique database object for each runner

* fixes crash when another database query is started while an old one is still running

REVIEW: 108842

Diffs: 1, 2, 3, 4, 5, 6 Revision 90ab8a7...

Graphics

Ananta Palani committed changes in [digikam] digikam/album/albumwatch.cpp:

Fix thumbnails not shown in Windows and excessive use of virtual memory / handles which may cause crashes and other unexpected behavior by removing file monitoring and only monitoring directories for changes. These problems might still occur with very large numbers of folders but could not be confirmed. However, medium to large collections should no longer cause a problem.











FIXED-IN: 3.0.0

KDE Base

Gerald Senarclens de Grancy committed changes in [kate] /indent/python:

created additional tests for Python indentation

Albert Astals Cid committed changes in [kdelibs/KDE/4.10] /:

Fix two bugs in kcolorbutton+tests

Selecting+cancel does not really cancel
Selecting in recent colors crashes
REVIEW: 108637

FIXED-IN: 4.10.1

Thomas Lübking committed changes in [kde-workspace] kwin/layers.cpp:

fix restacking ... code

- don't cast Window's to pointers for no apparent reason
bug introduced with ac0f8bfb24403168199027a77bba0107bc6d42e1
- no stupid java style iterators, we've stl everywhere
- postfix in a for loop is a bug. period. ;-)


REVIEW: 108864
FIXE-IN: 4.10.1

Dan Vratil committed changes in [kscreen] kcm/qml/Output.qml:

Fix snapping

Thanks to Stefan Hepp for pointing out the broken code.



FIXED-IN: 0.0.72

Frank Sebastian Roscher committed changes in [kde-workspace/KDE/4.10] khotkeys/libkhotkeysprivate/conditions/conditions_list_base.cpp:

Fix KHotkeys crash when using condition lists with several conditions.


FIXED-IN: 4.10.1

Lukáš Tinkl committed changes in [kde-workspace/KDE/4.10] /generic:

fix wrong description and size for 2-stage USB storage devices

with review and help from Dan Vratil and
Jan Grulich, tested on their N9 and SG III,
respectively :)

Diffs: 1, 2, 3 Revision b4096a2...
Dawit Alemayehu committed changes in [kdelibs/KDE/4.10] /misc/kpac:

Fixed both DHCP and DNS based PAC/PAD lookup.

The DHCP based lookup was completely broken while DNS based lookup only
worked if the domain name of your machine contained at least one '.'


FIXED-IN: 4.10.1

David Faure committed changes in [kdelibs/KDE/4.10] kio/kio/kmimetypechooser.cpp:
Alex Fiestas committed changes in [kscreen] kded/serializer.cpp:

Check if the EDID is valid before using it

In the XRandR backend we are always returning an EDID object but it can
be invalid.

KDE-PIM

Andrea Scarpino committed changes in [ktp-auth-handler] tls-cert-verifier-op.cpp:

Fixed wrong compare causing segfault

Andras Mantia committed changes in [kdepim-runtime] /maildir:

Fix caching: Collection.id is not always available and valid when maildirForCollection is called. Thanks for Guy Maurel who found the bug.


REVIEW: 108755

Christian Mollekopf committed changes in [kdepim/KDE/4.10] libkdepim/addresseelineedit.cpp:

Fix displaying of contacts found in the addressbook.

completion->allMatches doesn't provide all the necessary search results resulting in at least some cases in some search results not being displayed.
completions->substringCompletion on the other hand always provides the right results.
I'm not sure why the code is that complex (not sure what problem it's trying to solve), nor if anything else breaks with that change, but I don't think so.

Office

Sven Langkamp committed changes in [calligra] /part/dockers:
Stephane Mankowski committed changes in [skrooge/Feature] /:

: Skrooge crashed after double clicking on an account after using clean import tool

Friedrich W. H. Kossebau committed changes in [calligra] /plugins/filters/blur:

fix possibly broken rect size calculation in Krita blur filters (minus on unsigned int gives complement)

REVIEW: 108708

thanks boud for review

Diffs: 1, 2, 3 Revision 64408ec...
Pino Toscano committed changes in [alkimia] /:

tests: convert most of QVERIFY(a == b) as QCOMPARE(a, b)

this way, if the check fails both actual and expected values are printed;
also reorder in few cases the arguments to have first actual and then expected value

Diffs: 1, 2, 3 Revision 8982bde...

Multimedia

Ralf Engels committed changes in [amarok] /:

Fix Removing all items from a filtered list doesn't display warning

Remove the special warning label widget in the ProgressiveSearchWidget.
Widgets that are dynamically hidden and shown wreck havoc with layouts.
Instead the PrettyListView displays a label in cases it's completely
empty.


FIXED-IN: 2.8

Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Fix possible crash on track deletion: http://kdenlive.org/mantis/view.php?id=2967

Sudhendu Kumar committed changes in [plasma-mediacenter] /:

Map the current index to playlist model's actual index.

Jean-Baptiste Mardelle committed changes in [kdenlive] /:

Fix timeline seek sometimes not refreshing on last frame of the seek, small update for monitor ruler colors

Diffs: 1, 2, 3, 4 Revision e358551...
Ralf Engels committed changes in [amarok] src/playlist/proxymodels/GroupingProxy.cpp:

Group by directory don't work in main playlist

It was just not implemented and had a FIXME comment.


FIXED-IN: 2.8

Networking Tools

David Edmundson committed changes in [ktp-kded-module] /:

When offline, hide the "add contact status notifier item"

REVIEW: 108846

FIXED-IN: 0.6

DIGEST: Fixes having a notification "a new contact has added you" even when you are offline.

Sebastian Sauer committed changes in /trunk/extragear/network/kmldonkey:

Fixed last show-stopper bug for the Android version.

See also https://bugs.kde.org/show_bug.cgi?id=307443

Diffs: 1, 2, 3, 4, 5, 6 Revision 1338886

Utilities

Andrius Štikonas committed changes in /trunk/extragear/sysadmin/partitionmanager/src:

Fix detection of partitions' paths.

Previously, partition number was added to device path.
However, there are devices with more complicated numbering scheme,
e.g. memory cards may have /dev/mmcblk0p1.
It seems that the easiest way to handle this is to use partition
path instead of device path + partition number .

Jan Lepper committed changes in [krusader] /:

FIXED: [ 217711 ] directory chooser dialog does not allow to choose a directory

REVIEW: 107308

set url requester mode to KFile::Directoy in the KChoseDir::getFile() methods
add KChooseDir::getFile() for the cases where callers expect a file
more copy & paste - this will be cleaned up in krusader-next

Features

Educational

Andreas Cord-Landwehr committed changes in [artikulate] /:

Add course creation dialog.

Internal dialog logic is yet missing.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision adc75db...

KDE Base

Aleix Pol Gonzalez committed changes in [kde-workspace/KDE/4.10] ksmserver/themes/default/main.qml:

Improve the KSMServer integration with non-default themes

This patch fixes a problem that appeared when the Shutdown dialog
was displayed and the theme didn't offer the moon image (such as Caledonia).
This patch fixes this by properly anchoring the text item that says
Shutting down in X seconds".

REVIEW: 108797

Martin Gräßlin committed changes in [kde-workspace] /:

Port Client's decoration resize extend input window to XCB

Using Xcb::Window to manage the xcb_window_t and simplify the code - no
longer need to check whether the input_window is valid before calling e.g.
map, as that's handled in Xcb::Window.

One XLib usage for setting cursor is still present. This will be ported
once all the QCursor::handle() get removed.

REVIEW: 108771

Diffs: 1, 2, 3, 4 Revision 8dc1d43...
Alex Fiestas committed changes in [libkscreen] /:

Fallback to the biggestMode when no preferredMode is given

Brokens screens that provide no EDID will fail to indicate their
preferredModeId.

Since this is a problem common on all platforms (it does not matter if
we use wayland, xorg, quartz or framebuffer you will still have screens
with no EDID) the right place to solve this is in the abstraction.

Diffs: 1, 2, 3 Revision c664e69...
Dan Vratil committed changes in [libkscreen] /:

Introduce new comfortable methods and an API break

- add KScreen::Output::isHorizontal() method that returns TRUE when
output is not rotated or is upside down

- rename KScreen::Output::currentMode property and respective methods
to currentModeId (because they actually return the ID, not the
KScreen::Mode)

- add KScreen::Output::currentMode() method that returns current
KScreen::Mode*

- rename KScreen::Output::preferredMode() to preferredModeId()

- add KScreen::Output::preferredMode() method that actually
returns KScreen::Mode*

- fix versioning and soname

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision d0ea4ff...
Jörg Ehrichs committed changes in [nepomuk-core] /:

Change dbus interface to the FileIndexer for status messages

To have a unified dbus interface this patch adds the signal:
* statusMessage(int, string)
and the method:
* statusMessage
* currentStatus

To expose the current state of the fileindexer via dbus.
This change results in the same dbus signal/slot that are used by
akonadi_nepomuk and the FileWatcher.

The integers for the status are the fixed enum values of the Nepomuk2::IndexScheduler::Status
State_Normal = 0,
State_UserIdle = 1,
State_OnBattery = 2,
State_LowDiskSpace = 3,
State_Suspended = 4,
State_Cleaning = 5

Therefore the following method s are marked deprecated:
* userStatusString - bad naming, same as statusMessage
* simpleUserStatusString - not used/returns the same as userStatusString

REVIEW: 108811

Diffs: 1, 2, 3, 4, 5 Revision b42365a...
Thomas Lübking committed changes in [kde-workspace] kwin/geometry.cpp:

Permit maximization of windows with fixed position

A window can be "maximized" despite it's position is fixed.
Most obvioulsy for a corresponding of "0", but also in other
cases. The window can still be resized, some size is the
maximum one and there's no reason to prevent the shortcut of
this state.


REVIEW: 108789
FIXED-IN: 4.11

Valentin Rusu committed changes in [kwallet/ui-refactor] /manager:

First attempt to restore drag and drop

I return to ui refactoring after getting community and especially
agateau feedback

Vishesh Handa committed changes in [nepomuk-core/feature/mergeGraphs] /storage:

DMM: Resolve all the nodes before sending them forward

The resolveNode/Urls functions used to return a QHash which contain the
original -> resolvedNode. If it could not be resolved, then resolvedNode
would be blank.

With this patch, all the resolveNode/Url functions just return a list of
resolved nodes. If the node could not be resolved, it is then created at
that moment. It is created in the first graph that can be found
containing that application. This isn't correct according to the old
behaviour, but we just do not care about separate graphs any more.

This patch breaks a LOT of tests which I'm not going to fix right now.
When the entire graph based change have been done, then the tests can be
fixed. The current unit tests depend too strongly on the old graph
behavior.

KDE-PIM

Christophe Giboudeaux committed changes in [akonadi/1.9] server/src/storage/dbconfigmysql.cpp:

Ignore the custom settings in ~/.my.cnf
Looks like passing the socket path in our arguments is not enough for MySQL. It still tries to run the commands on any database defined in ~/.my.cnf.

We're now adding the --defaults-file argument to mysqladmin and mysqlcheck to only run these commands on the Akonadi DB.


FIXED-IN: 1.9.1

Dan Vratil committed changes in [ktp-approver] /:

.desktop-based tubes channel approver

Every application using tubes should now install a ,desktop
file to `kde4-config --prefix`/share/kde4/services/ktp.

Approver will pick the .desktop file on incoming tube, show
message and icon as specified in the file and 'Accept' and
'Reject' buttons.

REVIEW: 108780

Laurent Montel committed changes in [kdepim] /table:

Start to implement merge/split cell

Office

Stephane Mankowski committed changes in [skrooge/Feature] /:

feature: New dashboard (fast remove, fast add, fast move)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision e7b34c7...
C. Boemann committed changes in [calligra] /:

This patch makes a huge change as to when config ui are in a docker and when it is
in a tool.

This new way of working was discussed with several people. The config
widgets were part of the 8 hour akademy 2012 Calligra UI brainstorming. This commit
implements what was designed.

The needed config widgets when working with a particular tool are now made available as
tool option widgets, so the user now directly has what is needed and nothing more.

The following config widgets are new but in large part reimplement what was already there:
o Stroke config widget,
o Fill config widget,
o Shadow config widget,
o Opacity config widget.

The snap guide config widget has gone the opposite way and is now a docker.

This patch was co-written with: Jean-Nicolas Artaud
A big thank you, and also to Thomas Pfeiffer and Arjen Hiemstra for the ui discussions,
as well as numerous other people

REVIEW: 108569

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 28 more) Revision af0a527...
Stephane Mankowski committed changes in [skrooge/Feature] /:

feature: New dashboard

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 20 more) Revision 4e61183...

Networking Tools

Sebastian Sauer committed changes in /trunk/extragear/network/kmldonkey:

KMLDonkey 2.2.0 released.

This monster-commit includes:
* Port from MeGo Harmattan QML-components to pure QML components
* Build-targets for Android and Desktop

Known bugs:
* Search-queries not seem to proper work on Android cause Java garbage collector somehow removes some of our attached dyn-components.
* Some functionality is disabled yet. All major things proper work on both, desktop and Android :)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 93 more) Revision 1338630

Utilities

Aleix Pol Gonzalez committed changes in [muon/packagekit-resource] /backends/PackageKitBackend:

Add some first support for Appstream

This way we can start to list applications from the PackageKit backend,
instead of pretending that everything is not technical.

C +35 -33 libmuon/backends/PackageKitBackend/AppPackageKitResource.cpp [from: libmuon/backends/PackageKitBackend/PackageKitResource.h - 054% similarity]
C +12 -27 libmuon/backends/PackageKitBackend/AppPackageKitResource.h [from: libmuon/backends/PackageKitBackend/PackageKitResource.h - 058% similarity]

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 649d994...

Optimization

Development Tools

Sven Brauch committed changes in [kdevplatform] /:

Make the title of the "Import / open Project" dialog more obvious

For some users, it was not at all clear that they could simply
open any folder as a project. I have answered the question "how to
convert a folder with source files to a KDevelop project" like
twenty times now, here's an example:

KDE Base

Andriy Rysin committed changes in [kde-workspace/KDE/4.10] /keyboard:
Martin Gräßlin committed changes in [kde-workspace] /:

Move XRender based rendering of unstyled EffectFrame into scene_xrender

This follows how it is done for OpenGL where the renderRoundBox() got
dropped some time ago.

New implementation implements the box with round corners using xrender
directly instead of using a QPainter on a QPixmap.

Diffs: 1, 2, 3, 4 Revision 07f49af...

Multimedia

Ralf Engels committed changes in [amarok] /:

Update Dynamic playlist. Get rid of energy optimizing code

The dynamic playlist always used to optimize the generated tracks
by different ways.
However the new biases all have hard conditions. The user also
used to see it like this and was confused if a "pretty good" result
was generated.

The new algorithm will generate an empty list if the conditions
cannot be fullfilled





FIXED-IN: 2.8

Ralf Engels committed changes in [amarok] /dynamic:

Simplify dynamic playlist

Since we are no longer optimizing a playlist it's not longer needed
to create playlists in large batches.
Also the repopulate action was apparently never used.

This speeds up the playlist generation and get's rid of issues when
the buffer was not cleared.

Diffs: 1, 2, 3, 4 Revision aefc1c3...

Other

KDE Base

Martin Gräßlin committed changes in [kde-workspace] kwin/libkwineffects/kwineffects.h:

Increase KWIN_EFFECT_API_VERSION_MINOR

ABI change in new screen edge implementation

KDE-PIM

Martin Klapetek committed changes in [ktp-nepomuk-service] /:

Remove more unneeded stuff from the feeder

Since we have direct interface with Telepathy in KPeople,
we don't need most of the feeded things. Currently for contacts
we'll be feeding just Telepathy ID, alias, avatar and groups,
all the rest will come directly from Telepathy. Makes the feeder
ligher and faster too.

REVIEW: 108803

Diffs: 1, 2, 3, 4, 5, 6 Revision 9c3243d...

Office

C. Boemann committed changes in [calligra/stage-designtool2-boemann] /:

To avoid having the slide layout docker take up space when not needed this
patch morphs the "background tool" from KoPageApp into a "Slide design tool"
when used in Stage.

Stage adds an extra option widget which is just the contents of the slidelayout docker.
The docker is removed.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 98eda43...