Issue 281

31st March 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Jürgen Appel

This Week...

Kate improves the vim mode, including adding the Vim command bar. Amarok now recognizes Data CDs as collections; scripting interface has been enhanced with requested method. Python support in KDevelop adds identifier-similarity aware sorting of completion items. Kraft lets user select his/her own identity from address book in settings. Rekonq sees work on session management. Work on threading in Calligra Coffice to improve interface response time.

Statistics

Commits 2684 by 171 developers
Open Bugs 21256
Open Wishes 15886
Bugs Opened 313 in the last 7 days
Bugs Closed 306 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
198
 
/branches/stable
137
 
/trunk/l10n-support
45
 
/trunk/www
25
 
/plugins/pate
20
 
/applet/declarative
14
 
/libksieve/ksieveui
14
 
/KTp/Models
12
 
/kate/plugins
11
 
/part/view
11
 
Files Developer Commits
378
 
Laurent Montel
139
 
192
 
Christoph Cullmann
69
 
189
 
Jan Grulich
68
 
180
 
Alex Fiestas
60
 
141
 
Ingo Malchow
49
 
69
 
Bernd Buschinski
49
 
132
 
Boudewijn Rempt
48
 
144
 
Chetan Khona
48
 
117
 
Sairan Kikkarin
39
 
99
 
Aleix Pol Gonzalez
34
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
99%
 
Polish (pl)
97%
 
Dutch (nl)
97%
 
Spanish (es)
97%
 
Estonian (et)
97%
 
German (de)
96%
 
French (fr)
96%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
50
 
Boudewijn Rempt
29
 
Martin Bříza
22
 
Myriam Schweingruber
16
 
Julian Seward
12
 
Laurent Montel
12
 
Sandro Knauß
10
 
Thomas Pfeiffer
8
 
Martin Gräßlin
7
 
Andras Mantia
7
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[] []    []

Graphics

  [] []   []

KDE Base

[] [] []   

KDE-PIM

[] []    

Office

[] [] []   

Konqueror

     

Multimedia

  []    

Networking Tools

[] []    

User Interface

     

Utilities

     []

Games

     

Other

     

There are 46 selections this week

Bug Fixes

Development Tools

Olivier Jean de Gaalon committed changes in [kdevelop] /cpp:

Fix a bunch of stuff that I don't want milian to ask me to write tests for...
Fix the way best matches are calculated. Used to be really kludgy and ugly.
Fix constructor initializer completion (that whole constructor initializer completion handling needs to be redone to integrate better with the rest of completion)
Put special enum completion items in their own group, and have them show up in return access. (this means you can browse the whole list easily, and not only a max of 5 best matches)
More match types for binary operators, some other stuff.
Memo to me, next time stop after the first feature and write tests.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision e39b030...

Educational

Sebastian Gottfried committed changes in [ktouch/KDE/4.10] src/graph-plugin/qml/LineGraph.qml:

graph plugin: fix shrinking behavior of line graph

The data points on the right side are considered more important than
the ones on the left side, so clipping starts on left side now. This
way the most recent data points stay visible when the window containing
the graph is resized to a smaller geometry.


FIXED-IN: 4.10.2

KDE Base

Marco Martin committed changes in [plasma-mobile/pa4/criticalfixes] applications/filebrowser/package/contents/ui/BrowserFrame.qml:

map delegate pos to parent

should avoid the second page items to be selected

KDE-PIM

Grégory Oestreicher committed changes in [kdepim-runtime/KDE/4.10] resources/dav/resource/davgroupwareresource.cpp:
Laurent Montel committed changes in [kdepim] /:

Fix Bug 317198 - background-color for message window for HTML Message need to be adjustable

FIXED-IN: 4.11

Laurent Montel committed changes in [kdepim] /:

Fix Bug 89882 - Use custom header fields with kmail composer from command line

FIXED-IN: 4.11

Andras Mantia committed changes in [kdepim-runtime/KDE/4.10] /imap:

1) Fix creation of new toplevel folders (and all its subfolder): it used to generate a broken remote id and separtor ("i") causing weird problems.
2) Make sure toplevel imap folders are shown immediately, without a need to sync the account (workarounds an ETM bug 291143)
3) Warn the user if creating a folder failed on server-side and remove the folder locally. Otherwise if creation failed, it was impossible to create again a folder with the same name,
as it was already a folder with that name in the akonadi cache...
4) Make sure deleting folder "foo" doesn't deleted all folders starting with "foo" as it did before.
5) Just fix folder deletion. :) It could fail in certain cases.
6) Fix and adapt the tests.

Reporters of closed bugs: if you can still see the bug in 4.10.2, please reopen and state the details.

REVIEW: 109276
FIXED-IN: 4.10.2291143291143
, 305269, 301088, 292418, 305987, 291143

Laurent Montel committed changes in [kdepim] /:

Fix Bug 127181 - Keyboard key/menu to switch from brut HTML view to formatted HTML view of message body

FIXED-IN: 4.11

Sandro Knauß committed changes in [kdepim/KDE/4.10] messagecomposer/composer.cpp:

Fix 307776 - GnuPG signature + attachment produces signed but empty mail

Creating an inline encrypted mail with attachments produces an empty
mail without any attachments.


FIXED-IN: 4.10.2
REVIEW: 109710

Office

Robby Stephenson committed changes in [tellico/2.3] /:

Fix the CSV export to properly escape values with delimiter

An old commit accidently removed the escapeText() call from one
of the text export sections. As a result, values that include the
delimiter (usually a comma) were not enclosed in double quotation marks.

Add a unit test, as well.


FIXED-IN: 2.3.8

Allan Anderson committed changes in [kmymoney] kmymoney/mymoney/storage/mymoneystorageanon.cpp:

- KMyMoney hangs when editing transaction in anon file.
Fix problem when creating an Anon file, where a priceMode setting in an
investment or a stock account, was anonymized, resulting in looping
in InvestTransactionEditor::priceMode(void) on attempting to
edit the account in question.

Networking Tools

Aleix Pol Gonzalez committed changes in [ktp-desktop-applets/kde-telepathy-0.6] chat/org.kde.ktp-chat/contents/ui/ChatWidget.qml:

Correctly set the focus to the input field when the conversation opens

This patch makes sure that the focus will be forwarded to the text input
when the dialog is opened. This patch is probably only needed because I
don't understand the FocusScope that well, but it's an important feature
to have fixed.

Reviewed by David Edmundson

David Edmundson committed changes in [ktp-accounts-kcm] data/profiles/google-talk.profile:

Fix address of conference server for Google group chats

Features

Development Tools

Sven Brauch committed changes in [kdev-python/1.5] /:

Implement identifier-similarity aware sorting of completion items

If you have completion items called foobar and bazbang, and you write
myobj.foobar_of_obj = | then the "foobar" item will be sorted higher
than bazbang, even tough bazbang is alphabetically first.
This should be quite useful in some situations.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 333cf91...

Educational

Andreas Cord-Landwehr committed changes in [rocs/scriptInterfaceDocumentation] /:

Scripting API documentation manager.

Initial commit for scripting API documentation manager. This manager
is used to find all API specifications (from scripting extensions as
well as data structure backends) and to provide a simple interface
for the ApiDocWidget.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 3c72435...

Graphics

Albert Astals Cid committed changes in [okular] /:

Implement Open url in browser for plain text


REVIEW: 108614
FIXED-IN: 4.11.0

KDE Base

Simon Paul St James committed changes in [kate] /:

Add (currently hidden, off by default) config option for emulating the Vim command bar in Kate vim mode, and set it at the beginning of the new VimStyleCommandBarTests. Introduce KateViEmulatedCommandBar class, and add it to KateView, along with an accessor. Summon the bar on "/", and ensure that it has correct indicator label and an empty text bar. Test that the typed text appears in the emulatedCommandBarTextEdit when it is summoned.

Use RIAA to set up pre-conditions for the VimStyleCommandBarTests and ensure they are reverted when the test ends.

REVIEW:109867
DIGEST

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision e2cf410...
Ignat Semenov committed changes in [kde-baseapps] /applets/folderview:

add a "Folders first" checkbox to the Display config page

Allow the user to set the "Folders first" option using the Settings dialog.

Lukáš Tinkl committed changes in [kdelibs/KDE/4.10] /solid:
Thomas Lübking committed changes in [kde-workspace/KDE/4.10] /:

use QWidgetAction for activity setting in alt+f3

not that i really like using QWidgetAction, but it'll
prevent the popup from autoclosing.
Introduce activityUpdateBlocking to prevent users from
removing the popup under their fingertips


FIXED-IN: 4.10.2
REVIEW: 107762

Bernd Buschinski committed changes in [kdelibs] /:

kjs/khtml: Reuse existing html5 Audio Element instead of duplicating it

that adds all html functionality to the javascript Audio.
Previous one just had pause/play/stop/onload/onerror and
NOTE "stop" is not even part of the HTMLAudioElement/HTMLMediaElement(.idl), so its removed now.

REVIEW:106671

Diffs: 1, 2, 3 Revision b69affd...
Alex Fiestas committed changes in [bluedevil] src/monolithic/monolithic.cpp:

Check if there is an usable adapter before going to onlineMode

An adapter can be added but it might no be usable (not powered) so we
have to be certain that there is an usableAdapter before going into
onlineMode.

In the future We should connect only to usableAdapterChanged to make
the code waay simpler, but since we are close to release let's not
modify too much code.

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.10] dolphin/src/kitemviews/kfileitemmodel.cpp:

Improve grouping by name for non-ASCII file names

This commit prevents that all non-ASCII letters which are not umlauts
are grouped in a single group "Others", and that the joint group of
an ASCII letter and the associated umlaut in some locales is called
"Others" if there is only the umlaut in the group.


REVIEW: 109457
FIXED-IN: 4.10.2

Ignat Semenov committed changes in [kde-baseapps] /applets/folderview:

add "Arrange icons" submenu to the context menu

Allow the user to change icon flow in an icon view using the context menu.

Sebastian Kügler committed changes in [plasma-framework] src/plasmapkg/plasmapkg.cpp:

Make upgrading wallpapers work

We were previously accessing an invalid metadata, because wallpapers
aren't necessarily found as plugins: Take care of this case.

Lukáš Tinkl committed changes in [kdelibs/KDE/4.10] solid/solid/backends/upower/upowerdevice.cpp:

recognize additional battery types


FIXED-IN: 4.10.2

Thomas Lübking committed changes in [kde-workspace] /:

turn "ignore geometry" forcerule into a setrule

and btw. replace legacy "ignoreposition" by "ignoregeometry"

this will allow to use "apply initially" as "force" used to act
(ignore position on placement) and "force" to prevent clients
from reconfiguring themselves (to not break a tabgroup or to just
not be annoying)



REVIEW: 109691
FIXED-IN: 4.11

KDE-PIM

Dan Vratil committed changes in [kdepim-runtime] resources/google/contacts/contactsresource.cpp:

Use full name of system groups to avoid collision with user groups

When users create groups "Friends" or "Family" manually, the
collection name would conflict with the system group names,
so we use system group full name ("System Group: Friends" etc)
to avoid the conflict.

Thanks to Lindsay for tracking down the issue.

Stefan Brüns committed changes in [kdepim-runtime] resources/dav/protocols/caldavprotocol.cpp:

Fetch VJOURNAL from CalDAV resource

Although VJOURNAL entries were stored in the CalDAV ressource,
only VEVENT/VTODO were fetched so far.

FIXED-IN: 4.10.2

REVIEW: 109713

Signed-off-by: Stefan Brüns

Office

Klaas Freitag committed changes in [kraft] /:

Let user select his own identity from address book in settings.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision da723a3...
Florian Clavel committed changes in [calligra/words-pagelayout-toulouse] /part/pagetool:

A part of a new feature to let the user resize pages with the mouse. Only work for the first page for now + Cleaner control of the Autoscroll

Nicolas Bruniquel committed changes in [calligra/pagelaoyout] /part/pagetool:

Header/Footer can be created by mouse click

Thorsten Zachmann committed changes in [calligra] /:

Rework stylesmanager

This fixes various crash conditions which where present in the styles manager.
It used a different model for the style manager that handles the temporary styles
during they are modified and not yet saved.

REVIEW: 109651

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 4a46fc5...

Multimedia

Matěj Laitl committed changes in [amarok] /:

UmsCollection: recognize Data CDs as collections

CHANGES:
* Data CDs are now recognized in Amarok; patch by Anmol Ahuja.


FIXED-IN: 2.8
REVIEW: 109752
DIGEST: Amarok now recognizes Data CDs as collections

Matěj Laitl committed changes in [amarok] /:

AmarokWindowScript: add prepareToQuit() signal

CHANGES:
* Add prepareToQuit() signal to Amarok.Window script bindings; patch by
Anmol Ahuja.


FIXED-IN: 2.8
REVIEW: 109695
DIGEST: Amarok scripting interface has been enhanced with requested method

Networking Tools

Dan Vratil committed changes in [ktp-contact-runner/kde-telepathy-0.6] src/contactrunner.cpp:

Use KTp::Contact to determine contact's capabilities in krunner actions

KRunner now shows "Start audio call" and "Start video call"
actions when contact has such capabilities.

REVIEW: 109698

FIXED-IN: 0.6.0

Andrea Diamantini committed changes in [rekonq] /:

Managing sessions, first bits

This code is based on the patch from mayank jha about session saving.
Will be used as "first part" of the session saving support in rekonq.

Diffs: 1, 2, 3, 4 Revision 34050a0...
Andrea Diamantini committed changes in [rekonq] /:

Implement session saving, inspired from kate session management

(or at least, for what I see...)
Added session manager widget and ability to load/save/rename sessions

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 80828dc...

Optimization

Graphics

Gilles Caulier committed changes in [digikam] /:

new algorithm from Sayantan Datta to auto crop image by black hole border detection.
typical use case : crop automatically assembled panorama to the most largest suitable image size

CC
CC

KDE Base

Bernd Buschinski committed changes in [kdelibs] /:

kjs: Extend PropertySlot like JSC does, introduce new GetValueNumberFunc to
avoid doing unneeded Identifier::from(unsigned) if we already know its an unsigned.
Before we used to do something like:
store unsigned -> Identifier::from(unsigned) -> call -> Identifier.toArrayIndex to get the unsigned again -> use unsigned
now:
store unsigned -> call -> use unsigned.
The pure Identifier/"String" case is unchanged.

Also (like JSC too) add function to directly store the Value, this avoids extra function call.
Now we no longer need to create a static GetValueFunc for getting a tiny value. (less code, more fun)

This overall improves the performance for kjs:

with SunSpider 1.0-svn, (less is better, 3*10 runs)
before: 2887.5ms, 2836.9ms, 2865.4ms
after: 2748.5ms, 2756.4ms, 2747.3ms

octane benchmark (more is better)
before score: 225
after score: 272

and most important not a single testcase got slower.

For typed-arrays, my extra bloated worstcase bubble sort testcase (less is better)
before: ~44sec
after: ~18sec

REVIEW:108946

Diffs: 1, 2, 3, 4, 5 Revision aabebcb...
David Faure committed changes in [kdelibs/KDE/4.10] /:

Implement delayed loading of slow icons (from .desktop or .directory files)

Thanks to Pierre Sauter for making me fix this, and for testing that it
works over sshfs.

FIXED-IN: 4.10.2

Oliver Henshaw committed changes in [plasma-mobile/oliverhenshaw/power-timeou] applications/settings/modules/powermanagement/contents/ui/Power.qml:

DPMS idle timeouts are stored in seconds

Meant that screen power-saving was probably never activated.

Office

Sebastian Sauer committed changes in [calligra/coffice] /:

Land threading.

The whole Calligra application, means Words, runs
in an own thread now. That means the UI is 100%
non-blocking now independent of whatever the
application itself does during loading, layouting,
rendering, ...

While that works well on Android and X11 there
are still some corner-cases left that can or
could result in race-conditions / crashers. Going
to solve them in the next step and also may
give hellgrind a try before turning that into
the next Coffice release.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision b93e969...

Other

Educational

Sebastian Gottfried committed changes in [ktouch/KDE/4.10] /:

data: reformat the Catalan and two Spanish courses

So that their lessons have a more reasonable line length. Now the first
line of training text is actually visible in the trainer without
having to scroll down/resize the window first.

Graphics

Gilles Caulier committed changes in [digikam] /:

Remove clapack library from digiKam core used by Refocus tool.
Add new optional dependency to Eigen3 library to replace clapack
REVIEW: 109692

FIXED-IN: 3.2.0

Utilities

Aleix Pol Gonzalez committed changes in [kde-gtk-config/2.2] /:

New icon

Contributed by Christian Díaz



D +- -- icons/gnome-foot-color.png
A +- -- icons/hi128-app-kde-gtk-config.png
A +- -- icons/hi16-app-kde-gtk-config.png
A +- -- icons/hi22-app-kde-gtk-config.png
A +- -- icons/hi24-app-kde-gtk-config.png
A +- -- icons/hi256-app-kde-gtk-config.png
A +- -- icons/hi32-app-kde-gtk-config.png
M +- -- icons/hi48-app-kde-gtk-config.png
A +- -- icons/hi64-app-kde-gtk-config.png
A +- -- icons/hi8-app-kde-gtk-config.png
A +- -- icons/hisc-app-kde-gtk-config.svgz