Revision f48efe4...

Go back to digest for 7th April 2013

Other in KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Split out Activities related code from Workspace

All activities related code moves into new singleton class Activities.
This class gets only included into the build if the build option is
enabled which means there are less ifdefs all over the code and it also
handles better the moc doesn't like ifdef case.

The class holds the list of open and all activites, the current and the
previous activity and the KActivities::Controller. It also emits the
signals for any activities related changes.

Workspace still contains some activities related code. That is the
adjustment on change of current activity. Nevertheless the code looks
much cleaner now and does not contain the confusing naming conflict with
takeActivity() which existed before.

In all the places where Activities got used the code got adjusted and
quite often the ifdef got added with a fallback for the disabled case.

File Changes

Added 2 files
  •   kwin/activities.cpp
  •   kwin/activities.h
Modified 15 files
  •   kwin/activation.cpp
  •   kwin/client.cpp
  •   kwin/CMakeLists.txt
  •   kwin/dbusinterface.cpp
  •   kwin/effects.cpp
  •   kwin/manage.cpp
  •   kwin/sm.cpp
  •   kwin/toplevel.cpp
  •   kwin/toplevel.h
  •   kwin/useractions.cpp
  •   kwin/workspace.cpp
  •   kwin/workspace.h
  •   kwin/scripting/scripting_model.cpp
  •   kwin/scripting/workspace_wrapper.cpp
  •   kwin/tabbox/tabbox.cpp
17 files changed in total