Issue 283

14th April 2013 by KDE Commit-Digest Team

Contributors

Jürgen Appel
Marta Rybczynska

This Week...

KDE-PIM extends support for Facebook notifications: whenever the user receives a notification, it's displayed with direct links and an option to mark all notifications as read; work starts on grammar checker. Calligra expands the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks. Network Management autoconnects to a VPN when a device gets connected; work in progress on mobile broadband wizard integration. Rocs adds script engine documentation widget feature. Work on Youtube support in Plasma MediaCenter.
Spotlight

Statistics

Commits 2063 by 174 developers
Open Bugs 21216
Open Wishes 15800
Bugs Opened 322 in the last 7 days
Bugs Closed 522 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
169
 
/branches/stable
87
 
/trunk/l10n-support
75
 
/ksieveui/autocreatescripts
19
 
/libksieve/ksieveui
15
 
/krita/plugins
13
 
/trunk/www
12
 
/chat/org.kde.ktp-chat
10
 
/plasma/generic
9
 
/package/contents
9
 
Files Developer Commits
243
 
Laurent Montel
87
 
129
 
Gilles Caulier
46
 
120
 
Daniel Nicoletti
41
 
105
 
Friedrich W. H. Kossebau
35
 
105
 
Ingo Malchow
35
 
96
 
Sebastian Kügler
34
 
99
 
Andreas Cord-Landwehr
34
 
84
 
Aurélien Gâteau
32
 
93
 
Lukáš Tinkl
31
 
93
 
Sébastien Renard
31
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Swedish (sv)
99%
 
Brazilian Portuguese (pt_BR)
99%
 
Estonian (et)
97%
 
Spanish (es)
97%
 
Dutch (nl)
97%
 
Polish (pl)
97%
 
German (de)
96%
 
French (fr)
96%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Myriam Schweingruber
152
 
Aleix Pol Gonzalez
45
 
Jekyll Wu
38
 
Eike Hein
37
 
Martin Klapetek
24
 
Christoph Feck
23
 
Benni Hill
21
 
Matěj Laitl
14
 
David Edmundson
13
 
Thomas Lübking
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[] [] []   

Graphics

[] []    

KDE Base

[] []    

KDE-PIM

[] []    

Office

  [] []   

Konqueror

     

Multimedia

[] []    []

Networking Tools

[] []    

User Interface

[]     

Utilities

     

Games

     []

Other

  []    

There are 44 selections this week

Bug Fixes

Development Tools

Aleix Pol Gonzalez committed changes in [kdevelop] projectbuilders/cmakebuilder/cmakejob.cpp:

Educational

Sebastian Gottfried committed changes in [ktouch] /qml:

training screen: better placement of key hint item

The hint key item is now displayed right below under the current
training line so the user can see it really well while also beeing able
to read the text he has to type. Additionally the item is now in front
of all over visual elements so the it gets never clipped by the keyboard
visualization.

Graphics

Albert Astals Cid committed changes in [okular] /:

Fix Undo / Redo of annotation creation doesn't properly handle page rotation and adds undo unit tests


REVIEW: 109989

KDE Base

Aurélien Gâteau committed changes in [kde-baseapps/KDE/4.10] dolphin/src/kitemviews/kstandarditemlistwidget.cpp:

Fix moving image while transitioning to hover pixmap

See: http://youtu.be/OMYO0U0kSL0

REVIEW: 109960
FIXED-IN: 4.10.3

Chao Feng committed changes in [kde-workspace] plasma/generic/dataengines/share/backends/kde/contents/code/main.js:

Fix Bug 289647 - Default text engine 'kde' fails when pasting text longer than 513/741 characters

Use "post" instead of "get" method for kde paste bin.
HTTP get method only support 1024 url length.


FIXED-IN: 4.11.0

Martin Gräßlin committed changes in [kde-workspace] /:

Do not use stackingOrder in LanczosFilter to get all EffectWindows

LanczosFilter tries to discard all cached textures in the timer event by
getting the stacking order and iterating over it. But this approach seems
wrong from several aspects.

First of all the xStackingOrder does not include Deleted windows. So if
a cached texture still exists on an EffectWindow for a Deleted it would
not be discarded.

Also the xStackingOrder could result in an update from X because the
stacking order is currently considered dirty.

Last but not least the EffectsHandler::stackingOrder creates a temporary
list of EffectWindows - good for Effects but not necessarily useful
inside KWin core.

Instead the LanczosFilter gets the list of Clients, desktops, unmanaged
and deleted and iterates over them to check whether there is a texture to
discard.

REVIEW: 109954

Alex Fiestas committed changes in [kde-workspace] /kcmkwin/kwinrules:

Make activities really optional in KWin

KWin is already able to work without activities but there was some code
left in the rules GUI.

REVIEW: 109815

KDE-PIM

Laurent Montel committed changes in [kdepim] akregator/src/trayicon.cpp:

Fix Bug 318191 - akregator's bubble info on systray icon shows 1 feed not read whereas all are read

FIXED-IN: 4.11


can't put to 4.10.3 because it breaks message freeze

Aleix Pol Gonzalez committed changes in [ktp-desktop-applets] chat/org.kde.ktp-chat/contents/ui/main.qml:

Improve integration with hiding panels

This patch changes 2 things:
- Changes the code from a js function to setting a qml property. This is
better because we don't have to connect to all the changing signals to
re-evaluate (there were some weird problems in this regard).
- Also it makes it so when you have a dialog opened, the status is set to
AcceptingInputStatus, this way the panel doesn't hide while you're writing.
This is useful because this way you can see if somebody talks to you while
you're chatting already.

REVIEW: 109947

David Faure committed changes in [kdepim/KDE/4.10] /:

Fix kmail autocompletion from akonadi.

My commit 02f5f0214e made autocompletion from nepomuk work better, but broke
completion from akonadi. I kept the "keywords" based code, but now it's only
used for the special case of nickname-based search (because the nickname shouldn't
appear in the completion item). For everything else it really doesn't make sense
to have a search engine (akonadi/nepomuk) on top of a search engine
(the one inside KCompletion).

This time I verified that:
* nepomuk search still works
* contacts from akonadi work again
* contact groups from akonadi work (after previous commit)
* nickname-search in akonadi still doesn't work, but it didn't before. More work
needed for that one. This is the only reason to keep KMailCompletion around btw,
everything else would work without it.


FIXED-IN: 4.10.3

Sandro Knauß committed changes in [kdepim/KDE/4.10] messageviewer/objecttreeparser.cpp:

Fix Bug 318182 - Multipart messages are displayed twice in KMail

Instead of showing another time the first text block the actual text of
one node is taken


FIXED-IN: 4.10.3
REVIEW: 109963

Multimedia

Matěj Laitl committed changes in [amarok] /:

MySqlEmbeddedStorage: don't use QString::toAscii(), fix bug 313914

It is 2013. We have more characters than 128.

BUGFIXES:
* Fix inability to create database when home directory contains
non-ASCII characters.


FIXED-IN: 2.8

Networking Tools

Martin Klapetek committed changes in [ktp-text-ui/kde-telepathy-0.6] /:

Use KWebView instead of QWebView for AdiumThemeView

This should make sure that network requests like downloading image
preview go through KDE's configured proxy.

Reviewed-by: David Edmundson

FIXED-IN: 0.6.1

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk/gtk3] /:

Fixed leak when parsing colors from kde config


free result from g_spawn_command_line_sync


Free icon source after insertion in icon set


Fix another leak due to g_spawn_command_line_sync

Features

Development Tools

Nick Shaforostoff committed changes in [lokalize] /:

trans units filtering based on sync file matches available

three new filtering options in the Translation Units widget:

* Same in sync file
* Different in sync file
* Not in sync file

These options allow to filter out translation units based on
available syncing options for them.

REVIEW: 109904

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 6d909ec...

Educational

Andreas Cord-Landwehr committed changes in [rocs] /:

Merge branch 'master' of git.kde.org:rocs

DIGEST: merge script engine documentation widget feature

Graphics

Aurélien Gâteau committed changes in [gwenview] app/mainwindow.cpp:

Merge branch 'wip/wrap-around'

Gwenview now wraps to the first document when user tries to go after the last
one. Same thing when trying to go before the first document. A small text
bubble appears in the middle of the window to notify the user of the wrapping.

REVIEW: 109842

FIXED-IN: 4.11.0

KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Move killWindowId(Window) from Workspace to KillWindow

Only used from KillWindow and does not operate on private data of
Workspace.

At the same time port to XCB.

REVIEW: 109911

Diffs: 1, 2, 3, 4 Revision 03e4b7a...
Simon Paul St James committed changes in [kate] /:

Update the search bar background colour according to whether match is found or not (or text is empty).

Diffs: 1, 2, 3 Revision 3ea0723...
Dominik Haumann committed changes in [kate] /:

KateMessageWidget: force wordwrap if messages does not fit

Posting messages can now safely be used with word wrap set to false.
If the message's width is too large, word wrap will automatically
be enabled to avoid breaking the layout.

Diffs: 1, 2, 3 Revision d20d406...
Vishesh Handa committed changes in [nepomuk-core/feature/mergeGraphs] /storage:

Migrator: New Application called nepomukmigrator

It is responsible for migrating the existing data for the new release.
It will be mandatory to run.

So far this application doesn't do much. This is just the rough outline.

Diffs: 1, 2, 3, 4, 5, 6 Revision be1fe19...

KDE-PIM

Martin Klapetek committed changes in [kdepim-runtime] /facebook:

Display KNotification and KStatusNotifier for Facebook notifications

Whenever the user receives new Facebook notification, it's displayed in
KStatusNotifierItem, which also includes menu with direct links to the
notifications as well as an option to mark all notifications as read (on
the server).

For every new Facebook notification there is KNotification displayed as
well. If there are more than one Facebook notifications, the newest one
is displayed with "...and N more" appended.

The configuration part of the resource contains a setting to turn this
off.

REVIEW: 109825
DIGEST

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision a1aa471...
Laurent Montel committed changes in [kdepim] /:

Start to work on grammar checker

Diffs: 1, 2, 3, 4, 5, 6 Revision 6500943...

Office

Aman Madaan committed changes in [calligra] /:

Expansion of the References section by adding features to insert hyperlinks,
bookmarks and links to bookmarks.

This patch adds the following features :

1. Inserting hyperlinks

-- User has a choice of inserting a link by specifying the target and the
link text.
-- The user may fetch the title from the web page itself (contents of the
"title" tag ). This feature also handles URL redirects.This feature will especially
help in cases when a user has a list of links referred to and a list of references
has to be created. Just copy/pasting the URL, clicking fetch and then insert will do the job.

2. Linking to bookmarks

-- A user can specify a bookmark name and the link text. To help the user
with inserting a bookmark, an auto completer is used.

3. Adding Bookmark using a labeled widget ( similar to the way footnote and
endnote labels are entered)

4. Improvement to the Manage Bookmarks ui by adding feature to insert a bookmark
and fixing bugs.

A list of commit headlines follow :

Added licenses
Fixed Insert and Rename feature in ManageBookmarks.
Deleted Advanced options.
Combined bookmark name line edit and the list widget into an editable combobox.
Finised Internationalization
Modify insertText() to accomodate links
Merged LinkedInsertionDialog, WeblinkInsertionWidget and
Add a new bookmark to the list as it is added
Simple Link insertion finished.
Added the SimpleLinkWidget to the references dock
sg

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 6 more) Revision 5612ffd...
Stephane Mankowski committed changes in [skrooge/Feature] /:

: New file format (AFB120 CFONB)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision a116320...
Dmitry Kazakov committed changes in [calligra] libs/pigment/KoColorConversionCache.cpp:

Implement a per-thread color space conversion cache

This makes the cross-colorspace painting about 2 times faster.
There is really high contention on this mutex, so the per-thread storage
relaxes it a bit.

Arjen Hiemstra committed changes in [calligra/active-calligratouch-shantanu] /:

Add a model that can show thumbnails of presentation slides.

Diffs: 1, 2, 3, 4, 5, 6 Revision 1da2978...

Multimedia

Sinny Kumari committed changes in [plasma-mediacenter/sinny-youtube] /onlineservices:

Initial Youtube plugin

Refactoring of existing youtube plugin in Media Center written by Alessandro Diaferia
Currently only preview of default search "kde"

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1d12c13...
Sinny Kumari committed changes in [plasma-mediacenter/sinny-youtube] /onlineservices/youtube:

Implementing search in youtube backend

storing url link of videos

Diffs: 1, 2, 3, 4 Revision f2925d2...

Networking Tools

Lukáš Tinkl committed changes in [plasma-nm] /:

finish mobile broadband wizard integration

now it's possible to create and edit new gsm/cdma connections;
unfortunately the setting doesn't for some reason get saved,
jgrulich will look into it

Diffs: 1, 2, 3, 4, 5, 6 Revision 866b8a9...
Martin Klapetek committed changes in [ktp-accounts-kcm/kde-telepathy-0.6] /:

Bring new/enabled accounts to current global presence

Right now the accounts are always connected as online, which among other
things breaks global presence. With this patch the newly added or
enabled accounts are always connected to the current global presence.

Reviewed-by: David Edmundson

FIXED-IN: 0.6.1

Lukáš Tinkl committed changes in [plasma-nm] /:

new feature: autoconnect to a VPN when a device gets connected

Diffs: 1, 2, 3, 4 Revision f436064...
Lukáš Tinkl committed changes in [plasma-nm] /:

add a mobile broadband connection wizard

adapted from networkmanagement, not used yet

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision f7530db...
David Edmundson committed changes in [ktp-common-internals/kde-telepathy-0.6] /Declarative:
Harald Sitter committed changes in [rekonq] src/webtab/webpage.cpp:

honor filetype setting WRT embedding

there are 3 distinct states a filetype can have WRT kpart embeding
- always embed
- never embed
- do whatever the parent node does (e.g. application/foo would take the
setting of application)

since the logic to determine which of those it is going to be we are using
a bit of code imported from konqueror deciding in a boolean fashion
whether or not we are supposed to embed or not. this is particularly non-
intrusive as the decision directly relates to whether a kpart is created,
if not the file will simply be krun'.

this change is using static functions for the imported code. rationale
being that they are in fact static and not having them reflected in the
header makes them all the easier to remove should a better solution
arise in the future.

with that in mind: while the code is copy'n'pastable it seems like a
good idea to move this into some shared library in the long term such
that konqueror and rekonq (and any other kpart enabled app) can use the
same code.

REVIEW: 109942

Aleix Pol Gonzalez committed changes in [ktp-desktop-applets/kde-telepathy-0.6] chat/org.kde.ktp-chat/contents/ui/ConversationDelegateButton.qml:

Add visual feedback while dragging over the delegate

It helps to display that we accept drops

REVIEW: 109972

Martin Klapetek committed changes in [ktp-text-ui/kde-telepathy-0.6] lib/chat-widget.cpp:

Sort contacts by name in group chat contact list

REVIEW: 109943

FIXED-IN: 0.6.1

Other

Antonis Tsiapaliokas committed changes in [bodega-webapp-client/kokeroulis/paymentm] /:

Add payment method support

Diffs: 1, 2, 3, 4, 5 Revision ca3182f...

Optimization

Educational

Aleix Pol Gonzalez committed changes in [analitza] analitza/operations.cpp:

Optimizating squaring

It's clearly faster to call x*x than pow(). Given that the square
root is fairly common, I'll leave the optimization.

Improves 15% in curvetest testCorrectExpressions:slow-eval-implicit

Aleix Pol Gonzalez committed changes in [analitza] /:

Return the Apply::firstOperator as a reference

A bit of time was spent by copying the operator and accessing it, this
change reduces this problem where it's more notable, by using it as a
reference.
Improves about 10%

Office

Dmitry Kazakov committed changes in [calligra] interfaces/KoID.h:

Fixed a performance bug in KoID

In general, code duplication is not good. Avoiding it here makes the
performance of multi-colorspace painting about 5 times faster.

Arjen Hiemstra committed changes in [calligra/active-calligratouch-shantanu] /:

Add a way to do zooming using a temporary image

This can make zooming quite a bit more performant.

Other

Multimedia

Ed Rogalsky committed changes in [kdenlive/feature/jack] /:

make jack icons more attractive

M +- -- icons/hi16-action-kdenlive-toggle-jack-mon.png
M +- -- icons/hi16-action-kdenlive-toggle-jack.png
M +- -- icons/ox16-action-kdenlive-toggle-jack-mon.png
M +- -- icons/ox16-action-kdenlive-toggle-jack.png

Games

Roney Gomes committed changes in [knavalbattle/renaming] /:

All references to KBattleship replaced by KNavalbattle.

Due copyright issues KBattleship is now called KNavalbattle. Even so,
the program's installation folder as well as its image files and final
binary are all named making references to KBattleship.

This patch removes all references to the project's previous name,
changing its build settings as well as renaming some of its files.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision c020aac...