Issue 285

28th April 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Jürgen Appel
Michael Torres

This Week...

Amarok can now be configured not to transcode from e.g. MP3 to MP3 and more. Artikulate implements native sound recording in editor. Digikam adds Pixel size and Aspect ratio filters to Text filter and Advanced Search dialog. Search now uses https for web shortcuts. Kate adds OpenCL highlighting and preliminary implementation of CMake auto completer. Calligra implements file-backed layers; COffice adds zoom.

Statistics

Commits 2118 by 156 developers
Open Bugs 21308
Open Wishes 15811
Bugs Opened 307 in the last 7 days
Bugs Closed 268 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
163
 
/branches/stable
93
 
/trunk/l10n-support
88
 
/plasma/applets
19
 
/trunk/www
15
 
/libksieve/ksieveui
15
 
/src/lib
12
 
/package/contents
11
 
/src/shell
11
 
/addons/kate
11
 
Files Developer Commits
327
 
Laurent Montel
117
 
141
 
Burkhard Lück
47
 
111
 
Sébastien Renard
37
 
105
 
Vit Pelcak
35
 
105
 
Aleix Pol Gonzalez
35
 
93
 
Daniel Nicoletti
33
 
93
 
Xavier Besnard
31
 
63
 
Gilles Caulier
29
 
81
 
Sebastian Kügler
27
 
63
 
Patrick Spendrin
26
 

Internationalization (i18n) Status

Language Percentage Complete
Ukrainian (uk)
100%
 
Portuguese (pt)
100%
 
Swedish (sv)
99%
 
Spanish (es)
97%
 
Estonian (et)
97%
 
German (de)
97%
 
Dutch (nl)
97%
 
Polish (pl)
97%
 
French (fr)
96%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Christoph Feck
44
 
Frank Reininghaus
29
 
Jekyll Wu
19
 
Gilles Caulier
17
 
Martin Gräßlin
15
 
Alex Fiestas
14
 
Thomas Lübking
12
 
Boudewijn Rempt
9
 
Myriam Schweingruber
8
 
Daniel Nicoletti
8
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

  []    

Graphics

[] []    

KDE Base

[] [] []   []

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

  [] []   []

Networking Tools

[] []    

User Interface

  []    

Utilities

[] [] []   

Games

  []    

Other

     

There are 53 selections this week

Bug Fixes

Development Tools

Sven Brauch committed changes in [kdevplatform] interfaces/iassistant.cpp:

don't break when the string passed is not HTML at all

I really wonder if there's actually a situation where a HTML string is
being passed to this function?

Graphics

Fabio D'Urso committed changes in [okular/KDE/4.10] core/document.cpp:

Do *not* swap width and height in DocumentPrivate::refreshPixmaps

They must not be swapped, because generators already swap them on their
own, and swapping them twice results in distorted pixmaps.


FIXED-IN: 4.10.3

KDE Base

Dominik Haumann committed changes in [kate] /syntax:

update CubeScript

Complete Changelog
* Corrected deliminators to reflect CubeScript's quirks.
* Highlight all operators
* Added additional valid key names for mouse buttons.
* Split enclosed lookup types so they do proper bracket mismatching checks
* Adjusted style of $() lookup construct to reflect its executable nature.
* Include standard Alert types in the comment context.

* Fix file extension for identifying CubeScript files.
* Fix highlighting of reserved aliases outside an enclosed lookup.
* Fix Bind context possibly marking ) and ] characters as erroneous.

Thanks to Kevin Meyer for the patch!

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.10] dolphin/src/kitemviews/private/kitemlistroleeditor.cpp:

Disable Find/Replace in the "rename inline" line edit

These actions do not work correctly because renaming is considered
finished as soon as the line edit loses focus, which happens when the
"Replace" dialog pops up.


FIXED-IN: 4.10.3

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/search/dolphinsearchbox.cpp:

Replace the button label "Less Options" by "Fewer Options"



FIXED-IN: 4.11.0

Emmanuel Pescosta committed changes in [kde-baseapps] /src/views:

Scroll to newly pasted files.

If multiple files are pasted, scroll to the first pasted file.


REVIEW: 109950
FIXED-IN: 4.11.0

Dan Vratil committed changes in [kscreen] /:

Hide applet tray icon when only one screen is connected


FIXED-IN: 1.0

KDE-PIM

Dan Vratil committed changes in [kdepim-runtime/KDE/4.10] resources/kdeaccounts/kdeaccountsresource.cpp:

Prevent crash in case of malformed source file

Lamarque Souza committed changes in [kdepim/KDE/4.10] messagelist/core/messageitem.cpp:

Fix importand and todo highlighting in kmail2's message list.

REVIEW: 110098

Christian Mollekopf committed changes in [kdepimlibs/recurrences] kcalcore/recurrencerule.cpp:

The end date is inclusive.

Grégory Oestreicher committed changes in [kdepim-runtime/KDE/4.10] resources/dav/resource/davgroupwareresource.cpp:

Ensure that we have a valid DavUrl


FIXED-IN: 4.10.3

Office

Dmitry Kazakov committed changes in [calligra/calligra/2.7] /:

Fixed Drag & Drop of URL's

Now you can D&D images from Firefox, from Dolphin and there is no crash! =)
Tested the following usecases:

1) Add as layer (local and remote files)
2) Add new Document (local and remote files)
3) Replace Document (local and remote files)

4) Add Multiple Layers (local)
5) Add Multiple Documents (local)

Boudewijn Rempt committed changes in [calligra] karbon/ui/KarbonDocument.cpp:

Don't crash on closing karbon (or importing an svg in Krita)

Dmitry Kazakov committed changes in [calligra] /:

Fixed two bugs in filters/histogram code

1) Histogram should not crash when the source device is empty
2) The preview (and histogram) devices for an adjustment layer
should be created not from the previous layer, but from the
layers stack below.

Dmitry Kazakov committed changes in [calligra] /:

Fixed three bugs and add a feature to KisFilterOp

1) Fixed painting on semi-transparent images. Now COMPOSITE_COPY is the
default mode and it works nicely!
2) Added a feature: Smudge Mode for the Filter Op. The temporary device is
not cleared every time, which creates really nice effects.
3) Fixed loading of the default filter configuration for the Filter Op
4) Fixed an offset bug when painting with Gaussian Blur.



M +- -- krita/plugins/paintops/defaultpresets/filter.kpp

Dmitry Kazakov committed changes in [calligra/krita-testing-kazakov] /:

Fixed Drag & Drop of URL's

Now you can D&D images from Firefox, from Dolphin and there is no crash! =)
Tested the following usecases:

1) Add as layer (local and remote files)
2) Add new Document (local and remote files)
3) Replace Document (local and remote files)

4) Add Multiple Layers (local)
5) Add Multiple Documents (local)

Aurélien Gâteau committed changes in [colibri/plasma-dialog] /:

Fix blinking when text is appended to the widget

Lukáš Tvrdý committed changes in [calligra] /plugins/formats/psd:

Fix memory leak in psd format filter

readPlanarBytes returns QVector of pointers to allocated arrays
and caller is responsible for clean-up of memory

REVIEW:110214

Networking Tools

Emmanuel Lepage Vallee committed changes in [sflphone-kde/abstractmodels] /:

[ #22928 ] Port CallModel to abstractitemmodel (4/6)

This fix:
* Toolbar overlay buttons depending on call state
* Delegate appearance for calls
* Some on canvas tip rendering and position
* Double click on call
* The text event filter for calls

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 480a233...

Utilities

Daniel Nicoletti committed changes in [print-manager] libkcups/ClassListWidget.cpp:

Fix storing request properties before the object change threads

Daniel Nicoletti committed changes in [print-manager/KDE/4.10] printqueue/PrintQueueUi.cpp:

Fix consistency between namings, showing printer description on print-queue too

Features

Educational

Andreas Cord-Landwehr committed changes in [artikulate] /:

Implement native sound recording in editor.

This version is missing the following features:
* proper use of ascii filenames
* proper distinction between play states.

Diffs: 1, 2, 3, 4, 5 Revision 52cfb80...
Dennis Nienhüser committed changes in [marble] src/lib/routing/RoutingInputWidget.cpp:
Dennis Nienhüser committed changes in [marble] src/plugins/runner/gpx/handlers/GPXgpxTagHandler.cpp:

Improve rendering of GPX tracks and routes.

The rendering of tracks and routes is now identical to the rendering
of tracks and routes created by Marble itself, except that the color
is slightly more saturated in order to make it possible to distinguish
them.


REVIEW: 110161

Graphics

Michael Georg Hansen committed changes in [digikam] /views:

Add a digitization date/time column.

Pankaj Kumar committed changes in [digikam] /:

Add Pixel size and Aspect ratio filters to Text filter and Advanced Search dialog.


REVIEW: 108574
FIXED-IN: 3.2.0

Daniel Nicoletti committed changes in [colord-kde] /:

Add an ICC profile importer

Diffs: 1, 2, 3, 4, 5 Revision 02f214b...

KDE Base

Aurélien Gâteau committed changes in [homerun] /:

Use KAction to implement editable shortcuts


REVIEW: 110204

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 Revision 1c9f60c...
Martin Gräßlin committed changes in [kde-workspace] /:

Change the way how effects can get mouse events

With the removal of BoxSwitch all effects which want mouse events use the
fullscreen input window. The available functionality is too complex both
in EffectsHandler and in the Effects.

With this change only fullscreen input windows are supported and all
effects share the input window. This means there is at maximum one input
window. This simplifies the code in the Effects as they don't have to
keep track of the window they created any more. In EffectsHandler it
means that only one window needs to be created, destroyed and raised.
Also it means that we can properly react on screen size changes which had
been ignored in the past. Also quite some roundtrips to X are no longer
needed as we do not need to query the window geometry when creating the
input window.

REVIEW: 110156

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 316fc49...
Frank Reininghaus committed changes in [kde-baseapps/KDE/4.10] /src/kitemviews:

Always determine icons for the visible items first

When entering a folder, KFileItemModelRolesUpdater has not yet been
informed about the visible index range by the view when it tries to
determine icons synchronously. This resulted in the problem that it
tried to determine icons for all items in random order, and some visible
icons were somtimes still unknown after the "synchronous icon loading"
timeout of 200 ms.

This commit tries to improve the situation by loading icons starting
with the first item in increasing order. This should make it less likely
that some visible items still have unknown icons after 200 ms.


FIXED-IN: 4.10.3
REVIEW: 109843

Alex Turbov committed changes in [kate] /kate/pate/src/plugins/cmake_utils:

Preliminary implementation of CMake auto completer.
It capable to complete builtin CMake commands and variables, policies, as well as
options for some commands (i.e. command calling syntax). In this version about half
of commands still require syntax completers... it will be done soon...
However it is already quite usable and helpful...

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision cf30e3e...
Martin Gräßlin committed changes in [kde-workspace] /:

Change the visual appearance of the composited outline

Uses widgets/translucentbackground as FrameSvg item to ensure that we
don't get a huge black square on the screen.

When bordering a screen edge we disable the border except if all edges
are bordered. This makes a little bit more clear in the quick tiling case
what will be the geometry.

REVIEW: 110176

Dominik Haumann committed changes in [kate] part/syntax/data/opencl.xml:

add OpenCL highlighting

Thanks to Pedro for the patch.
FIXED-IN: 4.11

Ignacio Serantes committed changes in [nepomuk-core] services/fileindexer/indexer/taglibextractor.cpp:

CHANGE: Added support to Album Artist, Composer and Lyricist frames in MP3, OGG and FLAC files.
REVIEW: 109550

Maarten De Meyer committed changes in [kde-runtime] /ikws/searchproviders:

Use https for web shortcuts

Use encrypted https for the web shortcuts that support it.


FIXED-IN: 4.11.0
REVIEW: 109841

KDE-PIM

Laurent Montel committed changes in [kdepim] pimcommon/templatewidgets/templatelistwidget.cpp:

Allow to import/export templates

Office

Sebastian Sauer committed changes in [calligra/coffice] /coffice:

Add zoom.

This adds optimized zooming to COffice. Zooming is
done in multiple phases.

1. When a Zoom-operation starts the DocumentItem is
scaled till the zoom-operation completes. This
gives fluid and fast zooming.

2. Once a zoom-operation finished the DocumentItem's
scale is reverted, the zoom applied to the
PageItem's and there displayed page image and the
Page is marked dirty.

3. When now that page becomes visible for display
an update is scheduled to render a new page image
matching to the zoom.

4. Once the page update is done in the app-thread
and the result send to the UI-thread the displayed
image is replaced with the new one.

Result is that we earn a fluid zooming experience
with pages updated to the new zooming resolution
only when needed (means displayed) what effectively
delays the expensive re-render as long as possible.

For now the previous hacky and pinch-zo-zoom is
disabled. In a follow-up step pinch-to-zoom will
reuse the same zooming code.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 77947e8...
Boudewijn Rempt committed changes in [calligra] /:

FEATURE: implement file-backed layers

This is a layer that is loaded from a file and updates when the file
changes. Optionally, the image in the file can be scaled to the current
image's resolution.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 9 more) Revision 140d940...
C. Boemann committed changes in [calligra] /:

1) flow-with-text of text-box is always false
2) merge several paragraphs with equal text-box properties into a single text-box
3)improve .doc filer to handle margins and autosizing frames

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 9d4492c...
Stephane Mankowski committed changes in [skrooge] /:

feature: In report, the graph correction can be done by multiply or divide

Diffs: 1, 2, 3, 4 Revision b38e3a6...

Multimedia

Matěj Laitl committed changes in [amarok] /:

Better and more configurable selection of tracks to transcode

FEATURES:
* Allow to transcode only certain (different format, playability) tracks when
transferring them to a collection; patch by Anmol Ahuja.

Added 3 checkbox in the TranscodingAssistantDialog:
"Transcode all tracks" - transcode all tracks, the current default behavior
"Ignore files which're already the selected format" - transcode only if source and destination file formats are different
"Transcode only when needed for playability" - transcode only when needed for playability in the destination collection

Anmol, I've made some very minor modifications, compare the diffs if you're
really curious. Thanks again for implementing this, it makes Amarok better.


FIXED-IN: 2.8
REVIEW: 109781
CCMAIL: Anmol Ahuja
DIGEST: Amarok can now be configured not to transcode from e.g. MP3 to
MP3 and more. Patch by a newcomer Anmol Ahuja.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 10 more) Revision e84b44e...

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:
Lukáš Tinkl committed changes in [plasma-nm] /:

enable configuring notifications

feature: https://trello.com/c/kUIg3lFf

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 18ff43d...

User Interface

Sebastian Kügler committed changes in [plasma-framework] /shell/qmlpackages/lookandfeel:

Skeleton for Look & Feel package

This is an empty package, with directories and zero-sized files set up
that can be filled in.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 10 more) Revision 5175188...

Utilities

Aleix Pol Gonzalez committed changes in [muon] libmuon/resources/ResourcesUpdatesModel.cpp:

Increase verbosity while updating

It's nice to get some feedback and see what's going on...

Games

Ashwin Rajeev committed changes in [knetwalk/KDE/4.10] /:

New shuffling algorithm

Instead of randomly rotating every cell, rotate random cells such that initial and final state are not same and minimum moves to win is equal to shuffle limit.

Bug: 160470
Review: 109880
FIXED-IN: 4.10.3

Optimization

KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Split Outline in a composited and non-composited part

The non-composited part handles the showWithX case with the four small
windows. The composited part shows a translucent QWidget with the
FrameSvg as done by the selection effect frame.

Outline connects to the Compositor toggled signal to switch the mode if
compositing gets suspended/resumed. This works fine also in the case that
the switch happens while the outline is shown. To support this Outline
is now a QObject and created with Workspace as a parent.

Given that the Outline handles both cases by itself, the outline effect
is no longer needed and is dropped together with all the hooks into the
effect system.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 9ad383b...

Multimedia

Matěj Laitl committed changes in [amarok] /:

Cleaned up playlist multilevel sorting algorithm. Added album artist special case to playlist sorting.

It fixes an issue with two albums being merged on the playlist when they happen to have the same name, and sorting by album is enabled.
Originally thought to fix bug 271105, it actually fixes some other, but connected, one (see my comment https://bugs.kde.org/show_bug.cgi?id=271105#c10 ).

Thanks go to Konrad Zemek for the patch.

REVIEW: 110070

Utilities

Aleix Pol Gonzalez committed changes in [muon] discover/qml/Main.qml:

Small usability improvements in discover search feature

Delay search 200ms, so that we don't filter that often.
Don't filter for <2 elements, the proxy model will do it itself anyway.

Aleix Pol Gonzalez committed changes in [muon] /:

Optimize proxy filtering and search

Right now we were calling ResourcesModel::data() for every call when
filtering, now we fetch the resource and we operate on it.
Also when searching fetch QList<AbstractResource*> instead of a list of
package names. This is better because resource pointers are faster to deal
with: no need to see if it matches, comparison is faster too.

This leads to a ~50% optimization while searching (added QTimers to
ResourcesProxyModel::search()).

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 88b3a2d...

Other

KDE Base

Martin Gräßlin committed changes in [kde-workspace] /:

Split out Rules related code from Workspace into class RuleBook

Workspace is hardly interacting with Rules and all the Rules related code
is already in rules.cpp. This highly qualifies to move all the code out
of Workspace and improve the names.

REVIEW: 110207

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 2ff8de7...
Martin Gräßlin committed changes in [kde-workspace] /:

Move RootInfo and WinInfo into an own header and impl file

Main motivation for this change is that it's unhandy to have the class
definition in workspace.h and client.h while the implementation is in
events.cpp although nothing in events.cpp uses it directly.

By getting it out of workspace.h we get the header a little bit smaller
which should improve compile time given that it's included almost
everywhere.

In events.cpp the enum usage is changed to NETWinInfo as that's the class
where they are defined.

RootInfo does no longer hold a workspace pointer. Where it's needed it
uses the singleton accessor of Workspace.

REVIEW: 110199

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 3 more) Revision 45fdd33...

Multimedia

Nicolás Alvarez committed changes in [kde-ruleset] kdenetwork/kopete-rules:

Remove kopete plugin-javascript.

It didn't have any non-scripty commit since it was moved to playground.
If anyone still cares about it and wants to resurrect it,
we can convert it separately.