Issue 304

8th September 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Giacomo Barazzetti

This Week...

Marble adds integration with ownCloud, settings are available in Preferences. Calligra adds easy finishing to Path and Select Path tools, fixes loading of Scale and Rotate of the predefined brushes and other fixes. Dolphin prevents the interface freezes if there are many files inside the or the directory access is slow. KWin 4.11.2 improves memory footprint if color correction is disabled.

Statistics

Commits 1484 by 151 developers
Open Bugs 21318
Open Wishes 15976
Bugs Opened 273 in the last 7 days
Bugs Closed 253 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
117
 
/trunk/l10n-support
72
 
/branches/stable
41
 
/trunk/www
15
 
/staging/kservice
14
 
/plasma/desktop
14
 
/kservice/src
12
 
/krita/ui
11
 
/src/tests
10
 
/portage/win32libs
8
 
Files Developer Commits
366
 
Laurent Montel
138
 
201
 
Sayak Banerjee
72
 
183
 
Marco Martin
63
 
120
 
Kurt Hindenburg
43
 
114
 
Sebastian Kügler
40
 
117
 
Xavier Besnard
39
 
114
 
Sergio Luis Martins
38
 
108
 
Sven Brauch
36
 
84
 
Nico Kruber
28
 
69
 
Aleix Pol Gonzalez
24
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Ukrainian (uk)
100%
 
Swedish (sv)
99%
 
French (fr)
98%
 
Polish (pl)
98%
 
Spanish (es)
97%
 
Dutch (nl)
97%
 
German (de)
96%
 
Estonian (et)
94%
 
Italian (it)
92%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
34
 
Valentin Rusu
34
 
Christoph Feck
25
 
Thomas Lübking
12
 
Laurent Montel
9
 
Sergio Luis Martins
8
 
Andi Fischer
8
 
Eike Hein
8
 
Ralf Habacker
7
 
Frank Reininghaus
7
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]     

Educational

[] []    

Graphics

   []   

KDE Base

[] [] []   

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

[]   []   

Networking Tools

  []    

User Interface

  []    []

Utilities

[]   []   

Games

[]     

Other

[]     

There are 71 selections this week

Bug Fixes

Development Tools

Andi Fischer committed changes in [umbrello] /:

Fix broken entries in tree view (with cleanup of obsolete code)

Adding multiple items of the same type in the tree view resulted in broken
items. Fixed by calling createItem() directly when adding an object in
treeview. Renaming of items seems to work fine, in contrast to what the commit
message of 0d010aa states.

Andi Fischer committed changes in [umbrello] umbrello/widgets/umlwidget.cpp:

Fix moving and undo-moving a selection of widgets.

The current status of this issue in Umbrello 2.11.0 is almost right: it works as expected but undo works only for one of the selected items.
On master though, there seems to be some regression: moving 5 items 200 pixels will cause only 1 item to move to move - by 5*200 pixels!

Milian Wolff committed changes in [kdevplatform] plugins/projectfilter/projectfilterkcm.cpp:

Don't remove an item on Key_Delete when an editor is shown.

Educational

Dennis Nienhüser committed changes in [marble/KDE/4.11] /plugins/runner/monav:

Give a hint if monav-routing-daemon is not installed on the system.

(cherry-picked from commit bb5dff5)

FIXED-IN: 4.11.2

KDE Base

Christoph Feck committed changes in [kde-workspace/KDE/4.11] plasma/desktop/applets/tasks/support/textlabel.cpp:

Erase text outside boundingRect when text changes


FIXED-IN: 4.11.2
Ack'ed by Eike Hein

Sergio Luis Martins committed changes in [kde-runtime] /kcm:

Fix wording, the akonadi nepomuk feeder also indexes contacts.

Not only e-mail.

REVIEW: 112456

Eike Hein committed changes in [kde-runtime/KDE/4.11] plasma/declarativeimports/qtextracomponents/mouseeventlistener.cpp:

Discard the recorded events in the item-local handlers.

Solves problems with identical events being ignored due to
QGraphicsView's reuse of QGraphicsSceneMouseEvent instances.

Valentin Rusu committed changes in [kdelibs/frameworks] staging/kwallet/src/kwallet.cpp:

Fix the synchronous-mode wallet open logic



The wallet opening logic, for the synchronous mode, had a nested
event loops problem, leading to frozen kwalletd. That was because
kwalletd wasn't using qdbus delayed replies. kdelibs used
asynchronous open methods even for the synchronous mode, coupled
with an internal event loop to simulate synchronous mode.
This commit removes that internal event loop, as the kwalletd now
blocks on synchronous wallet open requests.

This commit has the same effect as f8fea3f01c85eb0d on kdelibs 4.11
but cherry-picking won't work because of KF5 source splitting. I just
redone it here.

Dawit Alemayehu committed changes in [kde-runtime/KDE/4.11] kioslave/smb/kio_smb_browse.cpp:

Mark files that end with '$' as hidden files in the UDS entry.


FIXED-IN: 4.11.1
REVIEW: 112529

Dawit Alemayehu committed changes in [kdelibs/KDE/4.11] kio/kio/job.cpp:

Set modified meta-data for all copy jobs, not just move operations.


REVIEW: 112528

Xuetian Weng committed changes in [kde-workspace/KDE/4.11] powerdevil/daemon/powerdevilcore.cpp:

Fix shutdown on critical battery level

powerdevil kcontrol and daemon doesn't use consistent value for
action, make them both use same enumeration is more desirable than
plain number.


FIXED-IN: 4.11.2
Reviewed By Weng Xuetian

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] /:

introduce GLTexture::clear and use it from paintredirector

also work around broken fbo texture clearing on fglrx

so far supports FBO/glClear and resorts to glTexSubImage2D

if the fbo cannot be created or is (in case of fglrx)
known to break, resort to glTexImage2D loading of an
argb array of zeros


FIXED-IN: 4.11.2
REVIEW: 112526

Eike Hein committed changes in [kde-workspace/KDE/4.11] plasma/desktop/applets/tasks/package/contents/ui/MouseHandler.qml:

Don't propagate drops to the containment while animating.

Plus a little cleanup in the drag move and leave code ...

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/effects.cpp:

copy and paste timebomb

bug as old as kwin compositing ....

FIXED-IN: 4.11.2
REVIEW: 112436

Martin Gräßlin committed changes in [kde-workspace/KDE/4.11] kwin/main.cpp:

Revert "Add ability to disable multihead support"

The variable is set not from config nor anywhere else when kwin is
started through ksmserver by startkde.

In addition the KGlobal implementation is twisted compared to the kcminit
config behavior (the config value defaults to true, not false - ie. if the
variable isn't set (by kcm init) it's reasonable to assume true either.

Therefore and in alignment with PW/2, the environment is read directly and
on absence resolved to "true".

To control the behavior, please export KDE_MULTIHEAD=true/false before starting KWin
(eg. in /usr/bin/startkde)

This reverts commit ab6d5c048a25bcb2f5bdb822ba3eda64019c61bc.

REVIEW: 112579

Christoph Feck committed changes in [kde-baseapps/KDE/4.11] dolphin/src/settings/serviceitemdelegate.cpp:

Fix color role of services list

Fixes the color of non-selected items to make them
readable with every color scheme.


FIXED-IN: 4.11.2
REVIEW: 112483

Martin Gräßlin committed changes in [kde-workspace/KDE/4.11] kwin/cursor.cpp:

Correctly detect mouseChanged between polls.

REVIEW: 112392

FIXED-IN: 4.11.2

Kurt Hindenburg committed changes in [konsole] src/TerminalCharacterDecoder.cpp:

Correct <span></span> in HTML output

Fix issue where HTML export has too many closing span tags in it.

Thanks to Martin Ueding for patch.

REVIEW: 112507

FIXED-IN: 4.12

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/effects/scalein/package/contents/code/main.js:

ignore minimized windows in scalein effect


FIXED-IN: 4.11.2
REVIEW: 112425

Frank Reininghaus committed changes in [kde-baseapps] /src:

Count the items inside directories in another thread

This prevents that the GUI freezes if there are many files inside the
directory, or if the access to the directory is slow for some other
reason.


REVIEW: 111920
FIXED-IN: 4.12.0

Vishesh Handa committed changes in [soprano/2.9] /virtuoso:

VirtuosoBackend: Automatic delete faulty transaction log if indicated by virtuoso

Sometimes the virtuoso transaction log gets corrupted, and the user is
told to delete the transaction log. Do that automatiacallly.

Simeon Bird committed changes in [nepomuk-core/KDE/4.11] services/fileindexer/indexer/epubextractor.cpp:

epubextractor: Fix crash on some invalid files where epub_get_data
returns an error.

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/manage.cpp:

no VD change for activation & unreasonable policy

F(S)UM mean "the focus is where the mouse is"
the mouse is not on the other virtual desktop
(and it was even granted regardless of the actual geometry/position)

The "unreasonable" focus policies expose an issue about
the present linked handling of "allow activation" and
"allow raising" (see https://git.reviewboard.kde.org/r/110919/ )

Activation would match "extreme" (if the window maps on the same
virtual desktop, half a mile away from the mouse, it won't
receive the focus) but not regarding raising (which is actually
an issue entirely different from FSP)

REVIEW: 112585

Emmanuel Pescosta committed changes in [kde-baseapps/KDE/4.11] /src:

Fix Bug 296970 - split view wrong behavior with search tab

Implemented setActive(bool active), isActive() and activated() signal
for DolphinSearchBox - similar to the KUrlNavigator implementation.


FIXED-IN: 4.11.2
REVIEW: 112534

KDE-PIM

Jan Kundrát committed changes in [trojita] src/Gui/Window.cpp:

Do not quit application on last closed window when running in systray


REVIEW: 112515

Laurent Montel committed changes in [kdepim/KDE/4.11] kaddressbook/xxport/vcard/vcard_xxport.cpp:

fix Bug 324141 - KAddressBook's default export method seems to be a seperate vcard for each contact.

FIXED-IN: 4.11.2

Laurent Montel committed changes in [kdepim/KDE/4.11] messageviewer/scamdetection/scamdetection.cpp:

Fix Bug 324103 - scam detection does not ignore missing protocol

FIXED-IN: 4.11.2

Laurent Montel committed changes in [kdepim] /:

Fix Bug 125361 Make "Automatically sign messages" a per identity setting

FIXED-IN: 4.12

Laurent Montel committed changes in [kdepimlibs/KDE/4.11] /contact/editor:

Fix Bug 324462 - Calendar input field ignores date in text field

FIXED-IN: 4.11.2

Jan Kundrát committed changes in [trojita] src/Imap/Model/Model.cpp:

Model: emit messageCountPossiblyChanged when periodically invalidating the message counts

The code which takes care of periodically refreshing the view of mailboxes emits
dataChanged() whenever it invalidates the cached message counts for a particular
mailbox. The systray code was, however, only listening to the
messageCountPossiblyChanged signal. During normal operation, this is not an
issue because the GUI's views would intercept the dataChanged and ask for the
actual data, which triggers an IMAP STATUS which in turn updates the message
counts and systray therefore notices that the numbers might have changed.
However, when the views are hidden for some reason, this process does not happen
and the systray icon is not updated.


REVIEW: 112474

Sergio Luis Martins committed changes in [kdepim] /agenda:

Don't show duplicated events.

Listen to UID changes and refresh the view when that happens.


FIXED-IN: 4.12

Laurent Montel committed changes in [kdepim] /:

Fix Bug 324419 - strings from grantleetheme* libs are untranslated in the GUI

Patch from Burkhard Lueck


FIXED-IN: 4.12

David Edmundson committed changes in [ktp-common-internals] KTp/Models/abstract-grouping-proxy-model.cpp:

Fix crash in AbstractGroupingModel when used in a tree

When removing a proxy item, remove children of that item from the proxy map


REVIEW: 112430

Laurent Montel committed changes in [kdepim/KDE/4.11] korganizer/calendarview.cpp:

Fix Bug 324493 - Kontact crashed after trying to export as WebSite

FIXED-IN: 4.11.2

Sergio Luis Martins committed changes in [kdepim/KDE/4.11] incidenceeditor-ng/alarmdialog.cpp:

Fix the alarm dialog when the to-do doesn't have DTSTART

This code made no sense, probably was never tested?

Sergio Luis Martins committed changes in [kdepim/KDE/4.11] calendarviews/agenda/agendaview.cpp:

agendaview: Fix calculation of duration when using other timezones.

David Edmundson committed changes in [libkpeople] src/personsmodel.cpp:

emit dataChanged() on person item when adding/removing rows


REVIEWED-BY: Aleix Pol

Laurent Montel committed changes in [kdepimlibs/KDE/4.11] /contact/editor:

Fix Bug 323717 - Creating a new category for a contact creates a duplicate entry when re-editing contact categories

FIXED-IN: 4.11.2

Office

Dmitry Kazakov committed changes in [calligra] /ui/widgets:

Fix the bug with flipping Multipliers of the Slider Spinbox

Dmitry Kazakov committed changes in [calligra] /plugins/paintops/libpaintop:

Fix the initial brush size value for the Clipboard Brush

Now the size of the brush is calculated dynamically basing on the real
content of the brush. That fixes some fall-backs in the Clipboard Brush.

Dmitry Kazakov committed changes in [calligra] /plugins/paintops/libbrush:

Fixed loading of Scale and Rotate of the predefined brushes

This patch also removes a significant portion of outdated code.

Dmitry Kazakov committed changes in [calligra] krita/plugins/paintops/libpaintop/kis_brush_selection_widget.cpp:

Fixed the initial resize of the Custom and Clipboard brushes

Stephane Mankowski committed changes in [skrooge/Feature] /:

Crash importing KmyMoney exported file from Skrooge

Christer Stenbrenden committed changes in [calligra] /:

Fill ignores layer alpha lock

Using either of Edit->Fill witch {Background color, Foreground Color,
Pattern} ignored the layer's alpha lock state. The fill tool's code
is now used by this action, so proper functionality is restored.

Jarosław Staniek committed changes in [calligra] libs/db/tableviewdata.cpp:

Fix sorting error in table views

The sorting was broken when NULL values are compared with text for text columns


FIXED-IN:2.7.3

Dmitry Kazakov committed changes in [calligra] krita/plugins/paintops/libpaintop/kis_brush_option.cpp:

Fixed false marking brush presets as invalid

The property should be *always* written

Dmitry Kazakov committed changes in [calligra] /plugins/paintops/libpaintop:

Changed parameter Scale to Size for predefined brushes

It has a few benefits:

1) It is easier for painters to operate with size than with scale
2) There is no cross-rounding problems between Scale and Size sliders.
The existence of the Scale slider caused the values of the Size slider
to be inexact.
3) Now there is a special 'Reset Brush' button that resets the scale of
the brush to 1.0 and reloads other values.

,318940

Dmitry Kazakov committed changes in [calligra] /ui:

A proper fix for the not-saved Move Tool action when it is saved while the stroke is active

This patch uses more accurate way of locking the image:

o When the autosave is happening and the document cannot lock the image,
the document sets the autosave interval to 10s to catch the nearest
moment when there is no stroke active

o When the usual saving is happening, the document first requests the end
of the current stroke, then tries to lock the image again

Multimedia

Mark Kretschmann committed changes in [amarok] src/context/widgets/TextScrollingWidget.cpp:

Don't suppress html tag like characters.

Example: "MY<DSMBR" by Linkin Park was shown as "MY".

Michael Pyne committed changes in [juk/KDE/4.11] /:

scrobbler: Change Scrobbler owner to be JuK, not PlayerManager.

PlayerManager will always emit a track changed signal, which means the
Scrobbler will always have to receive it even if we're not scrobbling
(my last change to avoid making network requests when not using last.fm
broke this, it seems).

Instead move the Scrobbler into the base application class where we can
track whether scrobbling is enabled or not, and Do the Right Thing. I
don't have a last.fm account so although this should still work (I
think), I can't verify. I have verified that we at least don't crash
anymore. Martin, can you double-check when you get a chance?

FIXED-IN:4.11.2

Richard Lärkäng committed changes in [audiocd-kio] /:

Fix Ogg/Vorbis support because HAVE_VORBIS is no longer set to 2
(since as far as I can see, the change to cmake)
See http://lists.kde.org/?l=kde-multimedia&m=134903246822765

Based on patches by the following people




FIXED-IN: 4.11.1

Utilities

Christoph Feck committed changes in [kremotecontrol/KDE/4.11] /:

Fix crash in kremotecontrol KCM

Common Qt4 porting regression: current != selected


FIXED-IN: 4.11.2

Valentin Rusu committed changes in [kwallet] src/manager/walletcontrolwidget.cpp:

Adjust WalletControlWidget::onSetupWidget logic



KWalletManager should also have access to a wallet. However, cases
may be found when open operation fail. Trace it at go to a known
state, where the user should click the "open" button to re-attempt
the operation later.

Valentin Rusu committed changes in [kwallet] /manager:

Restore the wallet_open scrpipting slot



The UI refactor left a TODO item for this and seems people is using
it, so here is it :)

Michel Ludwig committed changes in [kile] src/livepreview.cpp:

Fix the reloading of the document after live preview compilations

Thanks to Eugene Shalygin for suggesting the fix!

Sven Brauch committed changes in [kte-collaborative] /:

Games

Ashwin Rajeev committed changes in [knetwalk/ashwin] /qml:

Fix animations

Remove animation of change in selection.
Improve rotation animation.
Cleanup the code (rename variables, use alias).

Other

Rajko Albrecht committed changes in [kdesvn] src/svnqt/path.cpp:

Kdesvn will not crash with an assert when users have pathnames with @

But subversion will never display any content of such files or folder, you can test it with the command line.

(Tested against subversion 1.7.x)

Features

Educational

Andrei Duma committed changes in [marble] /:

Added ownCloud settings to Preferences

Diffs: 1, 2, 3, 4, 5 Revision 8f335d7...

KDE Base

Marco Martin committed changes in [kde-workspace/frameworks-scratch] /generic/containmentactions:

port applauncher menu to plasma2

Diffs: 1, 2, 3, 4, 5 Revision a11e8a7...

KDE-PIM

David Edmundson committed changes in [ktp-common-internals] /:

Add kpeople plugin to show IM contacts in show details view

REVIEW: 112549

Office

Dmitry Kazakov committed changes in [calligra] /:

Added easy finishing to Path and Select Path tools

Now you can finish the path:
1) By double clicking on the canvas
2) By clicking on the first point
3) By pressing Enter key
4) By Shift + Click

You can cancel the path:
1) By pressing Esc key


REVIEW:112405

Networking Tools

David Edmundson committed changes in [ktp-contact-list] contact-list-widget.cpp:

Allow drag + drop contacts with people


REVIEW: 112452

David Edmundson committed changes in [ktp-contact-list] /:

Enable Merge Contact Dialog in kpeople mode


REVIEW: 112427

User Interface

Ivan Čukić committed changes in [plasma-framework] /:

Added support for shell switching

Optimization

Graphics

Marcel Wiesweg committed changes in [digikam] /album:

The DAlbums scan can be costly for some setup as it sends large amounts of data over the SQL connection.
- reduce the timer limit to one minute
- do not kill the running job if the timer fired again while the job was running.

KDE Base

Martin Gräßlin committed changes in [kde-workspace/KDE/4.11] /:

Only create ColorCorrection if it is enabled in the options

According to massif just creating the ColorCorrection costs 2 MiB, so
it makes sense to not create it if it is not used.

REVIEW: 111604
DIGEST: Smaller memory footprint in KWin 4.11.2 if color correction is disabled

Sebastian Kügler committed changes in [kde-workspace/frameworks-scratch] /generic/applets/digital_clock:

improve sizing

- more sensible default size
- make font depend on width and height
- do not compare pixels (main dimensions) with points, use
font.pixelSize
- Fix name in metadata

Multimedia

Mark Kretschmann committed changes in [amarok] /playlist:

Sync playlist search config instantly.

Utilities

Marcel Wiesweg committed changes in [digikam] digikam/utils/contextmenuhelper.cpp:

I believe this performance check ended with the wrong result of cutting
the feature instead of cutting "intelligent" checks.
If >250 images are selected, do not check if they have tags - that may be costly - but simply
leave the action enabled.

Other

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk] src/oxygenapplicationname.cpp: