Issue 307

29th September 2013 by KDE Commit-Digest Team


Marta Rybczynska
Giacomo Barazzetti

This Week...

KDevelop adds a new tool: RegistersView. In KDE-PIM, KMail gains adblock support. Krita adds an option to hide preset strip and/or scratchpad; improves memory efficiency and conversions. Porting to KDE Frameworks and Plasma2 still in progress, this it includes the icon applet; porting to Qt 5 is also in progress for the KCM modules. Work in progress in on systemtray 2.


Commits 1755 by 154 developers
Open Bugs 21076
Open Wishes 15884
Bugs Opened 226 in the last 7 days
Bugs Closed 315 in the last 7 days

Commit Summary

Module Commits
Files Developer Commits
Laurent Montel
Aaron J. Seigo
Marco Martin
Sergio Luis Martins
Wolfgang Rohdewald
David Edmundson
Stephen Kelly
Yuri Chornoivan
Martin Gräßlin
Boudewijn Rempt

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
Brazilian Portuguese (pt_BR)
Swedish (sv)
French (fr)
Polish (pl)
Dutch (nl)
Spanish (es)
German (de)
Estonian (et)
Galician (gl)

Bug Killers

Person Bugs Closed
Jekyll Wu
Boudewijn Rempt
Christoph Feck
Thomas Lübking
Laurent Montel
Aleix Pol Gonzalez
Julian Seward
Andi Fischer
Sergio Luis Martins
Sven Langkamp

Commit Countries

Commit Demographics




  Bug Fixes Features Optimization Security Other



Development Tools

[] []    




[] []    

KDE Base

[] []    []


[] [] []   


[] [] []   []





Networking Tools

[] []    

User Interface



[] []    []





There are 77 selections this week

Bug Fixes

Development Tools

Ralf Habacker committed changes in [umbrello] /:

Cleanup of mime type detection when exporting bitmaps.

The usage of KDE4's KFileDialog::currentMimeFilter() is broken,
because it returns a list of the currently selected file type.
In the opposite the code expects a single mime type of the selected file.

Milian Wolff committed changes in [kdevplatform] plugins/projectfilter/filter.cpp:

Use default filter set also when the user has an old Filters config.

We do not convert the old Excludes/Includes rules though, as one would
need to merge the rules with the new defaults which is too much hassle.

Andi Fischer committed changes in [umbrello] /dialogs:

Fix crash when adding entity constraints

The root cause of this crash is not checking for a valid index when retrieving
the item from the QList. We should at least check that value before calling at().

The patch I propose adds this check and also fixes the problem causing the
index to be wrong in the first place (like Arash Abedinzadeh described).


Gilles Caulier committed changes in [digikam] utilities/imageeditor/core/undocache.cpp:

add free space check when Editor action is performed to undo/redo cache mechanism.
We check if at least 1 Gb is avaialble, which can be enough to play with photography

FIXED-IN: 3.5.0

KDE Base

Bernd Buschinski committed changes in [kdelibs/KDE/4.11] khtml/ecma/kjs_data.h:

khtml/ecma: Protect the value in DelayedPostMessage, the "gc" might clean it before we use it

I hope this fixes Bug 264526, but the lack of a 100% reproduceable testcase makes it difficult to confirm.

Lamarque Souza committed changes in [kdelibs/KDE/4.11] solid/solid/backends/udev/udevnetworkinterface.cpp:

Do not leak sockets in NetworkInterface::isWireless().

REVIEW: 112869
FIXED-IN: 4.11.2

Kurt Hindenburg committed changes in [kdelibs/KDE/4.11] mimetypes/kde.xml:

media type application/x-konsole is unsupported

remove "application/x-konsole"

Patch/research by Jekyll Wu - "ship it" from David Faure

REVIEW: 107167#
FIXED-IN: 4.11.2
(cherry picked from commit a6a76fcc3768417e855a8e384aad71dec44bfc83)

Eike Hein committed changes in [kde-workspace/KDE/4.11] /desktop/applets/tasks:

Fix calculation for "group only when full".

* Fixes potentially miscalculating the threshold with "Force
Rows" enabled.
* Fixes potentially being left with a stale threshold in the
group manager due to a race condition between reacting to
an applet geometry change and recalculating the threshold.
* The calculated threshold was generally off by one thanks to
misinterpreting the libtaskmanager API naming.

Valentin Rusu committed changes in [kde-runtime] /:

Add a KDE notification when wallet sync to disk fails

FIXED-IN: 4.12

This does not really fixes the bug, as I'm not able to reproduce it
and never happened on my system. However, KSaveFile's logic may fail
and kwalletd did not took that into account. When such a failure
occurred, kwalletd silently ignored the errors. This fixes that and
adds a system notification to let the user know that something is
wrong with the disk (disk full, r/W error, etc.)

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/effects/fade/package/contents/code/main.js:

workaround bug #321897 by multiplying fadeout time

with 4 instead of just altering the default value
It seems the value is actually written for some ppl.

Worse: former patch didn't actually work as expected


Laurent Montel committed changes in [kdepim/KDE/4.11] messageviewer/viewer/viewer_p.cpp:

Fix Bug 325354 - KMail-Kontact crashed on switching e-mail to html read mode

FIXED-IN: 4.11.3

David Edmundson committed changes in [ktp-common-internals] /nepomuk-feeder:

Remove contacts from Nepomuk when removed from Tp.

Also fix adding contacts at runtime


Laurent Montel committed changes in [kdepim-runtime] /newmailnotifier:

Fix Bug 289500 - New Mail Arrived notification Kmail + Jovie Speech customizing

FIXED-IN: 4.12

André Wöbbeking committed changes in [kdepim-runtime/KDE/4.11] /imap:

Don't bother IMAP servers with not supported flags

Created a new method ResourceTask::fromAkonadiToSupportedImapFlags() to convert
Akonadi to IMAP flags supported by the server and use it everywhere instead of

fromAkonadiFlags() was made private to make it impossible to call it by accident.

FIXED-IN: 4.11.3

This also reduces the risk to trigger 287356 as the insert on the IMAP server
doesn't fail due to unsupported IMAP flags.

Dan Vratil committed changes in [kdepim-runtime/KDE/4.11] /imap:

Fix support for IMAP servers with non-standard path separators

REVIEW: 112761

FIXED-IN: 4.11.2

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision ed7a89a...


Boudewijn Rempt committed changes in [calligra] krita/image/

Don't assert if there are multiple local selection masks

Dmitry Kazakov committed changes in [calligra] krita/image/kis_base_node.cpp:

The copy constructor should also initialize the member variables ;)

The systemLocked variable was not initialized properly.

Boudewijn Rempt committed changes in [calligra] /:

Fix outline cursor

The outline cursor now listens to rotation and size again, plus there's
an option to show a small dot in the middle of the outline.

Boudewijn Rempt committed changes in [calligra] krita/ui/tool/

Do not show outline in selection tools

Stephane Mankowski committed changes in [skrooge] /:

Crash when exiting skrooge
(I am not sure of the correction because I am not able to reproduce. Reopen this incident if your are still able to reproduce it.)

Sven Langkamp committed changes in [calligra] krita/plugins/tools/tool_text/

fix text shape position when inserted by the text tool
Based on patch by Annarosa Agarossi

Valentin Rusu committed changes in [kwallet] src/manager/kwalleteditor.cpp:

Make the "show values" sticky

FIXED-IN: 4.12

Boudewijn Rempt committed changes in [calligra] krita/plugins/extensions/dockers/artisticcolorselector/kis_color_selector.cpp:

Artistic color selector: update selected color while moving around

Stephane Mankowski committed changes in [skrooge] /:

Importing from gnucash file doesn't import accounts fo types 'Mutual Fund' nor 'Credit Card'

Signed-off-by: Stephane Mankowski

Boudewijn Rempt committed changes in [calligra] krita/ui/tool/

Fix layer lock after exposure change

This bug was around since at least 2008, probably earlier!

Sven Langkamp committed changes in [calligra] libs/flake/KoToolManager.cpp:

workaround for weird ui behaviour using scroll wheel while hovering over brush settings editor
patch by Tom Hall

Stephane Mankowski committed changes in [skrooge] /:

Erreur when importing .mny file whith 1.7.6BETA. Error when analysing categories.json

Boudewijn Rempt committed changes in [calligra] krita/plugins/formats/psd/psd_resource_section.cpp:

PSD: Do not halt on misformed resource blocks


Harald Sitter committed changes in [phonon-gstreamer] gstreamer/medianode.cpp:

assert when we have no tee in an A/V medianode

theory right now is that gstreamer is kaput and fails to factorize the
tee, outside MN nothing accesses the tee so the only way it could become
0x0 (assuming correct construction) is destruction. however since objects
are destructed through the main thread threading problems ought not be the
issue here.

At the very least we'll have an explicit assert so the casual code reader
knows what is going wrong.

Networking Tools

Lamarque Souza committed changes in [networkmanagement/nm09] /:

Fix signalQualityChanged and accessTechnologyChanged signals.


David Edmundson committed changes in [ktp-auth-handler/kde-telepathy-0.7] tls-cert-verifier-op.cpp:

Check for QCA certificate availability at run time.

This fixes a crash if packagers don't include qca-ossl a runtime
plugin for QCA needed to load SSL Certs.

Note this introduces a new string inside the feature freeze

Reviewed-by: David Edmundson


Jan Lepper committed changes in [krusader] /:

FIXED: [ 206926 ] Search doesn't work in sftp session (it returns too many results)

Jan Lepper committed changes in [krusader] /:

FIXED: [ 269542 ] Krusader search - Containing text still used when disabled

Aleix Pol Gonzalez committed changes in [muon/2.1] discover/qml/ApplicationOverview.qml:

Don't show the screenshot if it's not ready

Otherwise there are some painting glitches that aren't that fun. Most
likely influenced by some bug in QtQuick.

Aleix Pol Gonzalez committed changes in [muon/2.1] libmuon/backends/ApplicationBackend/ApplicationBackend.cpp:

Make sure that the search doesn't happen while fetching

It can cause crashes in QApt.

Jonathan Marten committed changes in [polkit-kde-kcmodules-1] /:

Show a diagnostic message if reading policies fails.

The settings displayed will not be meaningful in this case, but
at least it avoids a fatal assert within Qt.


Jan Lepper committed changes in [krusader] /:

FIXED: [ 324737 ] symlinks with a target path length of over 255 do not work


Development Tools

Heinz Wiesinger committed changes in [kdev-php] /:

Add support for Trait declarations, as introduced in PHP 5.4.

REVIEW: 112917

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision d87cd7d...
Vlas Puhov committed changes in [kdevelop] /:
Aleix Pol Gonzalez committed changes in [kdevelop] projectmanagers/cmake/parser/cmakeprojectvisitor.cpp:

Make it possible to glob directories

It should have worked as well with directories, not closing the bug since
[.*] is still unsupported.
We'll have to write a wildcard to regular expression conversor eventually
since QRegularExpression (in Qt5) doesn't support wildcards anyway.

Andi Fischer committed changes in [umbrello] /:

Documentation info label added to DocWindow. It shows type, name and
flag whether documentation is modified.
Removed unnecessary includes of docwindow.h to reduce dependency


Yuri Chornoivan committed changes in [parley/KDE/4.11] plugins/

Adopt Google images plugin to the new Google images search page

REVIEW: 112285


Fabio D'Urso committed changes in [okular] part.cpp:

Show table of contents in sidebar on startup (if present)

FIXED-IN: 4.12.0
REVIEW: 111036

KDE Base

Sebastian Kügler committed changes in [kde-workspace] /generic/applets:

Clean start for systemtray 2

Salvaging the necessary bits one by one from the old system tray makes
more sense, as the whole architecture has to be redone anyway. This
builds an empty plugin and contains an empty

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 7e9fe48...


Laurent Montel committed changes in [kdepim] /:

Add adblock settings

Diffs: 1, 2, 3 Revision b23fcfb...
Sergio Luis Martins committed changes in [kdepimlibs] /calendar:

Adjust recurrence parameters when moving events.

This is a long awaited feature.
For now it's only implemented for weekly recurrence, other types
have lots of corner cases.

Laurent Montel committed changes in [kdepim] /:

Add more adblock support

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 10 more) Revision fc00dcf...
Laurent Montel committed changes in [kdepim] /:

Implement widget to select several collection

Laurent Montel committed changes in [kdepim] /adblock:

Activate adblock

Laurent Montel committed changes in [kdepim] /:

Start to add adblock support

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 289ecd2...


Boudewijn Rempt committed changes in [calligra] /ui:

Allow the check colors to be configured independently

And make opengl canvas update the check texture when the config changes.

Boudewijn Rempt committed changes in [calligra] krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp:

Disable opacity and composite op controls for masks

These don't make sense for masks, so in the previous code, we'd set the
opacity and composite op to the one set on the layer, leading to

Cristian Oneț committed changes in [kmymoney] /:

Improve the column sizes auto adjustment of the register when the
transaction form is disabled and the register is in read only mode.
This improves register column sizes in the Payee, Tags views and in
the transaction search and autofill dialogs.

REVIEW: 112971

Boudewijn Rempt committed changes in [calligra] /ui/opengl:

Make it possible to have checks smaller than 32x32 in the opengl canvas

Boudewijn Rempt committed changes in [calligra] /ui:

Add the filter name to the filter layer or filter mask name

This restores functionality written by Melchior Franz in 2006 which
unaccountably got lost in the mists of time... From the code, it looks
like blockSignals hadn't been invented back then, so it's also a small

Sven Langkamp committed changes in [calligra] /ui:

move color darkness and opacity controls to a new canvas controls manager, making them available globally

Boudewijn Rempt committed changes in [calligra] krita/ui/actions/kis_selection_action_factories.cpp:

Make it possible to copy the projection of a group layer

Sven Langkamp committed changes in [calligra] /ui:

add option to hide preset strip and/or scratchpad

Cristian Oneț committed changes in [kmymoney] /:

Add a configuration option that allows the user to choose between
reusing or not the memos of a previous transaction when autofilling.

REVIEW: 112924

Sven Langkamp committed changes in [calligra] krita/plugins/extensions/dockers/advancedcolorselector/kis_shade_selector_line.cpp:

Networking Tools

Jan Grulich committed changes in [libnm-qt] manager.cpp:


Aleix Pol Gonzalez committed changes in [muon/2.1] libmuon/backends/BodegaBackend/BodegaBackend.cpp:

Add a bit more context on the credentials dialog for MakePlayLive

Aleix Pol Gonzalez committed changes in [muon/2.1] discover/qml/SourcesPage.qml:

Make the add source dialog adaptable to the height of its contents

Solves bug where part of the interface would be cut somehow.

Casian Andrei committed changes in [kolor-manager/kded] /:

Implement the transfer of the color lookup tables via shared memory

A shared memory pool is created to hold all the known color lookup
tables, in sequence. It is like a vector of the tables, in shared
memory. The color lookup tables are registered in the pool and they
become available for the clients.

The clients just need the key for the shared memory segment, and the
indices for the required color lookup tables.

This method of communication should provide a significant performance
boost, without using resources.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 17d2c5a...


Roney Gomes committed changes in [kbounce/keyboard-integration] /:

Enabled user defined key shortcuts.

The previous updates were reworked so now the game allows a player to
defined a custom set of keys to perfom each mouse action supported.

This commit contains a few modifications done by me, but the core work
has been entirely done by Season of KDE's participant Anuj Pahuja.

My modifications are basically a few refinements done to Anuj's work.
What I did:

1. Moved a #include<KAction> from gamewidget.h to gamewidget.cpp.

2. Renamed bindKeys()'s parameter to keyShortcuts. The previous
name denoted a private local pointer used in KBlocks, where all
this code derived from.

3. moveLeft(), moveRight() etc. were renamed to moveCursorLeft(),
moveCursorRight() and so on -- a more meaningful name in
KBounceGameWidget's context.

4. setCursorPosition() was reworked to include more conditions to
move the cursor, which simplified and reduced a few lines from
all moveCursor methods.

5. The methods needed for rotating the cursor and building the wall
were mixed into a single method. This way code duplication is
avoided and a more elegant sollution applied.

Diffs: 1, 2, 3 Revision 8158f09...


Albert Vaca Cintora committed changes in [kdeconnect-android/filetransfer] /src/main:

Added multi-file transfer and query for filename and file size

Diffs: 1, 2, 3, 4 Revision 37c2a0e...



David Edmundson committed changes in [ktp-common-internals] KTp/Models/abstract-grouping-proxy-model.cpp:

Simplify model index looping in AbstractGroupingProxyModel::onDataChanged();

REVIEW: 112887

Christian Mollekopf committed changes in [kdepimlibs] /calendar:

Async checking of fbobjects to validate url.

REVIEW: 112925


Lukáš Tvrdý committed changes in [calligra] /plugins/extensions/gmic:

Improve memory efficiency and improve conversions

o use KisRandomAccessorNG instead of read/writePlanarBytes
This improves memory efficiecy and it is also much faster/reliable
o simplify KisGmicSimpleConvertor
o add benchmarks/tests related to gmic:
- conversion between pixel formats (gmic->QImage, gmic->KisPaintDevice)
- conversion between Krita colorspace: rgba 8 bit -> rgba 32 bit float
(takes around 10 seconds for 4096x4096 picture)
o whitelist more filters due to this improvements!

Automatic testing:
Curent status of gmic filters in Krita:
- total filters: 260
- known failings (blacklisted filters): 15
- known success: 245

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision b615a80...


KDE Base

Bhushan Shah committed changes in [kde-workspace/frameworks-scratch] /generic/applets:

Port icon applet to Plasma2
REVIEW: 112888

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 86473b9...
Martin Gräßlin committed changes in [kde-workspace] CMakeLists.txt:

Welcome back systemsettings!

Martin Gräßlin committed changes in [kde-workspace] /hardware/display:

Port display KCM to Qt 5

Diffs: 1, 2, 3 Revision 5b3c473...
Martin Gräßlin committed changes in [kde-workspace] /:

Welcome back the first KControl modules!

Martin Gräßlin committed changes in [kde-workspace] /kcmkwin/kwindesktop:

Port KCMDesktop to Qt 5

Diffs: 1, 2, 3, 4, 5 Revision e387513...
Martin Gräßlin committed changes in [kde-workspace] /hardware/joystick:

Port joystick KCM to Qt 5

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision c5f21db...


Boudewijn Rempt committed changes in [calligra] krita/image/

Add links to two bugs for documentation purposes.

These bugs explain the dilemma of which blending mode to make
default for filter layers.


Aleix Pol Gonzalez committed changes in [muon/2.1] /qml:

Remove the root pages cache

It was doing weird things and didn't add that much speed anyway.