Issue 309

13th October 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Giacomo Barazzetti

This Week...

KDE Telepathy adds an ability to edit the name of your favourite chat rooms for quick joining. In Skrooge, operations can be split by date. Kooka does image transformations in a background thread to reduce wait time. Okular supports more transformations, including the ones dictated by Exif metadata. Bug fixes in KDevelop, Dolphin, KMail.

Statistics

Commits 1404 by 121 developers
Open Bugs 21126
Open Wishes 15890
Bugs Opened 228 in the last 7 days
Bugs Closed 229 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
148
 
/branches/stable
50
 
/trunk/l10n-support
41
 
/akonadi/calendar
14
 
/views/home.jade
12
 
/tags/tagsmanager
12
 
/krita/ui
11
 
/trunk/www
10
 
/kcontrol/colors
9
 
/daemon/kded
9
 
Files Developer Commits
483
 
Laurent Montel
178
 
324
 
Sebastian Kügler
108
 
198
 
Marco Martin
66
 
144
 
Aaron J. Seigo
48
 
129
 
Stephen Kelly
43
 
117
 
Yuri Chornoivan
39
 
102
 
Dan Vratil
34
 
99
 
Aleix Pol Gonzalez
33
 
96
 
Gilles Caulier
32
 
72
 
Cornelius Schumacher
28
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Ukrainian (uk)
100%
 
Swedish (sv)
99%
 
Polish (pl)
98%
 
French (fr)
98%
 
German (de)
97%
 
Dutch (nl)
97%
 
Spanish (es)
97%
 
Estonian (et)
94%
 
Italian (it)
91%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
61
 
Laurent Montel
18
 
Thomas Lübking
18
 
Christoph Feck
16
 
Frank Reininghaus
16
 
Boudewijn Rempt
11
 
Sergio Luis Martins
9
 
Andi Fischer
8
 
Myriam Schweingruber
7
 
David Edmundson
7
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

  []    

Graphics

[] [] []   

KDE Base

[] [] []   

KDE-PIM

[] []    

Office

[] []    

Konqueror

     

Multimedia

[]     

Networking Tools

[] [] []   

User Interface

     

Utilities

[]     

Games

     

Other

     

There are 62 selections this week

Bug Fixes

Development Tools

Kevin Funk committed changes in [kdevelop] /:

Patch for bug 274301

Arrangement of items in "Navigation" menu not well structured (kdevelop)
Separated the options group wise in Navigation menu by modifying the corresponding rc files.

Milian Wolff committed changes in [kdevelop/4.5] /cpp:

do not offer explicitely deleted methods for code completion



Again basically done by Milian.

Aleix Pol Gonzalez committed changes in [kdevplatform] plugins/projectmanagerview/projectmanagerviewplugin.cpp:

Don't store pointers ProjectBaseItem in classes

They could be deleted before used. Store the model index instead.

Andi Fischer committed changes in [umbrello] /codegenwizard:

Resizing of code generation wizard pages improved.

Aleix Pol Gonzalez committed changes in [kdevplatform] vcs/vcspluginhelper.cpp:
Aleix Pol Gonzalez committed changes in [kdevelop] /cmake:

Don't crash when a broken add_executable is found

Aleix Pol Gonzalez committed changes in [kdevplatform] shell/runcontroller.cpp:

Remove unused Run > profile menu entry

Currently we had the menu entry but nobody using it. Technically it's
correct because whenever we'd get a profiler it would work automatically
but I'd say that also having the option but not being able to use
it is nothing but frustrating.

Commenting out the code until somebody puts some care into profiling
integration.

Albert Astals Cid committed changes in [plasmate] plasmate/mainwindow.cpp:

Checks if an optional field was instantiated before accessing it

The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not.

This was laying around in reviewboard approved by Giorgos Tsiapaliokas but uncommited for 5 months

REVIEW: 110288

Rolf Eike Beer committed changes in [kdevelop/4.5] /cpp:

do not insert spaces in function definition after void or type with no argument name



Hint: basically done by Milian to trick me into being able to fix some of my
problems myself later.

Graphics

Jonathan Marten committed changes in [kooka] /:

Error message before scan for unsupported depth/colour combinations

KDE Base

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] /effects/showfps:
Frank Reininghaus committed changes in [kde-baseapps/KDE/4.11] /src:

Include "Space" in the keyboard search string

Before this commit, we only added pressed keys to the search string if
they have no other meaning. This means that files containing a Space in
their name could not be searched because Ctrl+Space toggles the
selection state of the current item, and Space alone selects the
current item.

After this commit, Space is added to the search string if

(a) the key press did not have any other effect, i.e., if Ctrl was not
pressed, and the current item is selected already, and
(b) a keyboard search has been started already (to prevent unexpected
effects when pressing Space accidentally - I think that it's rather
uncommon to have files whose names start with a Space - and to make
the unit test simpler).

I modified the unit test of KItemListController, which did not test
keyboard search yet. This uncovered a small problem in
KItemListController::slotChangeCurrentItem() when NoSelection mode is
used. It's not really relevant for anything that is executed inside
Dolphin, but I still fixed it to make the unit test happy.


FIXED-IN: 4.11.3
REVIEW: 113071

Dawit Alemayehu committed changes in [kde-baseapps/KDE/4.11] konqueror/settings/kio/kproxydlg.cpp:

Make sure clicking reset works under every circumstance.


FIXED-IN: 4.11.3

Vishesh Handa committed changes in [kdelibs] kio/kfile/kpropertiesdialog.cpp:

KPropertiesDialog: Do not show the KFileMetaDataWidget

The KFileMetaDataWidget uses Nepomuk1 which is deprecated and is buggy.
It would be better for people to use the Nepomuk2::FileMetaDataWidget.

This mostly only affect Dolphin where users can tag files via the
Information Panel and via File->Properties. This removes the widget in
the File->Properties


REVIEW: 113190

Laurent Montel committed changes in [kdeplasma-addons/KDE/4.11] applets/leavenote/leavenote.cpp:

Fix Bug 321304 - Leave A Note widget: When note is delivered, blank note also appears

FIXED-IN: 4.11.3

Wolfgang Bauer committed changes in [kde-workspace/KDE/4.11] plasma/desktop/applets/trash/trash.cpp:

Fix click on trash plasmoid when on desktop and widgets are unlocked

Don't register the icon as a draggable with the applet.

This causes events to be intercepted which prevents launching the file
manager when the applet is movable.

FIXED-IN: 4.11.3
REVIEW: 113127

Frank Reininghaus committed changes in [kde-baseapps] /src:

Make the code that removes items from KFileItemModel more robust

When we remove items from the model, we called the function
KFileItemModel::removeItems(const KFileItemList&, RemoveItemsBehavior).
This function then looked up the indexes of the items using the hash
m_items. This is wasteful in the situations when the indexes of the
removed items are known in advance (like when an expanded folder is
collapsed in Details View), and it can cause trouble if one item is
contained in the model multiple times (can happen when searching, and a
file both matches the search and is a child of a folder that matches
the search). Even if expanding folders in the search results list might
not be particularly useful most of the time, it makes sense to make the
model more robust to prevent crashes and other unexpected behavior in
such situations.

This patch makes the following changes to achieve that goal:

* Change the argument of removeItems() from KFileItemList to
KItemRangeList. To make this work, the "look the indexes up in
m_items" code is moved from that function to slotItemsDeleted(). In
the other places where removeItems() is called, the indexes are
calculated directly (which is not more difficult than determining the
removed items as a KFileItemList, if one considers that we needed the
function childItems(KFileItem) for that, which is not needed any more
with this patch).

* Also removeFilteredChildren() takes a KItemRangeList now. Rather than
putting the parent KFileItems into a QSet for O(1) lookup (which
prevents O(N^2) worst case behavior for the entire function), it uses
a QSet<ItemData*> now, which should even be more efficient (hashing a
pointer is cheaper than hashing a KFileItem/KUrl).



FIXED-IN: 4.12.0
REVIEW: 113070

David Edmundson committed changes in [nepomuk-core] servicestub/servicecontrol.cpp:

Don't delete a QObject from inside a slot.

If there are any pending calls to that object to be processed deleting
the object can cause them to crash. (such as in KTp's service)

Using deleteLater() is safer.


REVIEW: 113128

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/effects/mouseclick/mouseclick.cpp:
Frank Reininghaus committed changes in [kde-baseapps/KDE/4.11] dolphin/src/dolphinviewcontainer.cpp:

Reload the view if a previously unmounted device is mounted again

The problem was that DolphinViewContainer::setUrl(newUrl) was ignored
if newUrl is equal to the URL which is shown in the view already.

The new approach is to reload the view in that method if it is empty, to
make sure that we do not miss that a previously unmounted device has
been re-mounted.

Thanks to Grigoriadis Grigoris for analyzing the root cause of this
issue!


FIXED-IN: 4.11.3

Emmanuel Pescosta committed changes in [kde-baseapps] dolphin/src/kitemviews/kstandarditemlistwidget.cpp:

Use the icon size from KItemListStyleOption for the width and height of the
expansion area instead of KIconLoad::SizeSmall.


REVIEW: 113169
FIXED-IN: 4.12

Christoph Feck committed changes in [nepomuk-core/KDE/4.11] services/fileindexer/indexer/popplerextractor.cpp:

Fix trailing garbage in extracted PDF title


FIXED-IN: 4.11.3
REVIEW: 113138

Martin Gräßlin committed changes in [kde-workspace/KDE/4.11] kwin/effects/zoom/zoom.cpp:

Fix zoom effect cursor position on initial zoom in.


FIXED-IN: 4.11.3

Laurent Montel committed changes in [kdeplasma-addons/KDE/4.11] applets/leavenote/leavenote.cpp:

Fix Bug 321303 - Leave A Note widget: Delivered note presents itself in raw HTML code.

FIXED-IN: 4.11.3

Andrea Iacovitti committed changes in [kde-baseapps/KDE/4.11] konqueror/settings/kio/kproxydlg.cpp:

Use the correct variable, instead of the entire QStringList, to fill in
lineedit's text in autoDetectSystemProxy().
When saving for "System Proxy" configuration be sure to write the name
of environment variables and not their values in the configuration file.
Added missing signal connection for mUi.systemProxyRadioButton.
Connect slotChanged() to textEdited() signal, instead of textChanged(),
for systemProxy's lineedits: this avoid to emit changed() when
"Show the value of the envirnment variables" checkbox is clicked.


FIXED-IN: 4.11.3
REVIEW: 113129

KDE-PIM

Laurent Montel committed changes in [kdepimlibs/KDE/4.11] akonadi/contact/editor/contacteditorwidget.cpp:

Fix Bug 324063 - contact edit dialog has too narrow fields

FIXED-IN: 4.11.3

Laurent Montel committed changes in [kdepim/KDE/4.11] /:

Fix Bug 310627 - Drag and dropping a link to knotes from Firefox results in invisible text cursor

FIXED-IN: 4.11.3


Keep ktextedit makes work.

Laurent Montel committed changes in [kdepim-runtime/KDE/4.11] resources/shared/singlefileresourceconfigdialogbase.cpp:

Fix Bug 319313 - Select KDE accounts file 'text field' overflows

FIXED-IN: 4.11.3

David Edmundson committed changes in [ktp-common-internals] KTp/Models/text-channel-watcher-proxy-model.cpp:

Fix crash caused by TextChannelWatcherProxyModel

void KTp::TextChannelWatcherProxyModel::onChannelMessagesChanged()
void KTp::TextChannelWatcherProxyModel::onChannelInvalidated()
emit dataChanged() using indexes from the wrong model.

Because it's an QIdentityProxyModel it never causes any harm,
but it's still "wrong" so Qt asserts break in the grouping model.


REVIEW: 113126

Laurent Montel committed changes in [kdepim] /:

Fix apply setidentity (Bug 324532 - kmail filter on sending mails cannot change identity)


FIXED-IN: 4.12

Laurent Montel committed changes in [kdepim/KDE/4.11] kontact/plugins/knotes/knotes_part.cpp:

Fix Bug 297157 - knotes reqires to save edited note twice

FIXED-IN: 4.11.3

Sergio Luis Martins committed changes in [kdepim/KDE/4.11] korganizer/views/todoview/kotodoview.cpp:

Fix purging to-dos through popup menu.

There was a missing signal.


FIXED-IN: 4.11.3

Laurent Montel committed changes in [kdepim] /:

Fix Bug 238574 - show number of notes in systray icon

FIXED-IN: 4.12

Laurent Montel committed changes in [kdepim-runtime/KDE/4.11] resources/shared/singlefileresourceconfigdialogbase.cpp:

Fix Bug 287249 - Import VCF file dialogue is a bit funny

Define minimum size

FIXED-IN: 4.11.3

Sergio Luis Martins committed changes in [kdepim/KDE/4.11] incidenceeditor-ng/incidencedialog.cpp:

Don't forget to accept the close event after KDialog::reject().

If we simply ignore the close event, Qt::WA_DeleteOnClose won't
have any effect and the dialog just gets hidden.

Sergio Luis Martins committed changes in [kdepimlibs/KDE/4.11] akonadi/calendar/calendarbase.cpp:

Make code robust against event being deleted.

Also fixes a uid() vs instanceIdentifier() issue.

These are the two only possible causes for the crash reported in:

Office

Boudewijn Rempt committed changes in [calligra] krita/plugins/paintops/hatching/hatching_brush.cpp:

Apply thickness parameter to hatching brush

Patch by Salil Kapur

Boudewijn Rempt committed changes in [calligra] krita/ui/widgets/kis_slider_spin_box.cpp:

update the slider when scrolling with the wheel

Patch Salil Kapur

Multimedia

Michael Pyne committed changes in [juk] /:

Notify the user that JuK is docked on startup.

We show a simple notification if the user starts up JuK and it is set to
dock in the systray on startup (as otherwise the user may wonder why it
didn't open up). Although a "Do not show again" checkbox is not possible
with KNotification, it is possible to remove this additional
notification by going to "Application and System Notifications" in
System Settings to manage "Juk music player" application notifications.

We do *not* show a notification if a session is being restored to avoid
noise, however JuK will show the main window if the user tries to start
it up again after it's already running, so this should be OK.

Thanks to Shubham Chaudhary for the bugfix (you're been marked as the
patch author), and Michael for reporting the bug.

This bugfix adds new strings so it cannot be backported. It will show up
first in KDE SC 4.12.


FIXED-IN:4.12
GUI:

Networking Tools

David Edmundson committed changes in [ktp-common-internals/kde-telepathy-0.7] KTp/Models/text-channel-watcher-proxy-model.cpp:

Fix crash caused by TextChannelWatcherProxyModel

void KTp::TextChannelWatcherProxyModel::onChannelMessagesChanged()
void KTp::TextChannelWatcherProxyModel::onChannelInvalidated()
emit dataChanged() using indexes from the wrong model.

Because it's an QIdentityProxyModel it never causes any harm,
but it's still "wrong" so Qt asserts break in the grouping model.


REVIEW: 113126

Leon Handreke committed changes in [ktp-text-ui] /:

Fix adiumxtra-protocol-handler to show UI to confirm installation again

Don't install the Adium extra automatically but show a notification to
confirm the installation (as was probably originally intended by the
authors of the code).

Disable the KIO progress notification that results in a non-informative
"Copying [Finished]" notification for the temporary file being created.

REVIEW: 113214

David Edmundson committed changes in [ktp-contact-list] /:

Scale all avatars in contact list tooltips with Qt::SmoothTransformation

Scale all avatars in contact list tooltips with Qt::SmoothTransformation

Without using Qt::SmoothTransformation, scaled images look "grainy".

Utilities

Rolf Eike Beer committed changes in [kgpg/KDE/4.11] keysmanager.cpp:

fix keys not being refreshed if a user id is deleted from it

Valentin Rusu committed changes in [kwallet] src/manager/kwalleteditor.cpp:

Fix crash when deleting a "dirty" entry from the wallet


FIXED-IN:4.11

Features

Development Tools

Joris Steyn committed changes in [umbrello] umbrello/umllistview.cpp:

Update documentation window on key navigation

Selecting a different tree item using the keyboard now updates the
documentation window just like what would happen when using the mouse.

The keyboard can also be used to select a different diagram from the tree view.

Ralf Habacker committed changes in [umbrello/KDE/4.11] umbrello/foreignkeyconstraint.cpp:
Joris Steyn committed changes in [umbrello] umbrello/foreignkeyconstraint.cpp:
Milian Wolff committed changes in [kdevplatform] plugins/execute/nativeappconfig.cpp:

Show clear button in program arguments line edit.


REVIEW: 113186

Educational

Sebastian Gottfried committed changes in [ktouch] /:

data: add Basque course

Contributed by Alexander Gabilondo

Many thanks!

CCMAIL: Alexander Gabilondo

Diffs: 1, 2, 3 Revision bb27bc8...
Sebastian Gottfried committed changes in [ktouch] /:

data: add Workman layout and corresponding course

Contributed by Peter Feigl

Thanks!

Diffs: 1, 2, 3, 4, 5 Revision 76788b5...

Graphics

Fabio D'Urso committed changes in [okular] /:

kimgio generator: Apply transformations dictated by Exif metadata


FIXED-IN: 4.12.0
REVIEW: 111793

Jonathan Marten committed changes in [kooka] /:

Show the destination file name in the scan progress dialogue (if available)

Diffs: 1, 2, 3, 4, 5, 6 Revision d34ec16...
Fabio D'Urso committed changes in [okular] generators/kimgio/generator_kimgio.cpp:

kimgio generator: tiled rendering support

REVIEW: 113250

Jonathan Marten committed changes in [kooka] /:

Tool tips for PNM testing mode and scan size selector

Also change the layout of the two testing mode radio buttons.
Fade the resolution and scan area controls for Virtual Scanner.
Tool tips for Preview and Start Scan buttons.
Trim trailing '.' from SANE-supplied descriptions as tool tips.
Format tool tips as rich text so that they get word wrapped.

Diffs: 1, 2, 3, 4 Revision e7babd1...

KDE Base

Dominik Haumann committed changes in [kate] part/syntax/data/gnuplot.xml:

add Gnuplot syntax highlighting file


FIXED-IN: 4.12

KDE-PIM

Jan Kundrát committed changes in [trojita] /:

Support multiple sessions with separate configuration and cache

Thanks to the work Pali did within the GSoC, Trojita no longer constructs a
QSettings instance from multiple places. It is therefore pretty easy to enforce
a separation of some kind between the concurrent sessions. One use case of this
patch is for situations where it's necessary to access multiple IMAP accounts at
once. It's a pretty sucky hack, but it could serve as a stopgap measure until
proper multiaccounts support is written and integrated.

You can test this now via executing trojita with the --profile option like this:

$ ./trojita --profile work

Of course this patch will cause havoc when support for IPC via DBus is merged
(think mailto: URL handling); that will have to be disabled when a "special
profile" is called. Let's see how well this works for now. Oh, and *please*,
keep the profile name in ASCII; things will break if you don't do so.

For users who do not set a the --profile option, nothing changes and everything
shall work well. It is also safe to run one Trojita instance without any fancy
options and a second one with a custom profile (as long as your profile name
does not match a base64-encoding of some mailbox; please do not do this,
either).

The patch abuses environment variables behind the scenes. I'm not going to put
any more work into this -- the patch is ugly as usual, but this is officially
supposed to be a time-limited hack anyway.

REVIEW: 113150

Diffs: 1, 2, 3 Revision fe1f6e7...
David Edmundson committed changes in [ktp-common-internals] /:

Make favorite chat room names editable

REVIEW: 113111

FIXED-IN: 0.8.0

DIGEST: Add ability to edit the name of your favourite chat rooms for quick joining

Office

Stephane Mankowski committed changes in [skrooge] /:

feature: Operations can be split by date

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 21 more) Revision e12b450...

Networking Tools

Jan Grulich committed changes in [plasma-nm] /:

Add more PIN/PUK types for SIM/Modem unlocking

Diffs: 1, 2, 3 Revision 2ef233f...

Optimization

Graphics

Jonathan Marten committed changes in [kooka] /:

Image transformations can take time, so do them in a background thread.

New class ImageTransform to do this, with operation codes for the
various transforms supported. Combine the multiplicity of slots
in Kooka and the two rotate/mirror functions in KookaView. Also
simplifies ScanGallery.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 2845483...

KDE Base

Vishesh Handa committed changes in [nepomuk-core/KDE/4.11] services/fileindexer/indexer/indexer.cpp:

FileIndexer: Use parameterized queries for inserting the plain text

With Soprano 2.9.4 the virtuoso backend has support for paramterized
queries which consume way less memory when inserting large blobs of
text.

With this the high virtuoso memory usage should decrease to a large
extent.

Networking Tools

Xuetian Weng committed changes in [ktp-kded-module/kde-telepathy-0.7] /:

Refactor now playing plugin

Enable option now behaves as "enable on login", and changes at contact
list will be temporary for this login. And use requested presence to
evaluate the new presence by this plugin.



REVIEW: 113066
FIXED-IN: 0.7