Issue 310

20th October 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Giacomo Barazzetti
Alex Fikl

This Week...

Improvements to KPasswordDialog. Nepomuk adds File Extractor for the binary MS-Office formats (doc, xls, ppt). KGPG shows more information. Okular improves searching code. Multiple modules re-enabled in KDE Frameworks.

Statistics

Commits 1491 by 120 developers
Open Bugs 21287
Open Wishes 15906
Bugs Opened 347 in the last 7 days
Bugs Closed 351 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
145
 
/branches/stable
70
 
/kinfocenter/Modules
48
 
/trunk/l10n-support
40
 
/kcontrol/input
19
 
/akonadi/calendar
16
 
/server/lib
13
 
/kcontrol/CMakeLists.txt
13
 
/plugins/knotes
12
 
/kontact/plugins
11
 
Files Developer Commits
795
 
Martin Gräßlin
265
 
369
 
Laurent Montel
131
 
165
 
Dan Vratil
57
 
159
 
Sergio Luis Martins
53
 
135
 
Marco Martin
45
 
123
 
Aaron J. Seigo
41
 
102
 
Roman Paholík
34
 
99
 
Sebastian Kügler
33
 
60
 
Sayak Banerjee
28
 
81
 
Jan Kundrát
28
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
99%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
99%
 
German (de)
98%
 
French (fr)
98%
 
Spanish (es)
97%
 
Polish (pl)
97%
 
Dutch (nl)
97%
 
Estonian (et)
94%
 
Galician (gl)
91%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
78
 
Christoph Feck
66
 
Gilles Caulier
19
 
Boudewijn Rempt
17
 
Sergio Luis Martins
13
 
José Manuel Santamaría Lema
12
 
Aleix Pol Gonzalez
11
 
Martin Tobias Holmedahl Sandsmark
10
 
Andrea Iacovitti
9
 
Cedric Bellegarde
9
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[]     

Graphics

[]   []   

KDE Base

[] []    []

KDE-PIM

[] []    

Office

[]     

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    

User Interface

[]     

Utilities

  []    

Games

[] []    

Other

[]     

There are 61 selections this week

Bug Fixes

Development Tools

Joris Steyn committed changes in [umbrello] /:

Fix copy/paste between Umbrello instances

Clip4 now contains all the UMLObjects corresponding to the copied widgets.

Some related but obviously unused code removed. Involves a better fix than
c63e77c for broken copy/paste of listview items.

Educational

Albert Astals Cid committed changes in [kstars/KDE/4.11] kstars/skycomponents/supernovaecomponent.cpp:

Restring addition of null supernovae objects to supernovaecomponent list

While loading data for supernovae, there seems error in reading file supernovae.dat so it leads to creation of dummy supernovae object which leads to various error during run time of Kstars. So lets avoid creation of such dummy supernovae objects.
This fixes attached bug too.

Approved by Henry de Valence

FIXED-IN: 4.11.3

REVIEW: 112879

Albert Astals Cid committed changes in [kstars/KDE/4.11] kstars/skyqpainter.cpp:

Ordered visibility check for first point of SkyPolyLine in drawSkyPolyline function

Variable isVisibleLast and isVisible are not initialized so stores random value while operated and with check visibility and correct visibility of point are stored in same variable when passed to toScreen function.

Approved by Henry de Valence


REVIEW: 112726
FIXED-IN: 4.11.3

Graphics

Benjamin Girault committed changes in [kipi-plugins] panorama/importwizard/lastpage.cpp:

Panorama: bugfix lastpage

Thanks to Pulfer for the bug report and "ROSA & OpenMandriva" for the patch is one is based on.

Albert Astals Cid committed changes in [okular/KDE/4.11] ui/videowidget.cpp:

Fix Movie player controls sometimes only show up at the first playing of the movie


FIXED-IN: 4.11.3

Albert Astals Cid committed changes in [okular/KDE/4.11] generators/comicbook/unrar.cpp:

Fix cbr (rar) listing with unrar 5

The new unrar version includes the paths in its "bare listing" (unrar lb), while it still extracts only the filename without the path. Thus, the Unrar::list() function fails. This patch strips the path away.

REVIEW: 113163

FIXED-IN: 4.11.3

KDE Base

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/scene.cpp:

do not create window pixmap for Deleted windows

related black window issues


FIXED-IN: 4.11.3

David Faure committed changes in [kde-baseapps/KDE/4.11] /kbookmarkmodel:

Fix DnD crash for more cases (moving N bookmarks into subfolder or parent folder)

Solution: copy all selected bookmarks first, then delete them all
(at their possibly updated address).


FIXED-IN: 4.11.3

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.11] dolphin/src/dolphinmainwindow.cpp:

Files passed as arguments: Ignore unsupported files

With this patch, Dolphin ignores all files passed to it that it can't

Also, archives are now opened inside Dolphin so it can be used as an
archive manager at least for local files. If the user tries to open a
remote archive Dolphin still opens it externally; I have observed that
if it receives one as an argument, it will display a pseudo-folder that
contains only said archive. So having it set as the archive handler is
still broken, but in a less annoying way.


REVIEW: 113191
FIXED-IN: 4.11.3

Michael Pyne committed changes in [kdelibs] /dialogs:

kdeui: Streamline KPasswordDialog.

A user reported a couple of years ago that the "Anonymous login"
checkbox is badly placed in KPasswordDialog, appearing in between the
user and password fields and sticking out like a sore thumb.

Instead of just moving the checkbox, I took the opportunity to make the
U/I match the underlying code. Since "Anonymous" mode makes the existing
U/I set both username and password fields to be read-only, it's really a
separate authentication scheme and should be treated as such, especially
since it is hard to tell visually that the Anonymous checkbox is
responsible for disabling the line edits above and below it.

The existing code relies somewhat on the widgets that are present in the
U/I file, so instead of trying to merge the new radio buttons with the
existing widgets I separated out the "anonymous" radio button and its
new counterpart, and left the rest of the existing widgets parented
under a hidden widget to minimize code churn and the risk of introducing
bugs.

Tested with a handy FTP server, and with the included KPasswordDialog
test suite.


FIXED-IN:4.12
DIGEST:Improvements to KPasswordDialog
GUI:

David Faure committed changes in [kdelibs/KDE/4.11] /:

Fix association-with-derived-mimetype again.

871cccc8a88a made it impossible to re-order file type associations.
7f42bf253009 fixed that, but changed the value of KService::mimeTypes(), which
broke okular. This new fix works the same way, but only inside kbuildsycoca
when it processes the mimetypes. The value of KService::mimeTypes() is now
restored to be exactly what's in the desktop file.


FIXED-IN: 4.11.3

Kåre Särs committed changes in [kate] /kate/search:

S&R: Fix searching in never saved files + multiplex using roles

The match data is now saved in column 0 with custom roles in stead of
using UserRole in many columns. The custom roles also have enums for
better readability.

Wolfgang Bauer committed changes in [kde-workspace] kcontrol/input/xcursor/xcursortheme.cpp:

Cursor Theme KCM: Show correct resize cursor in preview for themes
without a file called "size_fdiag"

Apparently in XCursorTheme::findAlternative() (file
kcontrol/input/xcursor/xcursortheme.cpp) the alternatives for
"size_bdiag" and "size_fdiag" are swapped, so for themes not containing
"size_fdiag" the wrong resize cursor is shown in the preview.

This patch fixes that long standing bug. (there has been no change to
that function since 2007!)

This also fixes the glitch mentioned in bug#325763, that the wrong
arrows are used for the window resize hint after the theme change is
applied (for the current X session).

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] /:

fix deco config updates

- B2 linked to the wrong slot (instead of changed signal)
- border size change was not written (for B2, Laptop etc)
- Aurorae didn't recreate decos when required


FIXED-IN: 4.11.3
REVIEW: 113229

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.11] dolphin/src/dolphinmainwindow.cpp:

Fix crash when triggereing the "Compare files" action via D-Bus

If the number of selected items is not two, Dolphin disables this
action. However, it is still possible to trigger it via D-Bus, and this
could cause a crash in DolphinMainWindow::compareFiles() because this
function did not test at all if there are really two items selected.

This patch adds such a check and simplifies the code in that function.


FIXED-IN: 4.11.3

KDE-PIM

Laurent Montel committed changes in [kdepim/KDE/4.11] messageviewer/scamdetection/scamdetection.cpp:

Fix Bug 326072 - Scam detector misidentifies FQDN as numerical IP

FIXED-IN: 4.11.3

Jonathan Marten committed changes in [kdepim] messagecomposer/recipient/distributionlistdialog.cpp:

kmail: do not duplicate contacts when saving distribution list

Save a known contact by reference to its Akonadi ID plus possibly
email address (if it is not the preferrred one). Only save an
unknown contact by name and email, do not add it to the address book.
Correctly handle the case where the email search returns multiple
contacts.

REVIEW:113180

Laurent Montel committed changes in [kdepim] /plugins/knotes:

Fix Bug 178077 - notes are not updated in kontact overview

FIXED-IN: 4.12

Laurent Montel committed changes in [kdepim/KDE/4.11] /:

Fix Bug 326029 - No newlines in Contacts notes in right column

FIXED-IN: 4.11.3

Laurent Montel committed changes in [kdepim] /plugins/knotes:

Fix Bug 97895 - incremental search (ala Kmail)

FIXED-IN: 4.12


(this bug is 8 years old)

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 1a63fd0...

Office

C. Boemann committed changes in [calligra] libs/main/KoModeBox.cpp:

The text color in the modebox tab icons were not drawn accoring to style - this fixes it

C. Boemann committed changes in [calligra] /main:

Made it impossible for the modebox docker to be less wide than the option widget

Robby Stephenson committed changes in [tellico/2.3] /:

Fix cast list in IMDb search


FIXED-IN: 2.3.9

Jarosław Staniek committed changes in [calligra] /main/startup:

Fixed crash when using command line "kexi --dbdriver postgresql" and more

General:
*Fixed crash when using command line "kexi --dbdriver postgresql"
*Clicking "Details" button of the password dialog shows full connection dialog
*Skip the Welcome Wizard if connection data options are set from command line
*Enable editing of user name in the password dialog even if specified by command line

Multimedia

Mark Kretschmann committed changes in [amarok] /context/applets/analyzer:

Fix rendering glitch introduced with commit f4a3f4f.


BACKPORT

Networking Tools

Jan Grulich committed changes in [plasma-nm] declarative-plugins/model/model.cpp:

Do not remove shared connection when it is disconnected

Leon Handreke committed changes in [ktp-text-ui/kde-telepathy-0.7] logviewer/dates-model.cpp:

Fix logviewer crash with multiple conversations per date

This situation commonly occurs when conversations from multiple accounts
were held on a single day.

REVIEW: 113289

Dan Vratil committed changes in [ktp-text-ui] /:

Clear sent message history when clearing chat view

When user clicks Action->Clear View, clear the sent message history
in ChatTextEdit too - when you want to delete a sensitive conversation,
keeping sent messages is not a good thing to do :)

Also fix the actual Clear View action by setting d->exchangeMessageCount
to 0 in clear(), otherwise last X messages from backlog are loaded after
re-initialization of the chat view.

REVIEW: 113255

Diffs: 1, 2, 3 Revision 376a50d...

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-transparent/KDE/4.11] style/oxygenstyle.cpp:

set WA_TRANSLUCENT_BACKGROUND on QGLWidgets.

Hugo Pereira Da Costa committed changes in [oxygen-transparent/KDE/4.11] /:

do not set transparency on windows that have _XEMBED_INFO property set.

Games

Nemanja Hirsl committed changes in [konquest] dialogs/newgamedlg.cc:

When adding a new player to the game, the default player controller is
always the very first registered player controller (human player). Now,
the used player is either the default one if no players are added yet,
or the player controller of the last added player.


FIXED-IN:4.12
REVIEW:113114

Other

Albert Vaca Cintora committed changes in [kdeconnect-android] src/main/java/org/kde/kdeconnect/UserInterface/ShareToReceiver.java:

"Share to" now retrieves filename for file:// uris too

Querying the ContentProvider only works for content://... uris but when you
share a file from a file-manager, the uri you get has the form file://... and
ContentProvider returns a null cursor.


REVIEW: 113202

Features

Development Tools

Kevin Funk committed changes in [kdevplatform] /:

Provide a shortcut for switching split views

Provided a shortcut (key combination as well as on menu option)
for switching between split views. Implemented the same by providing
shortcut (Ctrl + Shift + P for moving to previous split and
Ctrl + Shift + N for moving to next split) along with menu options in
Window drop-down menu


REVIEW: 113264

Aleix Pol Gonzalez committed changes in [kdevplatform] plugins/execute/nativeappconfig.cpp:

Improve targets menu

If there are many targets in a directory, add a subdirectory. Otherwise
it would create huge menus that wouldn't even fit my screen in some cases,
this should make it a bit better.
Make sure everything has been sorted.

Milian Wolff committed changes in [kdevplatform] language/highlighting/colorcache.cpp:

Improve detection of dark color schemes for highlighting.

When blending syntax highlighting colors, determine whether the color
scheme is light or dark by comparing the luminance of the background and
the foreground colors, instead of looking only at the foreground color.
The rationale is that what determines whether a color scheme is light or
dark is its background color, and even a dark color scheme can still use a
somewhat grayish foreground color that still provides good contrast, but
is below the original half-luma threshold.

For instance, the popular Solarized Dark color scheme uses #839496 for
its foreground color, which has a luma of 0.287658, well below the 0.5
threshold. This causes KDevelop to incorrectly detect it as a light
color scheme, resulting in dark-on-dark generated syntax highlighting
colors which is very difficult to read. This is fixed by this change.

KDE Base

Frank Reininghaus committed changes in [kde-baseapps] /src:

Abort loading the current URL if the user presses Escape


FIXED-IN: 4.12.0
REVIEW: 113234

Denis Steckelmacher committed changes in [nepomuk-core] /fileindexer/indexer:

Nepomuk File Extractor for the binary MS-Office formats (doc, xls, ppt)

This file extractor uses the utilities of the "catdoc" package (catdoc,
xls2csv, catppt) to extract the plain-text content of binary MS-Office files.

No information about the title or the author of the file is extracted.

REVIEW: 113217
DIGEST:

Diffs: 1, 2, 3, 4 Revision 0d142df...
Dominik Haumann committed changes in [kate] /:

add Pascal indenter for KDE 4.12

Thanks to Trevor for the patch!

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Add print preview support in kontact plugins too

Diffs: 1, 2, 3, 4, 5 Revision e28c04b...
Sergio Luis Martins committed changes in [kdepim/KDE/4.11] /:

Fix side-by-side view.

Agendas weren't being created because it wasn't listening to
signals about them being checked or unchecked.

Still not happy about it, somethings weird with the default
sizes for the all day agenda, it appears too big at first.

Sandro Knauß committed changes in [kdepim] messageviewer/viewer/objecttreeparser.cpp:

Multimedia

Sinny Kumari committed changes in [plasma-mediacenter] /:

function to save different playlist in diffrent file
display list of all playlist in listview

Diffs: 1, 2, 3, 4, 5, 6 Revision a8331e2...

Networking Tools

Emmanuel Lepage Vallee committed changes in [sflphone-kde] /lib:

[ #31632 ] Restore basic presence support

Diffs: 1, 2, 3, 4, 5 Revision 59b99d5...
David Edmundson committed changes in [ktp-contact-list] main-widget.cpp:

If in kpeople mode use the shared AccountManager

REVIEW: 113232

Utilities

Rolf Eike Beer committed changes in [kgpg] /:

Allow to open a URL from a keys context menu to show additional information

This currently lacks a configuration UI.


FEATURE

Rolf Eike Beer committed changes in [kgpg] /:

add context action to send a mail to key or user id owner

Also reorder some other context menu entries to make those that are probably
used more often to the top.

Based on a patch from Roeland Douma which I forgot in the
bugtracker for more than 2 years :(


FEATURE

Games

Jaime Torres Amate committed changes in [knavalbattle] /:

make the AI smarter to not shoot at places it knows there are no ships

When notify is called after a shoot, and an opponent ship is sunk,
mark the surrounding cells as border, therefore the AI will not try
them in the future.


FIXED-IN: 4.12
REVIEW: 113054

Optimization

Graphics

Albert Astals Cid committed changes in [okular] /:

Improve searching code

Also simplified code a bit by removing unnecessary calls to toLower in TextPagePrivate::findTextInternalForward and TextPagePrivate::findTextInternalBackward I also fixed a small bug: the letter capital I with dot above (U+0130) did not match itself in case-insensitive mode on Qt 4.8.4 (U+0130 still does not match lowercase i (U+0069), which can be considered another bug, that I didn't fix (although this behavior conforms to the Unicode case folding rules)).

(I did not implement the Knuth-Morris-Pratt algorithm that I promised in a comment of Bug 323263 because on second thought I find that the win, if any, would probably be negligible except for some very special documents and special query strings.)



REVIEW: 112135

Other

KDE Base

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back style kcm

It works, just apps are not picking up any change. Probably related
to the changes around KGlobalSettings or a broken session on this
test system.

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back KCM for global shortcuts

Unfortunately not very usable as the global shortcuts editor is broken.
Not just in this KCM but also for example in the ones of virtual desktops
which means it's broken in frameworks.

Mark Gaiser committed changes in [kdelibs/frameworks] /kcoreaddons/src/lib/jobs:

Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

REVIEW: 113205

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back the input kcms (mouse and cursortheme)

Mouse has crashing tabs due to QFormLayout and cursortheme's apply
is not tested properly as it requires a restart of "KDE". Difficult
on KF5 right now.

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back kcm to configure the bell

Unfortunately I cannot test as my hardware doesn't support this erm
legacy notification system.

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back launch feedback KCM

Yeah we can configure the bouncing cursor again.

Martin Gräßlin committed changes in [kde-workspace] CMakeLists.txt:

Welcome back KInfoCenter

Martin Gräßlin committed changes in [kde-workspace] CMakeLists.txt:

Welcome back kmenuedit

Unfortunately it's not yet working as it complains on startup
because it cannot connect to the khotkeys kded.

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Welcome back kcm for standard actions

Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Bring back dateandtime kcm

Hardly tested as the kcm tells me that I am not allowed to change
anything. Seems like my system is missing something on DBus...

Martin Gräßlin committed changes in [kde-workspace] CMakeLists.txt:

Welcome back khotkeys!

Kevin Ottens committed changes in [kdelibs/frameworks] /:

Move KDatePicker to KWidgetsAddons

Diffs: 1, 2, 3, 4 Revision cfe5d9a...
Martin Gräßlin committed changes in [kde-workspace] kcontrol/CMakeLists.txt:

Enable fonts kcm