Issue 320

29th December 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Giacomo Barazzetti
Alex Fikl

This Week...

Umbrello offers more intelligent context menus: when multiple widgets are selected, a context menu is shown containing only the actions that work on the whole selection; sees better undo support and visual properties improvements. Marble supports nautical miles as a measurement system. Digikam improves detection of new images on the camera and sees a bug in face detection fixed. Krita improves usability of Shade Selector. Multiple bug fixes in Krita, digikam, KMyMoney and more.

Statistics

Commits 1304 by 126 developers
Open Bugs 21258
Open Wishes 15937
Bugs Opened 236 in the last 7 days
Bugs Closed 295 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
142
 
/branches/stable
76
 
/trunk/l10n-support
39
 
/plasma/generic
19
 
/krita/plugins
19
 
/src/core
16
 
/krita/ui
16
 
/src/lib
13
 
/app/views
12
 
/trunk/www
10
 
Files Developer Commits
198
 
Laurent Montel
75
 
153
 
Dmitry Kazakov
55
 
126
 
Friedrich W. H. Kossebau
43
 
123
 
Michal Humpula
41
 
87
 
Sayak Banerjee
41
 
102
 
Marco Martin
39
 
114
 
Iñigo Salvador Azurmendi
38
 
99
 
Martin Tobias Holmedahl Sandsmark
33
 
84
 
André Marcelo Alvarenga
28
 
78
 
Sebastian Kügler
26
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Brazilian Portuguese (pt_BR)
99%
 
Swedish (sv)
99%
 
German (de)
99%
 
French (fr)
98%
 
Dutch (nl)
97%
 
Spanish (es)
96%
 
Polish (pl)
96%
 
Estonian (et)
92%
 
Galician (gl)
91%
 

Bug Killers

Person Bugs Closed
Joris Steyn
38
 
Jekyll Wu
33
 
Boudewijn Rempt
32
 
Hugo Pereira Da Costa
22
 
Martin Gräßlin
18
 
Christoph Feck
17
 
Dmitry Kazakov
14
 
Allen Winter
9
 
Albert Astals Cid
9
 
Myriam Schweingruber
8
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[] []    

Educational

[] [] []   []

Graphics

[] []    

KDE Base

[] [] []   []

KDE-PIM

[] [] []   

Office

[] [] []   

Konqueror

     

Multimedia

  []    

Networking Tools

[]     

User Interface

[]     

Utilities

[]     

Games

[]     

Other

     

There are 70 selections this week

Bug Fixes

Development Tools

Joris Steyn committed changes in [umbrello] /:

Add alignment actions to context menu

Educational

Henry de Valence committed changes in [kstars] /skyobjects:

More alignment fixes.

This change reduces the size of StarObjects and DeepSkyObjects by 8
bytes each. Combined with the previous commit, this gives a ~10%
reduction in memory use.

Graphics

Marcel Wiesweg committed changes in [digikam] /models:

Fix infamous big face scanning crash: Re-sending a package in the ImageFilterModel discarded the extraValues,
resulting in a mismatch in the size of infos and extraValues lists in ImageModel

Teemu Rytilahti committed changes in [digikam] /importui:

Don't spam the camera with preview requests, even if capturing is possible, but liveview is not. Done by checking the existence of GP_OPERATION_CAPTURE_PREVIEW flag.

CC

KDE Base

Frank Reininghaus committed changes in [kde-baseapps] dolphin/src/kitemviews/kfileitemmodel.cpp:

Fix crash when dragging children of expanded folders in Details View

The problem was that the loop in KFileItemModel::createMimeData() which
is supposed to find out if any parent of an item has been added to the
QMimeData already (because it is not necessary to add the item in that
case) did not loop through the parents of the item, but incorrectly
replaced the local variable 'itemData' by its parent.


REVIEW: 114562

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/geometry.cpp:

fix shortcut driven quicktiling

1. swapping direction would rather toggle tiling
2. the next screen was calculated wrongly (found outmost)
3. the electrictborder geometry was not updated when swapping the mode on screen changes


FIXED-IN: 4.11.6

REVIEW: 114648

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.12] /src:

Update filtered items when the "refreshItems" signal is received

This fixes the problem that the new file name is not shown in the view
if an item is renamed while it is filtered.


FIXED-IN: 4.12.1
REVIEW: 114459

Michal Humpula committed changes in [kate/frameworks] /printing:

enable page ranges for printing

Thomas Lübking committed changes in [kde-workspace/KDE/4.11] kwin/clients/laptop/laptopclient.cpp:

fix laptop deco painting

REVIEW: 114511

FIXED-IN: 4.11.6

KDE-PIM

Jan Kundrát committed changes in [trojita] /Imap:

IMAP: ignore extra ENABLED CONDSTORE QRESYNC responses when syncing a mailbox

Apparently at least some versions of Kolab are happy to send out unsolicited
ENABLED responses during the SELECT processing despite the fact that the QRESYNC
has been already enabled explicitly. This is in violation of my understanding of
RFC 5161. Reported to Kolab at https://issues.kolab.org/show_bug.cgi?id=2708 .

Thanks to Martin Sandsmark for reporting this and
patiently providing logs until I was sure where the problem is. Much
appreciated!


REVIEW: 114666

Laurent Montel committed changes in [kdepim/KDE/4.12] kmail/kmmainwidget.cpp:

Fix Bug 328962 - menu entry 'mark all read' disabled

FIXED-IN: 4.12.1

Laurent Montel committed changes in [kdepim/KDE/4.12] /:

Fix Bug 328777 - Photo search for contact email should be case-insensitive

FIXED-IN: 4.12.1

Office

Dmitry Kazakov committed changes in [calligra] krita/ui/input/kis_input_manager.cpp:

Properly fix color-picking-after-ctrl-z bug

The ShortcutOverride event is always followed by KeyPress
event so there is no need to process both of them.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/ui/canvas/kis_canvas2.cpp:

Fix the crash when changing the canvas type while Transform Tool active

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /ui/opengl:

Fix openGL texture buffers on non RGB8 color spaces

We should prepare a proper pixel size when creating a buffer

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /image:

Fix the outline generation bug

The outline generation algorithm has a small bug, which
results in the starting point be repeated twice in the
beginning of the path, instead of being put into the
end. Now we just explicitly close the path to workaround
it in KisPixelSelection::recalculateOutlineCache().

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /:

Fix High-Quality filtering for some broken ATI cards

Some (broken) ATI drivers need the arithmetic operands to be
casted manually. So let's make them happy.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /plugins/paintops:

Fixed a dab size bug introduced by the smooth brush rotation fix

The fast-path code should crop the image by the actuall
expected rect.

Boudewijn Rempt committed changes in [calligra] /:

Fix the desaturate filter

There are several ways to do desaturation, so create a
kis_desature_adjusment color adjustment that allows to specify the type
of desaturation.

This replaces the old desat color adjusment that used a Lab-based lut
which didn't give correct results.

Allan Anderson committed changes in [kmymoney] kmymoney/plugins/csvimport/csvdialog.cpp:

- Fix out-of-range index in CSV Importer.

Boudewijn Rempt committed changes in [calligra] libs/main/KoMainWindow.cpp:

Use Qt to save and restore the window geometry and window size

Boudewijn Rempt committed changes in [calligra] krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp:
Dmitry Kazakov committed changes in [calligra/calligra/2.8] /:

Properly fix the transform tool not to process locked layers

Since the lockness of a node may change during the stroke, we now store
the list of to be processed nodes explicitly.

Dmitry Kazakov committed changes in [calligra] /plugins/paintops/libbrush:

Fix smooth rotation of the Predefined Brushes

There is a bug in Qt which prevents a QImage from being transformed
smoothly. See a comment in KisQImagePyramid::appendPyramidLevel.

Allan Anderson committed changes in [kmymoney] /plugins/csvimport:

Fix problem with CSV Importer table widget window height becoming erratic after several window resizes.

Dmitry Kazakov committed changes in [calligra] krita/plugins/paintops/libpaintop/kis_embedded_pattern_manager.cpp:

Do not overwrite the embedded pattern when it is the same

Well, doing the same work again and again is not a good idea :)
Now we just check whether the two md5 sums coincide and whether
there is at least some data present in the embedded pattern field.
If it is true, just skip saving. This fixes the Shift-gesture brush
scaling for some brush presents.

Thank Mifth for reporting this bug!

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/ui/tool/kis_tool.cc:

Fix the wrong color being set up when pressing 'D' shortcut

Some of color selectors do not differentiate foreground
and background colors, so if one wants them to end up
being set up to foreground color, it should be set the
last.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_simple.cpp:

Fixed the last non-inverted Y-axis in Advanced Color Selector

It caused the selector jump to random values.

Boudewijn Rempt committed changes in [calligra] krita/ui/widgets/kis_floating_message.cpp:

Correctly place floating message over the canvas

Dmitry Kazakov committed changes in [calligra] krita/ui/canvas/kis_canvas2.cpp:

Fix the crash when changing the canvas type while Transform Tool active

Dmitry Kazakov committed changes in [calligra] krita/plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp:

Make Transform Tool support Shape and other external layers

Dmitry Kazakov committed changes in [calligra] /plugins/extensions/dockers/overview:

Fixed a drastic performance blow caused by Overview Docker

When working on 32-bit images the creation of the preview is quite an
expensive operation, so we needed to do it a bit more rarely. The
situation was worsened by the fact that the docker was generating
a preview event when it was hidden, and in this hidden state its size
was "implementation defined", which might be 1000+ pixels in some cases.

The patch also fixes various small bugs of the docker, like garbage when
resizing it.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /plugins/extensions/dockers/advancedcolorselector:

Make the Color Selector Color Preview widget a ToolTip widget

Any PopUp window is a modal which is not what we want, because then
no other widget will get the events. Previously, the problem was solved
by explicitly forwarding events to the parent.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/image/commands/kis_image_layer_remove_command.cpp:
Dmitry Kazakov committed changes in [calligra] /image:

Fix speed regression when painting in BuildUp mode on a Transparent Layer with a Transparency Mask

The KisSelectionDefaultBounds should not call exactBounds() every time,
since it would result in constant boudns recalculation when the user
paints in BuildUp mode (which is always the case for ColorSmudgeOp).

Thomas Baumgart committed changes in [kmymoney] /dialogs:

Fix precision of price returned from price entry dialog

The returned price was truncated by the global price precision which
could cause all kinds of trouble when an amount was entered but the
price precision was not large enough to yield the same result in the
equation result = amount / price * price;

Now the price is returned without precision loss in case it is based
on an amount (method is selected by the user in the dialog). In the
case the price is entered it is returned with the global price
precision in effect.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /plugins/paintops/libbrush:

Fix smooth rotation of the Predefined Brushes

There is a bug in Qt which prevents a QImage from being transformed
smoothly. See a comment in KisQImagePyramid::appendPyramidLevel.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /:

Remove an assert when switching a tool while doing a stroke

Well, using macro for this purpose might be a bit ugly, but this is the
best thing we can do until we invent some strategy-based event handling
for the tools.

Ideally, every tool should provide a set of strategies for each of the
action. Such strategy could be registered in the tool proxy on
KisTool::activate() and deregistered on KisTool::deactivate(). But we
are on a long way till that.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /image:

Fix invalidating the outline cache when loading the selection from a file

Networking Tools

David Edmundson committed changes in [ktp-kded-module/kde-telepathy-0.7] contact-request-handler.cpp:

Block contacts when denying requests

This prevents them from reappearing


REVIEW: 114671
FIXED-IN: 0.7.1

User Interface

Alex Fiestas committed changes in [user-manager] src/accountinfo.cpp:

Do not allow to change the username

When the username is changed, the user is actually
removed and added again, this can couse many issues
so it is better if for the time being we do not allow
canging the username.

Alex Fiestas committed changes in [user-manager] src/passworddialog.cpp:

Reset KDialog::Ok to false on each checkPassword

Utilities

Volkan Gezer committed changes in [muon] /:

Fix two bugs regarding to multiple selection

This patch should solve issues related to multiple selection:
Solves right click issue when only one item status has changed and
disables install/remove button on DetailsWidget when multiple selection
is made since this button only installs one of the selections and causes
confusions.



CC
CC

REVIEW: 114630

Michel Ludwig committed changes in [kile] src/parser/latexparser.cpp:

Improve the recognition of Beamer frame titles

Also parse \begin{frame}{<frame title>}...\end{frame} correctly.

Patch by Yngve Inntjore Levinsen.

Games

Alexander Schuch committed changes in [konquest] minimapview.h:

Properly check for a valid selection in minimap.

Changing the dimensions of the map in game setup dialogue recreates the
game board. The sector selection is kept. However, the selection might
become invalid if the game board shrinks and the selection is not on the
board anymore. Adding a new player to the game will then result in
checking a sector outside the game board (NULL is returned), so that
a method is invoked on a NULL pointer, leading to a crash - see
NewGameDlg::slotNewOwner().

This is implemented in Konquest 2.1.


FIXED-IN: 4.11.5
(cherry picked from commit 238c8f3f12c84107be9095e63b135e8c94786f00)

Ian Wadham committed changes in [palapeli/KDE/4.11] /:

Fix 'Restart puzzle' action: enable it only in puzzle mode.

Features

Development Tools

Joris Steyn committed changes in [umbrello] /:

Show only menu actions applicable for selection

When multiple widgets are selected, a context menu is shown containing only the
actions that work on the whole selection.

The old implementation had a few features like changing the "show" options
on a classifier for multiple selected widgets and bulk-change classifiers to
interfaces. That code is removed now since it wasn't used in the first place
and it's problematic in both implementation and user interface.

Additional improvements:
* fix bug where fonts and colors sometimes wont apply
* fix bug where right-click on an unselected widget does not select the widget
* allow cloning multiple widgets
* remove double keyboard shortcuts for delete action

Also, checkable menu items should not be used in the context menu of multiple
widgets. There's no sane initial value if the widgets are set to a different
value. The only nice way to handle this is have one menu item for setting the option
and one for unsetting. This is done for the "Use fill color" checkbox.

Joris Steyn committed changes in [umbrello] /:

Undo stack and visual properties improvements

The multi-widget context menu allows setting visual properties ("Show") for a
selection. Unlike the previous "toggle" behaviour it is now possible to (for
example) hide all operations with one menu action.

Also fixed:
* applying the properties dialog without changes added a few undo commands to the stack
* the "Delete" shortcut is renamed to "Delete Diagram" because that is what it does
* mixed capitalization cmd/Cmd, is now always "Cmd"
* changes to the following widget options are now tracked in the undo stack:
** visual properties
** use fill color
** line width
** font

Christoph Thielecke committed changes in [kdev-cppcheck] /:

- group by severity added

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 6eabaef...

Educational

Filipe Saraiva committed changes in [cantor] /backends/python2:

Script extension support for Python2 backend

Diffs: 1, 2, 3 Revision 12df497...
Illya Kovalevskyy committed changes in [marble] /:

Support for nautical miles added (as a measurement sys.)

Nautical miles are introduced and implementation adjusted to the codebase.

REVIEW: 114156

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 13 more) Revision a88b7a6...
Illya Kovalevskyy committed changes in [marble] /:

Showing the Moon in the Stars plug-in

StarsPlugin is showing the Moon (custom Moon pixmap without phases stuff), which is customizable with Stars' preferences.

REVIEW: 114680

Diffs: 1, 2, 3, 4, 5 Revision e2e84ca...

Graphics

Teemu Rytilahti committed changes in [digikam] /:

- Use KUrl and make sure that the folder has a trailing slash. Otherwise call to setFileName() causes the end of the path to be removed and breaking the URLs for history.
- When listing files, request the status from history database for the current state.
- Also use only model and path information for PTP cameras, as port number changes on the fly, therefore breaking the hashes. Unfortunately this means that the old download history for PTP devices is lost.
- Use DownloadedNo to indicate "new" photos for the time being.


FIXED-IN:4.0.0

Marcel Wiesweg committed changes in [digikam] /:

- add a shutdown method to FacePipeline which provides the cancel + wait necessary at shutdown
- add a benchmark mode for recognition. (Note: this mode is not valid for the current LBPH-nearest-neighbor
method as it benchmarks recognition on the faces which were used for training)
- modify re-recognition so that unconfirmed results are overwritten by "not detected status, which can be
more valid

Diffs: 1, 2, 3, 4, 5, 6 Revision ff387d0...

KDE Base

Martin Gräßlin committed changes in [kde-workspace] /effects:

[kwin/effects] Add links to effect videos

Videos for the following effects are added:
* Dim Inactive
* Dim Screen for Administration Mode
* Invert
* Looking Glass
* Magnifier
* Mouse Click
* Track Mouse
* Zoom

Link for Present Windows video fixed.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 1 more) Revision 6733276...
Michal Humpula committed changes in [kate/frameworks] /:

add posibility to change swap file location

REVIEW: 114229

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Start a new app to manage storage service

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 396c12c...
Laurent Montel committed changes in [kdepim] /notesagent:

Start to implement modify alarm

Office

Allan Anderson committed changes in [kmymoney] /plugins/csvimport:

- Add category and subcategory into csv import.
Also, fix inabilty to import last line of CSV file if it has no return character.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] /ui:

Allow painting when no shortcuts have passed to current combination of keys

This patch does two things:
1) Changes the formula of the priority in the way that the
shortcuts with left mouse button would have higher priority
than ones with middle and right one
2) Add a tag to KisAbstractInputAction::canIgnoreModifiers(), which
shows that the action can be run with any particular modifier
(the default action).

Filipe Saraiva committed changes in [cantor] /backends/scilab:

Script extension support for Scilab backend

Diffs: 1, 2, 3 Revision d0802c8...
Allan Anderson committed changes in [kmymoney] kmymoney/dialogs/investtransactioneditor.cpp:

- Enable creating a new security when adding or editing a transaction.

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/plugins/tools/tool_crop/kis_tool_crop.cc:

Make Crop Tool handle Shift modifier to fix Aspect Ratio

Multimedia

Christian Esken committed changes in [kmix] /:

Add kmixremote, to conveniently access important KMix DBUS calls like device name listing, muting and volume changes.
This also acts as a reference for people who want to do KMix scripting.

Optimization

Educational

Albert Astals Cid committed changes in [kalzium/KDE/4.12] /:

Update min and max value at the same time in order to be more friendly with typing in the min/max box

REVIEW: 114006

This patch makes the behavior while typing in the min/max boxes more friendly.

Currently if one types in the maximum value box, the minimum value will stuck at a small value due to the small value in the maximum value box before one finish typing. (I don't really call this a bug, but I think it is not friendly.)

This patch tries to update both the maximum and minimum values whenever one of them changes (in the right order to always respect the one that changes) so that the actual range displayed is always the closed possible to the input values. It also covers the cases when min/max values change from illegal values to legal values (max > min) in some other ways.

Diffs: 1, 2, 3 Revision f077888...

KDE Base

Marco Martin committed changes in [kde-workspace] /desktop/toolboxes/desktoptoolbox/contents/ui:

make the toolbox menu appear on demand

should givea slight help to startup time and average memory usage

Diffs: 1, 2, 3, 4, 5 Revision 0fe7c76...

KDE-PIM

Sergio Luis Martins committed changes in [kdepimlibs] /calendar:

Allow to share EntityTreeModel between several ETMCalendars.

This will be a big memory improvement for kontact.
Korganizer and kontact's summary view use different ETMCalendars
because they need different collection selections, this results
into all incidences being duplicated in memory.

Now it will be possible to have two ETMCalendars, with different
collection selections, using the same EntityTreeModel.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 30b6103...

Office

Dmitry Kazakov committed changes in [calligra] /:

Improved usablility of the Shade Selector line configuration

It was really inobvious how to use this configuration dialog,
because clicking on it just close it, but changing the values
of spin boxes, didn't automatically applied these values.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 106c193...

Other

Educational

Illya Kovalevskyy committed changes in [marble] data/placemarks/moonlandingsites.kml:

Update moon landing sites to include Chang'e 3 mission

Moon landing sites are extended with successful Chang'e 3 chineeze soft landing on Moon. Cache file has been adjusted

REVIEW: 114568

M +- -- data/placemarks/moonlandingsites.cache

KDE Base

Alex Turbov committed changes in [kate] /kate/pate/src/plugins/expand:

One more big refactoring of the `expand` plugin:
* structure the code to incrase reuse-ability and read-ability
* introduce dynamic expands! huh, need to write some blog entry about
this cool feature... sometime... someday...
* fine tune and improve some templates (to be reusable)

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision d952ffd...