Issue 322

12th January 2014 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Alex Fikl
Giacomo Barazzetti

This Week...

KDM has been removed. KDE-PIM improves the attachment editor: better ability to switch between inline and linked attachments, allows undo/redo archive mail. Skrooge adds options in "Income & Expenditure" dashboard widget. Nepomuk adds Baloo migrator. KGeography porting to KF5 in progress. Bug fixes in KDevelop and more.

Statistics

Commits 1868 by 165 developers
Open Bugs 21255
Open Wishes 15934
Bugs Opened 219 in the last 7 days
Bugs Closed 234 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
203
 
/branches/stable
94
 
/trunk/l10n-support
68
 
/trunk/www
51
 
/krita/ui
20
 
/plasma/generic
13
 
/effects/backgroundcontrast
10
 
/src/declarativeimports
10
 
/plasma/qmlpackages
9
 
/kwin/effects
9
 
Files Developer Commits
453
 
Laurent Montel
158
 
210
 
Alex Merry
70
 
156
 
Hugo Pereira Da Costa
62
 
186
 
Boudewijn Rempt
62
 
147
 
Burkhard Lück
51
 
144
 
Dmitry Kazakov
48
 
111
 
Albert Astals Cid
42
 
117
 
Vishesh Handa
39
 
105
 
David Faure
36
 
99
 
Sebastian Kügler
36
 

Internationalization (i18n) Status

Language Percentage Complete
German (de)
99%
 
French (fr)
98%
 
Dutch (nl)
97%
 
Estonian (et)
92%
 
Galician (gl)
91%
 
Italian (it)
90%
 
Danish (da)
89%
 
Hungarian (hu)
87%
 
Catalan (ca)
86%
 
Chinese Traditional (zh_TW)
83%
 

Bug Killers

Person Bugs Closed
Jekyll Wu
31
 
Christoph Feck
22
 
Hugo Pereira Da Costa
19
 
Martin Gräßlin
18
 
Boudewijn Rempt
12
 
Dmitry Kazakov
11
 
philippe roubach free fr
11
 
Michal Humpula
10
 
Albert Astals Cid
9
 
Myriam Schweingruber
8
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

[]   []   

Educational

     []

Graphics

[]     

KDE Base

[] [] []   []

KDE-PIM

[] []    []

Office

[] [] []   []

Konqueror

     

Multimedia

[]     

Networking Tools

     

User Interface

[]     

Utilities

     

Games

  []    

Other

[]     

There are 50 selections this week

Bug Fixes

Development Tools

Milian Wolff committed changes in [kdev-clang] /:

Fix deadlock while parsing projects with deep include trees.

This complicates the code quite a bit, but I could not come up
with anything simpler.

We create a sorted list of includes by depth and traverse that
in a depth-first manner. Furthermore we remember what files are
imported in which files and ensure that these imports are available
when parsing a file as otherwise include guards and cyclic references
would break or lead to infinite recursions.

For every file or import we set the UrlParseLock and check whether
the DUChain information is up to date. If not, we traverse the whole
translation unit and look for any declarations that belong to the
current file.

This ensures we never nest the UrlParseLocks and thus should not
deadlock anymore.

Diffs: 1, 2, 3, 4, 5, 6 Revision 9aae316...
Josef Weidendorfer committed changes in [kcachegrind/KDE/4.12] libcore/costitem.cpp:

Fix: Do not crash on functions with call count 0.

Cherry-picked from master.


Call count 0 may exist with Callgrind when measuring starts after
the function was called but when the function is still active,
ie. not returned yet. For "cost per call", it makes sense to show
the full cost while the function was active.

Milian Wolff committed changes in [kdev-clang] duchain/contextbuilder.h:

Optimize: Don't put DUContext::Other contexts into the symbol table.

This is inherited by the declarations in these contexts which is
good as we don't want to pollute the costly global symbol table with
local declarations.

Vlas Puhov committed changes in [kdevelop] /gdb:

Show locations for all breakpoints even if they have neither
file nor line information.

Otherwise we'll be showing valid breakpoints with empty locations. Also
these breakpoints now'll be automatically inserted on debugger's restarts.

Vlas Puhov committed changes in [kdevelop] /gdb:

Don't insert the same breakpoint multiple times while starting. Part 2.

First compare "fullname" and "line" entries and only if it fails fall
back to "original-location", as the latter can contaion literally
anything. Note that even a better solution'd be to store a full path
in the first place (if available).

Graphics

Albert Astals Cid committed changes in [okular/KDE/4.12] core/document.cpp:

Do not resetSearch if we're closing down

It's useless as it will be reset anyway on the close down procedure
and it will cause a crash if you are unlucky.

Reason:
* In the document observers qset pageview comes before
* We are closing and notifySetup with an empty vector
* pageview empties its vector in notifySetip
* part sees the notifySetup and resets the search
* resetting the search calls another notifySetup with the non empty page vector
that will be deleted asap when we go back to the first notifySetup

There are another billion ways to fix this:
* Don't allow nested notifySetup
* Clear the running searches before sending the first notifySetup
* Empty the pagesVector before sending the first notifySetup
* etc

But i feel this is the less invasive one (even if it may not be the most technically correct)


FIXED-IN: 4.12.1

Kåre Särs committed changes in [libksane] libksane/ksane_widget_private.cpp:

Fix preview size for some backends

Some backends don't return data until everything is scanned.

Gilles Caulier committed changes in [digikam] /:

handle update file timestamp option from Setup/Metadata when file are changed outside metadata, as transformation through icon-view (JPEG files) or when
files are overwritten from Image Editor. BQM already manage this option properly. Import tool is not affected by this settings (as import or export file always preserve file timestamps)
Toogle on option from Setup/Metadata config pannel to on, to prevent all dysfunctions with extra application which use file timestamps to detect automatically file modifications.

FIXED-IN: 4.0.0

KDE Base

Frank Reininghaus committed changes in [kio] /:

Make KFileItemActions the parent of the actions it creates

This prevents the problem that the destructor of KFileItemActions may
delete dangling pointers if the widget that is set with setParentWidget
is destroyed before the KFileItemActions instance (note that this widget
was the parent of the actions before this commit, but that
KFileItemActions stll remembered them in d->m_ownActions and deleted
them in the destructor.)

REVIEW: 114921

Diffs: 1, 2, 3, 4 Revision 7a1543f...
Michal Humpula committed changes in [kate] /:

make killline work with current selection too

REVIEW: 114968

FIXED-IN: 4.13

David Edmundson committed changes in [kde-workspace] /qmlpackages/desktop/contents/explorer:

Adjust all WidgetExplorer animations to be cleaner

Fixes a bug where items would reappear slightly when exiting the view
Also tidies up objects moving around when items are inserted.

REVIEW: 114913

Frank Reininghaus committed changes in [kde-baseapps/KDE/4.12] /src/panels/information:

Kill any running preview jobs before starting a new one

If loading a preview takes long, it was possible before this commit
that a preview for a new item was requested before the first preview
was shown. In that case, there was a race condition, and the first
preview to arrive stayed in the Information Panel.

This commit fixes this by keeping a pointer to the preview job and
killing it before starting a new one.


FIXED-IN: 4.12.1
REVIEW: 114561

KDE-PIM

Albert Vaca Cintora committed changes in [kdeconnect-android] src/main/java/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java:

We will only sync actual notifications from now on

Michael Zanetti committed changes in [kopete] plugins/otr/otrlchatinterface.cpp:

Workaround issue in libotr 4.0.0.

This still has an issue with fragmentation as long as libotr 4.0.1 is
not released, but at least it doesn't crash.

Office

Dmitry Kazakov committed changes in [calligra] krita/ui/kis_paintop_box.cc:

Make the height of the Preset Chooser Popup 600px

This value is consistent with the height of the PaintOp configuration
popup.

Thanks David Revoy for suggestion!

Jarosław Staniek committed changes in [calligra] kexi/plugins/forms/widgets/kexidbcombobox.cpp:

Make text in form combo box not trimmed


FIXED-IN:2.8

Dmitry Kazakov committed changes in [calligra] krita/ui/tool/kis_painting_information_builder.cpp:

Fix the outline size in hover mode


In hover mode the pressure must be emulated to be 1.0, otherwise
we will not see anything.

Dmitry Kazakov committed changes in [calligra] /:

Probably fix the Ascension sensor in Hover mode

This patch passes the real tablet event to the outline generator
in hovering mode, so if your tablet supports rotational sensors it
the outline will be generated accordingly.

Please someone test it with a proper Tablet Device.

Dmitry Kazakov committed changes in [calligra] /:

Fix Color Smudge op in Dulling mode

We must not store reading random accessors when someone else in writing to
the same device, because the cache of the random accessor will become
outdated.

Dmitry Kazakov committed changes in [calligra] libs/flake/KoShapeStroke.cpp:

Fix calculation of the shape's insets when it has Miter joining

The insets should be not smaller than the limit of the Miter joining


REVIEW:114890

Dmitry Kazakov committed changes in [calligra/calligra/2.8] krita/image/kis_paint_layer.cc:

Fix the initialization of the default bounds of the Paint Layer

I don't know why the line was commented out :(

Boudewijn Rempt committed changes in [calligra] /:

Don't show an error when autosave fails in Krita

We'll retry it later again, since we cannot save if the image is locked,
so don't worry the user with alarming messages.

Boudewijn Rempt committed changes in [calligra] /ui/canvas:

On doing a full prescale, clear the projection image first.

Boudewijn Rempt committed changes in [calligra] /ui:

Disregard opacity with fg/bg fill

Bucket fill still uses the currently set opacity, but the shortcuts to
fill the entire layer with background or foreground colors should not
use the global opacity.

Multimedia

Sujith Haridasan committed changes in [plasma-mediacenter] /:

Fixing playing of files from command line or by any other means.

PMC was failing to play the songs which were passed from the command line.
It was playing the songs from the current playlist. With this patch it
rectifies the issue.

REVIEW: 114892

Signed-off-by: Sujith Haridasan

Diffs: 1, 2, 3, 4, 5, 6 Revision 8e1e82f...

User Interface

Hugo Pereira Da Costa committed changes in [oxygen-gtk/1.4] src/oxygenapplicationname.cpp:

Check both pid and gtk app name to identify XUL applications

Other

Andrea Iacovitti committed changes in [khtml] /rendering:

Also check for a non zero length text here.
The QChar* pointer could be not null but pointing to the single char '\0'
due to how DOMStringImpl is implemented.


FIXED-IN: 4.11.5

(Forward-port kdelibs commit e71c6b7b97c80afa284b854734b0a7d35868e093)

Features

KDE Base

Andreas Schneider committed changes in [kde-runtime] /:

kio_sftp: Support ECDSA keys.

This migrates to the API of libssh 0.6.0.

Sebastian Trueg committed changes in [nepomuktvnamer] /:

Added a nepomukcleaner job for removing duplicate series.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision be52fb2...
Vishesh Handa committed changes in [nepomuk-core] /:

Add an optional Baloo migrator

Diffs: 1, 2, 3, 4, 5 Revision a82c0ab...
Vishesh Handa committed changes in [baloo-widgets] /:

FileMetaDataWidget: Hookup the tags, ratings and comments

Kurt Hindenburg committed changes in [konsole] /:

Add xterm's bracketed paste mode

Allow xterm's bracketed paste mode to work

When enabled by '\e[?2004h', pasted data is surrounded by \e[200~ and
\e[201~. This is mainly for text editors to temporarily switch off
autoindent and line wrapping.

KDE-PIM

Laurent Montel committed changes in [kdepim] /:

Allow to undo/redo archive mail

Diffs: 1, 2, 3, 4, 5 Revision 8c74a53...
Allen Winter committed changes in [kdepim] /:

improvements to the attachment editor.
better ability to switch between inline and linked attachments


FIXED-IN: 4.12.1

Albert Vaca Cintora committed changes in [kdeconnect-android] /:

first draft SFTP implementation

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision 13a7c1e...

Office

Dmitry Kazakov committed changes in [calligra] /plugins/paintops/experiment:

Add support for nonzero fill rule for experiment brush

Thanks David Gowers for preparing this patch!

Boudewijn Rempt committed changes in [calligra] /:

Add a margin to KisGradientSlider

So the full triangles are shown at the edges

Stephane Mankowski committed changes in [skrooge] /:

feature: More option in "Income & Expenditure" dashboard widget

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 2 more) Revision 559bb8f...
Dmitry Kazakov committed changes in [calligra] /:

Added two triangular cursors for the painting

(it also adds two outline-enabled counterparts)

Games

Roney Gomes committed changes in [knavalbattle] src/battlefieldview.cpp:

Play fade-in animation to show enemy ships after a defeat.

If the player has lost the game, then oponnent ships will appear in a
nice fade-in animation in the battlefield.

REVIEW: 114840

Optimization

Development Tools

Milian Wolff committed changes in [kdev-clang] /:

Optimize: Skip function bodies when looking for visible decls only.

This decreases the parse time of my test project by ca. 25% from
~13s to ~10s. It is only applicable to VisibleDeclarationsAndContexts
or less features, but that is the default for project files anyways.

Diffs: 1, 2, 3 Revision 1f78e94...

KDE Base

Simeon Bird committed changes in [baloo] /file:

Refactor slotScheduleIndexing to make it clearer when each queue runs.

Along the way, fix a couple of odd edge cases:
1. The file queue would sometimes not be started correctly
2. The cleaner would stop when going onto battery, but if we
were already on battery when starting, it would still be started.
Change this so the cleaner runs even when on battery.

Also make some adjustments to the index cleaner so that it works when
resumed: these are only necessary because it is not yet implemented.

Diffs: 1, 2, 3 Revision 86d8f85...

Office

Boudewijn Rempt committed changes in [calligra] krita/plugins/extensions/dockers/specificcolorselector/kis_specific_color_selector_widget.cc:

Other

Educational

David Gil Oliva committed changes in [kgeography/frameworks] /:

First step to port to KF5

It builds and it works fairly well. But:
--There still are some KDE4 classes to port away from.
--Some toolbar buttons don't show up.

REVIEW: 114581

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 15 more) Revision 1b7772f...

KDE Base

Sebastian Kügler committed changes in [kde-workspace] /:

KDM goes the way of the Dodo.

It's exactly, to the day, 6 years ago that we released "KDE 4.0", while
this is of course entirely unrelated to this commit, let's celebrate
this anniversary with the deletion of kdm from kde-workspace.

Happy anniversary from Barcelona!

The Plasma Team

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 220 more) Revision 8577abf...
David Edmundson committed changes in [plasma-framework] /shell:

Move WidgetExplorer to be a private QML plugin

Instead of registering WidgetExplorer inside the shell, create a new qml
plugin in the org.kde.plasma.private namespace.

This is useful for running widgetexplorer in qmlscene.

This makes testing, debugging and profiling considerably easier.

REVIEW: 114914

Diffs: 1, 2, 3, 4, 5, 6 Revision 3e599d3...
Wolfgang Bauer committed changes in [kde-workspace/KDE/4.11] ksmserver/screenlocker/ksldapp.cpp:

Screenlocker: don't set the mouse cursor when grabbing the mouse

Setting the cursor to ArrowCursor when calling XGrabPointer() prevents
the Screen savers from blanking the mouse cursor.
With this change they can blank the mouse cursor again.



FIXED-IN: 4.11.6
REVIEW: 114841

KDE-PIM

Albert Vaca Cintora committed changes in [kdeconnect-android] src/main/java/org/kde/kdeconnect/Helpers/ContactsHelper.java:

Phone number shown next to contact name for calls/sms

Kevin Ottens committed changes in [zanshin] /:

Add a new Domain module containing the Artifact class

This marks the start of hopefully the right redesign of Zanshin. It will
be the last one, I swear.

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 162f286...

Office

Allan Anderson committed changes in [kmymoney] kmymoney/converter/mymoneystatementreader.cpp:

- Reinstate code from "Add VAT split to file import", inadvertently removed by this change.