Issue 275

17th February 2013 by KDE Commit-Digest Team

Contributors

Marta Rybczynska
Jürgen Appel
Michael Torres

This Week...

Amarok supports Opus codec with recent TagLib. Scripted effects and KWin scripts get a config interface; KWin improves multihead situation; Screenshot effect ported to XCB. Rekonq restores Bookmarks menu (in 2.x fashion). Calligra improves mobi and epub filter support. Bug fixes in Amarok, Network Management, Kdenlive.

Statistics

Commits 3138 by 175 developers
Open Bugs 21256
Open Wishes 15844
Bugs Opened 431 in the last 7 days
Bugs Closed 443 in the last 7 days

Commit Summary

Module Commits
/trunk/l10n-kde4
320
 
/branches/stable
167
 
/trunk/l10n-support
66
 
/src/lib
22
 
/trunk/www
22
 
/src/usermanager.cpp
20
 
/libmuon/backends
14
 
/src/customtrackview.cpp
12
 
/trunk/playground
11
 
/threadweaver/src
10
 
Files Developer Commits
282
 
Laurent Montel
111
 
306
 
Alex Fiestas
105
 
309
 
Roman Paholík
103
 
270
 
Jean-Baptiste Mardelle
90
 
258
 
Aleix Pol Gonzalez
87
 
246
 
Marco Martin
83
 
225
 
Gilles Caulier
79
 
219
 
Chetan Khona
73
 
207
 
Sebastian Kügler
69
 
117
 
David Edmundson
47
 

Internationalization (i18n) Status

Language Percentage Complete
Portuguese (pt)
100%
 
Estonian (et)
98%
 
Dutch (nl)
97%
 
Polish (pl)
97%
 
German (de)
96%
 
French (fr)
95%
 
Italian (it)
92%
 
Galician (gl)
92%
 
Danish (da)
89%
 
Greek (el)
86%
 

Bug Killers

Person Bugs Closed
Tom Albers
67
 
Myriam Schweingruber
44
 
Jekyll Wu
33
 
Christoph Feck
32
 
Jonathan Thomas
15
 
Thomas Lübking
13
 
David Faure
12
 
Dawit Alemayehu
12
 
Laurent Montel
11
 
Oliver Henshaw
10
 

Commit Countries

Commit Demographics

Sex

Age

Contents

  Bug Fixes Features Optimization Security Other

Accessibility

     

Development Tools

  []    

Educational

     

Graphics

[]   []   

KDE Base

[] []    []

KDE-PIM

[]     

Office

[] []    []

Konqueror

     

Multimedia

[] []    

Networking Tools

[] []    []

User Interface

     

Utilities

[] []    

Games

     []

Other

     

There are 41 selections this week

Bug Fixes

Graphics

Michael Georg Hansen committed changes in [digikam] digikam/views/mapwidgetview.cpp:

Fix crash of map view in image import on images without coordinates.

KDE Base

Kåre Särs committed changes in [kate] /view:

Fix minimap dragging with QtCurve.
Translate minimap-sliders y-coordinates to standard coordinates on small files.


FIXED-IN 4.10.1

Martin Gräßlin committed changes in [kde-workspace/KDE/4.10] kwin/scripts/desktopchangeosd/contents/ui/main.qml:

Fix layout issues of Desktop Change OSD

* no more binding loops - yeah for anchoring
* properly update sizes when switching screens
* properly handle case layout indicator enabled/disabled
* connect to desktop changed and reset desktop model
* set a maximum width/height of 0.8 of screen

Most interesting change is the moving of
visible = true;
to the beginning of the block which updates the layout. Without that
all the changes are ignored resulting in the incorrect size on screen
change.

The disadvantage of that is that the OSD is shown before the layout is
adjusted. But it's considerable minor given that it should be just one
frame.




FIXED-IN: 4.10.1
REVIEW: 108945

Thomas Lübking committed changes in [kde-workspace] /:

improve multihead situation

prevents the focus being passed to the other head
manages OpenGLIsUnsafe setting per head



REVIEW: 107853
FIXED-IN: 4.11

KDE-PIM

Martin Koller committed changes in [kdepim/KDE/4.10] kmail/kmkernel.cpp:

fix character encoding for body in composer window on cmdline usage

assemble message before it is passed to the composer window,
which makes sure that also the ContentType header is used
which contains the charset.

FIXED-IN: 4.10.1
REVIEW: 108884

Laurent Montel committed changes in [kdepimlibs/KDE/4.10] kpimutils/linklocator.cpp:

Start to fix Bug 313719 - A URL followed by a ) is parsed incorrectly in message viewer

now when we have just (http://www.kde.org) it's parsed correctly

will continue to look at specific bug when detect url

Laurent Montel committed changes in [kdepimlibs/KDE/4.10] akonadi/firstrun.cpp:

Fix Bug 315115 - Akonadi Firstrun doesn't work

Apply patch from Wolfgang Bauer

Thanks a lot.


FIXED-IN: 4.10.1

Office

Sven Langkamp committed changes in [calligra] /ui:

fix crash on saving an empty image

Diffs: 1, 2, 3, 4, 5, 6 Revision 3de738f...
Mojtaba Shahi committed changes in [calligra] /words:

Fix mobi and epub filter problems (fix for crashes).
Fix algorithm mobi compression, Odt to html converter (handle tag bookmark) and extract external image problem.
REVIEW : 108925

Diffs: 1, 2, 3, 4, 5 Revision b8b6ff4...
Thorsten Zachmann committed changes in [calligra] /:

Fix memory leak in KoShapeContainer.

This fixes a big memoryleak resulting in quite a lot of shapes not getting
deleted when the document is deleted.

This also fixes crashes on shutdown currently seen in cstester in quite some
calligra words files.
Problem for the crashes is that some shapes and QTextDocuments while others
still trigger relayouting which uses the no longer deleted objects.

The patch fixes that by deleting the shapes and making sure there is no
relayout when the stuff is deleted.

Thanks for boud and boemann for the review. The problem boemann pointed out
has been fixed.

REVIEW: 108937

Diffs: 1, 2, 3, 4, 5, 6, 7 Revision 8d7e28c...

Multimedia

Sujith Haridasan committed changes in [plasma-mediacenter] /playlist:

Fixing the playlist scroll issue. Now the scrollbar will move up or down
according to the songs played in the playlist.

Ralf Engels committed changes in [amarok] src/core-impl/playlists/types/file/pls/PLSPlaylist.cpp:

Fix: Amarok crashes by putting a broadcast in the playlist


FIXED-IN: 2.8

Ralf Engels committed changes in [amarok] src/core-impl/collections/db/sql/SqlScanResultProcessor.cpp:

Fix: Amarok crashes on start if a playlist source is unavailable


FIXED-IN: 2.8

Ralf Engels committed changes in [amarok] /dialogs:

Fix: "Copy to Collection" window doesn't fit on small screens (1024x600)


FIXED-IN: 2.8

Ralf Engels committed changes in [amarok] /core-impl/collections/umscollection:

Fix: Copy/Move to collection picks up wrong destination path and fails silently


FIXED-IN: 2.8

Networking Tools

Lamarque Souza committed changes in [networkmanagement] /:

Fix crash when parsing IPv6 configuration from dbus.

Emmanuel Lepage Vallee committed changes in [sflphone-kde] /:

[ #20251 ] Try harder not to exit on the first error

Diffs: 1, 2, 3 Revision 8ae7919...
Andrea Diamantini committed changes in [rekonq] src/application.cpp:

Double check (event) filtered window && window list

Utilities

Jean-Baptiste Mardelle committed changes in [kdenlive/v0.9] src/utils/freesound.cpp:

Fix Coverity #980678

Features

Development Tools

Giorgos Tsiapaliwkas committed changes in [plasmate] plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp:

Plasmakconfigxteditor is now able to load/edit xml files
REVIEW: 108857

KDE Base

Christoph Feck committed changes in [kde-runtime/KDE/4.10] kcontrol/locale/kcmlocale.cpp:

Insert a separator after two most used page sizes

This visually groups those to better explain why they
are duplicated in the list of page sizes below


FIXED-IN: 4.10.1
REVIEW: 108661

Vishesh Handa committed changes in [nepomuk-core/feature/mergeGraphs] /storage:

DMM: Use a special 'nepomuk' graph to store certain properties

Each application contains its own graph. Similarly, there exists one
graph owned by 'nepomuk', which contains the following properties -

* nao:lastModified
* nao:created
* nie:url

This simplifies removal of resources, as these properties should ideally
never be removed. Also, they are technically managed by nepomuk and not
some other application.

Changed all the tests to reflect this change.

We also no longer check for trailing graphs as they might always be some
trailing graphs of some applications.

Diffs: 1, 2, 3, 4, 5 Revision 17374f6...
Jacopo De Simoi committed changes in [kde-workspace/KDE/4.10] /generic/runners/solid:

Cache device icon and description

Cache this information on creation, so that we do not access to
Solid::Device from the runner thread.
This gets rid of tons of warnings at runtime

Christoph Cullmann committed changes in [kate] part/syntax/data/latex.xml:

add patch for fancy syntax hl inside listings/minted, remember comment:

I adapted the LateX syntax highlighting to highlight source code included with the listings and minted environment with its native syntax.
The minor highlightning bug of the language specification being already highlighted as verbatim for the minted environment from commit 6aea10d62b6558a657c6385416c7d477ae67cba6 is also fixed.

Please see the attached tex file for examples.

Currently there are only two "foreign" languages supported, namely C++ and Python.
The reason for only two is that I have found no way to dynamically specify the language for IncludeRules, e. g.

<context name="Highlightning" attribute="Normal Text" lineEndContext="#stay" dynamic="true">
<IncludeRules context="HighlightningCommon"/>
<IncludeRules context="##%1"/> <!-- attribute dynamic does not exist-->
</context>
does not work. Would that be in principle possible?

So my current apporach is that I create two contexts and one rule for each supported language. Doing that for all kate supported languages would make the currently not-so-straightforward-to-read latex syntax file even longer.

Opinions?

Thanks for reading
Thomas

thanks to Thomas Braun

the dynamic contexts might be a good idea, but please file an extra bug for this

REVIEW: 107820

Martin Gräßlin committed changes in [kde-workspace] /effects:

Port Screenshot effect to XCB

This includes:
* getting cursor image through xcb_xfixes
* using xcb_image_get for reading screen content in xrender case
* using xcb_put_image to upload the generated screenshot into shared xpix

Overall this means that QPixmap as an X Pixmap wrapper is no longer used.
The conversion from xcb_image_t to QImage still needs some code for not
matching byte order. I'm a little bit unsure about adding the code as I
would not be able to test it.

REVIEW: 109076

Diffs: 1, 2, 3 Revision d593d6e...
Jekyll Wu committed changes in [kde-runtime] /:

Add basic checking for product status, component and version status

This comes as the initial preparation for preventing crashes from outdated
verions being reported to bugs.kde.org.

Martin Gräßlin committed changes in [kde-workspace] /:

Provide config interface for scripted effects and KWin scripts

A scripted component providing:
* ui/config.ui
* config/main.xml

can get a config interface by using the following in metadata.desktop:
X-KDE-ServiceTypes=KWin/Effect,KCModule
X-KDE-PluginKeyword=`X-KDE-PluginInfo-Name`
X-KDE-Library=kcm_kwin4_genericscripted
X-KDE-ParentComponents=`X-KDE-PluginInfo-Name`

`X-KDE-PluginInfo-Name` has to be replaced by the actual value. In case
of a KWin Script the X-KDE-ServiceTypes needs to be:
X-KDE-ServiceTypes=KWin/Script,KCModule

The GenericScriptedConfig tries to identify the package from the keyword
and creates a Plasma::ConfigLoader and loads the UI from the packaged UI
file.

Diffs: 1, 2, 3, 4 Revision ffa2148...

Office

Jean-Nicolas Artaud committed changes in [calligra/stage-designtool2-boemann] /:

Introduce the slide background widget.

Diffs: 1, 2, 3, 4, 5 Revision 05f8a3f...

Multimedia

Matěj Laitl committed changes in [amarok] /:

Add support for Opus files if compiled against TagLib > 1.8

FEATURES:
* Added support for files in Opus codec if Amarok is compiled against recent
enough TagLib (post 1.8). patch by Martin Brodbeck.


FIXED-IN: 2.8
REVIEW: 108542
DIGEST: Amarok now supports Opus codec with recent TagLib

Networking Tools

Andrea Diamantini committed changes in [rekonq] /:

Restores Bookmarks menu (in 2.x fashion)

Cleans up 1.x code about and create a unique bk menu to be shown in
rekonq tools menu, (eventually) in the toolbar and in (an ideal)
menubar

This work starts from Lindsay's review request about. Thanks :)

REVIEW: 108729

Diffs: 1, 2, 3, 4, 5, 6, 7, 8 Revision 036bd6c...
Andrea Diamantini committed changes in [rekonq] /:

Add zoom text only webkit feature settings

Piedro, because of your comment about Midori, I tried applying this.
I don't think this fixes your problem, but it surely "hides" the
bug ;)

Andrea Diamantini committed changes in [rekonq] src/searchengine.cpp:

Honor configuration for Web Shortcuts.

Rekonq will no longer ignore options "Enable Web shortcuts" and "Use
preferred shortcuts only".

This commit also removes the conditional compilation directives
introduced in commit 14e028 as rekonq 2.x now depends on 4.9.


REVIEW: 108902

Signed-off-by: Andrea Diamantini

Emmanuel Lepage Vallee committed changes in [sflphone-kde] /:

[ #20254 ] Add proper command line support, refactor main.cpp. It is now possible to place call from the command line

Diffs: 1, 2, 3, 4, 5, 6 Revision e60bfb6...

Utilities

Jonathan Michael Thomas committed changes in [muon] /:

Add a mechanism with which libmuon backends can gracefully report runtime errors during initialization.
This way we can silently discard e.g. the KNewStuff backends and not load them if the runtime kns config files are not present. (E.g. on a non-KDE system)

This failure mechanism allows us to fix the crash that happened when the KNS config file did not exist.

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9 Revision d1d1f0c...

Optimization

Graphics

Jesper Pedersen committed changes in [kphotoalbum/StreamReader] /:

cache String creations from utf8, latin1, and number. This gave a speed up of almost 10%

Diffs: 1, 2, 3, 4 Revision 044bbd4...
Jan Hambrecht committed changes in [gwenview] /:

Make advanced settings visibility of crop tool persistent.


REVIEW:108885

Other

KDE Base

Sebastian Kügler committed changes in [plasma-framework] /declarativeimports/core:

A whole bunch of types in PlasmaCore

This enables, ports where necessary, the rest of the DataEngine classes,
ServiceJob handling, and RunnerManager.

Now, more or less only Dialog and ToolTip are unported. Those will need
reimplementations for QtQuick2.

Diffs: 1, 2, 3 Revision 6c6acb9...
Jekyll Wu committed changes in [kde-runtime] drkonqi/aboutbugreportingdialog.cpp:

Encourage users to join the BugSquad team

It is more user frinedly to direct users to the techbase webpage for
BugSquad, which contains many helpful explantaion , than just saying
join the #kde-bugs IRC channel.

Office

Timothée Giet committed changes in [calligra] /:

Icons update for Kexi, Plan, Author and Braindump

New application icons for Kexi and Plan. Add a feather in Author icon. Enhance color contrast in Braindump icon.

M +- -- braindump/data/icons/hi1024-app-braindump.png
M +- -- braindump/data/icons/hi128-app-braindump.png
M +- -- braindump/data/icons/hi16-app-braindump.png
M +- -- braindump/data/icons/hi22-app-braindump.png
M +- -- braindump/data/icons/hi256-app-braindump.png
M +- -- braindump/data/icons/hi32-app-braindump.png
M +- -- braindump/data/icons/hi48-app-braindump.png
M +- -- braindump/data/icons/hi512-app-braindump.png
M +- -- braindump/data/icons/hi64-app-braindump.png
M +- -- braindump/data/icons/hisc-app-braindump.svgz
M +- -- kexi/pics/app/hi1024-app-calligrakexi.png
M +- -- kexi/pics/app/hi128-app-calligrakexi.png
M +- -- kexi/pics/app/hi16-app-calligrakexi.png
M +- -- kexi/pics/app/hi22-app-calligrakexi.png
M +- -- kexi/pics/app/hi256-app-calligrakexi.png
M +- -- kexi/pics/app/hi32-app-calligrakexi.png
M +- -- kexi/pics/app/hi48-app-calligrakexi.png
M +- -- kexi/pics/app/hi512-app-calligrakexi.png
M +- -- kexi/pics/app/hi64-app-calligrakexi.png
M +- -- kexi/pics/app/hisc-app-calligrakexi.svgz
M +- -- plan/pics/hi1024-app-calligraplan.png
M +- -- plan/pics/hi128-app-calligraplan.png
M +- -- plan/pics/hi16-app-calligraplan.png
M +- -- plan/pics/hi22-app-calligraplan.png
M +- -- plan/pics/hi256-app-calligraplan.png
M +- -- plan/pics/hi32-app-calligraplan.png
M +- -- plan/pics/hi48-app-calligraplan.png
M +- -- plan/pics/hi512-app-calligraplan.png
M +- -- plan/pics/hi64-app-calligraplan.png
M +- -- plan/pics/hisc-app-calligraplan.svgz
M +- -- words/pics/hi1024-app-calligraauthor.png
M +- -- words/pics/hi128-app-calligraauthor.png
M +- -- words/pics/hi16-app-calligraauthor.png
M +- -- words/pics/hi22-app-calligraauthor.png
M +- -- words/pics/hi256-app-calligraauthor.png
M +- -- words/pics/hi32-app-calligraauthor.png
M +- -- words/pics/hi48-app-calligraauthor.png
M +- -- words/pics/hi512-app-calligraauthor.png
M +- -- words/pics/hi64-app-calligraauthor.png
M +- -- words/pics/hisc-app-calligraauthor.svgz

Networking Tools

Dan Vratil committed changes in [telepathy-logger-qt] /:

Update to TpLogger 0.8.0 API

- add support for TplLogWalker API (introduced in Tpl 0.8.0)
- added missing supersedesToken() and supersedes() methods to Tpl::TextEvent
- bump TelepathyLogger dependency to 0.8.0
- bump TelepathyLoggerQt4 version to 0.7.95

As of now TelepathyLoggerQt4 will use versioning scheme and release cycle of
TelepathyLogger, instead of KTp.

REVIEW: 108794

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 5 more) Revision 83f76d9...

Games

Dmitry Vladimirovich Chernov committed changes in /trunk/playground/games/backgammon:

huge refactoring

Diffs: 1, 2, 3, 4, 5, 6, 7, 8, 9, 10 (+ 4 more) Revision 1339933